Change in vdsm[master]: virt: common handling of exceptions
Nir Soffer has posted comments on this change. Change subject: virt: common handling of exceptions .. Patch Set 14: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: common handling of exceptions
gerrit-hooks has posted comments on this change. Change subject: virt: common handling of exceptions .. Patch Set 14: * #1316128::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1316128::OK, public bug * Check Product::#1316128::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: use the new response handling
gerrit-hooks has posted comments on this change. Change subject: vm: use the new response handling .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: use the new response handling
Francesco Romani has posted comments on this change. Change subject: vm: use the new response handling .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/54799/8//COMMIT_MSG Commit Message: Line 6: Line 7: vm: use the new response handling Line 8: Line 9: Let's start using the new api.method Line 10: decoratore to handle exceptions and response > decorator Thanks, fixed Line 11: from few methods already in need of some Line 12: refactoring and cleanup. Line 13: Line 14: Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b Line 8: Line 9: Let's start using the new api.method Line 10: decoratore to handle exceptions and response Line 11: from few methods already in need of some Line 12: refactoring and cleanup. > So this changes random apis? Why not wrap all apis? Not random: I'm starting from the APIs which most need a cleanup. I agree we must do transition, but I'll like to do in a small steps, to make things easily testable Line 13: Line 14: Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b -- To view, visit https://gerrit.ovirt.org/54799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: common handling of exceptions
Francesco Romani has posted comments on this change.
Change subject: virt: common handling of exceptions
..
Patch Set 13:
(3 comments)
https://gerrit.ovirt.org/#/c/54664/13/lib/vdsm/virt/api.py
File lib/vdsm/virt/api.py:
Line 31:
Line 32: def method(func):
Line 33: """
Line 34: Decorate an instance method, and return a response according to the
Line 35: outcome of the call.
> Can you separate paragraphs with empty line?
Done
Line 36: If the method returns None, return a plain success response.
Line 37: If the method wants to augment the success response, it could
return
Line 38: a dict. The dict items will be added to the success response.
Line 39: The method could override the success response message this way.
https://gerrit.ovirt.org/#/c/54664/13/tests/virt_api_test.py
File tests/virt_api_test.py:
Line 46: vmId = 'bar'
Line 47: res = self.vm.succeed_with_args('vmName', vmName, 'vmId', vmId)
Line 48: self.assertEquals(response.is_error(res), False)
Line 49: self.assertEquals(res['args'][0], 'vmName')
Line 50: self.assertEquals(res['args'][1], vmName)
> We can simplify this to:
Done
Line 51:
Line 52: def test_success_with_kwargs(self):
Line 53: port = 0
Line 54: res = self.vm.succeed_with_kwargs(migrationPort=port)
Line 52: def test_success_with_kwargs(self):
Line 53: port = 0
Line 54: res = self.vm.succeed_with_kwargs(migrationPort=port)
Line 55: self.assertEquals(response.is_error(res), False)
Line 56: self.assertEquals(res['kwargs']['migrationPort'], port)
> We can simplify this to:
Done
Line 57:
Line 58: def test_success_with_wrong_return(self):
Line 59: vmList = ['foobar'] # wrong type as per @api.method contract
Line 60: self.assertRaises(TypeError,
--
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Amit Aviram
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: use the new response handling
Nir Soffer has posted comments on this change. Change subject: vm: use the new response handling .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/54799/8//COMMIT_MSG Commit Message: Line 6: Line 7: vm: use the new response handling Line 8: Line 9: Let's start using the new api.method Line 10: decoratore to handle exceptions and response decorator Line 11: from few methods already in need of some Line 12: refactoring and cleanup. Line 13: Line 14: Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b Line 8: Line 9: Let's start using the new api.method Line 10: decoratore to handle exceptions and response Line 11: from few methods already in need of some Line 12: refactoring and cleanup. So this changes random apis? Why not wrap all apis? We need to remove all the calls to response.success, and replace calls to response.error with raising the proper exception. Line 13: Line 14: Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b -- To view, visit https://gerrit.ovirt.org/54799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: safer early return if destroyed on startup
Piotr Kliczewski has posted comments on this change. Change subject: vm: safer early return if destroyed on startup .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/55151/4//COMMIT_MSG Commit Message: PS4, Line 17: This patch improves that check to reduce the : time destroy() I do not see here info about 30 sec timeout we introduce here before calling destroy logic. https://gerrit.ovirt.org/#/c/55151/4/vdsm/virt/vm.py File vdsm/virt/vm.py: PS4, Line 3898: wait(_DESTROY_STARTUP_TIMEOUT) Does it mean that we may block api call for 30 seconds? Wouldn't be better to do it in async way? -- To view, visit https://gerrit.ovirt.org/55151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I618eb03783d7059ae33d7b0a02542b99c8d8199b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: common handling of exceptions
Nir Soffer has posted comments on this change.
Change subject: virt: common handling of exceptions
..
Patch Set 13: Code-Review+1
(3 comments)
Nice! some tests can be simplified if you like to submit another version.
https://gerrit.ovirt.org/#/c/54664/13/lib/vdsm/virt/api.py
File lib/vdsm/virt/api.py:
Line 31:
Line 32: def method(func):
Line 33: """
Line 34: Decorate an instance method, and return a response according to the
Line 35: outcome of the call.
Can you separate paragraphs with empty line?
Line 36: If the method returns None, return a plain success response.
Line 37: If the method wants to augment the success response, it could
return
Line 38: a dict. The dict items will be added to the success response.
Line 39: The method could override the success response message this way.
https://gerrit.ovirt.org/#/c/54664/13/tests/virt_api_test.py
File tests/virt_api_test.py:
Line 46: vmId = 'bar'
Line 47: res = self.vm.succeed_with_args('vmName', vmName, 'vmId', vmId)
Line 48: self.assertEquals(response.is_error(res), False)
Line 49: self.assertEquals(res['args'][0], 'vmName')
Line 50: self.assertEquals(res['args'][1], vmName)
We can simplify this to:
args = ("foo", "bar")
res = self.vm.succeed_with_args(*args)
self.assertEqual(res['args'], args)
Line 51:
Line 52: def test_success_with_kwargs(self):
Line 53: port = 0
Line 54: res = self.vm.succeed_with_kwargs(migrationPort=port)
Line 52: def test_success_with_kwargs(self):
Line 53: port = 0
Line 54: res = self.vm.succeed_with_kwargs(migrationPort=port)
Line 55: self.assertEquals(response.is_error(res), False)
Line 56: self.assertEquals(res['kwargs']['migrationPort'], port)
We can simplify this to:
kwargs = {"foo", "bar"}
res = self.vm.succeed_with_kwargs(**kwargs)
self.assertEqual(res['kwargs'], kwargs)
Line 57:
Line 58: def test_success_with_wrong_return(self):
Line 59: vmList = ['foobar'] # wrong type as per @api.method contract
Line 60: self.assertRaises(TypeError,
--
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Amit Aviram
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: expose hostdevReattach maintenance verb
Piotr Kliczewski has posted comments on this change. Change subject: hostdev: expose hostdevReattach maintenance verb .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebfb6a4e3854de8ea412417832a57fb896b78d1a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitoring: Introduce the check module
gerrit-hooks has posted comments on this change. Change subject: monitoring: Introduce the check module .. Patch Set 29: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug * Check Product::#1081962::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: suppress
Piotr Kliczewski has posted comments on this change. Change subject: utils: suppress .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76d5b0658435e59701ac4d845827e86026085c07 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: common handling of exceptions
Piotr Kliczewski has posted comments on this change. Change subject: virt: common handling of exceptions .. Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: storage: Clean up image links during teardownImage
Francesco Romani has submitted this change and it was merged. Change subject: storage: Clean up image links during teardownImage .. storage: Clean up image links during teardownImage In commit 736ab9 we began cleaning up volume links that were created in /var/run/vdsm/images/... Unfortunately on block domains we are leaving around a broken symlink in /rhev/data-center/... in some cases and this will cause storage operations related to a disk of a VM that was previously running to fail on this host. The solution is to also remove this broken symlink during teardownImage. Change-Id: I5fb871f3ccd785c555c72db34ab818c04d000534 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1319987 Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/55164 Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M vdsm/storage/blockSD.py M vdsm/storage/fileSD.py M vdsm/storage/hsm.py 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Adam Litke: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fb871f3ccd785c555c72db34ab818c04d000534 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: storage: Clean up image links during teardownImage
gerrit-hooks has posted comments on this change. Change subject: storage: Clean up image links during teardownImage .. Patch Set 4: * #1319987::Update tracker: OK * Set MODIFIED::bug 1319987#1319987IGNORE, not oVirt classification but Red Hat -- To view, visit https://gerrit.ovirt.org/55164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fb871f3ccd785c555c72db34ab818c04d000534 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: storage: Clean up image links during teardownImage
Francesco Romani has posted comments on this change. Change subject: storage: Clean up image links during teardownImage .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fb871f3ccd785c555c72db34ab818c04d000534 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: blockVolume: Remove stale links to image directory
gerrit-hooks has posted comments on this change. Change subject: blockVolume: Remove stale links to image directory .. Patch Set 2: * #1319987::Update tracker: OK * Set MODIFIED::bug 1319987#1319987IGNORE, not oVirt classification but Red Hat -- To view, visit https://gerrit.ovirt.org/55231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic694caab0e030c675e4a3a0c0638298abfea1a8c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: blockVolume: Remove stale links to image directory
Francesco Romani has submitted this change and it was merged. Change subject: blockVolume: Remove stale links to image directory .. blockVolume: Remove stale links to image directory Since we started to create the image directory under "/run/vdsm", the image directory under "/rhev/data-center/pool/sd/images/" may be a link to "/run/vdsm/storage/sd/image". The old code (from rhev-3.0) creating the image directory lazily was not designed to handle links and was happily using a stale link instead of creating the image directory. Now we detect and remove stale links, so proper image directory is created. Since stale links are not expected in normal usage, we log a warning in this case. Change-Id: Ic694caab0e030c675e4a3a0c0638298abfea1a8c Bug-Url: https://bugzilla.redhat.com/1319987 Signed-off-by: Nir Soffer Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/55231 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M vdsm/storage/blockVolume.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Adam Litke: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic694caab0e030c675e4a3a0c0638298abfea1a8c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: blockVolume: Remove stale links to image directory
Francesco Romani has posted comments on this change. Change subject: blockVolume: Remove stale links to image directory .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic694caab0e030c675e4a3a0c0638298abfea1a8c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
