[webkit-changes] [97939] trunk
Title: [97939] trunk
Revision 97939
Author hara...@chromium.org
Date 2011-10-19 23:02:42 -0700 (Wed, 19 Oct 2011)
Log Message
MessageEvent.data can be stored as ScriptValue.
https://bugs.webkit.org/show_bug.cgi?id=68978
Reviewed by Hajime Morita.
Source/WebCore:
Currently, the following test cases fail or crash:
- shouldBe(new MessageEvent('eventType', { data: test_object }).data, test_object) - FAIL
- new MessageEvent('eventType', { data: document }).data - CRASH
This is because MessageEvent.data is implemented just as SerializedScriptValue
and it cannot keep ScriptValue passed by _javascript_. This patch makes the following changes:
- If MessageEvent is constructed with ScriptValue, it is stored as ScriptValue internally.
When MessageEvent.data is called, the ScriptValue is returned.
- If MessageEvent is constructed with SerializedScriptValue, it is stored as
SerializedScriptValue internally (since we cannot deserialize it into ScriptValue
at this point because of lack of ExecState). When MessageEvent.data is called,
the SerializedScriptValue is deserialized into the corresponding ScriptValue,
and the ScriptValue is returned.
This patch does not make a fix for ObjC bindings code, since we need to first fix
the bug 28774, as commented in dom/MessageEvent.h and dom/MessageEvent.cpp.
Test: fast/events/constructors/message-event-constructor.html
fast/dom/message-port-deleted-by-accessor.html
fast/events/init-events.html
fast/eventsource/eventsource-attribute-listeners.html
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data): Custom getter for MessageEvent.data. Supported ScriptValue.
(WebCore::JSMessageEvent::handleInitMessageEvent): Changed SerializedScriptValue to ScriptValue. Removed a 'doTransfer' parameter.
(WebCore::JSMessageEvent::initMessageEvent): Removed a 'doTransfer' parameter.
(WebCore::JSMessageEvent::webkitInitMessageEvent): Ditto.
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter): Custom getter for MessageEvent.data. Supported ScriptValue.
(WebCore::V8MessageEvent::portsAccessorGetter): Removed extra spaces.
(WebCore::V8MessageEvent::initMessageEventCallback): Changed SerializedScriptValue to ScriptValue.
* dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent): Supported ScriptValue.
(WebCore::MessageEvent::initMessageEvent): Supported ScriptValue.
(WebCore::MessageEvent::isMessageEvent): Removed extra spaces.
* dom/MessageEvent.h: Added DataType::DataTypeScriptValue.
(WebCore::MessageEvent::create): Supported ScriptValue.
(WebCore::MessageEvent::dataAsScriptValue): Getter for data. Insert ASSERT() to guarantee that this accessor is not called for unintended type of data.
(WebCore::MessageEvent::dataAsSerializedScriptValue): Ditto.
(WebCore::MessageEvent::dataAsString): Ditto.
(WebCore::MessageEvent::dataAsBlob): Ditto.
(WebCore::MessageEvent::dataAsArrayBuffer): Ditto.
* dom/MessageEvent.idl: Changed SerializedScriptValue to DOMObject (i.e. ScriptValue). This patch does not touch an ObjC part. Removed [CachedAttribute] from MessageEvent.data, since it is now a DOMObject and needs not to be cached.
LayoutTests:
Removed failures and crashes.
* fast/events/constructors/message-event-constructor-expected.txt:
* fast/events/constructors/message-event-constructor.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/constructors/message-event-constructor-expected.txt
trunk/LayoutTests/fast/events/constructors/message-event-constructor.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp
trunk/Source/WebCore/dom/MessageEvent.cpp
trunk/Source/WebCore/dom/MessageEvent.h
trunk/Source/WebCore/dom/MessageEvent.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (97938 => 97939)
--- trunk/LayoutTests/ChangeLog 2011-10-20 05:19:48 UTC (rev 97938)
+++ trunk/LayoutTests/ChangeLog 2011-10-20 06:02:42 UTC (rev 97939)
@@ -1,3 +1,15 @@
+2011-10-19 Kentaro Hara hara...@chromium.org
+
+MessageEvent.data can be stored as ScriptValue.
+https://bugs.webkit.org/show_bug.cgi?id=68978
+
+Reviewed by Hajime Morita.
+
+Removed failures and crashes.
+
+* fast/events/constructors/message-event-constructor-expected.txt:
+* fast/events/constructors/message-event-constructor.html:
+
2011-10-19 Yuzo Fujishima y...@google.com
[chromium] Revert test expectaion change by 97932.
Modified: trunk/LayoutTests/fast/events/constructors/message-event-constructor-expected.txt (97938 => 97939)
--- trunk/LayoutTests/fast/events/constructors/message-event-constructor-expected.txt 2011-10-20 05:19:48 UTC (rev 97938)
+++ trunk/LayoutTests/fast/events/constructors/message-event-constructor-expected.txt 2011-10-20 06:02:42 UTC (rev 97939)
@@ -14,7 +14,8 @@
PASS new MessageEvent('eventType', { bubbles: true }).bubbles is true
PASS new
[webkit-changes] [97940] trunk/Source/JavaScriptCore
Title: [97940] trunk/Source/_javascript_Core Revision 97940 Author fpi...@apple.com Date 2011-10-19 23:33:33 -0700 (Wed, 19 Oct 2011) Log Message Optimization triggers in the old JIT may sometimes fire repeatedly even though there is no optimization to be done https://bugs.webkit.org/show_bug.cgi?id=70467 Reviewed by Oliver Hunt. If optimize_from_ret does nothing, it delays the next optimization trigger. This is performance-neutral. * jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): * runtime/Heuristics.cpp: (JSC::Heuristics::initializeHeuristics): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/jit/JITStubs.cpp trunk/Source/_javascript_Core/runtime/Heuristics.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (97939 => 97940) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-20 06:02:42 UTC (rev 97939) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-20 06:33:33 UTC (rev 97940) @@ -1,3 +1,19 @@ +2011-10-19 Filip Pizlo fpi...@apple.com + +Optimization triggers in the old JIT may sometimes fire repeatedly even +though there is no optimization to be done +https://bugs.webkit.org/show_bug.cgi?id=70467 + +Reviewed by Oliver Hunt. + +If optimize_from_ret does nothing, it delays the next optimization trigger. +This is performance-neutral. + +* jit/JITStubs.cpp: +(JSC::DEFINE_STUB_FUNCTION): +* runtime/Heuristics.cpp: +(JSC::Heuristics::initializeHeuristics): + 2011-10-19 Yuqiang Xian yuqiang.x...@intel.com DFG JIT 32_64 - remove unnecessary double unboxings in fillDouble/fillSpeculateDouble Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (97939 => 97940) --- trunk/Source/_javascript_Core/jit/JITStubs.cpp 2011-10-20 06:02:42 UTC (rev 97939) +++ trunk/Source/_javascript_Core/jit/JITStubs.cpp 2011-10-20 06:33:33 UTC (rev 97940) @@ -2023,6 +2023,7 @@ codeBlock-reoptimize(callFrame-globalData()); } +codeBlock-optimizeSoon(); return; } Modified: trunk/Source/_javascript_Core/runtime/Heuristics.cpp (97939 => 97940) --- trunk/Source/_javascript_Core/runtime/Heuristics.cpp 2011-10-20 06:02:42 UTC (rev 97939) +++ trunk/Source/_javascript_Core/runtime/Heuristics.cpp 2011-10-20 06:33:33 UTC (rev 97940) @@ -102,7 +102,7 @@ SET(executionCounterValueForOptimizeAfterWarmUp, -1000); SET(executionCounterValueForOptimizeAfterLongWarmUp, -5000); SET(executionCounterValueForDontOptimizeAnytimeSoon, std::numeric_limitsint32_t::min()); -SET(executionCounterValueForOptimizeSoon,-100); +SET(executionCounterValueForOptimizeSoon,-1000); SET(executionCounterValueForOptimizeNextInvocation, 0); SET(executionCounterIncrementForLoop, 1); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97941] trunk/LayoutTests
Title: [97941] trunk/LayoutTests Revision 97941 Author y...@google.com Date 2011-10-19 23:36:17 -0700 (Wed, 19 Oct 2011) Log Message [chromium] Test expectation change for platform/chromium/compositing/zoom-animator-scale-test2.html Unreviewed. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97940 => 97941) --- trunk/LayoutTests/ChangeLog 2011-10-20 06:33:33 UTC (rev 97940) +++ trunk/LayoutTests/ChangeLog 2011-10-20 06:36:17 UTC (rev 97941) @@ -1,3 +1,11 @@ +2011-10-19 Yuzo Fujishima y...@google.com + +[chromium] Test expectation change for platform/chromium/compositing/zoom-animator-scale-test2.html + +Unreviewed. + +* platform/chromium/test_expectations.txt: + 2011-10-19 Kentaro Hara hara...@chromium.org MessageEvent.data can be stored as ScriptValue. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97940 => 97941) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-20 06:33:33 UTC (rev 97940) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-20 06:36:17 UTC (rev 97941) @@ -2649,7 +2649,9 @@ // Take new baselines from the bots when 68035 lands. BUGWK69624 SLOW WIN GPU : platform/chromium/compositing/zoom-animator-scale-test2.html = IMAGE+TEXT -BUGWK70046 MAC : platform/chromium/compositing/zoom-animator-scale-test2.html = MISSING +BUGWK70046 LEOPARD : platform/chromium/compositing/zoom-animator-scale-test2.html = MISSING +BUGWK70046 SNOWLEOPARD CPU-CG : platform/chromium/compositing/zoom-animator-scale-test2.html = PASS +BUGWK70046 SNOWLEOPARD CPU GPU GPU-CG : platform/chromium/compositing/zoom-animator-scale-test2.html = TIMEOUT BUGCR72223 : media/video-frame-accurate-seek.html = PASS IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97942] trunk/Source/JavaScriptCore
Title: [97942] trunk/Source/_javascript_Core
Revision 97942
Author fpi...@apple.com
Date 2011-10-19 23:39:33 -0700 (Wed, 19 Oct 2011)
Log Message
DFG ConvertThis emits slow code when the source node is known to be,
but not predicted to be, a final object
https://bugs.webkit.org/show_bug.cgi?id=70466
Reviewed by Oliver Hunt.
Added a new case in ConvertThis compilation.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97941 => 97942)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-20 06:36:17 UTC (rev 97941)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-20 06:39:33 UTC (rev 97942)
@@ -1,5 +1,20 @@
2011-10-19 Filip Pizlo fpi...@apple.com
+DFG ConvertThis emits slow code when the source node is known to be,
+but not predicted to be, a final object
+https://bugs.webkit.org/show_bug.cgi?id=70466
+
+Reviewed by Oliver Hunt.
+
+Added a new case in ConvertThis compilation.
+
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
+2011-10-19 Filip Pizlo fpi...@apple.com
+
Optimization triggers in the old JIT may sometimes fire repeatedly even
though there is no optimization to be done
https://bugs.webkit.org/show_bug.cgi?id=70467
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (97941 => 97942)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2011-10-20 06:36:17 UTC (rev 97941)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2011-10-20 06:39:33 UTC (rev 97942)
@@ -1804,6 +1804,12 @@
}
case ConvertThis: {
+if (isObjectPrediction(m_state.forNode(node.child1()).m_type)) {
+SpeculateCellOperand thisValue(this, node.child1());
+cellResult(thisValue.gpr(), m_compileIndex);
+break;
+}
+
if (isOtherPrediction(at(node.child1()).prediction())) {
JSValueOperand thisValue(this, node.child1());
GPRTemporary scratch(this, thisValue);
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp (97941 => 97942)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2011-10-20 06:36:17 UTC (rev 97941)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2011-10-20 06:39:33 UTC (rev 97942)
@@ -1888,6 +1888,12 @@
}
case ConvertThis: {
+if (isObjectPrediction(m_state.forNode(node.child1()).m_type)) {
+SpeculateCellOperand thisValue(this, node.child1());
+cellResult(thisValue.gpr(), m_compileIndex);
+break;
+}
+
if (isOtherPrediction(at(node.child1()).prediction())) {
JSValueOperand thisValue(this, node.child1());
GPRTemporary scratch(this, thisValue);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97943] trunk/LayoutTests
Title: [97943] trunk/LayoutTests Revision 97943 Author o...@webkit.org Date 2011-10-19 23:47:43 -0700 (Wed, 19 Oct 2011) Log Message [Qt] Unreviewed morning gardning. * platform/qt/Skipped: Skip fast/dom/error-to-string-stack-overflow.html - https://bugs.webkit.org/show_bug.cgi?id=70476 * platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r97875. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (97942 => 97943) --- trunk/LayoutTests/ChangeLog 2011-10-20 06:39:33 UTC (rev 97942) +++ trunk/LayoutTests/ChangeLog 2011-10-20 06:47:43 UTC (rev 97943) @@ -1,3 +1,10 @@ +2011-10-19 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed morning gardning. + +* platform/qt/Skipped: Skip fast/dom/error-to-string-stack-overflow.html - https://bugs.webkit.org/show_bug.cgi?id=70476 +* platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r97875. + 2011-10-19 Yuzo Fujishima y...@google.com [chromium] Test expectation change for platform/chromium/compositing/zoom-animator-scale-test2.html Modified: trunk/LayoutTests/platform/qt/Skipped (97942 => 97943) --- trunk/LayoutTests/platform/qt/Skipped 2011-10-20 06:39:33 UTC (rev 97942) +++ trunk/LayoutTests/platform/qt/Skipped 2011-10-20 06:47:43 UTC (rev 97943) @@ -2446,3 +2446,7 @@ # [Qt] Assertion fail in CSSPrimitiveValue ctor # https://bugs.webkit.org/show_bug.cgi?id=69933 fast/borders/inline-mask-overlay-image-outset.html + +# REGRESSION(r97881): It broke fast/dom/error-to-string-stack-overflow.html +# https://bugs.webkit.org/show_bug.cgi?id=70476 +fast/dom/error-to-string-stack-overflow.html Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt (97942 => 97943) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-10-20 06:39:33 UTC (rev 97942) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-10-20 06:47:43 UTC (rev 97943) @@ -44,7 +44,6 @@ window.Audio [object AudioConstructor] window.Audio.length [number] window.Audio.prototype [object HTMLAudioElementPrototype] -window.Audio.prototype.ALLOW_KEYBOARD_INPUT [number] window.Audio.prototype.ATTRIBUTE_NODE [number] window.Audio.prototype.CDATA_SECTION_NODE [number] window.Audio.prototype.COMMENT_NODE [number] @@ -125,7 +124,6 @@ window.Audio.prototype.setAttributeNode [function] window.Audio.prototype.setAttributeNodeNS [function] window.Audio.prototype.webkitMatchesSelector [function] -window.Audio.prototype.webkitRequestFullScreen [function] window.BeforeLoadEvent [object BeforeLoadEventConstructor] window.BeforeLoadEvent.prototype [object BeforeLoadEventPrototype] window.BeforeLoadEvent.prototype.AT_TARGET [number] @@ -736,7 +734,6 @@ window.Document.prototype.removeChild [function] window.Document.prototype.removeEventListener [function] window.Document.prototype.replaceChild [function] -window.Document.prototype.webkitCancelFullScreen [function] window.DocumentFragment [object DocumentFragmentConstructor] window.DocumentFragment.prototype [object DocumentFragmentPrototype] window.DocumentFragment.prototype.ATTRIBUTE_NODE [number] @@ -818,9 +815,7 @@ window.DocumentType.prototype.removeEventListener [function] window.DocumentType.prototype.replaceChild [function] window.Element [object ElementConstructor] -window.Element.ALLOW_KEYBOARD_INPUT [number] window.Element.prototype [object ElementPrototype] -window.Element.prototype.ALLOW_KEYBOARD_INPUT [number] window.Element.prototype.ATTRIBUTE_NODE [number] window.Element.prototype.CDATA_SECTION_NODE [number] window.Element.prototype.COMMENT_NODE [number] @@ -885,7 +880,6 @@ window.Element.prototype.setAttributeNode [function] window.Element.prototype.setAttributeNodeNS [function] window.Element.prototype.webkitMatchesSelector [function] -window.Element.prototype.webkitRequestFullScreen [function] window.Entity [object EntityConstructor] window.Entity.prototype [object EntityPrototype] window.Entity.prototype.ATTRIBUTE_NODE [number] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97944] trunk/Source/WebCore
Title: [97944] trunk/Source/WebCore Revision 97944 Author jer.no...@apple.com Date 2011-10-20 00:20:55 -0700 (Thu, 20 Oct 2011) Log Message compositing/video tests time out on Lion https://bugs.webkit.org/show_bug.cgi?id=70448 Reviewed by Eric Carlson. Covered by existing tests. AVFoundation will occasionally fill it's playback buffers before collecting enough statistical information to answer YES to isLikelyToKeepUp. In this situation, set the ready state to HAVE_ENOUGH_DATA, on the presumption that if the playback buffers are full, playback will probably not stall. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (97943 => 97944) --- trunk/Source/WebCore/ChangeLog 2011-10-20 06:47:43 UTC (rev 97943) +++ trunk/Source/WebCore/ChangeLog 2011-10-20 07:20:55 UTC (rev 97944) @@ -1,3 +1,20 @@ +2011-10-19 Jer Noble jer.no...@apple.com + +compositing/video tests time out on Lion +https://bugs.webkit.org/show_bug.cgi?id=70448 + +Reviewed by Eric Carlson. + +Covered by existing tests. + +AVFoundation will occasionally fill it's playback buffers before collecting enough +statistical information to answer YES to isLikelyToKeepUp. In this situation, set the +ready state to HAVE_ENOUGH_DATA, on the presumption that if the playback buffers are +full, playback will probably not stall. + +* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: +(WebCore::MediaPlayerPrivateAVFoundation::updateStates): + 2011-10-19 Kentaro Hara hara...@chromium.org MessageEvent.data can be stored as ScriptValue. Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (97943 => 97944) --- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2011-10-20 06:47:43 UTC (rev 97943) +++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2011-10-20 07:20:55 UTC (rev 97944) @@ -450,10 +450,13 @@ break; case MediaPlayerAVPlayerItemStatusPlaybackLikelyToKeepUp: +case MediaPlayerAVPlayerItemStatusPlaybackBufferFull: +// If the status becomes PlaybackBufferFull, loading stops and the status will not +// progress to LikelyToKeepUp. Set the readyState to HAVE_ENOUGH_DATA, on the +// presumption that if the playback buffer is full, playback will probably not stall. m_readyState = MediaPlayer::HaveEnoughData; break; -case MediaPlayerAVPlayerItemStatusPlaybackBufferFull: case MediaPlayerAVPlayerItemStatusReadyToPlay: // If the readyState is already HaveEnoughData, don't go lower because of this state change. if (m_readyState == MediaPlayer::HaveEnoughData) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97945] trunk/Source
Title: [97945] trunk/Source
Revision 97945
Author ca...@webkit.org
Date 2011-10-20 00:22:49 -0700 (Thu, 20 Oct 2011)
Log Message
Tiled Backing Store does not regenerate tiles when it should
https://bugs.webkit.org/show_bug.cgi?id=57798
Reviewed by Darin Adler.
Source/WebCore:
Changed TiledBackingStore::adjustVisibleRect to take into account
contentsSize, the same way as it is done when tiles are generated.
This is an issue that requires a certain sequence of API calls which
may not be easily simulated from DumpRenderTree, but which is
easily reproduced with QtTest. This is why I have provided only
a Qt specific test despite this being a generic problem.
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::adjustVisibleRect):
Changed to take into account ContentsSize.
(WebCore::TiledBackingStore::visibleContentsRect):
Added to return the intersection of the viewport's visible rect with
the ContentsRect.
(WebCore::TiledBackingStore::createTiles):
Changed to take into account the ContentsSize when calculating the
previously visible rect.
* platform/graphics/TiledBackingStore.h:
Source/WebKit/qt:
Provided test for this bug. Changed the name of the resource I added
for a previous test so that the name is descriptive such that it can
be shared across several tests.
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::bug57798):
(tst_QGraphicsWebView::bug56929):
* tests/qgraphicswebview/tst_qgraphicswebview.qrc:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp
trunk/Source/WebCore/platform/graphics/TiledBackingStore.h
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp
trunk/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.qrc
Added Paths
trunk/Source/WebKit/qt/tests/qgraphicswebview/resources/greendiv.html
Removed Paths
trunk/Source/WebKit/qt/tests/qgraphicswebview/resources/56929.html
Diff
Modified: trunk/Source/WebCore/ChangeLog (97944 => 97945)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 07:20:55 UTC (rev 97944)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 07:22:49 UTC (rev 97945)
@@ -1,3 +1,29 @@
+2011-10-20 Carol Szabo ca...@webkit.org
+
+Tiled Backing Store does not regenerate tiles when it should
+https://bugs.webkit.org/show_bug.cgi?id=57798
+
+Reviewed by Darin Adler.
+
+Changed TiledBackingStore::adjustVisibleRect to take into account
+contentsSize, the same way as it is done when tiles are generated.
+
+This is an issue that requires a certain sequence of API calls which
+may not be easily simulated from DumpRenderTree, but which is
+easily reproduced with QtTest. This is why I have provided only
+a Qt specific test despite this being a generic problem.
+
+* platform/graphics/TiledBackingStore.cpp:
+(WebCore::TiledBackingStore::adjustVisibleRect):
+Changed to take into account ContentsSize.
+(WebCore::TiledBackingStore::visibleContentsRect):
+Added to return the intersection of the viewport's visible rect with
+the ContentsRect.
+(WebCore::TiledBackingStore::createTiles):
+Changed to take into account the ContentsSize when calculating the
+previously visible rect.
+* platform/graphics/TiledBackingStore.h:
+
2011-10-19 Jer Noble jer.no...@apple.com
compositing/video tests time out on Lion
Modified: trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp (97944 => 97945)
--- trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp 2011-10-20 07:20:55 UTC (rev 97944)
+++ trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp 2011-10-20 07:22:49 UTC (rev 97945)
@@ -173,7 +173,7 @@
void TiledBackingStore::adjustVisibleRect()
{
-IntRect visibleRect = mapFromContents(m_client-tiledBackingStoreVisibleRect());
+IntRect visibleRect = visibleContentsRect();
if (m_previousVisibleRect == visibleRect)
return;
m_previousVisibleRect = visibleRect;
@@ -181,6 +181,11 @@
startTileCreationTimer();
}
+IntRect TiledBackingStore::visibleContentsRect()
+{
+return mapFromContents(intersection(m_client-tiledBackingStoreVisibleRect(), m_client-tiledBackingStoreContentsRect()));
+}
+
void TiledBackingStore::setContentsScale(float scale)
{
if (m_pendingScale == m_contentsScale) {
@@ -242,7 +247,7 @@
if (m_contentsFrozen)
return;
-IntRect visibleRect = mapFromContents(m_client-tiledBackingStoreVisibleRect());
+IntRect visibleRect = visibleContentsRect();
m_previousVisibleRect = visibleRect;
if (visibleRect.isEmpty())
Modified: trunk/Source/WebCore/platform/graphics/TiledBackingStore.h (97944 => 97945)
--- trunk/Source/WebCore/platform/graphics/TiledBackingStore.h 2011-10-20 07:20:55 UTC (rev 97944)
+++ trunk/Source/WebCore/platform/graphics/TiledBackingStore.h
[webkit-changes] [97947] trunk/LayoutTests
Title: [97947] trunk/LayoutTests Revision 97947 Author ph...@webkit.org Date 2011-10-20 00:56:32 -0700 (Thu, 20 Oct 2011) Log Message Unreviewed, GTK rebaseline after r97926 and skip a failing plugin test. * platform/gtk/Skipped: Skip plugins/resize-from-plugin.html. * platform/gtk/fast/dom/Window/window-properties-expected.txt: * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: * platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt: * platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: * platform/gtk/fast/js/global-constructors-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt trunk/LayoutTests/platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (97946 => 97947) --- trunk/LayoutTests/ChangeLog 2011-10-20 07:34:48 UTC (rev 97946) +++ trunk/LayoutTests/ChangeLog 2011-10-20 07:56:32 UTC (rev 97947) @@ -1,3 +1,15 @@ +2011-10-20 Philippe Normand pnorm...@igalia.com + +Unreviewed, GTK rebaseline after r97926 and skip a failing plugin +test. + +* platform/gtk/Skipped: Skip plugins/resize-from-plugin.html. +* platform/gtk/fast/dom/Window/window-properties-expected.txt: +* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: +* platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt: +* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: +* platform/gtk/fast/js/global-constructors-expected.txt: + 2011-10-19 Csaba Osztrogonác o...@webkit.org [Qt] Unreviewed morning gardning. Modified: trunk/LayoutTests/platform/gtk/Skipped (97946 => 97947) --- trunk/LayoutTests/platform/gtk/Skipped 2011-10-20 07:34:48 UTC (rev 97946) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-10-20 07:56:32 UTC (rev 97947) @@ -1643,3 +1643,6 @@ # Microdata DOM API is not yet enabled. fast/dom/MicroData + +# https://bugs.webkit.org/show_bug.cgi?id=70481 +plugins/resize-from-plugin.html Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt (97946 => 97947) --- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2011-10-20 07:34:48 UTC (rev 97946) +++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2011-10-20 07:56:32 UTC (rev 97947) @@ -73,6 +73,7 @@ window.Audio.prototype.PROCESSING_INSTRUCTION_NODE [number] window.Audio.prototype.TEXT_NODE [number] window.Audio.prototype.addEventListener [function] +window.Audio.prototype.addTrack [function] window.Audio.prototype.appendChild [function] window.Audio.prototype.blur [function] window.Audio.prototype.canPlayType [function] @@ -2105,6 +2106,10 @@ window.TextEvent.prototype [printed above as window.Event.prototype] window.TextMetrics [object TextMetricsConstructor] window.TextMetrics.prototype [object TextMetricsPrototype] +window.TextTrackCue [object TextTrackCueConstructor] +window.TextTrackCue.prototype [object TextTrackCuePrototype] +window.TextTrackCue.prototype.getCueAsHTML [function] +window.TextTrackCue.prototype.getCueAsSource [function] window.TimeRanges [object TimeRangesConstructor] window.TimeRanges.prototype [object TimeRangesPrototype] window.TimeRanges.prototype.end [function] Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt (97946 => 97947) --- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt 2011-10-20 07:34:48 UTC (rev 97946) +++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt 2011-10-20 07:56:32 UTC (rev 97947) @@ -319,6 +319,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'Text') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'TextEvent') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'TextMetrics') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'TextTrackCue') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'TimeRanges') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'TypeError') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'UIEvent') is 'object' Modified: trunk/LayoutTests/platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt (97946 => 97947) --- trunk/LayoutTests/platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt 2011-10-20 07:34:48 UTC (rev 97946) +++ trunk/LayoutTests/platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt 2011-10-20 07:56:32 UTC (rev 97947) @@ -1,5 +1,8 @@ This
[webkit-changes] [97948] trunk/Tools
Title: [97948] trunk/Tools
Revision 97948
Author ph...@webkit.org
Date 2011-10-20 01:00:13 -0700 (Thu, 20 Oct 2011)
Log Message
Unreviewed. Adding myself to watchlists.
* Scripts/webkitpy/common/config/watchlist:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist
Diff
Modified: trunk/Tools/ChangeLog (97947 => 97948)
--- trunk/Tools/ChangeLog 2011-10-20 07:56:32 UTC (rev 97947)
+++ trunk/Tools/ChangeLog 2011-10-20 08:00:13 UTC (rev 97948)
@@ -1,3 +1,8 @@
+2011-10-20 Philippe Normand pnorm...@igalia.com
+
+Unreviewed. Adding myself to watchlists.
+* Scripts/webkitpy/common/config/watchlist:
+
2011-10-19 Eric Seidel e...@webkit.org
Reviewed by Adam Barth.
Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (97947 => 97948)
--- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2011-10-20 07:56:32 UTC (rev 97947)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2011-10-20 08:00:13 UTC (rev 97948)
@@ -18,6 +18,9 @@
ChromiumPublicApi: {
filename: rSource/WebKit/chromium/public/
},
+GStreamerGraphics: {
+filename: rSource/WebCore/platform/graphics/gstreamer/,
+},
WebIDL: {
filename: rSource/WebCore/(?!inspector).*\.idl
},
@@ -72,6 +75,7 @@
# two different accounts as far as bugzilla is concerned.
ChromiumGraphics: [ jam...@chromium.org, ],
ChromiumPublicApi: [ fi...@chromium.org, ],
+GStreamerGraphics: [ pnorm...@igalia.com, ],
WebIDL: [ aba...@webkit.org, o...@chromium.org ],
StyleChecker: [ le...@chromium.org, ],
ThreadingFiles|ThreadingUsage: [ levin+thread...@chromium.org, ],
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97949] trunk/Source/WebCore
Title: [97949] trunk/Source/WebCore
Revision 97949
Author apav...@chromium.org
Date 2011-10-20 01:15:40 -0700 (Thu, 20 Oct 2011)
Log Message
Web Inspector: The x in 980px x 36px looks weird in the inspector node callout
https://bugs.webkit.org/show_bug.cgi?id=69857
Reviewed by Pavel Feldman.
* inspector/DOMNodeHighlighter.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97948 => 97949)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 08:00:13 UTC (rev 97948)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 08:15:40 UTC (rev 97949)
@@ -1,3 +1,12 @@
+2011-10-19 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: The x in 980px x 36px looks weird in the inspector node callout
+https://bugs.webkit.org/show_bug.cgi?id=69857
+
+Reviewed by Pavel Feldman.
+
+* inspector/DOMNodeHighlighter.cpp:
+
2011-10-20 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r97917.
Modified: trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp (97948 => 97949)
--- trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp 2011-10-20 08:00:13 UTC (rev 97948)
+++ trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp 2011-10-20 08:15:40 UTC (rev 97949)
@@ -47,6 +47,7 @@
#include Settings.h
#include StyledElement.h
#include TextRun.h
+#include wtf/text/StringBuilder.h
namespace WebCore {
@@ -230,22 +231,23 @@
DEFINE_STATIC_LOCAL(Color, pxAndBorderColor, (128, 128, 128));
DEFINE_STATIC_LOCAL(String, pxString, (px));
-const static UChar timesUChar[] = { 0x00D7, 0 };
+const static UChar timesUChar[] = { 0x0020, 0x00D7, 0x0020, 0 };
DEFINE_STATIC_LOCAL(String, timesString, (timesUChar)); // times; string
FontCachePurgePreventer fontCachePurgePreventer;
Element* element = static_castElement*(node);
bool isXHTML = element-document()-isXHTMLDocument();
-String nodeTitle(isXHTML ? element-nodeName() : element-nodeName().lower());
+StringBuilder nodeTitle;
+nodeTitle.append(isXHTML ? element-nodeName() : element-nodeName().lower());
unsigned tagNameLength = nodeTitle.length();
const AtomicString idValue = element-getIdAttribute();
unsigned idStringLength = 0;
String idString;
if (!idValue.isNull() !idValue.isEmpty()) {
-nodeTitle += #;
-nodeTitle += idValue;
+nodeTitle.append(#);
+nodeTitle.append(idValue);
idStringLength = 1 + idValue.length();
}
@@ -259,8 +261,8 @@
if (usedClassNames.contains(className))
continue;
usedClassNames.add(className);
-nodeTitle += .;
-nodeTitle += className;
+nodeTitle.append(.);
+nodeTitle.append(className);
classesStringLength += 1 + className.length();
}
}
@@ -268,17 +270,19 @@
RenderBoxModelObject* modelObject = renderer-isBoxModelObject() ? toRenderBoxModelObject(renderer) : 0;
String widthNumberPart = + String::number(modelObject ? adjustForAbsoluteZoom(modelObject-offsetWidth(), modelObject) : boundingBox.width());
-nodeTitle += widthNumberPart + pxString;
-nodeTitle += timesString;
+nodeTitle.append(widthNumberPart);
+nodeTitle.append(pxString);
+nodeTitle.append(timesString);
String heightNumberPart = String::number(modelObject ? adjustForAbsoluteZoom(modelObject-offsetHeight(), modelObject) : boundingBox.height());
-nodeTitle += heightNumberPart + pxString;
+nodeTitle.append(heightNumberPart);
+nodeTitle.append(pxString);
FontDescription desc;
setUpFontDescription(desc, settings);
Font font = Font(desc, 0, 0);
font.update(0);
-TextRun nodeTitleRun(nodeTitle);
+TextRun nodeTitleRun(nodeTitle.toString());
LayoutPoint titleBasePoint = LayoutPoint(anchorBox.x(), anchorBox.maxY() - 1);
titleBasePoint.move(rectInflatePx, rectInflatePx);
LayoutRect titleRect = enclosingLayoutRect(font.selectionRectForText(nodeTitleRun, titleBasePoint, fontHeightPx));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97950] trunk/LayoutTests
Title: [97950] trunk/LayoutTests Revision 97950 Author y...@google.com Date 2011-10-20 01:19:55 -0700 (Thu, 20 Oct 2011) Log Message [chromium] Yet another test expectation change for platform/chromium/compositing/zoom-animator-scale-test2.html Unreviewed. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97949 => 97950) --- trunk/LayoutTests/ChangeLog 2011-10-20 08:15:40 UTC (rev 97949) +++ trunk/LayoutTests/ChangeLog 2011-10-20 08:19:55 UTC (rev 97950) @@ -1,3 +1,11 @@ +2011-10-20 Yuzo Fujishima y...@google.com + +[chromium] Yet another test expectation change for platform/chromium/compositing/zoom-animator-scale-test2.html + +Unreviewed. + +* platform/chromium/test_expectations.txt: + 2011-10-20 Philippe Normand pnorm...@igalia.com Unreviewed, GTK rebaseline after r97926 and skip a failing plugin Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97949 => 97950) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-20 08:15:40 UTC (rev 97949) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-20 08:19:55 UTC (rev 97950) @@ -2650,8 +2650,7 @@ // Take new baselines from the bots when 68035 lands. BUGWK69624 SLOW WIN GPU : platform/chromium/compositing/zoom-animator-scale-test2.html = IMAGE+TEXT BUGWK70046 LEOPARD : platform/chromium/compositing/zoom-animator-scale-test2.html = MISSING -BUGWK70046 SNOWLEOPARD CPU-CG : platform/chromium/compositing/zoom-animator-scale-test2.html = PASS -BUGWK70046 SNOWLEOPARD CPU GPU GPU-CG : platform/chromium/compositing/zoom-animator-scale-test2.html = TIMEOUT +BUGWK70046 SNOWLEOPARD : platform/chromium/compositing/zoom-animator-scale-test2.html = PASS TIMEOUT BUGCR72223 : media/video-frame-accurate-seek.html = PASS IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97951] trunk/Source/JavaScriptCore
Title: [97951] trunk/Source/_javascript_Core
Revision 97951
Author fpi...@apple.com
Date 2011-10-20 02:10:06 -0700 (Thu, 20 Oct 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=70482
DFG-related stubs in the old JIT should not be built if the DFG is disabled
Reviewed by Zoltan Herczeg.
Aiming for a slight code size/build time reduction if the DFG is not in
play. This should also make further DFG development slightly easier since
the bodies of these JIT stubs can now safely refer to things that are only
declared when the DFG is enabled.
* jit/JITStubs.cpp:
* jit/JITStubs.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITStubs.cpp
trunk/Source/_javascript_Core/jit/JITStubs.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97950 => 97951)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-20 08:19:55 UTC (rev 97950)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-20 09:10:06 UTC (rev 97951)
@@ -1,3 +1,18 @@
+2011-10-20 Filip Pizlo fpi...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=70482
+DFG-related stubs in the old JIT should not be built if the DFG is disabled
+
+Reviewed by Zoltan Herczeg.
+
+Aiming for a slight code size/build time reduction if the DFG is not in
+play. This should also make further DFG development slightly easier since
+the bodies of these JIT stubs can now safely refer to things that are only
+declared when the DFG is enabled.
+
+* jit/JITStubs.cpp:
+* jit/JITStubs.h:
+
2011-10-19 Filip Pizlo fpi...@apple.com
DFG ConvertThis emits slow code when the source node is known to be,
Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (97950 => 97951)
--- trunk/Source/_javascript_Core/jit/JITStubs.cpp 2011-10-20 08:19:55 UTC (rev 97950)
+++ trunk/Source/_javascript_Core/jit/JITStubs.cpp 2011-10-20 09:10:06 UTC (rev 97951)
@@ -1902,6 +1902,7 @@
VM_THROW_EXCEPTION_AT_END();
}
+#if ENABLE(DFG_JIT)
DEFINE_STUB_FUNCTION(void, optimize_from_loop)
{
STUB_INIT_STACK_FRAME(stackFrame);
@@ -2058,6 +2059,7 @@
codeBlock-optimizeSoon();
}
+#endif // ENABLE(DFG_JIT)
DEFINE_STUB_FUNCTION(EncodedJSValue, op_instanceof)
{
Modified: trunk/Source/_javascript_Core/jit/JITStubs.h (97950 => 97951)
--- trunk/Source/_javascript_Core/jit/JITStubs.h 2011-10-20 08:19:55 UTC (rev 97950)
+++ trunk/Source/_javascript_Core/jit/JITStubs.h 2011-10-20 09:10:06 UTC (rev 97951)
@@ -425,8 +425,10 @@
void JIT_STUB cti_op_tear_off_activation(STUB_ARGS_DECLARATION);
void JIT_STUB cti_op_tear_off_arguments(STUB_ARGS_DECLARATION);
void JIT_STUB cti_op_throw_reference_error(STUB_ARGS_DECLARATION);
+#if ENABLE(DFG_JIT)
void JIT_STUB cti_optimize_from_loop(STUB_ARGS_DECLARATION);
void JIT_STUB cti_optimize_from_ret(STUB_ARGS_DECLARATION);
+#endif
void* JIT_STUB cti_op_call_arityCheck(STUB_ARGS_DECLARATION);
void* JIT_STUB cti_op_construct_arityCheck(STUB_ARGS_DECLARATION);
void* JIT_STUB cti_op_call_jitCompile(STUB_ARGS_DECLARATION);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97952] trunk
Title: [97952] trunk
Revision 97952
Author podivi...@chromium.org
Date 2011-10-20 02:33:02 -0700 (Thu, 20 Oct 2011)
Log Message
Web Inspector: encode source map url as source map page url query parameter.
https://bugs.webkit.org/show_bug.cgi?id=70327
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/CompilerSourceMappingProvider.js:
(WebInspector.CompilerSourceMappingProvider):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping.frameLoaded):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
(WebInspector.CompilerSourceMappingProvider.prototype._sendRequest):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiSourceCodeList):
LayoutTests:
* http/tests/inspector/compiler-source-mapping-provider.html:
* http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider.html
trunk/LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMappingProvider.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
Diff
Modified: trunk/LayoutTests/ChangeLog (97951 => 97952)
--- trunk/LayoutTests/ChangeLog 2011-10-20 09:10:06 UTC (rev 97951)
+++ trunk/LayoutTests/ChangeLog 2011-10-20 09:33:02 UTC (rev 97952)
@@ -1,3 +1,13 @@
+2011-10-18 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: encode source map url as source map page url query parameter.
+https://bugs.webkit.org/show_bug.cgi?id=70327
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/compiler-source-mapping-provider.html:
+* http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html:
+
2011-10-20 Yuzo Fujishima y...@google.com
[chromium] Yet another test expectation change for platform/chromium/compositing/zoom-animator-scale-test2.html
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider.html (97951 => 97952)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider.html 2011-10-20 09:10:06 UTC (rev 97951)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider.html 2011-10-20 09:33:02 UTC (rev 97952)
@@ -9,7 +9,7 @@
InspectorTest.runTestSuite([
function testLoad(next)
{
-var provider = new WebInspector.CompilerSourceMappingProvider(http://localhost:8000/inspector/resources/compiler-source-mapping-provider/app-map);
+var provider = new WebInspector.CompilerSourceMappingProvider(http://localhost:8000/inspector/resources/compiler-source-mapping-provider/app-map.html?sourceMap=app-map);
var sourceMapping;
provider.loadSourceMapping(didLoadSourceMapping);
function didLoadSourceMapping(sourceMappingArg)
Modified: trunk/LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html (97951 => 97952)
--- trunk/LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html 2011-10-20 09:10:06 UTC (rev 97951)
+++ trunk/LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html 2011-10-20 09:33:02 UTC (rev 97952)
@@ -3,7 +3,19 @@
function handleMessage(event)
{
-var url = ""
+var requestId = event.data.id;
+var method = event.data.method;
+if (method === loadSourceMap) {
+var queryParameters = parseQueryString(window.location.toString());
+sendRequest(event, queryParameters.sourceMap);
+} else if (method === loadSourceCode) {
+var sourceCodeURL = event.data.params[0];
+sendRequest(event, sourceCodeURL);
+}
+}
+
+function sendRequest(event, url)
+{
var request = new XMLHttpRequest();
request.open(GET, url, true);
request._onreadystatechange_ = function()
@@ -17,4 +29,16 @@
}
request.send();
}
+
+function parseQueryString(url)
+{
+var query = url.split(?)[1];
+var parameters = query.split();
+var result = {};
+for (var i = 0; i parameters.length; ++i) {
+var parameter = parameters[i].split(=);
+result[parameter[0]] = parameter[1];
+}
+return result;
+}
/script
Modified: trunk/LayoutTests/inspector/debugger/raw-source-code.html (97951 => 97952)
--- trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-20 09:10:06 UTC (rev 97951)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-20 09:33:02 UTC (rev 97952)
@@ -375,7 +375,7 @@
function checkMapping()
{
var sourceMapping = rawSourceCode.sourceMapping;
-uiSourceCodeList =
[webkit-changes] [97953] trunk/LayoutTests
Title: [97953] trunk/LayoutTests Revision 97953 Author ph...@webkit.org Date 2011-10-20 02:34:07 -0700 (Thu, 20 Oct 2011) Log Message Unreviewed, skip failing test in GTK. * platform/gtk/Skipped: Skip fast/events/drag-selects-image.html Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (97952 => 97953) --- trunk/LayoutTests/ChangeLog 2011-10-20 09:33:02 UTC (rev 97952) +++ trunk/LayoutTests/ChangeLog 2011-10-20 09:34:07 UTC (rev 97953) @@ -1,3 +1,9 @@ +2011-10-20 Philippe Normand pnorm...@igalia.com + +Unreviewed, skip failing test in GTK. + +* platform/gtk/Skipped: Skip fast/events/drag-selects-image.html + 2011-10-18 Pavel Podivilov podivi...@chromium.org Web Inspector: encode source map url as source map page url query parameter. Modified: trunk/LayoutTests/platform/gtk/Skipped (97952 => 97953) --- trunk/LayoutTests/platform/gtk/Skipped 2011-10-20 09:33:02 UTC (rev 97952) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-10-20 09:34:07 UTC (rev 97953) @@ -1646,3 +1646,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=70481 plugins/resize-from-plugin.html + +# https://bugs.webkit.org/show_bug.cgi?id=70485 +fast/events/drag-selects-image.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97955] trunk
Title: [97955] trunk
Revision 97955
Author hara...@chromium.org
Date 2011-10-20 02:57:28 -0700 (Thu, 20 Oct 2011)
Log Message
Implement a MessageEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=70296
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/message-event-constructor.html
* bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::getKeyValue): Returns RefPtrDOMWindow corresponding to a given key.
(WebCore::OptionsObject::getKeyValue): Returns MessagePortArray corresponding to a given key.
* bindings/v8/OptionsObject.h:
* bindings/v8/custom/V8EventConstructors.cpp: Added a MessageEvent constructor.
* dom/MessageEvent.idl: Makes MessageEvent constructible for V8.
LayoutTests:
Enabled message-event-constructor.html for chromium,
since now V8 has the MessageEvent constructor.
* platform/chromium/test_expectations.txt:
* platform/chromium/fast/events/constructors/message-event-constructor-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/OptionsObject.cpp
trunk/Source/WebCore/bindings/v8/OptionsObject.h
trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp
trunk/Source/WebCore/dom/MessageEvent.idl
Added Paths
trunk/LayoutTests/platform/chromium/fast/events/constructors/message-event-constructor-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97954 => 97955)
--- trunk/LayoutTests/ChangeLog 2011-10-20 09:50:22 UTC (rev 97954)
+++ trunk/LayoutTests/ChangeLog 2011-10-20 09:57:28 UTC (rev 97955)
@@ -1,3 +1,16 @@
+2011-10-20 Kentaro Hara hara...@chromium.org
+
+Implement a MessageEvent constructor for V8
+https://bugs.webkit.org/show_bug.cgi?id=70296
+
+Reviewed by Adam Barth.
+
+Enabled message-event-constructor.html for chromium,
+since now V8 has the MessageEvent constructor.
+
+* platform/chromium/test_expectations.txt:
+* platform/chromium/fast/events/constructors/message-event-constructor-expected.txt: Added.
+
2011-10-20 Philippe Normand pnorm...@igalia.com
Unreviewed, skip failing test in GTK.
Added: trunk/LayoutTests/platform/chromium/fast/events/constructors/message-event-constructor-expected.txt (0 => 97955)
--- trunk/LayoutTests/platform/chromium/fast/events/constructors/message-event-constructor-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/events/constructors/message-event-constructor-expected.txt 2011-10-20 09:57:28 UTC (rev 97955)
@@ -0,0 +1,108 @@
+This tests the constructor for the MessageEvent DOM class.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS new MessageEvent('eventType').bubbles is false
+PASS new MessageEvent('eventType').cancelable is false
+PASS new MessageEvent('eventType').data is null
+PASS new MessageEvent('eventType').origin is
+PASS new MessageEvent('eventType').lastEventId is
+PASS new MessageEvent('eventType').source is null
+PASS new MessageEvent('eventType').ports is []
+PASS new MessageEvent('eventType', { bubbles: false }).bubbles is false
+PASS new MessageEvent('eventType', { bubbles: true }).bubbles is true
+PASS new MessageEvent('eventType', { cancelable: false }).cancelable is false
+PASS new MessageEvent('eventType', { cancelable: true }).cancelable is true
+PASS new MessageEvent('eventType', { data: test_object }).data is test_object
+PASS new MessageEvent('eventType', { data: document }).data is document
+PASS new MessageEvent('eventType', { data: undefined }).data is undefined
+PASS new MessageEvent('eventType', { data: null }).data is null
+PASS new MessageEvent('eventType', { data: false }).data is false
+PASS new MessageEvent('eventType', { data: true }).data is true
+PASS new MessageEvent('eventType', { data: '' }).data is
+PASS new MessageEvent('eventType', { data: 'chocolate' }).data is chocolate
+PASS new MessageEvent('eventType', { data: 12345 }).data is 12345
+PASS new MessageEvent('eventType', { data: 18446744073709551615 }).data is 18446744073709552000
+PASS new MessageEvent('eventType', { data: NaN }).data is NaN
+PASS new MessageEvent('eventType', { data: {valueOf: function () { return test_object; } } }).data == test_object is false
+PASS new MessageEvent('eventType', { get data() { return 123; } }).data is 123
+PASS new MessageEvent('eventType', { get data() { throw 'MessageEvent Error'; } }) threw exception MessageEvent Error.
+PASS new MessageEvent('eventType', { origin: 'melancholy' }).origin is melancholy
+PASS new MessageEvent('eventType', { origin: '' }).origin is
+PASS new MessageEvent('eventType', { origin: undefined }).origin is undefined
+PASS new MessageEvent('eventType', { origin: null }).origin is null
+PASS new MessageEvent('eventType', { origin: false }).origin is false
+PASS new MessageEvent('eventType', { origin: true }).origin is true
+PASS new
[webkit-changes] [97956] trunk/Source/WebCore
Title: [97956] trunk/Source/WebCore
Revision 97956
Author commit-qu...@webkit.org
Date 2011-10-20 03:22:05 -0700 (Thu, 20 Oct 2011)
Log Message
Enable geolocation client based flag for Qt5
https://bugs.webkit.org/show_bug.cgi?id=70330
Patch by Adenilson Cavalcanti adenilson.si...@openbossa.org on 2011-10-20
Reviewed by Kenneth Rohde Christiansen.
This will enable client based geolocation for Qt5.
No new tests, this enables flags for Qt5.
* features.pri:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.pri
Diff
Modified: trunk/Source/WebCore/ChangeLog (97955 => 97956)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 09:57:28 UTC (rev 97955)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 10:22:05 UTC (rev 97956)
@@ -1,3 +1,16 @@
+2011-10-20 Adenilson Cavalcanti adenilson.si...@openbossa.org
+
+Enable geolocation client based flag for Qt5
+https://bugs.webkit.org/show_bug.cgi?id=70330
+
+Reviewed by Kenneth Rohde Christiansen.
+
+This will enable client based geolocation for Qt5.
+
+No new tests, this enables flags for Qt5.
+
+* features.pri:
+
2011-10-20 Kentaro Hara hara...@chromium.org
Implement a MessageEvent constructor for V8
Modified: trunk/Source/WebCore/features.pri (97955 => 97956)
--- trunk/Source/WebCore/features.pri 2011-10-20 09:57:28 UTC (rev 97955)
+++ trunk/Source/WebCore/features.pri 2011-10-20 10:22:05 UTC (rev 97956)
@@ -120,7 +120,7 @@
# geolocation support if QtMobility exists
!contains(DEFINES, ENABLE_GEOLOCATION=.) {
-contains(MOBILITY_CONFIG, location) {
+contains(MOBILITY_CONFIG, location)|contains(QT_CONFIG, location) {
DEFINES += ENABLE_GEOLOCATION=1
DEFINES += ENABLE_CLIENT_BASED_GEOLOCATION=1
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97958] trunk/Source/WebCore
Title: [97958] trunk/Source/WebCore
Revision 97958
Author commit-qu...@webkit.org
Date 2011-10-20 03:38:30 -0700 (Thu, 20 Oct 2011)
Log Message
[EFL] Do not manually set the frameRect in different places in ScrollbarEfl.
https://bugs.webkit.org/show_bug.cgi?id=70427
Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-10-20
Reviewed by Kenneth Rohde Christiansen.
This commit is related to the effort towards having a different
scrollbar (with a size 0) for DumpRenderTree.
Scrollbar::Scrollbar() already calls setFrameRect() with the size
obtained from ScrollbarTheme::scrollbarThickness(), which is currently
always 0 for us, so the call to setFrameRect() in ScrollbarEfl's
constructor is not needed and would break things if scrollbarThickness
is changed to return another value.
The frameRect is also not changed in ScrollbarEfl::setParent() anymore,
as it also does not take scrollbarThickness() into account and thus
breaks using other themes such as ScrollbarThemeMock in DumpRenderTree.
Right now, it is always going to be 0 anyway.
It is still work in progress, though -- it'd be good to somehow move the
theming code to ScrollbarThemeEfl, as right now scrollbar EDCs with a
non-zero min size will not cause the scrollbars to have non-zero size.
No new tests, this is machinery needed to run the current tests.
* platform/efl/ScrollbarEfl.cpp:
(ScrollbarEfl::ScrollbarEfl):
(ScrollbarEfl::setParent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/ScrollbarEfl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97957 => 97958)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 10:25:06 UTC (rev 97957)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 10:38:30 UTC (rev 97958)
@@ -1,3 +1,34 @@
+2011-10-20 Raphael Kubo da Costa k...@profusion.mobi
+
+[EFL] Do not manually set the frameRect in different places in ScrollbarEfl.
+https://bugs.webkit.org/show_bug.cgi?id=70427
+
+Reviewed by Kenneth Rohde Christiansen.
+
+This commit is related to the effort towards having a different
+scrollbar (with a size 0) for DumpRenderTree.
+
+Scrollbar::Scrollbar() already calls setFrameRect() with the size
+obtained from ScrollbarTheme::scrollbarThickness(), which is currently
+always 0 for us, so the call to setFrameRect() in ScrollbarEfl's
+constructor is not needed and would break things if scrollbarThickness
+is changed to return another value.
+
+The frameRect is also not changed in ScrollbarEfl::setParent() anymore,
+as it also does not take scrollbarThickness() into account and thus
+breaks using other themes such as ScrollbarThemeMock in DumpRenderTree.
+Right now, it is always going to be 0 anyway.
+
+It is still work in progress, though -- it'd be good to somehow move the
+theming code to ScrollbarThemeEfl, as right now scrollbar EDCs with a
+non-zero min size will not cause the scrollbars to have non-zero size.
+
+No new tests, this is machinery needed to run the current tests.
+
+* platform/efl/ScrollbarEfl.cpp:
+(ScrollbarEfl::ScrollbarEfl):
+(ScrollbarEfl::setParent):
+
2011-10-20 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r97954.
Modified: trunk/Source/WebCore/platform/efl/ScrollbarEfl.cpp (97957 => 97958)
--- trunk/Source/WebCore/platform/efl/ScrollbarEfl.cpp 2011-10-20 10:25:06 UTC (rev 97957)
+++ trunk/Source/WebCore/platform/efl/ScrollbarEfl.cpp 2011-10-20 10:38:30 UTC (rev 97958)
@@ -53,7 +53,6 @@
, m_lastTotalSize(0)
, m_lastVisibleSize(0)
{
-Widget::setFrameRect(IntRect(0, 0, 0, 0));
}
ScrollbarEfl::~ScrollbarEfl()
@@ -90,7 +89,6 @@
void ScrollbarEfl::setParent(ScrollView* view)
{
Evas_Object* object = evasObject();
-Evas_Coord w, h;
Widget::setParent(view);
@@ -132,12 +130,6 @@
setPlatformWidget(object);
evas_object_smart_member_add(object, view-evasObject());
evas_object_show(object);
-
-edje_object_size_min_get(object, w, h);
-
-IntRect rect = frameRect();
-rect.setSize(IntSize(w, h));
-setFrameRect(rect);
}
void ScrollbarEfl::updateThumbPosition()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97959] trunk
Title: [97959] trunk
Revision 97959
Author vse...@chromium.org
Date 2011-10-20 04:03:02 -0700 (Thu, 20 Oct 2011)
Log Message
Web Inspector: Enable support for advanced search in script's static content provider.
https://bugs.webkit.org/show_bug.cgi?id=70354
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/search/search-in-static.html
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
* inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.performSearch):
* inspector/front-end/ContentProviders.js:
(WebInspector.StaticContentProvider.prototype.searchInContent):
* inspector/front-end/ElementsTreeOutline.js:
():
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype.performSearch):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._showSourceLine):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.createSearchRegex):
* inspector/front-end/utilities.js:
():
LayoutTests:
* http/tests/inspector/search/search-in-static-expected.txt: Added.
* http/tests/inspector/search/search-in-static.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js
trunk/Source/WebCore/inspector/front-end/ConsolePanel.js
trunk/Source/WebCore/inspector/front-end/ContentProviders.js
trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/SourceFrame.js
trunk/Source/WebCore/inspector/front-end/utilities.js
Added Paths
trunk/LayoutTests/http/tests/inspector/search/search-in-static-expected.txt
trunk/LayoutTests/http/tests/inspector/search/search-in-static.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97958 => 97959)
--- trunk/LayoutTests/ChangeLog 2011-10-20 10:38:30 UTC (rev 97958)
+++ trunk/LayoutTests/ChangeLog 2011-10-20 11:03:02 UTC (rev 97959)
@@ -1,3 +1,13 @@
+2011-10-20 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Enable support for advanced search in script's static content provider.
+https://bugs.webkit.org/show_bug.cgi?id=70354
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/search/search-in-static-expected.txt: Added.
+* http/tests/inspector/search/search-in-static.html: Added.
+
2011-10-20 Kentaro Hara hara...@chromium.org
Implement a MessageEvent constructor for V8
Added: trunk/LayoutTests/http/tests/inspector/search/search-in-static-expected.txt (0 => 97959)
--- trunk/LayoutTests/http/tests/inspector/search/search-in-static-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/search/search-in-static-expected.txt 2011-10-20 11:03:02 UTC (rev 97959)
@@ -0,0 +1,25 @@
+Tests static content provider search.
+
+Bug 70354
+http://127.0.0.1:8000/inspector/search/resources/search.js
+Search matches:
+lineNumber: 0, line: 'function searchTestUniqueString()'
+lineNumber: 3, line: '// searchTestUniqueString two occurences on the same line searchTestUniqueString'
+lineNumber: 9, line: 'searchTestUniqueString();'
+
+Search matches:
+lineNumber: 0, line: 'function searchTestUniqueString()'
+lineNumber: 3, line: '// searchTestUniqueString two occurences on the same line searchTestUniqueString'
+lineNumber: 9, line: 'searchTestUniqueString();'
+
+Search matches:
+lineNumber: 0, line: 'function searchTestUniqueString()'
+lineNumber: 3, line: '// searchTestUniqueString two occurences on the same line searchTestUniqueString'
+lineNumber: 9, line: 'searchTestUniqueString();'
+
+Search matches:
+lineNumber: 0, line: 'function searchTestUniqueString()'
+lineNumber: 3, line: '// searchTestUniqueString two occurences on the same line searchTestUniqueString'
+lineNumber: 9, line: 'searchTestUniqueString();'
+
+
Property changes on: trunk/LayoutTests/http/tests/inspector/search/search-in-static-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/http/tests/inspector/search/search-in-static.html (0 => 97959)
--- trunk/LayoutTests/http/tests/inspector/search/search-in-static.html (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/search/search-in-static.html 2011-10-20 11:03:02 UTC (rev 97959)
@@ -0,0 +1,67 @@
+html
+head
+script src=""
+script src=""
+script src=""
+script
+function test()
+{
+InspectorTest.runAfterResourcesAreFinished([search.js], step2);
+var resource;
+var staticContentProvider;
+
+function step2()
+{
+resource = WebInspector.resourceForURL(http://127.0.0.1:8000/inspector/search/resources/search.js);
+resource.requestContent(step3);
+}
+
+function step3()
+{
+
[webkit-changes] [97960] trunk/Source/WebKit2
Title: [97960] trunk/Source/WebKit2
Revision 97960
Author carlo...@webkit.org
Date 2011-10-20 04:16:37 -0700 (Thu, 20 Oct 2011)
Log Message
[GTK] Remove WebKitWebLoaderClientPrivate
https://bugs.webkit.org/show_bug.cgi?id=70488
Reviewed by Philippe Normand.
It's unused since r97920.
* GNUmakefile.am: Add WebKitWebLoaderClientPrivate.h.
* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkitWebLoaderClientAttachLoaderClientToPage): Renamed to make
it clear it's a private method of WebKitWebLoaderClient.
(webkit_web_loader_client_init): Remove
WebKitWebLoaderClientPrivate initialization.
(webkit_web_loader_client_class_init): Removed adding
WebKitWebLoaderClientPrivate struct as private data.
* UIProcess/API/gtk/WebKitWebLoaderClient.h: Remove
WebKitWebLoaderClientPrivate definition.
* UIProcess/API/gtk/WebKitWebLoaderClientPrivate.h: Move
webkitWebLoaderClientAttachLoaderClientToPage method here since
it's a private method implemented in WebKitWebLoaderClient, not in
WebKitWebView.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_set_loader_client): Use
webkitWebLoaderClientAttachLoaderClientToPage.
* UIProcess/API/gtk/WebKitWebViewPrivate.h: Remove
webkitWebLoaderClientAttachLoaderClientToPage prototype.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h
Added Paths
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClientPrivate.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (97959 => 97960)
--- trunk/Source/WebKit2/ChangeLog 2011-10-20 11:03:02 UTC (rev 97959)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-20 11:16:37 UTC (rev 97960)
@@ -1,3 +1,32 @@
+2011-10-20 Carlos Garcia Campos cgar...@igalia.com
+
+[GTK] Remove WebKitWebLoaderClientPrivate
+https://bugs.webkit.org/show_bug.cgi?id=70488
+
+Reviewed by Philippe Normand.
+
+It's unused since r97920.
+
+* GNUmakefile.am: Add WebKitWebLoaderClientPrivate.h.
+* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
+(webkitWebLoaderClientAttachLoaderClientToPage): Renamed to make
+it clear it's a private method of WebKitWebLoaderClient.
+(webkit_web_loader_client_init): Remove
+WebKitWebLoaderClientPrivate initialization.
+(webkit_web_loader_client_class_init): Removed adding
+WebKitWebLoaderClientPrivate struct as private data.
+* UIProcess/API/gtk/WebKitWebLoaderClient.h: Remove
+WebKitWebLoaderClientPrivate definition.
+* UIProcess/API/gtk/WebKitWebLoaderClientPrivate.h: Move
+webkitWebLoaderClientAttachLoaderClientToPage method here since
+it's a private method implemented in WebKitWebLoaderClient, not in
+WebKitWebView.
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkit_web_view_set_loader_client): Use
+webkitWebLoaderClientAttachLoaderClientToPage.
+* UIProcess/API/gtk/WebKitWebViewPrivate.h: Remove
+webkitWebLoaderClientAttachLoaderClientToPage prototype.
+
2011-10-10 Martin Robinson mrobin...@igalia.com
[GTK] [WebKit2] Allow sharing page clients between WebViews
Modified: trunk/Source/WebKit2/GNUmakefile.am (97959 => 97960)
--- trunk/Source/WebKit2/GNUmakefile.am 2011-10-20 11:03:02 UTC (rev 97959)
+++ trunk/Source/WebKit2/GNUmakefile.am 2011-10-20 11:16:37 UTC (rev 97960)
@@ -485,6 +485,7 @@
Source/WebKit2/UIProcess/API/gtk/WebKitWebContextPrivate.h \
Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.h \
Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp \
+ Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClientPrivate.h \
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h \
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp \
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h \
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp (97959 => 97960)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp 2011-10-20 11:03:02 UTC (rev 97959)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp 2011-10-20 11:16:37 UTC (rev 97960)
@@ -23,6 +23,7 @@
#include WebKitError.h
#include WebKitMarshal.h
#include WebKitPrivate.h
+#include WebKitWebLoaderClientPrivate.h
#include WebKitWebView.h
#include WebKitWebViewPrivate.h
#include WebKitWebViewBasePrivate.h
@@ -44,10 +45,6 @@
LAST_SIGNAL
};
-struct _WebKitWebLoaderClientPrivate {
-GRefPtrWebKitWebView view;
-};
-
static guint signals[LAST_SIGNAL] = { 0, };
G_DEFINE_TYPE(WebKitWebLoaderClient, webkit_web_loader_client, G_TYPE_OBJECT)
@@ -128,11 +125,11 @@
webkitWebViewSetEstimatedLoadProgress(webView, WKPageGetEstimatedProgress(page));
}
-void attachLoaderClientToPage(WKPageRef page, WebKitWebLoaderClient* client)
[webkit-changes] [97962] trunk/Source/WebCore
Title: [97962] trunk/Source/WebCore
Revision 97962
Author an...@apple.com
Date 2011-10-20 04:24:36 -0700 (Thu, 20 Oct 2011)
Log Message
Move rule matching and applying to separate functions from CSSStyleSelector::styleForElement
https://bugs.webkit.org/show_bug.cgi?id=70408
Reviewed by Andreas Kling.
- Move matching code to matchAllRules and applying to applyMatchedDeclarations.
- Encapsulate the matching results into a struct, use everywhere.
- Move first-line style adjustment to adjustRenderStyle().
- Remove unnecessary tests for resolveForRootDefault when applying the style
- Use applyMatchedDeclarations also from pseudoStyleForElement
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::applyMatchedDeclarations):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::MatchResult::MatchResult):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/CSSStyleSelector.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (97961 => 97962)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 11:23:58 UTC (rev 97961)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 11:24:36 UTC (rev 97962)
@@ -1,3 +1,28 @@
+2011-10-20 Antti Koivisto an...@apple.com
+
+Move rule matching and applying to separate functions from CSSStyleSelector::styleForElement
+https://bugs.webkit.org/show_bug.cgi?id=70408
+
+Reviewed by Andreas Kling.
+
+- Move matching code to matchAllRules and applying to applyMatchedDeclarations.
+- Encapsulate the matching results into a struct, use everywhere.
+- Move first-line style adjustment to adjustRenderStyle().
+- Remove unnecessary tests for resolveForRootDefault when applying the style
+- Use applyMatchedDeclarations also from pseudoStyleForElement
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::matchAllRules):
+(WebCore::CSSStyleSelector::matchUARules):
+(WebCore::CSSStyleSelector::styleForElement):
+(WebCore::CSSStyleSelector::pseudoStyleForElement):
+(WebCore::CSSStyleSelector::styleForPage):
+(WebCore::CSSStyleSelector::adjustRenderStyle):
+(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
+(WebCore::CSSStyleSelector::applyMatchedDeclarations):
+* css/CSSStyleSelector.h:
+(WebCore::CSSStyleSelector::MatchResult::MatchResult):
+
2011-10-19 Pavel Feldman pfeld...@google.com
Web Inspector: get rid of manual view hierarchy management.
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (97961 => 97962)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-10-20 11:23:58 UTC (rev 97961)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-10-20 11:24:36 UTC (rev 97962)
@@ -745,6 +745,70 @@
std::sort(m_matchedRules.begin(), m_matchedRules.end(), compareRules);
}
+void CSSStyleSelector::matchAllRules(MatchResult result)
+{
+matchUARules(result);
+
+// Now we check user sheet rules.
+if (m_matchAuthorAndUserStyles)
+matchRules(m_userStyle.get(), result.firstUserRule, result.lastUserRule, false);
+
+// Now check author rules, beginning first with presentational attributes mapped from HTML.
+if (m_styledElement) {
+// Ask if the HTML element has mapped attributes.
+if (m_styledElement-hasMappedAttributes()) {
+// Walk our attribute list and add in each decl.
+const NamedNodeMap* map = m_styledElement-attributeMap();
+for (unsigned i = 0; i map-length(); ++i) {
+Attribute* attr = map-attributeItem(i);
+if (attr-isMappedAttribute() attr-decl()) {
+result.lastAuthorRule = m_matchedDecls.size();
+if (result.firstAuthorRule == -1)
+result.firstAuthorRule = result.lastAuthorRule;
+addMatchedDeclaration(attr-decl());
+}
+}
+}
+
+// Now we check additional mapped declarations.
+// Tables and table cells share an additional mapped rule that must be applied
+// after all attributes, since their mapped style depends on the values of multiple attributes.
+if (m_styledElement-canHaveAdditionalAttributeStyleDecls()) {
+m_additionalAttributeStyleDecls.clear();
+m_styledElement-additionalAttributeStyleDecls(m_additionalAttributeStyleDecls);
+if (!m_additionalAttributeStyleDecls.isEmpty()) {
+unsigned additionalDeclsSize = m_additionalAttributeStyleDecls.size();
+if
[webkit-changes] [97964] trunk/Source/WebCore
Title: [97964] trunk/Source/WebCore
Revision 97964
Author kenn...@webkit.org
Date 2011-10-20 04:36:17 -0700 (Thu, 20 Oct 2011)
Log Message
Properly suspend/resume Geolocation/DeviceMotion/DeviceOrientation objects
https://bugs.webkit.org/show_bug.cgi?id=70328
Reviewed by Simon Hausmann.
Based on code from iOS and the N9.
No new tests, as the suspend/resume functionality is not fully working yet.
* dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::suspend):
(WebCore::DeviceMotionController::resume):
* dom/DeviceMotionController.h:
* dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::addListener):
(WebCore::DeviceOrientationController::removeListener):
(WebCore::DeviceOrientationController::removeAllListeners):
(WebCore::DeviceOrientationController::suspend):
(WebCore::DeviceOrientationController::resume):
* dom/DeviceOrientationController.h:
* dom/Document.cpp:
(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):
(WebCore::Document::stopActiveDOMObjects):
* dom/Document.h:
* dom/ScriptExecutionContext.h:
* page/GeolocationController.cpp:
(WebCore::GeolocationController::suspend):
(WebCore::GeolocationController::resume):
* page/GeolocationController.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DeviceMotionController.cpp
trunk/Source/WebCore/dom/DeviceMotionController.h
trunk/Source/WebCore/dom/DeviceOrientationController.cpp
trunk/Source/WebCore/dom/DeviceOrientationController.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/ScriptExecutionContext.h
trunk/Source/WebCore/page/GeolocationController.cpp
trunk/Source/WebCore/page/GeolocationController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (97963 => 97964)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 11:36:04 UTC (rev 97963)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 11:36:17 UTC (rev 97964)
@@ -1,3 +1,36 @@
+2011-10-20 Kenneth Rohde Christiansen kenn...@webkit.org
+
+Properly suspend/resume Geolocation/DeviceMotion/DeviceOrientation objects
+https://bugs.webkit.org/show_bug.cgi?id=70328
+
+Reviewed by Simon Hausmann.
+
+Based on code from iOS and the N9.
+
+No new tests, as the suspend/resume functionality is not fully working yet.
+
+* dom/DeviceMotionController.cpp:
+(WebCore::DeviceMotionController::suspend):
+(WebCore::DeviceMotionController::resume):
+* dom/DeviceMotionController.h:
+* dom/DeviceOrientationController.cpp:
+(WebCore::DeviceOrientationController::addListener):
+(WebCore::DeviceOrientationController::removeListener):
+(WebCore::DeviceOrientationController::removeAllListeners):
+(WebCore::DeviceOrientationController::suspend):
+(WebCore::DeviceOrientationController::resume):
+* dom/DeviceOrientationController.h:
+* dom/Document.cpp:
+(WebCore::Document::suspendActiveDOMObjects):
+(WebCore::Document::resumeActiveDOMObjects):
+(WebCore::Document::stopActiveDOMObjects):
+* dom/Document.h:
+* dom/ScriptExecutionContext.h:
+* page/GeolocationController.cpp:
+(WebCore::GeolocationController::suspend):
+(WebCore::GeolocationController::resume):
+* page/GeolocationController.h:
+
2011-10-20 Antti Koivisto an...@apple.com
Move rule matching and applying to separate functions from CSSStyleSelector::styleForElement
Modified: trunk/Source/WebCore/dom/DeviceMotionController.cpp (97963 => 97964)
--- trunk/Source/WebCore/dom/DeviceMotionController.cpp 2011-10-20 11:36:04 UTC (rev 97963)
+++ trunk/Source/WebCore/dom/DeviceMotionController.cpp 2011-10-20 11:36:17 UTC (rev 97964)
@@ -97,6 +97,18 @@
m_client-stopUpdating();
}
+void DeviceMotionController::suspend()
+{
+if (m_client)
+m_client-stopUpdating();
+}
+
+void DeviceMotionController::resume()
+{
+if (m_client !m_listeners.isEmpty())
+m_client-startUpdating();
+}
+
void DeviceMotionController::didChangeDeviceMotion(DeviceMotionData* deviceMotionData)
{
RefPtrDeviceMotionEvent event = DeviceMotionEvent::create(eventNames().devicemotionEvent, deviceMotionData);
Modified: trunk/Source/WebCore/dom/DeviceMotionController.h (97963 => 97964)
--- trunk/Source/WebCore/dom/DeviceMotionController.h 2011-10-20 11:36:04 UTC (rev 97963)
+++ trunk/Source/WebCore/dom/DeviceMotionController.h 2011-10-20 11:36:17 UTC (rev 97964)
@@ -44,6 +44,9 @@
void removeListener(DOMWindow*);
void removeAllListeners(DOMWindow*);
+void suspend();
+void resume();
+
void didChangeDeviceMotion(DeviceMotionData*);
bool isActive() { return !m_listeners.isEmpty(); }
Modified: trunk/Source/WebCore/dom/DeviceOrientationController.cpp (97963 => 97964)
--- trunk/Source/WebCore/dom/DeviceOrientationController.cpp 2011-10-20 11:36:04 UTC (rev 97963)
[webkit-changes] [97963] trunk/LayoutTests
Title: [97963] trunk/LayoutTests
Revision 97963
Author o...@webkit.org
Date 2011-10-20 04:36:04 -0700 (Thu, 20 Oct 2011)
Log Message
fast/frames/frame-element-name.html fails intermittently after r97881
https://bugs.webkit.org/show_bug.cgi?id=70487
Reviewed by Zoltán Herczeg.
r97881 made js/resources/js-test-pre.js (used in fast/frames/resource/frame-element-name.html)
slower with loading css dynamically. We have to wait for loading all frames to get correct results.
* fast/frames/frame-element-name.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/frames/frame-element-name.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97962 => 97963)
--- trunk/LayoutTests/ChangeLog 2011-10-20 11:24:36 UTC (rev 97962)
+++ trunk/LayoutTests/ChangeLog 2011-10-20 11:36:04 UTC (rev 97963)
@@ -1,3 +1,15 @@
+2011-10-20 Csaba Osztrogonác o...@webkit.org
+
+fast/frames/frame-element-name.html fails intermittently after r97881
+https://bugs.webkit.org/show_bug.cgi?id=70487
+
+Reviewed by Zoltán Herczeg.
+
+r97881 made js/resources/js-test-pre.js (used in fast/frames/resource/frame-element-name.html)
+slower with loading css dynamically. We have to wait for loading all frames to get correct results.
+
+* fast/frames/frame-element-name.html:
+
2011-10-19 Pavel Feldman pfeld...@google.com
Web Inspector: get rid of manual view hierarchy management.
Modified: trunk/LayoutTests/fast/frames/frame-element-name.html (97962 => 97963)
--- trunk/LayoutTests/fast/frames/frame-element-name.html 2011-10-20 11:24:36 UTC (rev 97962)
+++ trunk/LayoutTests/fast/frames/frame-element-name.html 2011-10-20 11:36:04 UTC (rev 97963)
@@ -1,11 +1,20 @@
html
head
script
-if (window.layoutTestController)
+if (window.layoutTestController) {
layoutTestController.dumpChildFramesAsText();
+layoutTestController.waitUntilDone();
+}
+
+function framesLoaded()
+{
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
/script
/head
- frameset border=1 cols=150,150,150,150,150,* style='border: solid 1px;'
+ frameset border=1 cols=150,150,150,150,150,* style='border: solid 1px;' _onload_=framesLoaded()
frame marginwidth=1 src="" name=left
frame src=""
frame src="" name=_blank
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97966] trunk/Source/WebCore
Title: [97966] trunk/Source/WebCore
Revision 97966
Author pfeld...@chromium.org
Date 2011-10-20 04:55:35 -0700 (Thu, 20 Oct 2011)
Log Message
Not reviewed: follow up to 97961 - dispatching of hide on detach was missing.
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype.show):
* inspector/front-end/View.js:
(WebInspector.View.prototype.detach):
* inspector/front-end/utilities.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/AuditsPanel.js
trunk/Source/WebCore/inspector/front-end/View.js
trunk/Source/WebCore/inspector/front-end/utilities.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (97965 => 97966)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 11:37:26 UTC (rev 97965)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 11:55:35 UTC (rev 97966)
@@ -1,3 +1,13 @@
+2011-10-20 Pavel Feldman pfeld...@google.com
+
+Not reviewed: follow up to 97961 - dispatching of hide on detach was missing.
+
+* inspector/front-end/AuditsPanel.js:
+(WebInspector.AuditsPanel.prototype.show):
+* inspector/front-end/View.js:
+(WebInspector.View.prototype.detach):
+* inspector/front-end/utilities.js:
+
2011-10-20 Kenneth Rohde Christiansen kenn...@webkit.org
Properly suspend/resume Geolocation/DeviceMotion/DeviceOrientation objects
Modified: trunk/Source/WebCore/inspector/front-end/AuditsPanel.js (97965 => 97966)
--- trunk/Source/WebCore/inspector/front-end/AuditsPanel.js 2011-10-20 11:37:26 UTC (rev 97965)
+++ trunk/Source/WebCore/inspector/front-end/AuditsPanel.js 2011-10-20 11:55:35 UTC (rev 97966)
@@ -247,8 +247,8 @@
show: function()
{
WebInspector.Panel.prototype.show.call(this);
-
-this.auditsItemTreeElement.select();
+if (!this._visibleView)
+this.auditsItemTreeElement.select();
},
updateMainViewWidth: function(width)
Modified: trunk/Source/WebCore/inspector/front-end/View.js (97965 => 97966)
--- trunk/Source/WebCore/inspector/front-end/View.js 2011-10-20 11:37:26 UTC (rev 97965)
+++ trunk/Source/WebCore/inspector/front-end/View.js 2011-10-20 11:55:35 UTC (rev 97966)
@@ -99,6 +99,11 @@
detach: function()
{
+if (this._visible) {
+this.dispatchToSelfAndChildren(willHide, true);
+this._visible = false;
+}
+
this.dispatchToSelfAndChildren(willDetach, false);
if (this.element.parentElement)
Modified: trunk/Source/WebCore/inspector/front-end/utilities.js (97965 => 97966)
--- trunk/Source/WebCore/inspector/front-end/utilities.js 2011-10-20 11:37:26 UTC (rev 97965)
+++ trunk/Source/WebCore/inspector/front-end/utilities.js 2011-10-20 11:55:35 UTC (rev 97966)
@@ -977,7 +977,7 @@
/**
* @param {string} query
- * @param {boolean} ignoreCase
+ * @param {boolean} caseSensitive
* @param {boolean} isRegex
* @return {RegExp}
*/
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97970] trunk/Source/WebCore
Title: [97970] trunk/Source/WebCore
Revision 97970
Author zherc...@webkit.org
Date 2011-10-20 06:05:21 -0700 (Thu, 20 Oct 2011)
Log Message
Improve NEON based GaussianBlur
https://bugs.webkit.org/show_bug.cgi?id=70493
Reviewed by Csaba Osztrogonác.
vmov instruction is less complex than vtbl.
* platform/graphics/filters/arm/FEGaussianBlurNEON.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97969 => 97970)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 12:57:47 UTC (rev 97969)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 13:05:21 UTC (rev 97970)
@@ -1,3 +1,14 @@
+2011-10-20 Zoltan Herczeg zherc...@webkit.org
+
+Improve NEON based GaussianBlur
+https://bugs.webkit.org/show_bug.cgi?id=70493
+
+Reviewed by Csaba Osztrogonác.
+
+vmov instruction is less complex than vtbl.
+
+* platform/graphics/filters/arm/FEGaussianBlurNEON.cpp:
+
2011-10-20 Pavel Feldman pfeld...@google.com
Not reviewed: follow up to 97961 - dispatching of hide on detach was missing.
Modified: trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.cpp (97969 => 97970)
--- trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.cpp 2011-10-20 12:57:47 UTC (rev 97969)
+++ trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.cpp 2011-10-20 13:05:21 UTC (rev 97970)
@@ -34,8 +34,6 @@
namespace WebCore {
static WTF_ALIGNED(unsigned char, s_FEGaussianBlurConstantsForNeon[], 16) = {
-// Mapping from ARM to NEON registers.
-0, 16, 16, 16, 1, 16, 16, 16, 2, 16, 16, 16, 3, 16, 16, 16,
// Mapping from NEON to ARM registers.
0, 4, 8, 12, 16, 16, 16, 16
};
@@ -93,10 +91,7 @@
#define PIXEL_D11 d5[1]
#define REMAINING_STRIDES_S0s12
-#define READ_RANGE d16-d18
-#define REMAP_ARM_NEON1_Q d16
-#define REMAP_ARM_NEON2_Q d17
-#define REMAP_NEON_ARM_Qd18
+#define REMAP_NEON_ARM_Qd16
asm ( // NOLINT
.globl TOSTRING(neonDrawAllChannelGaussianBlur) NL
@@ -119,7 +114,7 @@
movcs MAX_KERNEL_SIZE_R , STRIDE_WIDTH_R NL
add SOURCE_LINE_END_R , SOURCE_LINE_END_R , SOURCE_R NL
vdup.f32 INVERTED_KERNEL_SIZE_Q , INIT_INVERTED_KERNEL_SIZE_R NL
-vld1.f32 { READ_RANGE }, [ INIT_PAINTING_CONSTANTS_R ]! NL
+vld1.f32 { REMAP_NEON_ARM_Q }, [ INIT_PAINTING_CONSTANTS_R ]! NL
.allChannelMainLoop: NL
@@ -131,8 +126,8 @@
bcs .allChannelInitSumDone NL
.allChannelInitSum: NL
vld1.u32 PIXEL_D00 , [ INIT_SUM_R ], STRIDE_R NL
-vtbl.8 PIXEL_D1 , { PIXEL_D0 }, REMAP_ARM_NEON2_Q NL
-vtbl.8 PIXEL_D0 , { PIXEL_D0 }, REMAP_ARM_NEON1_Q NL
+vmovl.u8 PIXEL_Q , PIXEL_D0 NL
+vmovl.u16 PIXEL_Q , PIXEL_D0 NL
vadd.u32 SUM_Q , SUM_Q , PIXEL_Q NL
cmp INIT_SUM_R , SOURCE_END_R NL
bcc .allChannelInitSum NL
@@ -154,16 +149,16 @@
cmp LEFT_R , SOURCE_R NL
bcc .allChannelSkipLeft NL
vld1.u32 PIXEL_D00 , [ LEFT_R ] NL
-vtbl.8 PIXEL_D1 , { PIXEL_D0 }, REMAP_ARM_NEON2_Q NL
-vtbl.8 PIXEL_D0 , { PIXEL_D0 }, REMAP_ARM_NEON1_Q NL
+vmovl.u8 PIXEL_Q , PIXEL_D0 NL
+vmovl.u16 PIXEL_Q , PIXEL_D0 NL
vsub.u32 SUM_Q , SUM_Q , PIXEL_Q NL
.allChannelSkipLeft: NL
cmp RIGHT_R , SOURCE_END_R NL
bcs .allChannelSkipRight NL
vld1.u32 PIXEL_D00 , [ RIGHT_R ] NL
-vtbl.8 PIXEL_D1 , { PIXEL_D0 }, REMAP_ARM_NEON2_Q NL
-vtbl.8 PIXEL_D0 , { PIXEL_D0 }, REMAP_ARM_NEON1_Q NL
+vmovl.u8 PIXEL_Q , PIXEL_D0 NL
+vmovl.u16 PIXEL_Q , PIXEL_D0 NL
vadd.u32 SUM_Q , SUM_Q , PIXEL_Q NL
.allChannelSkipRight: NL
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97971] trunk/Source/WebCore
Title: [97971] trunk/Source/WebCore
Revision 97971
Author carycl...@google.com
Date 2011-10-20 06:18:51 -0700 (Thu, 20 Oct 2011)
Log Message
[Chromium Skia on Mac] Improve focus ring
https://bugs.webkit.org/show_bug.cgi?id=70124
Reviewed by Adam Barth.
The focus ring code formerly outset the bounds of
the component rectangles by fractional amounts. Because
the rectangles are SkIRect (integer based), the fractional
outset had no effect.
The equivalent code in GraphicsContextMac.mm computes
the curve radius and rectangle outset with integers, so
the use of floats in Skia's case, besides not working,
is unnecessary.
The Skia code also failed to take the offset into account.
In LayoutTests, the focus rings either have an offset of
0 or 2. The CoreGraphics code increases the ring's rectangles
by the offset, then passes the result to wkDrawFocusRing.
I did not find any documentation about how wkDrawFocusRing
further inflates the focus ring, but empirically I determined
that adding 2 to the offset generated rings with identical
outer diameters.
With these adjustments, the layout tests generate focus rings
in the Skia on Mac case that match the coverage of the
Chromium CG-based platform, in particular, matching:
editing/inserting/editable-inline-element.html
editing/selection/3690703-2.html
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97970 => 97971)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 13:05:21 UTC (rev 97970)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 13:18:51 UTC (rev 97971)
@@ -1,3 +1,41 @@
+2011-10-20 Cary Clark carycl...@google.com
+
+[Chromium Skia on Mac] Improve focus ring
+https://bugs.webkit.org/show_bug.cgi?id=70124
+
+Reviewed by Adam Barth.
+
+The focus ring code formerly outset the bounds of
+the component rectangles by fractional amounts. Because
+the rectangles are SkIRect (integer based), the fractional
+outset had no effect.
+
+The equivalent code in GraphicsContextMac.mm computes
+the curve radius and rectangle outset with integers, so
+the use of floats in Skia's case, besides not working,
+is unnecessary.
+
+The Skia code also failed to take the offset into account.
+In LayoutTests, the focus rings either have an offset of
+0 or 2. The CoreGraphics code increases the ring's rectangles
+by the offset, then passes the result to wkDrawFocusRing.
+
+I did not find any documentation about how wkDrawFocusRing
+further inflates the focus ring, but empirically I determined
+that adding 2 to the offset generated rings with identical
+outer diameters.
+
+With these adjustments, the layout tests generate focus rings
+in the Skia on Mac case that match the coverage of the
+Chromium CG-based platform, in particular, matching:
+
+editing/inserting/editable-inline-element.html
+editing/selection/3690703-2.html
+
+* platform/graphics/skia/GraphicsContextSkia.cpp:
+(WebCore::getFocusRingOutset):
+(WebCore::GraphicsContext::drawFocusRing):
+
2011-10-20 Zoltan Herczeg zherc...@webkit.org
Improve NEON based GaussianBlur
Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (97970 => 97971)
--- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2011-10-20 13:05:21 UTC (rev 97970)
+++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2011-10-20 13:18:51 UTC (rev 97971)
@@ -538,16 +538,16 @@
#endif
}
-static inline SkScalar getFocusRingOutset()
+static inline int getFocusRingOutset(int offset)
{
#if PLATFORM(CHROMIUM) OS(DARWIN)
-return 0.75f;
+return offset + 2;
#else
-return 0.5f;
+return 0;
#endif
}
-void GraphicsContext::drawFocusRing(const VectorIntRect rects, int width, int /* offset */, const Color color)
+void GraphicsContext::drawFocusRing(const VectorIntRect rects, int width, int offset, const Color color)
{
if (paintingDisabled())
return;
@@ -557,7 +557,7 @@
return;
SkRegion focusRingRegion;
-const SkScalar focusRingOutset = getFocusRingOutset();
+const int focusRingOutset = getFocusRingOutset(offset);
for (unsigned i = 0; i rectCount; i++) {
SkIRect r = rects[i];
r.inset(-focusRingOutset, -focusRingOutset);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97972] trunk/Source/WebCore
Title: [97972] trunk/Source/WebCore
Revision 97972
Author kenn...@webkit.org
Date 2011-10-20 06:21:26 -0700 (Thu, 20 Oct 2011)
Log Message
m_client in DeviceMotionController can never be 0, so no need to check for it
https://bugs.webkit.org/show_bug.cgi?id=70490
Reviewed by Simon Hausmann.
No behavior change, thus no new tests.
* dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::timerFired):
(WebCore::DeviceMotionController::addListener):
(WebCore::DeviceMotionController::removeListener):
(WebCore::DeviceMotionController::removeAllListeners):
(WebCore::DeviceMotionController::suspend):
(WebCore::DeviceMotionController::resume):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DeviceMotionController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97971 => 97972)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 13:18:51 UTC (rev 97971)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 13:21:26 UTC (rev 97972)
@@ -1,3 +1,20 @@
+2011-10-20 Kenneth Rohde Christiansen kenn...@webkit.org
+
+m_client in DeviceMotionController can never be 0, so no need to check for it
+https://bugs.webkit.org/show_bug.cgi?id=70490
+
+Reviewed by Simon Hausmann.
+
+No behavior change, thus no new tests.
+
+* dom/DeviceMotionController.cpp:
+(WebCore::DeviceMotionController::timerFired):
+(WebCore::DeviceMotionController::addListener):
+(WebCore::DeviceMotionController::removeListener):
+(WebCore::DeviceMotionController::removeAllListeners):
+(WebCore::DeviceMotionController::suspend):
+(WebCore::DeviceMotionController::resume):
+
2011-10-20 Cary Clark carycl...@google.com
[Chromium Skia on Mac] Improve focus ring
Modified: trunk/Source/WebCore/dom/DeviceMotionController.cpp (97971 => 97972)
--- trunk/Source/WebCore/dom/DeviceMotionController.cpp 2011-10-20 13:18:51 UTC (rev 97971)
+++ trunk/Source/WebCore/dom/DeviceMotionController.cpp 2011-10-20 13:21:26 UTC (rev 97972)
@@ -48,10 +48,10 @@
void DeviceMotionController::timerFired(TimerDeviceMotionController* timer)
{
ASSERT_UNUSED(timer, timer == m_timer);
-ASSERT(!m_client || m_client-currentDeviceMotion());
+ASSERT(m_client-currentDeviceMotion());
m_timer.stop();
-RefPtrDeviceMotionData deviceMotionData = m_client ? m_client-currentDeviceMotion() : DeviceMotionData::create();
+RefPtrDeviceMotionData deviceMotionData = m_client-currentDeviceMotion();
RefPtrDeviceMotionEvent event = DeviceMotionEvent::create(eventNames().devicemotionEvent, deviceMotionData.get());
VectorRefPtrDOMWindow listenersVector;
@@ -63,9 +63,9 @@
void DeviceMotionController::addListener(DOMWindow* window)
{
-// If no client is present or the client already has motion data,
+// If the client already has motion data,
// immediately trigger an asynchronous response.
-if (!m_client || m_client-currentDeviceMotion()) {
+if (m_client-currentDeviceMotion()) {
m_newListeners.add(window);
if (!m_timer.isActive())
m_timer.startOneShot(0);
@@ -73,7 +73,7 @@
bool wasEmpty = m_listeners.isEmpty();
m_listeners.add(window);
-if (wasEmpty m_client)
+if (wasEmpty)
m_client-startUpdating();
}
@@ -81,7 +81,7 @@
{
m_listeners.remove(window);
m_newListeners.remove(window);
-if (m_listeners.isEmpty() m_client)
+if (m_listeners.isEmpty())
m_client-stopUpdating();
}
@@ -93,19 +93,18 @@
m_listeners.removeAll(window);
m_newListeners.remove(window);
-if (m_listeners.isEmpty() m_client)
+if (m_listeners.isEmpty())
m_client-stopUpdating();
}
void DeviceMotionController::suspend()
{
-if (m_client)
-m_client-stopUpdating();
+m_client-stopUpdating();
}
void DeviceMotionController::resume()
{
-if (m_client !m_listeners.isEmpty())
+if (!m_listeners.isEmpty())
m_client-startUpdating();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97975] trunk
Title: [97975] trunk Revision 97975 Author vse...@chromium.org Date 2011-10-20 07:22:46 -0700 (Thu, 20 Oct 2011) Log Message Web Inspector: Advanced search results should keep working after pretty print toggled. https://bugs.webkit.org/show_bug.cgi?id=70347 Reviewed by Pavel Feldman. Source/WebCore: * inspector/front-end/AdvancedSearchController.js: (WebInspector.SearchScope.prototype.createSearchResultsPane): (WebInspector.FileBasedSearchResultsPane.prototype.createAnchor): (WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult): (WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges): (WebInspector.FileBasedSearchResultsPane.prototype._createContentSpan): * inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype._materializeBreakpoint): * inspector/front-end/CompilerSourceMapping.js: (WebInspector.CompilerSourceMapping.prototype.sourceLocationToCompiledLocation): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.createLinkifier): (WebInspector.DebuggerPresentationModel.prototype.continueToLine): (WebInspector.DebuggerPresentationModel.LinkifierFormatter): (WebInspector.DebuggerPresentationModel.LinkifierFormatter.prototype.formatRawSourceCodeAnchor): (WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter): (WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor): (WebInspector.DebuggerPresentationModel.Linkifier): (WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation): (WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyResource): (WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawSourceCode): (WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor): * inspector/front-end/RawSourceCode.js: (WebInspector.RawSourceCode.SourceMapping.prototype.uiLocationToRawLocation): (WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation): (WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation): (WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation): * inspector/front-end/ScriptsSearchScope.js: (WebInspector.ScriptsSearchResultsPane): (WebInspector.ScriptsSearchResultsPane.prototype.createAnchor): (WebInspector.ScriptsSearchResultsPane.LinkifierFormatter): (WebInspector.ScriptsSearchResultsPane.LinkifierFormatter.prototype.formatRawSourceCodeAnchor): * inspector/front-end/inspector.html: LayoutTests: * inspector/debugger/raw-source-code.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/debugger/raw-source-code.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js trunk/Source/WebCore/inspector/front-end/BreakpointManager.js trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js trunk/Source/WebCore/inspector/front-end/RawSourceCode.js trunk/Source/WebCore/inspector/front-end/ScriptsSearchScope.js trunk/Source/WebCore/inspector/front-end/inspector.html Diff Modified: trunk/LayoutTests/ChangeLog (97974 => 97975) --- trunk/LayoutTests/ChangeLog 2011-10-20 14:13:43 UTC (rev 97974) +++ trunk/LayoutTests/ChangeLog 2011-10-20 14:22:46 UTC (rev 97975) @@ -1,3 +1,12 @@ +2011-10-20 Vsevolod Vlasov vse...@chromium.org + +Web Inspector: Advanced search results should keep working after pretty print toggled. +https://bugs.webkit.org/show_bug.cgi?id=70347 + +Reviewed by Pavel Feldman. + +* inspector/debugger/raw-source-code.html: + 2011-10-20 Leandro Pereira lean...@profusion.mobi Unreviewed. Add EFL baselines for dom, editing, fonts, mathml, media, printing, scrollbars and security. Modified: trunk/LayoutTests/inspector/debugger/raw-source-code.html (97974 => 97975) --- trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-20 14:13:43 UTC (rev 97974) +++ trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-20 14:22:46 UTC (rev 97975) @@ -112,7 +112,7 @@ InspectorTest.assertEquals(true, uiSourceCode.isContentScript); InspectorTest.assertEquals(rawSourceCode, uiSourceCode.rawSourceCode); checkUILocation(uiSourceCode, 0, 5, sourceMapping.rawLocationToUILocation(createRawLocation(0, 5))); -checkRawLocation(script, 10, 0, sourceMapping.uiLocationToRawLocation(uiSourceCode, 10)); +checkRawLocation(script, 10, 0, sourceMapping.uiLocationToRawLocation(uiSourceCode, 10, 0)); uiSourceCode.requestContent(didRequestContent); function didRequestContent(mimeType, content) @@ -178,8 +178,8 @@ rawSourceCode.addScript(script2); rawSourceCode.forceUpdateSourceMapping(); checkUILocation(uiSourceCode, 1, 20,
[webkit-changes] [97976] trunk/Tools
Title: [97976] trunk/Tools Revision 97976 Author lean...@webkit.org Date 2011-10-20 07:29:22 -0700 (Thu, 20 Oct 2011) Log Message [EFL] Unreviewed. Build fix after r97043. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Use ewk_view_scale_set() instead of ewk_view_page_scale(). * DumpRenderTree/efl/EventSender.cpp: (scalePageByCallback): Ditto. Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp trunk/Tools/DumpRenderTree/efl/EventSender.cpp Diff Modified: trunk/Tools/ChangeLog (97975 => 97976) --- trunk/Tools/ChangeLog 2011-10-20 14:22:46 UTC (rev 97975) +++ trunk/Tools/ChangeLog 2011-10-20 14:29:22 UTC (rev 97976) @@ -1,3 +1,12 @@ +2011-10-20 Leandro Pereira lean...@profusion.mobi + +[EFL] Unreviewed. Build fix after r97043. + +* DumpRenderTree/efl/DumpRenderTreeChrome.cpp: +(DumpRenderTreeChrome::resetDefaultsToConsistentValues): Use ewk_view_scale_set() instead of ewk_view_page_scale(). +* DumpRenderTree/efl/EventSender.cpp: +(scalePageByCallback): Ditto. + 2011-10-20 Philippe Normand pnorm...@igalia.com Unreviewed. Adding myself to watchlists. Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (97975 => 97976) --- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2011-10-20 14:22:46 UTC (rev 97975) +++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2011-10-20 14:29:22 UTC (rev 97976) @@ -176,7 +176,7 @@ ewk_view_setting_scripts_can_close_windows_set(mainView(), EINA_TRUE); ewk_view_zoom_set(mainView(), 1.0, 0, 0); -ewk_view_page_scale(mainView(), 1.0, 0, 0); +ewk_view_scale_set(mainView(), 1.0, 0, 0); ewk_history_clear(ewk_view_history_get(mainView())); Modified: trunk/Tools/DumpRenderTree/efl/EventSender.cpp (97975 => 97976) --- trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2011-10-20 14:22:46 UTC (rev 97975) +++ trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2011-10-20 14:29:22 UTC (rev 97976) @@ -443,7 +443,7 @@ float scaleFactor = JSValueToNumber(context, arguments[0], exception); float x = JSValueToNumber(context, arguments[1], exception); float y = JSValueToNumber(context, arguments[2], exception); -ewk_view_page_scale(view, scaleFactor, x, y); +ewk_view_scale_set(view, scaleFactor, x, y); return JSValueMakeUndefined(context); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97977] trunk/Source/WebCore
Title: [97977] trunk/Source/WebCore
Revision 97977
Author pfeld...@chromium.org
Date 2011-10-20 07:51:48 -0700 (Thu, 20 Oct 2011)
Log Message
Web Inspector: minor CPU profiling UX improvements
https://bugs.webkit.org/show_bug.cgi?id=70499
Store profile type. Store time percentage toggle state.
Reviewed by Yury Semikhatsky.
* inspector/front-end/ProfileDataGridTree.js:
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView.profileCallback):
(WebInspector.CPUProfileView.prototype._changeView.set else):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ProfileDataGridTree.js
trunk/Source/WebCore/inspector/front-end/ProfileView.js
trunk/Source/WebCore/inspector/front-end/networkLogView.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (97976 => 97977)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 14:29:22 UTC (rev 97976)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 14:51:48 UTC (rev 97977)
@@ -1,3 +1,17 @@
+2011-10-20 Pavel Feldman pfeld...@google.com
+
+Web Inspector: minor CPU profiling UX improvements
+https://bugs.webkit.org/show_bug.cgi?id=70499
+
+Store profile type. Store time percentage toggle state.
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/ProfileDataGridTree.js:
+* inspector/front-end/ProfileView.js:
+(WebInspector.CPUProfileView.profileCallback):
+(WebInspector.CPUProfileView.prototype._changeView.set else):
+
2011-10-20 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Advanced search results should keep working after pretty print toggled.
Modified: trunk/Source/WebCore/inspector/front-end/ProfileDataGridTree.js (97976 => 97977)
--- trunk/Source/WebCore/inspector/front-end/ProfileDataGridTree.js 2011-10-20 14:29:22 UTC (rev 97976)
+++ trunk/Source/WebCore/inspector/front-end/ProfileDataGridTree.js 2011-10-20 14:51:48 UTC (rev 97977)
@@ -58,17 +58,17 @@
data[function] = this.functionName;
data[calls] = this.numberOfCalls;
-if (this.profileView.showSelfTimeAsPercent)
+if (this.profileView.showSelfTimeAsPercent.get())
data[self] = WebInspector.UIString(%.2f%%, this.selfPercent);
else
data[self] = formatMilliseconds(this.selfTime);
-if (this.profileView.showTotalTimeAsPercent)
+if (this.profileView.showTotalTimeAsPercent.get())
data[total] = WebInspector.UIString(%.2f%%, this.totalPercent);
else
data[total] = formatMilliseconds(this.totalTime);
-if (this.profileView.showAverageTimeAsPercent)
+if (this.profileView.showAverageTimeAsPercent.get())
data[average] = WebInspector.UIString(%.2f%%, this.averagePercent);
else
data[average] = formatMilliseconds(this.averageTime);
Modified: trunk/Source/WebCore/inspector/front-end/ProfileView.js (97976 => 97977)
--- trunk/Source/WebCore/inspector/front-end/ProfileView.js 2011-10-20 14:29:22 UTC (rev 97976)
+++ trunk/Source/WebCore/inspector/front-end/ProfileView.js 2011-10-20 14:51:48 UTC (rev 97977)
@@ -30,11 +30,12 @@
WebInspector.View.call(this);
this.element.addStyleClass(profile-view);
+
+this.showSelfTimeAsPercent = WebInspector.settings.createSetting(cpuProfilerShowSelfTimeAsPercent, true);
+this.showTotalTimeAsPercent = WebInspector.settings.createSetting(cpuProfilerShowTotalTimeAsPercent, true);
+this.showAverageTimeAsPercent = WebInspector.settings.createSetting(cpuProfilerShowAverageTimeAsPercent, true);
+this._viewType = WebInspector.settings.createSetting(cpuProfilerView, WebInspector.CPUProfileView._TypeHeavy);
-this.showSelfTimeAsPercent = true;
-this.showTotalTimeAsPercent = true;
-this.showAverageTimeAsPercent = true;
-
var columns = { self: { title: WebInspector.UIString(Self), width: 72px, sort: descending, sortable: true },
total: { title: WebInspector.UIString(Total), width: 72px, sortable: true },
average: { title: WebInspector.UIString(Average), width: 72px, sortable: true },
@@ -54,7 +55,6 @@
this.viewSelectElement = document.createElement(select);
this.viewSelectElement.className = status-bar-item;
this.viewSelectElement.addEventListener(change, this._changeView.bind(this), false);
-this.view = Heavy;
var heavyViewOption = document.createElement(option);
heavyViewOption.label = WebInspector.UIString(Heavy (Bottom Up));
@@ -62,6 +62,7 @@
treeViewOption.label = WebInspector.UIString(Tree (Top Down));
this.viewSelectElement.appendChild(heavyViewOption);
this.viewSelectElement.appendChild(treeViewOption);
+this.viewSelectElement.selectedIndex = this._viewType.get() === WebInspector.CPUProfileView._TypeHeavy ? 0 : 1;
this.percentButton = new WebInspector.StatusBarButton(, percent-time-status-bar-item);
this.percentButton.addEventListener(click,
[webkit-changes] [97978] trunk/Source/WebCore
Title: [97978] trunk/Source/WebCore
Revision 97978
Author loi...@chromium.org
Date 2011-10-20 07:55:15 -0700 (Thu, 20 Oct 2011)
Log Message
Unreviewed fix for Date.prototype.toISO8601Compact.
It was generated wrong string for the dates with no leading zeros like 2011.11.11.
* inspector/front-end/utilities.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/utilities.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (97977 => 97978)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 14:51:48 UTC (rev 97977)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 14:55:15 UTC (rev 97978)
@@ -1,3 +1,10 @@
+2011-10-20 Ilya Tikhonovsky loi...@chromium.org
+
+Unreviewed fix for Date.prototype.toISO8601Compact.
+It was generated wrong string for the dates with no leading zeros like 2011.11.11.
+
+* inspector/front-end/utilities.js:
+
2011-10-20 Pavel Feldman pfeld...@google.com
Web Inspector: minor CPU profiling UX improvements
Modified: trunk/Source/WebCore/inspector/front-end/utilities.js (97977 => 97978)
--- trunk/Source/WebCore/inspector/front-end/utilities.js 2011-10-20 14:51:48 UTC (rev 97977)
+++ trunk/Source/WebCore/inspector/front-end/utilities.js 2011-10-20 14:55:15 UTC (rev 97978)
@@ -540,7 +540,7 @@
{
function leadZero(x)
{
-return x 9 ? x : '0' + x
+return x 9 ? '' + x : '0' + x
}
return this.getFullYear() +
leadZero(this.getMonth() + 1) +
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97979] trunk/Source/WebKit/gtk
Title: [97979] trunk/Source/WebKit/gtk
Revision 97979
Author k...@webkit.org
Date 2011-10-20 08:00:16 -0700 (Thu, 20 Oct 2011)
Log Message
[GTK] webkitgtk's pkgconfig file needs to require _javascript_coregtk
https://bugs.webkit.org/show_bug.cgi?id=70500
Reviewed by Philippe Normand.
* webkit.pc.in: add _javascript_coregtk to Requires
Modified Paths
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit.pc.in
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (97978 => 97979)
--- trunk/Source/WebKit/gtk/ChangeLog 2011-10-20 14:55:15 UTC (rev 97978)
+++ trunk/Source/WebKit/gtk/ChangeLog 2011-10-20 15:00:16 UTC (rev 97979)
@@ -1,3 +1,12 @@
+2011-10-20 Gustavo Noronha Silva g...@gnome.org
+
+[GTK] webkitgtk's pkgconfig file needs to require _javascript_coregtk
+https://bugs.webkit.org/show_bug.cgi?id=70500
+
+Reviewed by Philippe Normand.
+
+* webkit.pc.in: add _javascript_coregtk to Requires
+
2011-10-19 Gustavo Noronha Silva g...@gnome.org
GTK+ build fix. Rename the INCLUDES variable so it is not picked
Modified: trunk/Source/WebKit/gtk/webkit.pc.in (97978 => 97979)
--- trunk/Source/WebKit/gtk/webkit.pc.in 2011-10-20 14:55:15 UTC (rev 97978)
+++ trunk/Source/WebKit/gtk/webkit.pc.in 2011-10-20 15:00:16 UTC (rev 97979)
@@ -6,6 +6,6 @@
Name: WebKit
Description: Web content engine for GTK+
Version: @VERSION@
-Requires: glib-2.0 gtk+-@GTK_API_VERSION@ libsoup-2.4
+Requires: glib-2.0 gtk+-@GTK_API_VERSION@ libsoup-2.4 _javascript_coregtk-@WEBKITGTK_API_VERSION@
Libs: -L${libdir} -lwebkitgtk-@WEBKITGTK_API_VERSION@
Cflags: -I${includedir}/webkitgtk-@WEBKITGTK_API_VERSION@
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97980] trunk/LayoutTests
Title: [97980] trunk/LayoutTests Revision 97980 Author commit-qu...@webkit.org Date 2011-10-20 08:18:41 -0700 (Thu, 20 Oct 2011) Log Message [Qt] Removing test from Skipped list. Test passes: fast/text/justify-padding-distribution.html https://bugs.webkit.org/show_bug.cgi?id=40584 Patch by Zoltan Arvai zar...@inf.u-szeged.hu on 2011-10-20 Reviewed by Andreas Kling. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (97979 => 97980) --- trunk/LayoutTests/ChangeLog 2011-10-20 15:00:16 UTC (rev 97979) +++ trunk/LayoutTests/ChangeLog 2011-10-20 15:18:41 UTC (rev 97980) @@ -1,3 +1,12 @@ +2011-10-20 Zoltan Arvai zar...@inf.u-szeged.hu + +[Qt] Removing test from Skipped list. Test passes: fast/text/justify-padding-distribution.html +https://bugs.webkit.org/show_bug.cgi?id=40584 + +Reviewed by Andreas Kling. + +* platform/qt/Skipped: + 2011-10-20 Vsevolod Vlasov vse...@chromium.org Web Inspector: Advanced search results should keep working after pretty print toggled. Modified: trunk/LayoutTests/platform/qt/Skipped (97979 => 97980) --- trunk/LayoutTests/platform/qt/Skipped 2011-10-20 15:00:16 UTC (rev 97979) +++ trunk/LayoutTests/platform/qt/Skipped 2011-10-20 15:18:41 UTC (rev 97980) @@ -1069,10 +1069,6 @@ fast/ruby/overhang-horizontal.html fast/ruby/overhang-vertical.html -# [Qt] fast/text/justify-padding-distribution.html fails -# https://bugs.webkit.org/show_bug.cgi?id=40584 -fast/text/justify-padding-distribution.html - # This test fails because Qt does not support conditionals in unicode special casing. # See also http://trolltech.com/developer/task-tracker/index_html?id=212870method=entry fast/css/case-transform.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97981] trunk/Source/WebCore
Title: [97981] trunk/Source/WebCore
Revision 97981
Author commit-qu...@webkit.org
Date 2011-10-20 08:18:54 -0700 (Thu, 20 Oct 2011)
Log Message
Unreviewed, rolling out r97964 and r97972.
http://trac.webkit.org/changeset/97964
http://trac.webkit.org/changeset/97972
https://bugs.webkit.org/show_bug.cgi?id=70502
They broke all geolocation tests in debug mode (Requested by
Ossy on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-10-20
* dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::timerFired):
(WebCore::DeviceMotionController::addListener):
(WebCore::DeviceMotionController::removeListener):
(WebCore::DeviceMotionController::removeAllListeners):
* dom/DeviceMotionController.h:
* dom/DeviceOrientationController.cpp:
* dom/DeviceOrientationController.h:
* dom/Document.cpp:
* dom/Document.h:
* dom/ScriptExecutionContext.h:
* page/GeolocationController.cpp:
* page/GeolocationController.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DeviceMotionController.cpp
trunk/Source/WebCore/dom/DeviceMotionController.h
trunk/Source/WebCore/dom/DeviceOrientationController.cpp
trunk/Source/WebCore/dom/DeviceOrientationController.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/ScriptExecutionContext.h
trunk/Source/WebCore/page/GeolocationController.cpp
trunk/Source/WebCore/page/GeolocationController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (97980 => 97981)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 15:18:41 UTC (rev 97980)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 15:18:54 UTC (rev 97981)
@@ -1,3 +1,27 @@
+2011-10-20 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r97964 and r97972.
+http://trac.webkit.org/changeset/97964
+http://trac.webkit.org/changeset/97972
+https://bugs.webkit.org/show_bug.cgi?id=70502
+
+They broke all geolocation tests in debug mode (Requested by
+Ossy on #webkit).
+
+* dom/DeviceMotionController.cpp:
+(WebCore::DeviceMotionController::timerFired):
+(WebCore::DeviceMotionController::addListener):
+(WebCore::DeviceMotionController::removeListener):
+(WebCore::DeviceMotionController::removeAllListeners):
+* dom/DeviceMotionController.h:
+* dom/DeviceOrientationController.cpp:
+* dom/DeviceOrientationController.h:
+* dom/Document.cpp:
+* dom/Document.h:
+* dom/ScriptExecutionContext.h:
+* page/GeolocationController.cpp:
+* page/GeolocationController.h:
+
2011-10-20 Ilya Tikhonovsky loi...@chromium.org
Unreviewed fix for Date.prototype.toISO8601Compact.
Modified: trunk/Source/WebCore/dom/DeviceMotionController.cpp (97980 => 97981)
--- trunk/Source/WebCore/dom/DeviceMotionController.cpp 2011-10-20 15:18:41 UTC (rev 97980)
+++ trunk/Source/WebCore/dom/DeviceMotionController.cpp 2011-10-20 15:18:54 UTC (rev 97981)
@@ -48,10 +48,10 @@
void DeviceMotionController::timerFired(TimerDeviceMotionController* timer)
{
ASSERT_UNUSED(timer, timer == m_timer);
-ASSERT(m_client-currentDeviceMotion());
+ASSERT(!m_client || m_client-currentDeviceMotion());
m_timer.stop();
-RefPtrDeviceMotionData deviceMotionData = m_client-currentDeviceMotion();
+RefPtrDeviceMotionData deviceMotionData = m_client ? m_client-currentDeviceMotion() : DeviceMotionData::create();
RefPtrDeviceMotionEvent event = DeviceMotionEvent::create(eventNames().devicemotionEvent, deviceMotionData.get());
VectorRefPtrDOMWindow listenersVector;
@@ -63,9 +63,9 @@
void DeviceMotionController::addListener(DOMWindow* window)
{
-// If the client already has motion data,
+// If no client is present or the client already has motion data,
// immediately trigger an asynchronous response.
-if (m_client-currentDeviceMotion()) {
+if (!m_client || m_client-currentDeviceMotion()) {
m_newListeners.add(window);
if (!m_timer.isActive())
m_timer.startOneShot(0);
@@ -73,7 +73,7 @@
bool wasEmpty = m_listeners.isEmpty();
m_listeners.add(window);
-if (wasEmpty)
+if (wasEmpty m_client)
m_client-startUpdating();
}
@@ -81,7 +81,7 @@
{
m_listeners.remove(window);
m_newListeners.remove(window);
-if (m_listeners.isEmpty())
+if (m_listeners.isEmpty() m_client)
m_client-stopUpdating();
}
@@ -93,21 +93,10 @@
m_listeners.removeAll(window);
m_newListeners.remove(window);
-if (m_listeners.isEmpty())
+if (m_listeners.isEmpty() m_client)
m_client-stopUpdating();
}
-void DeviceMotionController::suspend()
-{
-m_client-stopUpdating();
-}
-
-void DeviceMotionController::resume()
-{
-if (!m_listeners.isEmpty())
-m_client-startUpdating();
-}
-
void DeviceMotionController::didChangeDeviceMotion(DeviceMotionData* deviceMotionData)
{
[webkit-changes] [97982] trunk/Source/WebCore
Title: [97982] trunk/Source/WebCore
Revision 97982
Author o...@webkit.org
Date 2011-10-20 08:30:34 -0700 (Thu, 20 Oct 2011)
Log Message
[Qt] Roll-back r97964, r97972 and fix in https://bugs.webkit.org/show_bug.cgi?id=70328.
* dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::timerFired):
(WebCore::DeviceMotionController::addListener):
(WebCore::DeviceMotionController::removeListener):
(WebCore::DeviceMotionController::removeAllListeners):
(WebCore::DeviceMotionController::suspend):
(WebCore::DeviceMotionController::resume):
* dom/DeviceMotionController.h:
* dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::suspend):
(WebCore::DeviceOrientationController::resume):
* dom/DeviceOrientationController.h:
* dom/Document.cpp:
(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):
(WebCore::Document::stopActiveDOMObjects):
* dom/Document.h:
* dom/ScriptExecutionContext.h:
* page/GeolocationController.cpp:
(WebCore::GeolocationController::suspend):
(WebCore::GeolocationController::resume):
* page/GeolocationController.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DeviceMotionController.cpp
trunk/Source/WebCore/dom/DeviceMotionController.h
trunk/Source/WebCore/dom/DeviceOrientationController.cpp
trunk/Source/WebCore/dom/DeviceOrientationController.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/ScriptExecutionContext.h
trunk/Source/WebCore/page/GeolocationController.cpp
trunk/Source/WebCore/page/GeolocationController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (97981 => 97982)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 15:18:54 UTC (rev 97981)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 15:30:34 UTC (rev 97982)
@@ -1,3 +1,30 @@
+2011-10-20 Csaba Osztrogonác o...@webkit.org
+
+[Qt] Roll-back r97964, r97972 and fix in https://bugs.webkit.org/show_bug.cgi?id=70328.
+
+* dom/DeviceMotionController.cpp:
+(WebCore::DeviceMotionController::timerFired):
+(WebCore::DeviceMotionController::addListener):
+(WebCore::DeviceMotionController::removeListener):
+(WebCore::DeviceMotionController::removeAllListeners):
+(WebCore::DeviceMotionController::suspend):
+(WebCore::DeviceMotionController::resume):
+* dom/DeviceMotionController.h:
+* dom/DeviceOrientationController.cpp:
+(WebCore::DeviceOrientationController::suspend):
+(WebCore::DeviceOrientationController::resume):
+* dom/DeviceOrientationController.h:
+* dom/Document.cpp:
+(WebCore::Document::suspendActiveDOMObjects):
+(WebCore::Document::resumeActiveDOMObjects):
+(WebCore::Document::stopActiveDOMObjects):
+* dom/Document.h:
+* dom/ScriptExecutionContext.h:
+* page/GeolocationController.cpp:
+(WebCore::GeolocationController::suspend):
+(WebCore::GeolocationController::resume):
+* page/GeolocationController.h:
+
2011-10-20 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r97964 and r97972.
Modified: trunk/Source/WebCore/dom/DeviceMotionController.cpp (97981 => 97982)
--- trunk/Source/WebCore/dom/DeviceMotionController.cpp 2011-10-20 15:18:54 UTC (rev 97981)
+++ trunk/Source/WebCore/dom/DeviceMotionController.cpp 2011-10-20 15:30:34 UTC (rev 97982)
@@ -48,10 +48,10 @@
void DeviceMotionController::timerFired(TimerDeviceMotionController* timer)
{
ASSERT_UNUSED(timer, timer == m_timer);
-ASSERT(!m_client || m_client-currentDeviceMotion());
+ASSERT(m_client-currentDeviceMotion());
m_timer.stop();
-RefPtrDeviceMotionData deviceMotionData = m_client ? m_client-currentDeviceMotion() : DeviceMotionData::create();
+RefPtrDeviceMotionData deviceMotionData = m_client-currentDeviceMotion();
RefPtrDeviceMotionEvent event = DeviceMotionEvent::create(eventNames().devicemotionEvent, deviceMotionData.get());
VectorRefPtrDOMWindow listenersVector;
@@ -63,9 +63,9 @@
void DeviceMotionController::addListener(DOMWindow* window)
{
-// If no client is present or the client already has motion data,
+// If the client already has motion data,
// immediately trigger an asynchronous response.
-if (!m_client || m_client-currentDeviceMotion()) {
+if (m_client-currentDeviceMotion()) {
m_newListeners.add(window);
if (!m_timer.isActive())
m_timer.startOneShot(0);
@@ -73,7 +73,7 @@
bool wasEmpty = m_listeners.isEmpty();
m_listeners.add(window);
-if (wasEmpty m_client)
+if (wasEmpty)
m_client-startUpdating();
}
@@ -81,7 +81,7 @@
{
m_listeners.remove(window);
m_newListeners.remove(window);
-if (m_listeners.isEmpty() m_client)
+if (m_listeners.isEmpty())
m_client-stopUpdating();
}
@@ -93,10 +93,22 @@
m_listeners.removeAll(window);
[webkit-changes] [97983] trunk/Tools
Title: [97983] trunk/Tools
Revision 97983
Author ph...@webkit.org
Date 2011-10-20 08:47:57 -0700 (Thu, 20 Oct 2011)
Log Message
[style] Allow usage of NULL in gst_*
https://bugs.webkit.org/show_bug.cgi?id=70498
Reviewed by David Levin.
* Scripts/webkitpy/style/checkers/cpp.py: Simplified the detection
of gst_ calls. Now just ignore NULL in all of them.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Test for above change.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (97982 => 97983)
--- trunk/Tools/ChangeLog 2011-10-20 15:30:34 UTC (rev 97982)
+++ trunk/Tools/ChangeLog 2011-10-20 15:47:57 UTC (rev 97983)
@@ -1,3 +1,14 @@
+2011-10-20 Philippe Normand pnorm...@igalia.com
+
+[style] Allow usage of NULL in gst_*
+https://bugs.webkit.org/show_bug.cgi?id=70498
+
+Reviewed by David Levin.
+
+* Scripts/webkitpy/style/checkers/cpp.py: Simplified the detection
+of gst_ calls. Now just ignore NULL in all of them.
+* Scripts/webkitpy/style/checkers/cpp_unittest.py: Test for above change.
+
2011-10-20 Leandro Pereira lean...@profusion.mobi
[EFL] Unreviewed. Build fix after r97043.
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (97982 => 97983)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-10-20 15:30:34 UTC (rev 97982)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-10-20 15:47:57 UTC (rev 97983)
@@ -2377,26 +2377,10 @@
if search(r'\bg(_[a-z]+)+\b', line):
return
-# Don't warn about NULL usage in gst_*_many(). See Bug 39740
-if search(r'\bgst_\w+_many\b', line):
+# Don't warn about NULL usage in gst_*(). See Bug 70498.
+if search(r'\bgst(_[a-z]+)+\b', line):
return
-# Don't warn about NULL usage in some gst_structure_*(). See Bug 67194.
-if search(r'\bgst_structure_[sg]et\b', line):
-return
-if search(r'\bgst_structure_remove_fields\b', line):
-return
-if search(r'\bgst_structure_new\b', line):
-return
-if search(r'\bgst_structure_id_new\b', line):
-return
-if search(r'\bgst_structure_id_[sg]et\b', line):
-return
-
-# Don't warn about NULL usage in g_str{join,concat}(). See Bug 34834
-if search(r'\bg_str(join|concat)\b', line):
-return
-
# Don't warn about NULL usage in gdk_pixbuf_save_to_*{join,concat}(). See Bug 43090.
if search(r'\bgdk_pixbuf_save_to\w+\b', line):
return
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (97982 => 97983)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-10-20 15:30:34 UTC (rev 97982)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-10-20 15:47:57 UTC (rev 97983)
@@ -4128,6 +4128,12 @@
'gst_structure_id_get(FOO, VALUE, G_TYPE_INT, value, NULL);',
'')
self.assert_lint(
+'gst_caps_new_simple(mime, value, G_TYPE_INT, value, NULL);',
+'')
+self.assert_lint(
+'gst_caps_new_full(structure1, structure2, NULL);',
+'')
+self.assert_lint(
'gchar* result = g_strconcat(part1, part2, part3, NULL);',
'')
self.assert_lint(
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97984] trunk/Source/WebCore
Title: [97984] trunk/Source/WebCore
Revision 97984
Author pfeld...@chromium.org
Date 2011-10-20 09:07:46 -0700 (Thu, 20 Oct 2011)
Log Message
Web Inspector: detach should call hide so that overrides are processed.
https://bugs.webkit.org/show_bug.cgi?id=70503
Reviewed by Yury Semikhatsky.
* inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.hide):
* inspector/front-end/View.js:
(WebInspector.View):
(WebInspector.View.prototype.hide):
(WebInspector.View.prototype.detach):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ConsolePanel.js
trunk/Source/WebCore/inspector/front-end/View.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (97983 => 97984)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 15:47:57 UTC (rev 97983)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 16:07:46 UTC (rev 97984)
@@ -1,3 +1,17 @@
+2011-10-20 Pavel Feldman pfeld...@google.com
+
+Web Inspector: detach should call hide so that overrides are processed.
+https://bugs.webkit.org/show_bug.cgi?id=70503
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/ConsolePanel.js:
+(WebInspector.ConsolePanel.prototype.hide):
+* inspector/front-end/View.js:
+(WebInspector.View):
+(WebInspector.View.prototype.hide):
+(WebInspector.View.prototype.detach):
+
2011-10-20 Csaba Osztrogonác o...@webkit.org
[Qt] Roll-back r97964, r97972 and fix in https://bugs.webkit.org/show_bug.cgi?id=70328.
Modified: trunk/Source/WebCore/inspector/front-end/ConsolePanel.js (97983 => 97984)
--- trunk/Source/WebCore/inspector/front-end/ConsolePanel.js 2011-10-20 15:47:57 UTC (rev 97983)
+++ trunk/Source/WebCore/inspector/front-end/ConsolePanel.js 2011-10-20 16:07:46 UTC (rev 97984)
@@ -63,7 +63,6 @@
hide: function()
{
WebInspector.Panel.prototype.hide.call(this);
-this._view.detach();
if (this._drawerWasVisible) {
WebInspector.drawer.show(this._view, WebInspector.Drawer.AnimationType.Immediately);
delete this._drawerWasVisible;
Modified: trunk/Source/WebCore/inspector/front-end/View.js (97983 => 97984)
--- trunk/Source/WebCore/inspector/front-end/View.js 2011-10-20 15:47:57 UTC (rev 97983)
+++ trunk/Source/WebCore/inspector/front-end/View.js 2011-10-20 16:07:46 UTC (rev 97984)
@@ -36,6 +36,7 @@
this.element.__view = this;
this._visible = false;
this._children = [];
+this._inDetach = false;
}
WebInspector.View.prototype = {
@@ -85,7 +86,8 @@
hide: function()
{
this.dispatchToSelfAndChildren(willHide, true);
-this.element.removeStyleClass(visible);
+if (!this._inDetach)
+this.element.removeStyleClass(visible);
this._visible = false;
},
@@ -100,8 +102,9 @@
detach: function()
{
if (this._visible) {
-this.dispatchToSelfAndChildren(willHide, true);
-this._visible = false;
+this._inDetach = true;
+this.hide();
+this._inDetach = false;
}
this.dispatchToSelfAndChildren(willDetach, false);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97985] trunk/Source/WebCore
Title: [97985] trunk/Source/WebCore Revision 97985 Author andreas.kl...@nokia.com Date 2011-10-20 09:23:55 -0700 (Thu, 20 Oct 2011) Log Message CSSStyleDeclaration: Remove inheritance from StyleBase. https://bugs.webkit.org/show_bug.cgi?id=70411 Reviewed by Antti Koivisto. * bindings/js/JSDOMBinding.h: (WebCore::root): Specialized root() for CSSStyleDeclaration and CSSMutableStyleDeclaration. * css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc): Start the parent chain traversal from the parentStyleSheet(). (WebCore::CSSMutableStyleDeclaration::addSubresourceStyleURLs): * css/CSSParser.cpp: (WebCore::parseColorValue): (WebCore::parseSimpleLengthValue): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): Remove now-unnecessary assertions and casts. * css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::CSSStyleDeclaration): * css/CSSStyleDeclaration.h: (WebCore::CSSStyleDeclaration::~CSSStyleDeclaration): (WebCore::CSSStyleDeclaration::parentRule): (WebCore::CSSStyleDeclaration::setParentRule): (WebCore::CSSStyleDeclaration::setParentStyleSheet): (WebCore::CSSStyleDeclaration::parentStyleSheet): Make CSSStyleDeclaration inherit directly from RefCounted, and have either a CSSRule or CSSStyleSheet parent. Eventually it should only need to have rules as parents, but CSSParser depends on having style sheet parents for URL completion and primitive value cache. * css/StyleBase.h: * css/CSSStyleDeclaration.h: (WebCore::CSSStyleDeclaration::isMutableStyleDeclaration): Moved from StyleBase down to CSSStyleDeclaration. * css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::~CSSStyleRule): (WebCore::CSSStyleRule::setSelectorText): * css/WebKitCSSKeyframeRule.cpp: (WebCore::WebKitCSSKeyframeRule::~WebKitCSSKeyframeRule): (WebCore::WebKitCSSKeyframeRule::setDeclaration): * css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule): (WebCore::WebKitCSSKeyframesRule::append): (WebCore::WebKitCSSKeyframesRule::deleteRule): * dom/StyledElement.cpp: (WebCore::StyledElement::createInlineStyleDecl): (WebCore::StyledElement::destroyInlineStyleDecl): (WebCore::StyledElement::attributeChanged): (WebCore::StyledElement::createMappedDecl): (WebCore::StyledElement::didMoveToNewOwnerDocument): * html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::additionalAttributeStyleDecls): (WebCore::HTMLTableElement::addSharedCellBordersDecl): (WebCore::HTMLTableElement::addSharedCellPaddingDecl): (WebCore::HTMLTableElement::addSharedGroupDecls): * page/PageSerializer.cpp: (WebCore::PageSerializer::retrieveResourcesForCSSDeclaration): * svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::SVGFontFaceElement): Use the new parenting methods of CSSStyleDeclaration. * css/StyleBase.cpp: (WebCore::StyleBase::node): Remove the isMutableStyleDeclaration() code path. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSDOMBinding.h trunk/Source/WebCore/css/CSSMutableStyleDeclaration.cpp trunk/Source/WebCore/css/CSSParser.cpp trunk/Source/WebCore/css/CSSStyleDeclaration.cpp trunk/Source/WebCore/css/CSSStyleDeclaration.h trunk/Source/WebCore/css/CSSStyleRule.cpp trunk/Source/WebCore/css/StyleBase.cpp trunk/Source/WebCore/css/StyleBase.h trunk/Source/WebCore/css/WebKitCSSKeyframeRule.cpp trunk/Source/WebCore/css/WebKitCSSKeyframesRule.cpp trunk/Source/WebCore/dom/StyledElement.cpp trunk/Source/WebCore/html/HTMLTableElement.cpp trunk/Source/WebCore/page/PageSerializer.cpp trunk/Source/WebCore/svg/SVGFontFaceElement.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (97984 => 97985) --- trunk/Source/WebCore/ChangeLog 2011-10-20 16:07:46 UTC (rev 97984) +++ trunk/Source/WebCore/ChangeLog 2011-10-20 16:23:55 UTC (rev 97985) @@ -1,3 +1,83 @@ +2011-10-20 Andreas Kling kl...@webkit.org + +CSSStyleDeclaration: Remove inheritance from StyleBase. +https://bugs.webkit.org/show_bug.cgi?id=70411 + +Reviewed by Antti Koivisto. + +* bindings/js/JSDOMBinding.h: +(WebCore::root): + +Specialized root() for CSSStyleDeclaration and CSSMutableStyleDeclaration. + +* css/CSSMutableStyleDeclaration.cpp: +(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc): + +Start the parent chain traversal from the parentStyleSheet(). + +(WebCore::CSSMutableStyleDeclaration::addSubresourceStyleURLs): +* css/CSSParser.cpp: +(WebCore::parseColorValue): +(WebCore::parseSimpleLengthValue): +(WebCore::CSSParser::parseValue): +(WebCore::CSSParser::parseColor): +(WebCore::CSSParser::parseDeclaration): + +Remove now-unnecessary assertions and casts. + +* css/CSSStyleDeclaration.cpp: +(WebCore::CSSStyleDeclaration::CSSStyleDeclaration): +* css/CSSStyleDeclaration.h: +
[webkit-changes] [97987] trunk/Source/WebCore
Title: [97987] trunk/Source/WebCore
Revision 97987
Author andreas.kl...@nokia.com
Date 2011-10-20 09:41:51 -0700 (Thu, 20 Oct 2011)
Log Message
CSSMutableStyleDeclaration: Simplify setNeedsStyleRecalc().
https://bugs.webkit.org/show_bug.cgi?id=70509
Reviewed by Antti Koivisto.
We don't need to climb up the entire parent chain here to find the
Document, just grab it from the parentStyleSheet() (which will do
the climbing for us if necessary.)
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSMutableStyleDeclaration.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97986 => 97987)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 16:33:04 UTC (rev 97986)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 16:41:51 UTC (rev 97987)
@@ -1,5 +1,19 @@
2011-10-20 Andreas Kling kl...@webkit.org
+CSSMutableStyleDeclaration: Simplify setNeedsStyleRecalc().
+https://bugs.webkit.org/show_bug.cgi?id=70509
+
+Reviewed by Antti Koivisto.
+
+We don't need to climb up the entire parent chain here to find the
+Document, just grab it from the parentStyleSheet() (which will do
+the climbing for us if necessary.)
+
+* css/CSSMutableStyleDeclaration.cpp:
+(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
+
+2011-10-20 Andreas Kling kl...@webkit.org
+
CSSStyleDeclaration: Remove inheritance from StyleBase.
https://bugs.webkit.org/show_bug.cgi?id=70411
Modified: trunk/Source/WebCore/css/CSSMutableStyleDeclaration.cpp (97986 => 97987)
--- trunk/Source/WebCore/css/CSSMutableStyleDeclaration.cpp 2011-10-20 16:33:04 UTC (rev 97986)
+++ trunk/Source/WebCore/css/CSSMutableStyleDeclaration.cpp 2011-10-20 16:41:51 UTC (rev 97987)
@@ -519,14 +519,8 @@
return;
}
-if (!parentStyleSheet())
-return;
-
-StyleBase* root = parentStyleSheet();
-while (StyleBase* parent = root-parent())
-root = parent;
-if (root-isCSSStyleSheet()) {
-if (Document* document = static_castCSSStyleSheet*(root)-document())
+if (CSSStyleSheet* styleSheet = parentStyleSheet()) {
+if (Document* document = styleSheet-document())
document-styleSelectorChanged(DeferRecalcStyle);
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97988] trunk
Title: [97988] trunk
Revision 97988
Author jknot...@chromium.org
Date 2011-10-20 09:45:30 -0700 (Thu, 20 Oct 2011)
Log Message
Touch events should take page scale into account
https://bugs.webkit.org/show_bug.cgi?id=69798
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/touch/page-scaled-touch-gesture-click.html
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):
LayoutTests:
* fast/events/touch/page-scaled-touch-gesture-click-expected.txt: Added.
* fast/events/touch/page-scaled-touch-gesture-click.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
Added Paths
trunk/LayoutTests/fast/events/touch/page-scaled-touch-gesture-click-expected.txt
trunk/LayoutTests/fast/events/touch/page-scaled-touch-gesture-click.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97987 => 97988)
--- trunk/LayoutTests/ChangeLog 2011-10-20 16:41:51 UTC (rev 97987)
+++ trunk/LayoutTests/ChangeLog 2011-10-20 16:45:30 UTC (rev 97988)
@@ -1,3 +1,13 @@
+2011-10-20 John Knottenbelt jknot...@chromium.org
+
+Touch events should take page scale into account
+https://bugs.webkit.org/show_bug.cgi?id=69798
+
+Reviewed by Adam Barth.
+
+* fast/events/touch/page-scaled-touch-gesture-click-expected.txt: Added.
+* fast/events/touch/page-scaled-touch-gesture-click.html: Added.
+
2011-10-20 Leandro Pereira lean...@profusion.mobi
Unreviewed. Add part of EFL baselines for the fast/ suite.
Added: trunk/LayoutTests/fast/events/touch/page-scaled-touch-gesture-click-expected.txt (0 => 97988)
--- trunk/LayoutTests/fast/events/touch/page-scaled-touch-gesture-click-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/touch/page-scaled-touch-gesture-click-expected.txt 2011-10-20 16:45:30 UTC (rev 97988)
@@ -0,0 +1,39 @@
+This tests basic single touch gesture generation.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+have received: 1 touch events
+have received: 2 touch events
+PASS event.type is mousemove
+PASS event.clientX is 20
+PASS event.clientY is 24
+PASS event.shiftKey is true
+PASS event.altKey is true
+PASS event.ctrlKey is false
+PASS event.metaKey is false
+PASS event.type is mousedown
+PASS event.clientX is 20
+PASS event.clientY is 24
+PASS event.shiftKey is true
+PASS event.altKey is true
+PASS event.ctrlKey is false
+PASS event.metaKey is false
+PASS event.type is mouseup
+PASS event.clientX is 20
+PASS event.clientY is 24
+PASS event.shiftKey is true
+PASS event.altKey is true
+PASS event.ctrlKey is false
+PASS event.metaKey is false
+PASS event.type is click
+PASS event.clientX is 20
+PASS event.clientY is 24
+PASS event.shiftKey is true
+PASS event.altKey is true
+PASS event.ctrlKey is false
+PASS event.metaKey is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/events/touch/page-scaled-touch-gesture-click.html (0 => 97988)
--- trunk/LayoutTests/fast/events/touch/page-scaled-touch-gesture-click.html (rev 0)
+++ trunk/LayoutTests/fast/events/touch/page-scaled-touch-gesture-click.html 2011-10-20 16:45:30 UTC (rev 97988)
@@ -0,0 +1,121 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link rel=stylesheet href=""
+script src=""
+script src=""
+style type=text/css
+#touchtarget {
+ width: 100px;
+ height: 100px;
+ background: blue;
+}
+/style
+/head
+body _onload_=runTest();
+div id=touchtarget
+
+p id=description/p
+div id=console/div
+
+script
+var clickEventsReceived = 0;
+var expectedMouseEvents = 4;
+var touchEventsReceived = 0;
+var mouseEventsReceived = 0;
+var eventTypes = [ 'mousemove', 'mousedown', 'mouseup', 'click' ];
+
+function gestureEventCallback(event)
+{
+if (window.eventSender) {
+shouldBeEqualToString('event.type', eventTypes[mouseEventsReceived]);
+shouldBe('event.clientX', '20');
+shouldBe('event.clientY', '24');
+shouldBe(event.shiftKey, true);
+shouldBe(event.altKey, true);
+shouldBe(event.ctrlKey, false);
+shouldBe(event.metaKey, false);
+mouseEventsReceived++;
+} else {
+debug(event.type);
+debug(event.clientX);
+debug(event.clientY);
+}
+}
+
+// Because we may not have a gesture recognizer, we send a key press
+// event to end the test without temporal flakiness.
+function quitKeyToEndTest(event) {
+endTest();
+}
+
+// Log that we still got the touch events.
+function touchEventCallback(event) {
+touchEventsReceived++;
+debug('have received: ' + touchEventsReceived + ' touch events');
+return true;
+}
+
+function singleTouchSequence()
+{
+eventSender.clearTouchPoints();
+// Coordinates passed to eventSender.addTouchPoint are in screen pixels,
+// relative to the top left of the window.
+eventSender.addTouchPoint(10, 12);
+eventSender.touchStart();
+
+//
[webkit-changes] [97989] trunk/Source/WebCore
Title: [97989] trunk/Source/WebCore
Revision 97989
Author kenn...@webkit.org
Date 2011-10-20 09:48:35 -0700 (Thu, 20 Oct 2011)
Log Message
When user is panning with the tiled backing store, the page
isn't notified about the scroll position change
https://bugs.webkit.org/show_bug.cgi?id=70495
Reviewed by Simon Hausmann.
When using the tiled backing store the UI handles scrolling,
and sends setFixedVisibleContentRect after panning/scale ends.
If we actually changed position we need to send the scroll DOM event.
Covered by existing tests, though we are not testing the tiled backing store yet.
* page/FrameView.cpp:
(WebCore::FrameView::setFixedVisibleContentRect):
* page/FrameView.h:
* platform/ScrollView.h:
(WebCore::ScrollView::setFixedVisibleContentRect):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/platform/ScrollView.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (97988 => 97989)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 16:45:30 UTC (rev 97988)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 16:48:35 UTC (rev 97989)
@@ -1,3 +1,24 @@
+2011-10-20 Kenneth Rohde Christiansen kenn...@webkit.org
+
+When user is panning with the tiled backing store, the page
+isn't notified about the scroll position change
+https://bugs.webkit.org/show_bug.cgi?id=70495
+
+Reviewed by Simon Hausmann.
+
+When using the tiled backing store the UI handles scrolling,
+and sends setFixedVisibleContentRect after panning/scale ends.
+
+If we actually changed position we need to send the scroll DOM event.
+
+Covered by existing tests, though we are not testing the tiled backing store yet.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::setFixedVisibleContentRect):
+* page/FrameView.h:
+* platform/ScrollView.h:
+(WebCore::ScrollView::setFixedVisibleContentRect):
+
2011-10-20 John Knottenbelt jknot...@chromium.org
Touch events should take page scale into account
Modified: trunk/Source/WebCore/page/FrameView.cpp (97988 => 97989)
--- trunk/Source/WebCore/page/FrameView.cpp 2011-10-20 16:45:30 UTC (rev 97988)
+++ trunk/Source/WebCore/page/FrameView.cpp 2011-10-20 16:48:35 UTC (rev 97989)
@@ -1676,6 +1676,15 @@
m_inProgrammaticScroll = wasInProgrammaticScroll;
}
+void FrameView::setFixedVisibleContentRect(const IntRect visibleContentRect)
+{
+IntSize offset = scrollOffset();
+ScrollView::setFixedVisibleContentRect(visibleContentRect);
+if (offset != scrollOffset())
+scrollPositionChanged();
+frame()-loader()-client()-didChangeScrollOffset();
+}
+
void FrameView::scrollPositionChangedViaPlatformWidget()
{
repaintFixedElementsAfterScrolling();
Modified: trunk/Source/WebCore/page/FrameView.h (97988 => 97989)
--- trunk/Source/WebCore/page/FrameView.h 2011-10-20 16:45:30 UTC (rev 97988)
+++ trunk/Source/WebCore/page/FrameView.h 2011-10-20 16:48:35 UTC (rev 97989)
@@ -165,6 +165,7 @@
virtual LayoutRect windowResizerRect() const;
+virtual void setFixedVisibleContentRect(const IntRect) OVERRIDE;
void setScrollPosition(const LayoutPoint);
void scrollPositionChangedViaPlatformWidget();
virtual void repaintFixedElementsAfterScrolling();
Modified: trunk/Source/WebCore/platform/ScrollView.h (97988 => 97989)
--- trunk/Source/WebCore/platform/ScrollView.h 2011-10-20 16:45:30 UTC (rev 97988)
+++ trunk/Source/WebCore/platform/ScrollView.h 2011-10-20 16:48:35 UTC (rev 97989)
@@ -145,7 +145,7 @@
// the setFixedVisibleContentRect instead for the mainframe, though this must be updated manually, e.g just before resuming the page
// which usually will happen when panning, pinching and rotation ends, or when scale or position are changed manually.
virtual IntRect visibleContentRect(bool includeScrollbars = false) const;
-void setFixedVisibleContentRect(const IntRect visibleContentRect) { m_fixedVisibleContentRect = visibleContentRect; }
+virtual void setFixedVisibleContentRect(const IntRect visibleContentRect) { m_fixedVisibleContentRect = visibleContentRect; }
LayoutUnit visibleWidth() const { return visibleContentRect().width(); }
LayoutUnit visibleHeight() const { return visibleContentRect().height(); }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97991] trunk/Source/WebCore
Title: [97991] trunk/Source/WebCore
Revision 97991
Author andreas.kl...@nokia.com
Date 2011-10-20 09:57:16 -0700 (Thu, 20 Oct 2011)
Log Message
Simplify CSSParser::document().
https://bugs.webkit.org/show_bug.cgi?id=70518
Reviewed by Antti Koivisto.
We don't need to climb up the entire parent chain here to find the
Document, just grab it from m_styleSheet (which will do the climbing
for us if necessary.)
* css/CSSParser.cpp:
(WebCore::CSSParser::document):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97990 => 97991)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 16:49:11 UTC (rev 97990)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 16:57:16 UTC (rev 97991)
@@ -1,3 +1,17 @@
+2011-10-20 Andreas Kling kl...@webkit.org
+
+Simplify CSSParser::document().
+https://bugs.webkit.org/show_bug.cgi?id=70518
+
+Reviewed by Antti Koivisto.
+
+We don't need to climb up the entire parent chain here to find the
+Document, just grab it from m_styleSheet (which will do the climbing
+for us if necessary.)
+
+* css/CSSParser.cpp:
+(WebCore::CSSParser::document):
+
2011-10-20 Pierre Rossi pierre.ro...@gmail.com
[Qt] FontCache::createFontPlatformData() is broken, a default font is returned
Modified: trunk/Source/WebCore/css/CSSParser.cpp (97990 => 97991)
--- trunk/Source/WebCore/css/CSSParser.cpp 2011-10-20 16:49:11 UTC (rev 97990)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2011-10-20 16:57:16 UTC (rev 97991)
@@ -648,14 +648,9 @@
Document* CSSParser::document() const
{
-StyleBase* root = m_styleSheet;
-while (root root-parent())
-root = root-parent();
-if (!root)
+if (!m_styleSheet)
return 0;
-if (!root-isCSSStyleSheet())
-return 0;
-return static_castCSSStyleSheet*(root)-document();
+return m_styleSheet-document();
}
bool CSSParser::validUnit(CSSParserValue* value, Units unitflags, bool strict)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97992] trunk/Tools
Title: [97992] trunk/Tools
Revision 97992
Author commit-qu...@webkit.org
Date 2011-10-20 10:02:41 -0700 (Thu, 20 Oct 2011)
Log Message
[EFL] Plug ImageDiff/DumpRenderTree on CMake build system
https://bugs.webkit.org/show_bug.cgi?id=70142
Patch by Leandro Pereira lean...@profusion.mobi on 2011-10-20
Reviewed by Gustavo Noronha Silva.
* CMakeListsEfl.txt: Include DRT CMakeLists.
* DumpRenderTree/efl/CMakeLists.txt: Added.
Modified Paths
trunk/Tools/CMakeListsEfl.txt
trunk/Tools/ChangeLog
Added Paths
trunk/Tools/DumpRenderTree/efl/CMakeLists.txt
Diff
Modified: trunk/Tools/CMakeListsEfl.txt (97991 => 97992)
--- trunk/Tools/CMakeListsEfl.txt 2011-10-20 16:57:16 UTC (rev 97991)
+++ trunk/Tools/CMakeListsEfl.txt 2011-10-20 17:02:41 UTC (rev 97992)
@@ -57,3 +57,5 @@
ADD_EXECUTABLE(Programs/EWebLauncher ${EWebLauncher_SOURCES})
TARGET_LINK_LIBRARIES(Programs/EWebLauncher ${EWebLauncher_LIBRARIES})
ADD_TARGET_PROPERTIES(Programs/EWebLauncher LINK_FLAGS ${EWebLauncher_LINK_FLAGS})
+
+INCLUDE(${TOOLS_DIR}/DumpRenderTree/efl/CMakeLists.txt)
Modified: trunk/Tools/ChangeLog (97991 => 97992)
--- trunk/Tools/ChangeLog 2011-10-20 16:57:16 UTC (rev 97991)
+++ trunk/Tools/ChangeLog 2011-10-20 17:02:41 UTC (rev 97992)
@@ -1,3 +1,13 @@
+2011-10-20 Leandro Pereira lean...@profusion.mobi
+
+[EFL] Plug ImageDiff/DumpRenderTree on CMake build system
+https://bugs.webkit.org/show_bug.cgi?id=70142
+
+Reviewed by Gustavo Noronha Silva.
+
+* CMakeListsEfl.txt: Include DRT CMakeLists.
+* DumpRenderTree/efl/CMakeLists.txt: Added.
+
2011-10-20 Philippe Normand pnorm...@igalia.com
[style] Allow usage of NULL in gst_*
Added: trunk/Tools/DumpRenderTree/efl/CMakeLists.txt (0 => 97992)
--- trunk/Tools/DumpRenderTree/efl/CMakeLists.txt (rev 0)
+++ trunk/Tools/DumpRenderTree/efl/CMakeLists.txt 2011-10-20 17:02:41 UTC (rev 97992)
@@ -0,0 +1,127 @@
+SET(DumpRenderTree_SOURCES
+${TOOLS_DIR}/DumpRenderTree/CyclicRedundancyCheck.cpp
+${TOOLS_DIR}/DumpRenderTree/GCController.cpp
+${TOOLS_DIR}/DumpRenderTree/LayoutTestController.cpp
+${TOOLS_DIR}/DumpRenderTree/PixelDumpSupport.cpp
+${TOOLS_DIR}/DumpRenderTree/WorkQueue.cpp
+${TOOLS_DIR}/DumpRenderTree/cairo/PixelDumpSupportCairo.cpp
+${TOOLS_DIR}/DumpRenderTree/efl/DumpHistoryItem.cpp
+${TOOLS_DIR}/DumpRenderTree/efl/DumpRenderTree.cpp
+${TOOLS_DIR}/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
+${TOOLS_DIR}/DumpRenderTree/efl/DumpRenderTreeView.cpp
+${TOOLS_DIR}/DumpRenderTree/efl/EventSender.cpp
+${TOOLS_DIR}/DumpRenderTree/efl/FontManagement.cpp
+${TOOLS_DIR}/DumpRenderTree/efl/GCControllerEfl.cpp
+${TOOLS_DIR}/DumpRenderTree/efl/JSStringUtils.cpp
+${TOOLS_DIR}/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
+${TOOLS_DIR}/DumpRenderTree/efl/PixelDumpSupportEfl.cpp
+${TOOLS_DIR}/DumpRenderTree/efl/WorkQueueItemEfl.cpp
+)
+
+SET(ImageDiff_SOURCES
+${TOOLS_DIR}/DumpRenderTree/efl/ImageDiff.cpp
+)
+
+SET(DumpRenderTree_LIBRARIES
+${_javascript_Core_LIBRARY_NAME}
+${WebCore_LIBRARY_NAME}
+${WebKit_LIBRARY_NAME}
+${Cairo_LIBRARIES}
+${ECORE_X_LIBRARIES}
+${EDJE_LIBRARIES}
+${EFLDEPS_LIBRARIES}
+${EVAS_LIBRARIES}
+${LIBXML2_LIBRARIES}
+${LIBXSLT_LIBRARIES}
+${SQLITE_LIBRARIES}
+)
+
+SET(DumpRenderTree_LIBRARIES ${DumpRenderTree_LIBRARIES})
+SET(DumpRenderTree_INCLUDE_DIRECTORIES
+${WEBKIT_DIR}/efl/ewk
+${Cairo_INCLUDE_DIRS}
+${EDJE_INCLUDE_DIRS}
+${EFLDEPS_INCLUDE_DIRS}
+${EVAS_INCLUDE_DIRS}
+${WEBKIT_DIR}/efl
+${WEBCORE_DIR}
+${WEBCORE_DIR}/bridge
+${WEBCORE_DIR}/bridge/jsc
+${WEBCORE_DIR}/bindings
+${WEBCORE_DIR}/dom
+${WEBCORE_DIR}/editing
+${WEBCORE_DIR}/css
+${WEBCORE_DIR}/html
+${WEBCORE_DIR}/page
+${WEBCORE_DIR}/page/animation
+${WEBCORE_DIR}/platform
+${WEBCORE_DIR}/platform/text
+${WEBCORE_DIR}/platform/graphics
+${WEBCORE_DIR}/platform/graphics/cairo
+${WEBCORE_DIR}/platform/network
+${WEBCORE_DIR}/rendering
+${WEBCORE_DIR}/rendering/style
+${WEBCORE_DIR}/history
+${WEBCORE_DIR}/loader
+${WEBCORE_DIR}/loader/cache
+${WEBCORE_DIR}/loader/icon
+${_javascript_CORE_DIR}
+${_javascript_CORE_DIR}/API
+${_javascript_CORE_DIR}/assembler
+${_javascript_CORE_DIR}/dfg
+${_javascript_CORE_DIR}/heap
+${_javascript_CORE_DIR}/interpreter
+${_javascript_CORE_DIR}/jit
+${_javascript_CORE_DIR}/runtime
+${_javascript_CORE_DIR}/ForwardingHeaders
+${_javascript_CORE_DIR}/wtf
+${_javascript_CORE_DIR}/wtf/efl
+${TOOLS_DIR}/DumpRenderTree
+${TOOLS_DIR}/DumpRenderTree/cairo
+${TOOLS_DIR}/DumpRenderTree/efl
+${CMAKE_SOURCE_DIR}
+${CMAKE_BINARY_DIR}
+${DERIVED_SOURCES_WEBCORE_DIR}
+${WEBCORE_DIR}/bindings/js
+)
+
+SET(DumpRenderTree_LINK_FLAGS
+${ECORE_X_LDFLAGS}
+${EDJE_LDFLAGS}
+${EFLDEPS_LDFLAGS}
+
[webkit-changes] [97996] trunk/Tools
Title: [97996] trunk/Tools
Revision 97996
Author lean...@webkit.org
Date 2011-10-20 10:23:05 -0700 (Thu, 20 Oct 2011)
Log Message
[EFL] Unreviewed DumpRenderTree build fix.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addChromeInputField): Add stub.
(LayoutTestController::removeChromeInputField): Ditto.
(LayoutTestController::focusWebView): Ditto.
(LayoutTestController::setBackingScaleFactor): Ditto.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
Diff
Modified: trunk/Tools/ChangeLog (97995 => 97996)
--- trunk/Tools/ChangeLog 2011-10-20 17:19:02 UTC (rev 97995)
+++ trunk/Tools/ChangeLog 2011-10-20 17:23:05 UTC (rev 97996)
@@ -1,5 +1,15 @@
2011-10-20 Leandro Pereira lean...@profusion.mobi
+[EFL] Unreviewed DumpRenderTree build fix.
+
+* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+(LayoutTestController::addChromeInputField): Add stub.
+(LayoutTestController::removeChromeInputField): Ditto.
+(LayoutTestController::focusWebView): Ditto.
+(LayoutTestController::setBackingScaleFactor): Ditto.
+
+2011-10-20 Leandro Pereira lean...@profusion.mobi
+
[EFL] Plug ImageDiff/DumpRenderTree on CMake build system
https://bugs.webkit.org/show_bug.cgi?id=70142
Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (97995 => 97996)
--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2011-10-20 17:19:02 UTC (rev 97995)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2011-10-20 17:23:05 UTC (rev 97996)
@@ -760,3 +760,23 @@
{
notImplemented();
}
+
+void LayoutTestController::addChromeInputField()
+{
+notImplemented();
+}
+
+void LayoutTestController::removeChromeInputField()
+{
+notImplemented();
+}
+
+void LayoutTestController::focusWebView()
+{
+notImplemented();
+}
+
+void LayoutTestController::setBackingScaleFactor(double)
+{
+notImplemented();
+}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97997] trunk/Source/WebCore
Title: [97997] trunk/Source/WebCore Revision 97997 Author joep...@webkit.org Date 2011-10-20 10:33:40 -0700 (Thu, 20 Oct 2011) Log Message Remove Now Unused FileChooserSettings.deprecatedAcceptTypes https://bugs.webkit.org/show_bug.cgi?id=70473 Reviewed by Dan Bernstein. * html/FileInputType.cpp: (WebCore::FileInputType::handleDOMActivateEvent): (WebCore::FileInputType::receiveDropForDirectoryUpload): * platform/FileChooser.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/FileInputType.cpp trunk/Source/WebCore/platform/FileChooser.h Diff Modified: trunk/Source/WebCore/ChangeLog (97996 => 97997) --- trunk/Source/WebCore/ChangeLog 2011-10-20 17:23:05 UTC (rev 97996) +++ trunk/Source/WebCore/ChangeLog 2011-10-20 17:33:40 UTC (rev 97997) @@ -1,3 +1,15 @@ +2011-10-20 Joseph Pecoraro joep...@webkit.org + +Remove Now Unused FileChooserSettings.deprecatedAcceptTypes +https://bugs.webkit.org/show_bug.cgi?id=70473 + +Reviewed by Dan Bernstein. + +* html/FileInputType.cpp: +(WebCore::FileInputType::handleDOMActivateEvent): +(WebCore::FileInputType::receiveDropForDirectoryUpload): +* platform/FileChooser.h: + 2011-10-20 Andreas Kling kl...@webkit.org Simplify CSSParser::document(). Modified: trunk/Source/WebCore/html/FileInputType.cpp (97996 => 97997) --- trunk/Source/WebCore/html/FileInputType.cpp 2011-10-20 17:23:05 UTC (rev 97996) +++ trunk/Source/WebCore/html/FileInputType.cpp 2011-10-20 17:33:40 UTC (rev 97997) @@ -153,7 +153,6 @@ #else settings.allowsMultipleFiles = input-fastHasAttribute(multipleAttr); #endif -settings.deprecatedAcceptTypes = input-accept(); settings.acceptMIMETypes = input-acceptMIMETypes(); settings.selectedFiles = m_fileList-paths(); chrome-runOpenPanel(input-document()-frame(), newFileChooser(settings)); @@ -329,7 +328,6 @@ settings.allowsDirectoryUpload = true; settings.allowsMultipleFiles = true; settings.selectedFiles.append(paths[0]); -settings.deprecatedAcceptTypes = input-accept(); settings.acceptMIMETypes = input-acceptMIMETypes(); chrome-enumerateChosenDirectory(newFileChooser(settings)); } Modified: trunk/Source/WebCore/platform/FileChooser.h (97996 => 97997) --- trunk/Source/WebCore/platform/FileChooser.h 2011-10-20 17:23:05 UTC (rev 97996) +++ trunk/Source/WebCore/platform/FileChooser.h 2011-10-20 17:33:40 UTC (rev 97997) @@ -42,7 +42,6 @@ #if ENABLE(DIRECTORY_UPLOAD) bool allowsDirectoryUpload; #endif -String deprecatedAcceptTypes; VectorString acceptMIMETypes; VectorString selectedFiles; }; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98002] trunk/Source
Title: [98002] trunk/Source
Revision 98002
Author mhahnenb...@apple.com
Date 2011-10-20 11:14:50 -0700 (Thu, 20 Oct 2011)
Log Message
Rename static deleteProperty to deletePropertyByIndex
https://bugs.webkit.org/show_bug.cgi?id=70257
Reviewed by Geoffrey Garen.
Source/_javascript_Core:
Renaming versions of deleteProperty that use an unsigned as the property
name to deletePropertyByIndex in preparation for adding them to the
MethodTable, which requires unique names for each method.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSCdeletePropertyVirtual):
(JSCdeletePropertyByIndex):
* runtime/Arguments.cpp:
(JSC::Arguments::deletePropertyVirtual):
(JSC::Arguments::deletePropertyByIndex):
* runtime/Arguments.h:
* runtime/JSArray.cpp:
(JSC::JSArray::deletePropertyVirtual):
(JSC::JSArray::deletePropertyByIndex):
* runtime/JSArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::deletePropertyVirtual):
(JSC::JSCell::deletePropertyByIndex):
* runtime/JSCell.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::deletePropertyVirtual):
(JSC::JSNotAnObject::deletePropertyByIndex):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::deletePropertyVirtual):
(JSC::JSObject::deletePropertyByIndex):
* runtime/JSObject.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::deletePropertyVirtual):
(JSC::RegExpMatchesArray::deletePropertyByIndex):
Source/WebCore:
No new tests.
Renaming versions of deleteProperty that use an unsigned as the property
name to deletePropertyByIndex in preparation for adding them to the
MethodTable, which requires unique names for each method.
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::deletePropertyVirtual):
(JSC::RuntimeArray::deletePropertyByIndex):
* bridge/runtime_array.h:
Source/WebKit2:
Renaming versions of deleteProperty that use an unsigned as the property
name to deletePropertyByIndex in preparation for adding them to the
MethodTable, which requires unique names for each method.
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::deletePropertyVirtual):
(WebKit::JSNPObject::deletePropertyByIndex):
* WebProcess/Plugins/Netscape/JSNPObject.h:
Modified Paths
trunk/Source/_javascript_Core/API/JSCallbackObject.h
trunk/Source/_javascript_Core/API/JSCallbackObjectFunctions.h
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Arguments.cpp
trunk/Source/_javascript_Core/runtime/Arguments.h
trunk/Source/_javascript_Core/runtime/JSArray.cpp
trunk/Source/_javascript_Core/runtime/JSArray.h
trunk/Source/_javascript_Core/runtime/JSCell.cpp
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSNotAnObject.cpp
trunk/Source/_javascript_Core/runtime/JSNotAnObject.h
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/RegExpMatchesArray.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bridge/runtime_array.cpp
trunk/Source/WebCore/bridge/runtime_array.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.h
Diff
Modified: trunk/Source/_javascript_Core/API/JSCallbackObject.h (98001 => 98002)
--- trunk/Source/_javascript_Core/API/JSCallbackObject.h 2011-10-20 18:12:08 UTC (rev 98001)
+++ trunk/Source/_javascript_Core/API/JSCallbackObject.h 2011-10-20 18:14:50 UTC (rev 98002)
@@ -188,7 +188,7 @@
virtual bool deletePropertyVirtual(ExecState*, const Identifier);
static bool deleteProperty(JSCell*, ExecState*, const Identifier);
virtual bool deletePropertyVirtual(ExecState*, unsigned);
-static bool deleteProperty(JSCell*, ExecState*, unsigned);
+static bool deletePropertyByIndex(JSCell*, ExecState*, unsigned);
virtual bool hasInstance(ExecState* exec, JSValue value, JSValue proto);
Modified: trunk/Source/_javascript_Core/API/JSCallbackObjectFunctions.h (98001 => 98002)
--- trunk/Source/_javascript_Core/API/JSCallbackObjectFunctions.h 2011-10-20 18:12:08 UTC (rev 98001)
+++ trunk/Source/_javascript_Core/API/JSCallbackObjectFunctions.h 2011-10-20 18:14:50 UTC (rev 98002)
@@ -325,11 +325,11 @@
template class Parent
bool JSCallbackObjectParent::deletePropertyVirtual(ExecState* exec, unsigned propertyName)
{
-return deleteProperty(this, exec, propertyName);
+return deletePropertyByIndex(this, exec, propertyName);
}
template class Parent
-bool JSCallbackObjectParent::deleteProperty(JSCell* cell, ExecState* exec, unsigned propertyName)
+bool JSCallbackObjectParent::deletePropertyByIndex(JSCell* cell, ExecState* exec, unsigned propertyName)
{
return static_castJSCallbackObject*(cell)-deletePropertyVirtual(exec, Identifier::from(exec, propertyName));
}
Modified: trunk/Source/_javascript_Core/ChangeLog (98001 => 98002)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-20 18:12:08 UTC (rev 98001)
+++
[webkit-changes] [98003] branches/safari-534.52-branch/
Title: [98003] branches/safari-534.52-branch/ Revision 98003 Author lforsch...@apple.com Date 2011-10-20 11:17:23 -0700 (Thu, 20 Oct 2011) Log Message New Branch. Added Paths branches/safari-534.52-branch/ Diff Property changes: branches/safari-534.52-branch Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98004] trunk/LayoutTests
Title: [98004] trunk/LayoutTests Revision 98004 Author dch...@chromium.org Date 2011-10-20 11:25:21 -0700 (Thu, 20 Oct 2011) Log Message Update expectations after r97878. https://bugs.webkit.org/show_bug.cgi?id=70527 Reviewed by Tony Chang. * platform/chromium-cg-mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: * platform/chromium-cg-mac-leopard/editing/selection/drag-to-contenteditable-iframe-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/selection/drag-to-contenteditable-iframe-expected.png: Added. * platform/chromium-cg-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Removed. * platform/chromium-linux/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: * platform/chromium-linux/editing/selection/drag-to-contenteditable-iframe-expected.png: * platform/chromium-mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added. * platform/chromium-mac-leopard/editing/selection/drag-to-contenteditable-iframe-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/selection/drag-to-contenteditable-iframe-expected.png. * platform/chromium-mac-snowleopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added. * platform/chromium-mac-snowleopard/editing/selection/drag-to-contenteditable-iframe-expected.png: Added. * platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Removed. * platform/chromium-win/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: * platform/chromium-win/editing/selection/drag-to-contenteditable-iframe-expected.png: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png trunk/LayoutTests/platform/chromium-linux/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png trunk/LayoutTests/platform/chromium-linux/editing/selection/drag-to-contenteditable-iframe-expected.png trunk/LayoutTests/platform/chromium-win/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png trunk/LayoutTests/platform/chromium-win/editing/selection/drag-to-contenteditable-iframe-expected.png Added Paths trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/selection/drag-to-contenteditable-iframe-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/editing/selection/drag-to-contenteditable-iframe-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/drag-to-contenteditable-iframe-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/drag-to-contenteditable-iframe-expected.png Removed Paths trunk/LayoutTests/platform/chromium-cg-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png trunk/LayoutTests/platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png trunk/LayoutTests/platform/chromium-mac/editing/selection/drag-to-contenteditable-iframe-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (98003 => 98004) --- trunk/LayoutTests/ChangeLog 2011-10-20 18:17:23 UTC (rev 98003) +++ trunk/LayoutTests/ChangeLog 2011-10-20 18:25:21 UTC (rev 98004) @@ -1,3 +1,26 @@ +2011-10-20 Daniel Cheng dch...@chromium.org + +Update expectations after r97878. +https://bugs.webkit.org/show_bug.cgi?id=70527 + +Reviewed by Tony Chang. + +* platform/chromium-cg-mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: +* platform/chromium-cg-mac-leopard/editing/selection/drag-to-contenteditable-iframe-expected.png: Added. +* platform/chromium-cg-mac-snowleopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added. +* platform/chromium-cg-mac-snowleopard/editing/selection/drag-to-contenteditable-iframe-expected.png: Added. +* platform/chromium-cg-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Removed. +* platform/chromium-linux/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: +* platform/chromium-linux/editing/selection/drag-to-contenteditable-iframe-expected.png: +*
[webkit-changes] [98005] trunk/Source/WebCore
Title: [98005] trunk/Source/WebCore
Revision 98005
Author commit-qu...@webkit.org
Date 2011-10-20 11:26:15 -0700 (Thu, 20 Oct 2011)
Log Message
Playing HTMLAudioElement can be garbage collected
https://bugs.webkit.org/show_bug.cgi?id=66878
Patch by Eugene Nalimov e...@chromium.org on 2011-10-20
Reviewed by Adam Barth.
Make HTMLAudioElement an 'active' one, meaning that it cannot be
garbage collected if it has panding activity. Had to make
HTMLMediaElement::hasPendingActivity() and
HTMLAudioElement::hasPendingActivity() public, otherwise automatically
generated code would not compile.
Test: no test, as automatic test is blocked by
https://bugs.webkit.org/show_bug.cgi?id=70421
You don't want to sit down and listen if audio stream played completely,
and cannot rely on 'ended' event because events are lost when events
listener is collected.
* html/HTMLAudioElement.idl:
* html/HTMLAudioElement.h:
(WebCore::HTMLAudioElement::hasPendingActivity):
* html/HTMLMediaElement.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8HTMLAudioElementConstructor.cpp
trunk/Source/WebCore/html/HTMLAudioElement.h
trunk/Source/WebCore/html/HTMLAudioElement.idl
trunk/Source/WebCore/html/HTMLMediaElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98004 => 98005)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 18:25:21 UTC (rev 98004)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 18:26:15 UTC (rev 98005)
@@ -1,3 +1,27 @@
+2011-10-20 Eugene Nalimov e...@chromium.org
+
+Playing HTMLAudioElement can be garbage collected
+https://bugs.webkit.org/show_bug.cgi?id=66878
+
+Reviewed by Adam Barth.
+
+Make HTMLAudioElement an 'active' one, meaning that it cannot be
+garbage collected if it has panding activity. Had to make
+HTMLMediaElement::hasPendingActivity() and
+HTMLAudioElement::hasPendingActivity() public, otherwise automatically
+generated code would not compile.
+
+Test: no test, as automatic test is blocked by
+https://bugs.webkit.org/show_bug.cgi?id=70421
+You don't want to sit down and listen if audio stream played completely,
+and cannot rely on 'ended' event because events are lost when events
+listener is collected.
+
+* html/HTMLAudioElement.idl:
+* html/HTMLAudioElement.h:
+(WebCore::HTMLAudioElement::hasPendingActivity):
+* html/HTMLMediaElement.h:
+
2011-10-20 Mark Hahnenberg mhahnenb...@apple.com
Rename static deleteProperty to deletePropertyByIndex
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLAudioElementConstructor.cpp (98004 => 98005)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLAudioElementConstructor.cpp 2011-10-20 18:25:21 UTC (rev 98004)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLAudioElementConstructor.cpp 2011-10-20 18:26:15 UTC (rev 98005)
@@ -47,7 +47,7 @@
namespace WebCore {
-WrapperTypeInfo V8HTMLAudioElementConstructor::info = { V8HTMLAudioElementConstructor::GetTemplate, 0, 0, 0 };
+WrapperTypeInfo V8HTMLAudioElementConstructor::info = { V8HTMLAudioElementConstructor::GetTemplate, V8HTMLAudioElement::derefObject, V8HTMLAudioElement::toActiveDOMObject, 0 };
static v8::Handlev8::Value v8HTMLAudioElementConstructorCallback(const v8::Arguments args)
{
@@ -71,7 +71,6 @@
// may end up being the only node in the map and get garbage-collected prematurely.
toV8(document);
-
String src;
if (args.Length() 0)
src = ""
@@ -79,7 +78,7 @@
V8DOMWrapper::setDOMWrapper(args.Holder(), V8HTMLAudioElementConstructor::info, audio.get());
audio-ref();
-V8DOMWrapper::setJSWrapperForDOMNode(audio.get(), v8::Persistentv8::Object::New(args.Holder()));
+V8DOMWrapper::setJSWrapperForActiveDOMObject(audio.get(), v8::Persistentv8::Object::New(args.Holder()));
return args.Holder();
}
Modified: trunk/Source/WebCore/html/HTMLAudioElement.h (98004 => 98005)
--- trunk/Source/WebCore/html/HTMLAudioElement.h 2011-10-20 18:25:21 UTC (rev 98004)
+++ trunk/Source/WebCore/html/HTMLAudioElement.h 2011-10-20 18:26:15 UTC (rev 98005)
@@ -40,6 +40,8 @@
static PassRefPtrHTMLAudioElement create(const QualifiedName, Document*);
static PassRefPtrHTMLAudioElement createForJSConstructor(Document*, const String src);
+virtual bool hasPendingActivity() const { return isPlaying() || HTMLMediaElement::hasPendingActivity(); }
+
private:
HTMLAudioElement(const QualifiedName, Document*);
Modified: trunk/Source/WebCore/html/HTMLAudioElement.idl (98004 => 98005)
--- trunk/Source/WebCore/html/HTMLAudioElement.idl 2011-10-20 18:25:21 UTC (rev 98004)
+++ trunk/Source/WebCore/html/HTMLAudioElement.idl 2011-10-20 18:26:15 UTC (rev 98005)
@@ -25,8 +25,9 @@
module html {
interface [
+ActiveDOMObject,
Conditional=VIDEO
] HTMLAudioElement : HTMLMediaElement {
-
+
};
}
Modified:
[webkit-changes] [98006] trunk/Source/WebCore
Title: [98006] trunk/Source/WebCore
Revision 98006
Author commit-qu...@webkit.org
Date 2011-10-20 11:37:14 -0700 (Thu, 20 Oct 2011)
Log Message
Remove StyleBase::cssText().
https://bugs.webkit.org/show_bug.cgi?id=70521
Patch by Andreas Kling kl...@webkit.org on 2011-10-20
Reviewed by Antti Koivisto.
* css/StyleBase.cpp:
* css/StyleBase.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleBase.cpp
trunk/Source/WebCore/css/StyleBase.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98005 => 98006)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 18:26:15 UTC (rev 98005)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 18:37:14 UTC (rev 98006)
@@ -1,3 +1,13 @@
+2011-10-20 Andreas Kling kl...@webkit.org
+
+Remove StyleBase::cssText().
+https://bugs.webkit.org/show_bug.cgi?id=70521
+
+Reviewed by Antti Koivisto.
+
+* css/StyleBase.cpp:
+* css/StyleBase.h:
+
2011-10-20 Eugene Nalimov e...@chromium.org
Playing HTMLAudioElement can be garbage collected
Modified: trunk/Source/WebCore/css/StyleBase.cpp (98005 => 98006)
--- trunk/Source/WebCore/css/StyleBase.cpp 2011-10-20 18:26:15 UTC (rev 98005)
+++ trunk/Source/WebCore/css/StyleBase.cpp 2011-10-20 18:37:14 UTC (rev 98006)
@@ -30,11 +30,6 @@
namespace WebCore {
-String StyleBase::cssText() const
-{
-return ;
-}
-
void StyleBase::checkLoaded()
{
if (parent())
Modified: trunk/Source/WebCore/css/StyleBase.h (98005 => 98006)
--- trunk/Source/WebCore/css/StyleBase.h 2011-10-20 18:26:15 UTC (rev 98005)
+++ trunk/Source/WebCore/css/StyleBase.h 2011-10-20 18:37:14 UTC (rev 98006)
@@ -53,8 +53,6 @@
virtual bool isCSSStyleSheet() const { return false; }
virtual bool isXSLStyleSheet() const { return false; }
-virtual String cssText() const;
-
virtual void checkLoaded();
bool useStrictParsing() const { return !m_parent || m_parent-useStrictParsing(); }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98012] trunk/LayoutTests
Title: [98012] trunk/LayoutTests
Revision 98012
Author lean...@webkit.org
Date 2011-10-20 12:28:01 -0700 (Thu, 20 Oct 2011)
Log Message
Unreviewed. Add remaining EFL baselines.
* platform/efl/fast/html: Added.
* platform/efl/fast/html/keygen-expected.txt: Added.
* platform/efl/fast/html/link-rel-stylesheet-expected.txt: Added.
* platform/efl/fast/html/listing-expected.txt: Added.
* platform/efl/fast/html/marquee-scroll-expected.txt: Added.
* platform/efl/fast/html/marquee-scrollamount-expected.txt: Added.
* platform/efl/fast/loader: Added.
* platform/efl/fast/loader/text-document-wrapping-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/efl/fast/html/
trunk/LayoutTests/platform/efl/fast/html/keygen-expected.txt
trunk/LayoutTests/platform/efl/fast/html/link-rel-stylesheet-expected.txt
trunk/LayoutTests/platform/efl/fast/html/listing-expected.txt
trunk/LayoutTests/platform/efl/fast/html/marquee-scroll-expected.txt
trunk/LayoutTests/platform/efl/fast/html/marquee-scrollamount-expected.txt
trunk/LayoutTests/platform/efl/fast/loader/
trunk/LayoutTests/platform/efl/fast/loader/text-document-wrapping-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98011 => 98012)
--- trunk/LayoutTests/ChangeLog 2011-10-20 19:27:37 UTC (rev 98011)
+++ trunk/LayoutTests/ChangeLog 2011-10-20 19:28:01 UTC (rev 98012)
@@ -1,3 +1,16 @@
+2011-10-20 Leandro Pereira lean...@profusion.mobi
+
+Unreviewed. Add remaining EFL baselines.
+
+* platform/efl/fast/html: Added.
+* platform/efl/fast/html/keygen-expected.txt: Added.
+* platform/efl/fast/html/link-rel-stylesheet-expected.txt: Added.
+* platform/efl/fast/html/listing-expected.txt: Added.
+* platform/efl/fast/html/marquee-scroll-expected.txt: Added.
+* platform/efl/fast/html/marquee-scrollamount-expected.txt: Added.
+* platform/efl/fast/loader: Added.
+* platform/efl/fast/loader/text-document-wrapping-expected.txt: Added.
+
2011-10-20 Ken Buchanan ke...@chromium.org
Crash in updateFirstLetter on :after generated content
Added: trunk/LayoutTests/platform/efl/fast/html/keygen-expected.txt (0 => 98012)
--- trunk/LayoutTests/platform/efl/fast/html/keygen-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/fast/html/keygen-expected.txt 2011-10-20 19:28:01 UTC (rev 98012)
@@ -0,0 +1,10 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {KEYGEN} at (2,2) size 56x39
+RenderMenuList {SELECT} at (0,0) size 56x39 [color=#202020]
+ RenderBlock (anonymous) at (15,10) size 0x19
+RenderBR at (0,0) size 0x19
+ RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/platform/efl/fast/html/link-rel-stylesheet-expected.txt (0 => 98012)
--- trunk/LayoutTests/platform/efl/fast/html/link-rel-stylesheet-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/fast/html/link-rel-stylesheet-expected.txt 2011-10-20 19:28:01 UTC (rev 98012)
@@ -0,0 +1,17 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x156
+ RenderBlock {HTML} at (0,0) size 800x156
+RenderBody {BODY} at (8,16) size 784x124
+ RenderBlock {P} at (0,0) size 784x19
+RenderText {#text} at (0,0) size 262x19
+ text run at (0,0) width 262: This line should not have red background
+ RenderBlock {P} at (0,35) size 784x19 [bgcolor=#00FF00]
+RenderText {#text} at (0,0) size 245x19
+ text run at (0,0) width 245: This line should have lime background
+ RenderBlock {P} at (0,70) size 784x19
+RenderText {#text} at (0,0) size 262x19
+ text run at (0,0) width 262: This line should not have red background
+ RenderBlock {P} at (0,105) size 784x19 [bgcolor=#00FF00]
+RenderText {#text} at (0,0) size 245x19
+ text run at (0,0) width 245: This line should have lime background
Added: trunk/LayoutTests/platform/efl/fast/html/listing-expected.txt (0 => 98012)
--- trunk/LayoutTests/platform/efl/fast/html/listing-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/fast/html/listing-expected.txt 2011-10-20 19:28:01 UTC (rev 98012)
@@ -0,0 +1,25 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x576
+ RenderBlock {P} at (0,0) size 784x19
+RenderText {#text} at (0,0) size 406x19
+ text run at (0,0) width 406: This tests the listing tag. It's an obsolete synonym for the pre tag.
+ RenderBlock {DIV} at (0,35) size 784x19
+RenderText {#text} at (0,0) size 168x19
+ text run at (0,0) width 168: Text just before the listing.
+
[webkit-changes] [98014] trunk/Source/WebCore
Title: [98014] trunk/Source/WebCore Revision 98014 Author t...@chromium.org Date 2011-10-20 12:36:22 -0700 (Thu, 20 Oct 2011) Log Message Fix a compiler warning in MediaStreamTrack.cpp: ../../third_party/WebKit/Source/WebCore/dom/MediaStreamTrack.cpp: In member function 'WTF::String WebCore::MediaStreamTrack::kind() const': ../../third_party/WebKit/Source/WebCore/dom/MediaStreamTrack.cpp:61:1: error: control reaches end of non-void function [-Werror=return-type] Unreviewed build fix. * dom/MediaStreamTrack.cpp: (WebCore::MediaStreamTrack::kind): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/MediaStreamTrack.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (98013 => 98014) --- trunk/Source/WebCore/ChangeLog 2011-10-20 19:34:05 UTC (rev 98013) +++ trunk/Source/WebCore/ChangeLog 2011-10-20 19:36:22 UTC (rev 98014) @@ -1,3 +1,14 @@ +2011-10-20 Tony Chang t...@chromium.org + +Fix a compiler warning in MediaStreamTrack.cpp: +../../third_party/WebKit/Source/WebCore/dom/MediaStreamTrack.cpp: In member function 'WTF::String WebCore::MediaStreamTrack::kind() const': +../../third_party/WebKit/Source/WebCore/dom/MediaStreamTrack.cpp:61:1: error: control reaches end of non-void function [-Werror=return-type] + +Unreviewed build fix. + +* dom/MediaStreamTrack.cpp: +(WebCore::MediaStreamTrack::kind): + 2011-10-20 Gustavo Noronha Silva g...@gnome.org One more GTK+ build fix. Remove CueLoader files from the build. Modified: trunk/Source/WebCore/dom/MediaStreamTrack.cpp (98013 => 98014) --- trunk/Source/WebCore/dom/MediaStreamTrack.cpp 2011-10-20 19:34:05 UTC (rev 98013) +++ trunk/Source/WebCore/dom/MediaStreamTrack.cpp 2011-10-20 19:36:22 UTC (rev 98014) @@ -58,6 +58,7 @@ } ASSERT_NOT_REACHED(); +return String(); } String MediaStreamTrack::label() const ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98016] trunk/Source
Title: [98016] trunk/Source Revision 98016 Author sch...@chromium.org Date 2011-10-20 12:59:14 -0700 (Thu, 20 Oct 2011) Log Message MouseLock compile and run time flags. https://bugs.webkit.org/show_bug.cgi?id=70530 Reviewed by Darin Fisher. Source/_javascript_Core: * wtf/Platform.h: Source/WebCore: No new tests. * bindings/generic/RuntimeEnabledFeatures.cpp: * bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::webkitMouseLockAPIEnabled): (WebCore::RuntimeEnabledFeatures::setWebkitMouseLockAPIEnabled): (WebCore::RuntimeEnabledFeatures::webkitLockMouseEnabled): (WebCore::RuntimeEnabledFeatures::webkitUnlockMouseEnabled): (WebCore::RuntimeEnabledFeatures::webkitMouseLockedEnabled): * page/Settings.cpp: (WebCore::Settings::Settings): * page/Settings.h: (WebCore::Settings::setMouseLockEnabled): (WebCore::Settings::mouseLockEnabled): Source/WebKit/chromium: * features.gypi: * public/WebRuntimeFeatures.h: * public/WebSettings.h: * src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableMouseLockAPI): (WebKit::WebRuntimeFeatures::isMouseLockAPIEnabled): * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setMouseLockEnabled): * src/WebSettingsImpl.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wtf/Platform.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h trunk/Source/WebCore/page/Settings.cpp trunk/Source/WebCore/page/Settings.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/features.gypi trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h trunk/Source/WebKit/chromium/public/WebSettings.h trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp trunk/Source/WebKit/chromium/src/WebSettingsImpl.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (98015 => 98016) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-20 19:44:28 UTC (rev 98015) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-20 19:59:14 UTC (rev 98016) @@ -1,3 +1,12 @@ +2011-10-20 Vincent Scheib sch...@chromium.org + +MouseLock compile and run time flags. +https://bugs.webkit.org/show_bug.cgi?id=70530 + +Reviewed by Darin Fisher. + +* wtf/Platform.h: + 2011-10-20 Mark Hahnenberg mhahnenb...@apple.com Rename static deleteProperty to deletePropertyByIndex Modified: trunk/Source/_javascript_Core/wtf/Platform.h (98015 => 98016) --- trunk/Source/_javascript_Core/wtf/Platform.h 2011-10-20 19:44:28 UTC (rev 98015) +++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-10-20 19:59:14 UTC (rev 98016) @@ -841,6 +841,10 @@ #define ENABLE_FULLSCREEN_API 0 #endif +#if !defined(ENABLE_MOUSE_LOCK_API) +#define ENABLE_MOUSE_LOCK_API 0 +#endif + #if !defined(WTF_USE_JSVALUE64) !defined(WTF_USE_JSVALUE32_64) #if (CPU(X86_64) (OS(UNIX) || OS(WINDOWS))) \ || (CPU(IA64) !CPU(IA64_32)) \ Modified: trunk/Source/WebCore/ChangeLog (98015 => 98016) --- trunk/Source/WebCore/ChangeLog 2011-10-20 19:44:28 UTC (rev 98015) +++ trunk/Source/WebCore/ChangeLog 2011-10-20 19:59:14 UTC (rev 98016) @@ -1,3 +1,25 @@ +2011-10-20 Vincent Scheib sch...@chromium.org + +MouseLock compile and run time flags. +https://bugs.webkit.org/show_bug.cgi?id=70530 + +Reviewed by Darin Fisher. + +No new tests. + +* bindings/generic/RuntimeEnabledFeatures.cpp: +* bindings/generic/RuntimeEnabledFeatures.h: +(WebCore::RuntimeEnabledFeatures::webkitMouseLockAPIEnabled): +(WebCore::RuntimeEnabledFeatures::setWebkitMouseLockAPIEnabled): +(WebCore::RuntimeEnabledFeatures::webkitLockMouseEnabled): +(WebCore::RuntimeEnabledFeatures::webkitUnlockMouseEnabled): +(WebCore::RuntimeEnabledFeatures::webkitMouseLockedEnabled): +* page/Settings.cpp: +(WebCore::Settings::Settings): +* page/Settings.h: +(WebCore::Settings::setMouseLockEnabled): +(WebCore::Settings::mouseLockEnabled): + 2011-10-20 Tony Chang t...@chromium.org Fix a compiler warning in MediaStreamTrack.cpp: Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (98015 => 98016) --- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2011-10-20 19:44:28 UTC (rev 98015) +++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2011-10-20 19:59:14 UTC (rev 98016) @@ -155,6 +155,10 @@ bool RuntimeEnabledFeatures::isFullScreenAPIEnabled = true; #endif +#if ENABLE(MOUSE_LOCK_API) +bool RuntimeEnabledFeatures::isMouseLockAPIEnabled = false; +#endif + #if ENABLE(MEDIA_SOURCE) bool RuntimeEnabledFeatures::isMediaSourceEnabled = false; #endif Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (98015 => 98016) --- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2011-10-20
[webkit-changes] [98017] branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp
Title: [98017] branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp
Revision 98017
Author gav...@chromium.org
Date 2011-10-20 13:01:05 -0700 (Thu, 20 Oct 2011)
Log Message
Manual workaround for chromium bug 75604
BUG=75604
Review URL: http://codereview.chromium.org/8361008/
Modified Paths
branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp
Diff
Modified: branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp (98016 => 98017)
--- branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp 2011-10-20 19:59:14 UTC (rev 98016)
+++ branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp 2011-10-20 20:01:05 UTC (rev 98017)
@@ -322,6 +322,10 @@
void ScriptElement::notifyFinished(CachedResource* o)
{
+// crbug.com/75604 causes double notification in some situations, disregarding the second notification
+// is a workaround.
+if (!m_cachedScript)
+return;
ASSERT(!m_willBeParserExecuted);
ASSERT_UNUSED(o, o == m_cachedScript);
if (m_willExecuteInOrder)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98019] branches/chromium/912
Title: [98019] branches/chromium/912
Revision 98019
Author jchaffr...@webkit.org
Date 2011-10-20 13:27:03 -0700 (Thu, 20 Oct 2011)
Log Message
Merge 97907 - Multiple crashes in RenderTable during layout
https://bugs.webkit.org/show_bug.cgi?id=70392
Reviewed by Simon Fraser.
Source/WebCore:
Tests: fast/table/crash-anonymous-table-computeLogicalWidth.html
fast/table/crash-anonymous-table-layout.html
r97555 forgot to take into account anonymous tables during layout
where RenderObject::node() is NULL.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::layout):
Added a check for node() before calling Node::hasTagName.
LayoutTests:
* fast/table/crash-anonymous-table-computeLogicalWidth-expected.txt: Added.
* fast/table/crash-anonymous-table-computeLogicalWidth.html: Added.
* fast/table/crash-anonymous-table-layout-expected.txt: Added.
* fast/table/crash-anonymous-table-layout.html: Added.
TBR=jchaffr...@webkit.org
Review URL: http://codereview.chromium.org/8366015
Modified Paths
branches/chromium/912/Source/WebCore/rendering/RenderTable.cpp
Added Paths
branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-computeLogicalWidth-expected.txt
branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-computeLogicalWidth.html
branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-layout-expected.txt
branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-layout.html
Diff
Copied: branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-computeLogicalWidth-expected.txt (from rev 97907, trunk/LayoutTests/fast/table/crash-anonymous-table-computeLogicalWidth-expected.txt) (0 => 98019)
--- branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-computeLogicalWidth-expected.txt (rev 0)
+++ branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-computeLogicalWidth-expected.txt 2011-10-20 20:27:03 UTC (rev 98019)
@@ -0,0 +1,2 @@
+Bug 70392: Multiple crashes in RenderTable during layout
+This test passes if it does not CRASH.
Copied: branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-computeLogicalWidth.html (from rev 97907, trunk/LayoutTests/fast/table/crash-anonymous-table-computeLogicalWidth.html) (0 => 98019)
--- branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-computeLogicalWidth.html (rev 0)
+++ branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-computeLogicalWidth.html 2011-10-20 20:27:03 UTC (rev 98019)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+html
+head
+style
+.tableBefore:before { display: inline-table; content: url(data:text/plain,foo); width: 10px; }
+/style
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+/script
+/head
+body
+div class=tableBefore/div
+divBug a href="" Multiple crashes in RenderTable during layout/div
+divThis test passes if it does not CRASH./div
+/body
+/html
Copied: branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-layout-expected.txt (from rev 97907, trunk/LayoutTests/fast/table/crash-anonymous-table-layout-expected.txt) (0 => 98019)
--- branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-layout-expected.txt (rev 0)
+++ branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-layout-expected.txt 2011-10-20 20:27:03 UTC (rev 98019)
@@ -0,0 +1,2 @@
+Bug 70392: Multiple crashes in RenderTable during layout
+This test passes if it does not CRASH.
Copied: branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-layout.html (from rev 97907, trunk/LayoutTests/fast/table/crash-anonymous-table-layout.html) (0 => 98019)
--- branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-layout.html (rev 0)
+++ branches/chromium/912/LayoutTests/fast/table/crash-anonymous-table-layout.html 2011-10-20 20:27:03 UTC (rev 98019)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+html
+head
+style
+.tableAfter::after { display: table; content: attr(class); height: 1px; }
+/style
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+/script
+/head
+body
+div class=tableAfter/div
+divBug a href="" Multiple crashes in RenderTable during layout/div
+divThis test passes if it does not CRASH./div
+/body
+/html
Modified: branches/chromium/912/Source/WebCore/rendering/RenderTable.cpp (98018 => 98019)
--- branches/chromium/912/Source/WebCore/rendering/RenderTable.cpp 2011-10-20 20:05:44 UTC (rev 98018)
+++ branches/chromium/912/Source/WebCore/rendering/RenderTable.cpp 2011-10-20 20:27:03 UTC (rev 98019)
@@ -239,7 +239,7 @@
// Percent or fixed table
// HTML tables size as though CSS width includes border/padding, CSS tables do not.
LayoutUnit borders = 0;
-if (!node()-hasTagName(tableTag)) {
+if (!node() || !node()-hasTagName(tableTag)) {
bool
[webkit-changes] [98020] trunk/Source/WebCore
Title: [98020] trunk/Source/WebCore Revision 98020 Author simon.fra...@apple.com Date 2011-10-20 13:57:47 -0700 (Thu, 20 Oct 2011) Log Message Fix build breakage on some platforms after r98008. * page/FrameTree.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/FrameTree.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (98019 => 98020) --- trunk/Source/WebCore/ChangeLog 2011-10-20 20:27:03 UTC (rev 98019) +++ trunk/Source/WebCore/ChangeLog 2011-10-20 20:57:47 UTC (rev 98020) @@ -1,3 +1,9 @@ +2011-10-20 Simon Fraser simon.fra...@apple.com + +Fix build breakage on some platforms after r98008. + +* page/FrameTree.cpp: + 2011-10-20 Vincent Scheib sch...@chromium.org MouseLock compile and run time flags. Modified: trunk/Source/WebCore/page/FrameTree.cpp (98019 => 98020) --- trunk/Source/WebCore/page/FrameTree.cpp 2011-10-20 20:27:03 UTC (rev 98019) +++ trunk/Source/WebCore/page/FrameTree.cpp 2011-10-20 20:57:47 UTC (rev 98020) @@ -25,6 +25,7 @@ #include FrameView.h #include Page.h #include PageGroup.h +#include Document.h #include stdarg.h #include wtf/StringExtras.h #include wtf/Vector.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98021] trunk
Title: [98021] trunk
Revision 98021
Author hy...@apple.com
Date 2011-10-20 14:12:00 -0700 (Thu, 20 Oct 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=70539
Make the 'clip' property work in variable width regions.
Reviewed by Dan Bernstein.
Source/WebCore:
Added new test in fast/regions.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::clipRect):
* rendering/RenderBox.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::calculateRects):
(WebCore::RenderLayer::repaintBlockSelectionGaps):
* rendering/RenderLayerBacking.cpp:
(WebCore::clipBox):
LayoutTests:
* fast/regions/positioned-objects-clipped-spanning-regions.html: Added.
* platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
Added Paths
trunk/LayoutTests/fast/regions/positioned-objects-clipped-spanning-regions.html
trunk/LayoutTests/platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.png
trunk/LayoutTests/platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98020 => 98021)
--- trunk/LayoutTests/ChangeLog 2011-10-20 20:57:47 UTC (rev 98020)
+++ trunk/LayoutTests/ChangeLog 2011-10-20 21:12:00 UTC (rev 98021)
@@ -1,3 +1,15 @@
+2011-10-20 David Hyatt hy...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=70539
+
+Make the 'clip' property work in variable width regions.
+
+Reviewed by Dan Bernstein.
+
+* fast/regions/positioned-objects-clipped-spanning-regions.html: Added.
+* platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.png: Added.
+* platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.txt: Added.
+
2011-10-20 Csaba Osztrogonác o...@webkit.org
[Qt] FontCache::createFontPlatformData() is broken, a default font is returned
Added: trunk/LayoutTests/fast/regions/positioned-objects-clipped-spanning-regions.html (0 => 98021)
--- trunk/LayoutTests/fast/regions/positioned-objects-clipped-spanning-regions.html (rev 0)
+++ trunk/LayoutTests/fast/regions/positioned-objects-clipped-spanning-regions.html 2011-10-20 21:12:00 UTC (rev 98021)
@@ -0,0 +1,63 @@
+!doctype html
+
+html style=direction:rtl
+head
+ style
+#content {
+-webkit-flow-into: flow1;
+text-align: justify;
+padding: 5px;
+}
+
+#first-box {
+margin:10%
+}
+
+#second-box {
+position:absolute;
+right:0;
+top:0;
+height:450px;
+width:50%;
+background-color:green;
+border-left:10px solid red;
+clip:rect(0 300px 450px 10px)
+}
+
+#region1, #region2, #region3 {
+border: 1px solid black;
+-webkit-flow-from: flow1;
+}
+
+#region1 {
+width: 200px;
+height: 150px;
+}
+
+#region2 {
+width: 300px;
+height: 180px;
+}
+
+#region3 {
+width: 120px;
+height: 120px;
+}
+/style
+/head
+body
+p style=direction:ltrThe green positioned object should span all the regions. It should fill the right half of every region. Its red borders should be clipped./p
+
+div id=content
+div id=first-box
+div id=second-box
+
+/div
+/div
+/div
+
+div id=container
+div id=region1/div
+div id=region2/div
+div id=region3/div
+/div
Added: trunk/LayoutTests/platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.txt (0 => 98021)
--- trunk/LayoutTests/platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.txt 2011-10-20 21:12:00 UTC (rev 98021)
@@ -0,0 +1,25 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x532
+ RenderBlock {HTML} at (0,0) size 800x532
+RenderBody {BODY} at (8,16) size 784x508
+ RenderBlock {P} at (0,0) size 784x36
+RenderText {#text} at (0,0) size 777x36
+ text run at (0,0) width 777: The green positioned object should span
[webkit-changes] [98023] trunk/Tools
Title: [98023] trunk/Tools
Revision 98023
Author t...@chromium.org
Date 2011-10-20 14:33:29 -0700 (Thu, 20 Oct 2011)
Log Message
[chromium] Remove stdint.h from ImageDiff and use
unsigned int instead of uint32_t.
Unreviewed, fixing the chromium win build.
* DumpRenderTree/chromium/ImageDiff.cpp:
(Image::pixelAt):
(Image::setPixelAt):
(maxOf3):
(getRedComponent):
(getGreenComponent):
(getBlueComponent):
(weightedPercentageDifferent):
(createImageDiff):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/ImageDiff.cpp
Diff
Modified: trunk/Tools/ChangeLog (98022 => 98023)
--- trunk/Tools/ChangeLog 2011-10-20 21:27:54 UTC (rev 98022)
+++ trunk/Tools/ChangeLog 2011-10-20 21:33:29 UTC (rev 98023)
@@ -1,3 +1,20 @@
+2011-10-20 Tony Chang t...@chromium.org
+
+[chromium] Remove stdint.h from ImageDiff and use
+unsigned int instead of uint32_t.
+
+Unreviewed, fixing the chromium win build.
+
+* DumpRenderTree/chromium/ImageDiff.cpp:
+(Image::pixelAt):
+(Image::setPixelAt):
+(maxOf3):
+(getRedComponent):
+(getGreenComponent):
+(getBlueComponent):
+(weightedPercentageDifferent):
+(createImageDiff):
+
2011-10-20 Hao Zheng zheng...@chromium.org
[Chromium] Reduce dependencies of ImageDiff to compile it for Android.
Modified: trunk/Tools/DumpRenderTree/chromium/ImageDiff.cpp (98022 => 98023)
--- trunk/Tools/DumpRenderTree/chromium/ImageDiff.cpp 2011-10-20 21:27:54 UTC (rev 98022)
+++ trunk/Tools/DumpRenderTree/chromium/ImageDiff.cpp 2011-10-20 21:33:29 UTC (rev 98023)
@@ -40,7 +40,6 @@
#include algorithm
#include iterator
#include limits.h
-#include stdint.h
#include stdio.h
#include string.h
#include vector
@@ -79,8 +78,8 @@
static const int statusError = 2;
// Color codes.
-static const uint32_t rgbaRed = 0x00ff;
-static const uint32_t rgbaAlpha = 0xff00;
+static const unsigned int rgbaRed = 0x00ff;
+static const unsigned int rgbaAlpha = 0xff00;
class Image {
public:
@@ -151,19 +150,19 @@
}
// Returns the RGBA value of the pixel at the given location
-const uint32_t pixelAt(int x, int y) const
+const unsigned int pixelAt(int x, int y) const
{
ASSERT(x = 0 x m_width);
ASSERT(y = 0 y m_height);
-return *reinterpret_castconst uint32_t*((m_data[(y * m_width + x) * 4]));
+return *reinterpret_castconst unsigned int*((m_data[(y * m_width + x) * 4]));
}
-void setPixelAt(int x, int y, uint32_t color) const
+void setPixelAt(int x, int y, unsigned int color) const
{
ASSERT(x = 0 x m_width);
ASSERT(y = 0 y m_height);
void* addr = const_castunsigned char*(m_data.front())[(y * m_width + x) * 4];
-*reinterpret_castuint32_t*(addr) = color;
+*reinterpret_castunsigned int*(addr) = color;
}
private:
@@ -207,24 +206,24 @@
return static_castfloat(pixelsDifferent) / totalPixels * 100;
}
-inline uint32_t maxOf3(uint32_t a, uint32_t b, uint32_t c)
+inline unsigned int maxOf3(unsigned int a, unsigned int b, unsigned int c)
{
if (a b)
return std::max(b, c);
return std::max(a, c);
}
-inline uint32_t getRedComponent(uint32_t color)
+inline unsigned int getRedComponent(unsigned int color)
{
return (color 24) 24;
}
-inline uint32_t getGreenComponent(uint32_t color)
+inline unsigned int getGreenComponent(unsigned int color)
{
return (color 16) 24;
}
-inline uint32_t getBlueComponent(uint32_t color)
+inline unsigned int getBlueComponent(unsigned int color)
{
return (color 8) 24;
}
@@ -239,20 +238,20 @@
float weightedPixelsDifferent = 0;
for (int y = 0; y h; ++y) {
for (int x = 0; x w; ++x) {
-uint32_t actualColor = actual.pixelAt(x, y);
-uint32_t baselineColor = baseline.pixelAt(x, y);
+unsigned int actualColor = actual.pixelAt(x, y);
+unsigned int baselineColor = baseline.pixelAt(x, y);
if (baselineColor != actualColor) {
-uint32_t actualR = getRedComponent(actualColor);
-uint32_t actualG = getGreenComponent(actualColor);
-uint32_t actualB = getBlueComponent(actualColor);
-uint32_t baselineR = getRedComponent(baselineColor);
-uint32_t baselineG = getGreenComponent(baselineColor);
-uint32_t baselineB = getBlueComponent(baselineColor);
-uint32_t deltaR = std::max(actualR, baselineR)
+unsigned int actualR = getRedComponent(actualColor);
+unsigned int actualG = getGreenComponent(actualColor);
+unsigned int actualB = getBlueComponent(actualColor);
+unsigned int baselineR = getRedComponent(baselineColor);
+unsigned int baselineG = getGreenComponent(baselineColor);
+unsigned int baselineB =
[webkit-changes] [98027] trunk/Source
Title: [98027] trunk/Source Revision 98027 Author a...@apple.com Date 2011-10-20 15:25:23 -0700 (Thu, 20 Oct 2011) Log Message REGRESSION (r96823): Contextual menu closes immediately when control-clicking in Flash plug-in https://bugs.webkit.org/show_bug.cgi?id=70534 rdar://problem/10308827 Reviewed by Darin Adler. Source/WebCore: * plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): Return true for contextmenu event, so that plug-ins won't get a default WebKit context menu. We can't know if the plug-in is handling mousedown (or even mouseup) by displaying a menu. Source/WebKit/mac: * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Return true for contextmenu event, so that plug-ins won't get a default WebKit context menu. We can't know if the plug-in is handling mousedown (or even mouseup) by displaying a menu. Source/WebKit2: * WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::handleContextMenuEvent): * WebProcess/Plugins/Netscape/NetscapePlugin.h: * WebProcess/Plugins/Plugin.h: * WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::handleContextMenuEvent): * WebProcess/Plugins/PluginProxy.h: * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::handleEvent): Return true when handling contextmenu event, so that plug-ins won't get a default WebKit context menu. We can't know if the plug-in is handling mousedown (or even mouseup) by displaying a menu. * WebProcess/Plugins/PDF/BuiltInPDFView.h: * WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::handleContextMenuEvent): PDF is the only plug-in that wants default WebKit menu now. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/plugins/PluginView.cpp trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (98026 => 98027) --- trunk/Source/WebCore/ChangeLog 2011-10-20 22:24:07 UTC (rev 98026) +++ trunk/Source/WebCore/ChangeLog 2011-10-20 22:25:23 UTC (rev 98027) @@ -1,3 +1,15 @@ +2011-10-20 Alexey Proskuryakov a...@apple.com + +REGRESSION (r96823): Contextual menu closes immediately when control-clicking in Flash plug-in +https://bugs.webkit.org/show_bug.cgi?id=70534 +rdar://problem/10308827 + +Reviewed by Darin Adler. + +* plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): Return true for contextmenu +event, so that plug-ins won't get a default WebKit context menu. We can't know if the +plug-in is handling mousedown (or even mouseup) by displaying a menu. + 2011-10-17 Nat Duca nd...@chromium.org [chromium] Allow CCLayerTreeHostImpl to call back to proxy via CCLayerTreeHostImplClient Modified: trunk/Source/WebCore/plugins/PluginView.cpp (98026 => 98027) --- trunk/Source/WebCore/plugins/PluginView.cpp 2011-10-20 22:24:07 UTC (rev 98026) +++ trunk/Source/WebCore/plugins/PluginView.cpp 2011-10-20 22:25:23 UTC (rev 98027) @@ -170,6 +170,8 @@ handleMouseEvent(static_castMouseEvent*(event)); else if (event-isKeyboardEvent()) handleKeyboardEvent(static_castKeyboardEvent*(event)); +else if (event-type() == eventNames().contextmenuEvent) +event-setDefaultHandled(); // We don't know if the plug-in has handled mousedown event by displaying a context menu, so we never want WebKit to show a default one. #if defined(XP_UNIX) ENABLE(NETSCAPE_PLUGIN_API) else if (event-type() == eventNames().focusoutEvent) handleFocusOutEvent(); Modified: trunk/Source/WebKit/mac/ChangeLog (98026 => 98027) --- trunk/Source/WebKit/mac/ChangeLog 2011-10-20 22:24:07 UTC (rev 98026) +++ trunk/Source/WebKit/mac/ChangeLog 2011-10-20 22:25:23 UTC (rev 98027) @@ -1,3 +1,15 @@ +2011-10-20 Alexey Proskuryakov a...@apple.com + +REGRESSION (r96823): Contextual menu closes immediately when control-clicking in Flash plug-in +https://bugs.webkit.org/show_bug.cgi?id=70534 +rdar://problem/10308827 + +Reviewed by Darin Adler. + +* WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Return true +for contextmenu event, so that plug-ins won't get a default WebKit context menu. We can't +know if the plug-in is handling mousedown (or even mouseup) by displaying a menu. + 2011-10-19 Beth Dakin bda...@apple.com https://bugs.webkit.org/show_bug.cgi?id=70396 Modified:
[webkit-changes] [98028] branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp
Title: [98028] branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp
Revision 98028
Author gav...@chromium.org
Date 2011-10-20 15:32:19 -0700 (Thu, 20 Oct 2011)
Log Message
Revert manual workaround for chromium bug 75604
BUG=75604
Review URL: http://codereview.chromium.org/8361008/
Modified Paths
branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp
Diff
Modified: branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp (98027 => 98028)
--- branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp 2011-10-20 22:25:23 UTC (rev 98027)
+++ branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp 2011-10-20 22:32:19 UTC (rev 98028)
@@ -322,10 +322,6 @@
void ScriptElement::notifyFinished(CachedResource* o)
{
-// crbug.com/75604 causes double notification in some situations, disregarding the second notification
-// is a workaround.
-if (!m_cachedScript)
-return;
ASSERT(!m_willBeParserExecuted);
ASSERT_UNUSED(o, o == m_cachedScript);
if (m_willExecuteInOrder)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98029] trunk/Source/WebCore
Title: [98029] trunk/Source/WebCore
Revision 98029
Author commit-qu...@webkit.org
Date 2011-10-20 15:39:00 -0700 (Thu, 20 Oct 2011)
Log Message
Implement SSE denormal disabler for windows.
https://bugs.webkit.org/show_bug.cgi?id=70517
Patch by Raymond Toy r...@google.com on 2011-10-20
Reviewed by Kenneth Russell.
* platform/audio/DenormalDisabler.h:
(WebCore::DenormalDisabler::DenormalDisabler):
Add implementation for Windows.
(WebCore::DenormalDisabler::~DenormalDisabler):
Ditto.
(WebCore::DenormalDisabler::flushDenormalFloatToZero):
Unify Windows with mac/linux.
(WebCore::DenormalDisabler::getCSR):
Define only if we're not on Windows.
(WebCore::DenormalDisabler::setCSR):
Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/DenormalDisabler.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98028 => 98029)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 22:32:19 UTC (rev 98028)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 22:39:00 UTC (rev 98029)
@@ -1,3 +1,23 @@
+2011-10-20 Raymond Toy r...@google.com
+
+Implement SSE denormal disabler for windows.
+
+https://bugs.webkit.org/show_bug.cgi?id=70517
+
+Reviewed by Kenneth Russell.
+
+* platform/audio/DenormalDisabler.h:
+(WebCore::DenormalDisabler::DenormalDisabler):
+Add implementation for Windows.
+(WebCore::DenormalDisabler::~DenormalDisabler):
+Ditto.
+(WebCore::DenormalDisabler::flushDenormalFloatToZero):
+Unify Windows with mac/linux.
+(WebCore::DenormalDisabler::getCSR):
+Define only if we're not on Windows.
+(WebCore::DenormalDisabler::setCSR):
+Ditto.
+
2011-10-20 Alexey Proskuryakov a...@apple.com
REGRESSION (r96823): Contextual menu closes immediately when control-clicking in Flash plug-in
Modified: trunk/Source/WebCore/platform/audio/DenormalDisabler.h (98028 => 98029)
--- trunk/Source/WebCore/platform/audio/DenormalDisabler.h 2011-10-20 22:32:19 UTC (rev 98028)
+++ trunk/Source/WebCore/platform/audio/DenormalDisabler.h 2011-10-20 22:39:00 UTC (rev 98029)
@@ -31,26 +31,58 @@
// Deal with denormals. They can very seriously impact performance on x86.
+// Define HAVE_DENORMAL if we support flushing denormals to zero.
+#if OS(WINDOWS) COMPILER(MSVC)
+#define HAVE_DENORMAL
+#endif
+
#if defined(__GNUC__) (defined(__i386__) || defined(__x86_64__))
+#define HAVE_DENORMAL
+#endif
+
+#ifdef HAVE_DENORMAL
class DenormalDisabler {
public:
DenormalDisabler()
+: m_savedCSR(0)
{
+#if OS(WINDOWS) COMPILER(MSVC)
+// Save the current state, and set mode to flush denormals.
+//
+// http://stackoverflow.com/questions/637175/possible-bug-in-controlfp-s-may-not-restore-control-word-correctly
+_controlfp_s(m_savedCSR, 0, 0);
+unsigned int unused;
+_controlfp_s(unused, _DN_FLUSH, _MCW_DN);
+#else
m_savedCSR = getCSR();
setCSR(m_savedCSR | 0x8040);
+#endif
}
~DenormalDisabler()
{
+#if OS(WINDOWS) COMPILER(MSVC)
+unsigned int unused;
+_controlfp_s(unused, m_savedCSR, _MCW_DN);
+#else
setCSR(m_savedCSR);
+#endif
}
// This is a nop if we can flush denormals to zero in hardware.
static inline float flushDenormalFloatToZero(float f)
{
+#if OS(WINDOWS) COMPILER(MSVC) (!_M_IX86_FP)
+// For systems using x87 instead of sse, there's no hardware support
+// to flush denormals automatically. Hence, we need to flush
+// denormals to zero manually.
+return (fabs(f) FLT_MIN) ? 0.0f : f;
+#else
return f;
+#endif
}
private:
+#if defined(__GNUC__) (defined(__i386__) || defined(__x86_64__))
inline int getCSR()
{
int result;
@@ -64,25 +96,22 @@
asm volatile(ldmxcsr %0 : : m (temp));
}
-int m_savedCSR;
+#endif
+
+unsigned int m_savedCSR;
};
#else
-// FIXME: add implementations for other architectures and compilers such as Visual Studio.
+// FIXME: add implementations for other architectures and compilers
class DenormalDisabler {
public:
DenormalDisabler() { }
+// Assume the worst case that other architectures and compilers
+// need to flush denormals to zero manually.
static inline float flushDenormalFloatToZero(float f)
{
-#if OS(WINDOWS) COMPILER(MSVC) (!_M_IX86_FP)
-// For systems using x87 instead of sse, there's no hardware support
-// to flush denormals automatically. Hence, we need to flush
-// denormals to zero manually.
return (fabs(f) FLT_MIN) ? 0.0f : f;
-#else
-return f;
-#endif
}
};
@@ -90,4 +119,5 @@
} // WebCore
+#undef HAVE_DENORMAL
#endif // DenormalDisabler_h
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98030] trunk/Source/WebKit2
Title: [98030] trunk/Source/WebKit2
Revision 98030
Author je...@webkit.org
Date 2011-10-20 15:40:34 -0700 (Thu, 20 Oct 2011)
Log Message
[Qt][WK2] qweberror* should follow the new file and class naming rules
https://bugs.webkit.org/show_bug.cgi?id=70550
Reviewed by Noam Rosenthal.
Renaming qweberror* files and class to QtWebError*.
QWebErrorPrivate is now merged into QtWebError.
* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::loadDidFail):
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/qt/ClientImpl.cpp:
(dispatchLoadFailed):
* UIProcess/qt/QtTouchViewInterface.cpp:
(WebKit::QtTouchViewInterface::loadDidFail):
* UIProcess/qt/QtTouchViewInterface.h:
* UIProcess/qt/QtViewInterface.h:
* UIProcess/qt/QtWebError.cpp: Renamed from Source/WebKit2/UIProcess/qt/qweberror.cpp.
(QtWebError::QtWebError):
(QtWebError::type):
(QtWebError::errorCode):
(QtWebError::url):
* UIProcess/qt/QtWebError.h: Renamed from Source/WebKit2/UIProcess/qt/qweberror.h.
(QtWebError::errorCodeAsHttpStatusCode):
(QtWebError::errorCodeAsNetworkError):
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::loadDidFail):
* UIProcess/qt/QtWebPageProxy.h:
* UIProcess/qt/qweberror_p.h: Removed.
* WebKit2.pro:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h
trunk/Source/WebKit2/UIProcess/qt/ClientImpl.cpp
trunk/Source/WebKit2/UIProcess/qt/QtTouchViewInterface.cpp
trunk/Source/WebKit2/UIProcess/qt/QtTouchViewInterface.h
trunk/Source/WebKit2/UIProcess/qt/QtViewInterface.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h
trunk/Source/WebKit2/WebKit2.pro
Added Paths
trunk/Source/WebKit2/UIProcess/qt/QtWebError.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebError.h
Removed Paths
trunk/Source/WebKit2/UIProcess/qt/qweberror.cpp
trunk/Source/WebKit2/UIProcess/qt/qweberror.h
trunk/Source/WebKit2/UIProcess/qt/qweberror_p.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98029 => 98030)
--- trunk/Source/WebKit2/ChangeLog 2011-10-20 22:39:00 UTC (rev 98029)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-20 22:40:34 UTC (rev 98030)
@@ -1,3 +1,36 @@
+2011-10-20 Jesus Sanchez-Palencia jesus.palen...@openbossa.org
+
+[Qt][WK2] qweberror* should follow the new file and class naming rules
+https://bugs.webkit.org/show_bug.cgi?id=70550
+
+Reviewed by Noam Rosenthal.
+
+Renaming qweberror* files and class to QtWebError*.
+QWebErrorPrivate is now merged into QtWebError.
+
+* UIProcess/API/qt/qdesktopwebview.cpp:
+(QDesktopWebViewPrivate::loadDidFail):
+* UIProcess/API/qt/qdesktopwebview_p.h:
+* UIProcess/qt/ClientImpl.cpp:
+(dispatchLoadFailed):
+* UIProcess/qt/QtTouchViewInterface.cpp:
+(WebKit::QtTouchViewInterface::loadDidFail):
+* UIProcess/qt/QtTouchViewInterface.h:
+* UIProcess/qt/QtViewInterface.h:
+* UIProcess/qt/QtWebError.cpp: Renamed from Source/WebKit2/UIProcess/qt/qweberror.cpp.
+(QtWebError::QtWebError):
+(QtWebError::type):
+(QtWebError::errorCode):
+(QtWebError::url):
+* UIProcess/qt/QtWebError.h: Renamed from Source/WebKit2/UIProcess/qt/qweberror.h.
+(QtWebError::errorCodeAsHttpStatusCode):
+(QtWebError::errorCodeAsNetworkError):
+* UIProcess/qt/QtWebPageProxy.cpp:
+(QtWebPageProxy::loadDidFail):
+* UIProcess/qt/QtWebPageProxy.h:
+* UIProcess/qt/qweberror_p.h: Removed.
+* WebKit2.pro:
+
2011-10-20 Alexey Proskuryakov a...@apple.com
REGRESSION (r96823): Contextual menu closes immediately when control-clicking in Flash plug-in
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp (98029 => 98030)
--- trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp 2011-10-20 22:39:00 UTC (rev 98029)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp 2011-10-20 22:40:34 UTC (rev 98030)
@@ -21,9 +21,9 @@
#include config.h
#include qdesktopwebview.h
+#include QtWebError.h
#include UtilsQt.h
#include qdesktopwebview_p.h
-#include qweberror.h
#include QFileDialog
#include QGraphicsSceneEvent
#include QGraphicsSceneResizeEvent
@@ -160,7 +160,7 @@
emit q-loadSucceeded();
}
-void QDesktopWebViewPrivate::loadDidFail(const QWebError error)
+void QDesktopWebViewPrivate::loadDidFail(const QtWebError error)
{
emit q-loadFailed(static_castQDesktopWebView::ErrorType(error.type()), error.errorCode(), error.url());
}
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h (98029 => 98030)
--- trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h 2011-10-20 22:39:00 UTC (rev 98029)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h 2011-10-20 22:40:34 UTC (rev 98030)
@@ -74,7 +74,7 @@
virtual void loadDidBegin();
virtual void loadDidCommit();
virtual
[webkit-changes] [98031] trunk/LayoutTests
Title: [98031] trunk/LayoutTests
Revision 98031
Author rn...@webkit.org
Date 2011-10-20 15:48:13 -0700 (Thu, 20 Oct 2011)
Log Message
[nrwt] results.html should differentiate expected missing and unexpected missing
https://bugs.webkit.org/show_bug.cgi?id=70372
Reviewed by Ojan Vafai.
Fixed the bug by moving the code to set isExpected above where we find tests with missing results
in processGlobalStateFor, and replacing testList for the missing results table by failingTestsTable.
Also fixed a bug in updateTogglingImages that was erroneously replacing links to .png files by
links to -diffs.html that don't exist for tests with missing results.
* fast/harness/resources/results-test.js: Added a test.
* fast/harness/results-expected.txt: Rebaselined.
* fast/harness/results.html:
* platform/chromium/fast/harness/results-expected.txt: Rebaselined.
* platform/win/fast/harness/results-expected.txt: Rebaselined.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/harness/resources/results-test.js
trunk/LayoutTests/fast/harness/results-expected.txt
trunk/LayoutTests/fast/harness/results.html
trunk/LayoutTests/platform/chromium/fast/harness/results-expected.txt
trunk/LayoutTests/platform/win/fast/harness/results-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98030 => 98031)
--- trunk/LayoutTests/ChangeLog 2011-10-20 22:40:34 UTC (rev 98030)
+++ trunk/LayoutTests/ChangeLog 2011-10-20 22:48:13 UTC (rev 98031)
@@ -1,3 +1,22 @@
+2011-10-19 Ryosuke Niwa rn...@webkit.org
+
+[nrwt] results.html should differentiate expected missing and unexpected missing
+https://bugs.webkit.org/show_bug.cgi?id=70372
+
+Reviewed by Ojan Vafai.
+
+Fixed the bug by moving the code to set isExpected above where we find tests with missing results
+in processGlobalStateFor, and replacing testList for the missing results table by failingTestsTable.
+
+Also fixed a bug in updateTogglingImages that was erroneously replacing links to .png files by
+links to -diffs.html that don't exist for tests with missing results.
+
+* fast/harness/resources/results-test.js: Added a test.
+* fast/harness/results-expected.txt: Rebaselined.
+* fast/harness/results.html:
+* platform/chromium/fast/harness/results-expected.txt: Rebaselined.
+* platform/win/fast/harness/results-expected.txt: Rebaselined.
+
2011-10-20 Tony Chang t...@chromium.org
fix repaint bugs in new flexbox
Modified: trunk/LayoutTests/fast/harness/resources/results-test.js (98030 => 98031)
--- trunk/LayoutTests/fast/harness/resources/results-test.js 2011-10-20 22:40:34 UTC (rev 98030)
+++ trunk/LayoutTests/fast/harness/resources/results-test.js 2011-10-20 22:48:13 UTC (rev 98031)
@@ -138,10 +138,10 @@
subtree['bar.html'].is_missing_image = true;
runTest(results, function() {
assertTrue(!document.getElementById('results-table'));
-assertTrue(document.querySelector('#new-tests-table .test-link').textContent == 'foo/bar.html');
-assertTrue(document.querySelector('#new-tests-table .result-link:nth-child(1)').textContent == 'audio result');
-assertTrue(document.querySelector('#new-tests-table .result-link:nth-child(2)').textContent == 'result');
-assertTrue(document.querySelector('#new-tests-table .result-link:nth-child(3)').textContent == 'images');
+assertTrue(document.querySelector('#missing-table .test-link').textContent == 'foo/bar.html');
+assertTrue(document.getElementsByClassName('result-link')[0].textContent == 'audio result');
+assertTrue(document.getElementsByClassName('result-link')[1].textContent == 'result');
+assertTrue(document.getElementsByClassName('result-link')[2].textContent == 'png result');
});
results = mockResults();
@@ -509,6 +509,28 @@
assertTrue(resultText.indexOf('crash.html') resultText.indexOf('flaky-fail.html'));
});
+results = mockResults();
+var subtree = results.tests['foo'] = {}
+subtree['expected-missing.html'] = mockExpectation('MISSING', 'MISSING');
+subtree['expected-missing.html'].is_missing_text = true;
+subtree['expected-missing.html'].is_missing_image = true;
+subtree['unexpected-missing.html'] = mockExpectation('PASS', 'MISSING');
+subtree['unexpected-missing.html'].is_missing_text = true;
+runTest(results, function() {
+assertTrue(!document.getElementById('results-table'));
+assertTrue(visibleExpandLinks().length == 1);
+assertTrue(document.querySelector('#missing-table tbody.expected .test-link').textContent == 'foo/expected-missing.html');
+assertTrue(document.querySelector('#missing-table tbody.expected').getElementsByClassName('result-link')[0].textContent == 'result');
+assertTrue(document.querySelector('#missing-table tbody.expected').getElementsByClassName('result-link')[1].textContent == 'png result');
+
[webkit-changes] [98032] trunk/LayoutTests
Title: [98032] trunk/LayoutTests
Revision 98032
Author simon.fra...@apple.com
Date 2011-10-20 15:52:45 -0700 (Thu, 20 Oct 2011)
Log Message
Fix two compositing iframes tests
https://bugs.webkit.org/show_bug.cgi?id=70543
Reviewed by Dean Jackson.
Remove incorrect WK2-specific result for invisible-nested-iframe-show.html.
The WK1 result for overlapped-iframe-iframe-expected.txt was also incorrect, because
the test didn not function correctly in WK1. It needs to use a setTimeout(0) to work
around an AppKit issue, and to display() so that painting triggers overflow detection.
* compositing/iframes/overlapped-iframe-iframe.html:
* platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt: Removed.
* platform/mac/compositing/iframes/overlapped-iframe-iframe-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/compositing/iframes/overlapped-iframe-iframe.html
Removed Paths
trunk/LayoutTests/platform/mac/compositing/iframes/overlapped-iframe-iframe-expected.txt
trunk/LayoutTests/platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98031 => 98032)
--- trunk/LayoutTests/ChangeLog 2011-10-20 22:48:13 UTC (rev 98031)
+++ trunk/LayoutTests/ChangeLog 2011-10-20 22:52:45 UTC (rev 98032)
@@ -1,3 +1,20 @@
+2011-10-20 Simon Fraser simon.fra...@apple.com
+
+Fix two compositing iframes tests
+https://bugs.webkit.org/show_bug.cgi?id=70543
+
+Reviewed by Dean Jackson.
+
+Remove incorrect WK2-specific result for invisible-nested-iframe-show.html.
+
+The WK1 result for overlapped-iframe-iframe-expected.txt was also incorrect, because
+the test didn not function correctly in WK1. It needs to use a setTimeout(0) to work
+around an AppKit issue, and to display() so that painting triggers overflow detection.
+
+* compositing/iframes/overlapped-iframe-iframe.html:
+* platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt: Removed.
+* platform/mac/compositing/iframes/overlapped-iframe-iframe-expected.txt: Removed.
+
2011-10-19 Ryosuke Niwa rn...@webkit.org
[nrwt] results.html should differentiate expected missing and unexpected missing
Modified: trunk/LayoutTests/compositing/iframes/overlapped-iframe-iframe.html (98031 => 98032)
--- trunk/LayoutTests/compositing/iframes/overlapped-iframe-iframe.html 2011-10-20 22:48:13 UTC (rev 98031)
+++ trunk/LayoutTests/compositing/iframes/overlapped-iframe-iframe.html 2011-10-20 22:52:45 UTC (rev 98032)
@@ -25,14 +25,21 @@
/style
script
if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
layoutTestController.dumpAsText();
}
function doTest()
{
-if (window.layoutTestController) {
-document.getElementById('layers').innerHTML = layoutTestController.layerTreeAsText();
-}
+// For some reason this delay is required for AppKit to not short-circuit the display which is required
+// for overlap testing to kick in.
+window.setTimeout(function() {
+if (window.layoutTestController) {
+layoutTestController.display();
+document.getElementById('layers').innerHTML = layoutTestController.layerTreeAsText();
+layoutTestController.notifyDone();
+}
+}, 0);
}
window.addEventListener('load', doTest, false);
Deleted: trunk/LayoutTests/platform/mac/compositing/iframes/overlapped-iframe-iframe-expected.txt (98031 => 98032)
--- trunk/LayoutTests/platform/mac/compositing/iframes/overlapped-iframe-iframe-expected.txt 2011-10-20 22:48:13 UTC (rev 98031)
+++ trunk/LayoutTests/platform/mac/compositing/iframes/overlapped-iframe-iframe-expected.txt 2011-10-20 22:52:45 UTC (rev 98032)
@@ -1 +0,0 @@
-
Deleted: trunk/LayoutTests/platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt (98031 => 98032)
--- trunk/LayoutTests/platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt 2011-10-20 22:48:13 UTC (rev 98031)
+++ trunk/LayoutTests/platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt 2011-10-20 22:52:45 UTC (rev 98032)
@@ -1,19 +0,0 @@
-
-(GraphicsLayer
- (bounds 800.00 600.00)
- (children 1
-(GraphicsLayer
- (position -12.00 -12.00)
- (bounds 812.00 612.00)
- (children 1
-(GraphicsLayer
- (position 30.00 214.00)
- (bounds 210.00 210.00)
- (drawsContent 1)
- (transform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [0.00 0.00 1.00 0.00] [0.00 0.00 1.00 1.00])
-)
- )
-)
- )
-)
-
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98033] trunk
Title: [98033] trunk Revision 98033 Author jchaffr...@webkit.org Date 2011-10-20 15:55:49 -0700 (Thu, 20 Oct 2011) Log Message RenderDeprecatedFlexibleBox does not call its children's layout method https://bugs.webkit.org/show_bug.cgi?id=64842 Reviewed by David Hyatt. Source/WebCore: Tests: fast/flexbox/021-vertical.html fast/flexbox/crash-flexbox-no-layout-child.html The FlexBoxIterator would skip any child with visibility: collapsed. However those child would need layout but their layout() function would never be called. This change refactors the way flexible box handles visibility: collapsed child and mark sure their layout() function is called but makes sure that they don't participate in the flex box dimensions. * rendering/RenderDeprecatedFlexibleBox.cpp: (WebCore::FlexBoxIterator::next): Do not skip visibility: collapsed child. (WebCore::childDoesNotAffectWidthOrFlexing): Helper function. (WebCore::RenderDeprecatedFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderDeprecatedFlexibleBox::calcVerticalPrefWidths): (WebCore::gatherFlexChildrenInfo): (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): (WebCore::RenderDeprecatedFlexibleBox::applyLineClamp): (WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex): Updated to skip the now seen visibility: collapsed child during the iteration. LayoutTests: Added a test covering the vertical change as the horizontal one is covered by 021.html. The test is failing currently as we don't properly support this case. * fast/flexbox/021-vertical-expected.png: Added. * fast/flexbox/021-vertical-expected.txt: Added. * fast/flexbox/021-vertical.html: Added. * fast/flexbox/crash-flexbox-no-layout-child-expected.txt: Added. * fast/flexbox/crash-flexbox-no-layout-child.html: Added. * platform/chromium-win/fast/flexbox/021-expected.txt: * platform/efl/fast/flexbox/021-expected.txt: * platform/gtk/fast/flexbox/021-expected.txt: * platform/mac/fast/flexbox/021-expected.txt: * platform/qt/fast/flexbox/021-expected.txt: Updated as we now layout out this flex-box. The image result should not change as it doesn't contribute to the visible flexbox layout. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-win/fast/flexbox/021-expected.txt trunk/LayoutTests/platform/efl/fast/flexbox/021-expected.txt trunk/LayoutTests/platform/gtk/fast/flexbox/021-expected.txt trunk/LayoutTests/platform/mac/fast/flexbox/021-expected.txt trunk/LayoutTests/platform/qt/fast/flexbox/021-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp Added Paths trunk/LayoutTests/fast/flexbox/021-vertical-expected.png trunk/LayoutTests/fast/flexbox/021-vertical-expected.txt trunk/LayoutTests/fast/flexbox/021-vertical.html trunk/LayoutTests/fast/flexbox/crash-flexbox-no-layout-child-expected.txt trunk/LayoutTests/fast/flexbox/crash-flexbox-no-layout-child.html Diff Modified: trunk/LayoutTests/ChangeLog (98032 => 98033) --- trunk/LayoutTests/ChangeLog 2011-10-20 22:52:45 UTC (rev 98032) +++ trunk/LayoutTests/ChangeLog 2011-10-20 22:55:49 UTC (rev 98033) @@ -1,3 +1,28 @@ +2011-10-20 Julien Chaffraix jchaffr...@webkit.org + +RenderDeprecatedFlexibleBox does not call its children's layout method +https://bugs.webkit.org/show_bug.cgi?id=64842 + +Reviewed by David Hyatt. + +Added a test covering the vertical change as the horizontal one is covered +by 021.html. The test is failing currently as we don't properly support this +case. + +* fast/flexbox/021-vertical-expected.png: Added. +* fast/flexbox/021-vertical-expected.txt: Added. +* fast/flexbox/021-vertical.html: Added. +* fast/flexbox/crash-flexbox-no-layout-child-expected.txt: Added. +* fast/flexbox/crash-flexbox-no-layout-child.html: Added. + +* platform/chromium-win/fast/flexbox/021-expected.txt: +* platform/efl/fast/flexbox/021-expected.txt: +* platform/gtk/fast/flexbox/021-expected.txt: +* platform/mac/fast/flexbox/021-expected.txt: +* platform/qt/fast/flexbox/021-expected.txt: +Updated as we now layout out this flex-box. The image result should not +change as it doesn't contribute to the visible flexbox layout. + 2011-10-20 Simon Fraser simon.fra...@apple.com Fix two compositing iframes tests Added: trunk/LayoutTests/fast/flexbox/021-vertical-expected.png (0 => 98033) --- trunk/LayoutTests/fast/flexbox/021-vertical-expected.png (rev 0) +++ trunk/LayoutTests/fast/flexbox/021-vertical-expected.png 2011-10-20 22:55:49 UTC (rev 98033) @@ -0,0 +1,5 @@ +\x89PNG + + +IHDR X ' )tEXtchecksum c0fee90186c7c7a1304dce56aa9b46bc\xDB]`\x93 +\xC6IDATx\x9C\xED\xDC1\xC20EA\x8C88\x9C|\xD3R$\xC5\x96\xA2\x99\xD6\xCD/\x9F\xB6\xF0\x9A\x99 \x9D\xE7\xEE w#\xB0 b \xB0 b
[webkit-changes] [98034] trunk/Tools
Title: [98034] trunk/Tools
Revision 98034
Author e...@webkit.org
Date 2011-10-20 16:17:42 -0700 (Thu, 20 Oct 2011)
Log Message
REGRESSION(97879): Pixel tests no longer work with NRWT on Mac
https://bugs.webkit.org/show_bug.cgi?id=70492
Reviewed by Adam Barth.
The bug turned out to be that I was assuming the block.content
would be empty before the binary content following Content-Length
was read inside _read_block. Turns out its not, due to extra newlines
and ExpectedHash header.
In the process of trying to figure out what was going wrong I ended up
cleaning up our newline usage in DumpRenderTree a little. Moved
two error messages from stdout to stderr, and fixed a little code indent/whitespace.
I also fixed ServerProcess to use deadline everywhere instead of timeout
per Adam's request in the original bug.
* DumpRenderTree/PixelDumpSupport.cpp:
(dumpWebViewAsPixelsAndCompareWithExpected):
* DumpRenderTree/cg/ImageDiffCG.cpp:
(main):
* DumpRenderTree/mac/DumpRenderTree.mm:
(dump):
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(restoreMainDisplayColorProfile):
(setupMainDisplayColorProfile):
* Scripts/webkitpy/layout_tests/port/server_process.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/PixelDumpSupport.cpp
trunk/Tools/DumpRenderTree/cg/ImageDiffCG.cpp
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
trunk/Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm
trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (98033 => 98034)
--- trunk/Tools/ChangeLog 2011-10-20 22:55:49 UTC (rev 98033)
+++ trunk/Tools/ChangeLog 2011-10-20 23:17:42 UTC (rev 98034)
@@ -1,3 +1,35 @@
+2011-10-20 Eric Seidel e...@webkit.org
+
+REGRESSION(97879): Pixel tests no longer work with NRWT on Mac
+https://bugs.webkit.org/show_bug.cgi?id=70492
+
+Reviewed by Adam Barth.
+
+The bug turned out to be that I was assuming the block.content
+would be empty before the binary content following Content-Length
+was read inside _read_block. Turns out its not, due to extra newlines
+and ExpectedHash header.
+
+In the process of trying to figure out what was going wrong I ended up
+cleaning up our newline usage in DumpRenderTree a little. Moved
+two error messages from stdout to stderr, and fixed a little code indent/whitespace.
+
+I also fixed ServerProcess to use deadline everywhere instead of timeout
+per Adam's request in the original bug.
+
+* DumpRenderTree/PixelDumpSupport.cpp:
+(dumpWebViewAsPixelsAndCompareWithExpected):
+* DumpRenderTree/cg/ImageDiffCG.cpp:
+(main):
+* DumpRenderTree/mac/DumpRenderTree.mm:
+(dump):
+* DumpRenderTree/mac/PixelDumpSupportMac.mm:
+(restoreMainDisplayColorProfile):
+(setupMainDisplayColorProfile):
+* Scripts/webkitpy/layout_tests/port/server_process.py:
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
+
2011-10-20 Tony Chang t...@chromium.org
[chromium] Remove stdint.h from ImageDiff and use
Modified: trunk/Tools/DumpRenderTree/PixelDumpSupport.cpp (98033 => 98034)
--- trunk/Tools/DumpRenderTree/PixelDumpSupport.cpp 2011-10-20 22:55:49 UTC (rev 98033)
+++ trunk/Tools/DumpRenderTree/PixelDumpSupport.cpp 2011-10-20 23:17:42 UTC (rev 98034)
@@ -57,21 +57,21 @@
// Compute the hash of the bitmap context pixels
char actualHash[33];
computeMD5HashStringForBitmapContext(context.get(), actualHash);
-printf(\nActualHash: %s\n, actualHash);
-
+printf(\nActualHash: %s\n, actualHash); // FIXME: No need for the leading newline.
+
// Check the computed hash against the expected one and dump image on mismatch
bool dumpImage = true;
if (expectedHash.length() 0) {
ASSERT(expectedHash.length() == 32);
+
+printf(\nExpectedHash: %s\n, expectedHash.c_str()); // FIXME: No need for the leading newline.
-printf(\nExpectedHash: %s\n, expectedHash.c_str());
-
-if (expectedHash == actualHash) // FIXME: do case insensitive compare
+if (expectedHash == actualHash) // FIXME: do case insensitive compare
dumpImage = false;
}
-
+
if (dumpImage)
- dumpBitmap(context.get(), actualHash);
+dumpBitmap(context.get(), actualHash);
}
static void appendIntToVector(unsigned number, Vectorunsigned char vector)
Modified: trunk/Tools/DumpRenderTree/cg/ImageDiffCG.cpp (98033 => 98034)
--- trunk/Tools/DumpRenderTree/cg/ImageDiffCG.cpp 2011-10-20 22:55:49 UTC (rev 98033)
+++ trunk/Tools/DumpRenderTree/cg/ImageDiffCG.cpp 2011-10-20
[webkit-changes] [98035] trunk/Source/WebKit/chromium
Title: [98035] trunk/Source/WebKit/chromium
Revision 98035
Author commit-qu...@webkit.org
Date 2011-10-20 16:19:55 -0700 (Thu, 20 Oct 2011)
Log Message
Export missing symbols from Web*Layer
https://bugs.webkit.org/show_bug.cgi?id=70440
Patch by Antoine Labour pi...@chromium.org on 2011-10-20
Reviewed by Darin Fisher.
* public/WebContentLayer.h:
* public/WebExternalTextureLayer.h:
* public/WebLayer.h:
* public/WebLayerTreeView.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebContentLayer.h
trunk/Source/WebKit/chromium/public/WebExternalTextureLayer.h
trunk/Source/WebKit/chromium/public/WebLayer.h
trunk/Source/WebKit/chromium/public/WebLayerTreeView.h
trunk/Source/WebKit/chromium/src/WebLayer.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (98034 => 98035)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-20 23:17:42 UTC (rev 98034)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-20 23:19:55 UTC (rev 98035)
@@ -1,3 +1,15 @@
+2011-10-20 Antoine Labour pi...@chromium.org
+
+Export missing symbols from Web*Layer
+https://bugs.webkit.org/show_bug.cgi?id=70440
+
+Reviewed by Darin Fisher.
+
+* public/WebContentLayer.h:
+* public/WebExternalTextureLayer.h:
+* public/WebLayer.h:
+* public/WebLayerTreeView.h:
+
2011-10-17 Nat Duca nd...@chromium.org
[chromium] Allow CCLayerTreeHostImpl to call back to proxy via CCLayerTreeHostImplClient
Modified: trunk/Source/WebKit/chromium/public/WebContentLayer.h (98034 => 98035)
--- trunk/Source/WebKit/chromium/public/WebContentLayer.h 2011-10-20 23:17:42 UTC (rev 98034)
+++ trunk/Source/WebKit/chromium/public/WebContentLayer.h 2011-10-20 23:19:55 UTC (rev 98035)
@@ -37,7 +37,7 @@
class WebContentLayer : public WebLayer {
public:
-static WebContentLayer create(WebLayerClient*, WebContentLayerClient*);
+WEBKIT_EXPORT static WebContentLayer create(WebLayerClient*, WebContentLayerClient*);
WebContentLayer() { }
WebContentLayer(const WebContentLayer layer) : WebLayer(layer) { }
Modified: trunk/Source/WebKit/chromium/public/WebExternalTextureLayer.h (98034 => 98035)
--- trunk/Source/WebKit/chromium/public/WebExternalTextureLayer.h 2011-10-20 23:17:42 UTC (rev 98034)
+++ trunk/Source/WebKit/chromium/public/WebExternalTextureLayer.h 2011-10-20 23:19:55 UTC (rev 98035)
@@ -41,7 +41,7 @@
// the WebLayerTreeView is destroyed.
class WebExternalTextureLayer : public WebLayer {
public:
-static WebExternalTextureLayer create(WebLayerClient*);
+WEBKIT_EXPORT static WebExternalTextureLayer create(WebLayerClient*);
WebExternalTextureLayer() { }
WebExternalTextureLayer(const WebExternalTextureLayer layer) : WebLayer(layer) { }
Modified: trunk/Source/WebKit/chromium/public/WebLayer.h (98034 => 98035)
--- trunk/Source/WebKit/chromium/public/WebLayer.h 2011-10-20 23:17:42 UTC (rev 98034)
+++ trunk/Source/WebKit/chromium/public/WebLayer.h 2011-10-20 23:19:55 UTC (rev 98035)
@@ -40,11 +40,11 @@
class WebLayer {
public:
-static WebLayer create(WebLayerClient*);
+WEBKIT_EXPORT static WebLayer create(WebLayerClient*);
WebLayer() { }
WebLayer(const WebLayer layer) { assign(layer); }
-virtual ~WebLayer();
+virtual ~WebLayer() { reset(); }
WebLayer operator=(const WebLayer layer)
{
assign(layer);
Modified: trunk/Source/WebKit/chromium/public/WebLayerTreeView.h (98034 => 98035)
--- trunk/Source/WebKit/chromium/public/WebLayerTreeView.h 2011-10-20 23:17:42 UTC (rev 98034)
+++ trunk/Source/WebKit/chromium/public/WebLayerTreeView.h 2011-10-20 23:19:55 UTC (rev 98035)
@@ -55,7 +55,7 @@
#endif
};
-static WebLayerTreeView create(WebLayerTreeViewClient*, const WebLayer root, const Settings);
+WEBKIT_EXPORT static WebLayerTreeView create(WebLayerTreeViewClient*, const WebLayer root, const Settings);
WebLayerTreeView() { }
WebLayerTreeView(const WebLayerTreeView layer) { assign(layer); }
Modified: trunk/Source/WebKit/chromium/src/WebLayer.cpp (98034 => 98035)
--- trunk/Source/WebKit/chromium/src/WebLayer.cpp 2011-10-20 23:17:42 UTC (rev 98034)
+++ trunk/Source/WebKit/chromium/src/WebLayer.cpp 2011-10-20 23:19:55 UTC (rev 98035)
@@ -79,11 +79,6 @@
return WebLayer(WebLayerImpl::create(client));
}
-WebLayer::~WebLayer()
-{
-reset();
-}
-
void WebLayer::reset()
{
m_private.reset();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98036] trunk/Source/WebKit/chromium
Title: [98036] trunk/Source/WebKit/chromium
Revision 98036
Author commit-qu...@webkit.org
Date 2011-10-20 16:23:13 -0700 (Thu, 20 Oct 2011)
Log Message
[chromium] Add a setVisibility method to WebGraphicsContext3D.
https://bugs.webkit.org/show_bug.cgi?id=68905
Patch by Michal Mocny mmo...@google.com on 2011-10-20
Reviewed by Kenneth Russell.
Added hooks for notifying WebGraphicsContext3D of surface visibility changes.
Useful for releasing various graphics resource.
* DEPS:
* public/WebGraphicsContext3D.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setVisibilityState):
* tests/MockWebGraphicsContext3D.h:
(WebKit::MockWebGraphicsContext3D::setVisibility):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/tests/MockWebGraphicsContext3D.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (98035 => 98036)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-20 23:19:55 UTC (rev 98035)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-20 23:23:13 UTC (rev 98036)
@@ -1,3 +1,20 @@
+2011-10-20 Michal Mocny mmo...@google.com
+
+[chromium] Add a setVisibility method to WebGraphicsContext3D.
+https://bugs.webkit.org/show_bug.cgi?id=68905
+
+Reviewed by Kenneth Russell.
+
+Added hooks for notifying WebGraphicsContext3D of surface visibility changes.
+Useful for releasing various graphics resource.
+
+* DEPS:
+* public/WebGraphicsContext3D.h:
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::setVisibilityState):
+* tests/MockWebGraphicsContext3D.h:
+(WebKit::MockWebGraphicsContext3D::setVisibility):
+
2011-10-20 Antoine Labour pi...@chromium.org
Export missing symbols from Web*Layer
Modified: trunk/Source/WebKit/chromium/DEPS (98035 => 98036)
--- trunk/Source/WebKit/chromium/DEPS 2011-10-20 23:19:55 UTC (rev 98035)
+++ trunk/Source/WebKit/chromium/DEPS 2011-10-20 23:23:13 UTC (rev 98036)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '105970'
+ 'chromium_rev': '106342'
}
deps = {
Modified: trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h (98035 => 98036)
--- trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h 2011-10-20 23:19:55 UTC (rev 98035)
+++ trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h 2011-10-20 23:23:13 UTC (rev 98036)
@@ -140,6 +140,9 @@
// Resizes the region into which this WebGraphicsContext3D is drawing.
virtual void reshape(int width, int height) = 0;
+// Changes the visibility of the region
+virtual void setVisibility(bool visible) = 0;
+
// Query whether it is built on top of compliant GLES2 implementation.
virtual bool isGLES2Compliant() = 0;
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (98035 => 98036)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-10-20 23:19:55 UTC (rev 98035)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-10-20 23:23:13 UTC (rev 98036)
@@ -2811,6 +2811,7 @@
if (!visible)
m_nonCompositedContentHost-protectVisibleTileTextures();
m_layerTreeHost-setVisible(visible);
+graphicsContext3D()-setVisibility(visible);
}
#endif
}
Modified: trunk/Source/WebKit/chromium/tests/MockWebGraphicsContext3D.h (98035 => 98036)
--- trunk/Source/WebKit/chromium/tests/MockWebGraphicsContext3D.h 2011-10-20 23:19:55 UTC (rev 98035)
+++ trunk/Source/WebKit/chromium/tests/MockWebGraphicsContext3D.h 2011-10-20 23:23:13 UTC (rev 98036)
@@ -43,6 +43,8 @@
virtual void reshape(int width, int height) { }
+virtual void setVisibility(bool visible) { }
+
virtual bool isGLES2Compliant() { return false; }
virtual bool readBackFramebuffer(unsigned char* pixels, size_t bufferSize, WebGLId framebuffer, int width, int height) { return false; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98037] branches/subpixellayout/
Title: [98037] branches/subpixellayout/ Revision 98037 Author e...@chromium.org Date 2011-10-20 16:30:54 -0700 (Thu, 20 Oct 2011) Log Message Create subpixel layout branch. Added Paths branches/subpixellayout/ Diff Property changes: branches/subpixellayout Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98039] trunk/Source
Title: [98039] trunk/Source Revision 98039 Author nd...@chromium.org Date 2011-10-20 16:36:29 -0700 (Thu, 20 Oct 2011) Log Message [chromium] Route onSwapBuffersComplete from LayerRenderer to CCScheduler. Reviewed by James Robinson. Source/WebCore: * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererSwapBuffersCompleteCallbackAdapter::create): (WebCore::LayerRendererSwapBuffersCompleteCallbackAdapter::~LayerRendererSwapBuffersCompleteCallbackAdapter): (WebCore::LayerRendererSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete): (WebCore::LayerRendererSwapBuffersCompleteCallbackAdapter::LayerRendererSwapBuffersCompleteCallbackAdapter): (WebCore::LayerRendererChromium::initialize): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::swapBuffers): (WebCore::LayerRendererChromium::onSwapBuffersComplete): * platform/graphics/chromium/LayerRendererChromium.h: * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::onSwapBuffers): * platform/graphics/chromium/cc/CCHeadsUpDisplay.h: * platform/graphics/chromium/cc/CCLayerTreeHost.h: (WebCore::LayerRendererCapabilities::LayerRendererCapabilities): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::swapBuffers): (WebCore::CCLayerTreeHostImpl::onSwapBuffersComplete): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: * platform/graphics/chromium/cc/CCScheduler.cpp: (WebCore::CCScheduler::requestRedraw): (WebCore::CCScheduler::didDrawAndSwap): (WebCore::CCScheduler::didSwapBuffersComplete): (WebCore::CCScheduler::didSwapBuffersAbort): * platform/graphics/chromium/cc/CCScheduler.h: * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: (WebCore::CCSingleThreadProxy::compositeImmediately): * platform/graphics/chromium/cc/CCSingleThreadProxy.h: (WebCore::CCSingleThreadProxy::onSwapBuffersCompleteOnImplThread): * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxySchedulerClient::scheduleDrawAndSwap): (WebCore::CCThreadProxy::drawLayersAndReadbackOnImplThread): (WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread): (WebCore::CCThreadProxy::finishAllRenderingOnImplThread): (WebCore::CCThreadProxy::drawLayersAndSwapOnImplThread): (WebCore::CCThreadProxy::drawLayersOnImplThread): * platform/graphics/chromium/cc/CCThreadProxy.h: Source/WebKit/chromium: * src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter): (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter): (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete): (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::create): (WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM): * src/GraphicsContext3DPrivate.h: * tests/CCLayerTreeHostImplTest.cpp: (WebCore::CCLayerTreeHostImplTest::onSwapBuffersCompleteOnImplThread): * tests/CCSchedulerTest.cpp: (WebCore::CCSchedulerTest::CCSchedulerTest): (WebCore::TEST_F): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCScheduler.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCScheduler.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp trunk/Source/WebKit/chromium/src/GraphicsContext3DPrivate.h trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp trunk/Source/WebKit/chromium/tests/CCSchedulerTest.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (98038 => 98039) --- trunk/Source/WebCore/ChangeLog 2011-10-20 23:34:13 UTC (rev 98038) +++ trunk/Source/WebCore/ChangeLog 2011-10-20 23:36:29 UTC (rev 98039) @@ -1,3 +1,47 @@ +2011-10-20 Nat Duca nd...@chromium.org + +[chromium] Route onSwapBuffersComplete from LayerRenderer to CCScheduler. + +Reviewed by James Robinson. + +* platform/graphics/chromium/LayerRendererChromium.cpp: +(WebCore::LayerRendererSwapBuffersCompleteCallbackAdapter::create): +
[webkit-changes] [98038] trunk/Source/WebKit/mac
Title: [98038] trunk/Source/WebKit/mac Revision 98038 Author commit-qu...@webkit.org Date 2011-10-20 16:34:13 -0700 (Thu, 20 Oct 2011) Log Message https://bugs.webkit.org/show_bug.cgi?id=70541 There are two WebFrameLoadDelegatePrivate categories on NSObject Patch by Ian Henderson i...@apple.com on 2011-10-20 Reviewed by David Kilzer. * WebView/WebViewPrivate.h: Rename the private delegate categories in WebViewPrivate.h with a WebView prefix to avoid collision. Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebViewPrivate.h Diff Modified: trunk/Source/WebKit/mac/ChangeLog (98037 => 98038) --- trunk/Source/WebKit/mac/ChangeLog 2011-10-20 23:30:54 UTC (rev 98037) +++ trunk/Source/WebKit/mac/ChangeLog 2011-10-20 23:34:13 UTC (rev 98038) @@ -1,3 +1,13 @@ +2011-10-20 Ian Henderson i...@apple.com + +https://bugs.webkit.org/show_bug.cgi?id=70541 +There are two WebFrameLoadDelegatePrivate categories on NSObject + +Reviewed by David Kilzer. + +* WebView/WebViewPrivate.h: Rename the private delegate categories in +WebViewPrivate.h with a WebView prefix to avoid collision. + 2011-10-20 Alexey Proskuryakov a...@apple.com REGRESSION (r96823): Contextual menu closes immediately when control-clicking in Flash plug-in Modified: trunk/Source/WebKit/mac/WebView/WebViewPrivate.h (98037 => 98038) --- trunk/Source/WebKit/mac/WebView/WebViewPrivate.h 2011-10-20 23:30:54 UTC (rev 98037) +++ trunk/Source/WebKit/mac/WebView/WebViewPrivate.h 2011-10-20 23:34:13 UTC (rev 98038) @@ -700,7 +700,7 @@ - (JSValueRef)_nodesFromRect:(JSContextRef)context forDocument:(JSValueRef)value x:(int)x y:(int)y top:(unsigned)top right:(unsigned)right bottom:(unsigned)bottom left:(unsigned)left ignoreClipping:(BOOL)ignoreClipping; @end -@interface NSObject (WebFrameLoadDelegatePrivate) +@interface NSObject (WebViewFrameLoadDelegatePrivate) - (void)webView:(WebView *)sender didFirstLayoutInFrame:(WebFrame *)frame; // didFinishDocumentLoadForFrame is sent when the document has finished loading, though not necessarily all @@ -718,7 +718,7 @@ @end -@interface NSObject (WebResourceLoadDelegatePrivate) +@interface NSObject (WebViewResourceLoadDelegatePrivate) // Addresses rdar://problem/5008925 - SPI for now - (NSCachedURLResponse *)webView:(WebView *)sender resource:(id)identifier willCacheResponse:(NSCachedURLResponse *)response fromDataSource:(WebDataSource *)dataSource; @end ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98040] trunk/Tools
Title: [98040] trunk/Tools Revision 98040 Author e...@webkit.org Date 2011-10-20 16:36:35 -0700 (Thu, 20 Oct 2011) Log Message Possible REGRESSION(97879): NRWT fails when DumpRenderTree crashes https://bugs.webkit.org/show_bug.cgi?id=70524 Reviewed by Adam Barth. This is a speculative fix, since I do not use a platform which outputs crashlogs over stderr. * Scripts/webkitpy/layout_tests/port/server_process.py: * Scripts/webkitpy/layout_tests/port/webkit.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py Diff Modified: trunk/Tools/ChangeLog (98039 => 98040) --- trunk/Tools/ChangeLog 2011-10-20 23:36:29 UTC (rev 98039) +++ trunk/Tools/ChangeLog 2011-10-20 23:36:35 UTC (rev 98040) @@ -1,5 +1,18 @@ 2011-10-20 Eric Seidel e...@webkit.org +Possible REGRESSION(97879): NRWT fails when DumpRenderTree crashes +https://bugs.webkit.org/show_bug.cgi?id=70524 + +Reviewed by Adam Barth. + +This is a speculative fix, since I do not use a platform +which outputs crashlogs over stderr. + +* Scripts/webkitpy/layout_tests/port/server_process.py: +* Scripts/webkitpy/layout_tests/port/webkit.py: + +2011-10-20 Eric Seidel e...@webkit.org + REGRESSION(97879): Pixel tests no longer work with NRWT on Mac https://bugs.webkit.org/show_bug.cgi?id=70492 Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py (98039 => 98040) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py 2011-10-20 23:36:29 UTC (rev 98039) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py 2011-10-20 23:36:35 UTC (rev 98040) @@ -142,6 +142,9 @@ return self._pop_error_bytes(index_after_newline) return None +def pop_all_buffered_stderr(self): +return self._pop_error_bytes(len(self._error)) + def read_stdout_line(self, deadline): return self._read(deadline, self._pop_stdout_line_if_ready) Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (98039 => 98040) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-10-20 23:36:29 UTC (rev 98039) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-10-20 23:36:35 UTC (rev 98040) @@ -532,8 +532,12 @@ text, audio = self._read_first_block(deadline) # First block is either text or audio image, actual_image_hash = self._read_optional_image_block(deadline) # The second (optional) block is image data. -# We may not have read all output (if an error occured), but we certainly should have read all error bytes. -assert not self._server_process._error, Unprocessed error output: %s % self._server_process._error +# We may not have read all of the output if an error (crash) occured. +# Since some platforms output the stacktrace over error, we should +# dump any buffered error into self.error_from_test. +# FIXME: We may need to also read stderr until the process dies? +self.error_from_test += self._server_process.pop_all_buffered_stderr() + return DriverOutput(text, image, actual_image_hash, audio, crash=self._detected_crash(), test_time=time.time() - start_time, timeout=self._server_process.timed_out, error=self.error_from_test, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98041] trunk/LayoutTests
Title: [98041] trunk/LayoutTests
Revision 98041
Author dpra...@chromium.org
Date 2011-10-20 16:45:16 -0700 (Thu, 20 Oct 2011)
Log Message
Unreviewed, expectations change.
* platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98040 => 98041)
--- trunk/LayoutTests/ChangeLog 2011-10-20 23:36:35 UTC (rev 98040)
+++ trunk/LayoutTests/ChangeLog 2011-10-20 23:45:16 UTC (rev 98041)
@@ -1,3 +1,10 @@
+2011-10-20 Dirk Pranke dpra...@chromium.org
+
+Unreviewed, expectations change.
+
+* platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.png: Added.
+* platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.txt: Added.
+
2011-10-20 Julien Chaffraix jchaffr...@webkit.org
RenderDeprecatedFlexibleBox does not call its children's layout method
Added: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.txt (0 => 98041)
--- trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.txt 2011-10-20 23:45:16 UTC (rev 98041)
@@ -0,0 +1,21 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x50
+layer at (8,8) size 100x150
+ RenderBlock {DIV} at (0,0) size 100x150 [bgcolor=#FF] [border: (50px solid #008000) none]
+RenderBlock {DIV} at (0,0) size 50x100 [bgcolor=#008000]
+RenderBlock {DIV} at (0,100) size 50x100 [bgcolor=#008000]
+layer at (8,158) size 100x150
+ RenderBlock {DIV} at (0,150) size 100x150 [bgcolor=#FF] [border: none (50px solid #008000) none]
+RenderBlock {DIV} at (0,0) size 50x100 [bgcolor=#008000]
+RenderBlock {DIV} at (0,100) size 50x100 [bgcolor=#008000]
+layer at (8,308) size 150x100
+ RenderBlock {DIV} at (0,300) size 150x100 [bgcolor=#FF] [border: none (50px solid #008000)]
+RenderBlock {DIV} at (0,0) size 100x50 [bgcolor=#008000]
+RenderBlock {DIV} at (100,0) size 100x50 [bgcolor=#008000]
+layer at (8,408) size 150x100
+ RenderBlock {DIV} at (0,400) size 150x100 [bgcolor=#FF] [border: none (50px solid #008000) none]
+RenderBlock {DIV} at (0,0) size 100x50 [bgcolor=#008000]
+RenderBlock {DIV} at (100,0) size 100x50 [bgcolor=#008000]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98043] branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp
Title: [98043] branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp
Revision 98043
Author gav...@chromium.org
Date 2011-10-20 16:58:54 -0700 (Thu, 20 Oct 2011)
Log Message
Reland manual workaround for chromium bug 75604
BUG=75604
Review URL: http://codereview.chromium.org/8361008/
Modified Paths
branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp
Diff
Modified: branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp (98042 => 98043)
--- branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp 2011-10-20 23:56:51 UTC (rev 98042)
+++ branches/chromium/874/Source/WebCore/dom/ScriptElement.cpp 2011-10-20 23:58:54 UTC (rev 98043)
@@ -322,6 +322,10 @@
void ScriptElement::notifyFinished(CachedResource* o)
{
+// crbug.com/75604 causes double notification in some situations, disregarding the second notification
+// is a workaround.
+if (!m_cachedScript)
+return;
ASSERT(!m_willBeParserExecuted);
ASSERT_UNUSED(o, o == m_cachedScript);
if (m_willExecuteInOrder)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98046] trunk/LayoutTests
Title: [98046] trunk/LayoutTests Revision 98046 Author z...@google.com Date 2011-10-20 17:20:06 -0700 (Thu, 20 Oct 2011) Log Message 2011-10-20 Zhenyao Mo z...@google.com Unreviewed, test expectations update for GPU bots. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98045 => 98046) --- trunk/LayoutTests/ChangeLog 2011-10-21 00:16:28 UTC (rev 98045) +++ trunk/LayoutTests/ChangeLog 2011-10-21 00:20:06 UTC (rev 98046) @@ -1,3 +1,9 @@ +2011-10-20 Zhenyao Mo z...@google.com + +Unreviewed, test expectations update for GPU bots. + +* platform/chromium/test_expectations.txt: + 2011-10-20 Tony Chang t...@chromium.org Update chromium-linux flexbox pixel results. My machine is running Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98045 => 98046) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-21 00:16:28 UTC (rev 98045) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-21 00:20:06 UTC (rev 98046) @@ -2603,6 +2603,8 @@ BUGWK47923 GPU GPU-CG : compositing/geometry/limit-layer-bounds-opacity-transition.html = TIMEOUT +BUGCR101112 WIN GPU : compositing/geometry/object-clip-rects-assertion.html = PASS CRASH + // Chromium does not support PDF content in img tags. WONTFIX GPU WIN LINUX : compositing/color-matching/pdf-image-match.html = IMAGE+TEXT WONTFIX MAC GPU-CG : compositing/color-matching/pdf-image-match.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98048] trunk/LayoutTests
Title: [98048] trunk/LayoutTests Revision 98048 Author rn...@webkit.org Date 2011-10-20 17:26:17 -0700 (Thu, 20 Oct 2011) Log Message Mac rebaseline after r97878. * platform/mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (98047 => 98048) --- trunk/LayoutTests/ChangeLog 2011-10-21 00:23:34 UTC (rev 98047) +++ trunk/LayoutTests/ChangeLog 2011-10-21 00:26:17 UTC (rev 98048) @@ -1,3 +1,9 @@ +2011-10-20 Ryosuke Niwa rn...@webkit.org + +Mac rebaseline after r97878. + +* platform/mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: + 2011-10-20 Zhenyao Mo z...@google.com Unreviewed, test expectations update for GPU bots. Modified: trunk/LayoutTests/platform/mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt (98047 => 98048) --- trunk/LayoutTests/platform/mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt 2011-10-21 00:23:34 UTC (rev 98047) +++ trunk/LayoutTests/platform/mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt 2011-10-21 00:26:17 UTC (rev 98048) @@ -1,5 +1,4 @@ EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 0 of DIV BODY HTML #document to 0 of DIV BODY HTML #document givenAction:WebViewInsertActionDropped EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV BODY HTML #document to 0 of DIV BODY HTML #document EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98049] trunk/Source/WebCore
Title: [98049] trunk/Source/WebCore Revision 98049 Author aba...@webkit.org Date 2011-10-20 17:27:47 -0700 (Thu, 20 Oct 2011) Log Message Attempt to fix the GTK build. * GNUmakefile.am: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.am Diff Modified: trunk/Source/WebCore/ChangeLog (98048 => 98049) --- trunk/Source/WebCore/ChangeLog 2011-10-21 00:26:17 UTC (rev 98048) +++ trunk/Source/WebCore/ChangeLog 2011-10-21 00:27:47 UTC (rev 98049) @@ -1,5 +1,11 @@ 2011-10-20 Adam Barth aba...@webkit.org +Attempt to fix the GTK build. + +* GNUmakefile.am: + +2011-10-20 Adam Barth aba...@webkit.org + CloseEvent.idl isn't conditional on WebSockets. * dom/EventFactory.in: Modified: trunk/Source/WebCore/GNUmakefile.am (98048 => 98049) --- trunk/Source/WebCore/GNUmakefile.am 2011-10-21 00:26:17 UTC (rev 98048) +++ trunk/Source/WebCore/GNUmakefile.am 2011-10-21 00:27:47 UTC (rev 98049) @@ -681,7 +681,7 @@ DerivedSources/WebCore/XMLNames.cpp DerivedSources/WebCore/XMLNames.h: $(WebCore)/dom/make_names.pl $(WebCore)/xml/xmlattrs.in $(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $ --attrs $(WebCore)/xml/xmlattrs.in --outputDir $(GENSOURCES_WEBCORE) -DerivedSources/WebCore/EventFactory.cpp: $(WebCore)/dom/make_event_factory.pl $(WebCore)/dom/EventFactory.in +DerivedSources/WebCore/EventFactory.cpp DerivedSources/WebCore/EventHeaders.h DerivedSources/WebCore/EventInterfaces.h: $(WebCore)/dom/make_event_factory.pl $(WebCore)/dom/EventFactory.in $(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $ --events $(WebCore)/dom/EventFactory.in --outputDir $(GENSOURCES_WEBCORE) # All Web Inspector generated files are created with this one call to CodeGeneratorInspector.pm ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98050] trunk/Source/WebCore
Title: [98050] trunk/Source/WebCore
Revision 98050
Author dpra...@chromium.org
Date 2011-10-20 17:33:26 -0700 (Thu, 20 Oct 2011)
Log Message
Still lots of crashes in the chromium debug bots.
Unreviewed, rolling out r97982.
http://trac.webkit.org/changeset/97982
https://bugs.webkit.org/show_bug.cgi?id=70328
crashing in asserts in chromium debug builds
* dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::timerFired):
(WebCore::DeviceMotionController::addListener):
(WebCore::DeviceMotionController::removeListener):
(WebCore::DeviceMotionController::removeAllListeners):
* dom/DeviceMotionController.h:
* dom/DeviceOrientationController.cpp:
* dom/DeviceOrientationController.h:
* dom/Document.cpp:
* dom/Document.h:
* dom/ScriptExecutionContext.h:
* page/GeolocationController.cpp:
* page/GeolocationController.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DeviceMotionController.cpp
trunk/Source/WebCore/dom/DeviceMotionController.h
trunk/Source/WebCore/dom/DeviceOrientationController.cpp
trunk/Source/WebCore/dom/DeviceOrientationController.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/ScriptExecutionContext.h
trunk/Source/WebCore/page/GeolocationController.cpp
trunk/Source/WebCore/page/GeolocationController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98049 => 98050)
--- trunk/Source/WebCore/ChangeLog 2011-10-21 00:27:47 UTC (rev 98049)
+++ trunk/Source/WebCore/ChangeLog 2011-10-21 00:33:26 UTC (rev 98050)
@@ -1,3 +1,27 @@
+2011-10-20 Dirk Pranke dpra...@chromium.org
+
+Still lots of crashes in the chromium debug bots.
+
+Unreviewed, rolling out r97982.
+http://trac.webkit.org/changeset/97982
+https://bugs.webkit.org/show_bug.cgi?id=70328
+
+crashing in asserts in chromium debug builds
+
+* dom/DeviceMotionController.cpp:
+(WebCore::DeviceMotionController::timerFired):
+(WebCore::DeviceMotionController::addListener):
+(WebCore::DeviceMotionController::removeListener):
+(WebCore::DeviceMotionController::removeAllListeners):
+* dom/DeviceMotionController.h:
+* dom/DeviceOrientationController.cpp:
+* dom/DeviceOrientationController.h:
+* dom/Document.cpp:
+* dom/Document.h:
+* dom/ScriptExecutionContext.h:
+* page/GeolocationController.cpp:
+* page/GeolocationController.h:
+
2011-10-20 Adam Barth aba...@webkit.org
Attempt to fix the GTK build.
Modified: trunk/Source/WebCore/dom/DeviceMotionController.cpp (98049 => 98050)
--- trunk/Source/WebCore/dom/DeviceMotionController.cpp 2011-10-21 00:27:47 UTC (rev 98049)
+++ trunk/Source/WebCore/dom/DeviceMotionController.cpp 2011-10-21 00:33:26 UTC (rev 98050)
@@ -48,10 +48,10 @@
void DeviceMotionController::timerFired(TimerDeviceMotionController* timer)
{
ASSERT_UNUSED(timer, timer == m_timer);
-ASSERT(m_client-currentDeviceMotion());
+ASSERT(!m_client || m_client-currentDeviceMotion());
m_timer.stop();
-RefPtrDeviceMotionData deviceMotionData = m_client-currentDeviceMotion();
+RefPtrDeviceMotionData deviceMotionData = m_client ? m_client-currentDeviceMotion() : DeviceMotionData::create();
RefPtrDeviceMotionEvent event = DeviceMotionEvent::create(eventNames().devicemotionEvent, deviceMotionData.get());
VectorRefPtrDOMWindow listenersVector;
@@ -63,9 +63,9 @@
void DeviceMotionController::addListener(DOMWindow* window)
{
-// If the client already has motion data,
+// If no client is present or the client already has motion data,
// immediately trigger an asynchronous response.
-if (m_client-currentDeviceMotion()) {
+if (!m_client || m_client-currentDeviceMotion()) {
m_newListeners.add(window);
if (!m_timer.isActive())
m_timer.startOneShot(0);
@@ -73,7 +73,7 @@
bool wasEmpty = m_listeners.isEmpty();
m_listeners.add(window);
-if (wasEmpty)
+if (wasEmpty m_client)
m_client-startUpdating();
}
@@ -81,7 +81,7 @@
{
m_listeners.remove(window);
m_newListeners.remove(window);
-if (m_listeners.isEmpty())
+if (m_listeners.isEmpty() m_client)
m_client-stopUpdating();
}
@@ -93,22 +93,10 @@
m_listeners.removeAll(window);
m_newListeners.remove(window);
-if (m_listeners.isEmpty())
+if (m_listeners.isEmpty() m_client)
m_client-stopUpdating();
}
-void DeviceMotionController::suspend()
-{
-if (!m_listeners.isEmpty())
-m_client-stopUpdating();
-}
-
-void DeviceMotionController::resume()
-{
-if (!m_listeners.isEmpty())
-m_client-startUpdating();
-}
-
void DeviceMotionController::didChangeDeviceMotion(DeviceMotionData* deviceMotionData)
{
RefPtrDeviceMotionEvent event = DeviceMotionEvent::create(eventNames().devicemotionEvent, deviceMotionData);
Modified:
[webkit-changes] [98051] branches
Title: [98051] branches Revision 98051 Author aba...@webkit.org Date 2011-10-20 17:36:39 -0700 (Thu, 20 Oct 2011) Log Message Archive audio branch. Added Paths branches/old/audio/ Removed Paths branches/audio/ Diff Property changes: branches/old/audio Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98052] trunk/Source/WebCore
Title: [98052] trunk/Source/WebCore Revision 98052 Author aba...@webkit.org Date 2011-10-20 17:49:58 -0700 (Thu, 20 Oct 2011) Log Message Attempt to fix crash for infinite recursion. * bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (98051 => 98052) --- trunk/Source/WebCore/ChangeLog 2011-10-21 00:36:39 UTC (rev 98051) +++ trunk/Source/WebCore/ChangeLog 2011-10-21 00:49:58 UTC (rev 98052) @@ -1,3 +1,10 @@ +2011-10-20 Adam Barth aba...@webkit.org + +Attempt to fix crash for infinite recursion. + +* bindings/v8/custom/V8EventCustom.cpp: +(WebCore::toV8): + 2011-10-20 Dirk Pranke dpra...@chromium.org Still lots of crashes in the chromium debug bots. Modified: trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp (98051 => 98052) --- trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp 2011-10-21 00:36:39 UTC (rev 98051) +++ trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp 2011-10-21 00:49:58 UTC (rev 98052) @@ -85,6 +85,9 @@ if (!event) return v8::Null(); +if (event-interfaceName() == eventNames().interfaceForEvent) +return V8Event::wrap(event); + typedef v8::Handlev8::Value (*ToV8Function)(Event*); typedef HashMapWTF::AtomicStringImpl*, ToV8Function FunctionMap; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98054] trunk/Source/WebCore
Title: [98054] trunk/Source/WebCore
Revision 98054
Author commit-qu...@webkit.org
Date 2011-10-20 19:08:52 -0700 (Thu, 20 Oct 2011)
Log Message
[Forms][File] Add tooltip to No file selected text
https://bugs.webkit.org/show_bug.cgi?id=70474
Patch by Yosifumi Inoue yo...@chromium.org on 2011-10-20
Reviewed by Kent Tamura.
No new tests. Existing tests cover all changes.
This patch provides tooltip for text portion of upload file control
tell users to know actual text of truncated text of file name and
No file selected text. Tooltip is always displayed even if user
select only one file for truncated displayed file name.
* html/FileInputType.cpp:
(WebCore::FileInputType::defaultToolTip): Implement default tooltip logic.
* html/FileInputType.h: declaration of new method defaultToolTip.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultToolTip): Impelement new method defaultToolTip.
* html/HTMLInputElement.h: declaration of new method defaultToolTip.
* html/InputType.cpp:
(WebCore::InputType::defaultToolTip): Implement default method of defaultToolTip method.
* html/InputType.h: declaration of new method defaultToolTip.
* page/Chrome.cpp:
(WebCore::Chrome::setToolTip): Use new method HTMLInputElement::defaultToolTip and move default tooltip logic to FileInputType::defaultToolTip method.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/FileInputType.cpp
trunk/Source/WebCore/html/FileInputType.h
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/html/InputType.cpp
trunk/Source/WebCore/html/InputType.h
trunk/Source/WebCore/page/Chrome.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98053 => 98054)
--- trunk/Source/WebCore/ChangeLog 2011-10-21 01:27:33 UTC (rev 98053)
+++ trunk/Source/WebCore/ChangeLog 2011-10-21 02:08:52 UTC (rev 98054)
@@ -1,3 +1,29 @@
+2011-10-20 Yosifumi Inoue yo...@chromium.org
+
+[Forms][File] Add tooltip to No file selected text
+https://bugs.webkit.org/show_bug.cgi?id=70474
+
+Reviewed by Kent Tamura.
+
+No new tests. Existing tests cover all changes.
+
+This patch provides tooltip for text portion of upload file control
+tell users to know actual text of truncated text of file name and
+No file selected text. Tooltip is always displayed even if user
+select only one file for truncated displayed file name.
+
+* html/FileInputType.cpp:
+(WebCore::FileInputType::defaultToolTip): Implement default tooltip logic.
+* html/FileInputType.h: declaration of new method defaultToolTip.
+* html/HTMLInputElement.cpp:
+(WebCore::HTMLInputElement::defaultToolTip): Impelement new method defaultToolTip.
+* html/HTMLInputElement.h: declaration of new method defaultToolTip.
+* html/InputType.cpp:
+(WebCore::InputType::defaultToolTip): Implement default method of defaultToolTip method.
+* html/InputType.h: declaration of new method defaultToolTip.
+* page/Chrome.cpp:
+(WebCore::Chrome::setToolTip): Use new method HTMLInputElement::defaultToolTip and move default tooltip logic to FileInputType::defaultToolTip method.
+
2011-10-20 Darin Adler da...@apple.com
Remove OptionElement (first half)
Modified: trunk/Source/WebCore/html/FileInputType.cpp (98053 => 98054)
--- trunk/Source/WebCore/html/FileInputType.cpp 2011-10-21 01:27:33 UTC (rev 98053)
+++ trunk/Source/WebCore/html/FileInputType.cpp 2011-10-21 02:08:52 UTC (rev 98054)
@@ -37,6 +37,7 @@
#include ScriptController.h
#include ShadowRoot.h
#include wtf/PassOwnPtr.h
+#include wtf/text/StringBuilder.h
#include wtf/text/WTFString.h
namespace WebCore {
@@ -368,4 +369,20 @@
return m_icon.get();
}
+String FileInputType::defaultToolTip() const
+{
+FileList* fileList = m_fileList.get();
+unsigned listSize = fileList-length();
+if (!listSize)
+return fileButtonNoFileSelectedLabel();
+
+StringBuilder names;
+for (size_t i = 0; i listSize; ++i) {
+names.append(fileList-item(i)-fileName());
+if (i != listSize - 1)
+names.append('\n');
+}
+return names.toString();
+}
+
} // namespace WebCore
Modified: trunk/Source/WebCore/html/FileInputType.h (98053 => 98054)
--- trunk/Source/WebCore/html/FileInputType.h 2011-10-21 01:27:33 UTC (rev 98053)
+++ trunk/Source/WebCore/html/FileInputType.h 2011-10-21 02:08:52 UTC (rev 98054)
@@ -65,6 +65,7 @@
virtual bool isFileUpload() const;
virtual void createShadowSubtree();
virtual void multipleAttributeChanged();
+virtual String defaultToolTip() const OVERRIDE;
// FileChooserClient implementation.
virtual void filesChosen(const VectorString);
Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (98053 => 98054)
--- trunk/Source/WebCore/html/HTMLInputElement.cpp 2011-10-21 01:27:33 UTC (rev 98053)
+++
[webkit-changes] [98056] trunk/LayoutTests
Title: [98056] trunk/LayoutTests Revision 98056 Author dpra...@chromium.org Date 2011-10-20 19:25:25 -0700 (Thu, 20 Oct 2011) Log Message Suppress inspector failures for the moment. https://bugs.webkit.org/show_bug.cgi?id=70573 Unreviewed, expectations change. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98055 => 98056) --- trunk/LayoutTests/ChangeLog 2011-10-21 02:24:06 UTC (rev 98055) +++ trunk/LayoutTests/ChangeLog 2011-10-21 02:25:25 UTC (rev 98056) @@ -1,3 +1,12 @@ +2011-10-20 Dirk Pranke dpra...@chromium.org + +Suppress inspector failures for the moment. +https://bugs.webkit.org/show_bug.cgi?id=70573 + +Unreviewed, expectations change. + +* platform/chromium/test_expectations.txt: + 2011-10-20 Ryosuke Niwa rn...@webkit.org Mac rebaseline after r97878. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98055 => 98056) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-21 02:24:06 UTC (rev 98055) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-21 02:25:25 UTC (rev 98056) @@ -3874,3 +3874,7 @@ BUGWK70383 LEOPARD CPU-CG : editing/pasteboard/4944770-1.html = IMAGE BUGWK70386 SNOWLEOPARD DEBUG : storage/domstorage/events/documentURI.html = PASS CRASH + +BUGWK70573 : inspector/debugger/linkifier.html = TEXT +BUGWK70573 : inspector/debugger/script-formatter.html = TEXT + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98057] trunk/Source/WebCore
Title: [98057] trunk/Source/WebCore Revision 98057 Author commit-qu...@webkit.org Date 2011-10-20 19:30:10 -0700 (Thu, 20 Oct 2011) Log Message Make WebCore depend on translator_glsl instead of translator_common https://bugs.webkit.org/show_bug.cgi?id=70548 Patch by Antoine Labour pi...@chromium.org on 2011-10-20 Reviewed by Kenneth Russell. This is a build-only fix. Tested by checking WebKit still compiles and link. * WebCore.gyp/WebCore.gyp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gyp/WebCore.gyp Diff Modified: trunk/Source/WebCore/ChangeLog (98056 => 98057) --- trunk/Source/WebCore/ChangeLog 2011-10-21 02:25:25 UTC (rev 98056) +++ trunk/Source/WebCore/ChangeLog 2011-10-21 02:30:10 UTC (rev 98057) @@ -1,3 +1,15 @@ +2011-10-20 Antoine Labour pi...@chromium.org + +Make WebCore depend on translator_glsl instead of translator_common +https://bugs.webkit.org/show_bug.cgi?id=70548 + +Reviewed by Kenneth Russell. + +This is a build-only fix. Tested by checking WebKit still compiles and +link. + +* WebCore.gyp/WebCore.gyp: + 2011-10-20 Dana Jansens dan...@chromium.org [Chromium] Fix opaque flag default and for ImageLayerChromium Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (98056 => 98057) --- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-10-21 02:25:25 UTC (rev 98056) +++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-10-21 02:30:10 UTC (rev 98057) @@ -1118,7 +1118,7 @@ '(chromium_src_dir)/third_party/npapi/npapi.gyp:npapi', '(chromium_src_dir)/third_party/ots/ots.gyp:ots', '(chromium_src_dir)/third_party/sqlite/sqlite.gyp:sqlite', -'(chromium_src_dir)/third_party/angle/src/build_angle.gyp:translator_common', +'(chromium_src_dir)/third_party/angle/src/build_angle.gyp:translator_glsl', '(chromium_src_dir)/v8/tools/gyp/v8.gyp:v8', '(libjpeg_gyp_path):libjpeg', ], @@ -1135,7 +1135,7 @@ '(chromium_src_dir)/third_party/npapi/npapi.gyp:npapi', '(chromium_src_dir)/third_party/ots/ots.gyp:ots', '(chromium_src_dir)/third_party/sqlite/sqlite.gyp:sqlite', -'(chromium_src_dir)/third_party/angle/src/build_angle.gyp:translator_common', +'(chromium_src_dir)/third_party/angle/src/build_angle.gyp:translator_glsl', '(chromium_src_dir)/v8/tools/gyp/v8.gyp:v8', '(libjpeg_gyp_path):libjpeg', ], ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98059] trunk/Source/WebKit/chromium
Title: [98059] trunk/Source/WebKit/chromium Revision 98059 Author fsam...@chromium.org Date 2011-10-20 19:37:01 -0700 (Thu, 20 Oct 2011) Log Message [Chromium] Fixed Layout API needs to check that a FrameView has been created to avoid segfaults https://bugs.webkit.org/show_bug.cgi?id=70519 Reviewed by Adam Barth. Simple patch. Upcoming patches for https://bugs.webkit.org/show_bug.cgi?id=70559 will make use of these methods in certain situations where the main frame doesn't yet have a FrameView. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::isFixedLayoutModeEnabled): (WebKit::WebViewImpl::enableFixedLayoutMode): (WebKit::WebViewImpl::fixedLayoutSize): (WebKit::WebViewImpl::setFixedLayoutSize): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebViewImpl.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (98058 => 98059) --- trunk/Source/WebKit/chromium/ChangeLog 2011-10-21 02:35:12 UTC (rev 98058) +++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-21 02:37:01 UTC (rev 98059) @@ -1,3 +1,19 @@ +2011-10-20 Fady Samuel fsam...@chromium.org + +[Chromium] Fixed Layout API needs to check that a FrameView has been created to avoid segfaults +https://bugs.webkit.org/show_bug.cgi?id=70519 + +Reviewed by Adam Barth. + +Simple patch. Upcoming patches for https://bugs.webkit.org/show_bug.cgi?id=70559 will make +use of these methods in certain situations where the main frame doesn't yet have a FrameView. + +* src/WebViewImpl.cpp: +(WebKit::WebViewImpl::isFixedLayoutModeEnabled): +(WebKit::WebViewImpl::enableFixedLayoutMode): +(WebKit::WebViewImpl::fixedLayoutSize): +(WebKit::WebViewImpl::setFixedLayoutSize): + 2011-10-20 Sheriff Bot webkit.review@gmail.com Unreviewed. Rolled DEPS. Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (98058 => 98059) --- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-10-21 02:35:12 UTC (rev 98058) +++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-10-21 02:37:01 UTC (rev 98059) @@ -1919,7 +1919,7 @@ return false; Frame* frame = page()-mainFrame(); -if (!frame) +if (!frame || !frame-view()) return false; return frame-view()-useFixedLayout(); @@ -1931,7 +1931,7 @@ return; Frame* frame = page()-mainFrame(); -if (!frame) +if (!frame || !frame-view()) return; frame-view()-setUseFixedLayout(enable); @@ -1943,7 +1943,7 @@ return WebSize(); Frame* frame = page()-mainFrame(); -if (!frame) +if (!frame || !frame-view()) return WebSize(); return frame-view()-fixedLayoutSize(); @@ -1955,7 +1955,7 @@ return; Frame* frame = page()-mainFrame(); -if (!frame) +if (!frame || !frame-view()) return; frame-view()-setFixedLayoutSize(layoutSize); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98058] trunk/Source/WebKit/chromium
Title: [98058] trunk/Source/WebKit/chromium
Revision 98058
Author commit-qu...@webkit.org
Date 2011-10-20 19:35:12 -0700 (Thu, 20 Oct 2011)
Log Message
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot webkit.review@gmail.com on 2011-10-20
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (98057 => 98058)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-21 02:30:10 UTC (rev 98057)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-21 02:35:12 UTC (rev 98058)
@@ -1,3 +1,9 @@
+2011-10-20 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2011-10-20 Darin Adler da...@apple.com
Remove OptionElement (first half)
Modified: trunk/Source/WebKit/chromium/DEPS (98057 => 98058)
--- trunk/Source/WebKit/chromium/DEPS 2011-10-21 02:30:10 UTC (rev 98057)
+++ trunk/Source/WebKit/chromium/DEPS 2011-10-21 02:35:12 UTC (rev 98058)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '106342'
+ 'chromium_rev': '106581'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98060] trunk
Title: [98060] trunk
Revision 98060
Author simon.fra...@apple.com
Date 2011-10-20 20:02:05 -0700 (Thu, 20 Oct 2011)
Log Message
Hidden composited iframes cause infinite loop
https://bugs.webkit.org/show_bug.cgi?id=52655
Source/WebCore:
Reviewed by Darin Adler.
visibility:hidden is problematic for compositing, because it causes
RenderLayers to be removed from the z-order layer tree. This confuses
RenderLayerCompositor in several ways; it never sees these layers
when traversing the tree as it computes compositing requirements, or
rebuilds the layer tree.
This is a particular problem with composited iframes. When an iframe
becomes composited, scheduleSetNeedsStyleRecalc() is called on that
iframe's ownerElement in the parent document. If this happens inside
Document::updateStyleForAllDocuments(), we get into an infinite loop
because notifyIFramesOfCompositingChange() queues up style update as we
bounce in and out of compositing mode, so documentsThatNeedStyleRecalc
never empties out.
This is an initial, conservative fix that doesn't attempt to fix all
the issues with visibility. It changes RenderLayerCompositor to count
the number of compositing RenderLayers, and to not leave compositing
mode if there are any (even if they are hidden, so not hit while
traversing the z-order tree). This avoids the infinite loop.
Test: compositing/visibility/hidden-iframe.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::ensureBacking):
(WebCore::RenderLayer::clearBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
* rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::layerBecameComposited):
(WebCore::RenderLayerCompositor::layerBecameNonComposited):
LayoutTests:
Reviewed by Darin Adler.
Test with a visibility:hidden iframe, whose subframe becomes composited.
* compositing/visibility/hidden-iframe-expected.txt: Added.
* compositing/visibility/hidden-iframe.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h
Added Paths
trunk/LayoutTests/compositing/visibility/
trunk/LayoutTests/compositing/visibility/hidden-iframe-expected.txt
trunk/LayoutTests/compositing/visibility/hidden-iframe.html
Diff
Modified: trunk/LayoutTests/ChangeLog (98059 => 98060)
--- trunk/LayoutTests/ChangeLog 2011-10-21 02:37:01 UTC (rev 98059)
+++ trunk/LayoutTests/ChangeLog 2011-10-21 03:02:05 UTC (rev 98060)
@@ -1,3 +1,15 @@
+2011-10-20 Simon Fraser simon.fra...@apple.com
+
+Hidden composited iframes cause infinite loop
+https://bugs.webkit.org/show_bug.cgi?id=52655
+
+Reviewed by Darin Adler.
+
+Test with a visibility:hidden iframe, whose subframe becomes composited.
+
+* compositing/visibility/hidden-iframe-expected.txt: Added.
+* compositing/visibility/hidden-iframe.html: Added.
+
2011-10-20 Dirk Pranke dpra...@chromium.org
Suppress inspector failures for the moment.
Added: trunk/LayoutTests/compositing/visibility/hidden-iframe-expected.txt (0 => 98060)
--- trunk/LayoutTests/compositing/visibility/hidden-iframe-expected.txt (rev 0)
+++ trunk/LayoutTests/compositing/visibility/hidden-iframe-expected.txt 2011-10-21 03:02:05 UTC (rev 98060)
@@ -0,0 +1,3 @@
+PASS: test did not hang.
+
+
Added: trunk/LayoutTests/compositing/visibility/hidden-iframe.html (0 => 98060)
--- trunk/LayoutTests/compositing/visibility/hidden-iframe.html (rev 0)
+++ trunk/LayoutTests/compositing/visibility/hidden-iframe.html 2011-10-21 03:02:05 UTC (rev 98060)
@@ -0,0 +1,31 @@
+html
+ head
+style
+ iframe {
+visibility: hidden;
+position: absolute;
+ }
+/style
+script
+ if (window.layoutTestController) {
+ layoutTestController.dumpAsText();
+ layoutTestController.waitUntilDone();
+ }
+
+ // Called from subframe.
+ function testDone()
+ {
+// This timeout is necessary to detect the hang.
+window.setTimeout(function() {
+ document.getElementById('results').innerText = 'PASS: test did not hang.';
+ if (window.layoutTestController)
+layoutTestController.notifyDone();
+}, 0);
+ }
+/script
+ /head
+ body
+p id=resultsThis test should not hang./p
+iframe src=""
+ /body
+/html
Modified: trunk/Source/WebCore/ChangeLog (98059 => 98060)
--- trunk/Source/WebCore/ChangeLog 2011-10-21 02:37:01 UTC (rev 98059)
+++ trunk/Source/WebCore/ChangeLog 2011-10-21 03:02:05 UTC (rev 98060)
@@ -1,3 +1,44 @@
+2011-10-20 Simon Fraser
[webkit-changes] [98061] trunk/Tools
Title: [98061] trunk/Tools
Revision 98061
Author tk...@chromium.org
Date 2011-10-20 20:29:25 -0700 (Thu, 20 Oct 2011)
Log Message
Unreviewed. Adding myself to watchlist.
* Scripts/webkitpy/common/config/watchlist:
Add ChromiumDumpRenderTree and Forms definitions, and cc them to me.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist
Diff
Modified: trunk/Tools/ChangeLog (98060 => 98061)
--- trunk/Tools/ChangeLog 2011-10-21 03:02:05 UTC (rev 98060)
+++ trunk/Tools/ChangeLog 2011-10-21 03:29:25 UTC (rev 98061)
@@ -1,3 +1,10 @@
+2011-10-20 Kent Tamura tk...@chromium.org
+
+Unreviewed. Adding myself to watchlist.
+
+* Scripts/webkitpy/common/config/watchlist:
+Add ChromiumDumpRenderTree and Forms definitions, and cc them to me.
+
2011-10-20 Nico Weber tha...@chromium.org
[chromium/mac] Add support for building with make
Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (98060 => 98061)
--- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2011-10-21 03:02:05 UTC (rev 98060)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2011-10-21 03:29:25 UTC (rev 98061)
@@ -12,12 +12,22 @@
#
{
DEFINITIONS: {
+ChromiumDumpRenderTree: {
+filename: rTools/DumpRenderTree/chromium/,
+},
ChromiumGraphics: {
filename: rSource/WebCore/platform/graphics/chromium/,
},
ChromiumPublicApi: {
filename: rSource/WebKit/chromium/public/
},
+Forms: {
+filename: rSource/WebCore/html/HTML(FieldSet|Form|FormControl|Input|Label
+r|OptGroup|Option|Select|TextArea|TextFormControl)Element\.
+r|Source/WebCore/html/\w*InputType\.
+r|Source/WebCore/rendering/Render(ListBox|MenuList|Slider|TextControl
+r|TextControlMultiLine|TextControlSingleLine)\.
+},
GStreamerGraphics: {
filename: rSource/WebCore/platform/graphics/gstreamer/,
},
@@ -73,8 +83,10 @@
# Note: All email addresses listed must be registered with bugzilla.
# Specifically, le...@chromium.org and levin+thread...@chromium.org are
# two different accounts as far as bugzilla is concerned.
+ChromiumDumpRenderTree: [ tk...@chromium.org, ],
ChromiumGraphics: [ jam...@chromium.org, ],
ChromiumPublicApi: [ fi...@chromium.org, ],
+Forms: [ tk...@chromium.org, ],
GStreamerGraphics: [ pnorm...@igalia.com, ],
WebIDL: [ aba...@webkit.org, o...@chromium.org ],
StyleChecker: [ le...@chromium.org, ],
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98062] trunk/Tools
Title: [98062] trunk/Tools Revision 98062 Author rn...@webkit.org Date 2011-10-20 20:35:50 -0700 (Thu, 20 Oct 2011) Log Message nrwt: newly generated results are put in cross-platform directory https://bugs.webkit.org/show_bug.cgi?id=68931 Reviewed by Dirk Pranke. The bug was caused by SingleTestRunner._add_missing_baselines's always calling _save_baseline_data with generate_new_baseline set to False. Fixed the bug by always passing True when .png file is missing (because png images are typically different on each platform), and passing True when .txt file is missing and the actual result's first line matches the regular _expression_ layer at \(\d+,\d+\) size \d+x\d+. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: * Scripts/webkitpy/layout_tests/port/test.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Changed the expectation and added a test case. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py Diff Modified: trunk/Tools/ChangeLog (98061 => 98062) --- trunk/Tools/ChangeLog 2011-10-21 03:29:25 UTC (rev 98061) +++ trunk/Tools/ChangeLog 2011-10-21 03:35:50 UTC (rev 98062) @@ -1,3 +1,20 @@ +2011-10-20 Ryosuke Niwa rn...@webkit.org + +nrwt: newly generated results are put in cross-platform directory +https://bugs.webkit.org/show_bug.cgi?id=68931 + +Reviewed by Dirk Pranke. + +The bug was caused by SingleTestRunner._add_missing_baselines's always calling _save_baseline_data +with generate_new_baseline set to False. Fixed the bug by always passing True when .png file is missing +(because png images are typically different on each platform), and passing True when .txt file is missing +and the actual result's first line matches the regular _expression_ layer at \(\d+,\d+\) size \d+x\d+. + +* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: +* Scripts/webkitpy/layout_tests/port/test.py: +* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Changed the expectation +and added a test case. + 2011-10-20 Kent Tamura tk...@chromium.org Unreviewed. Adding myself to watchlist. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (98061 => 98062) --- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2011-10-21 03:29:25 UTC (rev 98061) +++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2011-10-21 03:35:50 UTC (rev 98062) @@ -28,6 +28,7 @@ import logging +import re import time from webkitpy.layout_tests.layout_package import test_result_writer @@ -141,17 +142,16 @@ self._overwrite_baselines(driver_output) return TestResult(self._test_name, failures, driver_output.test_time, driver_output.has_stderr()) +_render_tree_dump_pattern = re.compile(r^layer at \(\d+,\d+\) size \d+x\d+\n) + def _add_missing_baselines(self, test_result, driver_output): +missingImage = test_result.has_failure_matching_types(test_failures.FailureMissingImage, test_failures.FailureMissingImageHash) if test_result.has_failure_matching_types(test_failures.FailureMissingResult): -# FIXME: We seem to be putting new text results in non-platform -# specific directories even when they're rendertree dumps. Maybe -# we should have a different kind of failure for render tree dumps -# than for text tests? -self._save_baseline_data(driver_output.text, .txt, generate_new_baseline=False) +self._save_baseline_data(driver_output.text, .txt, SingleTestRunner._render_tree_dump_pattern.match(driver_output.text)) if test_result.has_failure_matching_types(test_failures.FailureMissingAudio): self._save_baseline_data(driver_output.audio, .wav, generate_new_baseline=False) -if test_result.has_failure_matching_types(test_failures.FailureMissingImage, test_failures.FailureMissingImageHash): -self._save_baseline_data(driver_output.image, .png, generate_new_baseline=False) +if missingImage: +self._save_baseline_data(driver_output.image, .png, generate_new_baseline=True) def _overwrite_baselines(self, driver_output): # Although all DumpRenderTree output should be utf-8, @@ -182,8 +182,7 @@ relative_dir = fs.dirname(self._test_name) baseline_path = port.baseline_path() output_dir = fs.join(baseline_path, relative_dir) -output_file = fs.basename(fs.splitext(self._test_name)[0] + --expected + modifier) +output_file = fs.basename(fs.splitext(self._test_name)[0] + -expected + modifier)
[webkit-changes] [98063] trunk/Source/JavaScriptCore
Title: [98063] trunk/Source/_javascript_Core
Revision 98063
Author commit-qu...@webkit.org
Date 2011-10-20 21:01:28 -0700 (Thu, 20 Oct 2011)
Log Message
DFG JIT 32_64 - Fix ByteArray speculation
https://bugs.webkit.org/show_bug.cgi?id=70571
Patch by Yuqiang Xian yuqiang.x...@intel.com on 2011-10-20
Reviewed by Filip Pizlo.
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::forPrediction):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98062 => 98063)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-21 03:35:50 UTC (rev 98062)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-21 04:01:28 UTC (rev 98063)
@@ -1,3 +1,15 @@
+2011-10-20 Yuqiang Xian yuqiang.x...@intel.com
+
+DFG JIT 32_64 - Fix ByteArray speculation
+https://bugs.webkit.org/show_bug.cgi?id=70571
+
+Reviewed by Filip Pizlo.
+
+* dfg/DFGSpeculativeJIT.h:
+(JSC::DFG::ValueSource::forPrediction):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
2011-10-20 Vincent Scheib sch...@chromium.org
MouseLock compile and run time flags.
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h (98062 => 98063)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h 2011-10-21 03:35:50 UTC (rev 98062)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h 2011-10-21 04:01:28 UTC (rev 98063)
@@ -99,7 +99,7 @@
{
if (isInt32Prediction(prediction))
return ValueSource(Int32InRegisterFile);
-if (isArrayPrediction(prediction))
+if (isArrayPrediction(prediction) || isByteArrayPrediction(prediction))
return ValueSource(CellInRegisterFile);
return ValueSource(ValueInRegisterFile);
}
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (98062 => 98063)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2011-10-21 03:35:50 UTC (rev 98062)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2011-10-21 04:01:28 UTC (rev 98063)
@@ -696,13 +696,13 @@
break;
}
-if (isArrayPrediction(prediction)) {
+if (isArrayPrediction(prediction) || isByteArrayPrediction(prediction)) {
m_jit.load32(JITCompiler::payloadFor(node.local()), result.gpr());
// Like cellResult, but don't useChildren - our children are phi nodes,
// and don't represent values within this dataflow with virtual registers.
VirtualRegister virtualRegister = node.virtualRegister();
-m_gprs.retain(result.gpr(), virtualRegister, SpillOrderInteger);
+m_gprs.retain(result.gpr(), virtualRegister, SpillOrderCell);
m_generationInfo[virtualRegister].initCell(m_compileIndex, node.refCount(), result.gpr());
break;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98064] trunk/Tools
Title: [98064] trunk/Tools Revision 98064 Author yu...@chromium.org Date 2011-10-20 21:14:10 -0700 (Thu, 20 Oct 2011) Log Message WebSocket: Connecting to localhost:8880 takes one second on Windows https://bugs.webkit.org/show_bug.cgi?id=64788 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/servers/websocket_server.py: Bind to localhost instead of 127.0.0.1 to let pywebsocket listen on both IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html from timing out on Windows, because this test tries to open a lot of connections to localhost and each attempt takes one second to fall back from IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though). Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py Diff Modified: trunk/Tools/ChangeLog (98063 => 98064) --- trunk/Tools/ChangeLog 2011-10-21 04:01:28 UTC (rev 98063) +++ trunk/Tools/ChangeLog 2011-10-21 04:14:10 UTC (rev 98064) @@ -1,3 +1,17 @@ +2011-10-20 Yuta Kitamura yu...@chromium.org + +WebSocket: Connecting to localhost:8880 takes one second on Windows +https://bugs.webkit.org/show_bug.cgi?id=64788 + +Reviewed by Dirk Pranke. + +* Scripts/webkitpy/layout_tests/servers/websocket_server.py: +Bind to localhost instead of 127.0.0.1 to let pywebsocket listen on both +IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html +from timing out on Windows, because this test tries to open a lot of +connections to localhost and each attempt takes one second to fall back from +IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though). + 2011-10-20 Ryosuke Niwa rn...@webkit.org nrwt: newly generated results are put in cross-platform directory Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py (98063 => 98064) --- trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py 2011-10-21 04:01:28 UTC (rev 98063) +++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py 2011-10-21 04:14:10 UTC (rev 98064) @@ -117,7 +117,7 @@ pywebsocket_script = self._filesystem.join(pywebsocket_base, 'mod_pywebsocket', 'standalone.py') start_cmd = [ python_interp, '-u', pywebsocket_script, -'--server-host', '127.0.0.1', +'--server-host', 'localhost', '--port', str(self._port), # FIXME: Don't we have a self._port_obj.layout_test_path? '--document-root', self._filesystem.join(self._layout_tests, 'http', 'tests'), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98065] trunk/Source/JavaScriptCore
Title: [98065] trunk/Source/_javascript_Core
Revision 98065
Author fpi...@apple.com
Date 2011-10-20 22:14:06 -0700 (Thu, 20 Oct 2011)
Log Message
DFG call optimization handling will fail if the call had been unlinked due
to the callee being optimized
https://bugs.webkit.org/show_bug.cgi?id=70468
Reviewed by Geoff Garen.
If a call had ever been linked, we remember this fact as well as the function
to which it was linked even if unlinkIncomingCalls() or unlinkCalls() are
called.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeBlock.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkFor):
* jit/JIT.cpp:
(JSC::JIT::linkFor):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGRepatch.cpp
trunk/Source/_javascript_Core/jit/JIT.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98064 => 98065)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-21 04:14:10 UTC (rev 98064)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-21 05:14:06 UTC (rev 98065)
@@ -1,3 +1,25 @@
+2011-10-20 Filip Pizlo fpi...@apple.com
+
+DFG call optimization handling will fail if the call had been unlinked due
+to the callee being optimized
+https://bugs.webkit.org/show_bug.cgi?id=70468
+
+Reviewed by Geoff Garen.
+
+If a call had ever been linked, we remember this fact as well as the function
+to which it was linked even if unlinkIncomingCalls() or unlinkCalls() are
+called.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::visitAggregate):
+* bytecode/CodeBlock.h:
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::parseBlock):
+* dfg/DFGRepatch.cpp:
+(JSC::DFG::dfgLinkFor):
+* jit/JIT.cpp:
+(JSC::JIT::linkFor):
+
2011-10-20 Yuqiang Xian yuqiang.x...@intel.com
DFG JIT 32_64 - Fix ByteArray speculation
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (98064 => 98065)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2011-10-21 04:14:10 UTC (rev 98064)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2011-10-21 05:14:06 UTC (rev 98065)
@@ -1545,9 +1545,12 @@
for (size_t i = 0; i m_functionDecls.size(); ++i)
visitor.append(m_functionDecls[i]);
#if ENABLE(JIT)
-for (unsigned i = 0; i numberOfCallLinkInfos(); ++i)
+for (unsigned i = 0; i numberOfCallLinkInfos(); ++i) {
if (callLinkInfo(i).isLinked())
visitor.append(callLinkInfo(i).callee);
+if (!!callLinkInfo(i).lastSeenCallee)
+visitor.append(callLinkInfo(i).lastSeenCallee);
+}
#endif
#if ENABLE(INTERPRETER)
for (size_t size = m_propertyAccessInstructions.size(), i = 0; i size; ++i)
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (98064 => 98065)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2011-10-21 04:14:10 UTC (rev 98064)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2011-10-21 05:14:06 UTC (rev 98065)
@@ -121,6 +121,7 @@
CodeLocationDataLabelPtr hotPathBegin;
CodeLocationNearCall hotPathOther;
JITWriteBarrierJSFunction callee;
+WriteBarrierJSFunction lastSeenCallee;
bool hasSeenShouldRepatch : 1;
bool isCall : 1;
bool isDFG : 1;
Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (98064 => 98065)
--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2011-10-21 04:14:10 UTC (rev 98064)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2011-10-21 05:14:06 UTC (rev 98065)
@@ -1642,7 +1642,7 @@
if (m_graph.isFunctionConstant(m_codeBlock, callTarget))
callType = ConstantFunction;
-else if (m_inlineStackTop-m_profiledBlock-getCallLinkInfo(m_currentIndex).isLinked() !m_inlineStackTop-m_profiledBlock-likelyToTakeSlowCase(m_currentIndex))
+else if (!!m_inlineStackTop-m_profiledBlock-getCallLinkInfo(m_currentIndex).lastSeenCallee !m_profiledBlock-likelyToTakeSlowCase(m_currentIndex))
callType = LinkedFunction;
else
callType = UnknownFunction;
@@ -1667,7 +1667,7 @@
intrinsic = m_graph.valueOfFunctionConstant(m_codeBlock, callTarget)-executable()-intrinsic();
else {
ASSERT(callType == LinkedFunction);
-JSFunction* function = m_inlineStackTop-m_profiledBlock-getCallLinkInfo(m_currentIndex).callee.get();
+JSFunction* function = m_inlineStackTop-m_profiledBlock-getCallLinkInfo(m_currentIndex).lastSeenCallee.get();
intrinsic =
[webkit-changes] [98066] trunk/Source/WebCore
Title: [98066] trunk/Source/WebCore
Revision 98066
Author aba...@webkit.org
Date 2011-10-20 22:43:00 -0700 (Thu, 20 Oct 2011)
Log Message
Attemp to fix a bunch of tests PLATFORM(MAC). We can't use a static
map because that's shared between threads (and events exist in worker
threads). It migh be better to add a thread-specific map, but we can
do that in another patch.
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSEventCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98065 => 98066)
--- trunk/Source/WebCore/ChangeLog 2011-10-21 05:14:06 UTC (rev 98065)
+++ trunk/Source/WebCore/ChangeLog 2011-10-21 05:43:00 UTC (rev 98066)
@@ -1,3 +1,15 @@
+2011-10-20 Adam Barth aba...@webkit.org
+
+Attemp to fix a bunch of tests PLATFORM(MAC). We can't use a static
+map because that's shared between threads (and events exist in worker
+threads). It migh be better to add a thread-specific map, but we can
+do that in another patch.
+
+* bindings/js/JSEventCustom.cpp:
+(WebCore::toJS):
+* bindings/v8/custom/V8EventCustom.cpp:
+(WebCore::toV8):
+
2011-10-20 Simon Fraser simon.fra...@apple.com
Hidden composited iframes cause infinite loop
Modified: trunk/Source/WebCore/bindings/js/JSEventCustom.cpp (98065 => 98066)
--- trunk/Source/WebCore/bindings/js/JSEventCustom.cpp 2011-10-21 05:14:06 UTC (rev 98065)
+++ trunk/Source/WebCore/bindings/js/JSEventCustom.cpp 2011-10-21 05:43:00 UTC (rev 98066)
@@ -48,17 +48,10 @@
return impl()-isClipboardEvent() ? toJS(exec, globalObject(), impl()-clipboardData()) : jsUndefined();
}
-#define DECLARE_EVENT_WRAPPER(interfaceName) \
-static JSDOMWrapper* create##interfaceName##Wrapper(ExecState* exec, JSDOMGlobalObject* globalObject, Event* event) \
-{ \
-return CREATE_DOM_WRAPPER(exec, globalObject, interfaceName, event); \
-} \
+#define TRY_TO_WRAP_WITH_INTERFACE(interfaceName) \
+if (eventNames().interfaceFor##interfaceName == desiredInterface) \
+return CREATE_DOM_WRAPPER(exec, globalObject, interfaceName, event);
-DOM_EVENT_INTERFACES_FOR_EACH(DECLARE_EVENT_WRAPPER)
-
-#define ADD_WRAPPER_TO_MAP(interfaceName) \
-map.add(eventNames().interfaceFor##interfaceName.impl(), create##interfaceName##Wrapper);
-
JSValue toJS(ExecState* exec, JSDOMGlobalObject* globalObject, Event* event)
{
JSLock lock(SilenceAssertionsOnly);
@@ -70,18 +63,9 @@
if (wrapper)
return wrapper;
-typedef JSDOMWrapper* (*CreateEventWrapperFunction)(ExecState*, JSDOMGlobalObject*, Event*);
-typedef HashMapWTF::AtomicStringImpl*, CreateEventWrapperFunction FunctionMap;
+String desiredInterface = event-interfaceName();
+DOM_EVENT_INTERFACES_FOR_EACH(TRY_TO_WRAP_WITH_INTERFACE)
-DEFINE_STATIC_LOCAL(FunctionMap, map, ());
-if (map.isEmpty()) {
-DOM_EVENT_INTERFACES_FOR_EACH(ADD_WRAPPER_TO_MAP)
-}
-
-CreateEventWrapperFunction createWrapperFunction = map.get(event-interfaceName().impl());
-if (createWrapperFunction)
-return createWrapperFunction(exec, globalObject, event);
-
return CREATE_DOM_WRAPPER(exec, globalObject, Event, event);
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp (98065 => 98066)
--- trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp 2011-10-21 05:14:06 UTC (rev 98065)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp 2011-10-21 05:43:00 UTC (rev 98066)
@@ -69,37 +69,23 @@
return v8::Undefined();
}
-#define DECLARE_EVENT_WRAPPER(interfaceName) \
-static v8::Handlev8::Value toV8##interfaceName(Event* event) \
-{ \
-return toV8(static_castinterfaceName*(event)); \
-} \
+#define TRY_TO_WRAP_WITH_INTERFACE(interfaceName) \
+if (eventNames().interfaceFor##interfaceName == desiredInterface) \
+return toV8(static_castinterfaceName*(event));
-DOM_EVENT_INTERFACES_FOR_EACH(DECLARE_EVENT_WRAPPER)
-
-#define ADD_WRAPPER_TO_MAP(interfaceName) \
-map.add(eventNames().interfaceFor##interfaceName.impl(), toV8##interfaceName);
-
v8::Handlev8::Value toV8(Event* event)
{
if (!event)
return v8::Null();
-if (event-interfaceName() == eventNames().interfaceForEvent)
+String desiredInterface = event-interfaceName();
+
+// We need to check Event first to avoid infinite recursion.
+if (eventNames().interfaceForEvent == desiredInterface)
return V8Event::wrap(event);
-typedef v8::Handlev8::Value (*ToV8Function)(Event*);
-typedef HashMapWTF::AtomicStringImpl*, ToV8Function FunctionMap;
+DOM_EVENT_INTERFACES_FOR_EACH(TRY_TO_WRAP_WITH_INTERFACE)
-DEFINE_STATIC_LOCAL(FunctionMap, map, ());
-if (map.isEmpty()) {
-
[webkit-changes] [98068] trunk/Tools
Title: [98068] trunk/Tools Revision 98068 Author yu...@chromium.org Date 2011-10-20 22:48:54 -0700 (Thu, 20 Oct 2011) Log Message Unreviewed, rolling out r98064. http://trac.webkit.org/changeset/98064 https://bugs.webkit.org/show_bug.cgi?id=64788 Broke Mac bots. * Scripts/webkitpy/layout_tests/servers/websocket_server.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py Diff Modified: trunk/Tools/ChangeLog (98067 => 98068) --- trunk/Tools/ChangeLog 2011-10-21 05:47:53 UTC (rev 98067) +++ trunk/Tools/ChangeLog 2011-10-21 05:48:54 UTC (rev 98068) @@ -1,5 +1,15 @@ 2011-10-20 Yuta Kitamura yu...@chromium.org +Unreviewed, rolling out r98064. +http://trac.webkit.org/changeset/98064 +https://bugs.webkit.org/show_bug.cgi?id=64788 + +Broke Mac bots. + +* Scripts/webkitpy/layout_tests/servers/websocket_server.py: + +2011-10-20 Yuta Kitamura yu...@chromium.org + WebSocket: Connecting to localhost:8880 takes one second on Windows https://bugs.webkit.org/show_bug.cgi?id=64788 Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py (98067 => 98068) --- trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py 2011-10-21 05:47:53 UTC (rev 98067) +++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py 2011-10-21 05:48:54 UTC (rev 98068) @@ -117,7 +117,7 @@ pywebsocket_script = self._filesystem.join(pywebsocket_base, 'mod_pywebsocket', 'standalone.py') start_cmd = [ python_interp, '-u', pywebsocket_script, -'--server-host', 'localhost', +'--server-host', '127.0.0.1', '--port', str(self._port), # FIXME: Don't we have a self._port_obj.layout_test_path? '--document-root', self._filesystem.join(self._layout_tests, 'http', 'tests'), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98067] branches/chromium/912
Title: [98067] branches/chromium/912
Revision 98067
Author tk...@chromium.org
Date 2011-10-20 22:47:53 -0700 (Thu, 20 Oct 2011)
Log Message
Merge 97745 - REGRESSION(r97248): :visited as descendant selector broken
https://bugs.webkit.org/show_bug.cgi?id=70122
Source/WebCore:
Reviewed by Nikolas Zimmerman.
Make :visited foo and similar selectors work correctly again. They can affect
the visited style of an element inside a visited link.
Test: fast/selectors/visited-descendant.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyDeclarations):
Apply visited style to children of visited links too.
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
Don't disable visited matching until we run into first ancestor link or use combinator other than child/descendant.
(WebCore::SelectorChecker::determineLinkMatchType):
Look into child/descendant component selectors too to determine the link match type.
LayoutTests:
Reviewed by Nikolas Zimmerman.
* fast/selectors/visited-descendant.html: Added.
* platform/mac/fast/selectors/visited-descendant-expected.txt: Added.
TBR=tk...@chromium.org
BUG=crbug.com/101023
Review URL: http://codereview.chromium.org/8365028
Modified Paths
branches/chromium/912/Source/WebCore/css/CSSStyleSelector.cpp
branches/chromium/912/Source/WebCore/css/SelectorChecker.cpp
Added Paths
branches/chromium/912/LayoutTests/fast/selectors/visited-descendant.html
branches/chromium/912/LayoutTests/platform/mac/fast/selectors/visited-descendant-expected.txt
Diff
Copied: branches/chromium/912/LayoutTests/fast/selectors/visited-descendant.html (from rev 97745, trunk/LayoutTests/fast/selectors/visited-descendant.html) (0 => 98067)
--- branches/chromium/912/LayoutTests/fast/selectors/visited-descendant.html (rev 0)
+++ branches/chromium/912/LayoutTests/fast/selectors/visited-descendant.html 2011-10-21 05:47:53 UTC (rev 98067)
@@ -0,0 +1,55 @@
+html
+head
+style
+:visited { color: red }
+:visited #l1 { color: green }
+:visited #l2 { color: green }
+:visited span :visited { color: green }
+:link + #span1 { color: green }
+:visited + #span1 { color: red }
+:link ~ #span2 { color: green }
+:visited ~ #span2 { color: red }
+/style
+/head
+body
+p
+Test that visited style matches to the topmost link in a decendant selector.
+The link should be green, with red underlining.
+/p
+p
+a href="" id=l1Link/span/a
+/p
+p
+Test that visited style matches to the topmost link in a child selector.
+The link should be green, with red underlining.
+/p
+p
+a href="" id=l2Link/span/a
+/p
+p
+Test that visited style does not match to non-topmost links.
+The link should be red, with red underlining.
+/p
+p
+a href="" href="" id=l3Link/a/span/a
+/p
+p
+Test that direct adjacent selector doesn't match visited style.
+The link should be red, with red underlining.
+The span should be green.
+/p
+p
+a href=""
+span id=span1Span/span
+/p
+p
+Test that indirect adjacent selector doesn't match visited style.
+The link should be red, with red underlining.
+The span should be green.
+/p
+p
+a href=""
+span id=span2Span/span
+/p
+/body
+/html
Copied: branches/chromium/912/LayoutTests/platform/mac/fast/selectors/visited-descendant-expected.txt (from rev 97745, trunk/LayoutTests/platform/mac/fast/selectors/visited-descendant-expected.txt) (0 => 98067)
--- branches/chromium/912/LayoutTests/platform/mac/fast/selectors/visited-descendant-expected.txt (rev 0)
+++ branches/chromium/912/LayoutTests/platform/mac/fast/selectors/visited-descendant-expected.txt 2011-10-21 05:47:53 UTC (rev 98067)
@@ -0,0 +1,61 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x576
+ RenderBlock {P} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 760x18
+ text run at (0,0) width 760: Test that visited style matches to the topmost link in a decendant selector. The link should be green, with red underlining.
+ RenderBlock {P} at (0,34) size 784x18
+RenderInline {A} at (0,0) size 30x18 [color=#FF]
+ RenderInline {SPAN} at (0,0) size 30x18 [color=#008000]
+RenderText {#text} at (0,0) size 30x18
+ text run at (0,0) width 30: Link
+RenderText {#text} at (0,0) size 0x0
+ RenderBlock {P} at (0,68) size 784x18
+RenderText {#text} at (0,0) size 727x18
+ text run at (0,0) width 727: Test that visited style matches to the topmost link in a child selector. The link should be green, with red underlining.
+ RenderBlock {P} at (0,102) size 784x18
+RenderInline {A} at (0,0) size 30x18 [color=#FF]
+ RenderInline {SPAN} at (0,0) size 30x18 [color=#008000]
+RenderText {#text} at (0,0) size 30x18
+ text run at (0,0) width 30: Link
