[webkit-changes] [121322] trunk/Source/WebKit/chromium
Title: [121322] trunk/Source/WebKit/chromium
Revision 121322
Author commit-qu...@webkit.org
Date 2012-06-26 23:37:55 -0700 (Tue, 26 Jun 2012)
Log Message
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot on 2012-06-26
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (121321 => 121322)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-27 06:03:35 UTC (rev 121321)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-27 06:37:55 UTC (rev 121322)
@@ -1,3 +1,9 @@
+2012-06-26 Sheriff Bot
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-06-26 James Robinson
[chromium] Remove WebView::graphicsContext3D getter
Modified: trunk/Source/WebKit/chromium/DEPS (121321 => 121322)
--- trunk/Source/WebKit/chromium/DEPS 2012-06-27 06:03:35 UTC (rev 121321)
+++ trunk/Source/WebKit/chromium/DEPS 2012-06-27 06:37:55 UTC (rev 121322)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '144049'
+ 'chromium_rev': '144160'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121321] trunk/Source/WebCore
Title: [121321] trunk/Source/WebCore
Revision 121321
Author yo...@chromium.org
Date 2012-06-26 23:03:35 -0700 (Tue, 26 Jun 2012)
Log Message
[Platform] Change implementation of LocaleICU class to support more UDateFormat.
https://bugs.webkit.org/show_bug.cgi?id=89967
Reviewed by Kent Tamura.
This patch changes internal functions of LocaleICU class to process
multiple ICU date time format handles in addition to short date time
format handle.
This patch is a part of implementing input type time. I'll add time
format related ICU date time format handles.
No new tests. This patch doesn't change behavior.
* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::initializeShortDateFormat): Changed to use openDateFormat().
(WebCore::LocaleICU::openDateFormat): Added for common usage of udt_open().
(WebCore::getDateFormatPattern): Added for common usage of udt_toPattern().
(WebCore::localizeFormat): Changed to take String parameter.
(WebCore::LocaleICU::initializeLocalizedDateFormatText): Changed to use getDateFormatPattern.
(WebCore::LocaleICU::createLabelVector): Changed to take UDateFormat parameter.
(WebCore::LocaleICU::initializeCalendar): Changed for helper functions.
* platform/text/LocaleICU.h:
(LocaleICU):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/LocaleICU.cpp
trunk/Source/WebCore/platform/text/LocaleICU.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (121320 => 121321)
--- trunk/Source/WebCore/ChangeLog 2012-06-27 05:40:18 UTC (rev 121320)
+++ trunk/Source/WebCore/ChangeLog 2012-06-27 06:03:35 UTC (rev 121321)
@@ -1,3 +1,30 @@
+2012-06-26 Yoshifumi Inoue
+
+[Platform] Change implementation of LocaleICU class to support more UDateFormat.
+https://bugs.webkit.org/show_bug.cgi?id=89967
+
+Reviewed by Kent Tamura.
+
+This patch changes internal functions of LocaleICU class to process
+multiple ICU date time format handles in addition to short date time
+format handle.
+
+This patch is a part of implementing input type time. I'll add time
+format related ICU date time format handles.
+
+No new tests. This patch doesn't change behavior.
+
+* platform/text/LocaleICU.cpp:
+(WebCore::LocaleICU::initializeShortDateFormat): Changed to use openDateFormat().
+(WebCore::LocaleICU::openDateFormat): Added for common usage of udt_open().
+(WebCore::getDateFormatPattern): Added for common usage of udt_toPattern().
+(WebCore::localizeFormat): Changed to take String parameter.
+(WebCore::LocaleICU::initializeLocalizedDateFormatText): Changed to use getDateFormatPattern.
+(WebCore::LocaleICU::createLabelVector): Changed to take UDateFormat parameter.
+(WebCore::LocaleICU::initializeCalendar): Changed for helper functions.
+* platform/text/LocaleICU.h:
+(LocaleICU):
+
2012-06-26 Luke Macpherson
Return correct value for css variables enabled runtime flag.
Modified: trunk/Source/WebCore/platform/text/LocaleICU.cpp (121320 => 121321)
--- trunk/Source/WebCore/platform/text/LocaleICU.cpp 2012-06-27 05:40:18 UTC (rev 121320)
+++ trunk/Source/WebCore/platform/text/LocaleICU.cpp 2012-06-27 06:03:35 UTC (rev 121321)
@@ -272,13 +272,18 @@
{
if (m_didCreateShortDateFormat)
return m_shortDateFormat;
-const UChar gmtTimezone[3] = {'G', 'M', 'T'};
-UErrorCode status = U_ZERO_ERROR;
-m_shortDateFormat = udat_open(UDAT_NONE, UDAT_SHORT, m_locale.data(), gmtTimezone, WTF_ARRAY_LENGTH(gmtTimezone), 0, -1, &status);
+m_shortDateFormat = openDateFormat(UDAT_NONE, UDAT_SHORT);
m_didCreateShortDateFormat = true;
return m_shortDateFormat;
}
+UDateFormat* LocaleICU::openDateFormat(UDateFormatStyle timeStyle, UDateFormatStyle dateStyle) const
+{
+const UChar gmtTimezone[3] = {'G', 'M', 'T'};
+UErrorCode status = U_ZERO_ERROR;
+return udat_open(timeStyle, dateStyle, m_locale.data(), gmtTimezone, WTF_ARRAY_LENGTH(gmtTimezone), 0, -1, &status);
+}
+
double LocaleICU::parseLocalizedDate(const String& input)
{
if (!initializeShortDateFormat())
@@ -313,6 +318,23 @@
}
#if ENABLE(CALENDAR_PICKER)
+static String getDateFormatPattern(const UDateFormat* dateFormat)
+{
+if (!dateFormat)
+return emptyString();
+
+UErrorCode status = U_ZERO_ERROR;
+int32_t length = udat_toPattern(dateFormat, TRUE, 0, 0, &status);
+if (status != U_BUFFER_OVERFLOW_ERROR || !length)
+return emptyString();
+Vector buffer(length);
+status = U_ZERO_ERROR;
+udat_toPattern(dateFormat, TRUE, buffer.data(), length, &status);
+if (U_FAILURE(status))
+return emptyString();
+return String::adopt(buffer);
+}
+
static inline bool isICUYearSymbol(UChar letter)
{
return letter == 'y' || letter == 'Y';
@@ -330,12 +352,12 @@
// Specification of the input:
// http://icu-project.org/apiref/icu4c/classSimpleDateFormat.html#details
-static S
[webkit-changes] [121320] trunk/Source/WebCore
Title: [121320] trunk/Source/WebCore
Revision 121320
Author macpher...@chromium.org
Date 2012-06-26 22:40:18 -0700 (Tue, 26 Jun 2012)
Log Message
Return correct value for css variables enabled runtime flag.
https://bugs.webkit.org/show_bug.cgi?id=90040
Reviewed by Dimitri Glazkov.
Was always returning true for the runtime flag when the compile time flag was on. That was good for testing,
but not so much for production.
* page/Settings.h:
(WebCore::Settings::cssVariablesEnabled):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (121319 => 121320)
--- trunk/Source/WebCore/ChangeLog 2012-06-27 04:22:47 UTC (rev 121319)
+++ trunk/Source/WebCore/ChangeLog 2012-06-27 05:40:18 UTC (rev 121320)
@@ -1,3 +1,16 @@
+2012-06-26 Luke Macpherson
+
+Return correct value for css variables enabled runtime flag.
+https://bugs.webkit.org/show_bug.cgi?id=90040
+
+Reviewed by Dimitri Glazkov.
+
+Was always returning true for the runtime flag when the compile time flag was on. That was good for testing,
+but not so much for production.
+
+* page/Settings.h:
+(WebCore::Settings::cssVariablesEnabled):
+
2012-06-26 Xueqing Huang
DragData::asFilenames should not push same file names to result in Windows.
Modified: trunk/Source/WebCore/page/Settings.h (121319 => 121320)
--- trunk/Source/WebCore/page/Settings.h 2012-06-27 04:22:47 UTC (rev 121319)
+++ trunk/Source/WebCore/page/Settings.h 2012-06-27 05:40:18 UTC (rev 121320)
@@ -333,7 +333,7 @@
#if ENABLE(CSS_VARIABLES)
void setCSSVariablesEnabled(bool enabled) { m_cssVariablesEnabled = enabled; }
-bool cssVariablesEnabled() const { return true; }
+bool cssVariablesEnabled() const { return m_cssVariablesEnabled; }
#else
void setCSSVariablesEnabled(bool) { }
bool cssVariablesEnabled() const { return false; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121319] trunk
Title: [121319] trunk
Revision 121319
Author commit-qu...@webkit.org
Date 2012-06-26 21:22:47 -0700 (Tue, 26 Jun 2012)
Log Message
DragData::asFilenames should not push same file names to result in Windows.
https://bugs.webkit.org/show_bug.cgi?id=79861
Patch by Xueqing Huang on 2012-06-26
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: platform/win/fast/forms/file/drag-and-drop-files.html
* platform/win/DragDataWin.cpp:
(WebCore::DragData::asFilenames):
LayoutTests:
* platform/win/fast/forms/file/drag-and-drop-files-expected.txt: Added.
* platform/win/fast/forms/file/drag-and-drop-files.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/win/DragDataWin.cpp
Added Paths
trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files-expected.txt
trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files.html
Diff
Modified: trunk/LayoutTests/ChangeLog (121318 => 121319)
--- trunk/LayoutTests/ChangeLog 2012-06-27 04:03:04 UTC (rev 121318)
+++ trunk/LayoutTests/ChangeLog 2012-06-27 04:22:47 UTC (rev 121319)
@@ -1,3 +1,13 @@
+2012-06-26 Xueqing Huang
+
+DragData::asFilenames should not push same file names to result in Windows.
+https://bugs.webkit.org/show_bug.cgi?id=79861
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/win/fast/forms/file/drag-and-drop-files-expected.txt: Added.
+* platform/win/fast/forms/file/drag-and-drop-files.html: Added.
+
2012-06-26 Ryosuke Niwa
Rebaseline after r121286 and r121290.
Added: trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files-expected.txt (0 => 121319)
--- trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files-expected.txt 2012-06-27 04:22:47 UTC (rev 121319)
@@ -0,0 +1,12 @@
+Tests drag multi-files into , and check the files name were correct.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS fileInput.files[0].name is 'got-file-upload-0.html'
+PASS fileInput.files[1].name is 'got-file-upload-1.html'
+PASS fileInput.files[2].name is 'got-file-upload-2.html'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files.html (0 => 121319)
--- trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files.html (rev 0)
+++ trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files.html 2012-06-27 04:22:47 UTC (rev 121319)
@@ -0,0 +1,30 @@
+
+
+
+
+
+description("Tests drag multi-files into <input type='file'>, and check the files name were correct.");
+
+if (window.eventSender) {
+var inputElement = document.getElementById("fileInput");
+var fileRect = inputElement.getClientRects()[0];
+var targetX = fileRect.left + fileRect.width / 2;
+var targetY = fileRect.top + fileRect.height / 2;
+eventSender.beginDragWithFiles(['got-file-upload-0.html', 'got-file-upload-1.html', 'got-file-upload-2.html']);
+eventSender.mouseMoveTo(targetX, targetY);
+eventSender.mouseUp();
+}
+
+function displayFiles()
+{
+var input = document.getElementById("fileInput");
+shouldBe("fileInput.files[0].name", "'got-file-upload-0.html'");
+shouldBe("fileInput.files[1].name", "'got-file-upload-1.html'");
+shouldBe("fileInput.files[2].name", "'got-file-upload-2.html'");
+}
+
+
[webkit-changes] [121318] trunk/LayoutTests
Title: [121318] trunk/LayoutTests
Revision 121318
Author rn...@webkit.org
Date 2012-06-26 21:03:04 -0700 (Tue, 26 Jun 2012)
Log Message
Rebaseline after r121286 and r121290.
* editing/deleting/merge-into-empty-block-2-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/deleting/merge-into-empty-block-2-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (121317 => 121318)
--- trunk/LayoutTests/ChangeLog 2012-06-27 03:49:44 UTC (rev 121317)
+++ trunk/LayoutTests/ChangeLog 2012-06-27 04:03:04 UTC (rev 121318)
@@ -1,3 +1,9 @@
+2012-06-26 Ryosuke Niwa
+
+Rebaseline after r121286 and r121290.
+
+* editing/deleting/merge-into-empty-block-2-expected.txt:
+
2012-06-26 Keishi Hattori
[Chromium] Rebaseline fast/backgrounds/size/zero.html. Caused by r121296
Modified: trunk/LayoutTests/editing/deleting/merge-into-empty-block-2-expected.txt (121317 => 121318)
--- trunk/LayoutTests/editing/deleting/merge-into-empty-block-2-expected.txt 2012-06-27 03:49:44 UTC (rev 121317)
+++ trunk/LayoutTests/editing/deleting/merge-into-empty-block-2-expected.txt 2012-06-27 04:03:04 UTC (rev 121318)
@@ -4,20 +4,10 @@
EDITING DELEGATE: shouldDeleteDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of LI > UL > DIV > BODY > HTML > #document
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-CONSOLE MESSAGE: line 13: ReferenceError: Can't find variable: Markup
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x576
- RenderBlock {P} at (0,0) size 784x18
-RenderText {#text} at (0,0) size 731x18
- text run at (0,0) width 731: "When a user puts the caret at the very beginning a list and hits delete into an empty line, the list should just move up."
- RenderBlock {DIV} at (0,34) size 784x18
-RenderBlock {UL} at (0,0) size 784x18
- RenderListItem {LI} at (40,0) size 744x18
-RenderListMarker at (-17,0) size 7x18: bullet
-RenderInline {SPAN} at (0,0) size 21x18
- RenderText {#text} at (0,0) size 21x18
-text run at (0,0) width 21: "foo"
-caret: position 0 of child 0 {#text} of child 0 {SPAN} of child 0 {LI} of child 0 {UL} of child 2 {DIV} of body
+EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification
+When a user puts the caret at the very beginning a list and hits delete into an empty line, the list should just move up.
+|
+|
+|
+| id="test"
+| "<#selection-caret>foo"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121317] trunk/LayoutTests
Title: [121317] trunk/LayoutTests Revision 121317 Author kei...@webkit.org Date 2012-06-26 20:49:44 -0700 (Tue, 26 Jun 2012) Log Message [Chromium] Rebaseline fast/backgrounds/size/zero.html. Caused by r121296 Unreviewed. * platform/chromium-mac-snowleopard/fast/backgrounds/size/zero-expected.png: * platform/chromium-mac/fast/backgrounds/size/zero-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/size/zero-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/backgrounds/size/zero-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (121316 => 121317) --- trunk/LayoutTests/ChangeLog 2012-06-27 03:44:05 UTC (rev 121316) +++ trunk/LayoutTests/ChangeLog 2012-06-27 03:49:44 UTC (rev 121317) @@ -1,5 +1,14 @@ 2012-06-26 Keishi Hattori +[Chromium] Rebaseline fast/backgrounds/size/zero.html. Caused by r121296 + +Unreviewed. + +* platform/chromium-mac-snowleopard/fast/backgrounds/size/zero-expected.png: +* platform/chromium-mac/fast/backgrounds/size/zero-expected.png: + +2012-06-26 Keishi Hattori + [Chromium] Rebaseline 4 tests in editing/deleting. Caused by r121303. Unreviewed. Modified: trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/size/zero-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/backgrounds/size/zero-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121316] trunk/Source
Title: [121316] trunk/Source Revision 121316 Author gga...@apple.com Date 2012-06-26 20:44:05 -0700 (Tue, 26 Jun 2012) Log Message Reduced (but did not eliminate) use of "berzerker GC" https://bugs.webkit.org/show_bug.cgi?id=89237 Reviewed by Gavin Barraclough. (PART 2) ../_javascript_Core: This part turns off "berzerker GC" and turns on incremental shrinking. * heap/IncrementalSweeper.cpp: (JSC::IncrementalSweeper::doSweep): Free or shrink after sweeping to maintain the behavior we used to get from the occasional berzerker GC, which would run all finalizers and then free or shrink all blocks synchronously. * heap/MarkedBlock.h: (JSC::MarkedBlock::needsSweeping): Sweep zapped blocks, too. It's always safe to sweep a zapped block (that's the point of zapping), and it's sometimes profitable. For example, consider this case: Block A does some allocation (transitioning Block A from Marked to FreeListed), then GC happens (transitioning Block A to Zapped), then all objects in Block A are free, then the incremental sweeper visits Block A. If we skipped Zapped blocks, we'd skip Block A, even though it would be profitable to run its destructors and free its memory. * runtime/GCActivityCallback.cpp: (JSC::DefaultGCActivityCallback::doWork): Don't sweep eagerly; we'll do this incrementally. ../WebCore: Don't ASSERT that RootObject's destructor runs and invalidates all RuntimeObjects before their destructors run. We don't guarantee this behavior because some RuntimeObjects may already be garbage by the time RootObject's destructor runs, in which case RootObject's weak pointers will be NULL, and RootObject will not call invalidate() on them. It's been theoretically possible for this ASSERT to fire for a while now. This patch makes it fire all the time. Luckily, we only needed the behavior guarded by this ASSERT for WebKit1 in Safari on Windows (cf. https://bugs.webkit.org/show_bug.cgi?id=61317), to handle the way WebKit1 would unload plugin DLLs. If this ever becomes an issue again, we can fix it by (a) not unloading plugin DLLs, (b) migrating WebKit1 to the WebKit2 JS-plugin binding model, (c) making the Instance pointer in a RuntimeObject an indirect pointer through RootObject, or (c) giving RuntimeObject some sort of special way to access a zombie weak pointer. * bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::destroy): ASSERT removed. Anders said so. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/heap/IncrementalSweeper.cpp trunk/Source/_javascript_Core/heap/MarkedBlock.h trunk/Source/_javascript_Core/runtime/GCActivityCallback.cpp trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bridge/runtime_object.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (121315 => 121316) --- trunk/Source/_javascript_Core/ChangeLog 2012-06-27 03:30:32 UTC (rev 121315) +++ trunk/Source/_javascript_Core/ChangeLog 2012-06-27 03:44:05 UTC (rev 121316) @@ -1,3 +1,34 @@ +2012-06-26 Geoffrey Garen + +Reduced (but did not eliminate) use of "berzerker GC" +https://bugs.webkit.org/show_bug.cgi?id=89237 + +Reviewed by Gavin Barraclough. + +(PART 2) + +This part turns off "berzerker GC" and turns on incremental shrinking. + +* heap/IncrementalSweeper.cpp: +(JSC::IncrementalSweeper::doSweep): Free or shrink after sweeping to +maintain the behavior we used to get from the occasional berzerker GC, +which would run all finalizers and then free or shrink all blocks +synchronously. + +* heap/MarkedBlock.h: +(JSC::MarkedBlock::needsSweeping): Sweep zapped blocks, too. It's always +safe to sweep a zapped block (that's the point of zapping), and it's +sometimes profitable. For example, consider this case: Block A does some +allocation (transitioning Block A from Marked to FreeListed), then GC +happens (transitioning Block A to Zapped), then all objects in Block A +are free, then the incremental sweeper visits Block A. If we skipped +Zapped blocks, we'd skip Block A, even though it would be profitable to +run its destructors and free its memory. + +* runtime/GCActivityCallback.cpp: +(JSC::DefaultGCActivityCallback::doWork): Don't sweep eagerly; we'll do +this incrementally. + 2012-06-26 Filip Pizlo DFG PutByValAlias is too aggressive Modified: trunk/Source/_javascript_Core/heap/IncrementalSweeper.cpp (121315 => 121316) --- trunk/Source/_javascript_Core/heap/IncrementalSweeper.cpp 2012-06-27 03:30:32 UTC (rev 121315) +++ trunk/Source/_javascript_Core/heap/IncrementalSweeper.cpp 2012-06-27 03:44:05 UTC (rev 121316) @@ -78,6 +78,7 @@ continue; block->sweep(); +m_globalData->heap.objectSpace().freeOrShrinkBlock(block); CFTimeInterval elapsedTime = WTF::monotonicallyIncreasingTime() - sweepBeginTime; if (elapsedTime < sweepTi
[webkit-changes] [121314] trunk
Title: [121314] trunk
Revision 121314
Author commit-qu...@webkit.org
Date 2012-06-26 20:02:48 -0700 (Tue, 26 Jun 2012)
Log Message
REGRESSION(r107836): box shadow not drawn for opaque images with an opaque background
https://bugs.webkit.org/show_bug.cgi?id=89958
Patch by Douglas Stockwell on 2012-06-26
Reviewed by Simon Fraser.
Source/WebCore:
Don't attempt to draw the box shadow as part of the background if the background is
obscured.
Test: fast/box-shadow/image-box-shadow.html
* rendering/RenderImage.cpp:
(WebCore::RenderImage::boxShadowShouldBeAppliedToBackground):
(WebCore):
* rendering/RenderImage.h:
(RenderImage):
LayoutTests:
* fast/box-shadow/image-box-shadow-expected.html: Added.
* fast/box-shadow/image-box-shadow.html: Added.
* fast/box-shadow/resources/green-alpha.png: Added.
* fast/box-shadow/resources/green.jpg: Added.
* fast/box-shadow/resources/green.png: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderImage.cpp
trunk/Source/WebCore/rendering/RenderImage.h
Added Paths
trunk/LayoutTests/fast/box-shadow/image-box-shadow-expected.html
trunk/LayoutTests/fast/box-shadow/image-box-shadow.html
trunk/LayoutTests/fast/box-shadow/resources/green-alpha.png
trunk/LayoutTests/fast/box-shadow/resources/green.jpg
trunk/LayoutTests/fast/box-shadow/resources/green.png
Diff
Modified: trunk/LayoutTests/ChangeLog (121313 => 121314)
--- trunk/LayoutTests/ChangeLog 2012-06-27 02:20:21 UTC (rev 121313)
+++ trunk/LayoutTests/ChangeLog 2012-06-27 03:02:48 UTC (rev 121314)
@@ -1,3 +1,16 @@
+2012-06-26 Douglas Stockwell
+
+REGRESSION(r107836): box shadow not drawn for opaque images with an opaque background
+https://bugs.webkit.org/show_bug.cgi?id=89958
+
+Reviewed by Simon Fraser.
+
+* fast/box-shadow/image-box-shadow-expected.html: Added.
+* fast/box-shadow/image-box-shadow.html: Added.
+* fast/box-shadow/resources/green-alpha.png: Added.
+* fast/box-shadow/resources/green.jpg: Added.
+* fast/box-shadow/resources/green.png: Added.
+
2012-06-26 Kulanthaivel Palanichamy
Unexpected element sizes when mixing inline-table with box-sizing
Added: trunk/LayoutTests/fast/box-shadow/image-box-shadow-expected.html (0 => 121314)
--- trunk/LayoutTests/fast/box-shadow/image-box-shadow-expected.html (rev 0)
+++ trunk/LayoutTests/fast/box-shadow/image-box-shadow-expected.html 2012-06-27 03:02:48 UTC (rev 121314)
@@ -0,0 +1,16 @@
+
+
+img {
+width: 50px;
+height: 25px;
+margin-bottom: 25px;
+}
+div {
+display: inline-block;
+background: rgb(0,256,0);
+height: 50px;
+}
+
+
Added: trunk/LayoutTests/fast/box-shadow/image-box-shadow.html (0 => 121314)
--- trunk/LayoutTests/fast/box-shadow/image-box-shadow.html (rev 0)
+++ trunk/LayoutTests/fast/box-shadow/image-box-shadow.html 2012-06-27 03:02:48 UTC (rev 121314)
@@ -0,0 +1,18 @@
+
+
+img {
+background: rgb(0,256,0);
+width: 50px;
+height: 25px;
+margin-bottom: 25px;
+box-shadow: 0px 25px rgb(0,256,0);
+}
+div {
+display: inline-block;
+background: red;
+height: 50px;
+}
+
+
Added: trunk/LayoutTests/fast/box-shadow/resources/green-alpha.png (0 => 121314)
--- trunk/LayoutTests/fast/box-shadow/resources/green-alpha.png (rev 0)
+++ trunk/LayoutTests/fast/box-shadow/resources/green-alpha.png 2012-06-27 03:02:48 UTC (rev 121314)
@@ -0,0 +1,5 @@
+\x89PNG
+
+
+IHDR ĉ
+IDAT[cd\xF8\xCFP \x86\x80\xA2"`IEND\xAEB`\x82
\ No newline at end of file
Added: trunk/LayoutTests/fast/box-shadow/resources/green.jpg (0 => 121314)
--- trunk/LayoutTests/fast/box-shadow/resources/green.jpg (rev 0)
+++ trunk/LayoutTests/fast/box-shadow/resources/green.jpg 2012-06-27 03:02:48 UTC (rev 121314)
@@ -0,0 +1,12 @@
+\xFF\xD8\xFF\xE0 JFIF \xFF\xDB C
+
+
+
+
+
+
+ \xFF\xDB C \xFF\xC0 " \xFF\xC4
+ \xFF\xC4 \xB5 } !1AQa"q2\x81\x91\xA1#B\xB1\xC1R\xD1\xF0$3br\x82
+%&'()*456789:CDEFGHIJSTUVWXYZcdefghijstuvwxyz\x83\x84\x85\x86\x87\x88\x89\x8A\x92\x93\x94\x95\x96\x97\x98\x99\x9A\xA2\xA3\xA4\xA5\xA6\xA7\xA8\xA9\xAA\xB2\xB3\xB4\xB5\xB6\xB7\xB8\xB9\xBA\xC2\xC3\xC4\xC5\xC6\xC7\xC8\xC9\xCA\xD2\xD3\xD4\xD5\xD6\xD7\xD8\xD9\xDA\xE1\xE2\xE3\xE4\xE5\xE6\xE7\xE8\xE9\xEA\xF1\xF2\xF3\xF4\xF5\xF6\xF7\xF8\xF9\xFA\xFF\xC4
+ \xFF\xC4 \xB5 w !1AQaq"2\x81B\x91\xA1\xB1\xC1 #3R\xF0br\xD1
+$4\xE1%\xF1&'()*56789:CDEFGHIJSTUVWXYZcdefghijstuvwxyz\x82\x83\x84\x85\x86\x87\x88\x89\x8A\x92\x93\x94\x95\x96\x97\x98\x99\x9A\xA2\xA3\xA4\xA5\xA6\xA7\xA8\xA9\xAA\xB2\xB3\xB4\xB5\xB6\xB7\xB8\xB9\xBA\xC2\xC3\xC4\xC5\xC6\xC7\xC8\xC9\xC
[webkit-changes] [121313] trunk/Source/WebCore
Title: [121313] trunk/Source/WebCore Revision 121313 Author tha...@chromium.org Date 2012-06-26 19:20:21 -0700 (Tue, 26 Jun 2012) Log Message Fix new Wunused-private-field violations that crept in https://bugs.webkit.org/show_bug.cgi?id=90032 Reviewed by Adam Barth. * page/Performance.h: (Performance): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/Performance.h Diff Modified: trunk/Source/WebCore/ChangeLog (121312 => 121313) --- trunk/Source/WebCore/ChangeLog 2012-06-27 02:11:13 UTC (rev 121312) +++ trunk/Source/WebCore/ChangeLog 2012-06-27 02:20:21 UTC (rev 121313) @@ -1,3 +1,13 @@ +2012-06-26 Nico Weber + +Fix new Wunused-private-field violations that crept in +https://bugs.webkit.org/show_bug.cgi?id=90032 + +Reviewed by Adam Barth. + +* page/Performance.h: +(Performance): + 2012-06-26 Gyuyoung Kim Change return type in bandwidth attribute of network information API Modified: trunk/Source/WebCore/page/Performance.h (121312 => 121313) --- trunk/Source/WebCore/page/Performance.h 2012-06-27 02:11:13 UTC (rev 121312) +++ trunk/Source/WebCore/page/Performance.h 2012-06-27 02:20:21 UTC (rev 121313) @@ -90,7 +90,6 @@ virtual EventTargetData* ensureEventTargetData(); EventTargetData m_eventTargetData; -ScriptExecutionContext *m_scriptExecutionContext; mutable RefPtr m_navigation; mutable RefPtr m_timing; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121311] trunk
Title: [121311] trunk
Revision 121311
Author macpher...@chromium.org
Date 2012-06-26 18:57:13 -0700 (Tue, 26 Jun 2012)
Log Message
Be careful not to read past the end of input in CSSParser::lex() when looking for variable definitions.
https://bugs.webkit.org/show_bug.cgi?id=89949
Reviewed by Abhishek Arya.
Added repro case as fast/css/short-inline-style.html.
* css/CSSParser.cpp:
(WebCore::CSSParser::lex):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
Added Paths
trunk/LayoutTests/fast/css/short-inline-style-expected.txt
trunk/LayoutTests/fast/css/short-inline-style.html
Diff
Added: trunk/LayoutTests/fast/css/short-inline-style-expected.txt (0 => 121311)
--- trunk/LayoutTests/fast/css/short-inline-style-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/short-inline-style-expected.txt 2012-06-27 01:57:13 UTC (rev 121311)
@@ -0,0 +1 @@
+Test successful if it does not crash.
Added: trunk/LayoutTests/fast/css/short-inline-style.html (0 => 121311)
--- trunk/LayoutTests/fast/css/short-inline-style.html (rev 0)
+++ trunk/LayoutTests/fast/css/short-inline-style.html 2012-06-27 01:57:13 UTC (rev 121311)
@@ -0,0 +1,5 @@
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+Test successful if it does not crash.
Modified: trunk/Source/WebCore/ChangeLog (121310 => 121311)
--- trunk/Source/WebCore/ChangeLog 2012-06-27 01:49:20 UTC (rev 121310)
+++ trunk/Source/WebCore/ChangeLog 2012-06-27 01:57:13 UTC (rev 121311)
@@ -1,3 +1,15 @@
+2012-06-26 Luke Macpherson
+
+Be careful not to read past the end of input in CSSParser::lex() when looking for variable definitions.
+https://bugs.webkit.org/show_bug.cgi?id=89949
+
+Reviewed by Abhishek Arya.
+
+Added repro case as fast/css/short-inline-style.html.
+
+* css/CSSParser.cpp:
+(WebCore::CSSParser::lex):
+
2012-06-26 James Robinson
[chromium] Remove WebView::graphicsContext3D getter
Modified: trunk/Source/WebCore/css/CSSParser.cpp (121310 => 121311)
--- trunk/Source/WebCore/css/CSSParser.cpp 2012-06-27 01:49:20 UTC (rev 121310)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2012-06-27 01:57:13 UTC (rev 121311)
@@ -8972,7 +8972,7 @@
case CharacterDash:
#if ENABLE(CSS_VARIABLES)
-if (cssVariablesEnabled() && m_currentCharacter[10] == '-' && isEqualToCSSIdentifier(m_currentCharacter, "webkit-var") && isIdentifierStartAfterDash(m_currentCharacter + 11)) {
+if (cssVariablesEnabled() && isEqualToCSSIdentifier(m_currentCharacter, "webkit-var") && m_currentCharacter[10] == '-' && isIdentifierStartAfterDash(m_currentCharacter + 11)) {
// handle variable declarations
m_currentCharacter += 11;
parseIdentifier(result, hasEscape);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121310] trunk/Source
Title: [121310] trunk/Source Revision 121310 Author commit-qu...@webkit.org Date 2012-06-26 18:49:20 -0700 (Tue, 26 Jun 2012) Log Message [chromium] Remove WebView::graphicsContext3D getter https://bugs.webkit.org/show_bug.cgi?id=89916 Patch by James Robinson on 2012-06-26 Reviewed by Adrienne Walker. Source/Platform: Remove unused getter. * chromium/public/WebLayerTreeView.h: (WebLayerTreeView): Source/WebCore: Deletes code supporting compositor context getter. * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: * platform/graphics/chromium/cc/CCLayerTreeHost.h: (CCLayerTreeHost): * platform/graphics/chromium/cc/CCProxy.h: (CCProxy): * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: * platform/graphics/chromium/cc/CCSingleThreadProxy.h: (CCSingleThreadProxy): * platform/graphics/chromium/cc/CCThreadProxy.cpp: * platform/graphics/chromium/cc/CCThreadProxy.h: (CCThreadProxy): Source/WebKit/chromium: Removes WebView::graphicsContext3D getter. This getter was used to access the compositor's context, which is an inherently dangerous operation since the compositor context may not be safe to use on the main thread and has somewhat complicated creation / recreation semantics. A shared context is exposed (WebView::sharedGraphicsContext3D) for callers who may want access to a context in a share group with the compositor. * public/WebView.h: (WebView): * src/WebLayerTreeView.cpp: * src/WebViewImpl.cpp: * src/WebViewImpl.h: (WebViewImpl): Modified Paths trunk/Source/Platform/ChangeLog trunk/Source/Platform/chromium/public/WebLayerTreeView.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCProxy.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebView.h trunk/Source/WebKit/chromium/src/WebLayerTreeView.cpp trunk/Source/WebKit/chromium/src/WebViewImpl.cpp trunk/Source/WebKit/chromium/src/WebViewImpl.h Diff Modified: trunk/Source/Platform/ChangeLog (121309 => 121310) --- trunk/Source/Platform/ChangeLog 2012-06-27 01:41:06 UTC (rev 121309) +++ trunk/Source/Platform/ChangeLog 2012-06-27 01:49:20 UTC (rev 121310) @@ -1,3 +1,15 @@ +2012-06-26 James Robinson + +[chromium] Remove WebView::graphicsContext3D getter +https://bugs.webkit.org/show_bug.cgi?id=89916 + +Reviewed by Adrienne Walker. + +Remove unused getter. + +* chromium/public/WebLayerTreeView.h: +(WebLayerTreeView): + 2012-06-26 Dave Tu [chromium] Expose rendering statistics to WebWidget. Modified: trunk/Source/Platform/chromium/public/WebLayerTreeView.h (121309 => 121310) --- trunk/Source/Platform/chromium/public/WebLayerTreeView.h 2012-06-27 01:41:06 UTC (rev 121309) +++ trunk/Source/Platform/chromium/public/WebLayerTreeView.h 2012-06-27 01:49:20 UTC (rev 121310) @@ -167,11 +167,6 @@ // This can have a significant performance impact and should be used with care. WEBKIT_EXPORT void finishAllRendering(); -// Returns the context being used for rendering this view. In threaded compositing mode, it is -// not safe to use this context for anything on the main thread, other than passing the pointer to -// the compositor thread. -WEBKIT_EXPORT WebGraphicsContext3D* context(); - // Debugging / dangerous - // Fills in a WebRenderingStats struct containing information about the state of the compositor. Modified: trunk/Source/WebCore/ChangeLog (121309 => 121310) --- trunk/Source/WebCore/ChangeLog 2012-06-27 01:41:06 UTC (rev 121309) +++ trunk/Source/WebCore/ChangeLog 2012-06-27 01:49:20 UTC (rev 121310) @@ -1,3 +1,24 @@ +2012-06-26 James Robinson + +[chromium] Remove WebView::graphicsContext3D getter +https://bugs.webkit.org/show_bug.cgi?id=89916 + +Reviewed by Adrienne Walker. + +Deletes code supporting compositor context getter. + +* platform/graphics/chromium/cc/CCLayerTreeHost.cpp: +* platform/graphics/chromium/cc/CCLayerTreeHost.h: +(CCLayerTreeHost): +* platform/graphics/chromium/cc/CCProxy.h: +(CCProxy): +* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: +* platform/graphics/chromium/cc/CCSingleThreadProxy.h: +(CCSingleThreadProxy): +* platform/graphics/chromium/cc/CCThreadProxy.cpp: +* platform/graphics/chromium/cc/CCThreadProxy.h: +(CCThreadProxy): + 2012-06-26 Kulanthaivel Palanichamy Unexpected element sizes when mixing inline-table with box-sizing Modif
[webkit-changes] [121309] trunk
Title: [121309] trunk
Revision 121309
Author commit-qu...@webkit.org
Date 2012-06-26 18:41:06 -0700 (Tue, 26 Jun 2012)
Log Message
Unexpected element sizes when mixing inline-table with box-sizing
https://bugs.webkit.org/show_bug.cgi?id=89819
Patch by Kulanthaivel Palanichamy on 2012-06-26
Reviewed by Julien Chaffraix.
Source/WebCore:
This change handles box-sizing: border-box property for CSS tables properly.
Test: fast/box-sizing/css-table-with-box-sizing.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::layout):
LayoutTests:
* fast/box-sizing/css-table-with-box-sizing-expected.txt: Added.
* fast/box-sizing/css-table-with-box-sizing.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTable.cpp
Added Paths
trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing-expected.txt
trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing.html
Diff
Modified: trunk/LayoutTests/ChangeLog (121308 => 121309)
--- trunk/LayoutTests/ChangeLog 2012-06-27 01:38:41 UTC (rev 121308)
+++ trunk/LayoutTests/ChangeLog 2012-06-27 01:41:06 UTC (rev 121309)
@@ -1,3 +1,13 @@
+2012-06-26 Kulanthaivel Palanichamy
+
+Unexpected element sizes when mixing inline-table with box-sizing
+https://bugs.webkit.org/show_bug.cgi?id=89819
+
+Reviewed by Julien Chaffraix.
+
+* fast/box-sizing/css-table-with-box-sizing-expected.txt: Added.
+* fast/box-sizing/css-table-with-box-sizing.html: Added.
+
2012-06-26 Filip Pizlo
DFG PutByValAlias is too aggressive
Added: trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing-expected.txt (0 => 121309)
--- trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing-expected.txt 2012-06-27 01:41:06 UTC (rev 121309)
@@ -0,0 +1,17 @@
+Test case for bug 89819. This tests CSS 'table' and 'inline-table' with box-sizing.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS document.getElementById("t1").offsetWidth is 120
+PASS document.getElementById("t1").offsetHeight is 120
+PASS document.getElementById("t2").offsetWidth is 120
+PASS document.getElementById("t2").offsetHeight is 120
+PASS document.getElementById("t3").offsetWidth is 140
+PASS document.getElementById("t3").offsetHeight is 140
+PASS document.getElementById("t4").offsetWidth is 140
+PASS document.getElementById("t4").offsetHeight is 140
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing.html (0 => 121309)
--- trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing.html (rev 0)
+++ trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing.html 2012-06-27 01:41:06 UTC (rev 121309)
@@ -0,0 +1,53 @@
+
+
+
+.test {
+ width:120px;
+ height:120px;
+ border:10px solid black;
+}
+
+.border-box {
+ box-sizing:border-box;
+ -moz-box-sizing:border-box;
+}
+
+ .content-box {
+ box-sizing:content-box;
+ -moz-box-sizing:content-box;
+}
+
+.css-inline-table {
+ display:inline-table;
+}
+
+.css-table {
+ display:table;
+}
+
+
+
+
+ 120x120css-inline-tableborder-box
+ 120x120css-tableborder-box
+ 120x120css-inline-tablecontent-box
+ 120x120css-tablecontent-box
+
+
+description("Test case for bug 89819. This tests CSS 'table' and 'inline-table' with box-sizing.");
+
+shouldBe('document.getElementById("t1").offsetWidth', '120');
+shouldBe('document.getElementById("t1").offsetHeight', '120');
+shouldBe('document.getElementById("t2").offsetWidth', '120');
+shouldBe('document.getElementById("t2").offsetHeight', '120');
+shouldBe('document.getElementById("t3").offsetWidth', '140');
+shouldBe('document.getElementById("t3").offsetHeight', '140');
+shouldBe('document.getElementById("t4").offsetWidth', '140');
+shouldBe('document.getElementById("t4").offsetHeight', '140');
+
+document.getElementById("testContent").style.display = 'none';
+
+
[webkit-changes] [121308] trunk/Tools
Title: [121308] trunk/Tools
Revision 121308
Author mhahnenb...@apple.com
Date 2012-06-26 18:38:41 -0700 (Tue, 26 Jun 2012)
Log Message
Add support for preciseTime() to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=90027
Reviewed by Darin Adler.
It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::preciseTime):
(WTR):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h
Diff
Modified: trunk/Tools/ChangeLog (121307 => 121308)
--- trunk/Tools/ChangeLog 2012-06-27 01:34:01 UTC (rev 121307)
+++ trunk/Tools/ChangeLog 2012-06-27 01:38:41 UTC (rev 121308)
@@ -1,3 +1,19 @@
+2012-06-26 Mark Hahnenberg
+
+Add support for preciseTime() to WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=90027
+
+Reviewed by Darin Adler.
+
+It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
+
+* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
+* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
+(WTR::LayoutTestController::preciseTime):
+(WTR):
+* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
+(LayoutTestController):
+
2012-06-26 Lucas Forschler
Teach the Apple port how to build the test tools in build-webkit
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl (121307 => 121308)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl 2012-06-27 01:34:01 UTC (rev 121307)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl 2012-06-27 01:38:41 UTC (rev 121308)
@@ -32,6 +32,7 @@
void waitForPolicyDelegate();
void waitUntilDone();
void notifyDone();
+double preciseTime();
// Other dumping.
void dumpBackForwardList();
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp (121307 => 121308)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp 2012-06-27 01:34:01 UTC (rev 121307)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp 2012-06-27 01:38:41 UTC (rev 121308)
@@ -43,6 +43,7 @@
#include
#include
#include
+#include
#include
#include
@@ -617,4 +618,9 @@
WKBundleOverrideBoolPreferenceForTestRunner(InjectedBundle::shared().bundle(), InjectedBundle::shared().pageGroup(), toWK(preference).get(), value);
}
+double LayoutTestController::preciseTime()
+{
+return currentTime();
+}
+
} // namespace WTR
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h (121307 => 121308)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h 2012-06-27 01:34:01 UTC (rev 121307)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h 2012-06-27 01:38:41 UTC (rev 121308)
@@ -63,6 +63,7 @@
void dumpChildFramesAsText() { m_whatToDump = AllFramesText; }
void waitUntilDone();
void notifyDone();
+double preciseTime();
// Other dumping.
void dumpBackForwardList() { m_shouldDumpBackForwardListsForAllWindows = true; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121307] trunk
Title: [121307] trunk Revision 121307 Author fpi...@apple.com Date 2012-06-26 18:34:01 -0700 (Tue, 26 Jun 2012) Log Message DFG PutByValAlias is too aggressive https://bugs.webkit.org/show_bug.cgi?id=90026 Source/_javascript_Core: Reviewed by Gavin Barraclough. For CSE on normal arrays, we now treat PutByVal as impure. This does not appear to affect performance by much. For CSE on typed arrays, we fix PutByValAlias by making GetByVal speculate that the access is within bounds. This also has the effect of making our out-of-bounds handling consistent with WebCore. * dfg/DFGCSEPhase.cpp: (JSC::DFG::CSEPhase::performNodeCSE): * dfg/DFGGraph.h: (JSC::DFG::Graph::byValIsPure): (JSC::DFG::Graph::clobbersWorld): * dfg/DFGNodeType.h: (DFG): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray): (JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray): LayoutTests: Reviewed by Gavin Barraclough. * fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt: Added. * fast/js/dfg-put-by-val-setter-then-get-by-val.html: Added. * fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias-expected.txt: Added. * fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.html: Added. * fast/js/script-tests/dfg-put-by-val-setter-then-get-by-val.js: Added. (foo): (for): * fast/js/script-tests/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.js: Added. (foo): Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp trunk/Source/_javascript_Core/dfg/DFGGraph.h trunk/Source/_javascript_Core/dfg/DFGNodeType.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp Added Paths trunk/LayoutTests/fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt trunk/LayoutTests/fast/js/dfg-put-by-val-setter-then-get-by-val.html trunk/LayoutTests/fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias-expected.txt trunk/LayoutTests/fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.html trunk/LayoutTests/fast/js/script-tests/dfg-put-by-val-setter-then-get-by-val.js trunk/LayoutTests/fast/js/script-tests/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.js Diff Modified: trunk/LayoutTests/ChangeLog (121306 => 121307) --- trunk/LayoutTests/ChangeLog 2012-06-27 01:31:22 UTC (rev 121306) +++ trunk/LayoutTests/ChangeLog 2012-06-27 01:34:01 UTC (rev 121307) @@ -1,3 +1,21 @@ +2012-06-26 Filip Pizlo + +DFG PutByValAlias is too aggressive +https://bugs.webkit.org/show_bug.cgi?id=90026 + + +Reviewed by Gavin Barraclough. + +* fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt: Added. +* fast/js/dfg-put-by-val-setter-then-get-by-val.html: Added. +* fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias-expected.txt: Added. +* fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.html: Added. +* fast/js/script-tests/dfg-put-by-val-setter-then-get-by-val.js: Added. +(foo): +(for): +* fast/js/script-tests/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.js: Added. +(foo): + 2012-06-26 Kevin Ellis Touch adjustment does not target shadow DOM elements Added: trunk/LayoutTests/fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt (0 => 121307) --- trunk/LayoutTests/fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt (rev 0) +++ trunk/LayoutTests/fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt 2012-06-27 01:34:01 UTC (rev 121307) @@ -0,0 +1,409 @@ +Tests that a GetByVal that accesses a value that was PutByVal'd, but where the PutByVal invoked a setter, works correctly. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS foo(array, -1, i) is 42 +PASS thingy is 0 +PASS foo(array, -1, i) is 42 +PASS thingy is 1 +PASS foo(array, -1, i) is 42 +PASS thingy is 2 +PASS foo(array, -1, i) is 42 +PASS thingy is 3 +PASS foo(array, -1, i) is 42 +PASS thingy is 4 +PASS foo(array, -1, i) is 42 +PASS thingy is 5 +PASS foo(array, -1, i) is 42 +PASS thingy is 6 +PASS foo(array, -1, i) is 42 +PASS thingy is 7 +PASS foo(array, -1, i) is 42 +PASS thingy is 8 +PASS foo(array, -1, i) is 42 +PASS thingy is 9 +PASS foo(array, -1, i) is 42 +PASS thingy is 10 +PASS foo(array, -1, i) is 42 +PASS thingy is 11 +PASS foo(array, -1, i) is 42 +PASS thingy is 12 +PASS foo(array, -1, i) is 42 +PASS thingy is 13 +PASS foo(array, -1, i) is 42 +PASS thingy is 14 +PASS foo(array, -1, i) is 42 +PASS thingy is 15 +PASS foo(array, -1, i) is 42 +PASS thingy is 16 +PASS foo(array, -1, i) is 42 +PASS thingy is 17 +PASS foo(array, -1, i) is 42 +PASS thingy is 18 +PASS foo(array, -1, i) is 42 +PASS thingy is 19 +PASS foo(array, -1, i) is 42 +PASS thingy is 20 +PASS foo(array, -1, i) is 42 +PASS thingy is 21 +PASS foo(array, -1, i) is 42 +PASS thingy is 22 +PASS foo(array, -1, i) is 4
[webkit-changes] [121306] trunk/Source/WebCore
Title: [121306] trunk/Source/WebCore
Revision 121306
Author simon.fra...@apple.com
Date 2012-06-26 18:31:22 -0700 (Tue, 26 Jun 2012)
Log Message
Optimize mappings of simple transforms in RenderGeometryMap
https://bugs.webkit.org/show_bug.cgi?id=90034
Reviewed by Dean Jackson.
For transforms that are identity or simple translations, don't
fall off the fast path in RenderGeometryMap; we can just
treat them as offsets.
Improves performance on pages with lots of translateZ(0) elements.
Remove RenderGeometryMapStep::mapPoint() and mapQuad(), which
were unused.
No new tests; optimization only, and tested by assertions.
* rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::push):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGeometryMap.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (121305 => 121306)
--- trunk/Source/WebCore/ChangeLog 2012-06-27 00:41:28 UTC (rev 121305)
+++ trunk/Source/WebCore/ChangeLog 2012-06-27 01:31:22 UTC (rev 121306)
@@ -1,3 +1,24 @@
+2012-06-26 Simon Fraser
+
+Optimize mappings of simple transforms in RenderGeometryMap
+https://bugs.webkit.org/show_bug.cgi?id=90034
+
+Reviewed by Dean Jackson.
+
+For transforms that are identity or simple translations, don't
+fall off the fast path in RenderGeometryMap; we can just
+treat them as offsets.
+
+Improves performance on pages with lots of translateZ(0) elements.
+
+Remove RenderGeometryMapStep::mapPoint() and mapQuad(), which
+were unused.
+
+No new tests; optimization only, and tested by assertions.
+
+* rendering/RenderGeometryMap.cpp:
+(WebCore::RenderGeometryMap::push):
+
2012-06-26 Kevin Ellis
Touch adjustment does not target shadow DOM elements
Modified: trunk/Source/WebCore/rendering/RenderGeometryMap.cpp (121305 => 121306)
--- trunk/Source/WebCore/rendering/RenderGeometryMap.cpp 2012-06-27 00:41:28 UTC (rev 121305)
+++ trunk/Source/WebCore/rendering/RenderGeometryMap.cpp 2012-06-27 01:31:22 UTC (rev 121306)
@@ -46,25 +46,6 @@
{
}
-FloatPoint mapPoint(const FloatPoint& p) const
-{
-if (!m_transform)
-return p + m_offset;
-
-return m_transform->mapPoint(p);
-}
-
-FloatQuad mapQuad(const FloatQuad& quad) const
-{
-if (!m_transform) {
-FloatQuad q = quad;
-q.move(m_offset);
-return q;
-}
-
-return m_transform->mapQuad(quad);
-}
-
const RenderObject* m_renderer;
LayoutSize m_offset;
OwnPtr m_transform; // Includes offset if non-null.
@@ -216,8 +197,11 @@
ASSERT(m_insertionPosition != notFound);
OwnPtr step = adoptPtr(new RenderGeometryMapStep(renderer, accumulatingTransform, isNonUniform, isFixedPosition, hasTransform));
-step->m_transform = adoptPtr(new TransformationMatrix(t));
-
+if (!t.isIntegerTranslation())
+step->m_transform = adoptPtr(new TransformationMatrix(t));
+else
+step->m_offset = LayoutSize(t.e(), t.f());
+
stepInserted(*step.get());
m_mapping.insert(m_insertionPosition, step.release());
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121305] trunk
Title: [121305] trunk
Revision 121305
Author commit-qu...@webkit.org
Date 2012-06-26 17:41:28 -0700 (Tue, 26 Jun 2012)
Log Message
Touch adjustment does not target shadow DOM elements
https://bugs.webkit.org/show_bug.cgi?id=89556
Source/WebCore:
The position of internal shadow-DOM nodes were not being considered
when determining the snap position when TOUCH_ADJUSTMENT is enabled
for fine tuning the position of synthetic mouse events. This
restriction results in not being able to select the calendar picker
when input type=date, or to clear the search field for input
type=search.
Patch by Kevin Ellis on 2012-06-26
Reviewed by Antonio Gomes.
Test: touchadjustment/nested-shadow-node.html
* page/EventHandler.cpp:
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
LayoutTests:
Cannot open calendar picker for input type=date using a touch tap
gesture if TOUCH_ADJUSTMENT is enabled. When touch adjustment is
enabled, the position of a touch point is snapped to the center of an
element when generating synthetic mouse events. The position of shadow
nodes was not being considered when determining the snap position.
This test verifies that touch adjustment now considers shadow-DOM
when calculating the snap position.
Patch by Kevin Ellis on 2012-06-26
Reviewed by Antonio Gomes.
* touchadjustment/nested-shadow-node-expected.txt: Added.
* touchadjustment/nested-shadow-node.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
Added Paths
trunk/LayoutTests/touchadjustment/nested-shadow-node-expected.txt
trunk/LayoutTests/touchadjustment/nested-shadow-node.html
Diff
Modified: trunk/LayoutTests/ChangeLog (121304 => 121305)
--- trunk/LayoutTests/ChangeLog 2012-06-27 00:06:19 UTC (rev 121304)
+++ trunk/LayoutTests/ChangeLog 2012-06-27 00:41:28 UTC (rev 121305)
@@ -1,3 +1,21 @@
+2012-06-26 Kevin Ellis
+
+Touch adjustment does not target shadow DOM elements
+https://bugs.webkit.org/show_bug.cgi?id=89556
+
+Cannot open calendar picker for input type=date using a touch tap
+gesture if TOUCH_ADJUSTMENT is enabled. When touch adjustment is
+enabled, the position of a touch point is snapped to the center of an
+element when generating synthetic mouse events. The position of shadow
+nodes was not being considered when determining the snap position.
+This test verifies that touch adjustment now considers shadow-DOM
+when calculating the snap position.
+
+Reviewed by Antonio Gomes.
+
+* touchadjustment/nested-shadow-node-expected.txt: Added.
+* touchadjustment/nested-shadow-node.html: Added.
+
2012-06-26 Ryosuke Niwa
Stop calling node() and deprecatedEditingOffset() in comparePositions
@@ -3703,7 +3721,6 @@
These make sure the alignment used in the first row of the span is correct when things like
the height of the cell and the height of the span are specified.
-
2012-06-18 Hayato Ito
Event dispatcher should use InsertionPoint::hasDistribution instead of InsertinPoint::isActive in re-targeting.
Added: trunk/LayoutTests/touchadjustment/nested-shadow-node-expected.txt (0 => 121305)
--- trunk/LayoutTests/touchadjustment/nested-shadow-node-expected.txt (rev 0)
+++ trunk/LayoutTests/touchadjustment/nested-shadow-node-expected.txt 2012-06-27 00:41:28 UTC (rev 121305)
@@ -0,0 +1,24 @@
+Test the case where a clickable target contains a shadow-DOM element. The adjusted point should snap to the location of the shadow-DOM element if close enough to the original touch position.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS adjustedNode.id is element.id
+PASS adjustedPoint.x is within 10 of 88
+PASS adjustedPoint.y is within 10 of 28
+PASS adjustedNode.id is element.id
+PASS adjustedPoint.x is within 10 of 88
+PASS adjustedPoint.y is within 10 of 28
+PASS adjustedNode.id is element.id
+PASS adjustedPoint.x is within 10 of 88
+PASS adjustedPoint.y is within 10 of 28
+PASS adjustedNode.id is element.id
+PASS adjustedPoint.x is within 10 of 88
+PASS adjustedPoint.y is within 10 of 28
+PASS adjustedNode.id is element.id
+PASS adjustedPoint.x is within 1 of 58
+PASS adjustedPoint.y is within 1 of 58
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/touchadjustment/nested-shadow-node.html (0 => 121305)
--- trunk/LayoutTests/touchadjustment/nested-shadow-node.html (rev 0)
+++ trunk/LayoutTests/touchadjustment/nested-shadow-node.html 2012-06-27 00:41:28 UTC (rev 121305)
@@ -0,0 +1,103 @@
+
+
+
+#targetDiv {
+background: #00f;
+height: 100px;
+position: relative;
+width: 100px;
+}
+
+
+
+
+
+
+
+
+
+
+
+