[webkit-changes] [200617] trunk
Title: [200617] trunk Revision 200617 Author commit-qu...@webkit.org Date 2016-05-09 23:36:42 -0700 (Mon, 09 May 2016) Log Message Web Inspector: CRASH under JSC::DebuggerCallFrame::thisValue when hitting breakpoint https://bugs.webkit.org/show_bug.cgi?id=157442 Patch by Joseph Pecoraro on 2016-05-09 Reviewed by Saam Barati. Source/_javascript_Core: * debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::thisValueForCallFrame): When the thisValue is JSValue() return undefined and avoid calling toThisValue which would lead to a crash. Having `this` be an empty JSValue could happen inside an ES6 class constructor, before calling super. LayoutTests: * inspector/debugger/break-in-constructor-before-super-expected.txt: Added. * inspector/debugger/break-in-constructor-before-super.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.cpp Added Paths trunk/LayoutTests/inspector/debugger/break-in-constructor-before-super-expected.txt trunk/LayoutTests/inspector/debugger/break-in-constructor-before-super.html Diff Modified: trunk/LayoutTests/ChangeLog (200616 => 200617) --- trunk/LayoutTests/ChangeLog 2016-05-10 06:07:30 UTC (rev 200616) +++ trunk/LayoutTests/ChangeLog 2016-05-10 06:36:42 UTC (rev 200617) @@ -1,3 +1,14 @@ +2016-05-09 Joseph Pecoraro + +Web Inspector: CRASH under JSC::DebuggerCallFrame::thisValue when hitting breakpoint +https://bugs.webkit.org/show_bug.cgi?id=157442 + + +Reviewed by Saam Barati. + +* inspector/debugger/break-in-constructor-before-super-expected.txt: Added. +* inspector/debugger/break-in-constructor-before-super.html: Added. + 2016-05-09 Simon Fraser iOS-scrolling test cleanup. Added: trunk/LayoutTests/inspector/debugger/break-in-constructor-before-super-expected.txt (0 => 200617) --- trunk/LayoutTests/inspector/debugger/break-in-constructor-before-super-expected.txt (rev 0) +++ trunk/LayoutTests/inspector/debugger/break-in-constructor-before-super-expected.txt 2016-05-10 06:36:42 UTC (rev 200617) @@ -0,0 +1,11 @@ +CONSOLE MESSAGE: line 16: before super +CONSOLE MESSAGE: line 19: after super +Pause in constructor before super should not crash. + + +== Running test suite: PauseInConstructorBeforeSuper +-- Running test case: TriggerPauseInConstructorBeforeSuper +PASS: Paused +PASS: `this` should be undefined and not cause a crash. +PASS: Resumed + Added: trunk/LayoutTests/inspector/debugger/break-in-constructor-before-super.html (0 => 200617) --- trunk/LayoutTests/inspector/debugger/break-in-constructor-before-super.html (rev 0) +++ trunk/LayoutTests/inspector/debugger/break-in-constructor-before-super.html 2016-05-10 06:36:42 UTC (rev 200617) @@ -0,0 +1,65 @@ + + + + +class Parent { +constructor() +{ +this.x = 1; +} +}; + +class Child extends Parent { +constructor() +{ +console.log("before super"); +debugger; +super(); +console.log("after super"); +} +}; + +function triggerPause() { +new Child; +} + +function test() +{ +InspectorProtocol.sendCommand("Debugger.enable", {}); +InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true}); + +let suite = ProtocolTest.createAsyncSuite("PauseInConstructorBeforeSuper"); + +suite.addTestCase({ +name: "TriggerPauseInConstructorBeforeSuper", +description: "Trigger a pause in a constructor before calling super should not crash.", +test: (resolve, reject) => { +ProtocolTest.evaluateInPage("triggerPause()"); + +InspectorProtocol.eventHandler["Debugger.paused"] = (messageObject) => { +ProtocolTest.pass("Paused"); + +let callFrameIdentifier = messageObject.params.callFrames[0].callFrameId; +InspectorProtocol.sendCommand("Debugger.evaluateOnCallFrame", {callFrameId: callFrameIdentifier, _expression_: "this"}, (messageObject) => { +ProtocolTest.expectThat(messageObject.result.result.type === "undefined", "`this` should be undefined and not cause a crash."); +}); + +InspectorProtocol.sendCommand("Debugger.resume"); +}; + +InspectorProtocol.eventHandler["Debugger.resumed"] = (messageObject) => { +ProtocolTest.pass("Resumed"); +resolve(); +}; +} +}); + +suite.runTestCasesAndFinish(); +} + + + +Pause in constructor before super should not crash. + + Modified: trunk/Source/_javascript_Core/ChangeLog (200616 => 200617) --- trunk/Source/_javascript_Core/ChangeLog 2016-05-10 06:07:30 UTC (rev 200616) +++ trunk/Source/_javascript_Core/ChangeLog 2016-05-10 06:36:42 UTC (rev 200617) @@ -1,3 +1,18 @@ +2016-05-09 Joseph Pecoraro + +Web Inspector: CRASH under JSC::DebuggerCallFr
[webkit-changes] [200616] branches/safari-601.6-branch/
Title: [200616] branches/safari-601.6-branch/ Revision 200616 Author bshaf...@apple.com Date 2016-05-09 23:07:30 -0700 (Mon, 09 May 2016) Log Message New Branch. Added Paths branches/safari-601.6-branch/ Diff Property changes: branches/safari-601.6-branch Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200615] branches/safari-601.1.46.128-branch/
Title: [200615] branches/safari-601.1.46.128-branch/ Revision 200615 Author bshaf...@apple.com Date 2016-05-09 23:03:32 -0700 (Mon, 09 May 2016) Log Message New Branch. Added Paths branches/safari-601.1.46.128-branch/ Diff Property changes: branches/safari-601.1.46.128-branch Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200614] trunk/Source/WebCore
Title: [200614] trunk/Source/WebCore Revision 200614 Author achristen...@apple.com Date 2016-05-09 22:04:24 -0700 (Mon, 09 May 2016) Log Message Fix GTK build after r200607 * Modules/notifications/Notification.h: dir and replaceId are used in WebNotificationManager with NOTIFICATIONS and with LEGACY_NOTIFICATIONS Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/notifications/Notification.h Diff Modified: trunk/Source/WebCore/ChangeLog (200613 => 200614) --- trunk/Source/WebCore/ChangeLog 2016-05-10 04:58:30 UTC (rev 200613) +++ trunk/Source/WebCore/ChangeLog 2016-05-10 05:04:24 UTC (rev 200614) @@ -1,3 +1,10 @@ +2016-05-09 Alex Christensen + +Fix GTK build after r200607 + +* Modules/notifications/Notification.h: +dir and replaceId are used in WebNotificationManager with NOTIFICATIONS and with LEGACY_NOTIFICATIONS + 2016-05-09 Simon Fraser Fix the Windows build after r200602, and do some minor tidyup. Modified: trunk/Source/WebCore/Modules/notifications/Notification.h (200613 => 200614) --- trunk/Source/WebCore/Modules/notifications/Notification.h 2016-05-10 04:58:30 UTC (rev 200613) +++ trunk/Source/WebCore/Modules/notifications/Notification.h 2016-05-10 05:04:24 UTC (rev 200614) @@ -80,13 +80,11 @@ const String& body() const { return m_body; } const String& lang() const { return m_lang; } -#if ENABLE(LEGACY_NOTIFICATIONS) const String& dir() const { return m_direction; } void setDir(const String& dir) { m_direction = dir; } const String& replaceId() const { return m_tag; } void setReplaceId(const String& replaceId) { m_tag = replaceId; } -#endif const String& tag() const { return m_tag; } void setTag(const String& tag) { m_tag = tag; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200613] trunk/Source/JavaScriptCore
Title: [200613] trunk/Source/_javascript_Core Revision 200613 Author fpi...@apple.com Date 2016-05-09 21:58:30 -0700 (Mon, 09 May 2016) Log Message Unreviewed, fix cloop. * bytecode/ValueProfile.cpp: (JSC::ResultProfile::emitDetectNumericness): (JSC::ResultProfile::emitSetNonNumber): * bytecode/ValueProfile.h: (JSC::ResultProfile::addressOfFlags): (JSC::ResultProfile::addressOfSpecialFastPathCount): (JSC::ResultProfile::detectNumericness): (JSC::ResultProfile::hasBits): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/ValueProfile.cpp trunk/Source/_javascript_Core/bytecode/ValueProfile.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (200612 => 200613) --- trunk/Source/_javascript_Core/ChangeLog 2016-05-10 04:52:31 UTC (rev 200612) +++ trunk/Source/_javascript_Core/ChangeLog 2016-05-10 04:58:30 UTC (rev 200613) @@ -1,3 +1,16 @@ +2016-05-09 Filip Pizlo + +Unreviewed, fix cloop. + +* bytecode/ValueProfile.cpp: +(JSC::ResultProfile::emitDetectNumericness): +(JSC::ResultProfile::emitSetNonNumber): +* bytecode/ValueProfile.h: +(JSC::ResultProfile::addressOfFlags): +(JSC::ResultProfile::addressOfSpecialFastPathCount): +(JSC::ResultProfile::detectNumericness): +(JSC::ResultProfile::hasBits): + 2016-05-09 Michael Saboff Crash beneath ObjCCallbackFunctionImpl::call Modified: trunk/Source/_javascript_Core/bytecode/ValueProfile.cpp (200612 => 200613) --- trunk/Source/_javascript_Core/bytecode/ValueProfile.cpp 2016-05-10 04:52:31 UTC (rev 200612) +++ trunk/Source/_javascript_Core/bytecode/ValueProfile.cpp 2016-05-10 04:58:30 UTC (rev 200613) @@ -31,6 +31,7 @@ namespace JSC { +#if ENABLE(JIT) void ResultProfile::emitDetectNumericness(CCallHelpers& jit, JSValueRegs regs, TagRegistersMode mode) { CCallHelpers::Jump isInt32 = jit.branchIfInt32(regs, mode); @@ -53,6 +54,7 @@ { jit.or32(CCallHelpers::TrustedImm32(ResultProfile::NonNumber), CCallHelpers::AbsoluteAddress(addressOfFlags())); } +#endif // ENABLE(JIT) } // namespace JSC Modified: trunk/Source/_javascript_Core/bytecode/ValueProfile.h (200612 => 200613) --- trunk/Source/_javascript_Core/bytecode/ValueProfile.h 2016-05-10 04:52:31 UTC (rev 200612) +++ trunk/Source/_javascript_Core/bytecode/ValueProfile.h 2016-05-10 04:58:30 UTC (rev 200613) @@ -248,10 +248,6 @@ void* addressOfFlags() { return &m_bytecodeOffsetAndFlags; } void* addressOfSpecialFastPathCount() { return &m_specialFastPathCount; } -// Sets (Int32Overflow | Int52Overflow | NonNegZeroDouble | NegZeroDouble) if it sees a -// double. Sets NonNumber if it sees a non-number. -void emitDetectNumericness(CCallHelpers&, JSValueRegs, TagRegistersMode = HaveTagRegisters); - void detectNumericness(JSValue value) { if (value.isInt32()) @@ -262,12 +258,18 @@ } m_bytecodeOffsetAndFlags |= NonNumber; } + +#if ENABLE(JIT) +// Sets (Int32Overflow | Int52Overflow | NonNegZeroDouble | NegZeroDouble) if it sees a +// double. Sets NonNumber if it sees a non-number. +void emitDetectNumericness(CCallHelpers&, JSValueRegs, TagRegistersMode = HaveTagRegisters); // Sets (Int32Overflow | Int52Overflow | NonNegZeroDouble | NegZeroDouble). void emitSetDouble(CCallHelpers&); // Sets NonNumber. void emitSetNonNumber(CCallHelpers&); +#endif // ENABLE(JIT) private: bool hasBits(int mask) const { return m_bytecodeOffsetAndFlags & mask; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200612] trunk/Source/WebCore
Title: [200612] trunk/Source/WebCore Revision 200612 Author simon.fra...@apple.com Date 2016-05-09 21:52:31 -0700 (Mon, 09 May 2016) Log Message Fix the Windows build after r200602, and do some minor tidyup. * platform/graphics/ca/PlatformCALayer.h: * platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: (PlatformCALayerCocoa::contentsHidden): * platform/graphics/ca/win/PlatformCALayerWin.cpp: (PlatformCALayerWin::contentsHidden): (PlatformCALayerWin::setContentsHidden): * platform/graphics/ca/win/PlatformCALayerWin.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h Diff Modified: trunk/Source/WebCore/ChangeLog (200611 => 200612) --- trunk/Source/WebCore/ChangeLog 2016-05-10 03:40:58 UTC (rev 200611) +++ trunk/Source/WebCore/ChangeLog 2016-05-10 04:52:31 UTC (rev 200612) @@ -1,3 +1,15 @@ +2016-05-09 Simon Fraser + +Fix the Windows build after r200602, and do some minor tidyup. + +* platform/graphics/ca/PlatformCALayer.h: +* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: +(PlatformCALayerCocoa::contentsHidden): +* platform/graphics/ca/win/PlatformCALayerWin.cpp: +(PlatformCALayerWin::contentsHidden): +(PlatformCALayerWin::setContentsHidden): +* platform/graphics/ca/win/PlatformCALayerWin.h: + 2016-05-09 Darin Adler Change Notification constructor to take an IDL dictionary instead of a WebCore::Dictionary Modified: trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h (200611 => 200612) --- trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h 2016-05-10 03:40:58 UTC (rev 200611) +++ trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h 2016-05-10 04:52:31 UTC (rev 200612) @@ -158,6 +158,7 @@ virtual bool isHidden() const = 0; virtual void setHidden(bool) = 0; +// Used to disable user interaction for some platforms. virtual bool contentsHidden() const = 0; virtual void setContentsHidden(bool) = 0; Modified: trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm (200611 => 200612) --- trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm 2016-05-10 03:40:58 UTC (rev 200611) +++ trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm 2016-05-10 04:52:31 UTC (rev 200612) @@ -618,13 +618,11 @@ bool PlatformCALayerCocoa::contentsHidden() const { -// Used to disable user interaction for some platforms. -return true; +return false; } void PlatformCALayerCocoa::setContentsHidden(bool) { -// Used to disable user interaction for some platforms. } void PlatformCALayerCocoa::setBackingStoreAttached(bool) Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp (200611 => 200612) --- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp 2016-05-10 03:40:58 UTC (rev 200611) +++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp 2016-05-10 04:52:31 UTC (rev 200612) @@ -448,6 +448,15 @@ setNeedsCommit(); } +bool PlatformCALayerWin::contentsHidden() const +{ +return false; +} + +void PlatformCALayerWin::setContentsHidden(bool) +{ +} + void PlatformCALayerWin::setBackingStoreAttached(bool) { } Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h (200611 => 200612) --- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h 2016-05-10 03:40:58 UTC (rev 200611) +++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h 2016-05-10 04:52:31 UTC (rev 200612) @@ -82,6 +82,9 @@ bool isHidden() const override; void setHidden(bool) override; +bool contentsHidden() const override; +void setContentsHidden(bool) override; + void setBackingStoreAttached(bool) override; bool backingStoreAttached() const override; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200611] trunk/Source/WebKit2
Title: [200611] trunk/Source/WebKit2 Revision 200611 Author timothy_hor...@apple.com Date 2016-05-09 20:40:58 -0700 (Mon, 09 May 2016) Log Message REGRESSION (r191922): Zoom in/Zoom Out is not working for PDFs https://bugs.webkit.org/show_bug.cgi?id=157503 Reviewed by Anders Carlsson. * WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h: Restore a requiresUnifiedScaleFactor that was lost in r191922. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::mainFramePluginHandlesPageScaleGestureDidChange): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::didInitializePlugin): * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad): Separate mainFramePluginHandlesPageScaleGesture changes out from didCommitLoadForFrame, because the PluginView doesn't exist at this point, so it can't answer the handlesPageScaleGesture question correctly (or at all). Instead, we'll send the message when the main-frame PluginView is initialized. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in trunk/Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (200610 => 200611) --- trunk/Source/WebKit2/ChangeLog 2016-05-10 03:22:39 UTC (rev 200610) +++ trunk/Source/WebKit2/ChangeLog 2016-05-10 03:40:58 UTC (rev 200611) @@ -1,3 +1,28 @@ +2016-05-09 Tim Horton + +REGRESSION (r191922): Zoom in/Zoom Out is not working for PDFs +https://bugs.webkit.org/show_bug.cgi?id=157503 + + +Reviewed by Anders Carlsson. + +* WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h: +Restore a requiresUnifiedScaleFactor that was lost in r191922. + +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::didCommitLoadForFrame): +(WebKit::WebPageProxy::mainFramePluginHandlesPageScaleGestureDidChange): +* UIProcess/WebPageProxy.h: +* UIProcess/WebPageProxy.messages.in: +* WebProcess/Plugins/PluginView.cpp: +(WebKit::PluginView::didInitializePlugin): +* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: +(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad): +Separate mainFramePluginHandlesPageScaleGesture changes out from didCommitLoadForFrame, +because the PluginView doesn't exist at this point, so it can't answer +the handlesPageScaleGesture question correctly (or at all). +Instead, we'll send the message when the main-frame PluginView is initialized. + 2016-05-09 Simon Fraser [iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (200610 => 200611) --- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2016-05-10 03:22:39 UTC (rev 200610) +++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2016-05-10 03:40:58 UTC (rev 200611) @@ -3036,7 +3036,7 @@ } } -void WebPageProxy::didCommitLoadForFrame(uint64_t frameID, uint64_t navigationID, const String& mimeType, bool frameHasCustomContentProvider, bool pluginHandlesPageScaleGesture, uint32_t opaqueFrameLoadType, const WebCore::CertificateInfo& certificateInfo, bool containsPluginDocument, const UserData& userData) +void WebPageProxy::didCommitLoadForFrame(uint64_t frameID, uint64_t navigationID, const String& mimeType, bool frameHasCustomContentProvider, uint32_t opaqueFrameLoadType, const WebCore::CertificateInfo& certificateInfo, bool containsPluginDocument, const UserData& userData) { PageClientProtector protector(m_pageClient); @@ -3096,11 +3096,10 @@ // plugin is handling page scaling itself) so we should reset it to the default // for standard main frame loads. if (frame->isMainFrame()) { -m_mainFramePluginHandlesPageScaleGesture = pluginHandlesPageScaleGesture; - if (static_cast(opaqueFrameLoadType) == FrameLoadType::Standard) { m_pageScaleFactor = 1; m_pluginScaleFactor = 1; +m_mainFramePluginHandlesPageScaleGesture = false; } } @@ -3342,6 +3341,11 @@ m_loaderClient->didDetectXSSForFrame(*this, *frame, m_process->transformHandlesToObjects(userData.object()).get()); } +void WebPageProxy::mainFramePluginHandlesPageScaleGestureDidChange(bool mainFramePluginHandlesPageScaleGesture) +{ +m_mainFramePluginHandlesPageScaleGesture = mainFramePluginHandlesPageScaleGesture; +} + void WebPageProxy::frameDidBecomeFrameSet(uint64_t frameID, bool value) { PageClientProtector protector(m_pageClient); Modified: trunk/Source/WebK
[webkit-changes] [200610] trunk/Source/JavaScriptCore
Title: [200610] trunk/Source/_javascript_Core Revision 200610 Author msab...@apple.com Date 2016-05-09 20:22:39 -0700 (Mon, 09 May 2016) Log Message Crash beneath ObjCCallbackFunctionImpl::call https://bugs.webkit.org/show_bug.cgi?id=157491 Reviewed by Saam Barati. Clear any exceptions after the micro task runs. Tried creating a test case, but I don't have source for the app. I can't seem to find the right combination of Promises and ObjC code. * runtime/JSJob.cpp: (JSC::JSJobMicrotask::run): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/JSJob.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (200609 => 200610) --- trunk/Source/_javascript_Core/ChangeLog 2016-05-10 02:55:20 UTC (rev 200609) +++ trunk/Source/_javascript_Core/ChangeLog 2016-05-10 03:22:39 UTC (rev 200610) @@ -1,3 +1,18 @@ +2016-05-09 Michael Saboff + +Crash beneath ObjCCallbackFunctionImpl::call +https://bugs.webkit.org/show_bug.cgi?id=157491 + +Reviewed by Saam Barati. + +Clear any exceptions after the micro task runs. + +Tried creating a test case, but I don't have source for the app. +I can't seem to find the right combination of Promises and ObjC code. + +* runtime/JSJob.cpp: +(JSC::JSJobMicrotask::run): + 2016-05-09 Filip Pizlo Polymorphic operands in operators coerces downstream values to double. Modified: trunk/Source/_javascript_Core/runtime/JSJob.cpp (200609 => 200610) --- trunk/Source/_javascript_Core/runtime/JSJob.cpp 2016-05-10 02:55:20 UTC (rev 200609) +++ trunk/Source/_javascript_Core/runtime/JSJob.cpp 2016-05-10 03:22:39 UTC (rev 200610) @@ -71,6 +71,7 @@ for (unsigned index = 0, length = m_arguments->length(); index < length; ++index) handlerArguments.append(m_arguments->JSArray::get(exec, index)); profiledCall(exec, ProfilingReason::Microtask, m_job.get(), handlerCallType, handlerCallData, jsUndefined(), handlerArguments); +exec->vm().clearException(); } } // namespace JSC ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200608] trunk/Source/WebInspectorUI
Title: [200608] trunk/Source/WebInspectorUI Revision 200608 Author mattba...@apple.com Date 2016-05-09 19:45:14 -0700 (Mon, 09 May 2016) Log Message Web Inspector: Filtering by Errors/Warnings should not filter Breakpoints list https://bugs.webkit.org/show_bug.cgi?id=157481 Reviewed by Timothy Hatcher. * Localizations/en.lproj/localizedStrings.js: New UI strings. * UserInterface/Views/DebuggerSidebarPanel.js: (WebInspector.DebuggerSidebarPanel.showResourcesWithIssuesOnlyFilterFunction): Only filter tree elements belonging to the scripts tree outline. (WebInspector.DebuggerSidebarPanel): Drive-by cleanup of Issues filter button tooltips. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (200607 => 200608) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-10 02:31:03 UTC (rev 200607) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-10 02:45:14 UTC (rev 200608) @@ -1,3 +1,20 @@ +2016-05-09 Matt Baker + +Web Inspector: Filtering by Errors/Warnings should not filter Breakpoints list +https://bugs.webkit.org/show_bug.cgi?id=157481 + + +Reviewed by Timothy Hatcher. + +* Localizations/en.lproj/localizedStrings.js: +New UI strings. + +* UserInterface/Views/DebuggerSidebarPanel.js: +(WebInspector.DebuggerSidebarPanel.showResourcesWithIssuesOnlyFilterFunction): +Only filter tree elements belonging to the scripts tree outline. +(WebInspector.DebuggerSidebarPanel): +Drive-by cleanup of Issues filter button tooltips. + 2016-05-09 Nikita Vasilyev REGRESSION: Web Inspector: DOM path bar blinks when modifying inline styles Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (200607 => 200608) --- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2016-05-10 02:31:03 UTC (rev 200607) +++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2016-05-10 02:45:14 UTC (rev 200608) @@ -501,6 +501,7 @@ localizedStrings["Object Graph"] = "Object Graph"; localizedStrings["Offset"] = "Offset"; localizedStrings["Online"] = "Online"; +localizedStrings["Only show resources with issues"] = "Only show resources with issues"; localizedStrings["Opacity"] = "Opacity"; localizedStrings["Option-click to show all units"] = "Option-click to show all units"; localizedStrings["Option-click to show all values"] = "Option-click to show all values"; @@ -636,10 +637,9 @@ localizedStrings["Show Remaining (%d)"] = "Show Remaining (%d)"; localizedStrings["Show Replay Controls"] = "Show Replay Controls"; localizedStrings["Show Source"] = "Show Source"; +localizedStrings["Show all resources"] = "Show all resources"; localizedStrings["Show compositing borders"] = "Show compositing borders"; localizedStrings["Show console tab"] = "Show console tab"; -localizedStrings["Show only resources with issues."] = "Show only resources with issues."; -localizedStrings["Show resources with and without issues."] = "Show resources with and without issues."; localizedStrings["Show shadow DOM nodes"] = "Show shadow DOM nodes"; localizedStrings["Show the details sidebar (%s)"] = "Show the details sidebar (%s)"; localizedStrings["Show the navigation sidebar (%s)"] = "Show the navigation sidebar (%s)"; Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (200607 => 200608) --- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2016-05-10 02:31:03 UTC (rev 200607) +++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2016-05-10 02:45:14 UTC (rev 200608) @@ -107,6 +107,10 @@ function showResourcesWithIssuesOnlyFilterFunction(treeElement) { +// Issues are only shown in the scripts tree outline. +if (treeElement.treeOutline !== this._scriptsContentTreeOutline) +return true; + // Keep issues. if (treeElement instanceof WebInspector.IssueTreeElement) return true; @@ -121,7 +125,7 @@ return false; }; -this.filterBar.addFilterBarButton("debugger-show-resources-with-issues-only", showResourcesWithIssuesOnlyFilterFunction, true, WebInspector.UIString("Show only resources with issues."), WebInspector.UIString("Show resources with and without issues."), "Images/Errors.svg", 15, 15); +this.filterBar.addFilterBarButton("debugger-show-resources-with-issues-only", showResourcesWithIssuesOnlyFilterFunction.bind(this), true, WebInspector.UIString("Only show resources with issues"), WebInspector.UIString("Show all resources"), "Images/Errors.svg", 15, 15); this._breakpointsContentTreeOutline = this.contentTreeOutline; _
[webkit-changes] [200607] trunk/Source/WebCore
Title: [200607] trunk/Source/WebCore Revision 200607 Author da...@apple.com Date 2016-05-09 19:31:03 -0700 (Mon, 09 May 2016) Log Message Change Notification constructor to take an IDL dictionary instead of a WebCore::Dictionary https://bugs.webkit.org/show_bug.cgi?id=157466 Reviewed by Alex Christensen. * Modules/notifications/Notification.cpp: Got rid of unneeded includes. (WebCore::Notification::Notification): Deleted the unused default constructor. Changed NotificationCenter argument to be reference rather than PassRefPtr. Changed one of the ScriptExecutionContext arguments to be a Document since the code relies on that already. Used the lambda form of timer creation instead of the class member form. Added a FIXME about when m_notificationCenter can be null. (WebCore::Notification::create): Changed NotificationCenter argument to be reference rather than PassRefPtr. Changed options argument to be Options rather than Dictionary. (WebCore::directionString): Added. Helper because the class still wants to store the direction as a string, at least for now. (WebCore::Notification::show): Streamlined the code a bit. (WebCore::Notification::taskTimerFired): Deleted. Not needed now that we use a lambda inside the constructor. (WebCore::Notification::permission): Removed unneeded const from return type. (WebCore::Notification::permissionString): Ditto. * Modules/notifications/Notification.h: Used pragma once, updated for changes above. Removed a number of unused functions, including cancel, setIconURL, setLang, stopLoadingIcon, detachPresenter, setBody, startLoadingIcon, finishLoadingIcon, and taskTimerFired. * Modules/notifications/Notification.idl: Add NotificationOptions and pass it instead of Dictionary to the constructor. Note that this is only a subset of what is currently specified in the Notifications API document. The latest document specifies a much more complex feature with lots more options. * Modules/notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::createNotification): Pass a reference rather than a pointer to this. * Modules/notifications/NotificationClient.h: Use pragma once. Removed unneeded includes and forward declarations. Fixed #if to be easier to read. * bindings/js/JSDOMConvert.h: Reworked the convert functions to use Converter and DefaultConverter structs so we can do partial specialization in the future and so we can get custom types for optional values. Used this to make an optional String just be a null String, so it won't try to use Optional instead. Might get more complex latter when we add support for nullable. * bindings/scripts/CodeGeneratorJS.pm: (GenerateEnumerationImplementationContent): Generate a blank line to make the output slightly clearer. Tweaked a comment. (GenerateDefaultValue): Added. Converts the default syntax from IDL into the syntax needed in C++ code. (GenerateDefaultValueWithLeadingComma): Added. Helper for use below. (GenerateDictionaryImplementationContent): Use GenerateDefaultValue and GenerateDefaultValueWithLeadingComma to make default values. (GenerateParametersCheck): Use GenerateDefaultValue here in the enumeration code path. This is a step in the direction of being able to make the whole thing more generic in the future. * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: * bindings/scripts/test/GObject/WebKitDOMTestObj.h: * bindings/scripts/test/JS/JSTestObj.cpp: * bindings/scripts/test/ObjC/DOMTestObj.h: * bindings/scripts/test/ObjC/DOMTestObj.mm: Regenerated. * bindings/scripts/test/TestObj.idl: Simplified and extended some of the test cases to cover more combinations of the dictionary and enumeration support. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/notifications/Notification.cpp trunk/Source/WebCore/Modules/notifications/Notification.h trunk/Source/WebCore/Modules/notifications/Notification.idl trunk/Source/WebCore/Modules/notifications/NotificationCenter.cpp trunk/Source/WebCore/Modules/notifications/NotificationClient.h trunk/Source/WebCore/bindings/js/JSDOMConvert.h trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm trunk/Source/WebCore/bindings/scripts/test/TestObj.idl Diff Modified: trunk/Source/WebCore/ChangeLog (200606 => 200607) --- trunk/Source/WebCore/ChangeLog 2016-05-10 02:01:28 UTC (rev 200606) +++ trunk/Source/WebCore/ChangeLog 2016-05-10 02:31:03 UTC (rev 200607) @@ -1,3 +1,70 @@ +2016-05-09 Darin Adler + +Change Notification constructor to take an IDL dictionary instead of a WebCore::Dictionary +https://bugs.webkit.org/show_bug.cgi?id=157466 + +Reviewed by Alex Christensen. + +* Modules/notifica
[webkit-changes] [200605] trunk/Source/WebInspectorUI
Title: [200605] trunk/Source/WebInspectorUI Revision 200605 Author nvasil...@apple.com Date 2016-05-09 18:40:26 -0700 (Mon, 09 May 2016) Log Message REGRESSION: Web Inspector: DOM path bar blinks when modifying inline styles https://bugs.webkit.org/show_bug.cgi?id=149258 Reviewed by Timothy Hatcher. * UserInterface/Base/Utilities.js: (Array.shallowEqual): * UserInterface/Views/ContentBrowser.js: (WebInspector.ContentBrowser.prototype._updateContentViewNavigationItems): (WebInspector.ContentBrowser.prototype._removeAllNavigationItems): Don't re-render the navigation bar when all new navigation items match the previous ones. * UserInterface/Views/HierarchicalPathNavigationItem.js: (WebInspector.HierarchicalPathNavigationItem.set components.let.componentsEqual): (WebInspector.HierarchicalPathNavigationItem.prototype.set components): Don't re-render HierarchicalPathComponent when all new path components match the previous ones. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathNavigationItem.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (200604 => 200605) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-10 01:35:48 UTC (rev 200604) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-10 01:40:26 UTC (rev 200605) @@ -1,3 +1,23 @@ +2016-05-09 Nikita Vasilyev + +REGRESSION: Web Inspector: DOM path bar blinks when modifying inline styles +https://bugs.webkit.org/show_bug.cgi?id=149258 + + +Reviewed by Timothy Hatcher. + +* UserInterface/Base/Utilities.js: +(Array.shallowEqual): +* UserInterface/Views/ContentBrowser.js: +(WebInspector.ContentBrowser.prototype._updateContentViewNavigationItems): +(WebInspector.ContentBrowser.prototype._removeAllNavigationItems): +Don't re-render the navigation bar when all new navigation items match the previous ones. + +* UserInterface/Views/HierarchicalPathNavigationItem.js: +(WebInspector.HierarchicalPathNavigationItem.set components.let.componentsEqual): +(WebInspector.HierarchicalPathNavigationItem.prototype.set components): +Don't re-render HierarchicalPathComponent when all new path components match the previous ones. + 2016-05-09 Matt Baker Web Inspector: Remove Global Breakpoints folder Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js (200604 => 200605) --- trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js 2016-05-10 01:35:48 UTC (rev 200604) +++ trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js 2016-05-10 01:40:26 UTC (rev 200605) @@ -424,6 +424,27 @@ value: Element.prototype.createChild }); +Object.defineProperty(Array, "shallowEqual", +{ +value: function(a, b) +{ +if (a === b) +return true; + +let length = a.length; + +if (length !== b.length) +return false; + +for (var i = 0; i < length; ++i) { +if (a[i] !== b[i]) +return false; +} + +return true; +} +}); + Object.defineProperty(Array.prototype, "lastValue", { get: function() Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js (200604 => 200605) --- trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js 2016-05-10 01:35:48 UTC (rev 200604) +++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js 2016-05-10 01:40:26 UTC (rev 200605) @@ -365,30 +365,33 @@ _updateContentViewNavigationItems() { -var navigationBar = this.navigationBar; - -// First, we remove the navigation items added by the previous content view. -this._currentContentViewNavigationItems.forEach(function(navigationItem) { -navigationBar.removeNavigationItem(navigationItem); -}); - var currentContentView = this.currentContentView; if (!currentContentView) { +this._removeAllNavigationItems(); this._currentContentViewNavigationItems = []; return; } -var insertionIndex = navigationBar.navigationItems.indexOf(this._dividingFlexibleSpaceNavigationItem) + 1; +let previousItems = this._currentContentViewNavigationItems.filter((item) => !(item instanceof WebInspector.DividerNavigationItem)); +let isUnchanged = Array.shallowEqual(previousItems, currentContentView.navigationItems); + +if (isUnchanged) +return; + +this._removeAllNavigationItems(); + +let navigationBar = this.navigationBar; +let insertionIndex = navigationBar.navigationItems.indexOf(this._dividingFlexibleSpaceNavigationItem) + 1; console.assert(insertionIndex >= 0); // Keep track of items we'll be adding to the navigation bar. -
[webkit-changes] [200604] trunk/LayoutTests
Title: [200604] trunk/LayoutTests Revision 200604 Author simon.fra...@apple.com Date 2016-05-09 18:35:48 -0700 (Mon, 09 May 2016) Log Message Land correct result for a recently added test. * fast/scrolling/ios/touch-scroll-visibility-hidden-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/scrolling/ios/touch-scroll-visibility-hidden-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (200603 => 200604) --- trunk/LayoutTests/ChangeLog 2016-05-10 00:59:33 UTC (rev 200603) +++ trunk/LayoutTests/ChangeLog 2016-05-10 01:35:48 UTC (rev 200604) @@ -1,5 +1,11 @@ 2016-05-09 Simon Fraser +Land correct result for a recently added test. + +* fast/scrolling/ios/touch-scroll-visibility-hidden-expected.txt: + +2016-05-09 Simon Fraser + [iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling https://bugs.webkit.org/show_bug.cgi?id=157496 rdar://problem/22963278 Modified: trunk/LayoutTests/fast/scrolling/ios/touch-scroll-visibility-hidden-expected.txt (200603 => 200604) --- trunk/LayoutTests/fast/scrolling/ios/touch-scroll-visibility-hidden-expected.txt 2016-05-10 00:59:33 UTC (rev 200603) +++ trunk/LayoutTests/fast/scrolling/ios/touch-scroll-visibility-hidden-expected.txt 2016-05-10 01:35:48 UTC (rev 200604) @@ -1,5 +1,6 @@ PASS hitElement.id is "under-target" PASS scroller.scrollTop is 0 +body scroll swipe complete PASS scroller.scrollTop is 0 PASS document.scrollingElement.scrollTop is 90 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200603] trunk/Source/WebCore
Title: [200603] trunk/Source/WebCore Revision 200603 Author beid...@apple.com Date 2016-05-09 17:59:33 -0700 (Mon, 09 May 2016) Log Message Modern IDB: Have server database connections remember the OpenDB request that spawned them. https://bugs.webkit.org/show_bug.cgi?id=157498 Reviewed by Tim Horton. No new tests (No testable change in behavior, debug only for now). * Modules/indexeddb/server/UniqueIDBDatabase.cpp: (WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation): * Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp: (WebCore::IDBServer::UniqueIDBDatabaseConnection::create): (WebCore::IDBServer::UniqueIDBDatabaseConnection::UniqueIDBDatabaseConnection): (WebCore::IDBServer::UniqueIDBDatabaseConnection::connectionClosedFromClient): (WebCore::IDBServer::UniqueIDBDatabaseConnection::didFireVersionChangeEvent): (WebCore::IDBServer::UniqueIDBDatabaseConnection::createVersionChangeTransaction): (WebCore::IDBServer::UniqueIDBDatabaseConnection::establishTransaction): (WebCore::IDBServer::UniqueIDBDatabaseConnection::didAbortTransaction): (WebCore::IDBServer::UniqueIDBDatabaseConnection::didCommitTransaction): * Modules/indexeddb/server/UniqueIDBDatabaseConnection.h: (WebCore::IDBServer::UniqueIDBDatabaseConnection::openRequestIdentifier): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.h Diff Modified: trunk/Source/WebCore/ChangeLog (200602 => 200603) --- trunk/Source/WebCore/ChangeLog 2016-05-10 00:20:27 UTC (rev 200602) +++ trunk/Source/WebCore/ChangeLog 2016-05-10 00:59:33 UTC (rev 200603) @@ -1,3 +1,27 @@ +2016-05-09 Brady Eidson + +Modern IDB: Have server database connections remember the OpenDB request that spawned them. +https://bugs.webkit.org/show_bug.cgi?id=157498 + +Reviewed by Tim Horton. + +No new tests (No testable change in behavior, debug only for now). + +* Modules/indexeddb/server/UniqueIDBDatabase.cpp: +(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation): + +* Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp: +(WebCore::IDBServer::UniqueIDBDatabaseConnection::create): +(WebCore::IDBServer::UniqueIDBDatabaseConnection::UniqueIDBDatabaseConnection): +(WebCore::IDBServer::UniqueIDBDatabaseConnection::connectionClosedFromClient): +(WebCore::IDBServer::UniqueIDBDatabaseConnection::didFireVersionChangeEvent): +(WebCore::IDBServer::UniqueIDBDatabaseConnection::createVersionChangeTransaction): +(WebCore::IDBServer::UniqueIDBDatabaseConnection::establishTransaction): +(WebCore::IDBServer::UniqueIDBDatabaseConnection::didAbortTransaction): +(WebCore::IDBServer::UniqueIDBDatabaseConnection::didCommitTransaction): +* Modules/indexeddb/server/UniqueIDBDatabaseConnection.h: +(WebCore::IDBServer::UniqueIDBDatabaseConnection::openRequestIdentifier): + 2016-05-09 Simon Fraser [iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (200602 => 200603) --- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2016-05-10 00:20:27 UTC (rev 200602) +++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2016-05-10 00:59:33 UTC (rev 200603) @@ -151,10 +151,10 @@ return; } -Ref connection = UniqueIDBDatabaseConnection::create(*this, m_currentOpenDBRequest->connection()); -UniqueIDBDatabaseConnection* rawConnection = &connection.get(); +Ref connection = UniqueIDBDatabaseConnection::create(*this, *m_currentOpenDBRequest); if (requestedVersion == m_databaseInfo->version()) { +auto* rawConnection = &connection.get(); addOpenDatabaseConnection(WTFMove(connection)); auto result = IDBResultData::openDatabaseSuccess(m_currentOpenDBRequest->requestData().requestIdentifier(), *rawConnection); @@ -165,7 +165,7 @@ } ASSERT(!m_versionChangeDatabaseConnection); -m_versionChangeDatabaseConnection = rawConnection; +m_versionChangeDatabaseConnection = WTFMove(connection); // 3.3.7 "versionchange" transaction steps // If there's no other open connections to this database, the version change process can begin immediately. Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp (200602 => 200603) --- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp 2016-05-10 00:20:27 UTC (rev 200602) +++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp 2016-05-10 00:59:33 UTC (rev 200603) @@ -43,15 +43,16 @@ return ++nextIdentifier; } -Ref UniqueIDBDatabaseConnection:
[webkit-changes] [200602] trunk
Title: [200602] trunk Revision 200602 Author simon.fra...@apple.com Date 2016-05-09 17:20:27 -0700 (Mon, 09 May 2016) Log Message [iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling https://bugs.webkit.org/show_bug.cgi?id=157496 Source/WebCore: Reviewed by Tim Horton. UIScrollViews are constructed in the UI process for visibility:hidden scrollable elements with -webkit-overflow-scrolling: touch, and these intercept user events when they should not. Fix by propagating a "contentsHidden" flag from the web process which is used to turn off user interaction on these views. Test: fast/scrolling/ios/touch-scroll-visibility-hidden.html * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateContentsVisibility): We have to tell the scrolling layer if we have visibility:hidden. * platform/graphics/ca/PlatformCALayer.h: * platform/graphics/ca/cocoa/PlatformCALayerCocoa.h: * platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: (PlatformCALayerCocoa::contentsHidden): (PlatformCALayerCocoa::setContentsHidden): * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterDescendants): Source/WebKit2: rdar://problem/22963278 Reviewed by Tim Horton. UIScrollViews are constructed in the UI process for visibility:hidden scrollable elements with -webkit-overflow-scrolling: touch, and these intercept user events when they should not. Fix by propagating a "contentsHidden" flag from the web process which is used to turn off user interaction on these views. * Shared/mac/RemoteLayerTreePropertyApplier.mm: (WebKit::RemoteLayerTreePropertyApplier::applyProperties): * Shared/mac/RemoteLayerTreeTransaction.h: * Shared/mac/RemoteLayerTreeTransaction.mm: (WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties): (WebKit::RemoteLayerTreeTransaction::LayerProperties::encode): (WebKit::RemoteLayerTreeTransaction::LayerProperties::decode): (WebKit::dumpChangedLayers): * UIProcess/ios/RemoteLayerTreeHostIOS.mm: (-[UIView _recursiveFindDescendantScrollViewAtPoint:withEvent:]): Our custom hit test needs to take view.isUserInteractionEnabled into account. * WebProcess/WebPage/mac/PlatformCALayerRemote.cpp: (WebKit::PlatformCALayerRemote::setHidden): (WebKit::PlatformCALayerRemote::contentsHidden): (WebKit::PlatformCALayerRemote::setContentsHidden): * WebProcess/WebPage/mac/PlatformCALayerRemote.h: Tools: rdar://problem/22963278 Reviewed by Tim Horton. Enhance UIScriptController to generate a drag, which is useful for scrolling. * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::dragFromPointToPoint): * WebKitTestRunner/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/HIDEventGenerator.h: * WebKitTestRunner/ios/HIDEventGenerator.mm: (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::dragFromPointToPoint): LayoutTests: rdar://problem/22963278 Reviewed by Tim Horton. Add a fast/scrolling/ios directory, disable it everywhere except on iOS. * TestExpectations: * fast/scrolling/ios/touch-scroll-visibility-hidden-expected.txt: Added. * fast/scrolling/ios/touch-scroll-visibility-hidden.html: Added. * platform/ios-simulator-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm trunk/Source/WebCore/rendering/RenderLayerBacking.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm trunk/Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl trunk/Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp trunk/Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.h trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm Added Paths trunk/LayoutTests/fast/scrolling/ios/ trunk/LayoutTests/fast/scrolling/ios/touch-scroll-visibility-hidden-expected.txt trunk/LayoutTests/fast/scrolling/ios/touch-scroll-visibility-hidden.html Diff Modified: trunk/LayoutTests/ChangeLog (200601 => 200602) --- trunk/LayoutTes
[webkit-changes] [200600] trunk/Source/WebInspectorUI
Title: [200600] trunk/Source/WebInspectorUI Revision 200600 Author mattba...@apple.com Date 2016-05-09 17:02:30 -0700 (Mon, 09 May 2016) Log Message Web Inspector: Remove Global Breakpoints folder https://bugs.webkit.org/show_bug.cgi?id=157478 Reviewed by Timothy Hatcher. * Localizations/en.lproj/localizedStrings.js: Remove UI string. * UserInterface/Views/DebuggerSidebarPanel.js: (WebInspector.DebuggerSidebarPanel): (WebInspector.DebuggerSidebarPanel.prototype._breakpointTreeOutlineContextMenuTreeElement): (WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange): Remove references to folder tree element. (WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements.isSpecialBreakpoint): (WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements): Top level comparison should check for "special" breakpoints. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (200599 => 200600) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-10 00:00:06 UTC (rev 200599) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-10 00:02:30 UTC (rev 200600) @@ -1,5 +1,26 @@ 2016-05-09 Matt Baker +Web Inspector: Remove Global Breakpoints folder +https://bugs.webkit.org/show_bug.cgi?id=157478 + + +Reviewed by Timothy Hatcher. + +* Localizations/en.lproj/localizedStrings.js: +Remove UI string. + +* UserInterface/Views/DebuggerSidebarPanel.js: +(WebInspector.DebuggerSidebarPanel): +(WebInspector.DebuggerSidebarPanel.prototype._breakpointTreeOutlineContextMenuTreeElement): +(WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange): +Remove references to folder tree element. + +(WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements.isSpecialBreakpoint): +(WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements): +Top level comparison should check for "special" breakpoints. + +2016-05-09 Matt Baker + Web Inspector: Heap Snapshot Timeline view can be live https://bugs.webkit.org/show_bug.cgi?id=157487 Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (200599 => 200600) --- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2016-05-10 00:00:06 UTC (rev 200599) +++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2016-05-10 00:02:30 UTC (rev 200600) @@ -362,7 +362,6 @@ localizedStrings["Function Name Variable"] = "Function Name Variable"; localizedStrings["Garbage Collection"] = "Garbage Collection"; localizedStrings["Getter"] = "Getter"; -localizedStrings["Global Breakpoints"] = "Global Breakpoints"; localizedStrings["Global Code"] = "Global Code"; localizedStrings["Global Lexical Environment"] = "Global Lexical Environment"; localizedStrings["Global Variables"] = "Global Variables"; Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (200599 => 200600) --- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2016-05-10 00:00:06 UTC (rev 200599) +++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2016-05-10 00:02:30 UTC (rev 200600) @@ -99,10 +99,9 @@ // Add this offset-sections class name so the sticky headers don't overlap the navigation bar. this.element.classList.add(WebInspector.DebuggerSidebarPanel.OffsetSectionsStyleClassName); -this._globalBreakpointsFolderTreeElement = new WebInspector.FolderTreeElement(WebInspector.UIString("Global Breakpoints"), null, WebInspector.DebuggerSidebarPanel.GlobalIconStyleClassName); this._allExceptionsBreakpointTreeElement = new WebInspector.BreakpointTreeElement(WebInspector.debuggerManager.allExceptionsBreakpoint, WebInspector.DebuggerSidebarPanel.ExceptionIconStyleClassName, WebInspector.UIString("All Exceptions")); this._allUncaughtExceptionsBreakpointTreeElement = new WebInspector.BreakpointTreeElement(WebInspector.debuggerManager.allUncaughtExceptionsBreakpoint, WebInspector.DebuggerSidebarPanel.ExceptionIconStyleClassName, WebInspector.UIString("All Uncaught Exceptions")); -this.suppressFilteringOnTreeElements([this._globalBreakpointsFolderTreeElement, this._allExceptionsBreakpointTreeElement, this._allUncaughtExceptionsBreakpointTreeElement]); +this.suppressFilteringOnTreeElements([this._allExceptionsBreakpointTreeElement, this._allUncaughtExceptionsBreakpointTreeElement]); this.filterBar.placeholder = WebInspector.UIString("Filter List"); @@ -137,10 +136,8 @@ this._breakpointsContentTreeOutline._ondelete_ = this._breakpointTreeOutlineDeleteTreeElement.bind(this); this._breakpointsContentTreeOutline
[webkit-changes] [200599] trunk/Source/WebKit/mac
Title: [200599] trunk/Source/WebKit/mac Revision 200599 Author timothy_hor...@apple.com Date 2016-05-09 17:00:06 -0700 (Mon, 09 May 2016) Log Message [WebKit1] Invoking a link preview on a complex link (e.g. an image) results in an empty TextIndicator https://bugs.webkit.org/show_bug.cgi?id=157497 Reviewed by Anders Carlsson. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _defaultAnimationController]): r198578 fixed this for WebKit2, but forgot about WebKit1. Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm Diff Modified: trunk/Source/WebKit/mac/ChangeLog (200598 => 200599) --- trunk/Source/WebKit/mac/ChangeLog 2016-05-09 23:59:55 UTC (rev 200598) +++ trunk/Source/WebKit/mac/ChangeLog 2016-05-10 00:00:06 UTC (rev 200599) @@ -1,3 +1,15 @@ +2016-05-09 Tim Horton + +[WebKit1] Invoking a link preview on a complex link (e.g. an image) results in an empty TextIndicator +https://bugs.webkit.org/show_bug.cgi?id=157497 + + +Reviewed by Anders Carlsson. + +* WebView/WebImmediateActionController.mm: +(-[WebImmediateActionController _defaultAnimationController]): +r198578 fixed this for WebKit2, but forgot about WebKit1. + 2016-05-08 Myles C. Maxfield [OS X] Migrate our Font classes entirely off of NSFont Modified: trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm (200598 => 200599) --- trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm 2016-05-09 23:59:55 UTC (rev 200598) +++ trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm 2016-05-10 00:00:06 UTC (rev 200599) @@ -278,7 +278,7 @@ _type = WebImmediateActionLinkPreview; RefPtr linkRange = rangeOfContents(*_hitTestResult.URLElement()); -auto indicator = TextIndicator::createWithRange(*linkRange, TextIndicatorOptionDefault, TextIndicatorPresentationTransition::FadeIn); +auto indicator = TextIndicator::createWithRange(*linkRange, TextIndicatorOptionUseBoundingRectAndPaintAllContentForComplexRanges, TextIndicatorPresentationTransition::FadeIn); if (indicator) [_webView _setTextIndicator:*indicator withLifetime:TextIndicatorWindowLifetime::Permanent]; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200598] trunk/Source/WebCore
Title: [200598] trunk/Source/WebCore Revision 200598 Author beid...@apple.com Date 2016-05-09 16:59:55 -0700 (Mon, 09 May 2016) Log Message Modern IDB: Prevent the same transaction from being commited/aborted twice. https://bugs.webkit.org/show_bug.cgi?id=157494 Reviewed by Tim Horton. When a page navigates or a worker terminates, in rare cases with specific unfortunate timing, the IDBServer might receive a request to commit/abort a transaction that is already in the process of committing/aborting. By moving transactions that are finishing into their own map we can at least detect this situation and return an error. This seems like an improvement over some mysterious ASSERTs/timeouts. No new tests: While apparent that this is at least partially to blame for some existing timeouts/ASSERTs, I could not nail down a reliable way to reproduce this with a dedicated test. * Modules/indexeddb/server/UniqueIDBDatabase.cpp: (WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase): (WebCore::IDBServer::UniqueIDBDatabase::performCurrentDeleteOperation): (WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore): (WebCore::IDBServer::UniqueIDBDatabase::prepareToFinishTransaction): (WebCore::IDBServer::UniqueIDBDatabase::commitTransaction): (WebCore::IDBServer::UniqueIDBDatabase::didPerformCommitTransaction): (WebCore::IDBServer::UniqueIDBDatabase::abortTransaction): (WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction): (WebCore::IDBServer::UniqueIDBDatabase::hasUnfinishedTransactions): (WebCore::IDBServer::UniqueIDBDatabase::operationAndTransactionTimerFired): (WebCore::IDBServer::UniqueIDBDatabase::takeNextRunnableTransaction): (WebCore::IDBServer::UniqueIDBDatabase::transactionCompleted): Renamed from inProgressTransactionCompleted. (WebCore::IDBServer::UniqueIDBDatabase::inProgressTransactionCompleted): Deleted. * Modules/indexeddb/server/UniqueIDBDatabase.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h Diff Modified: trunk/Source/WebCore/ChangeLog (200597 => 200598) --- trunk/Source/WebCore/ChangeLog 2016-05-09 23:51:20 UTC (rev 200597) +++ trunk/Source/WebCore/ChangeLog 2016-05-09 23:59:55 UTC (rev 200598) @@ -1,3 +1,36 @@ +2016-05-09 Brady Eidson + +Modern IDB: Prevent the same transaction from being commited/aborted twice. +https://bugs.webkit.org/show_bug.cgi?id=157494 + +Reviewed by Tim Horton. + +When a page navigates or a worker terminates, in rare cases with specific unfortunate timing, the IDBServer +might receive a request to commit/abort a transaction that is already in the process of committing/aborting. + +By moving transactions that are finishing into their own map we can at least detect this situation and +return an error. This seems like an improvement over some mysterious ASSERTs/timeouts. + +No new tests: +While apparent that this is at least partially to blame for some existing timeouts/ASSERTs, I could not nail +down a reliable way to reproduce this with a dedicated test. + +* Modules/indexeddb/server/UniqueIDBDatabase.cpp: +(WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase): +(WebCore::IDBServer::UniqueIDBDatabase::performCurrentDeleteOperation): +(WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore): +(WebCore::IDBServer::UniqueIDBDatabase::prepareToFinishTransaction): +(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction): +(WebCore::IDBServer::UniqueIDBDatabase::didPerformCommitTransaction): +(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction): +(WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction): +(WebCore::IDBServer::UniqueIDBDatabase::hasUnfinishedTransactions): +(WebCore::IDBServer::UniqueIDBDatabase::operationAndTransactionTimerFired): +(WebCore::IDBServer::UniqueIDBDatabase::takeNextRunnableTransaction): +(WebCore::IDBServer::UniqueIDBDatabase::transactionCompleted): Renamed from inProgressTransactionCompleted. +(WebCore::IDBServer::UniqueIDBDatabase::inProgressTransactionCompleted): Deleted. +* Modules/indexeddb/server/UniqueIDBDatabase.h: + 2016-05-09 Tim Horton Draw border and correct icon for placeholder attachments Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (200597 => 200598) --- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2016-05-09 23:51:20 UTC (rev 200597) +++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2016-05-09 23:59:55 UTC (rev 200598) @@ -60,7 +60,7 @@ { LOG(IndexedDB, "UniqueIDBDatabase::~UniqueIDBDatabase() (%p) %s", this, m_identifier.debugString().utf8().data()); ASSERT(!hasAnyPendingCallbacks()); -ASSERT(m_inProgressT
[webkit-changes] [200597] trunk/Source/JavaScriptCore
Title: [200597] trunk/Source/_javascript_Core Revision 200597 Author keith_mil...@apple.com Date 2016-05-09 16:51:20 -0700 (Mon, 09 May 2016) Log Message CallObjectConstructor should not call operationToThis in the FTL https://bugs.webkit.org/show_bug.cgi?id=157492 Reviewed by Mark Lam. At some point when I was working on intrinsifying the Object constructor, I realized that the Object constructor was different from the ToObject operation. I fixed the DFG but I guess I didn't fix the FTL. This patch fixes an issue with www.wunderground.com not loading the 10-day forecast and local map. * ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCallObjectConstructor): * tests/stress/call-object-constructor.js: Added. (test): (assert): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp Added Paths trunk/Source/_javascript_Core/tests/stress/call-object-constructor.js Diff Modified: trunk/Source/_javascript_Core/ChangeLog (200596 => 200597) --- trunk/Source/_javascript_Core/ChangeLog 2016-05-09 23:48:17 UTC (rev 200596) +++ trunk/Source/_javascript_Core/ChangeLog 2016-05-09 23:51:20 UTC (rev 200597) @@ -1,3 +1,25 @@ +2016-05-09 Keith Miller + +CallObjectConstructor should not call operationToThis in the FTL +https://bugs.webkit.org/show_bug.cgi?id=157492 + + +Reviewed by Mark Lam. + +At some point when I was working on intrinsifying the Object +constructor, I realized that the Object constructor was different +from the ToObject operation. I fixed the DFG but I guess I didn't +fix the FTL. + +This patch fixes an issue with www.wunderground.com not loading +the 10-day forecast and local map. + +* ftl/FTLLowerDFGToB3.cpp: +(JSC::FTL::DFG::LowerDFGToB3::compileCallObjectConstructor): +* tests/stress/call-object-constructor.js: Added. +(test): +(assert): + 2016-05-09 Saam barati Getter and setter on super are called with wrong "this" object Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (200596 => 200597) --- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp 2016-05-09 23:48:17 UTC (rev 200596) +++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp 2016-05-09 23:51:20 UTC (rev 200597) @@ -1458,6 +1458,7 @@ void compileCallObjectConstructor() { +JSGlobalObject* globalObject = m_graph.globalObjectFor(m_node->origin.semantic); LValue value = lowJSValue(m_node->child1()); LBasicBlock isCellCase = m_out.newBlock(); @@ -1471,7 +1472,7 @@ m_out.branch(isObject(value), usually(continuation), rarely(slowCase)); m_out.appendTo(slowCase, continuation); -ValueFromBlock slowResult = m_out.anchor(vmCall(m_out.int64, m_out.operation(operationToObject), m_callFrame, value)); +ValueFromBlock slowResult = m_out.anchor(vmCall(m_out.int64, m_out.operation(operationObjectConstructor), m_callFrame, m_out.constIntPtr(globalObject), value)); m_out.jump(continuation); m_out.appendTo(continuation, lastNext); Added: trunk/Source/_javascript_Core/tests/stress/call-object-constructor.js (0 => 200597) --- trunk/Source/_javascript_Core/tests/stress/call-object-constructor.js (rev 0) +++ trunk/Source/_javascript_Core/tests/stress/call-object-constructor.js 2016-05-09 23:51:20 UTC (rev 200597) @@ -0,0 +1,18 @@ +function test(n) { +return n === Object(n); +} +noInline(test); + +function assert(condition) { +if (!condition) +throw new Error("assertion failed"); +} + +for (i = 0; i < 10; i++) { +assert(!test(null)); +assert(!test(undefined)); +assert(!test(1)); +assert(!test("")); +assert(!test(Symbol.iterator)); +assert(test({})); +} ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200596] trunk/Source/WebCore
Title: [200596] trunk/Source/WebCore Revision 200596 Author timothy_hor...@apple.com Date 2016-05-09 16:48:17 -0700 (Mon, 09 May 2016) Log Message Draw border and correct icon for placeholder attachments https://bugs.webkit.org/show_bug.cgi?id=157495 rdar://problem/19982510 Reviewed by Anders Carlsson. * Resources/AttachmentPlaceholder.png: Added. * Resources/attachmentplacehol...@2x.png: Added. * WebCore.xcodeproj/project.pbxproj: * rendering/RenderThemeMac.mm: (WebCore::attachmentPlaceholderBorderColor): (WebCore::paintAttachmentIconPlaceholder): (WebCore::paintAttachmentProgress): (WebCore::paintAttachmentPlaceholderBorder): (WebCore::RenderThemeMac::paintAttachment): If progress is set, but set to 0, draw a dashed border around the attachment and use the placeholder "download" artwork. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/rendering/RenderThemeMac.mm Added Paths trunk/Source/WebCore/Resources/AttachmentPlaceholder.png trunk/Source/WebCore/Resources/attachmentplacehol...@2x.png Diff Modified: trunk/Source/WebCore/ChangeLog (200595 => 200596) --- trunk/Source/WebCore/ChangeLog 2016-05-09 22:50:34 UTC (rev 200595) +++ trunk/Source/WebCore/ChangeLog 2016-05-09 23:48:17 UTC (rev 200596) @@ -1,3 +1,23 @@ +2016-05-09 Tim Horton + +Draw border and correct icon for placeholder attachments +https://bugs.webkit.org/show_bug.cgi?id=157495 +rdar://problem/19982510 + +Reviewed by Anders Carlsson. + +* Resources/AttachmentPlaceholder.png: Added. +* Resources/attachmentplacehol...@2x.png: Added. +* WebCore.xcodeproj/project.pbxproj: +* rendering/RenderThemeMac.mm: +(WebCore::attachmentPlaceholderBorderColor): +(WebCore::paintAttachmentIconPlaceholder): +(WebCore::paintAttachmentProgress): +(WebCore::paintAttachmentPlaceholderBorder): +(WebCore::RenderThemeMac::paintAttachment): +If progress is set, but set to 0, draw a dashed border around the attachment +and use the placeholder "download" artwork. + 2016-05-09 Ada Chan Introduce WebVideoFullscreenInterfaceMac::isPlayingVideoInEnhancedFullscreen() and use it in WebVideoFullscreenManagerProxy::isPlayingVideoInEnhancedFullscreen() Added: trunk/Source/WebCore/Resources/AttachmentPlaceholder.png (Binary files differ) Property changes on: trunk/Source/WebCore/Resources/AttachmentPlaceholder.png ___ Added: svn:mime-type Added: trunk/Source/WebCore/Resources/attachmentplacehol...@2x.png (Binary files differ) Property changes on: trunk/Source/WebCore/Resources/attachmentplacehol...@2x.png ___ Added: svn:mime-type Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (200595 => 200596) --- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2016-05-09 22:50:34 UTC (rev 200595) +++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2016-05-09 23:48:17 UTC (rev 200596) @@ -1165,6 +1165,8 @@ 2D5002FB1B56D7990020AAF7 /* PathUtilities.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D5002F91B56D7990020AAF7 /* PathUtilities.cpp */; }; 2D5002FC1B56D7990020AAF7 /* PathUtilities.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D5002FA1B56D7990020AAF7 /* PathUtilities.h */; settings = {ATTRIBUTES = (Private, ); }; }; 2D5036681BCDDDC400E20BB3 /* GestureEvents.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D5036671BCDDDC400E20BB3 /* GestureEvents.cpp */; }; + 2D50A4B71CE10E198049 /* AttachmentPlaceholder.png in Resources */ = {isa = PBXBuildFile; fileRef = 2D50A4B51CE10E198049 /* AttachmentPlaceholder.png */; }; + 2D50A4B81CE10E198049 /* attachmentplacehol...@2x.png in Resources */ = {isa = PBXBuildFile; fileRef = 2D50A4B61CE10E198049 /* attachmentplacehol...@2x.png */; }; 2D5646B01B8F8493003C4994 /* DictionaryPopupInfo.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D5646AF1B8F8493003C4994 /* DictionaryPopupInfo.h */; settings = {ATTRIBUTES = (Private, ); }; }; 2D59F1BF1A0044C6001F3D29 /* DataDetectorsSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D59F1BE1A0044C6001F3D29 /* DataDetectorsSPI.h */; settings = {ATTRIBUTES = (Private, ); }; }; 2D5A592F152525230036EE51 /* ImageOrientation.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8748D7412CC3F89001FBA41 /* ImageOrientation.cpp */; }; @@ -8654,6 +8656,8 @@ 2D5002F91B56D7990020AAF7 /* PathUtilities.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = PathUtilities.cpp; sourceTree = ""; }; 2D5002FA1B56D7990020AAF7 /* PathUtilities.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PathUtilities.h; sourceTree = ""; }; 2D5036671BCDDDC400E20BB3 /* GestureEvents.cpp */ = {isa = PBXFileReference; f
[webkit-changes] [200595] trunk/Source
Title: [200595] trunk/Source Revision 200595 Author adac...@apple.com Date 2016-05-09 15:50:34 -0700 (Mon, 09 May 2016) Log Message Introduce WebVideoFullscreenInterfaceMac::isPlayingVideoInEnhancedFullscreen() and use it in WebVideoFullscreenManagerProxy::isPlayingVideoInEnhancedFullscreen() https://bugs.webkit.org/show_bug.cgi?id=157493 Reviewed by Dan Bernstein. Source/WebCore: * platform/mac/WebVideoFullscreenInterfaceMac.h: * platform/mac/WebVideoFullscreenInterfaceMac.mm: (WebCore::WebVideoFullscreenInterfaceMac::isPlayingVideoInEnhancedFullscreen): Source/WebKit2: * UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm: (WebKit::WebVideoFullscreenManagerProxy::isPlayingVideoInEnhancedFullscreen): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm Diff Modified: trunk/Source/WebCore/ChangeLog (200594 => 200595) --- trunk/Source/WebCore/ChangeLog 2016-05-09 22:01:30 UTC (rev 200594) +++ trunk/Source/WebCore/ChangeLog 2016-05-09 22:50:34 UTC (rev 200595) @@ -1,3 +1,14 @@ +2016-05-09 Ada Chan + +Introduce WebVideoFullscreenInterfaceMac::isPlayingVideoInEnhancedFullscreen() and use it in WebVideoFullscreenManagerProxy::isPlayingVideoInEnhancedFullscreen() +https://bugs.webkit.org/show_bug.cgi?id=157493 + +Reviewed by Dan Bernstein. + +* platform/mac/WebVideoFullscreenInterfaceMac.h: +* platform/mac/WebVideoFullscreenInterfaceMac.mm: +(WebCore::WebVideoFullscreenInterfaceMac::isPlayingVideoInEnhancedFullscreen): + 2016-05-09 Simon Fraser Clean up iOS text autosizing code Modified: trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h (200594 => 200595) --- trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h 2016-05-09 22:01:30 UTC (rev 200594) +++ trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h 2016-05-09 22:50:34 UTC (rev 200595) @@ -93,6 +93,8 @@ void setMode(HTMLMediaElementEnums::VideoFullscreenMode); void clearMode(HTMLMediaElementEnums::VideoFullscreenMode); +bool isPlayingVideoInEnhancedFullscreen() const; + WEBCORE_EXPORT bool mayAutomaticallyShowVideoPictureInPicture() const { return false; } void applicationDidBecomeActive() { } Modified: trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm (200594 => 200595) --- trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm 2016-05-09 22:01:30 UTC (rev 200594) +++ trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm 2016-05-09 22:50:34 UTC (rev 200595) @@ -167,6 +167,11 @@ { } +bool WebVideoFullscreenInterfaceMac::isPlayingVideoInEnhancedFullscreen() const +{ +return false; +} + bool supportsPictureInPicture() { return false; Modified: trunk/Source/WebKit2/ChangeLog (200594 => 200595) --- trunk/Source/WebKit2/ChangeLog 2016-05-09 22:01:30 UTC (rev 200594) +++ trunk/Source/WebKit2/ChangeLog 2016-05-09 22:50:34 UTC (rev 200595) @@ -1,3 +1,13 @@ +2016-05-09 Ada Chan + +Introduce WebVideoFullscreenInterfaceMac::isPlayingVideoInEnhancedFullscreen() and use it in WebVideoFullscreenManagerProxy::isPlayingVideoInEnhancedFullscreen() +https://bugs.webkit.org/show_bug.cgi?id=157493 + +Reviewed by Dan Bernstein. + +* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm: +(WebKit::WebVideoFullscreenManagerProxy::isPlayingVideoInEnhancedFullscreen): + 2016-05-06 Ada Chan Add WKPageRef SPI to tell whether there's a video playing in enhanced fullscreen Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm (200594 => 200595) --- trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm 2016-05-09 22:01:30 UTC (rev 200594) +++ trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm 2016-05-09 22:50:34 UTC (rev 200595) @@ -250,11 +250,12 @@ #if PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE) bool WebVideoFullscreenManagerProxy::isPlayingVideoInEnhancedFullscreen() const { -#if USE(APPLE_INTERNAL_SDK) -#import -#else +for (auto& tuple : m_contextMap.values()) { +if (std::get<1>(tuple)->isPlayingVideoInEnhancedFullscreen()) +return true; +} + return false; -#endif } #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200594] trunk/Source/WebInspectorUI
Title: [200594] trunk/Source/WebInspectorUI Revision 200594 Author mattba...@apple.com Date 2016-05-09 15:01:30 -0700 (Mon, 09 May 2016) Log Message Web Inspector: Heap Snapshot Timeline view can be live https://bugs.webkit.org/show_bug.cgi?id=157487 Reviewed by Joseph Pecoraro. * UserInterface/Views/HeapAllocationsTimelineView.js: (WebInspector.HeapAllocationsTimelineView.prototype.get showsLiveRecordingData): Deleted. Don't override, should return true. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (200593 => 200594) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-09 21:57:43 UTC (rev 200593) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-09 22:01:30 UTC (rev 200594) @@ -1,3 +1,15 @@ +2016-05-09 Matt Baker + +Web Inspector: Heap Snapshot Timeline view can be live +https://bugs.webkit.org/show_bug.cgi?id=157487 + + +Reviewed by Joseph Pecoraro. + +* UserInterface/Views/HeapAllocationsTimelineView.js: +(WebInspector.HeapAllocationsTimelineView.prototype.get showsLiveRecordingData): Deleted. +Don't override, should return true. + 2016-05-09 Manuel Rego Casasnovas [css-grid] Update Grid Layout properties in CSSKeywordCompletions.js Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js (200593 => 200594) --- trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js 2016-05-09 21:57:43 UTC (rev 200593) +++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js 2016-05-09 22:01:30 UTC (rev 200594) @@ -93,8 +93,6 @@ // Public -get showsLiveRecordingData() { return false; } - showHeapSnapshotList() { if (this._showingSnapshotList) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200593] trunk/Source/WebCore
Title: [200593] trunk/Source/WebCore Revision 200593 Author simon.fra...@apple.com Date 2016-05-09 14:57:43 -0700 (Mon, 09 May 2016) Log Message Clean up iOS text autosizing code https://bugs.webkit.org/show_bug.cgi?id=157489 Reviewed by Zalan Bujtas. Change the TraverseNextInclusionFunction and HeightTypeTraverseNextInclusionFunction to take references. Use downcast<> more. Whitespace cleanup. * rendering/RenderBlockFlow.cpp: (WebCore::isNonBlocksOrNonFixedHeightListItems): * rendering/RenderElement.cpp: (WebCore::includeNonFixedHeight): * rendering/RenderObject.cpp: (WebCore::RenderObject::traverseNext): * rendering/RenderObject.h: * rendering/TextAutoSizing.cpp: (WebCore::TextAutoSizingValue::adjustNodeSizes): (WebCore::TextAutoSizingValue::reset): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBlockFlow.cpp trunk/Source/WebCore/rendering/RenderElement.cpp trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/TextAutoSizing.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (200592 => 200593) --- trunk/Source/WebCore/ChangeLog 2016-05-09 21:53:43 UTC (rev 200592) +++ trunk/Source/WebCore/ChangeLog 2016-05-09 21:57:43 UTC (rev 200593) @@ -1,3 +1,28 @@ +2016-05-09 Simon Fraser + +Clean up iOS text autosizing code +https://bugs.webkit.org/show_bug.cgi?id=157489 + +Reviewed by Zalan Bujtas. + +Change the TraverseNextInclusionFunction and HeightTypeTraverseNextInclusionFunction +to take references. + +Use downcast<> more. + +Whitespace cleanup. + +* rendering/RenderBlockFlow.cpp: +(WebCore::isNonBlocksOrNonFixedHeightListItems): +* rendering/RenderElement.cpp: +(WebCore::includeNonFixedHeight): +* rendering/RenderObject.cpp: +(WebCore::RenderObject::traverseNext): +* rendering/RenderObject.h: +* rendering/TextAutoSizing.cpp: +(WebCore::TextAutoSizingValue::adjustNodeSizes): +(WebCore::TextAutoSizingValue::reset): + 2016-05-09 Anders Carlsson Add injected bundle SPI for getting favicon and touch icon URLs Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (200592 => 200593) --- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2016-05-09 21:53:43 UTC (rev 200592) +++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2016-05-09 21:57:43 UTC (rev 200593) @@ -3739,12 +3739,12 @@ return count; } -static bool isNonBlocksOrNonFixedHeightListItems(const RenderObject* render) +static bool isNonBlocksOrNonFixedHeightListItems(const RenderObject& render) { -if (!render->isRenderBlock()) +if (!render.isRenderBlock()) return true; -if (render->isListItem()) -return render->style().height().type() != Fixed; +if (render.isListItem()) +return render.style().height().type() != Fixed; return false; } @@ -3790,7 +3790,7 @@ for (RenderObject* descendent = traverseNext(this, isNonBlocksOrNonFixedHeightListItems); descendent; descendent = descendent->traverseNext(this, isNonBlocksOrNonFixedHeightListItems)) { if (isVisibleRenderText(descendent) && resizeTextPermitted(descendent)) { -RenderText& text = downcast(*descendent); +auto& text = downcast(*descendent); auto& oldStyle = text.style(); auto fontDescription = oldStyle.fontDescription(); float specifiedSize = fontDescription.specifiedSize(); Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (200592 => 200593) --- trunk/Source/WebCore/rendering/RenderElement.cpp 2016-05-09 21:53:43 UTC (rev 200592) +++ trunk/Source/WebCore/rendering/RenderElement.cpp 2016-05-09 21:57:43 UTC (rev 200593) @@ -2169,15 +2169,15 @@ } #if ENABLE(IOS_TEXT_AUTOSIZING) -static RenderObject::BlockContentHeightType includeNonFixedHeight(const RenderObject* renderer) +static RenderObject::BlockContentHeightType includeNonFixedHeight(const RenderObject& renderer) { -const RenderStyle& style = renderer->style(); +const RenderStyle& style = renderer.style(); if (style.height().type() == Fixed) { -if (is(*renderer)) { +if (is(renderer)) { // For fixed height styles, if the overflow size of the element spills out of the specified // height, assume we can apply text auto-sizing. if (style.overflowY() == OVISIBLE -&& style.height().value() < downcast(renderer)->layoutOverflowRect().maxY()) +&& style.height().value() < downcast(renderer).layoutOverflowRect().maxY()) return RenderObject::OverflowHeight; } return RenderObject::FixedHeight; Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (200592 => 200593) --- trunk/Source/WebCore/rendering/RenderObject.cpp 2016-05-09 21:53:43 UTC (rev 200592) +++ trunk/Sourc
[webkit-changes] [200592] trunk/Source/WebKit2
Title: [200592] trunk/Source/WebKit2 Revision 200592 Author adac...@apple.com Date 2016-05-09 14:53:43 -0700 (Mon, 09 May 2016) Log Message Add WKPageRef SPI to tell whether there's a video playing in enhanced fullscreen https://bugs.webkit.org/show_bug.cgi?id=157434 Reviewed by Darin Adler. * UIProcess/API/C/mac/WKPagePrivateMac.h: * UIProcess/API/C/mac/WKPagePrivateMac.mm: (WKPageIsPlayingVideoInEnhancedFullscreen): * UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h: * UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm: (WebKit::WebVideoFullscreenManagerProxy::isPlayingVideoInEnhancedFullscreen): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::isPlayingVideoInEnhancedFullscreen): * UIProcess/WebPageProxy.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.mm trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.h Diff Modified: trunk/Source/WebKit2/ChangeLog (200591 => 200592) --- trunk/Source/WebKit2/ChangeLog 2016-05-09 20:41:31 UTC (rev 200591) +++ trunk/Source/WebKit2/ChangeLog 2016-05-09 21:53:43 UTC (rev 200592) @@ -1,3 +1,20 @@ +2016-05-06 Ada Chan + +Add WKPageRef SPI to tell whether there's a video playing in enhanced fullscreen +https://bugs.webkit.org/show_bug.cgi?id=157434 + +Reviewed by Darin Adler. + +* UIProcess/API/C/mac/WKPagePrivateMac.h: +* UIProcess/API/C/mac/WKPagePrivateMac.mm: +(WKPageIsPlayingVideoInEnhancedFullscreen): +* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h: +* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm: +(WebKit::WebVideoFullscreenManagerProxy::isPlayingVideoInEnhancedFullscreen): +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::isPlayingVideoInEnhancedFullscreen): +* UIProcess/WebPageProxy.h: + 2016-05-09 Anders Carlsson Add injected bundle SPI for getting favicon and touch icon URLs Modified: trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h (200591 => 200592) --- trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h 2016-05-09 20:41:31 UTC (rev 200591) +++ trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h 2016-05-09 21:53:43 UTC (rev 200592) @@ -59,6 +59,10 @@ WK_EXPORT pid_t WKPageGetProcessIdentifier(WKPageRef page); WK_EXPORT bool WKPageIsURLKnownHSTSHost(WKPageRef page, WKURLRef url); +#if TARGET_OS_MAC +WK_EXPORT bool WKPageIsPlayingVideoInEnhancedFullscreen(WKPageRef page); +#endif + #ifdef __cplusplus } #endif Modified: trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.mm (200591 => 200592) --- trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.mm 2016-05-09 20:41:31 UTC (rev 200591) +++ trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.mm 2016-05-09 21:53:43 UTC (rev 200592) @@ -128,3 +128,10 @@ return webPageProxy->process().processPool().isURLKnownHSTSHost(toImpl(url)->string(), privateBrowsingEnabled); } + +#if PLATFORM(MAC) +bool WKPageIsPlayingVideoInEnhancedFullscreen(WKPageRef pageRef) +{ +return toImpl(pageRef)->isPlayingVideoInEnhancedFullscreen(); +} +#endif Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h (200591 => 200592) --- trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h 2016-05-09 20:41:31 UTC (rev 200591) +++ trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h 2016-05-09 21:53:43 UTC (rev 200592) @@ -106,6 +106,10 @@ void applicationDidBecomeActive(); bool isVisible() const; +#if PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE) +bool isPlayingVideoInEnhancedFullscreen() const; +#endif + private: friend class WebVideoFullscreenModelContext; Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm (200591 => 200592) --- trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm 2016-05-09 20:41:31 UTC (rev 200591) +++ trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm 2016-05-09 21:53:43 UTC (rev 200592) @@ -247,6 +247,17 @@ return false; } +#if PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE) +bool WebVideoFullscreenManagerProxy::isPlayingVideoInEnhancedFullscreen() const +{ +#if USE(APPLE_INTERNAL_SDK) +#import +#else +return false; +#endif +} +#endif + void WebVideoFullscreenManagerProxy::applicationDidBecomeActive() { for (auto& tuple : m_contextMap.values()) Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (200591 => 200592) --- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2016-05-09 20:41:31 UTC (rev 200591) +++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2016-05-09 21:53:43 UTC (rev 200592) @@ -6068,7 +6068,16 @@ return false;
[webkit-changes] [200591] trunk/Source
Title: [200591] trunk/Source Revision 200591 Author ander...@apple.com Date 2016-05-09 13:41:31 -0700 (Mon, 09 May 2016) Log Message Add injected bundle SPI for getting favicon and touch icon URLs https://bugs.webkit.org/show_bug.cgi?id=157435 Reviewed by Darin Adler. Source/WebCore: * CMakeLists.txt: Add new files. * WebCore.xcodeproj/project.pbxproj: Add new files. * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::iconType): * html/HTMLLinkElement.h: Rename LinkRelAttribute::IconType to LinkIconType. * html/LinkIconCollector.cpp: Added. (WebCore::iconSize): New helper function that returns the icon size for an icon. (WebCore::compareIcons): Icon comparison function, to be used by for sorting. (LinkIconCollector::iconsOfTypes): Gather the right icons, sort them (descending by size) and return them. * html/LinkIconCollector.h: Added. * html/LinkIconType.h: Move icon type declarations here and arrange them so we can use them in an OptionSet. * html/LinkRelAttribute.cpp: (WebCore::LinkRelAttribute::LinkRelAttribute): * html/LinkRelAttribute.h: * loader/icon/IconController.cpp: (WebCore::iconFromLinkElements): Rename IconType to LinkIconType. Source/WebKit2: * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h: * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm: (collectIcons): New helper function that calls into the WebCore LinkCollector. (-[WKWebProcessPlugInFrame appleTouchIconURLs]): Call collectIcons. (-[WKWebProcessPlugInFrame faviconURLs]): Ditto. Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/html/HTMLLinkElement.cpp trunk/Source/WebCore/html/HTMLLinkElement.h trunk/Source/WebCore/html/LinkRelAttribute.cpp trunk/Source/WebCore/html/LinkRelAttribute.h trunk/Source/WebCore/loader/icon/IconController.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm Added Paths trunk/Source/WebCore/html/LinkIconCollector.cpp trunk/Source/WebCore/html/LinkIconCollector.h trunk/Source/WebCore/html/LinkIconType.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (200590 => 200591) --- trunk/Source/WebCore/CMakeLists.txt 2016-05-09 20:22:58 UTC (rev 200590) +++ trunk/Source/WebCore/CMakeLists.txt 2016-05-09 20:41:31 UTC (rev 200591) @@ -1736,6 +1736,7 @@ html/InputTypeNames.cpp html/LabelableElement.cpp html/LabelsNodeList.cpp +html/LinkIconCollector.cpp html/LinkRelAttribute.cpp html/MediaController.cpp html/MediaDocument.cpp Modified: trunk/Source/WebCore/ChangeLog (200590 => 200591) --- trunk/Source/WebCore/ChangeLog 2016-05-09 20:22:58 UTC (rev 200590) +++ trunk/Source/WebCore/ChangeLog 2016-05-09 20:41:31 UTC (rev 200591) @@ -1,3 +1,44 @@ +2016-05-09 Anders Carlsson + +Add injected bundle SPI for getting favicon and touch icon URLs +https://bugs.webkit.org/show_bug.cgi?id=157435 + +Reviewed by Darin Adler. + +* CMakeLists.txt: +Add new files. + +* WebCore.xcodeproj/project.pbxproj: +Add new files. + +* html/HTMLLinkElement.cpp: +(WebCore::HTMLLinkElement::iconType): +* html/HTMLLinkElement.h: +Rename LinkRelAttribute::IconType to LinkIconType. + +* html/LinkIconCollector.cpp: Added. +(WebCore::iconSize): +New helper function that returns the icon size for an icon. + +(WebCore::compareIcons): +Icon comparison function, to be used by for sorting. + +(LinkIconCollector::iconsOfTypes): +Gather the right icons, sort them (descending by size) and return them. + +* html/LinkIconCollector.h: +Added. + +* html/LinkIconType.h: +Move icon type declarations here and arrange them so we can use them in an OptionSet. + +* html/LinkRelAttribute.cpp: +(WebCore::LinkRelAttribute::LinkRelAttribute): +* html/LinkRelAttribute.h: +* loader/icon/IconController.cpp: +(WebCore::iconFromLinkElements): +Rename IconType to LinkIconType. + 2016-05-06 Simon Fraser [iOS WK2] Font size increases on some pages after navigating then going back Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (200590 => 200591) --- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2016-05-09 20:22:58 UTC (rev 200590) +++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2016-05-09 20:41:31 UTC (rev 200591) @@ -696,6 +696,7 @@ 1A22464C0CC98DDB00C05240 /* SQLiteStatement.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A2246460CC98DDB00C05240 /* SQLiteStatement.h */; settings = {ATTRIBUTES = (Private, ); }; }; 1A22464D0CC98DDB00C05240 /* SQLiteTransaction.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A2246470CC98DDB00C05240 /* SQLiteT
[webkit-changes] [200590] trunk
Title: [200590] trunk Revision 200590 Author simon.fra...@apple.com Date 2016-05-09 13:22:58 -0700 (Mon, 09 May 2016) Log Message Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it https://bugs.webkit.org/show_bug.cgi?id=157480 Reviewed by Zalan Bujtas. Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled() and move it next to the other iOS text autosizing tests. Tools: Remove testRunner.setTextAutosizingEnabled(), which was only implemented in DumpRenderTree. * DumpRenderTree/TestRunner.cpp: (setTextAutosizingEnabledCallback): Deleted. (TestRunner::staticFunctions): Deleted. * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setTextAutosizingEnabled): Deleted. LayoutTests: * fast/text-autosizing/ios/textarea-auto-sizing-disable-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable-expected.txt. * fast/text-autosizing/ios/textarea-auto-sizing-disable.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable.html. * platform/ios-simulator/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-simulator/TestExpectations trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/TestRunner.cpp trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm Added Paths trunk/LayoutTests/fast/text-autosizing/ios/textarea-auto-sizing-disable-expected.txt trunk/LayoutTests/fast/text-autosizing/ios/textarea-auto-sizing-disable.html Removed Paths trunk/LayoutTests/platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable-expected.txt trunk/LayoutTests/platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable.html Diff Modified: trunk/LayoutTests/ChangeLog (200589 => 200590) --- trunk/LayoutTests/ChangeLog 2016-05-09 20:22:54 UTC (rev 200589) +++ trunk/LayoutTests/ChangeLog 2016-05-09 20:22:58 UTC (rev 200590) @@ -1,5 +1,19 @@ 2016-05-09 Simon Fraser +Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it +https://bugs.webkit.org/show_bug.cgi?id=157480 + +Reviewed by Zalan Bujtas. + +Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled() +and move it next to the other iOS text autosizing tests. + +* fast/text-autosizing/ios/textarea-auto-sizing-disable-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable-expected.txt. +* fast/text-autosizing/ios/textarea-auto-sizing-disable.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable.html. +* platform/ios-simulator/TestExpectations: + +2016-05-09 Simon Fraser + Upstream some iOS text autosizing tests. * fast/text-autosizing/ios/anonymous-block.html: Added. Copied: trunk/LayoutTests/fast/text-autosizing/ios/textarea-auto-sizing-disable-expected.txt (from rev 200589, trunk/LayoutTests/platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable-expected.txt) (0 => 200590) --- trunk/LayoutTests/fast/text-autosizing/ios/textarea-auto-sizing-disable-expected.txt (rev 0) +++ trunk/LayoutTests/fast/text-autosizing/ios/textarea-auto-sizing-disable-expected.txt 2016-05-09 20:22:58 UTC (rev 200590) @@ -0,0 +1,2 @@ + +SUCCESS Copied: trunk/LayoutTests/fast/text-autosizing/ios/textarea-auto-sizing-disable.html (from rev 200589, trunk/LayoutTests/platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable.html) (0 => 200590) --- trunk/LayoutTests/fast/text-autosizing/ios/textarea-auto-sizing-disable.html (rev 0) +++ trunk/LayoutTests/fast/text-autosizing/ios/textarea-auto-sizing-disable.html 2016-05-09 20:22:58 UTC (rev 200590) @@ -0,0 +1,55 @@ + + +TextArea auto-sizing test + + +if (window.testRunner) +window.testRunner.waitUntilDone(); + +function doTest() +{ +if (!window.testRunner) +return; + +if (!window.eventSender) +return; + +window.internals.settings.setTextAutosizingEnabled(true); +window.internals.settings.setTextAutosizingWindowSizeOverride(320, 480); + +var obj = document.getElementById('test'); +var oldHeight = obj.offsetHeight; + +eventSender.mouseMoveTo(obj.offsetLeft+10, obj.offsetTop+20); +eventSender.mouseDown(); +eventSender.mouseUp(); + +eventSender.keyDown("\n") +eventSender.keyDown('A'); +eventSender.keyDown('B'); +eventSender.keyDown('\n'); + +// Textarea height shouldn't change after we add new lines. +document.getElementById("result").innerHTML= obj.offset
[webkit-changes] [200588] trunk
Title: [200588] trunk Revision 200588 Author simon.fra...@apple.com Date 2016-05-09 13:22:47 -0700 (Mon, 09 May 2016) Log Message [iOS WK2] Font size increases on some pages after navigating then going back https://bugs.webkit.org/show_bug.cgi?id=157441 rdar://problem/22873240 Reviewed by Darin Adler. Source/WebCore: Sometimes I want to dump ViewportConfigurations from WebKit2 so export dump(). Test: fast/text-autosizing/ios/text-autosizing-after-back.html * page/ViewportConfiguration.h: Source/WebKit2: There's an ordering dependency between setting the viewport configuration and doing layouts when going back to a page from the page cache that is incorrectly handled. In FrameLoader::commitProvisionalLoad(), CachedPage::restore() triggers a layout under updateContentsSize(), but this happens before dispatchDidCommitLoad() which updates the viewport arguments via ViewportConfiguration::setViewportArguments(). This issue is not addressed by the current commit. But a second problem is: if the inputs to text autosizing change, we need to invalidate the autosizing state. The relevant input here is the fixed layout width (which is determined from the viewport configuration). The current code invalidated text autosizing when m_viewportConfiguration.minimumLayoutSize() changed, but the correct behavior is to invalidate based on fixed layout size changing. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::sendViewportAttributesChanged): (WebKit::WebPage::setFixedLayoutSize): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::resetTextAutosizing): (WebKit::WebPage::dynamicViewportSizeUpdate): (WebKit::WebPage::viewportConfigurationChanged): (WebKit::WebPage::setViewportConfigurationMinimumLayoutSize): Deleted. (WebKit::WebPage::resetTextAutosizingBeforeLayoutIfNeeded): Deleted. LayoutTests: * fast/text-autosizing/ios/text-autosizing-after-back-expected.html: Added. * fast/text-autosizing/ios/text-autosizing-after-back.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/ViewportConfiguration.h trunk/Source/WebCore/rendering/RenderElement.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm Added Paths trunk/LayoutTests/fast/text-autosizing/ios/text-autosizing-after-back-expected.html trunk/LayoutTests/fast/text-autosizing/ios/text-autosizing-after-back.html Diff Modified: trunk/LayoutTests/ChangeLog (200587 => 200588) --- trunk/LayoutTests/ChangeLog 2016-05-09 20:18:15 UTC (rev 200587) +++ trunk/LayoutTests/ChangeLog 2016-05-09 20:22:47 UTC (rev 200588) @@ -1,3 +1,14 @@ +2016-05-06 Simon Fraser + +[iOS WK2] Font size increases on some pages after navigating then going back +https://bugs.webkit.org/show_bug.cgi?id=157441 +rdar://problem/22873240 + +Reviewed by Darin Adler. + +* fast/text-autosizing/ios/text-autosizing-after-back-expected.html: Added. +* fast/text-autosizing/ios/text-autosizing-after-back.html: Added. + 2016-05-09 Ryan Haddad Rebaseline failing LayoutTests after r200580 Added: trunk/LayoutTests/fast/text-autosizing/ios/text-autosizing-after-back-expected.html (0 => 200588) --- trunk/LayoutTests/fast/text-autosizing/ios/text-autosizing-after-back-expected.html (rev 0) +++ trunk/LayoutTests/fast/text-autosizing/ios/text-autosizing-after-back-expected.html 2016-05-09 20:22:47 UTC (rev 200588) @@ -0,0 +1,19 @@ + + + + + + +if (window.internals) { +window.internals.settings.setTextAutosizingEnabled(true); +window.internals.settings.setTextAutosizingWindowSizeOverride(320, 480); +} + + + +Anchor to another page + +Lorem ipsum dolor sit amet, consectetur adipisicing elit. + + + Added: trunk/LayoutTests/fast/text-autosizing/ios/text-autosizing-after-back.html (0 => 200588) --- trunk/LayoutTests/fast/text-autosizing/ios/text-autosizing-after-back.html (rev 0) +++ trunk/LayoutTests/fast/text-autosizing/ios/text-autosizing-after-back.html 2016-05-09 20:22:47 UTC (rev 200588) @@ -0,0 +1,54 @@ + + + + + + +function navigateAwayAndBack() +{ +// Simulate a link click to create a history entry +var evt = new MouseEvent("click", { +bubbles: true, +cancelable: true, +view: window +}); +document.getElementById('anchor').dispatchEvent(evt); +} + +function runTest() +{ +if (window.testRunner) { +testRunner.waitUntilDone(); +testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1); +} + +if (window.internals) { +window.internals.settings.setTextAutosizingEnabled(true); +
[webkit-changes] [200589] trunk/LayoutTests
Title: [200589] trunk/LayoutTests Revision 200589 Author simon.fra...@apple.com Date 2016-05-09 13:22:54 -0700 (Mon, 09 May 2016) Log Message Upstream some iOS text autosizing tests. * fast/text-autosizing/ios/anonymous-block.html: Added. * fast/text-autosizing/ios/contenteditable.html: Added. * fast/text-autosizing/ios/first-letter.html: Added. * fast/text-autosizing/ios/font-family-case-insensitive-expected.txt: Added. * fast/text-autosizing/ios/font-family-case-insensitive.html: Added. * fast/text-autosizing/ios/lists.html: Added. * fast/text-autosizing/ios/overflow.html: Added. * fast/text-autosizing/ios/percent-adjust-length-line-height-expected.txt: Added. * fast/text-autosizing/ios/percent-adjust-length-line-height.html: Added. * fast/text-autosizing/ios/percent-adjust-number-line-height-expected.txt: Added. * fast/text-autosizing/ios/percent-adjust-number-line-height.html: Added. * fast/text-autosizing/ios/percent-adjust-percent-line-height-expected.txt: Added. * fast/text-autosizing/ios/percent-adjust-percent-line-height.html: Added. * platform/ios-simulator/fast/text-autosizing/ios/anonymous-block-expected.txt: Added. * platform/ios-simulator/fast/text-autosizing/ios/contenteditable-expected.txt: Added. * platform/ios-simulator/fast/text-autosizing/ios/first-letter-expected.txt: Added. * platform/ios-simulator/fast/text-autosizing/ios/lists-expected.txt: Added. * platform/ios-simulator/fast/text-autosizing/ios/overflow-expected.txt: Added. * platform/mac/fast/text-autosizing/ios/anonymous-block-expected.txt: Added. * platform/mac/fast/text-autosizing/ios/contenteditable-expected.txt: Added. * platform/mac/fast/text-autosizing/ios/first-letter-expected.txt: Added. * platform/mac/fast/text-autosizing/ios/lists-expected.txt: Added. * platform/mac/fast/text-autosizing/ios/overflow-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/fast/text-autosizing/ios/anonymous-block.html trunk/LayoutTests/fast/text-autosizing/ios/contenteditable.html trunk/LayoutTests/fast/text-autosizing/ios/first-letter.html trunk/LayoutTests/fast/text-autosizing/ios/font-family-case-insensitive-expected.txt trunk/LayoutTests/fast/text-autosizing/ios/font-family-case-insensitive.html trunk/LayoutTests/fast/text-autosizing/ios/lists.html trunk/LayoutTests/fast/text-autosizing/ios/overflow.html trunk/LayoutTests/fast/text-autosizing/ios/percent-adjust-length-line-height-expected.txt trunk/LayoutTests/fast/text-autosizing/ios/percent-adjust-length-line-height.html trunk/LayoutTests/fast/text-autosizing/ios/percent-adjust-number-line-height-expected.txt trunk/LayoutTests/fast/text-autosizing/ios/percent-adjust-number-line-height.html trunk/LayoutTests/fast/text-autosizing/ios/percent-adjust-percent-line-height-expected.txt trunk/LayoutTests/fast/text-autosizing/ios/percent-adjust-percent-line-height.html trunk/LayoutTests/platform/ios-simulator/fast/text-autosizing/ trunk/LayoutTests/platform/ios-simulator/fast/text-autosizing/ios/ trunk/LayoutTests/platform/ios-simulator/fast/text-autosizing/ios/anonymous-block-expected.txt trunk/LayoutTests/platform/ios-simulator/fast/text-autosizing/ios/contenteditable-expected.txt trunk/LayoutTests/platform/ios-simulator/fast/text-autosizing/ios/first-letter-expected.txt trunk/LayoutTests/platform/ios-simulator/fast/text-autosizing/ios/lists-expected.txt trunk/LayoutTests/platform/ios-simulator/fast/text-autosizing/ios/overflow-expected.txt trunk/LayoutTests/platform/mac/fast/text-autosizing/ios/anonymous-block-expected.txt trunk/LayoutTests/platform/mac/fast/text-autosizing/ios/contenteditable-expected.txt trunk/LayoutTests/platform/mac/fast/text-autosizing/ios/first-letter-expected.txt trunk/LayoutTests/platform/mac/fast/text-autosizing/ios/lists-expected.txt trunk/LayoutTests/platform/mac/fast/text-autosizing/ios/overflow-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (200588 => 200589) --- trunk/LayoutTests/ChangeLog 2016-05-09 20:22:47 UTC (rev 200588) +++ trunk/LayoutTests/ChangeLog 2016-05-09 20:22:54 UTC (rev 200589) @@ -1,3 +1,31 @@ +2016-05-09 Simon Fraser + +Upstream some iOS text autosizing tests. + +* fast/text-autosizing/ios/anonymous-block.html: Added. +* fast/text-autosizing/ios/contenteditable.html: Added. +* fast/text-autosizing/ios/first-letter.html: Added. +* fast/text-autosizing/ios/font-family-case-insensitive-expected.txt: Added. +* fast/text-autosizing/ios/font-family-case-insensitive.html: Added. +* fast/text-autosizing/ios/lists.html: Added. +* fast/text-autosizing/ios/overflow.html: Added. +* fast/text-autosizing/ios/percent-adjust-length-line-height-expected.txt: Added. +* fast/text-autosizing/ios/percent-adjust-length-line-height.html: Added. +* fast/text-autosizing/ios/percent-adjust-number-line-height-expected.txt: Added. +* fast/text-autosizing/ios/percent-adjust-number-line-height.html: Adde
[webkit-changes] [200587] trunk/Source/WebCore
Title: [200587] trunk/Source/WebCore Revision 200587 Author eric.carl...@apple.com Date 2016-05-09 13:18:15 -0700 (Mon, 09 May 2016) Log Message "Main content" restrictions should not apply to media documents https://bugs.webkit.org/show_bug.cgi?id=157479 Reviewed by Jer Noble. No new tests, this change only applies to media documents in a top level document so it isn't possible to have a layout test. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Don't apply restrictions to a media document. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (200586 => 200587) --- trunk/Source/WebCore/ChangeLog 2016-05-09 20:17:23 UTC (rev 200586) +++ trunk/Source/WebCore/ChangeLog 2016-05-09 20:18:15 UTC (rev 200587) @@ -1,3 +1,17 @@ +2016-05-09 Eric Carlson + +"Main content" restrictions should not apply to media documents +https://bugs.webkit.org/show_bug.cgi?id=157479 + + +Reviewed by Jer Noble. + +No new tests, this change only applies to media documents in a top level document so it +isn't possible to have a layout test. + +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::HTMLMediaElement): Don't apply restrictions to a media document. + 2016-05-09 Dean Jackson Update Picture-in-picture artwork Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (200586 => 200587) --- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2016-05-09 20:17:23 UTC (rev 200586) +++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2016-05-09 20:18:15 UTC (rev 200587) @@ -461,23 +461,26 @@ m_mediaSession->removeBehaviorRestriction(MediaElementSession::RequireUserGestureForFullscreen); } #endif + if (settings && settings->invisibleAutoplayNotPermitted()) m_mediaSession->addBehaviorRestriction(MediaElementSession::InvisibleAutoplayNotPermitted); -if (settings && settings->audioPlaybackRequiresUserGesture()) -m_mediaSession->addBehaviorRestriction(MediaElementSession::RequireUserGestureForAudioRateChange); +if (document.ownerElement() || !document.isMediaDocument()) { +if (settings && settings->audioPlaybackRequiresUserGesture()) +m_mediaSession->addBehaviorRestriction(MediaElementSession::RequireUserGestureForAudioRateChange); -if (!settings || !settings->mediaDataLoadsAutomatically()) -m_mediaSession->addBehaviorRestriction(MediaElementSession::AutoPreloadingNotPermitted); +if (!settings || !settings->mediaDataLoadsAutomatically()) +m_mediaSession->addBehaviorRestriction(MediaElementSession::AutoPreloadingNotPermitted); +if (settings && settings->mainContentUserGestureOverrideEnabled()) +m_mediaSession->addBehaviorRestriction(MediaElementSession::OverrideUserGestureRequirementForMainContent); +} + #if ENABLE(VIDEO_TRACK) if (document.page()) m_captionDisplayMode = document.page()->group().captionPreferences().captionDisplayMode(); #endif -if (settings && settings->mainContentUserGestureOverrideEnabled()) -m_mediaSession->addBehaviorRestriction(MediaElementSession::OverrideUserGestureRequirementForMainContent); - #if ENABLE(MEDIA_SESSION) m_elementID = nextElementID(); elementIDsToElements().add(m_elementID, this); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200585] trunk/LayoutTests
Title: [200585] trunk/LayoutTests Revision 200585 Author ryanhad...@apple.com Date 2016-05-09 13:10:59 -0700 (Mon, 09 May 2016) Log Message Rebaseline failing LayoutTests after r200580 Unreviewed test gardening. * fast/xmlhttprequest/xmlhttprequest-get-expected.txt: * http/tests/workers/worker-importScriptsOnError-expected.txt: * inspector/model/remote-object-get-properties-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt trunk/LayoutTests/http/tests/workers/worker-importScriptsOnError-expected.txt trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (200584 => 200585) --- trunk/LayoutTests/ChangeLog 2016-05-09 20:07:21 UTC (rev 200584) +++ trunk/LayoutTests/ChangeLog 2016-05-09 20:10:59 UTC (rev 200585) @@ -1,3 +1,13 @@ +2016-05-09 Ryan Haddad + +Rebaseline failing LayoutTests after r200580 + +Unreviewed test gardening. + +* fast/xmlhttprequest/xmlhttprequest-get-expected.txt: +* http/tests/workers/worker-importScriptsOnError-expected.txt: +* inspector/model/remote-object-get-properties-expected.txt: + 2016-05-09 Chris Dumez Optimize [StrictTypeChecking] on IDL operations Modified: trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt (200584 => 200585) --- trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt 2016-05-09 20:07:21 UTC (rev 200584) +++ trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt 2016-05-09 20:10:59 UTC (rev 200585) @@ -47,10 +47,10 @@ cancelBubble : 'false' cancelable : 'false' clipboardData : 'undefined' -currentTarget : '[object XMLHttpRequest]' -deepPath : 'function deepPath() { +composedPath : 'function composedPath() { [native code] }' +currentTarget : '[object XMLHttpRequest]' defaultPrevented : 'false' eventPhase : '2' initEvent : 'function initEvent() { Modified: trunk/LayoutTests/http/tests/workers/worker-importScriptsOnError-expected.txt (200584 => 200585) --- trunk/LayoutTests/http/tests/workers/worker-importScriptsOnError-expected.txt 2016-05-09 20:07:21 UTC (rev 200584) +++ trunk/LayoutTests/http/tests/workers/worker-importScriptsOnError-expected.txt 2016-05-09 20:10:59 UTC (rev 200585) @@ -27,8 +27,8 @@ cancelable: true, clipboardData: undefined, colno: 14, +composedPath: function composedPath() { [native code] }, currentTarget: [object Worker], -deepPath: function deepPath() { [native code] }, defaultPrevented: false, eventPhase: 2, filename: http://127.0.0.1:8000/workers/resources/worker-importScripts-error.js, Modified: trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt (200584 => 200585) --- trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt 2016-05-09 20:07:21 UTC (rev 200584) +++ trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt 2016-05-09 20:10:59 UTC (rev 200585) @@ -75,7 +75,7 @@ returnValue cancelBubble clipboardData -deepPath +composedPath stopPropagation preventDefault initEvent ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200584] trunk/Source/WebCore
Title: [200584] trunk/Source/WebCore Revision 200584 Author d...@apple.com Date 2016-05-09 13:07:21 -0700 (Mon, 09 May 2016) Log Message Update Picture-in-picture artwork https://bugs.webkit.org/show_bug.cgi?id=157484 Reviewed by Eric Carlson. We have new artwork for the picture-in-picture presentation mode. I also converted it to use SVG (and moved the button style to a more consistent part of the file). * Modules/mediacontrols/mediaControlsApple.css: (video::-webkit-media-controls-panel .picture-in-picture-button): (video::-webkit-media-controls-panel .picture-in-picture-button.return-from-picture-in-picture): (video::-webkit-media-controls-panel .picture-in-picture-button:active): (video::-webkit-media-controls-panel .picture-in-picture-button.return-from-picture-in-picture:active): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css Diff Modified: trunk/Source/WebCore/ChangeLog (200583 => 200584) --- trunk/Source/WebCore/ChangeLog 2016-05-09 19:46:35 UTC (rev 200583) +++ trunk/Source/WebCore/ChangeLog 2016-05-09 20:07:21 UTC (rev 200584) @@ -1,3 +1,21 @@ +2016-05-09 Dean Jackson + +Update Picture-in-picture artwork +https://bugs.webkit.org/show_bug.cgi?id=157484 + + +Reviewed by Eric Carlson. + +We have new artwork for the picture-in-picture presentation mode. I +also converted it to use SVG (and moved the button style to a +more consistent part of the file). + +* Modules/mediacontrols/mediaControlsApple.css: +(video::-webkit-media-controls-panel .picture-in-picture-button): +(video::-webkit-media-controls-panel .picture-in-picture-button.return-from-picture-in-picture): +(video::-webkit-media-controls-panel .picture-in-picture-button:active): +(video::-webkit-media-controls-panel .picture-in-picture-button.return-from-picture-in-picture:active): + 2016-05-09 Chris Dumez Optimize [StrictTypeChecking] on IDL operations Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css (200583 => 200584) --- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css 2016-05-09 19:46:35 UTC (rev 200583) +++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css 2016-05-09 20:07:21 UTC (rev 200584) @@ -480,6 +480,21 @@ content: url('data:image/svg+xml,'); } +video::-webkit-media-controls-panel .picture-in-picture-button { +margin-right: 7px; +margin-left: 8px; +margin-top: 1px; +width: 16px; +min-width: 18px; +height: 12px; + +background-image: url('data:image/svg+xml,'); +} + +video::-webkit-media-controls-panel .picture-in-picture-button.return-from-picture-in-picture { +background-image: url('data:image/svg+xml,'); +} + video::-webkit-media-controls-fullscreen-button, audio::-webkit-media-controls-fullscreen-button { background-image: url('data:image/svg+xml,'); @@ -1002,6 +1017,14 @@ background-image: url('data:image/svg+xml, '); } +video::-webkit-media-controls-panel .picture-in-picture-button:active { +background-image: url('data:image/svg+xml,'); +} + +video::-webkit-media-controls-panel .picture-in-picture-button.return-from-picture-in-picture:active { +background-image: url('data:image/svg+xml,'); +} + /* AIRPLAY PLACARD */ video::-webkit-media-controls-wireless-playback-status, @@ -1102,23 +1125,6 @@ display: none; } -video::-webkit-media-controls-panel .picture-in-picture-button { -margin-right: 7px; -margin-left: 8px; -margin-top: 1px; -width: 18px; -min-width: 18px; -height: 14px; - -background-color: rgba(255,255,255,0.45); --webkit-mask-size: 18px 14px; --webkit-mask-image: url('data:image/png;base64,iVBORw0KGgoNSUhEUgAAAC4kCAYAAAD2IghRGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPNhJREFUeNrslzEOwjAMRR2UA3AQ7sLKwsTEglg6sTIgLgs7qCZBRbIsWpDayHH1v/SHJmn0ZFutHYiIqX4F+cDMtCCncgseh1JiLJ5lxH+Br2qGZ2Gpa/IjeVMZ1/ur0ndgLdaeydsvF9/7LrYEz7oo+J0X8Kyz2GuT917As04K/uAFPKtR5xov4FnHLuIy+i7AqavxVr1jAh7H/HbRZE3QZGndBvaW1k1Z6VqdHtjzIBELZrHoKIfRzbpUxqY4IOJzLpWAiAMc4AAHOMAB/m9T9Bn1veklwACtBYmnlYBaIQBJRU5ErkJggg=='); -} - -video::-webkit-media-controls-panel .picture-in-picture-button.return-from-picture-in-picture { --webkit-mask-image: url('data:image/png;base64,iVBORw0KGgoNSUhEUgAAAC4kCAYAAAD2IghRGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPOZJREFUeNpiZGBg+M8w+AEjMuf///8MTAxDFAxZh7Pgi5IBBv+HZYgPS4f/JwJ/GA1xCjMnIfAejf9poHPvfyy5GFvS6KdjyYPLXeAKiFiH/0ZiT6GT46ni8CAg/onEn0WH/EEVh4OAL5rjFwIx81BwOAh4APE3JPGlNHQ8VR0OAs5A/BVJbjUQsw0Fh4OAHRB/RpLPG0wOJwSsoTXnfBolF5o5HARUBqL2pYbDB6bGBDqchYYlAk27cqPt8YFuHVIaxYyjIT6ckwrjaIiPOnzU4aMOH3X4qMNHHU5sowjWmxhqACDAAI3lmdvpn4aTAElFTkSuQmCC'); -} - video::-webkit-media-controls-panel.picture-in-picture { opacity: 0; pointer-events: none; __
[webkit-changes] [200583] trunk
Title: [200583] trunk Revision 200583 Author cdu...@apple.com Date 2016-05-09 12:46:35 -0700 (Mon, 09 May 2016) Log Message Optimize [StrictTypeChecking] on IDL operations https://bugs.webkit.org/show_bug.cgi?id=157467 Reviewed by Darin Adler. Source/WebCore: Optimize [StrictTypeChecking] on IDL operations so that: - Only generate extra code for nullable parameters because for non-nullable parameters, JSXXX::toWrapped() will return null in case of a bad input type. We will then throw a TypeError when null-checking it already. - After the JSValue::isNullOrUndefined() check, avoid calling JSXXX::toWrapped() and set nativeValue to nullptr directly. - Drop the check for JSValue::inherits(JSXXX::info()) and just do a null check on the value returned by JSXXX::toWrapped(). toWrapped() already does a JSValue::inherits(JSXXX::info() check. Since we only call toWrapped() if the JSValue is not null/undefined, a null return value always indicates a bad input type. Also update the TypeError message to be more useful when passing null for non-nullable parameters or assigning null to a non-nullable attribute. The message is now consistent with the one used for strict type checking. No new tests, rebaselined existing tests. * bindings/js/JSDOMBinding.h: * bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): (GenerateParametersCheck): * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: (WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction): * bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::setJSTestInterfaceImplementsNode): (WebCore::setJSTestInterfaceSupplementalNode): (WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2): (WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2): * bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::setJSTestObjTestObjAttr): (WebCore::setJSTestObjLenientTestObjAttr): (WebCore::setJSTestObjXMLObjAttr): (WebCore::setJSTestObjTypedArrayAttr): (WebCore::setJSTestObjWithScriptExecutionContextAttribute): (WebCore::setJSTestObjWithScriptStateAttributeRaises): (WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises): (WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute): (WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises): (WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute): (WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute): (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionByteMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionOctetMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionMethodWithXPathNSResolverParameter): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod8): (WebCore::jsTestObjPrototypeFunctionDomStringListFunction): (WebCore::jsTestObjPrototypeFunctionConvert1): (WebCore::jsTestObjPrototypeFunctionStrictFunctionWithSequence): (WebCore::jsTestObjPrototypeFunctionStrictFunctionWithArray): (WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod): (WebCore::jsTestObjPrototypeFunctionTestPromiseOverloadedFunction2Promise): * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: (WebCore::constructJSTestOverloadedConstructors1): (WebCore::constructJSTestOverloadedConstructors2): (WebCore::constructJSTestOverloadedConstructors3): * bindings/scripts/test/TestObj.idl: LayoutTests: Rebaseline existing tests now that we provide a more useful exception message when passing null for a non-nullable parameter and assigning null to a non-nullable attribute. * editing/selection/extend-expected.txt: * fast/dom/Document/adoptNode-null-expected.txt: * fast/dom/Document/adoptNode-null.html: * fast/dom/Document/importNode-null-expected.txt: * fast/dom/Document/importNode-null.html: * fast/dom/Element/attr-param-typechecking-expected.txt: * fast/dom/MutationObserver/observe-exceptions-expected.txt: * fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: * fast/dom/Range/range-intersectsNode-expected.txt: * fast/dom/createNodeIterator-parameters-expected.txt: * fast/dom/createNodeIterator-parameters.html: * fast/dom/createTreeWalker-parameters-expected.txt: * fast/dom/createTreeWalker-parameters.html: * fast/dom/xmlserializer-serialize-to-string-exception-expected.txt: * fast/dynamic/insertAdjacentElement-expected.txt: * fast/mediastream/MediaStream-add-remove-null-undefined-tracks-expected.txt: * fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt: * fast/text/font-face-set-_javascript_-expected.txt: * fast/text/text-combine-crash-expected.txt: * media/encrypted-media/encrypted-media-v2-syntax-expected.txt: * media/encrypted-media/encrypted-media-v2-syntax.html: * webaudio/createMediaStreamSource-null-expected.txt: * webaudio/createMediaStreamSource-null.html: * webaudio/deco
[webkit-changes] [200582] trunk/Source/WebCore
Title: [200582] trunk/Source/WebCore Revision 200582 Author timothy_hor...@apple.com Date 2016-05-09 11:05:20 -0700 (Mon, 09 May 2016) Log Message Download progress on attachment elements sometimes exceeds element bounds https://bugs.webkit.org/show_bug.cgi?id=157440 Reviewed by Darin Adler. In the case of very large dynamic type sizes, we can overflow the bounds of the attachment. It turns out that we used to limit to one line in many cases anyway, so only wrap if we have only a title and/or icon. This looks better when you have many of the other elements even in non-large-type modes. * rendering/RenderThemeIOS.mm: (WebCore::AttachmentInfo::buildTitleLines): (WebCore::AttachmentInfo::AttachmentInfo): Limit the title to a single line if we have anything other than a title and icon. (WebCore::attachmentBorderPath): (WebCore::paintAttachmentBorder): (WebCore::RenderThemeIOS::paintAttachment): Clip to the border, so that even if somehow we paint outside of the bounds, we don't paint over other parts of the page. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderThemeIOS.mm Diff Modified: trunk/Source/WebCore/ChangeLog (200581 => 200582) --- trunk/Source/WebCore/ChangeLog 2016-05-09 17:48:49 UTC (rev 200581) +++ trunk/Source/WebCore/ChangeLog 2016-05-09 18:05:20 UTC (rev 200582) @@ -1,3 +1,29 @@ +2016-05-09 Tim Horton + +Download progress on attachment elements sometimes exceeds element bounds +https://bugs.webkit.org/show_bug.cgi?id=157440 + + +Reviewed by Darin Adler. + +In the case of very large dynamic type sizes, we can overflow the +bounds of the attachment. It turns out that we used to limit to one +line in many cases anyway, so only wrap if we have only a title and/or icon. +This looks better when you have many of the other elements even in +non-large-type modes. + +* rendering/RenderThemeIOS.mm: +(WebCore::AttachmentInfo::buildTitleLines): +(WebCore::AttachmentInfo::AttachmentInfo): +Limit the title to a single line if we have anything +other than a title and icon. + +(WebCore::attachmentBorderPath): +(WebCore::paintAttachmentBorder): +(WebCore::RenderThemeIOS::paintAttachment): +Clip to the border, so that even if somehow we paint outside of +the bounds, we don't paint over other parts of the page. + 2016-05-09 Ryosuke Niwa REGRESSION (198056): Unable to use edit buttons on WordPress Modified: trunk/Source/WebCore/rendering/RenderThemeIOS.mm (200581 => 200582) --- trunk/Source/WebCore/rendering/RenderThemeIOS.mm 2016-05-09 17:48:49 UTC (rev 200581) +++ trunk/Source/WebCore/rendering/RenderThemeIOS.mm 2016-05-09 18:05:20 UTC (rev 200582) @@ -1397,7 +1397,7 @@ CGFloat contentYOrigin { 0 }; private: -void buildTitleLines(const RenderAttachment&); +void buildTitleLines(const RenderAttachment&, unsigned maximumLineCount); void buildSingleLine(const String&, CTFontRef, UIColor *); void addLine(CTLineRef); @@ -1418,7 +1418,7 @@ lines.append(labelLine); } -void AttachmentInfo::buildTitleLines(const RenderAttachment& attachment) +void AttachmentInfo::buildTitleLines(const RenderAttachment& attachment, unsigned maximumLineCount) { RetainPtr font = attachmentTitleFont(); @@ -1444,17 +1444,16 @@ if (!lineCount) return; -// Lay out and record the first (attachmentTitleMaximumLineCount - 1) lines. +// Lay out and record the first (maximumLineCount - 1) lines. CFIndex lineIndex = 0; -for (; lineIndex < std::min(attachmentTitleMaximumLineCount - 1, lineCount); ++lineIndex) { -CTLineRef line = (CTLineRef)CFArrayGetValueAtIndex(ctLines, lineIndex); -addLine(line); -} +CFIndex nonTruncatedLineCount = std::min(maximumLineCount - 1, lineCount); +for (; lineIndex < nonTruncatedLineCount; ++lineIndex) +addLine((CTLineRef)CFArrayGetValueAtIndex(ctLines, lineIndex)); if (lineIndex == lineCount) return; -// We had text that didn't fit in the first (attachmentTitleMaximumLineCount - 1) lines. +// We had text that didn't fit in the first (maximumLineCount - 1) lines. // Combine it into one last line, and center-truncate it. CTLineRef firstRemainingLine = (CTLineRef)CFArrayGetValueAtIndex(ctLines, lineIndex); CFIndex remainingRangeStart = CTLineGetStringRange(firstRemainingLine).location; @@ -1573,7 +1572,8 @@ } else buildSingleLine(action, attachmentActionFont().get(), attachmentActionColor(attachment)); -buildTitleLines(attachment); +bool forceSingleLineTitle = !action.isEmpty() || !subtitle.isEmpty() || hasProgress; +buildTitleLines(attachment, forceSingleLineTitle ? 1 : attachmentTitleMaximumLineCount); buildSingleLine(subtitle, attachmentSubtitleFont().get(), attachmentSubtitleColor()); if (!lines.isEmpty())
[webkit-changes] [200581] trunk/LayoutTests
Title: [200581] trunk/LayoutTests Revision 200581 Author rn...@webkit.org Date 2016-05-09 10:48:49 -0700 (Mon, 09 May 2016) Log Message Focusing a shadow host places the slot content after the shadow DOM content https://bugs.webkit.org/show_bug.cgi?id=154770 Reviewed by Antti Koivisto. Add a regression test now that the bug has been fixed. * fast/shadow-dom/shadow-layout-after-focus-expected.html: Added. * fast/shadow-dom/shadow-layout-after-focus.html: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/fast/shadow-dom/shadow-layout-after-focus-expected.html trunk/LayoutTests/fast/shadow-dom/shadow-layout-after-focus.html Diff Modified: trunk/LayoutTests/ChangeLog (200580 => 200581) --- trunk/LayoutTests/ChangeLog 2016-05-09 17:47:01 UTC (rev 200580) +++ trunk/LayoutTests/ChangeLog 2016-05-09 17:48:49 UTC (rev 200581) @@ -1,5 +1,18 @@ 2016-05-09 Ryosuke Niwa +Focusing a shadow host places the slot content after the shadow DOM content +https://bugs.webkit.org/show_bug.cgi?id=154770 + + +Reviewed by Antti Koivisto. + +Add a regression test now that the bug has been fixed. + +* fast/shadow-dom/shadow-layout-after-focus-expected.html: Added. +* fast/shadow-dom/shadow-layout-after-focus.html: Added. + +2016-05-09 Ryosuke Niwa + REGRESSION (198056): Unable to use edit buttons on WordPress https://bugs.webkit.org/show_bug.cgi?id=157475 Added: trunk/LayoutTests/fast/shadow-dom/shadow-layout-after-focus-expected.html (0 => 200581) --- trunk/LayoutTests/fast/shadow-dom/shadow-layout-after-focus-expected.html (rev 0) +++ trunk/LayoutTests/fast/shadow-dom/shadow-layout-after-focus-expected.html 2016-05-09 17:48:49 UTC (rev 200581) @@ -0,0 +1,7 @@ + + + +Test passes if you see a single 100px by 100px green box below. + + + Added: trunk/LayoutTests/fast/shadow-dom/shadow-layout-after-focus.html (0 => 200581) --- trunk/LayoutTests/fast/shadow-dom/shadow-layout-after-focus.html (rev 0) +++ trunk/LayoutTests/fast/shadow-dom/shadow-layout-after-focus.html 2016-05-09 17:48:49 UTC (rev 200581) @@ -0,0 +1,70 @@ + + + + + +#container { +position: relative; +} + +#host { +width: 90px; +height: 90px; +border: solid 5px red; +outline: none; +} + +#host:not(:focus)::after { +position: absolute; +left: 5px; +bottom: 5px; +width: 90px; +height: 45px; +content: 'FAIL - not focused'; +} + +#host:focus { +outline: solid 5px green; +outline-offset: -5px; +} + +#host div { +background: red; +width: 90px; +height: 45px; +} + +#overlay { +position: absolute; +top: 0; +left: 0; +background: green; +display: block; +width: 100px; +height: 50px; +} + + +Test passes if you see a single 100px by 100px green box below. + +FAIL - misplaced + + + + +var host = document.getElementById('host'); +var shadow = host.attachShadow({mode: 'closed'}); +shadow.innerHTML = ` + ++ +`; + +host.getBoundingClientRect(); +host.focus(); + + + + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200580] trunk
Title: [200580] trunk Revision 200580 Author rn...@webkit.org Date 2016-05-09 10:47:01 -0700 (Mon, 09 May 2016) Log Message REGRESSION (198056): Unable to use edit buttons on WordPress https://bugs.webkit.org/show_bug.cgi?id=157475 Reviewed by Antti Koivisto. Source/WebCore: Renamed Event.prototype.deepPath() to composedPath() per discussions on https://github.com/whatwg/dom/issues/242 as the old name was not Web compatible. Test: fast/shadow-dom/Extensions-to-Event-Interface.html * dom/Event.cpp: (WebCore::Event::composedPath): Renamed from deepPath. * dom/Event.h: * dom/Event.idl: LayoutTests: Updated the tests. * fast/shadow-dom/Extensions-to-Event-Interface-expected.txt: * fast/shadow-dom/Extensions-to-Event-Interface.html: * fast/shadow-dom/resources/event-path-test-helpers.js: (dispatchEventWithLog): Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/shadow-dom/Extensions-to-Event-Interface-expected.txt trunk/LayoutTests/fast/shadow-dom/Extensions-to-Event-Interface.html trunk/LayoutTests/fast/shadow-dom/resources/event-path-test-helpers.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Event.cpp trunk/Source/WebCore/dom/Event.h trunk/Source/WebCore/dom/Event.idl Diff Modified: trunk/LayoutTests/ChangeLog (200579 => 200580) --- trunk/LayoutTests/ChangeLog 2016-05-09 17:32:10 UTC (rev 200579) +++ trunk/LayoutTests/ChangeLog 2016-05-09 17:47:01 UTC (rev 200580) @@ -1,3 +1,17 @@ +2016-05-09 Ryosuke Niwa + +REGRESSION (198056): Unable to use edit buttons on WordPress +https://bugs.webkit.org/show_bug.cgi?id=157475 + +Reviewed by Antti Koivisto. + +Updated the tests. + +* fast/shadow-dom/Extensions-to-Event-Interface-expected.txt: +* fast/shadow-dom/Extensions-to-Event-Interface.html: +* fast/shadow-dom/resources/event-path-test-helpers.js: +(dispatchEventWithLog): + 2016-05-09 Ryan Haddad Removing timeout and adding failure expectation for storage/indexeddb/intversion-open-in-upgradeneeded.html Modified: trunk/LayoutTests/fast/shadow-dom/Extensions-to-Event-Interface-expected.txt (200579 => 200580) --- trunk/LayoutTests/fast/shadow-dom/Extensions-to-Event-Interface-expected.txt 2016-05-09 17:32:10 UTC (rev 200579) +++ trunk/LayoutTests/fast/shadow-dom/Extensions-to-Event-Interface-expected.txt 2016-05-09 17:47:01 UTC (rev 200580) @@ -1,7 +1,7 @@ -PASS deepPath() must exist on Event -PASS deepPath() must return an empty array when the event has not been dispatched -PASS deepPath() must return an empty array when the event is no longer dispatched +PASS composedPath() must exist on Event +PASS composedPath() must return an empty array when the event has not been dispatched +PASS composedPath() must return an empty array when the event is no longer dispatched PASS scoped must exist on Event PASS scoped on EventInit must default to false PASS scoped on EventInit must set the scoped flag @@ -20,6 +20,6 @@ PASS The event must not propagate out of closed mode shadow tree of the target but must propagate out of inner shadow trees when the scoped flag is set PASS The event must propagate out of open mode shadow tree in which the relative target and the relative related target are the same PASS The event must propagate out of closed mode shadow tree in which the relative target and the relative related target are the same -PASS deepPath() must contain and only contain the unclosed nodes of target in open mode shadow trees -PASS deepPath() must contain and only contain the unclosed nodes of target in closed mode shadow trees +PASS composedPath() must contain and only contain the unclosed nodes of target in open mode shadow trees +PASS composedPath() must contain and only contain the unclosed nodes of target in closed mode shadow trees Modified: trunk/LayoutTests/fast/shadow-dom/Extensions-to-Event-Interface.html (200579 => 200580) --- trunk/LayoutTests/fast/shadow-dom/Extensions-to-Event-Interface.html 2016-05-09 17:32:10 UTC (rev 200579) +++ trunk/LayoutTests/fast/shadow-dom/Extensions-to-Event-Interface.html 2016-05-09 17:47:01 UTC (rev 200580) @@ -3,7 +3,7 @@ Shadow DOM: Extensions to Event Interface - +
[webkit-changes] [200579] trunk/LayoutTests
Title: [200579] trunk/LayoutTests Revision 200579 Author ryanhad...@apple.com Date 2016-05-09 10:32:10 -0700 (Mon, 09 May 2016) Log Message Removing timeout and adding failure expectation for storage/indexeddb/intversion-open-in-upgradeneeded.html https://bugs.webkit.org/show_bug.cgi?id=155050 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (200578 => 200579) --- trunk/LayoutTests/ChangeLog 2016-05-09 16:54:37 UTC (rev 200578) +++ trunk/LayoutTests/ChangeLog 2016-05-09 17:32:10 UTC (rev 200579) @@ -1,3 +1,12 @@ +2016-05-09 Ryan Haddad + +Removing timeout and adding failure expectation for storage/indexeddb/intversion-open-in-upgradeneeded.html +https://bugs.webkit.org/show_bug.cgi?id=155050 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2016-05-09 Manuel Rego Casasnovas [css-grid] Fix static position for positioned grid items Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (200578 => 200579) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2016-05-09 16:54:37 UTC (rev 200578) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2016-05-09 17:32:10 UTC (rev 200579) @@ -296,7 +296,7 @@ webkit.org/b/152492 [ Debug ] inspector/debugger/break-on-exception-catch.html [ Pass Timeout ] -webkit.org/b/155050 storage/indexeddb/intversion-open-in-upgradeneeded.html [ Pass Crash Timeout ] +webkit.org/b/155050 storage/indexeddb/intversion-open-in-upgradeneeded.html [ Pass Crash Failure ] webkit.org/b/155138 [ Yosemite ElCapitan ] inspector/console/addInspectedNode.html [ Pass Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200578] trunk/Source
Title: [200578] trunk/Source Revision 200578 Author commit-qu...@webkit.org Date 2016-05-09 09:54:37 -0700 (Mon, 09 May 2016) Log Message Don't use DiskCache for media resource loads https://bugs.webkit.org/show_bug.cgi?id=157405 Patch by Alex Christensen on 2016-05-09 Reviewed by Darin Adler. Source/WebCore: http/tests/security/video-cross-origin-caching.html was loading from the disk cache. This patch adds an assertion that fires in that test without this fix. * loader/MediaResourceLoader.cpp: (WebCore::MediaResourceLoader::requestResource): * platform/graphics/PlatformMediaResourceLoader.h: * platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::hiddenFromInspector): (WebCore::ResourceRequestBase::setHiddenFromInspector): (WebCore::ResourceRequestBase::requester): (WebCore::ResourceRequestBase::setRequester): * platform/network/cocoa/WebCoreNSURLSession.mm: (-[WebCoreNSURLSessionDataTask _restart]): (-[WebCoreNSURLSessionDataTask resource:receivedResponse:]): Source/WebKit2: * NetworkProcess/cache/NetworkCache.cpp: (WebKit::NetworkCache::makeRetrieveDecision): (WebKit::NetworkCache::makeStoreDecision): * NetworkProcess/cache/NetworkCache.h: * NetworkProcess/cache/NetworkCacheStatistics.cpp: (WebKit::NetworkCache::retrieveDecisionToDiagnosticKey): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/MediaResourceLoader.cpp trunk/Source/WebCore/platform/graphics/PlatformMediaResourceLoader.h trunk/Source/WebCore/platform/network/ResourceRequestBase.h trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.h trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStatistics.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (200577 => 200578) --- trunk/Source/WebCore/ChangeLog 2016-05-09 16:28:38 UTC (rev 200577) +++ trunk/Source/WebCore/ChangeLog 2016-05-09 16:54:37 UTC (rev 200578) @@ -1,3 +1,25 @@ +2016-05-09 Alex Christensen + +Don't use DiskCache for media resource loads +https://bugs.webkit.org/show_bug.cgi?id=157405 + +Reviewed by Darin Adler. + +http/tests/security/video-cross-origin-caching.html was loading from the disk cache. +This patch adds an assertion that fires in that test without this fix. + +* loader/MediaResourceLoader.cpp: +(WebCore::MediaResourceLoader::requestResource): +* platform/graphics/PlatformMediaResourceLoader.h: +* platform/network/ResourceRequestBase.h: +(WebCore::ResourceRequestBase::hiddenFromInspector): +(WebCore::ResourceRequestBase::setHiddenFromInspector): +(WebCore::ResourceRequestBase::requester): +(WebCore::ResourceRequestBase::setRequester): +* platform/network/cocoa/WebCoreNSURLSession.mm: +(-[WebCoreNSURLSessionDataTask _restart]): +(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]): + 2016-05-09 Ryosuke Niwa Refactor FocusController::findFocusableElementRecursively Modified: trunk/Source/WebCore/loader/MediaResourceLoader.cpp (200577 => 200578) --- trunk/Source/WebCore/loader/MediaResourceLoader.cpp 2016-05-09 16:28:38 UTC (rev 200577) +++ trunk/Source/WebCore/loader/MediaResourceLoader.cpp 2016-05-09 16:54:37 UTC (rev 200578) @@ -64,9 +64,11 @@ DataBufferingPolicy bufferingPolicy = options & LoadOption::BufferData ? WebCore::BufferData : WebCore::DoNotBufferData; RequestOriginPolicy corsPolicy = !m_crossOriginMode.isNull() ? PotentiallyCrossOriginEnabled : UseDefaultOriginRestrictionsForType; +auto cachingPolicy = options & LoadOption::DisallowCaching ? CachingPolicy::DisallowCaching : CachingPolicy::AllowCaching; StoredCredentials allowCredentials = m_crossOriginMode.isNull() || equalLettersIgnoringASCIICase(m_crossOriginMode, "use-credentials") ? AllowStoredCredentials : DoNotAllowStoredCredentials; auto updatedRequest = request; +updatedRequest.setRequester(ResourceRequest::Requester::Media); #if HAVE(AVFOUNDATION_LOADER_DELEGATE) && PLATFORM(MAC) // FIXME: Workaround for . We are not able to do CORS checking on 304 responses because they // are usually missing the headers we need. @@ -76,7 +78,7 @@ // FIXME: Skip Content Security Policy check if the element that inititated this request // is in a user-agent shadow tree. See . -CachedResourceRequest cacheRequest(updatedRequest, ResourceLoaderOptions(SendCallbacks, DoNotSniffContent, bufferingPolicy, allowCredentials, DoNotAskClientForCrossOriginCredentials, ClientDidNotRequestCredentials, DoSecurityCheck, corsPolicy, DoNotIncludeCertificateInfo, ContentSecurityPolicyImposition::DoPolicyCheck, DefersLoadingPolicy::AllowDefersLoading, CachingPolicy::AllowCaching)); +CachedResourceRequest cacheRequest(updatedRequest, ResourceLoaderOptions(SendCallbacks, DoNotSniffContent, buffering
[webkit-changes] [200577] trunk/Source/WebKit/win
Title: [200577] trunk/Source/WebKit/win Revision 200577 Author commit-qu...@webkit.org Date 2016-05-09 09:28:38 -0700 (Mon, 09 May 2016) Log Message [wincairo] web inspector failed to launch in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=156184 Patch by Fujii Hironori on 2016-05-09 Reviewed by Alex Christensen. * WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::openLocalFrontend): Enable AllowFileAccessFromFileURLs and AllowUniversalAccessFromFileURLs of WebPreferences for Web Inspector. Modified Paths trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp Diff Modified: trunk/Source/WebKit/win/ChangeLog (200576 => 200577) --- trunk/Source/WebKit/win/ChangeLog 2016-05-09 16:20:20 UTC (rev 200576) +++ trunk/Source/WebKit/win/ChangeLog 2016-05-09 16:28:38 UTC (rev 200577) @@ -1,3 +1,16 @@ +2016-05-09 Fujii Hironori + +[wincairo] web inspector failed to launch in MiniBrowser +https://bugs.webkit.org/show_bug.cgi?id=156184 + + +Reviewed by Alex Christensen. + +* WebCoreSupport/WebInspectorClient.cpp: +(WebInspectorClient::openLocalFrontend): Enable +AllowFileAccessFromFileURLs and AllowUniversalAccessFromFileURLs +of WebPreferences for Web Inspector. + 2016-05-06 Joseph Pecoraro Rename HitTestRequest DisallowShadowContent to DisallowUserAgentShadowContent Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp (200576 => 200577) --- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp 2016-05-09 16:20:20 UTC (rev 200576) +++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp 2016-05-09 16:28:38 UTC (rev 200577) @@ -120,6 +120,10 @@ return 0; if (FAILED(preferences->setAuthorAndUserStylesEnabled(TRUE))) return 0; +if (FAILED(preferences->setAllowFileAccessFromFileURLs(TRUE))) +return 0; +if (FAILED(preferences->setAllowUniversalAccessFromFileURLs(TRUE))) +return 0; if (FAILED(preferences->setAllowsAnimatedImages(TRUE))) return 0; if (FAILED(preferences->setLoadsImagesAutomatically(TRUE))) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200576] trunk/Source/WebCore
Title: [200576] trunk/Source/WebCore Revision 200576 Author rn...@webkit.org Date 2016-05-09 09:20:20 -0700 (Mon, 09 May 2016) Log Message Refactor FocusController::findFocusableElementRecursively https://bugs.webkit.org/show_bug.cgi?id=157415 Reviewed by Darin Adler. Refactor FocusController::findFocusableElementRecursively and related functions. Extracted two functions: nextFocusableElementWithinScope and previousFocusableElementWithinScope out of it since they didn't really share any code other than calling findFocusableElement at the beginning. Also renamed internal variant of nextFocusableElement and previousFocusableElement to nextFocusableElementOrScopeOwner and previousFocusableElementOrScopeOwner. It was confusing to have these internal functions in addition to public member functions that are used in Objective-C DOM API. No new tests are added since there should be no behavioral change. * page/FocusController.cpp: (WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument): Added a FIXME. (WebCore::FocusController::advanceFocusInDocumentOrder): Use findFocusableElementAcrossFocusScope instead of manually calling findFocusableElementRecursively and findFocusableElementDescendingDownIntoFrameDocument separately. (WebCore::FocusController::findFocusableElementAcrossFocusScope): Now that findFocusableElementWithinScope calls findFocusableElementDescendingDownIntoFrameDocument internally, there is no need to keep around "found" local variable. Introduce a few early exists for a better clarity. (WebCore::FocusController::findFocusableElementWithinScope): Renamed from findFocusableElementRecursively. Also call findFocusableElementDescendingDownIntoFrameDocument here instead of findFocusableElementAcrossFocusScope. (WebCore::FocusController::nextFocusableElementWithinScope): Extracted from findFocusableElementRecursively. (WebCore::FocusController::previousFocusableElementWithinScope): Ditto. (WebCore::FocusController::findFocusableElement): (WebCore::FocusController::nextFocusableElement): Added a FIXME. (WebCore::FocusController::previousFocusableElement): Ditto. (WebCore::FocusController::findFocusableElementOrScopeOwner): Renamed from findFocusableElement for clarity. (WebCore::FocusController::nextFocusableElementOrScopeOwner): Ditto from nextFocusableElement. (WebCore::FocusController::previousFocusableElementOrScopeOwner): Ditto from nextFocusableElement. * page/FocusController.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/FocusController.cpp trunk/Source/WebCore/page/FocusController.h Diff Modified: trunk/Source/WebCore/ChangeLog (200575 => 200576) --- trunk/Source/WebCore/ChangeLog 2016-05-09 16:09:17 UTC (rev 200575) +++ trunk/Source/WebCore/ChangeLog 2016-05-09 16:20:20 UTC (rev 200576) @@ -1,3 +1,39 @@ +2016-05-09 Ryosuke Niwa + +Refactor FocusController::findFocusableElementRecursively +https://bugs.webkit.org/show_bug.cgi?id=157415 + +Reviewed by Darin Adler. + +Refactor FocusController::findFocusableElementRecursively and related functions. Extracted two functions: +nextFocusableElementWithinScope and previousFocusableElementWithinScope out of it since they didn't really share +any code other than calling findFocusableElement at the beginning. + +Also renamed internal variant of nextFocusableElement and previousFocusableElement to nextFocusableElementOrScopeOwner +and previousFocusableElementOrScopeOwner. It was confusing to have these internal functions in addition to public +member functions that are used in Objective-C DOM API. + +No new tests are added since there should be no behavioral change. + +* page/FocusController.cpp: +(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument): Added a FIXME. +(WebCore::FocusController::advanceFocusInDocumentOrder): Use findFocusableElementAcrossFocusScope instead of manually +calling findFocusableElementRecursively and findFocusableElementDescendingDownIntoFrameDocument separately. +(WebCore::FocusController::findFocusableElementAcrossFocusScope): Now that findFocusableElementWithinScope calls +findFocusableElementDescendingDownIntoFrameDocument internally, there is no need to keep around "found" local variable. +Introduce a few early exists for a better clarity. +(WebCore::FocusController::findFocusableElementWithinScope): Renamed from findFocusableElementRecursively. Also call +findFocusableElementDescendingDownIntoFrameDocument here instead of findFocusableElementAcrossFocusScope. +(WebCore::FocusController::nextFocusableElementWithinScope): Extracted from findFocusableElementRecursively. +(WebCore::FocusController::previousFocusableElementWithinScope): Ditto. +(WebCore::FocusController::findFocusableElement): +(WebCore::FocusController::nextFocusableElement): Added
[webkit-changes] [200575] trunk/Source/WebInspectorUI
Title: [200575] trunk/Source/WebInspectorUI Revision 200575 Author r...@igalia.com Date 2016-05-09 09:09:17 -0700 (Mon, 09 May 2016) Log Message [css-grid] Update Grid Layout properties in CSSKeywordCompletions.js https://bugs.webkit.org/show_bug.cgi?id=157166 Reviewed by Timothy Hatcher. The CSS Grid Layout properties have been changing on the spec, however they haven't been updated in CSSKeywordCompletions for a long time. Update them using the last spec draft: https://drafts.csswg.org/css-grid/#property-index * UserInterface/Models/CSSKeywordCompletions.js: Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (200574 => 200575) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-09 14:59:23 UTC (rev 200574) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-09 16:09:17 UTC (rev 200575) @@ -1,3 +1,17 @@ +2016-05-09 Manuel Rego Casasnovas + +[css-grid] Update Grid Layout properties in CSSKeywordCompletions.js +https://bugs.webkit.org/show_bug.cgi?id=157166 + +Reviewed by Timothy Hatcher. + +The CSS Grid Layout properties have been changing on the spec, +however they haven't been updated in CSSKeywordCompletions for a long time. +Update them using the last spec draft: +https://drafts.csswg.org/css-grid/#property-index + +* UserInterface/Models/CSSKeywordCompletions.js: + 2016-05-09 Matt Baker Web Inspector: Cleanup issue tree elements in the Debugger sidebar Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js (200574 => 200575) --- trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js 2016-05-09 14:59:23 UTC (rev 200574) +++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js 2016-05-09 16:09:17 UTC (rev 200575) @@ -776,33 +776,51 @@ "flex-basis": [ "auto" ], -"grid-after": [ -"auto" +"grid": [ +"none" ], -"grid-before": [ +"grid-area": [ "auto" ], -"grid-end": [ -"auto" +"grid-auto-columns": [ +"auto", "-webkit-max-content", "-webkit-min-content", "minmax()", ], -"grid-start": [ -"auto" -], "grid-auto-flow": [ "row", "column", "dense" ], +"grid-auto-rows": [ +"auto", "-webkit-max-content", "-webkit-min-content", "minmax()", +], "grid-column": [ "auto" ], +"grid-column-start": [ +"auto" +], +"grid-column-end": [ +"auto" +], "grid-row": [ "auto" ], -"grid-columns": [ -"auto", "-webkit-max-content", "-webkit-min-content" +"grid-row-start": [ +"auto" ], -"grid-rows": [ -"auto", "-webkit-max-content", "-webkit-min-content" +"grid-row-end": [ +"auto" ], +"grid-template": [ +"none" +], +"grid-template-areas": [ +"none" +], +"grid-template-columns": [ +"none", "auto", "-webkit-max-content", "-webkit-min-content", "minmax()", "repeat()" +], +"grid-template-rows": [ +"none", "auto", "-webkit-max-content", "-webkit-min-content", "minmax()", "repeat()" +], "-webkit-ruby-position": [ "after", "before", "inter-character" ], ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200573] trunk/Source/WebInspectorUI
Title: [200573] trunk/Source/WebInspectorUI Revision 200573 Author mattba...@apple.com Date 2016-05-09 07:52:19 -0700 (Mon, 09 May 2016) Log Message Web Inspector: Show in progress message in Timeline views that do not show data until the recording finishes https://bugs.webkit.org/show_bug.cgi?id=156761 Reviewed by Timothy Hatcher. * Localizations/en.lproj/localizedStrings.js: New UI strings. * UserInterface/Main.html: New view class. * UserInterface/Views/HeapAllocationsTimelineView.js: (WebInspector.HeapAllocationsTimelineView.prototype.get showsLiveRecordingData): * UserInterface/Views/RenderingFrameTimelineView.js: (WebInspector.RenderingFrameTimelineView.prototype.get showsLiveRecordingData): * UserInterface/Views/ScriptDetailsTimelineView.js: (WebInspector.ScriptDetailsTimelineView.prototype.get showsLiveRecordingData): * UserInterface/Views/ScriptProfileTimelineView.js: (WebInspector.ScriptProfileTimelineView.prototype.get showsLiveRecordingData): Don't show live recording data. * UserInterface/Views/ScriptClusterTimelineView.js: (WebInspector.ScriptClusterTimelineView.prototype.get showsLiveRecordingData): Forward property to current child TimelineView. * UserInterface/Views/TimelineRecordingContentView.css: (.content-view.timeline-recording > .content-browser .recording-progress): (.content-view.timeline-recording > .content-browser .recording-progress > .status): (.content-view.timeline-recording > .content-browser .recording-progress > .status > .indeterminate-progress-spinner): New progress view styles. * UserInterface/Views/TimelineRecordingContentView.js: (WebInspector.TimelineRecordingContentView): (WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange): (WebInspector.TimelineRecordingContentView.prototype._capturingStarted): (WebInspector.TimelineRecordingContentView.prototype._capturingStopped): Refresh progress view visibility. (WebInspector.TimelineRecordingContentView.prototype._updateProgressView): Show the progress view if we're currently capturing, and showing a view that doesn't support showing live data. * UserInterface/Views/TimelineRecordingProgressView.js: (WebInspector.TimelineRecordingProgressView): (WebInspector.TimelineRecordingProgressView.prototype.get visible): (WebInspector.TimelineRecordingProgressView.prototype.set visible): Show a status message, indeterminate progress spinner, and Stop Recording button while timeline data is being recorded. * UserInterface/Views/TimelineView.js: (WebInspector.TimelineView.prototype.get showsLiveRecordingData): Implemented by TimelineViews that don't support showing data while recording. * UserInterface/Views/Variables.css: (:root): Add --panel-background-color-light for the progress view. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Main.html trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js trunk/Source/WebInspectorUI/UserInterface/Views/ScriptClusterTimelineView.js trunk/Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js trunk/Source/WebInspectorUI/UserInterface/Views/ScriptProfileTimelineView.js trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.css trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css Added Paths trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingProgressView.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (200572 => 200573) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-09 10:17:29 UTC (rev 200572) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-09 14:52:19 UTC (rev 200573) @@ -1,3 +1,63 @@ +2016-05-09 Matt Baker + +Web Inspector: Show in progress message in Timeline views that do not show data until the recording finishes +https://bugs.webkit.org/show_bug.cgi?id=156761 + + +Reviewed by Timothy Hatcher. + +* Localizations/en.lproj/localizedStrings.js: +New UI strings. + +* UserInterface/Main.html: +New view class. + +* UserInterface/Views/HeapAllocationsTimelineView.js: +(WebInspector.HeapAllocationsTimelineView.prototype.get showsLiveRecordingData): +* UserInterface/Views/RenderingFrameTimelineView.js: +(WebInspector.RenderingFrameTimelineView.prototype.get showsLiveRecordingData): +* UserInterface/Views/ScriptDetailsTimelineView.js: +(WebInspector.ScriptDetailsTimelineView.prototype.get showsLiveRecordingData): +* UserInterface/Views/ScriptProfileTimelineView.js: +(WebInspector.ScriptProfileTimelineView.prototype.get showsLiveRecordingData): +Don't show live recording da
[webkit-changes] [200574] trunk/Source/WebInspectorUI
Title: [200574] trunk/Source/WebInspectorUI Revision 200574 Author mattba...@apple.com Date 2016-05-09 07:59:23 -0700 (Mon, 09 May 2016) Log Message Web Inspector: Cleanup issue tree elements in the Debugger sidebar https://bugs.webkit.org/show_bug.cgi?id=157469 Reviewed by Timothy Hatcher. * UserInterface/Views/DebuggerSidebarPanel.js: (WebInspector.DebuggerSidebarPanel): (WebInspector.DebuggerSidebarPanel.prototype._addIssue): Don't add duplicate issue tree elements. (WebInspector.DebuggerSidebarPanel.prototype._handleIssuesCleared): Remove issues from the correct tree outline. * UserInterface/Views/IssueTreeElement.css: (.issue .icon): (.issue.warning .icon): (.issue.error .icon): Match dashboard icons. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js trunk/Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.css Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (200573 => 200574) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-09 14:52:19 UTC (rev 200573) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-09 14:59:23 UTC (rev 200574) @@ -1,5 +1,26 @@ 2016-05-09 Matt Baker +Web Inspector: Cleanup issue tree elements in the Debugger sidebar +https://bugs.webkit.org/show_bug.cgi?id=157469 + + +Reviewed by Timothy Hatcher. + +* UserInterface/Views/DebuggerSidebarPanel.js: +(WebInspector.DebuggerSidebarPanel): +(WebInspector.DebuggerSidebarPanel.prototype._addIssue): +Don't add duplicate issue tree elements. +(WebInspector.DebuggerSidebarPanel.prototype._handleIssuesCleared): +Remove issues from the correct tree outline. + +* UserInterface/Views/IssueTreeElement.css: +(.issue .icon): +(.issue.warning .icon): +(.issue.error .icon): +Match dashboard icons. + +2016-05-09 Matt Baker + Web Inspector: Show in progress message in Timeline views that do not show data until the recording finishes https://bugs.webkit.org/show_bug.cgi?id=156761 Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (200573 => 200574) --- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2016-05-09 14:52:19 UTC (rev 200573) +++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2016-05-09 14:59:23 UTC (rev 200574) @@ -866,11 +866,15 @@ _addIssue(issueMessage) { +let issueTreeElement = this._scriptsContentTreeOutline.findTreeElement(issueMessage); +if (issueTreeElement) +return issueTreeElement; + let parentTreeElement = this._addTreeElementForSourceCodeToTreeOutline(issueMessage.sourceCodeLocation.sourceCode, this._scriptsContentTreeOutline); if (!parentTreeElement) return null; -var issueTreeElement = new WebInspector.IssueTreeElement(issueMessage); +issueTreeElement = new WebInspector.IssueTreeElement(issueMessage); parentTreeElement.insertChild(issueTreeElement, insertionIndexForObjectInListSortedByFunction(issueTreeElement, parentTreeElement.children, this._compareDebuggerTreeElements)); if (parentTreeElement.children.length === 1) @@ -892,8 +896,8 @@ _handleIssuesCleared(event) { -var currentTreeElement = this._contentTreeOutline.children[0]; -var issueTreeElements = []; +let currentTreeElement = this._scriptsContentTreeOutline.children[0]; +let issueTreeElements = []; while (currentTreeElement && !currentTreeElement.root) { if (currentTreeElement instanceof WebInspector.IssueTreeElement) @@ -901,8 +905,7 @@ currentTreeElement = currentTreeElement.traverseNextTreeElement(false, null, true); } -for (var issueTreeElement of issueTreeElements) -issueTreeElement.parent.removeChild(issueTreeElement); +issueTreeElements.forEach((treeElement) => treeElement.parent.removeChild(treeElement)); } }; Modified: trunk/Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.css (200573 => 200574) --- trunk/Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.css 2016-05-09 14:52:19 UTC (rev 200573) +++ trunk/Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.css 2016-05-09 14:59:23 UTC (rev 200574) @@ -24,10 +24,13 @@ */ .issue .icon { -background-image: url(../Images/Warning.svg); -content: ''; +content: ""; } +.issue.warning .icon { +background-image: url(../Images/IssuesEnabled.svg); +} + .issue.error .icon { -background-image: url(../Images/Error.svg); +background-image: url(../Images/ErrorsEnabled.svg); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200572] trunk
Title: [200572] trunk Revision 200572 Author r...@igalia.com Date 2016-05-09 03:17:29 -0700 (Mon, 09 May 2016) Log Message [css-grid] Fix static position for positioned grid items https://bugs.webkit.org/show_bug.cgi?id=157417 Reviewed by Darin Adler. Source/WebCore: The spec was updated to define properly the static position for positioned grid items, but we didn't update the implementation yet: https://drafts.csswg.org/css-grid-1/issues-wd-20150108#issue-1 We were only setting the static position when the start line was not auto. Otherwise we were using the default one which includes the padding. With the spec change we need to set it always, even if the start line is auto. * rendering/RenderGrid.cpp: (WebCore::RenderGrid::layoutPositionedObject): (WebCore::RenderGrid::offsetAndBreadthForPositionedChild): LayoutTests: Updated several tests to follow the new expected behavior. * fast/css-grid-layout/absolute-positioning-grid-container-containing-block.html: * fast/css-grid-layout/absolute-positioning-grid-container-parent.html: * fast/css-grid-layout/grid-positioned-items-gaps-rtl.html: * fast/css-grid-layout/grid-positioned-items-gaps.html: * fast/css-grid-layout/grid-positioned-items-implicit-grid-line.html: * fast/css-grid-layout/grid-positioned-items-implicit-grid.html: * fast/css-grid-layout/grid-positioned-items-unknown-named-grid-line.html: * fast/css-grid-layout/grid-sizing-positioned-items.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css-grid-layout/absolute-positioning-grid-container-containing-block.html trunk/LayoutTests/fast/css-grid-layout/absolute-positioning-grid-container-parent.html trunk/LayoutTests/fast/css-grid-layout/grid-positioned-items-gaps-rtl.html trunk/LayoutTests/fast/css-grid-layout/grid-positioned-items-gaps.html trunk/LayoutTests/fast/css-grid-layout/grid-positioned-items-implicit-grid-line.html trunk/LayoutTests/fast/css-grid-layout/grid-positioned-items-implicit-grid.html trunk/LayoutTests/fast/css-grid-layout/grid-positioned-items-unknown-named-grid-line.html trunk/LayoutTests/fast/css-grid-layout/grid-sizing-positioned-items.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderGrid.cpp Diff Modified: trunk/LayoutTests/ChangeLog (200571 => 200572) --- trunk/LayoutTests/ChangeLog 2016-05-09 08:55:50 UTC (rev 200571) +++ trunk/LayoutTests/ChangeLog 2016-05-09 10:17:29 UTC (rev 200572) @@ -1,3 +1,21 @@ +2016-05-09 Manuel Rego Casasnovas + +[css-grid] Fix static position for positioned grid items +https://bugs.webkit.org/show_bug.cgi?id=157417 + +Reviewed by Darin Adler. + +Updated several tests to follow the new expected behavior. + +* fast/css-grid-layout/absolute-positioning-grid-container-containing-block.html: +* fast/css-grid-layout/absolute-positioning-grid-container-parent.html: +* fast/css-grid-layout/grid-positioned-items-gaps-rtl.html: +* fast/css-grid-layout/grid-positioned-items-gaps.html: +* fast/css-grid-layout/grid-positioned-items-implicit-grid-line.html: +* fast/css-grid-layout/grid-positioned-items-implicit-grid.html: +* fast/css-grid-layout/grid-positioned-items-unknown-named-grid-line.html: +* fast/css-grid-layout/grid-sizing-positioned-items.html: + 2016-05-09 Gyuyoung Kim Fix wrong gardening in r200570 Modified: trunk/LayoutTests/fast/css-grid-layout/absolute-positioning-grid-container-containing-block.html (200571 => 200572) --- trunk/LayoutTests/fast/css-grid-layout/absolute-positioning-grid-container-containing-block.html 2016-05-09 08:55:50 UTC (rev 200571) +++ trunk/LayoutTests/fast/css-grid-layout/absolute-positioning-grid-container-containing-block.html 2016-05-09 10:17:29 UTC (rev 200572) @@ -113,7 +113,7 @@ -data-offset-x="15" data-offset-y="15" data-expected-width="530" data-expected-height="530"> +data-offset-x="0" data-offset-y="0" data-expected-width="530" data-expected-height="530"> data-offset-x="15" data-offset-y="15" data-expected-width="515" data-expected-height="515"> @@ -137,22 +137,22 @@ -data-offset-x="15" data-offset-y="65" data-expected-width="315" data-expected-height="250"> +data-offset-x="0" data-offset-y="65" data-expected-width="315" data-expected-height="250"> data-offset-x="65" data-offset-y="65" data-expected-width="250" data-expected-height="250"> -data-offset-x="15" data-offset-y="15" data-expected-width="165" data-expected-height="165"> +data-offset-x="0" data-offset-y="0" data-expected-width="165" data-expected-height="165"> -data-offset-x="15" data-offset-y="15" data-expected-width="65" data-expected-height="165"> +data-offset-x="0" data-offset-y="0" data-expected-width="65" data-expected-height="165"> -data-offset-x="15" data-offset-y="15" data-expected-width="165" dat
[webkit-changes] [200571] trunk/LayoutTests
Title: [200571] trunk/LayoutTests Revision 200571 Author gyuyoung@webkit.org Date 2016-05-09 01:55:50 -0700 (Mon, 09 May 2016) Log Message Fix wrong gardening in r200570 Unreviewed EFL gardening. * TestExpectations: Move selection gap tests to EFL's one. * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (200570 => 200571) --- trunk/LayoutTests/ChangeLog 2016-05-09 08:51:20 UTC (rev 200570) +++ trunk/LayoutTests/ChangeLog 2016-05-09 08:55:50 UTC (rev 200571) @@ -1,5 +1,14 @@ 2016-05-09 Gyuyoung Kim +Fix wrong gardening in r200570 + +Unreviewed EFL gardening. + +* TestExpectations: Move selection gap tests to EFL's one. +* platform/efl/TestExpectations: + +2016-05-09 Gyuyoung Kim + [EFL] Skip tests of selection gap because EFL port disabled to paint the selection gap Unreviewed EFL gardening. Modified: trunk/LayoutTests/TestExpectations (200570 => 200571) --- trunk/LayoutTests/TestExpectations 2016-05-09 08:51:20 UTC (rev 200570) +++ trunk/LayoutTests/TestExpectations 2016-05-09 08:55:50 UTC (rev 200571) @@ -51,14 +51,6 @@ fast/harness/ui-side-scripts.html [ Skip ] fast/harness/concurrent-ui-side-scripts.html [ Skip ] -# EFL port has not supported selection gap painting since r200412 -fast/repaint/selection-gap-absolute-child.html [ Skip ] -fast/repaint/selection-gap-fixed-child.html [ Skip ] -fast/repaint/selection-gap-flipped-absolute-child.html [ Skip ] -fast/repaint/selection-gap-flipped-fixed-child.html [ Skip ] -fast/repaint/selection-gap-transformed-absolute-child.html [ Skip ] -fast/repaint/selection-gap-transformed-fixed-child.html [ Skip ] - #// # End platform-specific tests. #// Modified: trunk/LayoutTests/platform/efl/TestExpectations (200570 => 200571) --- trunk/LayoutTests/platform/efl/TestExpectations 2016-05-09 08:51:20 UTC (rev 200570) +++ trunk/LayoutTests/platform/efl/TestExpectations 2016-05-09 08:55:50 UTC (rev 200571) @@ -376,6 +376,14 @@ webkit.org/b/87661 crypto/subtle/rsa-indexeddb.html [ Skip ] storage/indexeddb/database-odd-names.html [ Skip ] +# EFL port has not supported selection gap painting since r200412 +fast/repaint/selection-gap-absolute-child.html [ Skip ] +fast/repaint/selection-gap-fixed-child.html [ Skip ] +fast/repaint/selection-gap-flipped-absolute-child.html [ Skip ] +fast/repaint/selection-gap-flipped-fixed-child.html [ Skip ] +fast/repaint/selection-gap-transformed-absolute-child.html [ Skip ] +fast/repaint/selection-gap-transformed-fixed-child.html [ Skip ] + # # TESTS EXPECTED TO FAIL # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200570] trunk/LayoutTests
Title: [200570] trunk/LayoutTests Revision 200570 Author gyuyoung@webkit.org Date 2016-05-09 01:51:20 -0700 (Mon, 09 May 2016) Log Message [EFL] Skip tests of selection gap because EFL port disabled to paint the selection gap Unreviewed EFL gardening. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (200569 => 200570) --- trunk/LayoutTests/ChangeLog 2016-05-09 05:51:37 UTC (rev 200569) +++ trunk/LayoutTests/ChangeLog 2016-05-09 08:51:20 UTC (rev 200570) @@ -1,3 +1,11 @@ +2016-05-09 Gyuyoung Kim + +[EFL] Skip tests of selection gap because EFL port disabled to paint the selection gap + +Unreviewed EFL gardening. + +* TestExpectations: + 2016-05-08 Zalan Bujtas iOS selection: Use inflow containing block for positioned . Modified: trunk/LayoutTests/TestExpectations (200569 => 200570) --- trunk/LayoutTests/TestExpectations 2016-05-09 05:51:37 UTC (rev 200569) +++ trunk/LayoutTests/TestExpectations 2016-05-09 08:51:20 UTC (rev 200570) @@ -51,6 +51,14 @@ fast/harness/ui-side-scripts.html [ Skip ] fast/harness/concurrent-ui-side-scripts.html [ Skip ] +# EFL port has not supported selection gap painting since r200412 +fast/repaint/selection-gap-absolute-child.html [ Skip ] +fast/repaint/selection-gap-fixed-child.html [ Skip ] +fast/repaint/selection-gap-flipped-absolute-child.html [ Skip ] +fast/repaint/selection-gap-flipped-fixed-child.html [ Skip ] +fast/repaint/selection-gap-transformed-absolute-child.html [ Skip ] +fast/repaint/selection-gap-transformed-fixed-child.html [ Skip ] + #// # End platform-specific tests. #// ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes