[webkit-changes] [229741] trunk/Source/WebCore

[timothy_horton]

Title: [229741] trunk/Source/WebCore








Revision 229741
Author timothy_hor...@apple.com
Date 2018-03-19 23:26:36 -0700 (Mon, 19 Mar 2018)


Log Message
Apply some SDK checks in LocalDefaultSystemAppearance
https://bugs.webkit.org/show_bug.cgi?id=183767


Reviewed by Zalan Bujtas.

* platform/mac/LocalDefaultSystemAppearance.h:
* platform/mac/LocalDefaultSystemAppearance.mm:
(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance):
(WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/LocalDefaultSystemAppearance.h
trunk/Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (229740 => 229741)

--- trunk/Source/WebCore/ChangeLog	2018-03-20 05:34:48 UTC (rev 229740)
+++ trunk/Source/WebCore/ChangeLog	2018-03-20 06:26:36 UTC (rev 229741)
@@ -1,3 +1,16 @@
+2018-03-19  Tim Horton  
+
+Apply some SDK checks in LocalDefaultSystemAppearance
+https://bugs.webkit.org/show_bug.cgi?id=183767
+
+
+Reviewed by Zalan Bujtas.
+
+* platform/mac/LocalDefaultSystemAppearance.h:
+* platform/mac/LocalDefaultSystemAppearance.mm:
+(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance):
+(WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance):
+
 2018-03-19  Chris Dumez  
 
 Have one service worker process per security origin


Modified: trunk/Source/WebCore/platform/mac/LocalDefaultSystemAppearance.h (229740 => 229741)

--- trunk/Source/WebCore/platform/mac/LocalDefaultSystemAppearance.h	2018-03-20 05:34:48 UTC (rev 229740)
+++ trunk/Source/WebCore/platform/mac/LocalDefaultSystemAppearance.h	2018-03-20 06:26:36 UTC (rev 229741)
@@ -42,7 +42,9 @@
 LocalDefaultSystemAppearance(bool useSystemAppearance);
 ~LocalDefaultSystemAppearance();
 private:
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
 RetainPtr m_savedSystemAppearance;
+#endif
 };
 
 }


Modified: trunk/Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm (229740 => 229741)

--- trunk/Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm	2018-03-20 05:34:48 UTC (rev 229740)
+++ trunk/Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm	2018-03-20 06:26:36 UTC (rev 229741)
@@ -32,16 +32,21 @@
 namespace WebCore {
 
 LocalDefaultSystemAppearance::LocalDefaultSystemAppearance(bool useSystemAppearance)
-: m_savedSystemAppearance()
 {
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
 m_savedSystemAppearance = [NSAppearance currentAppearance];
 [NSAppearance setCurrentAppearance:useSystemAppearance ? [NSApp effectiveAppearance] : [NSAppearance appearanceNamed:NSAppearanceNameAqua]];
+#else
+UNUSED_PARAM(useSystemAppearance);
+#endif
 }
 
 LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance()
 {
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
 if (m_savedSystemAppearance)
 [NSAppearance setCurrentAppearance:m_savedSystemAppearance.get()];
+#endif
 }
 
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229740] trunk/Source/JavaScriptCore

[utatane . tea]

Title: [229740] trunk/Source/_javascript_Core








Revision 229740
Author utatane@gmail.com
Date 2018-03-19 22:34:48 -0700 (Mon, 19 Mar 2018)


Log Message
Drop s_exceptionInstructions static initializer
https://bugs.webkit.org/show_bug.cgi?id=183732

Reviewed by Darin Adler.

Make Instruction constructor constexpr to drop the static constructor
of LLInt::Data::s_exceptionInstructions.

* bytecode/Instruction.h:
(JSC::Instruction::Instruction):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/Instruction.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (229739 => 229740)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-20 05:02:41 UTC (rev 229739)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-20 05:34:48 UTC (rev 229740)
@@ -1,3 +1,16 @@
+2018-03-19  Yusuke Suzuki  
+
+Drop s_exceptionInstructions static initializer
+https://bugs.webkit.org/show_bug.cgi?id=183732
+
+Reviewed by Darin Adler.
+
+Make Instruction constructor constexpr to drop the static constructor
+of LLInt::Data::s_exceptionInstructions.
+
+* bytecode/Instruction.h:
+(JSC::Instruction::Instruction):
+
 2018-03-19  Dan Bernstein  
 
 Investigate why __cpu_indicator_init is used


Modified: trunk/Source/_javascript_Core/bytecode/Instruction.h (229739 => 229740)

--- trunk/Source/_javascript_Core/bytecode/Instruction.h	2018-03-20 05:02:41 UTC (rev 229739)
+++ trunk/Source/_javascript_Core/bytecode/Instruction.h	2018-03-20 05:34:48 UTC (rev 229740)
@@ -55,11 +55,11 @@
 #endif
 
 struct Instruction {
-Instruction()
+constexpr Instruction()
+: u({ nullptr })
 {
-u.jsCell.clear();
 }
-
+
 Instruction(Opcode opcode)
 {
 #if !ENABLE(COMPUTED_GOTO_OPCODES)
@@ -119,6 +119,7 @@
 Instruction(bool* predicatePointer) { u.predicatePointer = predicatePointer; }
 
 union {
+void* pointer;
 Opcode opcode;
 int operand;
 unsigned unsignedValue;
@@ -137,7 +138,6 @@
 ArrayAllocationProfile* arrayAllocationProfile;
 ObjectAllocationProfile* objectAllocationProfile;
 WatchpointSet* watchpointSet;
-void* pointer;
 bool* predicatePointer;
 ToThisStatus toThisStatus;
 TypeLocation* location;
@@ -149,6 +149,7 @@
 Instruction(StructureChain*);
 Instruction(Structure*);
 };
+static_assert(sizeof(Instruction) == sizeof(void*), "");
 
 } // namespace JSC
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229739] trunk/Tools

[zalan]

Title: [229739] trunk/Tools








Revision 229739
Author za...@apple.com
Date 2018-03-19 22:02:41 -0700 (Mon, 19 Mar 2018)


Log Message
[LayoutReloaded] Layout.Box should not create the formatting context.
https://bugs.webkit.org/show_bug.cgi?id=183766

Reviewed by Antti Koivisto.

Since the formattingContext's lifetime is tied to the layout, the LayoutContext
should construct it instead.

* LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
(BlockFormattingContext):
(BlockFormattingContext.prototype.layout):
(BlockFormattingContext.prototype._layoutOutOfFlowDescendants):
(BlockFormattingContext.prototype._contentHeight):
* LayoutReloaded/FormattingContext/FormattingContext.js:
(FormattingContext):
(FormattingContext.prototype.layoutContext):
(FormattingContext.prototype.toDisplayBox):
(FormattingContext.prototype._outOfFlowDescendants):
* LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
(InlineFormattingContext):
(InlineFormattingContext.prototype.layout):
* LayoutReloaded/Layout.js:
(layout):
* LayoutReloaded/LayoutContext.js:
(LayoutContext.prototype.layout):
(LayoutContext.prototype._createFormattingContext):
(LayoutContext):
(LayoutContext.prototype.layoutFormattingContext): Deleted.
* LayoutReloaded/LayoutTree/Box.js:
(Layout.Box):
(Layout.Box.prototype.establishedFormattingContext): Deleted.
* LayoutReloaded/misc/headers/Box.h:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js
trunk/Tools/LayoutReloaded/FormattingContext/FormattingContext.js
trunk/Tools/LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js
trunk/Tools/LayoutReloaded/Layout.js
trunk/Tools/LayoutReloaded/LayoutContext.js
trunk/Tools/LayoutReloaded/LayoutTree/Box.js
trunk/Tools/LayoutReloaded/misc/headers/Box.h




Diff

Modified: trunk/Tools/ChangeLog (229738 => 229739)

--- trunk/Tools/ChangeLog	2018-03-20 03:26:15 UTC (rev 229738)
+++ trunk/Tools/ChangeLog	2018-03-20 05:02:41 UTC (rev 229739)
@@ -1,3 +1,38 @@
+2018-03-19  Zalan Bujtas  
+
+[LayoutReloaded] Layout.Box should not create the formatting context.
+https://bugs.webkit.org/show_bug.cgi?id=183766
+
+Reviewed by Antti Koivisto.
+
+Since the formattingContext's lifetime is tied to the layout, the LayoutContext
+should construct it instead.
+
+* LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
+(BlockFormattingContext):
+(BlockFormattingContext.prototype.layout):
+(BlockFormattingContext.prototype._layoutOutOfFlowDescendants):
+(BlockFormattingContext.prototype._contentHeight):
+* LayoutReloaded/FormattingContext/FormattingContext.js:
+(FormattingContext):
+(FormattingContext.prototype.layoutContext):
+(FormattingContext.prototype.toDisplayBox):
+(FormattingContext.prototype._outOfFlowDescendants):
+* LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
+(InlineFormattingContext):
+(InlineFormattingContext.prototype.layout):
+* LayoutReloaded/Layout.js:
+(layout):
+* LayoutReloaded/LayoutContext.js:
+(LayoutContext.prototype.layout):
+(LayoutContext.prototype._createFormattingContext):
+(LayoutContext):
+(LayoutContext.prototype.layoutFormattingContext): Deleted.
+* LayoutReloaded/LayoutTree/Box.js:
+(Layout.Box):
+(Layout.Box.prototype.establishedFormattingContext): Deleted.
+* LayoutReloaded/misc/headers/Box.h:
+
 2018-03-19  Chris Dumez  
 
 Have one service worker process per security origin


Modified: trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js (229738 => 229739)

--- trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js	2018-03-20 03:26:15 UTC (rev 229738)
+++ trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js	2018-03-20 05:02:41 UTC (rev 229739)
@@ -23,13 +23,13 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 class BlockFormattingContext extends FormattingContext {
-constructor(root) {
-super(root);
+constructor(root, layoutContext) {
+super(root, layoutContext);
 // New block formatting context always establishes a new floating context.
 this.m_floatingContext = new FloatingContext(this);
 }
 
-layout(layoutContext) {
+layout() {
 // 9.4.1 Block formatting contexts
 // In a block formatting context, boxes are laid out one after the other, vertically, beginning at the top of a containing block.
 // The vertical distance between two sibling boxes is determined by the 'margin' properties.
@@ -50,7 +50,7 @@
 this.computeWidth(layoutBox);
 this._computeStaticPosition(layoutBox);
 

[webkit-changes] [229738] trunk/Source/JavaScriptCore

[mitz]

Title: [229738] trunk/Source/_javascript_Core








Revision 229738
Author m...@apple.com
Date 2018-03-19 20:26:15 -0700 (Mon, 19 Mar 2018)


Log Message
Investigate why __cpu_indicator_init is used
https://bugs.webkit.org/show_bug.cgi?id=183736

Reviewed by Tim Horton.

__cpu_indicator_init, which is a global initializer, was included in _javascript_Core because
we were passing the -all_load option to the linker, causing it to bring in all members of
every static library being linked in, including the compiler runtime library. We only need
to load all members of WTF. The linker option for doing that is -force_load, and it requires
a path to the library. To support building against libWTF.a built locally as well as against
the copy that is in the SDK, we add a script build phase that palces a symbolic link to the
appropriate libWTF.a under the DerivedSources directory, and pass the path to that symlink
to the linker. Also, while cleaning up linker flags, make OTHER_LDFLAGS_HIDE_SYMBOLS less
verbose by eliminating every other -Wl, remove redundant -lobjc (libobjc is already listed
in the Link Binary With Libraries build phase), remove long-unsupported -Y,3, and stop
reexporting libobjc.

* Configurations/_javascript_Core.xcconfig:
* _javascript_Core.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (229737 => 229738)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-20 02:49:14 UTC (rev 229737)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-20 03:26:15 UTC (rev 229738)
@@ -1,3 +1,25 @@
+2018-03-19  Dan Bernstein  
+
+Investigate why __cpu_indicator_init is used
+https://bugs.webkit.org/show_bug.cgi?id=183736
+
+Reviewed by Tim Horton.
+
+__cpu_indicator_init, which is a global initializer, was included in _javascript_Core because
+we were passing the -all_load option to the linker, causing it to bring in all members of
+every static library being linked in, including the compiler runtime library. We only need
+to load all members of WTF. The linker option for doing that is -force_load, and it requires
+a path to the library. To support building against libWTF.a built locally as well as against
+the copy that is in the SDK, we add a script build phase that palces a symbolic link to the
+appropriate libWTF.a under the DerivedSources directory, and pass the path to that symlink
+to the linker. Also, while cleaning up linker flags, make OTHER_LDFLAGS_HIDE_SYMBOLS less
+verbose by eliminating every other -Wl, remove redundant -lobjc (libobjc is already listed
+in the Link Binary With Libraries build phase), remove long-unsupported -Y,3, and stop
+reexporting libobjc.
+
+* Configurations/_javascript_Core.xcconfig:
+* _javascript_Core.xcodeproj/project.pbxproj:
+
 2018-03-19  Jiewen Tan  
 
 Unreviewed, another quick fix for r229699


Modified: trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig (229737 => 229738)

--- trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig	2018-03-20 02:49:14 UTC (rev 229737)
+++ trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig	2018-03-20 03:26:15 UTC (rev 229738)
@@ -35,11 +35,11 @@
 JSVALUE_MODEL_x86_64 = 64;
 
 // Prevent C++ standard library operator new, delete and their related exception types from being exported as weak symbols.
-OTHER_LDFLAGS_HIDE_SYMBOLS = -Wl,-unexported_symbol -Wl,__ZTISt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTISt9exception -Wl,-unexported_symbol -Wl,__ZTSSt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTSSt9exception -Wl,-unexported_symbol -Wl,__ZdlPvS_ -Wl,-unexported_symbol -Wl,__ZnwmPv -Wl,-unexported_symbol -Wl,__ZNKSt3__18functionIFvvEEclEv -Wl,-unexported_symbol -Wl,__ZNSt3__18functionIFvvEEC1EOS2_ -Wl,-unexported_symbol -Wl,__ZNSt3__18functionIFvvEEC2EOS2_ -Wl,-unexported_symbol -Wl,__ZNKSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEEclES3_S5_ -Wl,-unexported_symbol -Wl,__ZNSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEED1Ev -Wl,-unexported_symbol -Wl,__ZNSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEED2Ev -Wl,-unexported_symbol -Wl,__ZNSt3__18functionIFvvEED1Ev -Wl,-unexported_symbol -Wl,__ZNSt3__18functionIFvvEED2Ev -Wl,-unexported_symbol -Wl,__ZTVNSt3__117bad_function_callE -Wl,-all_load;
+OTHER_LDFLAGS_HIDE_SYMBOLS = -Wl,-unexported_symbol,__ZTISt9bad_alloc -Wl,-unexported_symbol,__ZTISt9exception -Wl,-unexported_symbol,__ZTSSt9bad_alloc -Wl,-unexported_symbol,__ZTSSt9exception -Wl,-unexported_symbol,__ZdlPvS_ -Wl,-unexported_symbol,__ZnwmPv -Wl,-unexported_symbol,__ZNKSt3__18functionIFvvEEclEv -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEEC1EOS2_ -Wl,-unexport

[webkit-changes] [229737] trunk/Source

[megan_gardner]

Title: [229737] trunk/Source








Revision 229737
Author megan_gard...@apple.com
Date 2018-03-19 19:49:14 -0700 (Mon, 19 Mar 2018)


Log Message
Clear style colors when setting default appearance
https://bugs.webkit.org/show_bug.cgi?id=183759

Reviewed by Tim Horton.

Colors are cached and need to be cleared and recalculated.
Source/WebKit:


* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDefaultAppearance):

Source/WebKitLegacy/mac:

Refactor to do all style recalcs together.

* WebView/WebView.mm:
(-[WebView _setDefaultAppearanceAndClearStyle]):
(-[WebView _setUseSystemAppearance:]):
(-[WebView effectiveAppearanceDidChange]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (229736 => 229737)

--- trunk/Source/WebKit/ChangeLog	2018-03-20 02:34:25 UTC (rev 229736)
+++ trunk/Source/WebKit/ChangeLog	2018-03-20 02:49:14 UTC (rev 229737)
@@ -1,3 +1,15 @@
+2018-03-19  Megan Gardner  
+
+Clear style colors when setting default appearance
+https://bugs.webkit.org/show_bug.cgi?id=183759
+
+Reviewed by Tim Horton.
+
+Colors are cached and need to be cleared and recalculated.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::setDefaultAppearance):
+
 2018-03-19  Chris Dumez  
 
 WKWebView.ClearAppCache is a flaky API test failure on High Sierra.


Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (229736 => 229737)

--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2018-03-20 02:34:25 UTC (rev 229736)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2018-03-20 02:49:14 UTC (rev 229737)
@@ -183,6 +183,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -4130,6 +4131,7 @@
 void WebPage::setDefaultAppearance(bool defaultAppearance)
 {
 corePage()->setDefaultAppearance(defaultAppearance);
+RenderTheme::singleton().platformColorsDidChange();
 corePage()->setNeedsRecalcStyleInAllFrames();
 }
 #endif


Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (229736 => 229737)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2018-03-20 02:34:25 UTC (rev 229736)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2018-03-20 02:49:14 UTC (rev 229737)
@@ -1,3 +1,18 @@
+2018-03-19  Megan Gardner  
+
+Clear style colors when setting default appearance
+https://bugs.webkit.org/show_bug.cgi?id=183759
+
+Reviewed by Tim Horton.
+
+Colors are cached and need to be cleared and recalculated.
+Refactor to do all style recalcs together.
+
+* WebView/WebView.mm:
+(-[WebView _setDefaultAppearanceAndClearStyle]):
+(-[WebView _setUseSystemAppearance:]):
+(-[WebView effectiveAppearanceDidChange]):
+
 2018-03-19  Jiewen Tan  
 
 Unreviewed, another quick fix for r229699


Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (229736 => 229737)

--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm	2018-03-20 02:34:25 UTC (rev 229736)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm	2018-03-20 02:49:14 UTC (rev 229737)
@@ -185,6 +185,7 @@
 #import 
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 
@@ -5197,12 +5198,19 @@
 - (bool)_defaultAppearance { return true; }
 #endif
 
+
+- (void)_updateDefaultAppearance
+{
+_private->page->setDefaultAppearance([self _defaultAppearance]);
+RenderTheme::singleton().platformColorsDidChange();
+_private->page->setNeedsRecalcStyleInAllFrames();
+}
+
 - (void)_setUseSystemAppearance:(BOOL)useSystemAppearance
 {
 if (auto page = _private->page) {
 page->setUseSystemAppearance(useSystemAppearance);
-page->setDefaultAppearance([self _defaultAppearance]);
-page->setNeedsRecalcStyleInAllFrames();
+[self _updateDefaultAppearance];
 }
 }
 
@@ -5219,8 +5227,7 @@
 if (!_private->page)
 return;
 
-_private->page->setDefaultAppearance([self _defaultAppearance]);
-_private->page->setNeedsRecalcStyleInAllFrames();
+[self _updateDefaultAppearance];
 }
 
 - (void)_setSourceApplicationAuditData:(NSData *)sourceApplicationAuditData






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229736] trunk/Source/WebKit

[cdumez]

Title: [229736] trunk/Source/WebKit








Revision 229736
Author cdu...@apple.com
Date 2018-03-19 19:34:25 -0700 (Mon, 19 Mar 2018)


Log Message
WKWebView.ClearAppCache is a flaky API test failure on High Sierra.
https://bugs.webkit.org/show_bug.cgi?id=181546


Reviewed by Ryosuke Niwa.

in LocalStorageDatabaseTracker::deleteDatabasesModifiedSince(), add origin
to originIdentifiersToDelete if we cannot determine the last modification
time of the database file. This likely means the database file does not
exist. However, we still needs to make sure the origin gets removed from
the origins database and there may be *.wal / *.shm variants of the database
that are still on disk and need to be deleted.

* UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::deleteDatabasesModifiedSince):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (229735 => 229736)

--- trunk/Source/WebKit/ChangeLog	2018-03-20 02:31:47 UTC (rev 229735)
+++ trunk/Source/WebKit/ChangeLog	2018-03-20 02:34:25 UTC (rev 229736)
@@ -1,5 +1,23 @@
 2018-03-19  Chris Dumez  
 
+WKWebView.ClearAppCache is a flaky API test failure on High Sierra.
+https://bugs.webkit.org/show_bug.cgi?id=181546
+
+
+Reviewed by Ryosuke Niwa.
+
+in LocalStorageDatabaseTracker::deleteDatabasesModifiedSince(), add origin
+to originIdentifiersToDelete if we cannot determine the last modification
+time of the database file. This likely means the database file does not
+exist. However, we still needs to make sure the origin gets removed from
+the origins database and there may be *.wal / *.shm variants of the database
+that are still on disk and need to be deleted.
+
+* UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp:
+(WebKit::LocalStorageDatabaseTracker::deleteDatabasesModifiedSince):
+
+2018-03-19  Chris Dumez  
+
 Have one service worker process per security origin
 https://bugs.webkit.org/show_bug.cgi?id=183600
 


Modified: trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp (229735 => 229736)

--- trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp	2018-03-20 02:31:47 UTC (rev 229735)
+++ trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp	2018-03-20 02:34:25 UTC (rev 229736)
@@ -152,10 +152,7 @@
 String filePath = pathForDatabaseWithOriginIdentifier(origin);
 
 auto modificationTime = FileSystem::getFileModificationTime(filePath);
-if (!modificationTime)
-continue;
-
-if (modificationTime.value() >= time)
+if (!modificationTime || modificationTime.value() >= time)
 originIdentifiersToDelete.append(origin);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229735] trunk

[cdumez]

Title: [229735] trunk








Revision 229735
Author cdu...@apple.com
Date 2018-03-19 19:31:47 -0700 (Mon, 19 Mar 2018)


Log Message
Have one service worker process per security origin
https://bugs.webkit.org/show_bug.cgi?id=183600


Reviewed by Brady Eidson.

Source/WebCore:

Split service workers from different origins into their own processes
for security reasons.

* workers/service/server/SWServer.cpp:
(WebCore::SWServer::addRegistrationFromStore):
(WebCore::SWServer::clear):
(WebCore::SWServer::tryInstallContextData):
(WebCore::SWServer::serverToContextConnectionCreated):
(WebCore::SWServer::installContextData):
(WebCore::SWServer::runServiceWorkerIfNecessary):
(WebCore::SWServer::markAllWorkersAsTerminated):
* workers/service/server/SWServer.h:
* workers/service/server/SWServerToContextConnection.cpp:
(WebCore::SWServerToContextConnection::SWServerToContextConnection):
(WebCore::SWServerToContextConnection::~SWServerToContextConnection):
(WebCore::SWServerToContextConnection::connectionForOrigin):
* workers/service/server/SWServerToContextConnection.h:
(WebCore::SWServerToContextConnection::origin):
* workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::SWServerWorker):
(WebCore::SWServerWorker::securityOrigin const):
(WebCore::SWServerWorker::contextConnection):
* workers/service/server/SWServerWorker.h:

Source/WebKit:

Split service workers from different origins into their own processes
for security reasons.

* StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::startFetch):
(WebKit::WebSWServerConnection::postMessageToServiceWorker):
(WebKit::WebSWServerConnection::scheduleJobInServer):
* StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::WebSWServerToContextConnection):
* StorageProcess/ServiceWorker/WebSWServerToContextConnection.h:
* StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::connectionToContextProcessFromIPCConnection):
(WebKit::StorageProcess::didClose):
(WebKit::StorageProcess::connectionToContextProcessWasClosed):
(WebKit::StorageProcess::needsServerToContextConnectionForOrigin const):
(WebKit::StorageProcess::didReceiveMessage):
(WebKit::StorageProcess::createStorageToWebProcessConnection):
(WebKit::StorageProcess::serverToContextConnectionForOrigin):
(WebKit::StorageProcess::createServerToContextConnection):
* StorageProcess/StorageProcess.h:
* StorageProcess/StorageProcess.messages.in:
* StorageProcess/StorageToWebProcessConnection.cpp:
(WebKit::StorageToWebProcessConnection::didReceiveMessage):
(WebKit::StorageToWebProcessConnection::didClose):
* StorageProcess/StorageToWebProcessConnection.h:
* UIProcess/API/C/WKContext.cpp:
(WKContextTerminateServiceWorkerProcess):
* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _terminateServiceWorkerProcesses]):
(-[WKProcessPool _webPageContentProcessCount]):
(-[WKProcessPool _serviceWorkerProcessCount]):
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveAuthenticationChallenge):
(WebKit::NetworkProcessProxy::canAuthenticateAgainstProtectionSpace):
* UIProcess/ServiceWorkerProcessProxy.cpp:
(WebKit::ServiceWorkerProcessProxy::create):
(WebKit::ServiceWorkerProcessProxy::ServiceWorkerProcessProxy):
* UIProcess/ServiceWorkerProcessProxy.h:
(isType):
* UIProcess/Storage/StorageProcessProxy.cpp:
(WebKit::StorageProcessProxy::getStorageProcessConnection):
(WebKit::StorageProcessProxy::didFinishLaunching):
(WebKit::StorageProcessProxy::establishWorkerContextConnectionToStorageProcess):
(WebKit::StorageProcessProxy::establishWorkerContextConnectionToStorageProcessForExplicitSession):
* UIProcess/Storage/StorageProcessProxy.h:
* UIProcess/Storage/StorageProcessProxy.messages.in:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::getStorageProcessConnection):
(WebKit::WebProcessPool::establishWorkerContextConnectionToStorageProcess):
(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::disconnectProcess):
(WebKit::WebProcessPool::createNewWebProcessRespectingProcessCountLimit):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::updateServiceWorkerUserAgent):
(WebKit::WebProcessPool::mayHaveRegisteredServiceWorkers):
(WebKit::WebProcessPool::pageBeginUsingWebsiteDataStore):
(WebKit::WebProcessPool::terminateServiceWorkerProcesses):
(WebKit::WebProcessPool::updateProcessAssertions):
(WebKit::WebProcessPool::serviceWorkerProcessProxyFromPageID const):
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getStorageProcessConnection):

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/server/SWServer.cpp
trunk/Source/WebCore/workers/service/server/SWServer.h
trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.cpp
trunk/Source/WebCore/

[webkit-changes] [229734] trunk/Tools

[zalan]

Title: [229734] trunk/Tools








Revision 229734
Author za...@apple.com
Date 2018-03-19 19:30:51 -0700 (Mon, 19 Mar 2018)


Log Message
[LayoutReloaded] Remove border/padding/contentBox() functions from Layout.Box
https://bugs.webkit.org/show_bug.cgi?id=183761

Reviewed by Antti Koivisto.

Display.Box has them.

* LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
(BlockFormattingContext.prototype._computeOutOfFlowWidth):
(BlockFormattingContext.prototype._computeOutOfFlowHeight):
(BlockFormattingContext.prototype._horizontalConstraint):
(BlockFormattingContext.prototype._contentHeight):
(BlockFormattingContext.prototype._adjustBottomWithFIXME):
(BlockFormattingContext.prototype._computeOutOfFlowPosition):
* LayoutReloaded/FormattingContext/FloatingContext.js:
(FloatingContext.prototype._availableSpace):
* LayoutReloaded/FormattingContext/FormattingContext.js:
(FormattingContext.prototype.absoluteBorderBox):
(FormattingContext.prototype.absolutePaddingBox):
(FormattingContext.prototype.absoluteContentBox):
* LayoutReloaded/LayoutTree/Box.js:
(Layout.Box.prototype.isDescendantOf):
(Layout.Box):
(Layout.Box.prototype.borderBox): Deleted.
(Layout.Box.prototype.paddingBox): Deleted.
(Layout.Box.prototype.contentBox): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js
trunk/Tools/LayoutReloaded/FormattingContext/FloatingContext.js
trunk/Tools/LayoutReloaded/FormattingContext/FormattingContext.js
trunk/Tools/LayoutReloaded/LayoutTree/Box.js




Diff

Modified: trunk/Tools/ChangeLog (229733 => 229734)

--- trunk/Tools/ChangeLog	2018-03-20 02:27:57 UTC (rev 229733)
+++ trunk/Tools/ChangeLog	2018-03-20 02:30:51 UTC (rev 229734)
@@ -1,3 +1,32 @@
+2018-03-19  Zalan Bujtas  
+
+[LayoutReloaded] Remove border/padding/contentBox() functions from Layout.Box
+https://bugs.webkit.org/show_bug.cgi?id=183761
+
+Reviewed by Antti Koivisto.
+
+Display.Box has them.
+
+* LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
+(BlockFormattingContext.prototype._computeOutOfFlowWidth):
+(BlockFormattingContext.prototype._computeOutOfFlowHeight):
+(BlockFormattingContext.prototype._horizontalConstraint):
+(BlockFormattingContext.prototype._contentHeight):
+(BlockFormattingContext.prototype._adjustBottomWithFIXME):
+(BlockFormattingContext.prototype._computeOutOfFlowPosition):
+* LayoutReloaded/FormattingContext/FloatingContext.js:
+(FloatingContext.prototype._availableSpace):
+* LayoutReloaded/FormattingContext/FormattingContext.js:
+(FormattingContext.prototype.absoluteBorderBox):
+(FormattingContext.prototype.absolutePaddingBox):
+(FormattingContext.prototype.absoluteContentBox):
+* LayoutReloaded/LayoutTree/Box.js:
+(Layout.Box.prototype.isDescendantOf):
+(Layout.Box):
+(Layout.Box.prototype.borderBox): Deleted.
+(Layout.Box.prototype.paddingBox): Deleted.
+(Layout.Box.prototype.contentBox): Deleted.
+
 2018-03-19  Jiewen Tan  
 
 Unreviewed, another quick fix for r229699


Modified: trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js (229733 => 229734)

--- trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js	2018-03-20 02:27:57 UTC (rev 229733)
+++ trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js	2018-03-20 02:30:51 UTC (rev 229734)
@@ -171,7 +171,7 @@
 else if (Utils.isLeftAuto(layoutBox) && !Utils.isWidthAuto(layoutBox) && !Utils.isRightAuto(layoutBox))
 width = Utils.width(layoutBox); // 4
 else if (Utils.isWidthAuto(layoutBox) && !Utils.isLeftAuto(layoutBox) && !Utils.isRightAuto(layoutBox))
-width = Math.max(0, layoutBox.containingBlock().contentBox().width() - Utils.right(layoutBox) - Utils.left(layoutBox)); // 5
+width = Math.max(0, this.toDisplayBox(layoutBox.containingBlock()).contentBox().width() - Utils.right(layoutBox) - Utils.left(layoutBox)); // 5
 else if (Utils.isRightAuto(layoutBox) && !Utils.isLeftAuto(layoutBox) && !Utils.isWidthAuto(layoutBox))
 width = Utils.width(layoutBox); // 6
 else
@@ -219,7 +219,7 @@
 else if (Utils.isTopAuto((layoutBox)) && !Utils.isHeightAuto((layoutBox)) && !Utils.isBottomAuto((layoutBox)))
 height = Utils.height(layoutBox); // 6
 else if (Utils.isHeightAuto((layoutBox)) && !Utils.isTopAuto((layoutBox)) && !Utils.isBottomAuto((layoutBox)))
-height = Math.max(0, layoutBox.containingBlock().contentBox().height() - Utils.bottom(layoutBox) - Utils.top(layoutBox)); // 7
+height = Math.max(0, this.toDisplayBox(layoutBox.containingBlock()).contentBox().height() - Utils.bottom(layoutBox) - Utils.top(layoutBox)); // 7
 else if 

[webkit-changes] [229733] trunk/LayoutTests

[beidson]

Title: [229733] trunk/LayoutTests








Revision 229733
Author beid...@apple.com
Date 2018-03-19 19:27:57 -0700 (Mon, 19 Mar 2018)


Log Message
Add a layout test verifying AppCache resource fetches have the document's cookie in place.
https://bugs.webkit.org/show_bug.cgi?id=183757

Reviewed by Alex Christensen.

* http/tests/appcache/document-cookie-expected.txt: Added.
* http/tests/appcache/document-cookie.php: Added.
* http/tests/appcache/resources/cookie-protected-script.php: Added.
* http/tests/appcache/resources/document-cookie.manifest: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/http/tests/appcache/document-cookie-expected.txt
trunk/LayoutTests/http/tests/appcache/document-cookie.php
trunk/LayoutTests/http/tests/appcache/resources/cookie-protected-script.php
trunk/LayoutTests/http/tests/appcache/resources/document-cookie.manifest




Diff

Modified: trunk/LayoutTests/ChangeLog (229732 => 229733)

--- trunk/LayoutTests/ChangeLog	2018-03-20 01:56:45 UTC (rev 229732)
+++ trunk/LayoutTests/ChangeLog	2018-03-20 02:27:57 UTC (rev 229733)
@@ -1,3 +1,15 @@
+2018-03-19  Brady Eidson  
+
+Add a layout test verifying AppCache resource fetches have the document's cookie in place.
+https://bugs.webkit.org/show_bug.cgi?id=183757
+
+Reviewed by Alex Christensen.
+
+* http/tests/appcache/document-cookie-expected.txt: Added.
+* http/tests/appcache/document-cookie.php: Added.
+* http/tests/appcache/resources/cookie-protected-script.php: Added.
+* http/tests/appcache/resources/document-cookie.manifest: Added.
+
 2018-03-19  Chris Dumez  
 
 Make policy decisions asynchronous


Added: trunk/LayoutTests/http/tests/appcache/document-cookie-expected.txt (0 => 229733)

--- trunk/LayoutTests/http/tests/appcache/document-cookie-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/appcache/document-cookie-expected.txt	2018-03-20 02:27:57 UTC (rev 229733)
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
+This tests that cookies set on the main document are used when accessing resources in the manifest.
+PASSED: Cookie is set to 'bar'


Added: trunk/LayoutTests/http/tests/appcache/document-cookie.php (0 => 229733)

--- trunk/LayoutTests/http/tests/appcache/document-cookie.php	(rev 0)
+++ trunk/LayoutTests/http/tests/appcache/document-cookie.php	2018-03-20 02:27:57 UTC (rev 229733)
@@ -0,0 +1,28 @@
+
+
+
+This tests that cookies set on the main document are used when accessing resources in the manifest.
+Not run yet
+
+if (window.testRunner) {
+testRunner.dumpAsText()
+testRunner.waitUntilDone();
+}
+
+function dynamicScriptLoad() {
+	var script = document.createElement("script");
+	script.type = "text/_javascript_";
+	script.src = "" 
+	document.getElementsByTagName("head")[0].appendChild(script);
+}
+
+function cached()
+{
+	setTimeout("dynamicScriptLoad();", 0);
+}
+
+applicationCache.addEventListener('cached', cached, false);
+
+


Added: trunk/LayoutTests/http/tests/appcache/resources/cookie-protected-script.php (0 => 229733)

--- trunk/LayoutTests/http/tests/appcache/resources/cookie-protected-script.php	(rev 0)
+++ trunk/LayoutTests/http/tests/appcache/resources/cookie-protected-script.php	2018-03-20 02:27:57 UTC (rev 229733)
@@ -0,0 +1,18 @@
+';";
+}
+
+?>
+
+if (cookieVal == "bar")
+	document.getElementById("result").innerHTML = "PASSED: Cookie is set to 'bar'";
+else
+	document.getElementById("result").innerHTML = "FAILED: Cookie should be 'bar', is set to '" + cookieVal + "'";
+
+if (window.testRunner)
+	testRunner.notifyDone();


Added: trunk/LayoutTests/http/tests/appcache/resources/document-cookie.manifest (0 => 229733)

--- trunk/LayoutTests/http/tests/appcache/resources/document-cookie.manifest	(rev 0)
+++ trunk/LayoutTests/http/tests/appcache/resources/document-cookie.manifest	2018-03-20 02:27:57 UTC (rev 229733)
@@ -0,0 +1,4 @@
+CACHE MANIFEST
+/appcache/resources/cookie-protected-script.php
+NETWORK:
+/favicon.ico






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229732] tags/Safari-606.1.9.4

[jmarcell]

Title: [229732] tags/Safari-606.1.9.4








Revision 229732
Author jmarc...@apple.com
Date 2018-03-19 18:56:45 -0700 (Mon, 19 Mar 2018)


Log Message
Cherry-pick r229641. rdar://problem/38421894

Modified Paths

tags/Safari-606.1.9.4/Source/WebKit/ChangeLog
tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
tags/Safari-606.1.9.4/Source/WebKit/UIProcess/ios/WKPDFView.mm
tags/Safari-606.1.9.4/Tools/ChangeLog
tags/Safari-606.1.9.4/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

tags/Safari-606.1.9.4/Tools/TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm




Diff

Modified: tags/Safari-606.1.9.4/Source/WebKit/ChangeLog (229731 => 229732)

--- tags/Safari-606.1.9.4/Source/WebKit/ChangeLog	2018-03-20 01:56:40 UTC (rev 229731)
+++ tags/Safari-606.1.9.4/Source/WebKit/ChangeLog	2018-03-20 01:56:45 UTC (rev 229732)
@@ -1,5 +1,95 @@
 2018-03-19  Jason Marcell  
 
+Cherry-pick r229641. rdar://problem/38421894
+
+2018-03-15  Wenson Hsieh  
+
+[iOS WK2] Hit-testing fails when specifying a large top content inset
+https://bugs.webkit.org/show_bug.cgi?id=183648
+
+
+Reviewed by Tim Horton.
+
+Currently, in the process of computing unobscured content rect in the UI process on iOS, we subtract away parts
+of the view that are obscured by insets (e.g. MobileSafari's chrome). The helper method -[WKWebView
+_computeContentInset] is intended to compute these obscuring insets around the view, but it takes scroll view
+insets into account. This means that if WKWebView's inner scroll view has content insets, we'll end up shrinking
+the unobscured content rect as if the insetted region obscures the viewport; this causes visible content on the
+page to be uninteractible, since WKWebView erroneously thinks it's obscured.
+
+To address this, we rename _computeContentInset to _computeObscuredInset, and make it _not_ affected by the
+scroll view's content insets. From code inspection and testing, all but one of the former call sites of
+_computeContentInset really need the obscured inset instead (see below). The one exception, -[WKWebView
+_adjustedContentOffset:], takes a scroll position from the page and maps it to a content offset in the inner
+UIScrollView (see below for more details).
+
+Tests:  ScrollViewInsetTests.InnerHeightWithLargeTopContentInset
+ScrollViewInsetTests.InnerHeightWithLargeBottomContentInset
+ScrollViewInsetTests.RestoreInitialContentOffsetAfterCrash
+ScrollViewInsetTests.RestoreInitialContentOffsetAfterNavigation
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _setHasCustomContentView:loadedMIMEType:]):
+(-[WKWebView _initialContentOffsetForScrollView]):
+
+See -_contentOffsetAdjustedForObscuredInset: below.
+
+(-[WKWebView _contentOffsetAdjustedForObscuredInset:]):
+
+Formerly -_adjustedContentOffset:. -_contentOffsetAdjustedForObscuredInset: no longer takes scroll view content
+inset into account, and only cares about insets that obscure the view. This means that the scroll position
+(0, 0) in the document now maps to the content offset in the inner UIScrollView, such that the top of the page
+is aligned with the top of the viewport.
+
+However, many call sites of -_adjustedContentOffset: were intended to compute the initial, top-left-most content
+offset in the scroll view to scroll to when resetting the web view (i.e., they pass in CGPointZero for the
+scroll position). An example of this is the scroll position to jump to after web content process termination, or
+the scroll position after main frame navigation. In these cases, we actually want to jump to the top of the
+scroll view, so we do want to use the version of the computed content insets that accounts for scroll view
+insets.
+
+Since these cases are limited to finding the top-left-most scroll position, we pull this out into a separate
+helper method (-_initialContentOffsetForScrollView) and replace calls to
+`-[self _adjustedContentOffset:CGPointZero]` with this instead.
+
+(-[WKWebView _computedObscuredInset]):
+
+A version of -_computeContentInset that doesn't care about scroll view insets. Used whereever we need to account
+for obscured insets rather than the combination of content insets and unobscured insets (e.g.
+-_initialContentOffsetForScrollView).
+
+(-[WKWebView _processDidExit]):
+(-[WKWebView _didCommitLayerTree:]):
+(-[WKWebView _dynamicViewportUpdateChang

[webkit-changes] [229731] tags/Safari-606.1.9.4/Source/WebKit

[jmarcell]

Title: [229731] tags/Safari-606.1.9.4/Source/WebKit








Revision 229731
Author jmarc...@apple.com
Date 2018-03-19 18:56:40 -0700 (Mon, 19 Mar 2018)


Log Message
Cherry-pick r229575. rdar://problem/38535115

Modified Paths

tags/Safari-606.1.9.4/Source/WebKit/ChangeLog
tags/Safari-606.1.9.4/Source/WebKit/UIProcess/CredentialManagement/cocoa/WebCredentialsMessengerProxyCocoa.mm
tags/Safari-606.1.9.4/Source/WebKit/WebKit.xcodeproj/project.pbxproj




Diff

Modified: tags/Safari-606.1.9.4/Source/WebKit/ChangeLog (229730 => 229731)

--- tags/Safari-606.1.9.4/Source/WebKit/ChangeLog	2018-03-20 01:21:23 UTC (rev 229730)
+++ tags/Safari-606.1.9.4/Source/WebKit/ChangeLog	2018-03-20 01:56:40 UTC (rev 229731)
@@ -1,5 +1,21 @@
 2018-03-19  Jason Marcell  
 
+Cherry-pick r229575. rdar://problem/38535115
+
+2018-03-13  Jiewen Tan  
+
+Soft-link LocalAuthentication.Framework
+https://bugs.webkit.org/show_bug.cgi?id=183587
+
+
+Reviewed by Brian Burg.
+
+* UIProcess/CredentialManagement/cocoa/WebCredentialsMessengerProxyCocoa.mm:
+(WebKit::WebCredentialsMessengerProxy::platformIsUserVerifyingPlatformAuthenticatorAvailable):
+* WebKit.xcodeproj/project.pbxproj:
+
+2018-03-19  Jason Marcell  
+
 Cherry-pick r229684. rdar://problem/38516584
 
 2018-03-16  Megan Gardner  


Modified: tags/Safari-606.1.9.4/Source/WebKit/UIProcess/CredentialManagement/cocoa/WebCredentialsMessengerProxyCocoa.mm (229730 => 229731)

--- tags/Safari-606.1.9.4/Source/WebKit/UIProcess/CredentialManagement/cocoa/WebCredentialsMessengerProxyCocoa.mm	2018-03-20 01:21:23 UTC (rev 229730)
+++ tags/Safari-606.1.9.4/Source/WebKit/UIProcess/CredentialManagement/cocoa/WebCredentialsMessengerProxyCocoa.mm	2018-03-20 01:56:40 UTC (rev 229731)
@@ -31,7 +31,11 @@
 #import 
 #import 
 #import 
+#import 
 
+SOFT_LINK_FRAMEWORK(LocalAuthentication)
+SOFT_LINK_CLASS(LocalAuthentication, LAContext);
+
 namespace WebKit {
 
 void WebCredentialsMessengerProxy::platformIsUserVerifyingPlatformAuthenticatorAvailable(uint64_t messageId)
@@ -40,7 +44,7 @@
 ASSERT_UNUSED(messageId, messageId);
 notImplemented();
 #else
-auto context = adoptNS([[LAContext alloc] init]);
+auto context = adoptNS([allocLAContextInstance() init]);
 NSError *error = nil;
 
 if ([context canEvaluatePolicy:LAPolicyDeviceOwnerAuthenticationWithBiometrics error:&error])


Modified: tags/Safari-606.1.9.4/Source/WebKit/WebKit.xcodeproj/project.pbxproj (229730 => 229731)

--- tags/Safari-606.1.9.4/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2018-03-20 01:21:23 UTC (rev 229730)
+++ tags/Safari-606.1.9.4/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2018-03-20 01:56:40 UTC (rev 229731)
@@ -1216,7 +1216,6 @@
 		53BA47D01DC2EF5E004DF4AD /* NetworkDataTaskBlob.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 539EB5461DC2EE40009D48CF /* NetworkDataTaskBlob.cpp */; };
 		53BA47D11DC2EF5E004DF4AD /* NetworkDataTaskBlob.h in Headers */ = {isa = PBXBuildFile; fileRef = 539EB5471DC2EE40009D48CF /* NetworkDataTaskBlob.h */; };
 		53DEA3661DDE423100E82648 /* json.hpp in Headers */ = {isa = PBXBuildFile; fileRef = 53DEA3651DDE422E00E82648 /* json.hpp */; };
-		5750F32B2032D4E500389347 /* LocalAuthentication.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 5750F32A2032D4E500389347 /* LocalAuthentication.framework */; };
 		5760828E2029895E00116678 /* WebCredentialsMessenger.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5760828C2029854200116678 /* WebCredentialsMessenger.cpp */; };
 		57608298202BD8BA00116678 /* WebCredentialsMessengerProxy.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 57608296202BD8BA00116678 /* WebCredentialsMessengerProxy.cpp */; };
 		5760829C202D2C3C00116678 /* WebCredentialsMessengerMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5760829020298FBD00116678 /* WebCredentialsMessengerMessageReceiver.cpp */; };
@@ -4735,7 +4734,6 @@
 			files = (
 3766F9EE189A1241003CF19B /* _javascript_Core.framework in Frameworks */,
 3766F9F1189A1254003CF19B /* libicucore.dylib in Frameworks */,
-5750F32B2032D4E500389347 /* LocalAuthentication.framework in Frameworks */,
 3766F9EF189A1244003CF19B /* QuartzCore.framework in Frameworks */,
 37694525184FC6B600CDE21F /* Security.framework in Frameworks */,
 37BEC4DD1948FC6A008B4286 /* WebCore.framework in Frameworks */,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229730] trunk/Source/WebCore

[megan_gardner]

Title: [229730] trunk/Source/WebCore








Revision 229730
Author megan_gard...@apple.com
Date 2018-03-19 18:21:23 -0700 (Mon, 19 Mar 2018)


Log Message
Have select element respect current appearance
https://bugs.webkit.org/show_bug.cgi?id=183753

Reviewed by Tim Horton.

Not currently testable, will add tests in a later patch.

Have the menu lists/select elements follow the system colors.

* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustMenuListStyle const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (229729 => 229730)

--- trunk/Source/WebCore/ChangeLog	2018-03-20 01:08:53 UTC (rev 229729)
+++ trunk/Source/WebCore/ChangeLog	2018-03-20 01:21:23 UTC (rev 229730)
@@ -1,3 +1,17 @@
+2018-03-19  Megan Gardner  
+
+Have select element respect current appearance
+https://bugs.webkit.org/show_bug.cgi?id=183753
+
+Reviewed by Tim Horton.
+
+Not currently testable, will add tests in a later patch.
+
+Have the menu lists/select elements follow the system colors.
+
+* rendering/RenderThemeMac.mm:
+(WebCore::RenderThemeMac::adjustMenuListStyle const):
+
 2018-03-19  Nan Wang  
 
 AX: embedded attachments do not work correctly with text marker APIs on macOS


Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (229729 => 229730)

--- trunk/Source/WebCore/rendering/RenderThemeMac.mm	2018-03-20 01:08:53 UTC (rev 229729)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm	2018-03-20 01:21:23 UTC (rev 229730)
@@ -1345,8 +1345,12 @@
 style.setWhiteSpace(PRE);
 
 // Set the foreground color to black or gray when we have the aqua look.
-// Cast to RGB32 is to work around a compiler bug.
-style.setColor(e && !e->isDisabledFormControl() ? static_cast(Color::black) : Color::darkGray);
+Color c = Color::darkGray;
+if (e) {
+bool useSystemAppearance = e->document().page()->useSystemAppearance();
+c = !e->isDisabledFormControl() ? systemColor(CSSValueButtontext, useSystemAppearance) : systemColor(CSSValueGraytext, useSystemAppearance);
+}
+style.setColor(c);
 
 // Set the button's vertical size.
 setSizeFromFont(style, menuListButtonSizes());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229729] trunk/Source/WebCore

[n_wang]

Title: [229729] trunk/Source/WebCore








Revision 229729
Author n_w...@apple.com
Date 2018-03-19 18:08:53 -0700 (Mon, 19 Mar 2018)


Log Message
AX: embedded attachments do not work correctly with text marker APIs on macOS
https://bugs.webkit.org/show_bug.cgi?id=183751

Reviewed by Chris Fleizach.

In WebKit1, embedded attachments are not working well with text marker APIs.
We should use the corresponding attachment view in the following cases:
1. Hit testing on an attachment object.
2. Getting the attachment object at a text marker position.
3. Asking for the associated element with NSAccessibilityAttachmentTextAttribute.

Not able to construct a layout test because it relies on embedded attachments.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(AXAttributeStringSetElement):
(-[WebAccessibilityObjectWrapper accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (229728 => 229729)

--- trunk/Source/WebCore/ChangeLog	2018-03-20 00:20:46 UTC (rev 229728)
+++ trunk/Source/WebCore/ChangeLog	2018-03-20 01:08:53 UTC (rev 229729)
@@ -1,3 +1,23 @@
+2018-03-19  Nan Wang  
+
+AX: embedded attachments do not work correctly with text marker APIs on macOS
+https://bugs.webkit.org/show_bug.cgi?id=183751
+
+Reviewed by Chris Fleizach.
+
+In WebKit1, embedded attachments are not working well with text marker APIs.
+We should use the corresponding attachment view in the following cases:
+1. Hit testing on an attachment object.
+2. Getting the attachment object at a text marker position.
+3. Asking for the associated element with NSAccessibilityAttachmentTextAttribute. 
+
+Not able to construct a layout test because it relies on embedded attachments.
+
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+(AXAttributeStringSetElement):
+(-[WebAccessibilityObjectWrapper accessibilityHitTest:]):
+(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
+
 2018-03-19  Jiewen Tan  
 
 Unreviewed, another quick fix for r229699


Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (229728 => 229729)

--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm	2018-03-20 00:20:46 UTC (rev 229728)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm	2018-03-20 01:08:53 UTC (rev 229729)
@@ -1015,7 +1015,11 @@
 if (!cache)
 return;
 
-AXUIElementRef axElement = NSAccessibilityCreateAXUIElementRef(object->wrapper());
+id objectWrapper = object->wrapper();
+if ([attribute isEqualToString:NSAccessibilityAttachmentTextAttribute] && object->isAttachment() && [objectWrapper attachmentView])
+objectWrapper = [objectWrapper attachmentView];
+
+AXUIElementRef axElement = NSAccessibilityCreateAXUIElementRef(objectWrapper);
 if (axElement) {
 [attrString addAttribute:attribute value:(id)axElement range:range];
 CFRelease(axElement);
@@ -3307,8 +3311,11 @@
 
 m_object->updateChildrenIfNecessary();
 RefPtr axObject = m_object->accessibilityHitTest(IntPoint(point));
-if (axObject)
+if (axObject) {
+if (axObject->isAttachment() && [axObject->wrapper() attachmentView])
+return [axObject->wrapper() attachmentView];
 return NSAccessibilityUnignoredAncestor(axObject->wrapper());
+}
 return NSAccessibilityUnignoredAncestor(self);
 }
 
@@ -3991,6 +3998,8 @@
 AccessibilityObject* axObject = [self accessibilityObjectForTextMarker:textMarker];
 if (!axObject)
 return nil;
+if (axObject->isAttachment() && [axObject->wrapper() attachmentView])
+return [axObject->wrapper() attachmentView];
 return axObject->wrapper();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229727] trunk

[jiewen_tan]

Title: [229727] trunk








Revision 229727
Author jiewen_...@apple.com
Date 2018-03-19 16:15:38 -0700 (Mon, 19 Mar 2018)


Log Message
Unreviewed, another quick fix for r229699

Restricts ENABLE_WEB_AUTHN to only macOS and iOS.

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
* TestWebKitAPI/Tests/ios/LocalAuthenticator.mm:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
trunk/Tools/TestWebKitAPI/Tests/ios/LocalAuthenticator.mm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (229726 => 229727)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-19 23:12:19 UTC (rev 229726)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-19 23:15:38 UTC (rev 229727)
@@ -1,3 +1,11 @@
+2018-03-19  Jiewen Tan  
+
+Unreviewed, another quick fix for r229699
+
+Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
+
+* Configurations/FeatureDefines.xcconfig:
+
 2018-03-19  Mark Lam  
 
 FunctionPtr should be passed by value.


Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (229726 => 229727)

--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2018-03-19 23:12:19 UTC (rev 229726)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2018-03-19 23:15:38 UTC (rev 229727)
@@ -326,7 +326,10 @@
 
 ENABLE_WEB_AUDIO = ENABLE_WEB_AUDIO;
 
-ENABLE_WEB_AUTHN = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(PLATFORM_NAME));
+ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(PLATFORM_NAME));
 ENABLE_WEB_RTC_iphoneos = ENABLE_WEB_RTC;


Modified: trunk/Source/WebCore/ChangeLog (229726 => 229727)

--- trunk/Source/WebCore/ChangeLog	2018-03-19 23:12:19 UTC (rev 229726)
+++ trunk/Source/WebCore/ChangeLog	2018-03-19 23:15:38 UTC (rev 229727)
@@ -1,3 +1,11 @@
+2018-03-19  Jiewen Tan  
+
+Unreviewed, another quick fix for r229699
+
+Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
+
+* Configurations/FeatureDefines.xcconfig:
+
 2018-03-19  Daniel Bates  
 
 Fix case of Strong Password localized string


Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (229726 => 229727)

--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2018-03-19 23:12:19 UTC (rev 229726)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2018-03-19 23:15:38 UTC (rev 229727)
@@ -326,7 +326,10 @@
 
 ENABLE_WEB_AUDIO = ENABLE_WEB_AUDIO;
 
-ENABLE_WEB_AUTHN = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(PLATFORM_NAME));
+ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(PLATFORM_NAME));
 ENABLE_WEB_RTC_iphoneos = ENABLE_WEB_RTC;


Modified: trunk/Source/WebCore/PAL/ChangeLog (229726 => 229727)

--- trunk/Source/WebCore/PAL/ChangeLog	2018-03-19 23:12:19 UTC (rev 229726)
+++ trunk/Source/WebCore/PAL/ChangeLog	2018-03-19 23:15:38 UTC (rev 229727)
@@ -1,3 +1,11 @@
+2018-03-19  Jiewen Tan  
+
+Unreviewed, another quick fix for r229699
+
+Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
+
+* Configurations/FeatureDefines.xcconfig:
+
 2018-03-19  Eric Carlson  
 
 [Extra zoom mode] Require fullscreen for video playback


Modified: trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (229726 => 229727)

--- trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2018-03-19 23:12:19 UTC (rev 229726)
+++ trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2018-03-19 23:15:38 UTC (rev 229727)
@@ -326,7 +326,10 @@
 
 ENABLE_WEB_AUDIO = ENABLE_WEB_AUDIO;
 
-ENABLE_WEB_AUTHN = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(PLATFORM_NAME));
+ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(PLATF

[webkit-changes] [229725] trunk/Tools

[zalan]

Title: [229725] trunk/Tools








Revision 229725
Author za...@apple.com
Date 2018-03-19 15:58:10 -0700 (Mon, 19 Mar 2018)


Log Message
[LayoutReloaded] Move statically positioned absolute box positioning to _computeOutOfFlowPosition
https://bugs.webkit.org/show_bug.cgi?id=183750

Reviewed by Antti Koivisto.

* LayoutReloaded/DisplayTree/Box.js:
(Display.Box.prototype.setTop):
(Display.Box.prototype.paddingBox):
(Display.Box.prototype.contentBox):
(Display.Box):
* LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
(BlockFormattingContext.prototype._computeStaticPosition):
(BlockFormattingContext.prototype._layoutOutOfFlowDescendants):
(BlockFormattingContext.prototype._computeOutOfFlowPosition):
* LayoutReloaded/FormattingContext/FormattingContext.js:
(FormattingContext.prototype.absoluteMarginBox):
(FormattingContext.prototype.absoluteBorderBox):
(FormattingContext.prototype.absolutePaddingBox):
(FormattingContext.prototype.absoluteContentBox):
(FormattingContext.prototype._toAbsolutePosition):
(FormattingContext.prototype._toRootAbsolutePosition):
(FormattingContext.prototype.toDisplayBox):
* LayoutReloaded/LayoutTree/InitialBlockContainer.js:
(Layout.InitialBlockContainer.prototype.establishesBlockFormattingContext):
(Layout.InitialBlockContainer):
(Layout.InitialBlockContainer.prototype.paddingBox): Deleted.
(Layout.InitialBlockContainer.prototype.contentBox): Deleted.
* LayoutReloaded/Utils.js:
(Utils.isStaticallyPositioned):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/DisplayTree/Box.js
trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js
trunk/Tools/LayoutReloaded/FormattingContext/FormattingContext.js
trunk/Tools/LayoutReloaded/LayoutTree/InitialBlockContainer.js
trunk/Tools/LayoutReloaded/Utils.js




Diff

Modified: trunk/Tools/ChangeLog (229724 => 229725)

--- trunk/Tools/ChangeLog	2018-03-19 22:47:39 UTC (rev 229724)
+++ trunk/Tools/ChangeLog	2018-03-19 22:58:10 UTC (rev 229725)
@@ -1,3 +1,35 @@
+2018-03-19  Zalan Bujtas  
+
+[LayoutReloaded] Move statically positioned absolute box positioning to _computeOutOfFlowPosition
+https://bugs.webkit.org/show_bug.cgi?id=183750
+
+Reviewed by Antti Koivisto.
+
+* LayoutReloaded/DisplayTree/Box.js:
+(Display.Box.prototype.setTop):
+(Display.Box.prototype.paddingBox):
+(Display.Box.prototype.contentBox):
+(Display.Box):
+* LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
+(BlockFormattingContext.prototype._computeStaticPosition):
+(BlockFormattingContext.prototype._layoutOutOfFlowDescendants):
+(BlockFormattingContext.prototype._computeOutOfFlowPosition):
+* LayoutReloaded/FormattingContext/FormattingContext.js:
+(FormattingContext.prototype.absoluteMarginBox):
+(FormattingContext.prototype.absoluteBorderBox):
+(FormattingContext.prototype.absolutePaddingBox):
+(FormattingContext.prototype.absoluteContentBox):
+(FormattingContext.prototype._toAbsolutePosition):
+(FormattingContext.prototype._toRootAbsolutePosition):
+(FormattingContext.prototype.toDisplayBox):
+* LayoutReloaded/LayoutTree/InitialBlockContainer.js:
+(Layout.InitialBlockContainer.prototype.establishesBlockFormattingContext):
+(Layout.InitialBlockContainer):
+(Layout.InitialBlockContainer.prototype.paddingBox): Deleted.
+(Layout.InitialBlockContainer.prototype.contentBox): Deleted.
+* LayoutReloaded/Utils.js:
+(Utils.isStaticallyPositioned):
+
 2018-03-19  Chris Dumez  
 
 WebKit.WebsitePoliciesAutoplayQuirks API test times out with async policy delegates


Modified: trunk/Tools/LayoutReloaded/DisplayTree/Box.js (229724 => 229725)

--- trunk/Tools/LayoutReloaded/DisplayTree/Box.js	2018-03-19 22:47:39 UTC (rev 229724)
+++ trunk/Tools/LayoutReloaded/DisplayTree/Box.js	2018-03-19 22:58:10 UTC (rev 229725)
@@ -75,6 +75,10 @@
 this.m_rect.setTopLeft(topLeft);
 }
 
+setTop(top) {
+this.m_rect.setTop(top);
+}
+
 setSize(size) {
 this.m_rect.setSize(size);
 }
@@ -92,6 +96,9 @@
 }
 
 paddingBox() {
+// ICB does not have associated node.
+if (!this.m_node)
+return this.borderBox();
 let paddingBox = this.borderBox();
 let borderSize = Utils.computedBorderTopLeft(this.m_node);
 paddingBox.moveBy(borderSize);
@@ -101,6 +108,9 @@
 }
 
 contentBox() {
+// ICB does not have associated node.
+if (!this.m_node)
+return this.borderBox();
 let contentBox = this.paddingBox();
 let paddingSize = Utils.computedPaddingTopLeft(this.m_node);
 contentBox.moveBy(paddingSize);


Modified: trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js (229724 => 229725)

--- trunk/Tools/LayoutReloaded/Forma

[webkit-changes] [229724] trunk/Source/WebCore

[dbates]

Title: [229724] trunk/Source/WebCore








Revision 229724
Author dba...@webkit.org
Date 2018-03-19 15:47:39 -0700 (Mon, 19 Mar 2018)


Log Message
Fix case of Strong Password localized string

* English.lproj/Localizable.strings:
* platform/LocalizedStrings.cpp:
(WebCore::autoFillStrongPasswordLabel):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/Localizable.strings
trunk/Source/WebCore/platform/LocalizedStrings.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (229723 => 229724)

--- trunk/Source/WebCore/ChangeLog	2018-03-19 22:31:30 UTC (rev 229723)
+++ trunk/Source/WebCore/ChangeLog	2018-03-19 22:47:39 UTC (rev 229724)
@@ -1,3 +1,11 @@
+2018-03-19  Daniel Bates  
+
+Fix case of Strong Password localized string
+
+* English.lproj/Localizable.strings:
+* platform/LocalizedStrings.cpp:
+(WebCore::autoFillStrongPasswordLabel):
+
 2018-03-19  Chris Dumez  
 
 WebKit.WebsitePoliciesAutoplayQuirks API test times out with async policy delegates


Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (229723 => 229724)

--- trunk/Source/WebCore/English.lproj/Localizable.strings	2018-03-19 22:31:30 UTC (rev 229723)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings	2018-03-19 22:47:39 UTC (rev 229724)
@@ -1202,7 +1202,7 @@
 "strong confirmation password auto fill" = "strong confirmation password auto fill";
 
 /* Label for strong password. */
-"strong password" = "strong password";
+"Strong Password" = "Strong Password";
 
 /* Label for the strong password auto fill button inside a text field. */
 "strong password auto fill" = "strong password auto fill";


Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (229723 => 229724)

--- trunk/Source/WebCore/platform/LocalizedStrings.cpp	2018-03-19 22:31:30 UTC (rev 229723)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp	2018-03-19 22:47:39 UTC (rev 229724)
@@ -637,7 +637,7 @@
 
 String autoFillStrongPasswordLabel()
 {
-return WEB_UI_STRING("strong password", "Label for strong password.");
+return WEB_UI_STRING("Strong Password", "Label for strong password.");
 }
 
 String missingPluginText()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229723] tags/Safari-606.1.9.3.1/Source

[jmarcell]

Title: [229723] tags/Safari-606.1.9.3.1/Source








Revision 229723
Author jmarc...@apple.com
Date 2018-03-19 15:31:30 -0700 (Mon, 19 Mar 2018)


Log Message
Versioning.

Modified Paths

tags/Safari-606.1.9.3.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-606.1.9.3.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-606.1.9.3.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-606.1.9.3.1/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-606.1.9.3.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-606.1.9.3.1/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-606.1.9.3.1/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-606.1.9.3.1/Source/_javascript_Core/Configurations/Version.xcconfig (229722 => 229723)

--- tags/Safari-606.1.9.3.1/Source/_javascript_Core/Configurations/Version.xcconfig	2018-03-19 22:30:57 UTC (rev 229722)
+++ tags/Safari-606.1.9.3.1/Source/_javascript_Core/Configurations/Version.xcconfig	2018-03-19 22:31:30 UTC (rev 229723)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
 MICRO_VERSION = 3;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.9.3.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (229722 => 229723)

--- tags/Safari-606.1.9.3.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-03-19 22:30:57 UTC (rev 229722)
+++ tags/Safari-606.1.9.3.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-03-19 22:31:30 UTC (rev 229723)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
 MICRO_VERSION = 3;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.9.3.1/Source/WebCore/Configurations/Version.xcconfig (229722 => 229723)

--- tags/Safari-606.1.9.3.1/Source/WebCore/Configurations/Version.xcconfig	2018-03-19 22:30:57 UTC (rev 229722)
+++ tags/Safari-606.1.9.3.1/Source/WebCore/Configurations/Version.xcconfig	2018-03-19 22:31:30 UTC (rev 229723)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
 MICRO_VERSION = 3;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.9.3.1/Source/WebCore/PAL/Configurations/Version.xcconfig (229722 => 229723)

--- tags/Safari-606.1.9.3.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-03-19 22:30:57 UTC (rev 229722)
+++ tags/Safari-606.1.9.3.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-03-19 22:31:30 UTC (rev 229723)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
 MICRO_VERSION = 3;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.9.3.1/Source/WebInspectorUI/Configurations/Version.xcconfig (229722 => 229723)

--- tags/Safari-606.1.9.3.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-03-19 22:30:57 UTC (rev 229722)
+++ tags/Safari-606.1.9.3.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-03-19 22:31:30 UTC (rev 229723)
@@ -2,8 +2,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
 MICRO_VERSION = 3;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-606.1.9.3.1/Source/WebKit/Configurations/Version.xcconfig (229722 => 229723)

--- tags/Safari-606.1.9.3.1/Source/WebKit/Configurations/Version.xcconfig	2018-03-19 22:30:57 UTC (rev 229722)
+++ tags/Safari-606.1.9.3.1/Source/WebKit/Configur

[webkit-changes] [229722] trunk

[cdumez]

Title: [229722] trunk








Revision 229722
Author cdu...@apple.com
Date 2018-03-19 15:30:57 -0700 (Mon, 19 Mar 2018)


Log Message
WebKit.WebsitePoliciesAutoplayQuirks API test times out with async policy delegates
https://bugs.webkit.org/show_bug.cgi?id=183702


Reviewed by Alex Christensen.

Source/WebCore:

The issue is that the test calls loadHTMLString then loadRequest right after, without
waiting for the first load to complete first. loadHTMLString is special as it relies
on substitute data and which schedules a timer to commit the data. When doing the
navigation policy check for the following loadRequest(), the substitute data timer
would fire and commit its data and load. This would in turn cancel the pending
navigation policy check for the loadRequest().

With sync policy delegates, this is not an issue because we take care of stopping
all loaders when receiving the policy decision, which happens synchronously. However,
when the policy decision happens asynchronously, the pending substitute data load
does not get cancelled in time and it gets committed.

To address the issue, we now cancel any pending provisional load before doing the
navigation policy check.

Test: fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-async-delegate.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::clearProvisionalLoadForPolicyCheck):
* loader/FrameLoader.h:
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
Cancel any pending provisional load before starting the navigation policy check. This call
needs to be here rather than in the call site of policyChecker().checkNavigationPolicy()
because there is code in PolicyChecker::checkNavigationPolicy() which relies on
FrameLoader::activeDocumentLoader().
Also, we only cancel the provisional load if there is a policy document loader. In some
rare cases (when we receive a redirect after navigation policy has been decided for the
initial request), the provisional document loader needs to receive navigation policy
decisions so we cannot clear the provisional document loader in such case.

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(-[AsyncAutoplayPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[AsyncAutoplayPoliciesDelegate _webView:handleAutoplayEvent:withFlags:]):
(TEST):

LayoutTests:

Add variant of fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash.html with async navigation
delegate since the previous iteration of this patch broke this test case.

* fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-async-delegate-expected.txt: Added.
* fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-async-delegate.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/FrameLoader.h
trunk/Source/WebCore/loader/PolicyChecker.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm


Added Paths

trunk/LayoutTests/fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-async-delegate-expected.txt
trunk/LayoutTests/fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-async-delegate.html




Diff

Modified: trunk/LayoutTests/ChangeLog (229721 => 229722)

--- trunk/LayoutTests/ChangeLog	2018-03-19 22:05:17 UTC (rev 229721)
+++ trunk/LayoutTests/ChangeLog	2018-03-19 22:30:57 UTC (rev 229722)
@@ -1,3 +1,17 @@
+2018-03-19  Chris Dumez  
+
+WebKit.WebsitePoliciesAutoplayQuirks API test times out with async policy delegates
+https://bugs.webkit.org/show_bug.cgi?id=183702
+
+
+Reviewed by Alex Christensen.
+
+Add variant of fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash.html with async navigation
+delegate since the previous iteration of this patch broke this test case.
+
+* fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-async-delegate-expected.txt: Added.
+* fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-async-delegate.html: Added.
+
 2018-03-17  Jiewen Tan  
 
 [WebAuthN] Implement authenticatorMakeCredential


Added: trunk/LayoutTests/fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-async-delegate-expected.txt (0 => 229722)

--- trunk/LayoutTests/fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-async-delegate-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-async-delegate-expected.txt	2018-03-19 22:30:57 UTC (rev 229722)
@@ -0,0 +1,6 @@
+
+
+
+Frame: '-->'
+
+PASS did not crash.


Added: trunk/LayoutTests/fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-async-delegate.html (0

[webkit-changes] [229721] trunk/Source/ThirdParty/ANGLE

[clopez]

Title: [229721] trunk/Source/ThirdParty/ANGLE








Revision 229721
Author clo...@igalia.com
Date 2018-03-19 15:05:17 -0700 (Mon, 19 Mar 2018)


Log Message
REGRESSION(r225340): WPE port should not be getting EGL X11 types on ANGLE
https://bugs.webkit.org/show_bug.cgi?id=183749

Reviewed by Alex Christensen.

Add back the USE_WPE ifdef.

* changes.diff:
* include/EGL/eglplatform.h:

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/changes.diff
trunk/Source/ThirdParty/ANGLE/include/EGL/eglplatform.h




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (229720 => 229721)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2018-03-19 21:46:41 UTC (rev 229720)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2018-03-19 22:05:17 UTC (rev 229721)
@@ -1,3 +1,15 @@
+2018-03-19  Carlos Alberto Lopez Perez  
+
+REGRESSION(r225340): WPE port should not be getting EGL X11 types on ANGLE
+https://bugs.webkit.org/show_bug.cgi?id=183749
+
+Reviewed by Alex Christensen.
+
+Add back the USE_WPE ifdef.
+
+* changes.diff:
+* include/EGL/eglplatform.h:
+
 2018-03-15  Tim Horton  
 
 Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in ANGLE


Modified: trunk/Source/ThirdParty/ANGLE/changes.diff (229720 => 229721)

--- trunk/Source/ThirdParty/ANGLE/changes.diff	2018-03-19 21:46:41 UTC (rev 229720)
+++ trunk/Source/ThirdParty/ANGLE/changes.diff	2018-03-19 22:05:17 UTC (rev 229721)
@@ -8066,3 +8066,16 @@
  bool EndObject(SizeType memberCount = 0) {
  (void)memberCount;
  RAPIDJSON_ASSERT(level_stack_.GetSize() >= sizeof(Level));
+diff --git a/include/EGL/eglplatform.h b/include/EGL/eglplatform.h
+index 333448be348..47d18093c96 100644
+--- a/include/EGL/eglplatform.h
 b/include/EGL/eglplatform.h
+@@ -100,7 +100,7 @@ typedef struct ANativeWindow*   EGLNativeWindowType;
+ typedef struct egl_native_pixmap_t* EGLNativePixmapType;
+ typedef void*   EGLNativeDisplayType;
+ 
+-#elif defined(USE_OZONE)
++#elif defined(USE_OZONE) || defined(USE_WPE)
+ 
+ typedef intptr_t EGLNativeDisplayType;
+ typedef intptr_t EGLNativeWindowType;


Modified: trunk/Source/ThirdParty/ANGLE/include/EGL/eglplatform.h (229720 => 229721)

--- trunk/Source/ThirdParty/ANGLE/include/EGL/eglplatform.h	2018-03-19 21:46:41 UTC (rev 229720)
+++ trunk/Source/ThirdParty/ANGLE/include/EGL/eglplatform.h	2018-03-19 22:05:17 UTC (rev 229721)
@@ -100,7 +100,7 @@
 typedef struct egl_native_pixmap_t* EGLNativePixmapType;
 typedef void*   EGLNativeDisplayType;
 
-#elif defined(USE_OZONE)
+#elif defined(USE_OZONE) || defined(USE_WPE)
 
 typedef intptr_t EGLNativeDisplayType;
 typedef intptr_t EGLNativeWindowType;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229720] tags/Safari-606.1.9.3.1/

[jmarcell]

Title: [229720] tags/Safari-606.1.9.3.1/








Revision 229720
Author jmarc...@apple.com
Date 2018-03-19 14:46:41 -0700 (Mon, 19 Mar 2018)


Log Message
New tag.

Added Paths

tags/Safari-606.1.9.3.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229716] tags/Safari-606.1.9.4/Source

[jmarcell]

Title: [229716] tags/Safari-606.1.9.4/Source








Revision 229716
Author jmarc...@apple.com
Date 2018-03-19 14:27:09 -0700 (Mon, 19 Mar 2018)


Log Message
Versioning.

Modified Paths

tags/Safari-606.1.9.4/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-606.1.9.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-606.1.9.4/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-606.1.9.4/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-606.1.9.4/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-606.1.9.4/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-606.1.9.4/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-606.1.9.4/Source/_javascript_Core/Configurations/Version.xcconfig (229715 => 229716)

--- tags/Safari-606.1.9.4/Source/_javascript_Core/Configurations/Version.xcconfig	2018-03-19 21:22:51 UTC (rev 229715)
+++ tags/Safari-606.1.9.4/Source/_javascript_Core/Configurations/Version.xcconfig	2018-03-19 21:27:09 UTC (rev 229716)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-606.1.9.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (229715 => 229716)

--- tags/Safari-606.1.9.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-03-19 21:22:51 UTC (rev 229715)
+++ tags/Safari-606.1.9.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-03-19 21:27:09 UTC (rev 229716)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-606.1.9.4/Source/WebCore/Configurations/Version.xcconfig (229715 => 229716)

--- tags/Safari-606.1.9.4/Source/WebCore/Configurations/Version.xcconfig	2018-03-19 21:22:51 UTC (rev 229715)
+++ tags/Safari-606.1.9.4/Source/WebCore/Configurations/Version.xcconfig	2018-03-19 21:27:09 UTC (rev 229716)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-606.1.9.4/Source/WebCore/PAL/Configurations/Version.xcconfig (229715 => 229716)

--- tags/Safari-606.1.9.4/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-03-19 21:22:51 UTC (rev 229715)
+++ tags/Safari-606.1.9.4/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-03-19 21:27:09 UTC (rev 229716)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-606.1.9.4/Source/WebInspectorUI/Configurations/Version.xcconfig (229715 => 229716)

--- tags/Safari-606.1.9.4/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-03-19 21:22:51 UTC (rev 229715)
+++ tags/Safari-606.1.9.4/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-03-19 21:27:09 UTC (rev 229716)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-606.1.9.4/Source/WebKit/Configurations/Version.xcconfig (229715 => 229716)

--- tags/Safari-606.1.9.4/Source/WebKit/Configurations/Version.xcconfig	2018-03-19 21:22:51 UTC (rev 229715)
+++ tags/Safari-606.1.9.4/Source/WebKit/Configurations/Version.xcconfig	2018-03-19 21:27:09 UTC (rev 229716)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-606.1.9.4/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (229715 => 229716)

--- tags/Safari-606.1.9.4/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-03-19 21:22:51 UTC (rev 229715)
+++ tags/Safari-606.1.9.4/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-03-19 21:27:09 UTC (rev 229716)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229718] tags/Safari-606.1.9.4/Source

[jmarcell]

Title: [229718] tags/Safari-606.1.9.4/Source








Revision 229718
Author jmarc...@apple.com
Date 2018-03-19 14:27:23 -0700 (Mon, 19 Mar 2018)


Log Message
Cherry-pick r229679. rdar://problem/38385900

Modified Paths

tags/Safari-606.1.9.4/Source/WebCore/ChangeLog
tags/Safari-606.1.9.4/Source/WebCore/page/Page.h
tags/Safari-606.1.9.4/Source/WebKit/ChangeLog
tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
tags/Safari-606.1.9.4/Source/WebKit/WebProcess/WebPage/WebPage.cpp
tags/Safari-606.1.9.4/Source/WebKitLegacy/mac/ChangeLog
tags/Safari-606.1.9.4/Source/WebKitLegacy/mac/WebView/WebView.mm




Diff

Modified: tags/Safari-606.1.9.4/Source/WebCore/ChangeLog (229717 => 229718)

--- tags/Safari-606.1.9.4/Source/WebCore/ChangeLog	2018-03-19 21:27:18 UTC (rev 229717)
+++ tags/Safari-606.1.9.4/Source/WebCore/ChangeLog	2018-03-19 21:27:23 UTC (rev 229718)
@@ -1,5 +1,21 @@
 2018-03-19  Jason Marcell  
 
+Cherry-pick r229679. rdar://problem/38385900
+
+2018-03-16  Megan Gardner  
+
+Ensure that style is updated when the effective appearance changes
+https://bugs.webkit.org/show_bug.cgi?id=183690
+
+
+Reviewed by Tim Horton and Wenson Hsieh.
+
+Only exposing a function to outside WebCore, no tests needed.
+
+* page/Page.h:
+
+2018-03-19  Jason Marcell  
+
 Cherry-pick r229654. rdar://problem/38382934
 
 2018-03-15  Megan Gardner  


Modified: tags/Safari-606.1.9.4/Source/WebCore/page/Page.h (229717 => 229718)

--- tags/Safari-606.1.9.4/Source/WebCore/page/Page.h	2018-03-19 21:27:18 UTC (rev 229717)
+++ tags/Safari-606.1.9.4/Source/WebCore/page/Page.h	2018-03-19 21:27:23 UTC (rev 229718)
@@ -160,7 +160,7 @@
 
 WEBCORE_EXPORT uint64_t renderTreeSize() const;
 
-void setNeedsRecalcStyleInAllFrames();
+WEBCORE_EXPORT void setNeedsRecalcStyleInAllFrames();
 
 WEBCORE_EXPORT ViewportArguments viewportArguments() const;
 


Modified: tags/Safari-606.1.9.4/Source/WebKit/ChangeLog (229717 => 229718)

--- tags/Safari-606.1.9.4/Source/WebKit/ChangeLog	2018-03-19 21:27:18 UTC (rev 229717)
+++ tags/Safari-606.1.9.4/Source/WebKit/ChangeLog	2018-03-19 21:27:23 UTC (rev 229718)
@@ -1,3 +1,22 @@
+2018-03-19  Jason Marcell  
+
+Cherry-pick r229679. rdar://problem/38385900
+
+2018-03-16  Megan Gardner  
+
+Ensure that style is updated when the effective appearance changes
+https://bugs.webkit.org/show_bug.cgi?id=183690
+
+
+Reviewed by Tim Horton and Wenson Hsieh.
+
+Respond to and respect the effective appearance changing.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView effectiveAppearanceDidChange]):
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::setDefaultAppearance):
+
 2018-03-16  Jason Marcell  
 
 Cherry-pick r229597. rdar://problem/38431469


Modified: tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (229717 => 229718)

--- tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2018-03-19 21:27:18 UTC (rev 229717)
+++ tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2018-03-19 21:27:23 UTC (rev 229718)
@@ -6167,6 +6167,11 @@
 _page->setDefaultAppearance([self _defaultAppearance]);
 }
 
+- (void)effectiveAppearanceDidChange
+{
+_page->setDefaultAppearance([self _defaultAppearance]);
+}
+
 - (void)_setHeaderBannerHeight:(int)height
 {
 _page->setHeaderBannerHeightForTesting(height);


Modified: tags/Safari-606.1.9.4/Source/WebKit/WebProcess/WebPage/WebPage.cpp (229717 => 229718)

--- tags/Safari-606.1.9.4/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2018-03-19 21:27:18 UTC (rev 229717)
+++ tags/Safari-606.1.9.4/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2018-03-19 21:27:23 UTC (rev 229718)
@@ -4130,6 +4130,7 @@
 void WebPage::setDefaultAppearance(bool defaultAppearance)
 {
 corePage()->setDefaultAppearance(defaultAppearance);
+corePage()->setNeedsRecalcStyleInAllFrames();
 }
 #endif
 


Modified: tags/Safari-606.1.9.4/Source/WebKitLegacy/mac/ChangeLog (229717 => 229718)

--- tags/Safari-606.1.9.4/Source/WebKitLegacy/mac/ChangeLog	2018-03-19 21:27:18 UTC (rev 229717)
+++ tags/Safari-606.1.9.4/Source/WebKitLegacy/mac/ChangeLog	2018-03-19 21:27:23 UTC (rev 229718)
@@ -1,5 +1,23 @@
 2018-03-19  Jason Marcell  
 
+Cherry-pick r229679. rdar://problem/38385900
+
+2018-03-16  Megan Gardner  
+
+Ensure that style is updated when the effective appearance changes
+https://bugs.webkit.org/show_bug.cgi?id=183690
+
+
+Reviewed by Tim Horton and Wenson Hsieh.
+
+Respond to and respect the effective appearance changing.
+
+* WebView/WebView.mm:
+(-[WebView _setUseSystemAppearance:]):
+(-[WebView effectiveAppearanceDidChange]):
+
+2018-03-19  Jason Marcell  
+
 Cherry-pick r229654. rdar:/

[webkit-changes] [229717] tags/Safari-606.1.9.4/Source

[jmarcell]

Title: [229717] tags/Safari-606.1.9.4/Source








Revision 229717
Author jmarc...@apple.com
Date 2018-03-19 14:27:18 -0700 (Mon, 19 Mar 2018)


Log Message
Cherry-pick r229654. rdar://problem/38382934

Modified Paths

tags/Safari-606.1.9.4/Source/WebCore/ChangeLog
tags/Safari-606.1.9.4/Source/WebCore/Sources.txt
tags/Safari-606.1.9.4/Source/WebCore/WebCore.xcodeproj/project.pbxproj
tags/Safari-606.1.9.4/Source/WebCore/css/MediaList.cpp
tags/Safari-606.1.9.4/Source/WebCore/css/MediaList.h
tags/Safari-606.1.9.4/Source/WebCore/css/MediaQueryEvaluator.cpp
tags/Safari-606.1.9.4/Source/WebCore/css/MediaQueryExpression.cpp
tags/Safari-606.1.9.4/Source/WebCore/css/MediaQueryExpression.h
tags/Safari-606.1.9.4/Source/WebCore/css/MediaQueryMatcher.cpp
tags/Safari-606.1.9.4/Source/WebCore/css/StyleMedia.cpp
tags/Safari-606.1.9.4/Source/WebCore/css/StyleRuleImport.cpp
tags/Safari-606.1.9.4/Source/WebCore/css/parser/CSSParser.cpp
tags/Safari-606.1.9.4/Source/WebCore/css/parser/CSSParserImpl.cpp
tags/Safari-606.1.9.4/Source/WebCore/css/parser/MediaQueryParser.cpp
tags/Safari-606.1.9.4/Source/WebCore/css/parser/MediaQueryParser.h
tags/Safari-606.1.9.4/Source/WebCore/css/parser/SizesAttributeParser.cpp
tags/Safari-606.1.9.4/Source/WebCore/dom/InlineStyleSheetOwner.cpp
tags/Safari-606.1.9.4/Source/WebCore/dom/ProcessingInstruction.cpp
tags/Safari-606.1.9.4/Source/WebCore/html/HTMLImageElement.cpp
tags/Safari-606.1.9.4/Source/WebCore/html/HTMLLinkElement.cpp
tags/Safari-606.1.9.4/Source/WebCore/html/HTMLLinkElement.h
tags/Safari-606.1.9.4/Source/WebCore/html/HTMLMediaElement.cpp
tags/Safari-606.1.9.4/Source/WebCore/html/HTMLSourceElement.cpp
tags/Safari-606.1.9.4/Source/WebCore/html/HTMLSourceElement.h
tags/Safari-606.1.9.4/Source/WebCore/html/HTMLStyleElement.cpp
tags/Safari-606.1.9.4/Source/WebCore/html/parser/HTMLPreloadScanner.cpp
tags/Safari-606.1.9.4/Source/WebKitLegacy/mac/ChangeLog
tags/Safari-606.1.9.4/Source/WebKitLegacy/mac/DOM/DOM.mm


Added Paths

tags/Safari-606.1.9.4/Source/WebCore/css/MediaQueryParserContext.cpp
tags/Safari-606.1.9.4/Source/WebCore/css/MediaQueryParserContext.h




Diff

Modified: tags/Safari-606.1.9.4/Source/WebCore/ChangeLog (229716 => 229717)

--- tags/Safari-606.1.9.4/Source/WebCore/ChangeLog	2018-03-19 21:27:09 UTC (rev 229716)
+++ tags/Safari-606.1.9.4/Source/WebCore/ChangeLog	2018-03-19 21:27:18 UTC (rev 229717)
@@ -1,3 +1,86 @@
+2018-03-19  Jason Marcell  
+
+Cherry-pick r229654. rdar://problem/38382934
+
+2018-03-15  Megan Gardner  
+
+Create MediaQueryParserContext to provide additional context for the evaluation of media queries
+https://bugs.webkit.org/show_bug.cgi?id=183677
+
+Reviewed by Tim Horton.
+
+We need additional context for parsing media queries to make sure they are parsed correctly and valid.
+
+Not currently testable, will add tests in a later patch.
+
+* WebCore.xcodeproj/project.pbxproj:
+* css/MediaList.cpp:
+(WebCore::MediaQuerySet::create):
+(WebCore::MediaQuerySet::set):
+(WebCore::MediaQuerySet::add):
+(WebCore::MediaQuerySet::remove):
+* css/MediaList.h:
+* css/MediaQueryEvaluator.cpp:
+(WebCore::MediaQueryEvaluator::mediaAttributeMatches):
+* css/MediaQueryExpression.cpp:
+(WebCore::featureWithValidIdent):
+(WebCore::featureWithValidDensity):
+(WebCore::featureWithValidPositiveLength):
+(WebCore::featureWithPositiveInteger):
+(WebCore::featureWithPositiveNumber):
+(WebCore::featureWithZeroOrOne):
+(WebCore::isFeatureValidWithoutValue):
+(WebCore::MediaQueryExpression::MediaQueryExpression):
+* css/MediaQueryExpression.h:
+* css/MediaQueryMatcher.cpp:
+(WebCore::MediaQueryMatcher::matchMedia):
+* css/MediaQueryParserContext.cpp: Added.
+(WebCore::MediaQueryParserContext::MediaQueryParserContext):
+* css/MediaQueryParserContext.h: Added.
+(WebCore::MediaQueryParserContext::MediaQueryParserContext):
+* css/StyleMedia.cpp:
+(WebCore::StyleMedia::matchMedium const):
+* css/StyleRuleImport.cpp:
+(WebCore::StyleRuleImport::StyleRuleImport):
+(WebCore::StyleRuleImport::setCSSStyleSheet):
+* css/parser/CSSParser.cpp:
+(WebCore::CSSParserContext::CSSParserContext):
+(WebCore::operator==):
+* css/parser/CSSParserImpl.cpp:
+(WebCore::CSSParserImpl::consumeImportRule):
+(WebCore::CSSParserImpl::consumeMediaRule):
+* css/parser/MediaQueryParser.cpp:
+(WebCore::MediaQueryParser::parseMediaQuerySet):
+(WebCore::MediaQueryParser::parseMediaCondition):
+(WebCore::MediaQueryParser::MediaQueryParser):
+(WebCore::MediaQuer

[webkit-changes] [229719] tags/Safari-606.1.9.4/Source/WebKit

[jmarcell]

Title: [229719] tags/Safari-606.1.9.4/Source/WebKit








Revision 229719
Author jmarc...@apple.com
Date 2018-03-19 14:27:26 -0700 (Mon, 19 Mar 2018)


Log Message
Cherry-pick r229684. rdar://problem/38516584

Modified Paths

tags/Safari-606.1.9.4/Source/WebKit/ChangeLog
tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h
tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/mac/WKView.mm
tags/Safari-606.1.9.4/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h
tags/Safari-606.1.9.4/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm




Diff

Modified: tags/Safari-606.1.9.4/Source/WebKit/ChangeLog (229718 => 229719)

--- tags/Safari-606.1.9.4/Source/WebKit/ChangeLog	2018-03-19 21:27:23 UTC (rev 229718)
+++ tags/Safari-606.1.9.4/Source/WebKit/ChangeLog	2018-03-19 21:27:26 UTC (rev 229719)
@@ -1,5 +1,36 @@
 2018-03-19  Jason Marcell  
 
+Cherry-pick r229684. rdar://problem/38516584
+
+2018-03-16  Megan Gardner  
+
+Add _useSystemAppearance to WKView
+https://bugs.webkit.org/show_bug.cgi?id=183706
+
+
+Reviewed by Tim Horton.
+
+Plumb useSystemAppearance and other supporting functions to WKView
+
+* UIProcess/API/Cocoa/WKViewPrivate.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _initializeWithConfiguration:]):
+(-[WKWebView _useSystemAppearance]):
+(-[WKWebView _setUseSystemAppearance:]):
+(-[WKWebView effectiveAppearanceDidChange]):
+* UIProcess/API/mac/WKView.mm:
+(-[WKView effectiveAppearanceDidChange]):
+(-[WKView _setUseSystemAppearance:]):
+(-[WKView _useSystemAppearance]):
+(-[WKView _setDefaultAppearance:]):
+* UIProcess/Cocoa/WebViewImpl.h:
+* UIProcess/Cocoa/WebViewImpl.mm:
+(WebKit::WebViewImpl::setUseSystemAppearance):
+(WebKit::WebViewImpl::useSystemAppearance):
+(WebKit::WebViewImpl::setDefaultAppearance):
+
+2018-03-19  Jason Marcell  
+
 Cherry-pick r229679. rdar://problem/38385900
 
 2018-03-16  Megan Gardner  


Modified: tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h (229718 => 229719)

--- tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h	2018-03-19 21:27:23 UTC (rev 229718)
+++ tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h	2018-03-19 21:27:26 UTC (rev 229719)
@@ -140,6 +140,8 @@
 
 - (void)_doAfterNextPresentationUpdate:(void (^)(void))updateBlock WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 
+@property (nonatomic, readwrite, setter=_setUseSystemAppearance:) BOOL _useSystemAppearance WK_API_AVAILABLE(macosx(WK_MAC_TBA));
+
 @end
 
 #endif // !TARGET_OS_IPHONE


Modified: tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (229718 => 229719)

--- tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2018-03-19 21:27:23 UTC (rev 229718)
+++ tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2018-03-19 21:27:26 UTC (rev 229719)
@@ -684,8 +684,6 @@
 
 _impl->setAutomaticallyAdjustsContentInsets(true);
 _impl->setRequiresUserActionForEditingControlsManager([configuration _requiresUserActionForEditingControlsManager]);
-
-_page->setDefaultAppearance([self _defaultAppearance]);
 #endif
 
 _page->setBackgroundExtendsBeyondPage(true);
@@ -6158,18 +6156,18 @@
 
 - (BOOL)_useSystemAppearance
 {
-return _page->useSystemAppearance();
+return _impl->useSystemAppearance();
 }
 
 - (void)_setUseSystemAppearance:(BOOL)useSystemAppearance
 {
-_page->setUseSystemAppearance(useSystemAppearance);
-_page->setDefaultAppearance([self _defaultAppearance]);
+_impl->setUseSystemAppearance(useSystemAppearance);
+_impl->setDefaultAppearance([self _defaultAppearance]);
 }
 
 - (void)effectiveAppearanceDidChange
 {
-_page->setDefaultAppearance([self _defaultAppearance]);
+_impl->setDefaultAppearance([self _defaultAppearance]);
 }
 
 - (void)_setHeaderBannerHeight:(int)height


Modified: tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/mac/WKView.mm (229718 => 229719)

--- tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/mac/WKView.mm	2018-03-19 21:27:23 UTC (rev 229718)
+++ tags/Safari-606.1.9.4/Source/WebKit/UIProcess/API/mac/WKView.mm	2018-03-19 21:27:26 UTC (rev 229719)
@@ -1609,6 +1609,35 @@
 {
 _data->_impl->setShouldSuppressFirstResponderChanges(shouldSuppress);
 }
+
+#if USE(APPLE_INTERNAL_SDK)
+#import 
+#else
+- (bool)_defaultAppearance { return true; }
+#endif
+
+- (void)effectiveAppearanceDidChange
+{
+_data->_impl->setDefaultAppearance([self _defaultAppearance]);
+}
+
+- (void)_setUseSystemAppearance:(BOOL)useSystemAppearance
+{
+_data->_impl->setUseSystemAppearance(useSystemAppearance);
+_data->_impl->setDefaultAppearance([self _defaultAppearance]);
+}
+
+- (BOOL)_useSyste

[webkit-changes] [229715] trunk/Source/WebKit

[bburg]

Title: [229715] trunk/Source/WebKit








Revision 229715
Author bb...@apple.com
Date 2018-03-19 14:22:51 -0700 (Mon, 19 Mar 2018)


Log Message
Web Inspector: clean up WKWebView configuration code
https://bugs.webkit.org/show_bug.cgi?id=183747


Reviewed by Timothy Hatcher.

* UIProcess/mac/WKInspectorViewController.mm:
(-[WKInspectorViewController webView]): Always use system
appearance for Inspector's web content.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/mac/WKInspectorViewController.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (229714 => 229715)

--- trunk/Source/WebKit/ChangeLog	2018-03-19 21:22:15 UTC (rev 229714)
+++ trunk/Source/WebKit/ChangeLog	2018-03-19 21:22:51 UTC (rev 229715)
@@ -1,3 +1,15 @@
+2018-03-19  Brian Burg  
+
+Web Inspector: clean up WKWebView configuration code
+https://bugs.webkit.org/show_bug.cgi?id=183747
+
+
+Reviewed by Timothy Hatcher.
+
+* UIProcess/mac/WKInspectorViewController.mm:
+(-[WKInspectorViewController webView]): Always use system
+appearance for Inspector's web content.
+
 2018-03-19  Eric Carlson  
 
 [Extra zoom mode] Require fullscreen for video playback


Modified: trunk/Source/WebKit/UIProcess/mac/WKInspectorViewController.mm (229714 => 229715)

--- trunk/Source/WebKit/UIProcess/mac/WKInspectorViewController.mm	2018-03-19 21:22:15 UTC (rev 229714)
+++ trunk/Source/WebKit/UIProcess/mac/WKInspectorViewController.mm	2018-03-19 21:22:51 UTC (rev 229715)
@@ -37,8 +37,8 @@
 #import "WKPreferencesPrivate.h"
 #import "WKProcessPoolInternal.h"
 #import "WKUIDelegatePrivate.h"
-#import "WKWebView.h"
 #import "WKWebViewConfigurationPrivate.h"
+#import "WKWebViewPrivate.h"
 #import "WeakObjCPtr.h"
 #import "WebInspectorProxy.h"
 #import "WebInspectorUtilities.h"
@@ -93,6 +93,7 @@
 [_webView setNavigationDelegate:self];
 [_webView setInspectorWKWebViewDelegate:self];
 [_webView _setAutomaticallyAdjustsContentInsets:NO];
+[_webView _setUseSystemAppearance:YES];
 [_webView setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable];
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229714] trunk/Source

[eric . carlson]

Title: [229714] trunk/Source








Revision 229714
Author eric.carl...@apple.com
Date 2018-03-19 14:22:15 -0700 (Mon, 19 Mar 2018)


Log Message
[Extra zoom mode] Require fullscreen for video playback
https://bugs.webkit.org/show_bug.cgi?id=183742


Reviewed by Jer Noble.

Source/WebCore:

* Modules/modern-media-controls/media/playback-support.js:
(PlaybackSupport.prototype.syncControl): Always show the play button.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updatePlayState): Return immediately if playback requires fullscreen
(WebCore::HTMLMediaElement::didBecomeFullscreenElement): Call updatePlayState in case
playback is pending.
* html/HTMLMediaElement.h:
* platform/cocoa/VideoFullscreenModel.h:
(WebCore::VideoFullscreenModel::presentingViewController): New.
(WebCore::VideoFullscreenModel::createVideoFullscreenViewController): New.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenMode):
* platform/ios/PlaybackSessionInterfaceAVKit.mm:
(WebCore::PlaybackSessionInterfaceAVKit::seekableRangesChanged):

* platform/ios/VideoFullscreenInterfaceAVKit.h:
* platform/ios/VideoFullscreenInterfaceAVKit.mm: Wrap AVPlayerLayerView so we can change its
behavior.
(WebAVPlayerLayerView_playerLayer):
(WebAVPlayerLayerView_videoView):
(allocWebAVPlayerLayerViewInstance):
(-[WebAVPlayerViewController initWithFullscreenInterface:]):
(-[WebAVPlayerViewController playerViewControllerShouldHandleDoneButtonTap:]):
(-[WebAVPlayerViewController enterFullScreenAnimated:completionHandler:]):
(-[WebAVPlayerViewController exitFullScreenAnimated:completionHandler:]):
(-[WebAVPlayerViewController NO_RETURN_DUE_TO_ASSERT]):
(-[WebAVPlayerViewController isPictureInPicturePossible]):
(-[WebAVPlayerViewController isPictureInPictureActive]):
(-[WebAVPlayerViewController isPictureInPictureSuspended]):
(-[WebAVPlayerViewController pictureInPictureActive]):
(-[WebAVPlayerViewController pictureInPictureWasStartedWhenEnteringBackground]):
(-[WebAVPlayerViewController view]):
(-[WebAVPlayerViewController showsPlaybackControls]):
(-[WebAVPlayerViewController setShowsPlaybackControls:]):
(-[WebAVPlayerViewController setAllowsPictureInPicturePlayback:]):
(-[WebAVPlayerViewController setDelegate:]):
(-[WebAVPlayerViewController setPlayerController:]):
(-[WebAVPlayerViewController avPlayerViewController]):
(-[WebAVPlayerViewController removeFromParentViewController]):
(VideoFullscreenInterfaceAVKit::setupFullscreen):
(fallbackViewController):
(VideoFullscreenInterfaceAVKit::presentingViewController):
(VideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason):
(VideoFullscreenInterfaceAVKit::doSetup):
(WebCore::supportsPictureInPicture):

Source/WebCore/PAL:

* pal/spi/cocoa/AVKitSPI.h:

Source/WebKit:

* UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(-[WKVideoFullScreenViewController initWithAVPlayerViewController:]):
(-[WKVideoFullScreenViewController viewDidLoad]):
(-[WKVideoFullScreenViewController prefersStatusBarHidden]):
(WebKit::VideoFullscreenModelContext::presentingViewController):
(WebKit::VideoFullscreenModelContext::createVideoFullscreenViewController):
* WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::VideoFullscreenManager::didEnterFullscreen):

Source/WTF:

* wtf/Platform.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/modern-media-controls/media/playback-support.js
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/platform/cocoa/VideoFullscreenModel.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm
trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h
trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h
trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm
trunk/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (229713 => 229714)

--- trunk/Source/WTF/ChangeLog	2018-03-19 21:16:31 UTC (rev 229713)
+++ trunk/Source/WTF/ChangeLog	2018-03-19 21:22:15 UTC (rev 229714)
@@ -1,3 +1,13 @@
+2018-03-19  Eric Carlson  
+
+[Extra zoom mode] Require fullscreen for video playback
+https://bugs.webkit.org/show_bug.cgi?id=183742
+
+
+Reviewed by Jer Noble.
+
+* wtf/Platform.h:
+
 2018-03-15  Tim Horton  
 
 Avoid defining commonly-named system macros on all Cocoa platform

[webkit-changes] [229713] tags/Safari-606.1.9.4/

[jmarcell]

Title: [229713] tags/Safari-606.1.9.4/








Revision 229713
Author jmarc...@apple.com
Date 2018-03-19 14:16:31 -0700 (Mon, 19 Mar 2018)


Log Message
New tag.

Added Paths

tags/Safari-606.1.9.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229712] trunk

[dbates]

Title: [229712] trunk








Revision 229712
Author dba...@webkit.org
Date 2018-03-19 14:12:17 -0700 (Mon, 19 Mar 2018)


Log Message
test-webkitpy no longer runs WebKit2 tests
https://bugs.webkit.org/show_bug.cgi?id=183724

Reviewed by Alexey Proskuryakov.

Source/WebKit:

Fixes an issue where Python emits errors "global name reset_results is not defined" when
running tests in messages_unittest.py using test-webkitpy.

Currently messages_unittest.py conditionally defines the global variable reset_results
when run as the main program (i.e. __name__ == "__main__"). When messages_unittest.py is
imported as a module as test-webkitpy does then it is not considered the main program
;=> the top-level script environment is not __main__ ;=> we do not define the global
variable reset_results. Instead we should unconditionally define the global variable
reset_results.

* Scripts/webkit/messages_unittest.py:

Tools:

The WebKit2 tests have seen been moved from Source/WebKit2/Scripts/webkit2 to Source/WebKit/Scripts/webkit.

* Scripts/webkitpy/test/main.py:
(main):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/messages_unittest.py
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/test/main.py




Diff

Modified: trunk/Source/WebKit/ChangeLog (229711 => 229712)

--- trunk/Source/WebKit/ChangeLog	2018-03-19 20:49:03 UTC (rev 229711)
+++ trunk/Source/WebKit/ChangeLog	2018-03-19 21:12:17 UTC (rev 229712)
@@ -1,3 +1,22 @@
+2018-03-19  Daniel Bates  
+
+test-webkitpy no longer runs WebKit2 tests
+https://bugs.webkit.org/show_bug.cgi?id=183724
+
+Reviewed by Alexey Proskuryakov.
+
+Fixes an issue where Python emits errors "global name reset_results is not defined" when
+running tests in messages_unittest.py using test-webkitpy.
+
+Currently messages_unittest.py conditionally defines the global variable reset_results
+when run as the main program (i.e. __name__ == "__main__"). When messages_unittest.py is
+imported as a module as test-webkitpy does then it is not considered the main program
+;=> the top-level script environment is not __main__ ;=> we do not define the global
+variable reset_results. Instead we should unconditionally define the global variable
+reset_results.
+
+* Scripts/webkit/messages_unittest.py:
+
 2018-03-19  Per Arne Vollan  
 
 When the WebContent process is blocked from accessing the WindowServer, the call CVDisplayLinkCreateWithCGDisplay will fail.


Modified: trunk/Source/WebKit/Scripts/webkit/messages_unittest.py (229711 => 229712)

--- trunk/Source/WebKit/Scripts/webkit/messages_unittest.py	2018-03-19 20:49:03 UTC (rev 229711)
+++ trunk/Source/WebKit/Scripts/webkit/messages_unittest.py	2018-03-19 21:12:17 UTC (rev 229712)
@@ -32,6 +32,8 @@
 
 script_directory = os.path.dirname(os.path.realpath(__file__))
 
+reset_results = False
+
 with open(os.path.join(script_directory, 'test-messages.in')) as in_file:
 _messages_file_contents = in_file.read()
 
@@ -383,7 +385,6 @@
 
 
 if __name__ == '__main__':
-reset_results = False
 add_reset_results_to_unittest_help()
 parse_sys_argv()
 unittest.main()


Modified: trunk/Tools/ChangeLog (229711 => 229712)

--- trunk/Tools/ChangeLog	2018-03-19 20:49:03 UTC (rev 229711)
+++ trunk/Tools/ChangeLog	2018-03-19 21:12:17 UTC (rev 229712)
@@ -1,5 +1,17 @@
 2018-03-19  Daniel Bates  
 
+test-webkitpy no longer runs WebKit2 tests
+https://bugs.webkit.org/show_bug.cgi?id=183724
+
+Reviewed by Alexey Proskuryakov.
+
+The WebKit2 tests have seen been moved from Source/WebKit2/Scripts/webkit2 to Source/WebKit/Scripts/webkit.
+
+* Scripts/webkitpy/test/main.py:
+(main):
+
+2018-03-19  Daniel Bates  
+
 Make run-webkit-app work for non-GUI apps
 https://bugs.webkit.org/show_bug.cgi?id=183701
 


Modified: trunk/Tools/Scripts/webkitpy/test/main.py (229711 => 229712)

--- trunk/Tools/Scripts/webkitpy/test/main.py	2018-03-19 20:49:03 UTC (rev 229711)
+++ trunk/Tools/Scripts/webkitpy/test/main.py	2018-03-19 21:12:17 UTC (rev 229712)
@@ -53,7 +53,7 @@
 
 # There is no WebKit2 on Windows, so we don't need to run WebKit2 unittests on it.
 if not (sys.platform.startswith('win') or sys.platform == 'cygwin'):
-tester.add_tree(os.path.join(webkit_root, 'Source', 'WebKit2', 'Scripts'), 'webkit2')
+tester.add_tree(os.path.join(webkit_root, 'Source', 'WebKit', 'Scripts'), 'webkit')
 
 tester.skip(('webkitpy.common.checkout.scm.scm_unittest',), 'are really, really, slow', 31818)
 if sys.platform.startswith('win'):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229711] trunk/Tools

[dbates]

Title: [229711] trunk/Tools








Revision 229711
Author dba...@webkit.org
Date 2018-03-19 13:49:03 -0700 (Mon, 19 Mar 2018)


Log Message
Make run-webkit-app work for non-GUI apps
https://bugs.webkit.org/show_bug.cgi?id=183701

Reviewed by Lucas Forschler.

Launch the app directly if it is an executable file. Otherwise, assume it is an app bundle
and launch it using open(1) as we currently do.

Note that open(1) is meant for launching GUI apps. Standard output and standard error are
not sent to the tty when using open(1) to launch a non-GUI app.

* Scripts/run-webkit-app: We make the assumption that
* Scripts/webkitdirs.pm:
- Define and export constant DO_NOT_USE_OPEN_COMMAND.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-webkit-app
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (229710 => 229711)

--- trunk/Tools/ChangeLog	2018-03-19 20:43:36 UTC (rev 229710)
+++ trunk/Tools/ChangeLog	2018-03-19 20:49:03 UTC (rev 229711)
@@ -1,5 +1,22 @@
 2018-03-19  Daniel Bates  
 
+Make run-webkit-app work for non-GUI apps
+https://bugs.webkit.org/show_bug.cgi?id=183701
+
+Reviewed by Lucas Forschler.
+
+Launch the app directly if it is an executable file. Otherwise, assume it is an app bundle
+and launch it using open(1) as we currently do.
+
+Note that open(1) is meant for launching GUI apps. Standard output and standard error are
+not sent to the tty when using open(1) to launch a non-GUI app.
+
+* Scripts/run-webkit-app: We make the assumption that 
+* Scripts/webkitdirs.pm:
+- Define and export constant DO_NOT_USE_OPEN_COMMAND.
+
+2018-03-19  Daniel Bates  
+
 run-webkit-app -g does not work
 https://bugs.webkit.org/show_bug.cgi?id=183699
 


Modified: trunk/Tools/Scripts/run-webkit-app (229710 => 229711)

--- trunk/Tools/Scripts/run-webkit-app	2018-03-19 20:43:36 UTC (rev 229710)
+++ trunk/Tools/Scripts/run-webkit-app	2018-03-19 20:49:03 UTC (rev 229711)
@@ -48,4 +48,5 @@
 if (isIOSWebKit()) {
 exit exitStatus(runIOSWebKitApp($appPath));
 }
-exit exitStatus(runMacWebKitApp($appPath, USE_OPEN_COMMAND));
+my $isExecutable = -f $appPath && -x $appPath;
+exit exitStatus(runMacWebKitApp($appPath, $isExecutable ? DO_NOT_USE_OPEN_COMMAND : USE_OPEN_COMMAND));


Modified: trunk/Tools/Scripts/webkitdirs.pm (229710 => 229711)

--- trunk/Tools/Scripts/webkitdirs.pm	2018-03-19 20:43:36 UTC (rev 229710)
+++ trunk/Tools/Scripts/webkitdirs.pm	2018-03-19 20:49:03 UTC (rev 229711)
@@ -92,6 +92,7 @@
&shutDownIOSSimulatorDevice
&willUseIOSDeviceSDK
&willUseIOSSimulatorSDK
+   DO_NOT_USE_OPEN_COMMAND
SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT
USE_OPEN_COMMAND
);
@@ -114,6 +115,7 @@
 };
 
 use constant USE_OPEN_COMMAND => 1; # Used in runMacWebKitApp().
+use constant DO_NOT_USE_OPEN_COMMAND => 2;
 use constant SIMULATOR_DEVICE_STATE_SHUTDOWN => "1";
 use constant SIMULATOR_DEVICE_STATE_BOOTED => "3";
 use constant SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT  => "For WebKit Development";






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229710] trunk/Tools

[dbates]

Title: [229710] trunk/Tools








Revision 229710
Author dba...@webkit.org
Date 2018-03-19 13:43:36 -0700 (Mon, 19 Mar 2018)


Log Message
run-webkit-app -g does not work
https://bugs.webkit.org/show_bug.cgi?id=183699

Reviewed by Lucas Forschler.

Check for the optional command line argument -g/--guard-malloc before taking the
first argument passed to be the path to the app to run.

* Scripts/run-webkit-app:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-webkit-app




Diff

Modified: trunk/Tools/ChangeLog (229709 => 229710)

--- trunk/Tools/ChangeLog	2018-03-19 20:22:30 UTC (rev 229709)
+++ trunk/Tools/ChangeLog	2018-03-19 20:43:36 UTC (rev 229710)
@@ -1,3 +1,15 @@
+2018-03-19  Daniel Bates  
+
+run-webkit-app -g does not work
+https://bugs.webkit.org/show_bug.cgi?id=183699
+
+Reviewed by Lucas Forschler.
+
+Check for the optional command line argument -g/--guard-malloc before taking the
+first argument passed to be the path to the app to run.
+
+* Scripts/run-webkit-app:
+
 2018-03-18  Commit Queue  
 
 Unreviewed, rolling out r229689.


Modified: trunk/Tools/Scripts/run-webkit-app (229709 => 229710)

--- trunk/Tools/Scripts/run-webkit-app	2018-03-19 20:22:30 UTC (rev 229709)
+++ trunk/Tools/Scripts/run-webkit-app	2018-03-19 20:43:36 UTC (rev 229710)
@@ -37,6 +37,7 @@
 printHelpAndExitForRunAndDebugWebKitAppIfNeeded();
 
 setConfiguration();
+setUpGuardMallocIfNeeded();
 
 die "Did not specify an application to open (e.g. run-webkit-app AppName).\n" unless length($ARGV[0]) > 0;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229709] trunk/Source/JavaScriptCore

[mark . lam]

Title: [229709] trunk/Source/_javascript_Core








Revision 229709
Author mark@apple.com
Date 2018-03-19 13:22:30 -0700 (Mon, 19 Mar 2018)


Log Message
FunctionPtr should be passed by value.
https://bugs.webkit.org/show_bug.cgi?id=183746


Reviewed by JF Bastien.

It's meant to be an encapsulation of a C/C++ function pointer.  There are cases
where we use it to pass JIT compiled code (e.g. the VM thunks/stubs), but they are
treated as if they are C/C++ functions.

Regardless, there's no need to pass it by reference.

* assembler/MacroAssemblerCodeRef.h:
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::appendCall):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::appendCall):
(JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnException):
(JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnExceptionSetResult):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
* jit/JIT.h:
(JSC::JIT::appendCall):
(JSC::JIT::appendCallWithSlowPathReturnType):
* jit/JITInlines.h:
(JSC::JIT::appendCallWithExceptionCheck):
(JSC::JIT::appendCallWithExceptionCheckAndSlowPathReturnType):
(JSC::JIT::appendCallWithCallFrameRollbackOnException):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITInlines.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (229708 => 229709)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-19 20:06:21 UTC (rev 229708)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-19 20:22:30 UTC (rev 229709)
@@ -1,3 +1,35 @@
+2018-03-19  Mark Lam  
+
+FunctionPtr should be passed by value.
+https://bugs.webkit.org/show_bug.cgi?id=183746
+
+
+Reviewed by JF Bastien.
+
+It's meant to be an encapsulation of a C/C++ function pointer.  There are cases
+where we use it to pass JIT compiled code (e.g. the VM thunks/stubs), but they are
+treated as if they are C/C++ functions.
+
+Regardless, there's no need to pass it by reference.
+
+* assembler/MacroAssemblerCodeRef.h:
+* dfg/DFGJITCompiler.h:
+(JSC::DFG::JITCompiler::appendCall):
+* dfg/DFGSpeculativeJIT.h:
+(JSC::DFG::SpeculativeJIT::appendCall):
+(JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnException):
+(JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnExceptionSetResult):
+(JSC::DFG::SpeculativeJIT::appendCallSetResult):
+* jit/JIT.h:
+(JSC::JIT::appendCall):
+(JSC::JIT::appendCallWithSlowPathReturnType):
+* jit/JITInlines.h:
+(JSC::JIT::appendCallWithExceptionCheck):
+(JSC::JIT::appendCallWithExceptionCheckAndSlowPathReturnType):
+(JSC::JIT::appendCallWithCallFrameRollbackOnException):
+(JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
+(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):
+
 2018-03-15  Ross Kirsling  
 
 Fix MSVC run-time check after r229391. 


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h (229708 => 229709)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h	2018-03-19 20:06:21 UTC (rev 229708)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h	2018-03-19 20:22:30 UTC (rev 229709)
@@ -126,6 +126,9 @@
 void* m_value { nullptr };
 };
 
+static_assert(sizeof(FunctionPtr) == sizeof(void*), "");
+static_assert(std::is_trivially_copyable::value, "");
+
 // ReturnAddressPtr:
 //
 // ReturnAddressPtr should be used to wrap return addresses generated by processor


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h (229708 => 229709)

--- trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h	2018-03-19 20:06:21 UTC (rev 229708)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h	2018-03-19 20:22:30 UTC (rev 229709)
@@ -156,7 +156,7 @@
 }
 
 // Add a call out from JIT code, without an exception check.
-Call appendCall(const FunctionPtr& function)
+Call appendCall(const FunctionPtr function)
 {
 Call functionCall = call(NoPtrTag);
 m_calls.append(CallLinkRecord(functionCall, function));


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h (229708 => 229709)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h	2018-03-19 20:06:21 UTC (rev 229708)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h	2018-03-19 20:22:30 UTC (rev 229709)
@@ -1007,19 +1007,19 @@
 #endif
 
 // These methods add call instructions, optionally setting results, and optionally rolling back the call frame on an exception.
-JITCompiler::Call appendCall(const FunctionPtr& function)

[webkit-changes] [229708] trunk/Source/WebCore/PAL

[jiewen_tan]

Title: [229708] trunk/Source/WebCore/PAL








Revision 229708
Author jiewen_...@apple.com
Date 2018-03-19 13:06:21 -0700 (Mon, 19 Mar 2018)


Log Message
Unreviewed, a quick fix for r229699

* pal/spi/cocoa/DeviceIdentitySPI.h:

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cocoa/DeviceIdentitySPI.h




Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (229707 => 229708)

--- trunk/Source/WebCore/PAL/ChangeLog	2018-03-19 18:04:39 UTC (rev 229707)
+++ trunk/Source/WebCore/PAL/ChangeLog	2018-03-19 20:06:21 UTC (rev 229708)
@@ -1,3 +1,9 @@
+2018-03-19  Jiewen Tan  
+
+Unreviewed, a quick fix for r229699
+
+* pal/spi/cocoa/DeviceIdentitySPI.h:
+
 2018-03-17  Jiewen Tan  
 
 [WebAuthN] Implement authenticatorMakeCredential


Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/DeviceIdentitySPI.h (229707 => 229708)

--- trunk/Source/WebCore/PAL/pal/spi/cocoa/DeviceIdentitySPI.h	2018-03-19 18:04:39 UTC (rev 229707)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/DeviceIdentitySPI.h	2018-03-19 20:06:21 UTC (rev 229708)
@@ -27,8 +27,14 @@
 
 #if ENABLE(WEB_AUTHN)
 
-#if USE(APPLE_INTERNAL_SDK) && PLATFORM(IOS) && !PLATFORM(IOS_SIMULATOR)
+#if PLATFORM(IOS) && !PLATFORM(IOS_SIMULATOR)
 
+#if USE(APPLE_INTERNAL_SDK)
+
+#if __IPHONE_OS_VERSION_MAX_ALLOWED < 110300
+extern NSString * _Nonnull const kMAOptionsBAAAccessControls;
+#endif
+
 extern "C" {
 #import 
 }
@@ -50,6 +56,8 @@
 extern "C"
 void DeviceIdentityIssueClientCertificateWithCompletion(dispatch_queue_t _Nullable, NSDictionary * _Nullable options, MABAACompletionBlock _Nonnull);
 
-#endif // USE(APPLE_INTERNAL_SDK) && PLATFORM(IOS) && !PLATFORM(IOS_SIMULATOR)
+#endif // USE(APPLE_INTERNAL_SDK)
 
+#endif // PLATFORM(IOS) && !PLATFORM(IOS_SIMULATOR)
+
 #endif // ENABLE(WEB_AUTHN)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229707] trunk/Source

[pvollan]

Title: [229707] trunk/Source








Revision 229707
Author pvol...@apple.com
Date 2018-03-19 11:04:39 -0700 (Mon, 19 Mar 2018)


Log Message
When the WebContent process is blocked from accessing the WindowServer, the call CVDisplayLinkCreateWithCGDisplay will fail.
https://bugs.webkit.org/show_bug.cgi?id=183604


Reviewed by Brent Fulgham.

Source/WebCore:

The call to CVDisplayLinkCreateWithCGDisplay can instead be made in the UIProcess. Notify the WebContent process
about display updates by sending a message from the UIProcess on each screen update. This patch adds an extra
IPC step when notifying the WebContent process about display updates. However, the MotionMark benchmark shows no
performance regression when running it with this patch. A possible explanation for this is that the high priority
display link thread is now running in the UIProcess instead of the WebContent process, which means there will be
more available CPU resources for the WebContent process. A run loop observer is added to make sure that only one
display callback (for each display observer) is executed in a single iteration of the run loop. This will make
sure we are not filling the IPC message queue with unhandled display link messages.

No new tests, covered by existing tests.

* platform/graphics/DisplayRefreshMonitor.h:
(WebCore::DisplayRefreshMonitor::displayLinkFired):
* platform/graphics/DisplayRefreshMonitorManager.cpp:
(WebCore::DisplayRefreshMonitorManager::displayWasUpdated):
* platform/graphics/DisplayRefreshMonitorManager.h:
* platform/graphics/mac/DisplayRefreshMonitorMac.h:

Source/WebKit:

* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/DisplayLink.cpp: Added.
(WebKit::DisplayLink::DisplayLink):
(WebKit::DisplayLink::~DisplayLink):
(WebKit::DisplayLink::displayLinkCallback):
* UIProcess/mac/DisplayLink.h: Added.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::startDisplayRefreshMonitor):
(WebKit::WebPageProxy::stopDisplayRefreshMonitor):
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::createDisplayRefreshMonitor):
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/mac/DrawingAreaMac.cpp: Added.
(WebKit::DisplayRefreshMonitorMac::create):
(WebKit::DisplayRefreshMonitorMac::DisplayRefreshMonitorMac):
(WebKit::DisplayRefreshMonitorMac::~DisplayRefreshMonitorMac):
(WebKit::DisplayRefreshMonitorMac::requestRefreshCallback):
(WebKit::DisplayRefreshMonitorMac::displayLinkFired):
(WebKit::DrawingArea::screenWasRefreshed):
(WebKit::DrawingArea::createDisplayRefreshMonitor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.h
trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.cpp
trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.h
trunk/Source/WebCore/platform/graphics/ios/DisplayRefreshMonitorIOS.h
trunk/Source/WebCore/platform/graphics/mac/DisplayRefreshMonitorMac.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/WebPage/DrawingArea.cpp
trunk/Source/WebKit/WebProcess/WebPage/DrawingArea.h
trunk/Source/WebKit/WebProcess/WebPage/DrawingArea.messages.in


Added Paths

trunk/Source/WebKit/UIProcess/mac/DisplayLink.cpp
trunk/Source/WebKit/UIProcess/mac/DisplayLink.h
trunk/Source/WebKit/WebProcess/WebPage/mac/DrawingAreaMac.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (229706 => 229707)

--- trunk/Source/WebCore/ChangeLog	2018-03-19 17:29:57 UTC (rev 229706)
+++ trunk/Source/WebCore/ChangeLog	2018-03-19 18:04:39 UTC (rev 229707)
@@ -1,3 +1,29 @@
+2018-03-19  Per Arne Vollan  
+
+When the WebContent process is blocked from accessing the WindowServer, the call CVDisplayLinkCreateWithCGDisplay will fail.
+https://bugs.webkit.org/show_bug.cgi?id=183604
+
+
+Reviewed by Brent Fulgham.
+
+The call to CVDisplayLinkCreateWithCGDisplay can instead be made in the UIProcess. Notify the WebContent process
+about display updates by sending a message from the UIProcess on each screen update. This patch adds an extra
+IPC step when notifying the WebContent process about display updates. However, the MotionMark benchmark shows no
+performance regression when running it with this patch. A possible explanation for this is that the high priority
+display link thread is now running in the UIProcess instead of the WebContent process, which means there will be
+more available CPU resources for the WebContent process. A run loop observer is added to make sure that only one
+display callback (for each display observer) is executed in a single iteration of the run loop. This will make
+sure we are not

[webkit-changes] [229706] trunk/Source/WebCore

[megan_gardner]

Title: [229706] trunk/Source/WebCore








Revision 229706
Author megan_gard...@apple.com
Date 2018-03-19 10:29:57 -0700 (Mon, 19 Mar 2018)


Log Message
Ensure local appearance actually mirrors the app's appearance
https://bugs.webkit.org/show_bug.cgi?id=183743

Reviewed by Tim Horton.

Not currently testable, will add tests in a later patch.

Current appearance isn't always accurate by default and needs to be set manually.

* platform/mac/LocalDefaultSystemAppearance.mm:
(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (229705 => 229706)

--- trunk/Source/WebCore/ChangeLog	2018-03-19 08:40:56 UTC (rev 229705)
+++ trunk/Source/WebCore/ChangeLog	2018-03-19 17:29:57 UTC (rev 229706)
@@ -1,3 +1,17 @@
+2018-03-19  Megan Gardner  
+
+Ensure local appearance actually mirrors the app's appearance
+https://bugs.webkit.org/show_bug.cgi?id=183743
+
+Reviewed by Tim Horton.
+
+Not currently testable, will add tests in a later patch.
+
+Current appearance isn't always accurate by default and needs to be set manually.
+
+* platform/mac/LocalDefaultSystemAppearance.mm:
+(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance):
+
 2018-03-19  Zan Dobersek  
 
 Unreviewed GCC 4.9 build-fix after r229672.


Modified: trunk/Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm (229705 => 229706)

--- trunk/Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm	2018-03-19 08:40:56 UTC (rev 229705)
+++ trunk/Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm	2018-03-19 17:29:57 UTC (rev 229706)
@@ -34,10 +34,8 @@
 LocalDefaultSystemAppearance::LocalDefaultSystemAppearance(bool useSystemAppearance)
 : m_savedSystemAppearance()
 {
-if (!useSystemAppearance) {
-m_savedSystemAppearance = [NSAppearance currentAppearance];
-[NSAppearance setCurrentAppearance:[NSAppearance appearanceNamed:NSAppearanceNameAqua]];
-}
+m_savedSystemAppearance = [NSAppearance currentAppearance];
+[NSAppearance setCurrentAppearance:useSystemAppearance ? [NSApp effectiveAppearance] : [NSAppearance appearanceNamed:NSAppearanceNameAqua]];
 }
 
 LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229705] trunk/Source/WebCore

[zandobersek]

Title: [229705] trunk/Source/WebCore








Revision 229705
Author zandober...@gmail.com
Date 2018-03-19 01:40:56 -0700 (Mon, 19 Mar 2018)


Log Message
Unreviewed GCC 4.9 build-fix after r229672.

* platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
(Nicosia::createCommand): Don't depend on implicit conversion of the
returning std::unique_ptr<> object, and instead only wrap the
heap-allocated PaintingOperation-derived in a std::unique_ptr<> at the
point of return.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (229704 => 229705)

--- trunk/Source/WebCore/ChangeLog	2018-03-19 03:38:39 UTC (rev 229704)
+++ trunk/Source/WebCore/ChangeLog	2018-03-19 08:40:56 UTC (rev 229705)
@@ -1,3 +1,13 @@
+2018-03-19  Zan Dobersek  
+
+Unreviewed GCC 4.9 build-fix after r229672.
+
+* platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
+(Nicosia::createCommand): Don't depend on implicit conversion of the
+returning std::unique_ptr<> object, and instead only wrap the
+heap-allocated PaintingOperation-derived in a std::unique_ptr<> at the
+point of return.
+
 2018-03-18  Commit Queue  
 
 Unreviewed, rolling out r229689.


Modified: trunk/Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp (229704 => 229705)

--- trunk/Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp	2018-03-19 03:38:39 UTC (rev 229704)
+++ trunk/Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp	2018-03-19 08:40:56 UTC (rev 229705)
@@ -59,9 +59,9 @@
 template
 auto createCommand(Args&&... arguments) -> std::enable_if_t...>, T>::value, std::unique_ptr>
 {
-auto command = std::make_unique();
+auto* command = new T();
 command->arguments = std::make_tuple(std::forward(arguments)...);
-return command;
+return std::unique_ptr(command);
 }
 
 template






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes