[webkit-changes] [239861] trunk/Source/WebCore

[mmaxfield]

Title: [239861] trunk/Source/WebCore








Revision 239861
Author mmaxfi...@apple.com
Date 2019-01-10 23:47:07 -0800 (Thu, 10 Jan 2019)


Log Message
[WHLSL] Include the standard library
https://bugs.webkit.org/show_bug.cgi?id=192994

Reviewed by Jon Lee.

A small section of the standard library is present in WHLSLStandardLibrary.txt. This gets turned into a header file containing
its raw data at build time by invoking our xxd.pl script (which WebCore already uses for other purposes). The standard
library is generated by running a _javascript_ script, but currently there is no way to invoke _javascript_ from our build
process, so this patch includes in the standard library's raw text instead. Once the parser is faster, we can include the
entire standard library.

No new tests because it isn't hooked up yet.

* DerivedSources.make:
* Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt: Added.
* WebCore.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt




Diff

Modified: trunk/Source/WebCore/ChangeLog (239860 => 239861)

--- trunk/Source/WebCore/ChangeLog	2019-01-11 06:23:47 UTC (rev 239860)
+++ trunk/Source/WebCore/ChangeLog	2019-01-11 07:47:07 UTC (rev 239861)
@@ -1,3 +1,22 @@
+2019-01-10  Myles C. Maxfield  
+
+[WHLSL] Include the standard library
+https://bugs.webkit.org/show_bug.cgi?id=192994
+
+Reviewed by Jon Lee.
+
+A small section of the standard library is present in WHLSLStandardLibrary.txt. This gets turned into a header file containing
+its raw data at build time by invoking our xxd.pl script (which WebCore already uses for other purposes). The standard
+library is generated by running a _javascript_ script, but currently there is no way to invoke _javascript_ from our build
+process, so this patch includes in the standard library's raw text instead. Once the parser is faster, we can include the
+entire standard library.
+
+No new tests because it isn't hooked up yet.
+
+* DerivedSources.make:
+* Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt: Added.
+* WebCore.xcodeproj/project.pbxproj:
+
 2019-01-10  Jer Noble  
 
  elements do not enter 'paused' state when playing to end over AirPlay


Modified: trunk/Source/WebCore/DerivedSources.make (239860 => 239861)

--- trunk/Source/WebCore/DerivedSources.make	2019-01-11 06:23:47 UTC (rev 239860)
+++ trunk/Source/WebCore/DerivedSources.make	2019-01-11 07:47:07 UTC (rev 239861)
@@ -1602,6 +1602,15 @@
 
 # 
 
+# WHLSL Standard Library
+
+all : WHLSLStandardLibrary.cpp
+
+WHLSLStandardLibrary.cpp : $(_javascript_Core_SCRIPTS_DIR)/xxd.pl $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt
+	$(PERL) $(_javascript_Core_SCRIPTS_DIR)/xxd.pl WHLSLStandardLibrary $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt WHLSLStandardLibrary.h
+
+# 
+
 # Common generator things
 
 COMMON_BINDINGS_SCRIPTS = \


Added: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt (0 => 239861)

--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt	(rev 0)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt	2019-01-11 07:47:07 UTC (rev 239861)
@@ -0,0 +1,471 @@
+// https://github.com/gpuweb/WHLSL/blob/9528f19aaa71fd5c3c706d2873f4b8c8cce857b5/Spec/source/Generate_Standard_Library.js
+// This was autogenerated from Generate_Standard_Library.js! Do not edit!!
+
+native typedef void;
+native typedef bool;
+native typedef uchar;
+native typedef ushort;
+native typedef uint;
+native typedef char;
+native typedef short;
+native typedef int;
+native typedef half;
+native typedef float;
+native typedef atomic_int;
+native typedef atomic_uint;
+native typedef vector;
+typedef bool2 = vector;
+native typedef vector;
+typedef bool3 = vector;
+native typedef vector;
+typedef bool4 = vector;
+native typedef vector;
+typedef uchar2 = vector;
+native typedef vector;
+typedef uchar3 = vector;
+native typedef vector;
+typedef uchar4 = vector;
+native typedef vector;
+typedef ushort2 = vector;
+native typedef vector;
+typedef ushort3 = vector;
+native typedef vector;
+typedef ushort4 = vector;
+native typedef vector;
+typedef uint2 = vector;
+native typedef vector;
+typedef uint3 = vector;
+native typedef vector;
+typedef uint4 = vector;
+native typedef vector;
+typedef char2 = vector;
+native typedef vector;
+typedef char3 = vector;
+native typedef vector;
+typedef char4 = vector;
+native typedef vector;
+typedef short2 = vector;
+native typedef vector;
+typedef short3 = vector;
+native typedef vector;
+typedef short4 = vector;
+native typedef vector;
+typedef int2 = vector;
+native typedef vector;
+typedef int3 = vector;
+native typedef vector;
+typedef int4 = vector;
+native typedef vector;
+typedef 

[webkit-changes] [239860] trunk/Tools

[ryanhaddad]

Title: [239860] trunk/Tools








Revision 239860
Author ryanhad...@apple.com
Date 2019-01-10 22:23:47 -0800 (Thu, 10 Jan 2019)


Log Message
Unreviewed, fix typo that breaks dashboard link.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js (239859 => 239860)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js	2019-01-11 06:07:26 UTC (rev 239859)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js	2019-01-11 06:23:47 UTC (rev 239860)
@@ -39,7 +39,7 @@
 "Apple High Sierra Debug WK1 (Tests)": {platform: Dashboard.Platform.macOSHighSierra, debug: true, tester: true, testCategory: Buildbot.TestCategory.WebKit1},
 "Apple High Sierra Debug WK2 (Tests)": {platform: Dashboard.Platform.macOSHighSierra, debug: true, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
 "Apple High Sierra Release WK1 (Tests)": {platform: Dashboard.Platform.macOSHighSierra, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit1},
-"Apple High Release WK2 (Perf)": {platform: Dashboard.Platform.macOSHighSierra, debug: false, performance: true, heading: "Performance"},
+"Apple High Sierra Release WK2 (Perf)": {platform: Dashboard.Platform.macOSHighSierra, debug: false, performance: true, heading: "Performance"},
 "Apple High Sierra Release WK2 (Tests)": {platform: Dashboard.Platform.macOSHighSierra, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
 "Apple High Sierra JSC": {platform: Dashboard.Platform.macOSHighSierra, heading: "_javascript_", combinedQueues: {
 "Apple High Sierra 32-bit JSC (BuildAndTest)": {heading: "32-bit JSC (BuildAndTest)"},


Modified: trunk/Tools/ChangeLog (239859 => 239860)

--- trunk/Tools/ChangeLog	2019-01-11 06:07:26 UTC (rev 239859)
+++ trunk/Tools/ChangeLog	2019-01-11 06:23:47 UTC (rev 239860)
@@ -1,5 +1,12 @@
 2019-01-10  Ryan Haddad  
 
+Unreviewed, fix typo that breaks dashboard link.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
+(WebKitBuildbot):
+
+2019-01-10  Ryan Haddad  
+
 Update macOS queue configurations
 https://bugs.webkit.org/show_bug.cgi?id=193329
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239859] trunk/Tools

[ryanhaddad]

Title: [239859] trunk/Tools








Revision 239859
Author ryanhad...@apple.com
Date 2019-01-10 22:07:26 -0800 (Thu, 10 Jan 2019)


Log Message
Update macOS queue configurations
https://bugs.webkit.org/show_bug.cgi?id=193329

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (239858 => 239859)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2019-01-11 05:54:54 UTC (rev 239858)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2019-01-11 06:07:26 UTC (rev 239859)
@@ -24,32 +24,18 @@
 { "name": "bot187", "platform": "mac-highsierra" },
 { "name": "bot194", "platform": "mac-highsierra" },
 { "name": "bot197", "platform": "mac-highsierra" },
+{ "name": "bot205", "platform": "mac-highsierra" },
 { "name": "bot215", "platform": "mac-highsierra" },
 { "name": "bot216", "platform": "mac-highsierra" },
 { "name": "bot217", "platform": "mac-highsierra" },
+{ "name": "bot603", "platform": "mac-highsierra" },
 { "name": "bot630", "platform": "mac-highsierra" },
 { "name": "bot631", "platform": "mac-highsierra" },
+{ "name": "bot632", "platform": "mac-highsierra" },
 { "name": "bot635", "platform": "mac-highsierra" },
 { "name": "bot636", "platform": "mac-highsierra" },
 { "name": "bot638", "platform": "mac-highsierra" },
 
-{ "name": "bot118", "platform": "mac-sierra" },
-{ "name": "bot122", "platform": "mac-sierra" },
-{ "name": "bot141", "platform": "mac-sierra" },
-{ "name": "bot160", "platform": "mac-sierra" },
-{ "name": "bot164", "platform": "mac-sierra" },
-{ "name": "bot199", "platform": "mac-sierra" },
-{ "name": "bot202", "platform": "mac-sierra" },
-{ "name": "bot205", "platform": "mac-sierra" },
-{ "name": "bot219", "platform": "mac-sierra" },
-{ "name": "bot603", "platform": "mac-sierra" },
-{ "name": "bot632", "platform": "mac-sierra" },
-{ "name": "bot600", "platform": "mac-sierra" },
-{ "name": "bot601", "platform": "mac-sierra" },
-{ "name": "bot609", "platform": "mac-sierra" },
-{ "name": "bot698", "platform": "mac-sierra" },
-{ "name": "bot699", "platform": "mac-sierra" },
-
 { "name": "bot673", "platform": "ios-12" },
 { "name": "bot626", "platform": "ios-simulator-12" },
 { "name": "bot618", "platform": "ios-simulator-12" },
@@ -136,7 +122,7 @@
 },
 { "name": "Apple High Sierra Debug (Build)", "type": "Build", "builddir": "highsierra-debug",
   "platform": "mac-highsierra", "configuration": "debug", "architectures": ["x86_64"],
-  "triggers": ["highsierra-debug-tests-jsc", "highsierra-debug-tests-wk1", "highsierra-debug-tests-wk2"],
+  "triggers": ["highsierra-debug-tests-jsc", "highsierra-debug-tests-test262", "highsierra-debug-tests-wk1", "highsierra-debug-tests-wk2"],
   "slavenames": ["bot630", "bot631"]
 },
 { "name": "Apple High Sierra Debug WK1 (Tests)", "type": "TestWebKit1AllButJSC", "builddir": "highsierra-debug-tests-wk1",
@@ -151,7 +137,7 @@
 },
 { "name": "Apple High Sierra Release (Build)", 

[webkit-changes] [239858] trunk

[drousso]

Title: [239858] trunk








Revision 239858
Author drou...@apple.com
Date 2019-01-10 21:54:54 -0800 (Thu, 10 Jan 2019)


Log Message
Web Inspector: Audit: allow audits to be enabled/disabled
https://bugs.webkit.org/show_bug.cgi?id=192210


Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

* UserInterface/Controllers/AuditManager.js:
(WI.AuditManager.prototype.get editing): Added.
(WI.AuditManager.prototype.set editing): Added.
(WI.AuditManager.prototype.stop):
(WI.AuditManager.prototype.addDefaultTestsIfNeeded):
Since default audits aren't stored, keep a list of disabled default tests in a `WI.Setting`.

* UserInterface/Models/AuditTestBase.js:
(WI.AuditTestBase):
(WI.AuditTestBase.prototype.get disabled): Added.
(WI.AuditTestBase.prototype.set disabled): Added.
(WI.AuditTestBase.prototype.async start):
(WI.AuditTestBase.prototype.stop):
(WI.AuditTestBase.toJSON):

* UserInterface/Models/AuditTestCase.js:
(WI.AuditTestCase):
(WI.AuditTestCase.async fromPayload):
(WI.AuditTestCase.prototype.toJSON):

* UserInterface/Models/AuditTestGroup.js:
(WI.AuditTestGroup):
(WI.AuditTestGroup.async fromPayload):
(WI.AuditTestGroup.prototype.get disabled): Added.
(WI.AuditTestGroup.prototype.set disabled): Added.
(WI.AuditTestGroup.prototype.toJSON):
(WI.AuditTestGroup.prototype.async run):
(WI.AuditTestGroup.prototype._handleTestDisabledChanged): Added.
(WI.AuditTestGroup.prototype._handleTestProgress):
Propagate `disabled` changes to all sub-tests, unless the change was caused by one of the
sub-tests, in which case we are now in an intermediate state.

* UserInterface/Views/AuditNavigationSidebarPanel.js:
(WI.AuditNavigationSidebarPanel):
(WI.AuditNavigationSidebarPanel.prototype.showDefaultContentView):
(WI.AuditNavigationSidebarPanel.prototype.initialLayout):
(WI.AuditNavigationSidebarPanel.prototype.hasCustomFilters): Added.
(WI.AuditNavigationSidebarPanel.prototype.matchTreeElementAgainstCustomFilters): Added.
(WI.AuditNavigationSidebarPanel.prototype._addTest):
(WI.AuditNavigationSidebarPanel.prototype._addResult):
(WI.AuditNavigationSidebarPanel.prototype._updateStartStopButtonNavigationItemState):
(WI.AuditNavigationSidebarPanel.prototype._updateEditButtonNavigationItemState): Added.
(WI.AuditNavigationSidebarPanel.prototype._handleAuditManagerEditingChanged): Added.
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestRemoved):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestScheduled):
(WI.AuditNavigationSidebarPanel.prototype._treeSelectionDidChange):
(WI.AuditNavigationSidebarPanel.prototype._handleEditButtonNavigationItemClicked): Added.
* UserInterface/Views/AuditNavigationSidebarPanel.css:
(.sidebar > .panel.navigation.audit > .content):
(.sidebar > .panel.navigation.audit > .content > .tree-outline): Added.
(.sidebar > .panel.navigation.audit > .content .edit-audits:not(.disabled):active): Added.
(.sidebar > .panel.navigation.audit > .content .edit-audits:not(.disabled).activated): Added.
(.sidebar > .panel.navigation.audit > .content .edit-audits:not(.disabled).activated:active): Added.
(.sidebar > .panel.navigation.audit > .content .edit-audits.disabled): Added.
(.finish-editing-audits-placeholder.message-text-view .navigation-item-help .navigation-bar): Added.
Leverage custom filters to ensure that disabled audits arent shown when not editing and that
result tree elements aren't shown while editing.

* UserInterface/Views/AuditTestGroupContentView.js:
(WI.AuditTestGroupContentView.prototype.shown):

* UserInterface/Views/AuditTreeElement.js:
(WI.AuditTreeElement.prototype.onattach):
(WI.AuditTreeElement.prototype.canSelectOnMouseDown): Added.
(WI.AuditTreeElement.prototype._updateTestGroupDisabled): Added.
(WI.AuditTreeElement.prototype._handleTestDisabledChanged): Added.
(WI.AuditTreeElement.prototype._handleManagerEditingChanged): Added.
* UserInterface/Views/AuditTreeElement.css:
(.tree-outline .item.audit > .status:not(:hover) > img.show-on-hover, .tree-outline .item.audit.test-group.expanded:not(.editing-audits) > .status:not(:hover)): Added.
(.tree-outline .item.audit.manager-active > .status > img.show-on-hover, .tree-outline .item.audit.test-group.expanded:not(.editing-audits) > .status:hover > :not(img), .tree-outline .item.audit.test-group-result.expanded > .status): Added.
(.tree-outline .item.audit > .status:not(:hover) > img.show-on-hover, .tree-outline .item.audit.test-group.expanded > .status:not(:hover)): Deleted.
(.tree-outline .item.audit.manager-active > .status > img.show-on-hover, .tree-outline .item.audit.test-group.expanded > .status:hover > :not(img), .tree-outline .item.audit.test-group-result.expanded > .status): Deleted.
Prevent selection and running when editing.

* UserInterface/Views/TreeOutline.css:
(.tree-outline .children.expanded:not([hidden])): Added.
(.tree-outline .children.expanded): Deleted.

* UserInterface/Base/ObjectStore.js:
(WI.ObjectStore._open):
Batch operations together to help avoid multiple simultaneous `indexedDB.open` calls. 

[webkit-changes] [239857] trunk/Source/WebCore

[jer . noble]

Title: [239857] trunk/Source/WebCore








Revision 239857
Author jer.no...@apple.com
Date 2019-01-10 20:46:23 -0800 (Thu, 10 Jan 2019)


Log Message
 elements do not enter 'paused' state when playing to end over AirPlay
https://bugs.webkit.org/show_bug.cgi?id=193295


Reviewed by Eric Carlson.

Adopt the -[AVPlayer timeControlStatus] API, which reports whether the AVPlayer is paused, playing, or blocked waiting
for more data before playing. AirPlay devices report this state back from the remote device, and this allows the
MediaPlayerPrivateAVFoundationObjC to differentiate between user-generated pauses and simple stalling.

Adopting this API allows us to remove the heuristic from rateChanged() which inteprets a rate change when the
readyState > HAVE_ENOUGH as an intentional pause.

Drive-by fix: MediaPlayerPrivateAVFoundation had some code to delay calling platformPlay()
until the first frame became available. But this code was entirely undermined by the previous
behavior of setRate(). Fixing setRate()/setRateDouble() to only start playback if playback was
actually requested started making this code work for the first time, and broke some API tests.
Thus, we're removing this previously dead code.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::play):
(WebCore::MediaPlayerPrivateAVFoundation::pause):
(WebCore::MediaPlayerPrivateAVFoundation::rateChanged):
(WebCore::MediaPlayerPrivateAVFoundation::updateStates):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::didEnd):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPlay):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setRateDouble):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setPlayerRate):
(WebCore::MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldObserveTimeControlStatus):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (239856 => 239857)

--- trunk/Source/WebCore/ChangeLog	2019-01-11 04:39:23 UTC (rev 239856)
+++ trunk/Source/WebCore/ChangeLog	2019-01-11 04:46:23 UTC (rev 239857)
@@ -1,3 +1,45 @@
+2019-01-10  Jer Noble  
+
+ elements do not enter 'paused' state when playing to end over AirPlay
+https://bugs.webkit.org/show_bug.cgi?id=193295
+
+
+Reviewed by Eric Carlson.
+
+Adopt the -[AVPlayer timeControlStatus] API, which reports whether the AVPlayer is paused, playing, or blocked waiting
+for more data before playing. AirPlay devices report this state back from the remote device, and this allows the
+MediaPlayerPrivateAVFoundationObjC to differentiate between user-generated pauses and simple stalling.
+
+Adopting this API allows us to remove the heuristic from rateChanged() which inteprets a rate change when the
+readyState > HAVE_ENOUGH as an intentional pause.
+
+Drive-by fix: MediaPlayerPrivateAVFoundation had some code to delay calling platformPlay()
+until the first frame became available. But this code was entirely undermined by the previous
+behavior of setRate(). Fixing setRate()/setRateDouble() to only start playback if playback was
+actually requested started making this code work for the first time, and broke some API tests.
+Thus, we're removing this previously dead code.
+
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
+(WebCore::MediaPlayerPrivateAVFoundation::play):
+(WebCore::MediaPlayerPrivateAVFoundation::pause):
+(WebCore::MediaPlayerPrivateAVFoundation::rateChanged):
+(WebCore::MediaPlayerPrivateAVFoundation::updateStates):
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
+* 

[webkit-changes] [239856] trunk/Tools

[commit-queue]

Title: [239856] trunk/Tools








Revision 239856
Author commit-qu...@webkit.org
Date 2019-01-10 20:39:23 -0800 (Thu, 10 Jan 2019)


Log Message
MiniBrowser should be able to navigate to about:blank
https://bugs.webkit.org/show_bug.cgi?id=193345

Patch by Joseph Pecoraro  on 2019-01-10
Reviewed by Simon Fraser.

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController addProtocolIfNecessary:]):
Don't prepend "http://" to "about:" prefixed URLs like "about:blank".

* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController fetch:]):
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController fetch:]):
Clean up the code that uses this to match style.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/BrowserWindowController.m
trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m
trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m




Diff

Modified: trunk/Tools/ChangeLog (239855 => 239856)

--- trunk/Tools/ChangeLog	2019-01-11 04:38:04 UTC (rev 239855)
+++ trunk/Tools/ChangeLog	2019-01-11 04:39:23 UTC (rev 239856)
@@ -1,5 +1,22 @@
 2019-01-10  Joseph Pecoraro  
 
+MiniBrowser should be able to navigate to about:blank
+https://bugs.webkit.org/show_bug.cgi?id=193345
+
+Reviewed by Simon Fraser.
+
+* MiniBrowser/mac/BrowserWindowController.m:
+(-[BrowserWindowController addProtocolIfNecessary:]):
+Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
+
+* MiniBrowser/mac/WK1BrowserWindowController.m:
+(-[WK1BrowserWindowController fetch:]):
+* MiniBrowser/mac/WK2BrowserWindowController.m:
+(-[WK2BrowserWindowController fetch:]):
+Clean up the code that uses this to match style.
+
+2019-01-10  Joseph Pecoraro  
+
 Remove MiniBrowser custom "Process Swap" menu item which does not work
 https://bugs.webkit.org/show_bug.cgi?id=193344
 


Modified: trunk/Tools/MiniBrowser/mac/BrowserWindowController.m (239855 => 239856)

--- trunk/Tools/MiniBrowser/mac/BrowserWindowController.m	2019-01-11 04:38:04 UTC (rev 239855)
+++ trunk/Tools/MiniBrowser/mac/BrowserWindowController.m	2019-01-11 04:39:23 UTC (rev 239856)
@@ -65,6 +65,9 @@
 if ([address hasPrefix:@"data:"])
 return address;
 
+if ([address hasPrefix:@"about:"])
+return address;
+
 return [@"http://" stringByAppendingString:address];
 }
 


Modified: trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m (239855 => 239856)

--- trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m	2019-01-11 04:38:04 UTC (rev 239855)
+++ trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m	2019-01-11 04:39:23 UTC (rev 239856)
@@ -90,7 +90,7 @@
 
 - (IBAction)fetch:(id)sender
 {
-[urlText setStringValue:[self addProtocolIfNecessary:[urlText stringValue]]];
+[urlText setStringValue:[self addProtocolIfNecessary:urlText.stringValue]];
 NSURL *url = "" _webkit_URLWithUserTypedString:urlText.stringValue];
 [[_webView mainFrame] loadRequest:[NSURLRequest requestWithURL:url]];
 }


Modified: trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m (239855 => 239856)

--- trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m	2019-01-11 04:38:04 UTC (rev 239855)
+++ trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m	2019-01-11 04:39:23 UTC (rev 239856)
@@ -135,9 +135,9 @@
 
 - (IBAction)fetch:(id)sender
 {
-[urlText setStringValue:[self addProtocolIfNecessary:[urlText stringValue]]];
-
-[_webView loadRequest:[NSURLRequest requestWithURL:[NSURL _webkit_URLWithUserTypedString:[urlText stringValue;
+[urlText setStringValue:[self addProtocolIfNecessary:urlText.stringValue]];
+NSURL *url = "" _webkit_URLWithUserTypedString:urlText.stringValue];
+[_webView loadRequest:[NSURLRequest requestWithURL:url]];
 }
 
 - (IBAction)setPageScale:(id)sender






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239855] trunk/Tools

[commit-queue]

Title: [239855] trunk/Tools








Revision 239855
Author commit-qu...@webkit.org
Date 2019-01-10 20:38:04 -0800 (Thu, 10 Jan 2019)


Log Message
Remove MiniBrowser custom "Process Swap" menu item which does not work
https://bugs.webkit.org/show_bug.cgi?id=193344

Patch by Joseph Pecoraro  on 2019-01-10
Reviewed by Simon Fraser.

There is a menu item under the Experimental menu that does work.

* MiniBrowser/mac/AppDelegate.m:
(defaultConfiguration):
* MiniBrowser/mac/SettingsController.h:
* MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController processSwapOnNavigationEnabled]): Deleted.
(-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/AppDelegate.m
trunk/Tools/MiniBrowser/mac/SettingsController.h
trunk/Tools/MiniBrowser/mac/SettingsController.m




Diff

Modified: trunk/Tools/ChangeLog (239854 => 239855)

--- trunk/Tools/ChangeLog	2019-01-11 03:54:43 UTC (rev 239854)
+++ trunk/Tools/ChangeLog	2019-01-11 04:38:04 UTC (rev 239855)
@@ -1,3 +1,21 @@
+2019-01-10  Joseph Pecoraro  
+
+Remove MiniBrowser custom "Process Swap" menu item which does not work
+https://bugs.webkit.org/show_bug.cgi?id=193344
+
+Reviewed by Simon Fraser.
+
+There is a menu item under the Experimental menu that does work.
+
+* MiniBrowser/mac/AppDelegate.m:
+(defaultConfiguration):
+* MiniBrowser/mac/SettingsController.h:
+* MiniBrowser/mac/SettingsController.m:
+(-[SettingsController _populateMenu]):
+(-[SettingsController validateMenuItem:]):
+(-[SettingsController processSwapOnNavigationEnabled]): Deleted.
+(-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
+
 2019-01-10  Timothy Hatcher  
 
 Add WKBundlePage SPI to temporarily force light or dark appearance on a page.


Modified: trunk/Tools/MiniBrowser/mac/AppDelegate.m (239854 => 239855)

--- trunk/Tools/MiniBrowser/mac/AppDelegate.m	2019-01-11 03:54:43 UTC (rev 239854)
+++ trunk/Tools/MiniBrowser/mac/AppDelegate.m	2019-01-11 04:38:04 UTC (rev 239855)
@@ -101,8 +101,6 @@
 processConfiguration.diskCacheSpeculativeValidationEnabled = ![SettingsController shared].networkCacheSpeculativeRevalidationDisabled;
 if ([SettingsController shared].perWindowWebProcessesDisabled)
 processConfiguration.maximumProcessCount = 1;
-if ([SettingsController shared].processSwapOnNavigationEnabled)
-processConfiguration.processSwapsOnNavigation = true;
 if ([SettingsController shared].processSwapOnWindowOpenWithOpenerEnabled)
 processConfiguration.processSwapsOnWindowOpenWithOpener = true;
 


Modified: trunk/Tools/MiniBrowser/mac/SettingsController.h (239854 => 239855)

--- trunk/Tools/MiniBrowser/mac/SettingsController.h	2019-01-11 03:54:43 UTC (rev 239854)
+++ trunk/Tools/MiniBrowser/mac/SettingsController.h	2019-01-11 04:38:04 UTC (rev 239855)
@@ -62,7 +62,6 @@
 @property (nonatomic, readonly) BOOL loadsAllSiteIcons;
 @property (nonatomic, readonly) BOOL usesGameControllerFramework;
 @property (nonatomic, readonly) BOOL networkCacheSpeculativeRevalidationDisabled;
-@property (nonatomic, readonly) BOOL processSwapOnNavigationEnabled;
 @property (nonatomic, readonly) BOOL processSwapOnWindowOpenWithOpenerEnabled;
 
 @property (nonatomic, readonly) NSString *defaultURL;


Modified: trunk/Tools/MiniBrowser/mac/SettingsController.m (239854 => 239855)

--- trunk/Tools/MiniBrowser/mac/SettingsController.m	2019-01-11 03:54:43 UTC (rev 239854)
+++ trunk/Tools/MiniBrowser/mac/SettingsController.m	2019-01-11 04:38:04 UTC (rev 239855)
@@ -74,7 +74,6 @@
 
 static NSString * const PerWindowWebProcessesDisabledKey = @"PerWindowWebProcessesDisabled";
 static NSString * const NetworkCacheSpeculativeRevalidationDisabledKey = @"NetworkCacheSpeculativeRevalidationDisabled";
-static NSString * const ProcessSwapOnNavigationKey = @"ProcessSwapOnNavigation";
 static NSString * const ProcessSwapOnWindowOpenWithOpenerKey = @"ProcessSwapOnWindowOpenWithOpener";
 
 typedef NS_ENUM(NSInteger, DebugOverylayMenuItemTag) {
@@ -188,7 +187,6 @@
 [self _addItemWithTitle:@"Load All Site Icons Per-Page" action:@selector(toggleLoadsAllSiteIcons:) indented:YES];
 [self _addItemWithTitle:@"Use GameController.framework on macOS (Restart required)" action:@selector(toggleUsesGameControllerFramework:) indented:YES];
 [self _addItemWithTitle:@"Disable network cache speculative revalidation" action:@selector(toggleNetworkCacheSpeculativeRevalidationDisabled:) indented:YES];
-[self _addItemWithTitle:@"Enable Process Swap on Navigation" action:@selector(toggleProcessSwapOnNavigation:) indented:YES];
 [self _addItemWithTitle:@"Enable Process Swap on window.open() with an opener" action:@selector(toggleProcessSwapOnWindowOpenWithOpener:) indented:YES];
 
 

[webkit-changes] [239854] trunk/Source/WebCore

[mmaxfield]

Title: [239854] trunk/Source/WebCore








Revision 239854
Author mmaxfi...@apple.com
Date 2019-01-10 19:54:43 -0800 (Thu, 10 Jan 2019)


Log Message
Fix the build after r239844
https://bugs.webkit.org/show_bug.cgi?id=192991

Unreviewed.

* Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp:
(WebCore::WHLSL::AST::BuiltInSemantic::isAcceptableType const):
(WebCore::WHLSL::AST::BuiltInSemantic::isAcceptableForShaderItemDirection const):
* Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp:
(WebCore::WHLSL::AST::ResourceSemantic::isAcceptableType const):
(WebCore::WHLSL::AST::ResourceSemantic::isAcceptableForShaderItemDirection const):
* Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp:
(WebCore::WHLSL::AST::SpecializationConstantSemantic::isAcceptableType const):
(WebCore::WHLSL::AST::SpecializationConstantSemantic::isAcceptableForShaderItemDirection const):
* Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp:
(WebCore::WHLSL::AST::StageInOutSemantic::isAcceptableType const):
(WebCore::WHLSL::AST::StageInOutSemantic::isAcceptableForShaderItemDirection const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (239853 => 239854)

--- trunk/Source/WebCore/ChangeLog	2019-01-11 02:12:57 UTC (rev 239853)
+++ trunk/Source/WebCore/ChangeLog	2019-01-11 03:54:43 UTC (rev 239854)
@@ -1,3 +1,23 @@
+2019-01-10  Myles C. Maxfield  
+
+Fix the build after r239844
+https://bugs.webkit.org/show_bug.cgi?id=192991
+
+Unreviewed.
+
+* Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp:
+(WebCore::WHLSL::AST::BuiltInSemantic::isAcceptableType const):
+(WebCore::WHLSL::AST::BuiltInSemantic::isAcceptableForShaderItemDirection const):
+* Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp:
+(WebCore::WHLSL::AST::ResourceSemantic::isAcceptableType const):
+(WebCore::WHLSL::AST::ResourceSemantic::isAcceptableForShaderItemDirection const):
+* Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp:
+(WebCore::WHLSL::AST::SpecializationConstantSemantic::isAcceptableType const):
+(WebCore::WHLSL::AST::SpecializationConstantSemantic::isAcceptableForShaderItemDirection const):
+* Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp:
+(WebCore::WHLSL::AST::StageInOutSemantic::isAcceptableType const):
+(WebCore::WHLSL::AST::StageInOutSemantic::isAcceptableForShaderItemDirection const):
+
 2019-01-10  Justin Fan  
 
 [WebGPU] WebGPUBindGroup and device::createBindGroup prototype


Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp (239853 => 239854)

--- trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp	2019-01-11 02:12:57 UTC (rev 239853)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp	2019-01-11 03:54:43 UTC (rev 239854)
@@ -37,6 +37,74 @@
 
 namespace AST {
 
+bool BuiltInSemantic::isAcceptableType(const UnnamedType&, const Intrinsics&) const
+{
+// FIXME: Implement this
+return true;
+}
+
+bool BuiltInSemantic::isAcceptableForShaderItemDirection(ShaderItemDirection direction, const FunctionDefinition& functionDefinition) const
+{
+switch (*functionDefinition.entryPointType()) {
+case FunctionDeclaration::EntryPointType::Vertex:
+switch (direction) {
+case ShaderItemDirection::Input:
+switch (m_variable) {
+case Variable::SVInstanceID:
+case Variable::SVVertexID:
+return true;
+default:
+return false;
+}
+case ShaderItemDirection::Output:
+switch (m_variable) {
+case Variable::PSize:
+case Variable::SVPosition:
+return true;
+default:
+return false;
+}
+}
+case FunctionDeclaration::EntryPointType::Fragment:
+switch (direction) {
+case ShaderItemDirection::Input:
+switch (m_variable) {
+case Variable::SVIsFrontFace:
+case Variable::SVPosition:
+case Variable::SVSampleIndex:
+case Variable::SVInnerCoverage:
+return true;
+default:
+return false;
+}
+case ShaderItemDirection::Output:
+switch (m_variable) {
+case Variable::SVTarget:
+case Variable::SVDepth:
+case Variable::SVCoverage:
+return true;
+default:
+return false;
+}
+}
+case FunctionDeclaration::EntryPointType::Compute:
+ 

[webkit-changes] [239853] trunk

[justin_fan]

Title: [239853] trunk








Revision 239853
Author justin_...@apple.com
Date 2019-01-10 18:12:57 -0800 (Thu, 10 Jan 2019)


Log Message
[WebGPU] WebGPUBindGroup and device::createBindGroup prototype
https://bugs.webkit.org/show_bug.cgi?id=193341

Reviewed by Myles C. Maxfield.

Source/WebCore:

Add *GPUBindGroup class stubs and the ability to create WebGPUBindGroups via the API.

Test: bind-groups.html

* CMakeLists.txt:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:

* Modules/webgpu/WebGPUBindGroup.cpp:
(WebCore::WebGPUBindGroup::create):
(WebCore::WebGPUBindGroup::WebGPUBindGroup):
* Modules/webgpu/WebGPUBindGroup.h:
* Modules/webgpu/WebGPUBindGroup.idl: Enable createBindGroup().
* Modules/webgpu/WebGPUDevice.cpp:
(WebCore::BindingResourceVisitor::operator() const): Added. Validate and convert WebGPUBindGroupDescriptor to GPU* version.
(WebCore::WebGPUDevice::createBindGroup const): Added.
* Modules/webgpu/WebGPUDevice.h:
* platform/graphics/gpu/GPUBindGroup.cpp:
(WebCore::GPUBindGroup::create):
(WebCore::GPUBindGroup::GPUBindGroup):
* platform/graphics/gpu/GPUBindGroup.h:
* platform/graphics/gpu/GPUBufferBinding.h:
* platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm:
(WebCore::appendArgumentToArray): Pass RetainPtr by reference to actually update descriptor.

LayoutTests:

Small test that creates a WebGPUBindGroup.

* webgpu/bind-groups-expected.txt: Added.
* webgpu/bind-groups.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.h
trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.idl
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
trunk/Source/WebCore/platform/graphics/gpu/GPUBufferBinding.h
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm


Added Paths

trunk/LayoutTests/webgpu/bind-groups-expected.txt
trunk/LayoutTests/webgpu/bind-groups.html
trunk/Source/WebCore/Modules/webgpu/WebGPUBindGroup.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPUBindGroup.h
trunk/Source/WebCore/Modules/webgpu/WebGPUBindGroup.idl
trunk/Source/WebCore/platform/graphics/gpu/GPUBindGroup.cpp
trunk/Source/WebCore/platform/graphics/gpu/GPUBindGroup.h




Diff

Modified: trunk/LayoutTests/ChangeLog (239852 => 239853)

--- trunk/LayoutTests/ChangeLog	2019-01-11 01:42:34 UTC (rev 239852)
+++ trunk/LayoutTests/ChangeLog	2019-01-11 02:12:57 UTC (rev 239853)
@@ -1,3 +1,15 @@
+2019-01-10  Justin Fan  
+
+[WebGPU] WebGPUBindGroup and device::createBindGroup prototype
+https://bugs.webkit.org/show_bug.cgi?id=193341
+
+Reviewed by Myles C. Maxfield.
+
+Small test that creates a WebGPUBindGroup.
+
+* webgpu/bind-groups-expected.txt: Added.
+* webgpu/bind-groups.html: Added.
+
 2019-01-10  Eric Carlson  
 
 Define page media state flags for display capture.


Added: trunk/LayoutTests/webgpu/bind-groups-expected.txt (0 => 239853)

--- trunk/LayoutTests/webgpu/bind-groups-expected.txt	(rev 0)
+++ trunk/LayoutTests/webgpu/bind-groups-expected.txt	2019-01-11 02:12:57 UTC (rev 239853)
@@ -0,0 +1,3 @@
+
+PASS Create a basic WebGPUBindGroup via WebGPUDevice. 
+


Added: trunk/LayoutTests/webgpu/bind-groups.html (0 => 239853)

--- trunk/LayoutTests/webgpu/bind-groups.html	(rev 0)
+++ trunk/LayoutTests/webgpu/bind-groups.html	2019-01-11 02:12:57 UTC (rev 239853)
@@ -0,0 +1,30 @@
+
+
+Create a basic WebGPUBindGroup.
+
+
+promise_test(async () => {
+const device = await getBasicDevice();
+
+// WebGPUBindGroupLayoutBindings
+// FIXME: Also test sampled texture bindings. 
+const bufferLayoutBinding = {
+binding: 1,
+visibility: WebGPUShaderStageBit.VERTEX,
+type: "storageBuffer"
+};
+
+const bindGroupLayout = device.createBindGroupLayout({ bindings: [bufferLayoutBinding]});
+
+const buffer = device.createBuffer({ size: 16, usage: WebGPUBufferUsage.STORAGE });
+const bufferBinding = { buffer: buffer, offset: 0, size: 16 };
+const bindGroupBinding = { binding: 1, resource: bufferBinding };
+
+const bindGroup = device.createBindGroup({ layout: bindGroupLayout, bindings: [bindGroupBinding]});
+assert_true(bindGroup instanceof WebGPUBindGroup, "WebGPUBindGroup successfully created.")
+}, "Create a basic WebGPUBindGroup via WebGPUDevice.")
+
+
\ No newline at end of file


Modified: trunk/Source/WebCore/CMakeLists.txt (239852 => 239853)

--- trunk/Source/WebCore/CMakeLists.txt	2019-01-11 01:42:34 UTC (rev 239852)
+++ trunk/Source/WebCore/CMakeLists.txt	2019-01-11 02:12:57 UTC (rev 239853)
@@ -464,6 +464,7 @@
 Modules/webgpu/WebGPU.idl
 Modules/webgpu/WebGPUAdapter.idl
 

[webkit-changes] [239852] trunk/Source/WebKit

[jiewen_tan]

Title: [239852] trunk/Source/WebKit








Revision 239852
Author jiewen_...@apple.com
Date 2019-01-10 17:42:34 -0800 (Thu, 10 Jan 2019)


Log Message
[WebAuthN] Change the nonce in the CTAP kInit command to weak random values
https://bugs.webkit.org/show_bug.cgi?id=192061


Reviewed by Chris Dumez.

Change the nonce in the CTAP kInit command to weak random values as the nonce is mainly
for being a probabilistically unique global identifier for hand shakes, instead of
preventing replay attacks. Otherwise, it might exhaust system entropy unnecessarily.

The patch also removes all logging when debugging the test case flakiness.

* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::respondReceived):
(WebKit::AuthenticatorManager::initTimeOutTimer):
(WebKit::AuthenticatorManager::timeOutTimerFired):
* UIProcess/WebAuthentication/Cocoa/HidService.mm:
(WebKit::HidService::deviceAdded):
* UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp:
(WebKit::MockAuthenticatorManager::respondReceivedInternal):
* UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
(WebKit::MockHidConnection::send):
* UIProcess/WebAuthentication/fido/CtapHidAuthenticator.cpp:
(WebKit::CtapHidAuthenticator::makeCredential):
(WebKit::CtapHidAuthenticator::getAssertion):
* UIProcess/WebAuthentication/fido/CtapHidDriver.cpp:
(WebKit::CtapHidDriver::Worker::write):
(WebKit::CtapHidDriver::Worker::read):
(WebKit::CtapHidDriver::Worker::returnMessage):
(WebKit::CtapHidDriver::transact):
(WebKit::CtapHidDriver::continueAfterChannelAllocated):
(WebKit::CtapHidDriver::continueAfterResponseReceived):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm
trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp
trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp
trunk/Source/WebKit/UIProcess/WebAuthentication/fido/CtapHidAuthenticator.cpp
trunk/Source/WebKit/UIProcess/WebAuthentication/fido/CtapHidDriver.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (239851 => 239852)

--- trunk/Source/WebKit/ChangeLog	2019-01-11 01:11:57 UTC (rev 239851)
+++ trunk/Source/WebKit/ChangeLog	2019-01-11 01:42:34 UTC (rev 239852)
@@ -1,3 +1,38 @@
+2019-01-10  Jiewen Tan  
+
+[WebAuthN] Change the nonce in the CTAP kInit command to weak random values
+https://bugs.webkit.org/show_bug.cgi?id=192061
+
+
+Reviewed by Chris Dumez.
+
+Change the nonce in the CTAP kInit command to weak random values as the nonce is mainly
+for being a probabilistically unique global identifier for hand shakes, instead of
+preventing replay attacks. Otherwise, it might exhaust system entropy unnecessarily.
+
+The patch also removes all logging when debugging the test case flakiness.
+
+* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
+(WebKit::AuthenticatorManager::respondReceived):
+(WebKit::AuthenticatorManager::initTimeOutTimer):
+(WebKit::AuthenticatorManager::timeOutTimerFired):
+* UIProcess/WebAuthentication/Cocoa/HidService.mm:
+(WebKit::HidService::deviceAdded):
+* UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp:
+(WebKit::MockAuthenticatorManager::respondReceivedInternal):
+* UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
+(WebKit::MockHidConnection::send):
+* UIProcess/WebAuthentication/fido/CtapHidAuthenticator.cpp:
+(WebKit::CtapHidAuthenticator::makeCredential):
+(WebKit::CtapHidAuthenticator::getAssertion):
+* UIProcess/WebAuthentication/fido/CtapHidDriver.cpp:
+(WebKit::CtapHidDriver::Worker::write):
+(WebKit::CtapHidDriver::Worker::read):
+(WebKit::CtapHidDriver::Worker::returnMessage):
+(WebKit::CtapHidDriver::transact):
+(WebKit::CtapHidDriver::continueAfterChannelAllocated):
+(WebKit::CtapHidDriver::continueAfterResponseReceived):
+
 2019-01-10  Timothy Hatcher  
 
 Add WKBundlePage SPI to temporarily force light or dark appearance on a page.


Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp (239851 => 239852)

--- trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp	2019-01-11 01:11:57 UTC (rev 239851)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp	2019-01-11 01:42:34 UTC (rev 239852)
@@ -192,8 +192,6 @@
 if (WTF::holds_alternative(respond)) {
 m_pendingCompletionHandler(WTFMove(respond));
 clearStateAsync();
-// FIXME(192061)
-LOG_ERROR("Stop timer.");
 m_requestTimeOutTimer.stop();
 return;
 }
@@ -226,17 +224,12 @@
 using namespace AuthenticatorManagerInternal;
 
 unsigned timeOutInMsValue = std::min(maxTimeOutValue, 

[webkit-changes] [239851] trunk

[timothy]

Title: [239851] trunk








Revision 239851
Author timo...@apple.com
Date 2019-01-10 17:11:57 -0800 (Thu, 10 Jan 2019)


Log Message
Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
https://bugs.webkit.org/show_bug.cgi?id=193327
rdar://problem/47093222

Reviewed by Tim Horton.

Source/WebKit:

Tests: WebKit.ForceLightAppearanceInBundle API Test

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetUseDarkAppearance): Added.
(WKBundlePageIsUsingDarkAppearance): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
(TestWebKitAPI::didFinishNavigation):
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
(TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
(TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
(TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
* TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm
trunk/Tools/TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm
trunk/Tools/TestWebKitAPI/Tests/WebKit/mac/dark-mode.html




Diff

Modified: trunk/Source/WebKit/ChangeLog (239850 => 239851)

--- trunk/Source/WebKit/ChangeLog	2019-01-11 00:49:23 UTC (rev 239850)
+++ trunk/Source/WebKit/ChangeLog	2019-01-11 01:11:57 UTC (rev 239851)
@@ -1,3 +1,18 @@
+2019-01-10  Timothy Hatcher  
+
+Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
+https://bugs.webkit.org/show_bug.cgi?id=193327
+rdar://problem/47093222
+
+Reviewed by Tim Horton.
+
+Tests: WebKit.ForceLightAppearanceInBundle API Test
+
+* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
+(WKBundlePageSetUseDarkAppearance): Added.
+(WKBundlePageIsUsingDarkAppearance): Added.
+* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
+
 2019-01-10  Eric Carlson  
 
 DeviceID hash salt manager can be NULL


Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp (239850 => 239851)

--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp	2019-01-11 00:49:23 UTC (rev 239850)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp	2019-01-11 01:11:57 UTC (rev 239851)
@@ -589,6 +589,21 @@
 WebKit::toImpl(pageRef)->confirmCompositionForTesting(WebKit::toWTFString(text));
 }
 
+void WKBundlePageSetUseDarkAppearance(WKBundlePageRef pageRef, bool useDarkAppearance)
+{
+WebKit::WebPage* webPage = WebKit::toImpl(pageRef);
+if (WebCore::Page* page = webPage ? webPage->corePage() : nullptr)
+page->setUseDarkAppearance(useDarkAppearance);
+}
+
+bool WKBundlePageIsUsingDarkAppearance(WKBundlePageRef pageRef)
+{
+WebKit::WebPage* webPage = WebKit::toImpl(pageRef);
+if (WebCore::Page* page = webPage ? webPage->corePage() : nullptr)
+return page->useDarkAppearance();
+return false;
+}
+
 bool WKBundlePageCanShowMIMEType(WKBundlePageRef pageRef, WKStringRef mimeTypeRef)
 {
 return WebKit::toImpl(pageRef)->canShowMIMEType(WebKit::toWTFString(mimeTypeRef));


Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h (239850 => 239851)

--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h	2019-01-11 00:49:23 UTC (rev 239850)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h	2019-01-11 01:11:57 UTC (rev 239851)
@@ -77,6 +77,9 @@
 WK_EXPORT void WKBundlePageConfirmComposition(WKBundlePageRef page);
 WK_EXPORT void WKBundlePageConfirmCompositionWithText(WKBundlePageRef page, WKStringRef text);
 
+WK_EXPORT void WKBundlePageSetUseDarkAppearance(WKBundlePageRef page, bool useDarkAppearance);
+WK_EXPORT bool WKBundlePageIsUsingDarkAppearance(WKBundlePageRef page);
+
 WK_EXPORT bool WKBundlePageCanShowMIMEType(WKBundlePageRef, WKStringRef mimeType);
 
 WK_EXPORT void* WKAccessibilityRootObject(WKBundlePageRef);


Modified: trunk/Tools/ChangeLog (239850 => 239851)

--- trunk/Tools/ChangeLog	2019-01-11 00:49:23 UTC (rev 239850)
+++ trunk/Tools/ChangeLog	2019-01-11 01:11:57 UTC (rev 239851)
@@ -1,3 +1,22 @@
+2019-01-10  Timothy Hatcher  
+
+Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
+https://bugs.webkit.org/show_bug.cgi?id=193327
+rdar://problem/47093222
+
+Reviewed by Tim Horton.
+
+* 

[webkit-changes] [239850] trunk/Source/WebKit

[eric . carlson]

Title: [239850] trunk/Source/WebKit








Revision 239850
Author eric.carl...@apple.com
Date 2019-01-10 16:49:23 -0800 (Thu, 10 Jan 2019)


Log Message
DeviceID hash salt manager can be NULL
https://bugs.webkit.org/show_bug.cgi?id=193334


Reviewed by Youenn Fablet.

* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted): No need to
NULL-check websiteDataStore.deviceIdHashSaltStorage, it is a Ref.
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Ditto.

* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::WebsiteDataStore): m_deviceIdHashSaltStorage is a Ref.
(WebKit::WebsiteDataStore::fetchDataAndApply): Ditto.
(WebKit::WebsiteDataStore::removeData): Ditto.
* UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::deviceIdHashSaltStorage): Ditto.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp
trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (239849 => 239850)

--- trunk/Source/WebKit/ChangeLog	2019-01-11 00:09:01 UTC (rev 239849)
+++ trunk/Source/WebKit/ChangeLog	2019-01-11 00:49:23 UTC (rev 239850)
@@ -1,3 +1,25 @@
+2019-01-10  Eric Carlson  
+
+DeviceID hash salt manager can be NULL
+https://bugs.webkit.org/show_bug.cgi?id=193334
+
+
+Reviewed by Youenn Fablet.
+
+* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
+(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted): No need to
+NULL-check websiteDataStore.deviceIdHashSaltStorage, it is a Ref.
+(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame): Ditto.
+(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Ditto.
+(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Ditto.
+
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::WebsiteDataStore): m_deviceIdHashSaltStorage is a Ref.
+(WebKit::WebsiteDataStore::fetchDataAndApply): Ditto.
+(WebKit::WebsiteDataStore::removeData): Ditto.
+* UIProcess/WebsiteData/WebsiteDataStore.h:
+(WebKit::WebsiteDataStore::deviceIdHashSaltStorage): Ditto.
+
 2019-01-10  Per Arne Vollan  
 
 [macOS] Add name of IORegistry key in sandbox.


Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp (239849 => 239850)

--- trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp	2019-01-11 00:09:01 UTC (rev 239849)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp	2019-01-11 00:49:23 UTC (rev 239850)
@@ -193,7 +193,7 @@
 
 bool checkUserMediaPermissionForOrigin(WebPageProxy& page, WebFrameProxy&, API::SecurityOrigin& userMediaDocumentOrigin, API::SecurityOrigin& topLevelDocumentOrigin, UserMediaPermissionCheckProxy& permissionRequest) override
 {
-auto deviceInfoPermissionRequest = adoptGRef(webkitDeviceInfoPermissionRequestCreate(permissionRequest, page.websiteDataStore().deviceIdHashSaltStorage()));
+auto deviceInfoPermissionRequest = adoptGRef(webkitDeviceInfoPermissionRequestCreate(permissionRequest, ().deviceIdHashSaltStorage()));
 webkitWebViewMakePermissionRequest(m_webView, WEBKIT_PERMISSION_REQUEST(deviceInfoPermissionRequest.get()));
 return true;
 }


Modified: trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp (239849 => 239850)

--- trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp	2019-01-11 00:09:01 UTC (rev 239849)
+++ trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp	2019-01-11 00:49:23 UTC (rev 239850)
@@ -178,7 +178,7 @@
 {
 ASSERT(audioDevice || videoDevice);
 
-if (!m_page.isValid() || !m_page.websiteDataStore().deviceIdHashSaltStorage())
+if (!m_page.isValid())
 return;
 
 #if ENABLE(MEDIA_STREAM)
@@ -186,7 +186,7 @@
 if (!request)
 return;
 
-m_page.websiteDataStore().deviceIdHashSaltStorage()->deviceIdHashSaltForOrigin(request->userMediaDocumentSecurityOrigin(), request->topLevelDocumentSecurityOrigin(), [this, weakThis = makeWeakPtr(*this), userMediaID, audioDevice = WTFMove(audioDevice), videoDevice = WTFMove(videoDevice), localRequest = request.copyRef()] (String&& deviceIDHashSalt) mutable {
+m_page.websiteDataStore().deviceIdHashSaltStorage().deviceIdHashSaltForOrigin(request->userMediaDocumentSecurityOrigin(), request->topLevelDocumentSecurityOrigin(), [this, weakThis = makeWeakPtr(*this), 

[webkit-changes] [239849] tags/Safari-607.1.21/

[kocsen_chung]

Title: [239849] tags/Safari-607.1.21/








Revision 239849
Author kocsen_ch...@apple.com
Date 2019-01-10 16:09:01 -0800 (Thu, 10 Jan 2019)


Log Message
Tag Safari-607.1.21.

Added Paths

tags/Safari-607.1.21/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239848] trunk/Tools

[commit-queue]

Title: [239848] trunk/Tools








Revision 239848
Author commit-qu...@webkit.org
Date 2019-01-10 15:03:47 -0800 (Thu, 10 Jan 2019)


Log Message
Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
https://bugs.webkit.org/show_bug.cgi?id=193338


Patch by Joseph Pecoraro  on 2019-01-10
Reviewed by David Kilzer.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::decidePolicyForNavigationAction):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp




Diff

Modified: trunk/Tools/ChangeLog (239847 => 239848)

--- trunk/Tools/ChangeLog	2019-01-10 22:50:13 UTC (rev 239847)
+++ trunk/Tools/ChangeLog	2019-01-10 23:03:47 UTC (rev 239848)
@@ -1,3 +1,14 @@
+2019-01-10  Joseph Pecoraro  
+
+Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
+https://bugs.webkit.org/show_bug.cgi?id=193338
+
+
+Reviewed by David Kilzer.
+
+* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+(WTR::InjectedBundlePage::decidePolicyForNavigationAction):
+
 2019-01-10  Commit Queue  
 
 Unreviewed, rolling out r239825.


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp (239847 => 239848)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp	2019-01-10 22:50:13 UTC (rev 239847)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp	2019-01-10 23:03:47 UTC (rev 239848)
@@ -1372,10 +1372,11 @@
 stringBuilder.appendLiteral(" with navigation type \'");
 stringBuilder.append(toWTFString(NavigationTypeToString(WKBundleNavigationActionGetNavigationType(navigationAction;
 stringBuilder.appendLiteral("\'");
-WKBundleHitTestResultRef hitTestResultRef = WKBundleNavigationActionCopyHitTestResult(navigationAction);
+WKRetainPtr hitTestResultRef = adoptWK(WKBundleNavigationActionCopyHitTestResult(navigationAction));
 if (hitTestResultRef) {
+WKRetainPtr nodeHandleRef = adoptWK(WKBundleHitTestResultCopyNodeHandle(hitTestResultRef.get()));
 stringBuilder.appendLiteral(" originating from ");
-stringBuilder.append(dumpPath(m_page, m_world.get(), WKBundleHitTestResultCopyNodeHandle(hitTestResultRef)));
+stringBuilder.append(dumpPath(m_page, m_world.get(), nodeHandleRef.get()));
 }
 
 stringBuilder.append('\n');






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239847] trunk/Source/WebCore

[simon . fraser]

Title: [239847] trunk/Source/WebCore








Revision 239847
Author simon.fra...@apple.com
Date 2019-01-10 14:50:13 -0800 (Thu, 10 Jan 2019)


Log Message
Fix rare crash under ScrollbarThemeMac::paintScrollCorner()
https://bugs.webkit.org/show_bug.cgi?id=193337
rdar://problem/47179993

Reviewed by Zalan Bujtas.

Async image decoding can trigger a FrameView::traverseForPaintInvalidation() fake paint,
which creates a GraphicsContext with no platform context. However, we could hit ScrollView::paintScrollbars()
which tried to get at the platform context, and then crashed.

So protect two functions in ScrollbarThemeMac with if (context.paintingDisabled()) checks. I verified
that other scrollbar-related painting code paths were already protected.

Hard to test because it depends on async image decoding timing.

* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
(WebCore::ScrollbarThemeMac::paintScrollCorner):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (239846 => 239847)

--- trunk/Source/WebCore/ChangeLog	2019-01-10 22:36:56 UTC (rev 239846)
+++ trunk/Source/WebCore/ChangeLog	2019-01-10 22:50:13 UTC (rev 239847)
@@ -1,3 +1,24 @@
+2019-01-10  Simon Fraser  
+
+Fix rare crash under ScrollbarThemeMac::paintScrollCorner()
+https://bugs.webkit.org/show_bug.cgi?id=193337
+rdar://problem/47179993
+
+Reviewed by Zalan Bujtas.
+
+Async image decoding can trigger a FrameView::traverseForPaintInvalidation() fake paint,
+which creates a GraphicsContext with no platform context. However, we could hit ScrollView::paintScrollbars()
+which tried to get at the platform context, and then crashed.
+
+So protect two functions in ScrollbarThemeMac with if (context.paintingDisabled()) checks. I verified
+that other scrollbar-related painting code paths were already protected.
+
+Hard to test because it depends on async image decoding timing.
+
+* platform/mac/ScrollbarThemeMac.mm:
+(WebCore::ScrollbarThemeMac::paint):
+(WebCore::ScrollbarThemeMac::paintScrollCorner):
+
 2019-01-10  Myles C. Maxfield  
 
 [WHLSL] Implement parser AST nodes


Modified: trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm (239846 => 239847)

--- trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm	2019-01-10 22:36:56 UTC (rev 239846)
+++ trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm	2019-01-10 22:50:13 UTC (rev 239847)
@@ -550,6 +550,9 @@
 
 bool ScrollbarThemeMac::paint(Scrollbar& scrollbar, GraphicsContext& context, const IntRect& damageRect)
 {
+if (context.paintingDisabled())
+return false;
+
 setPaintCharacteristicsForScrollbar(scrollbar);
 
 if (scrollbar.supportsUpdateOnSecondaryThread())
@@ -568,6 +571,9 @@
 
 void ScrollbarThemeMac::paintScrollCorner(GraphicsContext& context, const IntRect& cornerRect)
 {
+if (context.paintingDisabled())
+return;
+
 LocalCurrentGraphicsContext localContext(context);
 
 auto cornerDrawingOptions = @{ (__bridge NSString *)kCUIWidgetKey: (__bridge NSString *)kCUIWidgetScrollBarTrackCorner,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239846] trunk/Source/JavaScriptCore

[bburg]

Title: [239846] trunk/Source/_javascript_Core








Revision 239846
Author bb...@apple.com
Date 2019-01-10 14:36:56 -0800 (Thu, 10 Jan 2019)


Log Message
Web Inspector: incorrect type signature used for protocol enums in async command results
https://bugs.webkit.org/show_bug.cgi?id=193331

Reviewed by Devin Rousso.

When an enum is returned by an async command, the type signature should be that of the
Inspector::Protocol::* generated enum, rather than the underlying primitive type (i.e., String).

* inspector/scripts/codegen/cpp_generator.py:
(CppGenerator.cpp_type_for_formal_async_parameter):
* inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
Rebaseline generator test results.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/scripts/codegen/cpp_generator.py
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (239845 => 239846)

--- trunk/Source/_javascript_Core/ChangeLog	2019-01-10 22:31:10 UTC (rev 239845)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-01-10 22:36:56 UTC (rev 239846)
@@ -1,5 +1,20 @@
 2019-01-10  Brian Burg  
 
+Web Inspector: incorrect type signature used for protocol enums in async command results
+https://bugs.webkit.org/show_bug.cgi?id=193331
+
+Reviewed by Devin Rousso.
+
+When an enum is returned by an async command, the type signature should be that of the
+Inspector::Protocol::* generated enum, rather than the underlying primitive type (i.e., String).
+
+* inspector/scripts/codegen/cpp_generator.py:
+(CppGenerator.cpp_type_for_formal_async_parameter):
+* inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
+Rebaseline generator test results.
+
+2019-01-10  Brian Burg  
+
 Rebaseline inspector generator test results after recent changes.
 
 Unreviewed test gardening.


Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/cpp_generator.py (239845 => 239846)

--- trunk/Source/_javascript_Core/inspector/scripts/codegen/cpp_generator.py	2019-01-10 22:31:10 UTC (rev 239845)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/cpp_generator.py	2019-01-10 22:36:56 UTC (rev 239846)
@@ -229,9 +229,6 @@
 if isinstance(_type, AliasedType):
 _type = _type.aliased_type  # Fall through.
 
-if isinstance(_type, EnumType):
-_type = _type.primitive_type  # Fall through.
-
 if isinstance(_type, (ObjectType, ArrayType)):
 return 'RefPtr<%s>&&' % CppGenerator.cpp_protocol_type_for_type(_type)
 if isinstance(_type, PrimitiveType):
@@ -244,7 +241,17 @@
 return 'const %s&' % cpp_name
 else:
 return cpp_name
+if isinstance(_type, EnumType):
+if _type.is_anonymous:
+cpp_name = '%sBackendDispatcherHandler::%s' % (_type.type_domain().domain_name, ucfirst(parameter.parameter_name))
+else:
+cpp_name = 'Inspector::Protocol::%s::%s' % (_type.type_domain().domain_name, _type.raw_name())
 
+if parameter.is_optional:
+return "Optional<%s>" % cpp_name
+else:
+return cpp_name
+
 raise ValueError("Unknown formal async parameter type.")
 
 # In-parameters don't use builder types, because they could be passed


Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result (239845 => 239846)

--- trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result	2019-01-10 22:31:10 UTC (rev 239845)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result	2019-01-10 22:36:56 UTC (rev 239846)
@@ -161,7 +161,7 @@
 class ExecuteSQLAsyncOptionalReturnValuesCallback : public BackendDispatcher::CallbackBase {
 public:
 ExecuteSQLAsyncOptionalReturnValuesCallback(Ref&&, int id);
-void sendSuccess(RefPtr>&& columnNames, Optional& notes, Optional& timestamp, Optional& values, Optional& payload, Optional& databaseId, RefPtr&& sqlError, Optional& screenColor, RefPtr&& alternateColors, Optional& printColor);
+void sendSuccess(RefPtr>&& columnNames, Optional& notes, Optional& timestamp, Optional& values, Optional& payload, Optional& databaseId, RefPtr&& sqlError, Optional screenColor, RefPtr&& alternateColors, Optional printColor);
 };
 virtual void executeSQLAsyncOptionalReturnValues(int in_databaseId, const String& in_query, Ref&& callback) = 0;
 virtual void executeSQLSync(ErrorString&, int in_databaseId, const String& in_query, RefPtr>& out_columnNames, String* out_notes, double* out_timestamp, JSON::Object* out_values, JSON::Value* 

[webkit-changes] [239845] trunk/Source/WebKit

[pvollan]

Title: [239845] trunk/Source/WebKit








Revision 239845
Author pvol...@apple.com
Date 2019-01-10 14:31:10 -0800 (Thu, 10 Jan 2019)


Log Message
[macOS] Add name of IORegistry key in sandbox.
https://bugs.webkit.org/show_bug.cgi?id=193335


Reviewed by Alexey Proskuryakov.

The property IOGVAHEVCDecodeCapabilities was added in https://bugs.webkit.org/show_bug.cgi?id=193324.
Also, the property IOGVAHEVCEncodeCapabilities needs to be added.

* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (239844 => 239845)

--- trunk/Source/WebKit/ChangeLog	2019-01-10 22:17:58 UTC (rev 239844)
+++ trunk/Source/WebKit/ChangeLog	2019-01-10 22:31:10 UTC (rev 239845)
@@ -1,3 +1,16 @@
+2019-01-10  Per Arne Vollan  
+
+[macOS] Add name of IORegistry key in sandbox.
+https://bugs.webkit.org/show_bug.cgi?id=193335
+
+
+Reviewed by Alexey Proskuryakov.
+
+The property IOGVAHEVCDecodeCapabilities was added in https://bugs.webkit.org/show_bug.cgi?id=193324.
+Also, the property IOGVAHEVCEncodeCapabilities needs to be added.
+
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2019-01-10  Zalan Bujtas  
 
 REGRESSION (r237658): Tap highlight limits cause the highlight to no longer show with legitimate button sizes


Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (239844 => 239845)

--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-01-10 22:17:58 UTC (rev 239844)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-01-10 22:31:10 UTC (rev 239845)
@@ -248,7 +248,7 @@
 (iokit-property "IOFramebufferOpenGLIndex")
 (iokit-property "IOGeneralInterest")
 (iokit-property "IOGLBundleName")
-(iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|VTCapabilities|HEVCDecodeCapabilities)")
+(iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|VTCapabilities|HEVCDecodeCapabilities|HEVCEncodeCapabilities)")
 (iokit-property-regex #"^IOGVA(.*)(De|En)code$")
 (iokit-property "IOHibernateState")
 (iokit-property "IOI2CTransactionTypes")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239843] trunk/Source

[zalan]

Title: [239843] trunk/Source








Revision 239843
Author za...@apple.com
Date 2019-01-10 13:50:42 -0800 (Thu, 10 Jan 2019)


Log Message
REGRESSION (r237658): Tap highlight limits cause the highlight to no longer show with legitimate button sizes
https://bugs.webkit.org/show_bug.cgi?id=193294


Reviewed by Simon Fraser.

Input type elements should always paint tap highlight (ignore size heuristic).

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didGetTapHighlightGeometries):
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _showTapHighlight]):
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:nodeHasBuiltInClickHandling:]):
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]): Deleted.
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didGetTapHighlightGeometries):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):

Modified Paths

trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/PageClient.h
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.h
trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (239842 => 239843)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2019-01-10 21:46:30 UTC (rev 239842)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2019-01-10 21:50:42 UTC (rev 239843)
@@ -4242,7 +4242,7 @@
 		D3A94A3B122DABAC00A37BBC /* MediaQueryListListener.h in Headers */ = {isa = PBXBuildFile; fileRef = D3A94A34122DABAC00A37BBC /* MediaQueryListListener.h */; };
 		D3A94A47122DC40F00A37BBC /* JSMediaQueryList.h in Headers */ = {isa = PBXBuildFile; fileRef = D3A94A43122DC40F00A37BBC /* JSMediaQueryList.h */; };
 		D3AA10F4123A98AA0092152B /* MediaQueryMatcher.h in Headers */ = {isa = PBXBuildFile; fileRef = D3AA10F2123A98AA0092152B /* MediaQueryMatcher.h */; };
-		D3D4E973130C7CFE007BA540 /* HTMLSummaryElement.h in Headers */ = {isa = PBXBuildFile; fileRef = D3D4E971130C7CFE007BA540 /* HTMLSummaryElement.h */; };
+		D3D4E973130C7CFE007BA540 /* HTMLSummaryElement.h in Headers */ = {isa = PBXBuildFile; fileRef = D3D4E971130C7CFE007BA540 /* HTMLSummaryElement.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		D3F3D3641A69B1900059FC2B /* JSWebGL2RenderingContext.h in Headers */ = {isa = PBXBuildFile; fileRef = D3F3D3621A69B1900059FC2B /* JSWebGL2RenderingContext.h */; };
 		D3F3D3691A69B7B00059FC2B /* WebGLRenderingContextBase.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D3F3D35E1A69A5060059FC2B /* WebGLRenderingContextBase.cpp */; };
 		D3F3D36A1A69B7B90059FC2B /* WebGLRenderingContextBase.h in Headers */ = {isa = PBXBuildFile; fileRef = D3F3D35F1A69A5060059FC2B /* WebGLRenderingContextBase.h */; };


Modified: trunk/Source/WebKit/ChangeLog (239842 => 239843)

--- trunk/Source/WebKit/ChangeLog	2019-01-10 21:46:30 UTC (rev 239842)
+++ trunk/Source/WebKit/ChangeLog	2019-01-10 21:50:42 UTC (rev 239843)
@@ -1,3 +1,29 @@
+2019-01-10  Zalan Bujtas  
+
+REGRESSION (r237658): Tap highlight limits cause the highlight to no longer show with legitimate button sizes
+https://bugs.webkit.org/show_bug.cgi?id=193294
+
+
+Reviewed by Simon Fraser.
+
+Input type elements should always paint tap highlight (ignore size heuristic). 
+
+* UIProcess/PageClient.h:
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebPageProxy.messages.in:
+* UIProcess/ios/PageClientImplIOS.h:
+* UIProcess/ios/PageClientImplIOS.mm:
+(WebKit::PageClientImpl::didGetTapHighlightGeometries):
+* UIProcess/ios/WKContentViewInteraction.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _showTapHighlight]):
+(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:nodeHasBuiltInClickHandling:]):
+(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]): Deleted.
+* UIProcess/ios/WebPageProxyIOS.mm:
+(WebKit::WebPageProxy::didGetTapHighlightGeometries):
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
+
 2019-01-10  

[webkit-changes] [239842] trunk/Source/WebCore

[wenson_hsieh]

Title: [239842] trunk/Source/WebCore








Revision 239842
Author wenson_hs...@apple.com
Date 2019-01-10 13:46:30 -0800 (Thu, 10 Jan 2019)


Log Message
Bindings generator emits incorrect code when using VoidCallback as an IDL dictionary attribute
https://bugs.webkit.org/show_bug.cgi?id=193328

Reviewed by Chris Dumez.

Currently, when generating the function body of `convertDictionary`, our bindings generator does not pass in an
argument to use as the `$globalObjectReference` in `JSValueToNative`, when generating code to convert a wrapped
attribute value to the native value. As a result, if the generated IDL type returns `true` from
`JSValueToNativeDOMConvertNeedsGlobalObject` (i.e. for callback function types), we will end up using the empty
string as the generated _expression_ for the global object. This emits syntactically incorrect code:

`convert>(state, someValue, );`

To fix this, we pass in a string to use as the global object, which uses the given ExecState to grab the global
object. Tested by augmenting TestStandaloneDictionary.idl and its generated expectation.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateDictionaryImplementationContent):
* bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:
(WebCore::convertDictionary):
* bindings/scripts/test/TestStandaloneDictionary.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp
trunk/Source/WebCore/bindings/scripts/test/TestStandaloneDictionary.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (239841 => 239842)

--- trunk/Source/WebCore/ChangeLog	2019-01-10 21:23:00 UTC (rev 239841)
+++ trunk/Source/WebCore/ChangeLog	2019-01-10 21:46:30 UTC (rev 239842)
@@ -1,3 +1,27 @@
+2019-01-10  Wenson Hsieh  
+
+Bindings generator emits incorrect code when using VoidCallback as an IDL dictionary attribute
+https://bugs.webkit.org/show_bug.cgi?id=193328
+
+Reviewed by Chris Dumez.
+
+Currently, when generating the function body of `convertDictionary`, our bindings generator does not pass in an
+argument to use as the `$globalObjectReference` in `JSValueToNative`, when generating code to convert a wrapped
+attribute value to the native value. As a result, if the generated IDL type returns `true` from
+`JSValueToNativeDOMConvertNeedsGlobalObject` (i.e. for callback function types), we will end up using the empty
+string as the generated _expression_ for the global object. This emits syntactically incorrect code:
+
+`convert>(state, someValue, );`
+
+To fix this, we pass in a string to use as the global object, which uses the given ExecState to grab the global
+object. Tested by augmenting TestStandaloneDictionary.idl and its generated expectation.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateDictionaryImplementationContent):
+* bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:
+(WebCore::convertDictionary):
+* bindings/scripts/test/TestStandaloneDictionary.idl:
+
 2019-01-10  Eric Carlson  
 
 Define page media state flags for display capture.


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (239841 => 239842)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2019-01-10 21:23:00 UTC (rev 239841)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2019-01-10 21:46:30 UTC (rev 239842)
@@ -2348,7 +2348,7 @@
 # 4.3. If value is not undefined, then:
 $result .= "if (!${key}Value.isUndefined()) {\n";
 
-my $nativeValue = JSValueToNative($typeScope, $member, "${key}Value", $member->extendedAttributes->{Conditional}, "", "state");
+my $nativeValue = JSValueToNative($typeScope, $member, "${key}Value", $member->extendedAttributes->{Conditional}, "", "state", "", "*jsCast(state.lexicalGlobalObject())");
 $result .= "result.$implementedAsKey = $nativeValue;\n";
 $result .= "RETURN_IF_EXCEPTION(throwScope, { });\n";
 


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp (239841 => 239842)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp	2019-01-10 21:23:00 UTC (rev 239841)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp	2019-01-10 21:46:30 UTC (rev 239842)
@@ -25,7 +25,10 @@
 #include "JSTestStandaloneDictionary.h"
 
 #include "JSDOMConvertBoolean.h"
+#include "JSDOMConvertCallbacks.h"
 #include "JSDOMConvertStrings.h"
+#include "JSDOMGlobalObject.h"
+#include "JSVoidCallback.h"
 #include <_javascript_Core/JSCInlines.h>
 #include <_javascript_Core/JSString.h>
 #include 
@@ -58,6 +61,17 @@
 result.boolMember = convert(state, boolMemberValue);
 RETURN_IF_EXCEPTION(throwScope, { });
 }
+JSValue callbackMemberValue;
+if 

[webkit-changes] [239841] trunk/Source/WebKit

[ap]

Title: [239841] trunk/Source/WebKit








Revision 239841
Author a...@apple.com
Date 2019-01-10 13:23:00 -0800 (Thu, 10 Jan 2019)


Log Message
Remove unneeded XPCService variant for plugin service
https://bugs.webkit.org/show_bug.cgi?id=193326

Reviewed by Tim Horton.

* Configurations/PluginService.32.xcconfig: Removed.
* Configurations/PluginService.64.xcconfig:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist: Removed.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.64.Info.plist: Copied from Source/WebKit/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist.
* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/PluginService.64.xcconfig
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit/PluginProcess/EntryPoint/mac/XPCService/PluginService.64.Info.plist


Removed Paths

trunk/Source/WebKit/Configurations/PluginService.32.xcconfig
trunk/Source/WebKit/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist




Diff

Modified: trunk/Source/WebKit/ChangeLog (239840 => 239841)

--- trunk/Source/WebKit/ChangeLog	2019-01-10 20:48:49 UTC (rev 239840)
+++ trunk/Source/WebKit/ChangeLog	2019-01-10 21:23:00 UTC (rev 239841)
@@ -1,3 +1,16 @@
+2019-01-10  Alexey Proskuryakov  
+
+Remove unneeded XPCService variant for plugin service
+https://bugs.webkit.org/show_bug.cgi?id=193326
+
+Reviewed by Tim Horton.
+
+* Configurations/PluginService.32.xcconfig: Removed.
+* Configurations/PluginService.64.xcconfig:
+* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist: Removed.
+* PluginProcess/EntryPoint/mac/XPCService/PluginService.64.Info.plist: Copied from Source/WebKit/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist.
+* WebKit.xcodeproj/project.pbxproj:
+
 2019-01-10  Eric Carlson  
 
 Define page media state flags for display capture.


Deleted: trunk/Source/WebKit/Configurations/PluginService.32.xcconfig (239840 => 239841)

--- trunk/Source/WebKit/Configurations/PluginService.32.xcconfig	2019-01-10 20:48:49 UTC (rev 239840)
+++ trunk/Source/WebKit/Configurations/PluginService.32.xcconfig	2019-01-10 21:23:00 UTC (rev 239841)
@@ -1,47 +0,0 @@
-// Copyright (C) 2013-2016 Apple Inc. All rights reserved.
-//
-// Redistribution and use in source and binary forms, with or without
-// modification, are permitted provided that the following conditions
-// are met:
-// 1. Redistributions of source code must retain the above copyright
-//notice, this list of conditions and the following disclaimer.
-// 2. Redistributions in binary form must reproduce the above copyright
-//notice, this list of conditions and the following disclaimer in the
-//documentation and/or other materials provided with the distribution.
-//
-// THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
-// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-// PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
-// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
-// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
-// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
-// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
-// OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
-
-#include "BaseXPCService.xcconfig"
-
-VALID_ARCHS_macosx_NO = $(VALID_ARCHS_BUILDING_ONLY_X86_64_$(WK_BUILDING_ONLY_X86_64));
-VALID_ARCHS_BUILDING_ONLY_X86_64_ = $(VALID_ARCHS_BUILDING_ONLY_X86_64_NO);
-VALID_ARCHS_BUILDING_ONLY_X86_64_NO = i386;
-VALID_ARCHS_BUILDING_ONLY_X86_64_YES = $(VALID_ARCHS);
-
-PRODUCT_NAME = com.apple.WebKit.Plugin.32;
-PRODUCT_BUNDLE_IDENTIFIER = $(PRODUCT_NAME);
-INFOPLIST_FILE = PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist;
-
-WK_APPKIT_LDFLAGS = $(WK_APPKIT_LDFLAGS_$(WK_PLATFORM_NAME));
-WK_APPKIT_LDFLAGS_macosx = -framework AppKit;
-
-OTHER_LDFLAGS = $(inherited) $(WK_APPKIT_LDFLAGS) $(OTHER_LDFLAGS_PLATFORM) $(OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH) $(WK_RELOCATABLE_FRAMEWORKS_LDFLAGS);
-OTHER_LDFLAGS_PLATFORM[sdk=macosx*] = $(BUILT_PRODUCTS_DIR)/PluginProcessShim.dylib;
-
-CODE_SIGN_ENTITLEMENTS = Configurations/PluginService.entitlements;
-
-SKIP_INSTALL = $(WK_BUILDING_ONLY_X86_64);
-SKIP_INSTALL[sdk=iphone*] = YES;
-
-WK_BUILDING_ONLY_X86_64 = $(WK_BUILDING_ONLY_X86_64_$(RC_ARCHS:identifier));
-WK_BUILDING_ONLY_X86_64_x86_64 = YES;


Modified: trunk/Source/WebKit/Configurations/PluginService.64.xcconfig (239840 => 239841)

--- trunk/Source/WebKit/Configurations/PluginService.64.xcconfig	2019-01-10 20:48:49 UTC 

[webkit-changes] [239840] trunk

[eric . carlson]

Title: [239840] trunk








Revision 239840
Author eric.carl...@apple.com
Date 2019-01-10 12:48:49 -0800 (Thu, 10 Jan 2019)


Log Message
Define page media state flags for display capture.
https://bugs.webkit.org/show_bug.cgi?id=193230


Reviewed by Youenn Fablet.

Source/WebCore:

Test: fast/mediastream/get-display-media-muted.html

* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::mediaState const):
* page/MediaProducer.h:
* platform/mediastream/RealtimeIncomingVideoSource.cpp:
(WebCore::RealtimeIncomingVideoSource::RealtimeIncomingVideoSource):
* platform/mediastream/RealtimeMediaSource.h:
* platform/mediastream/mac/AVVideoCaptureSource.h:
* platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h:
* platform/mediastream/mac/WindowDisplayCaptureSourceMac.h:
* platform/mock/MockRealtimeAudioSource.h:
* platform/mock/MockRealtimeVideoSource.h:
* testing/Internals.cpp:
(WebCore::Internals::pageMediaState):

Source/WebKit:

* UIProcess/API/C/WKPage.cpp:
(WKPageGetMediaState):
* UIProcess/API/C/WKPagePrivate.h:
* WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::Source::Source):
(WebKit::UserMediaCaptureManager::createCaptureSource):

LayoutTests:

* fast/mediastream/get-display-media-muted-expected.txt: Added.
* fast/mediastream/get-display-media-muted.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
trunk/Source/WebCore/page/MediaProducer.h
trunk/Source/WebCore/platform/mediastream/CaptureDevice.h
trunk/Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.cpp
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h
trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h
trunk/Source/WebCore/platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp
trunk/Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp
trunk/Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h
trunk/Source/WebCore/platform/mediastream/mac/WindowDisplayCaptureSourceMac.h
trunk/Source/WebCore/platform/mock/MockRealtimeAudioSource.h
trunk/Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp
trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit/UIProcess/API/C/WKPagePrivate.h
trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp
trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp


Added Paths

trunk/LayoutTests/fast/mediastream/get-display-media-muted-expected.txt
trunk/LayoutTests/fast/mediastream/get-display-media-muted.html




Diff

Modified: trunk/LayoutTests/ChangeLog (239839 => 239840)

--- trunk/LayoutTests/ChangeLog	2019-01-10 20:22:32 UTC (rev 239839)
+++ trunk/LayoutTests/ChangeLog	2019-01-10 20:48:49 UTC (rev 239840)
@@ -1,3 +1,14 @@
+2019-01-10  Eric Carlson  
+
+Define page media state flags for display capture.
+https://bugs.webkit.org/show_bug.cgi?id=193230
+
+
+Reviewed by Youenn Fablet.
+
+* fast/mediastream/get-display-media-muted-expected.txt: Added.
+* fast/mediastream/get-display-media-muted.html: Added.
+
 2019-01-10  Commit Queue  
 
 Unreviewed, rolling out r239825.


Added: trunk/LayoutTests/fast/mediastream/get-display-media-muted-expected.txt (0 => 239840)

--- trunk/LayoutTests/fast/mediastream/get-display-media-muted-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/mediastream/get-display-media-muted-expected.txt	2019-01-10 20:48:49 UTC (rev 239840)
@@ -0,0 +1,3 @@
+
+PASS Mute video track during screen capture 
+


Added: trunk/LayoutTests/fast/mediastream/get-display-media-muted.html (0 => 239840)

--- trunk/LayoutTests/fast/mediastream/get-display-media-muted.html	(rev 0)
+++ trunk/LayoutTests/fast/mediastream/get-display-media-muted.html	2019-01-10 20:48:49 UTC (rev 239840)
@@ -0,0 +1,74 @@
+
+
+
+
+Mute screen capture, make sure page state updates correctly.
+
+
+if (window.testRunner)
+testRunner.setUserMediaPermission(true);
+
+async function waitForPageStateChange(numberOfTries, originalState)
+{
+return new Promise(async (resolve) => {
+while (numberOfTries) {
+if (internals.pageMediaState() != originalState) {
+resolve(true);
+return;
+}
+
+await new Promise(resolve => { setTimeout(resolve, 10) });
+--numberOfTries;
+}
+
+resolve(false);
+});
+}
+
+promise_test(async (test) => {
+await new Promise(async (resolve, reject) => {
+let stream = await navigator.mediaDevices.getDisplayMedia({ video: true });
+let pageMediaState = internals.pageMediaState();
+
+ 

[webkit-changes] [239839] trunk/Source/JavaScriptCore

[bburg]

Title: [239839] trunk/Source/_javascript_Core








Revision 239839
Author bb...@apple.com
Date 2019-01-10 12:22:32 -0800 (Thu, 10 Jan 2019)


Log Message
Rebaseline inspector generator test results after recent changes.

Unreviewed test gardening.

* inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
* inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
* inspector/scripts/tests/generic/expected/fail-on-domain-availability-value.json-error:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/fail-on-domain-availability-value.json-error




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (239838 => 239839)

--- trunk/Source/_javascript_Core/ChangeLog	2019-01-10 20:04:32 UTC (rev 239838)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-01-10 20:22:32 UTC (rev 239839)
@@ -1,3 +1,13 @@
+2019-01-10  Brian Burg  
+
+Rebaseline inspector generator test results after recent changes.
+
+Unreviewed test gardening.
+
+* inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
+* inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
+* inspector/scripts/tests/generic/expected/fail-on-domain-availability-value.json-error:
+
 2019-01-10  Commit Queue  
 
 Unreviewed, rolling out r239825.


Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result (239838 => 239839)

--- trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result	2019-01-10 20:04:32 UTC (rev 239838)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result	2019-01-10 20:22:32 UTC (rev 239839)
@@ -309,23 +309,23 @@
 if (!error.length()) {
 if (out_columnNames)
 result->setArray("columnNames"_s, out_columnNames);
-if (out_notes.has_value())
+if (out_notes.hasValue())
 result->setString("notes"_s, *out_notes);
-if (out_timestamp.has_value())
+if (out_timestamp.hasValue())
 result->setDouble("timestamp"_s, *out_timestamp);
-if (out_values.has_value())
+if (out_values.hasValue())
 result->setObject("values"_s, *out_values);
-if (out_payload.has_value())
+if (out_payload.hasValue())
 result->setValue("payload"_s, *out_payload);
-if (out_databaseId.has_value())
+if (out_databaseId.hasValue())
 result->setInteger("databaseId"_s, *out_databaseId);
 if (out_sqlError)
 result->setObject("sqlError"_s, out_sqlError);
-if (out_screenColor.has_value())
+if (out_screenColor.hasValue())
 result->setString("screenColor"_s, *out_screenColor);
 if (out_alternateColors)
 result->setArray("alternateColors"_s, out_alternateColors);
-if (out_printColor.has_value())
+if (out_printColor.hasValue())
 result->setString("printColor"_s, *out_printColor);
 }
 if (!error.length())
@@ -341,23 +341,23 @@
 Ref jsonMessage = JSON::Object::create();
 if (columnNames)
 jsonMessage->setArray("columnNames"_s, columnNames);
-if (notes.has_value())
+if (notes.hasValue())
 jsonMessage->setString("notes"_s, *notes);
-if (timestamp.has_value())
+if (timestamp.hasValue())
 jsonMessage->setDouble("timestamp"_s, *timestamp);
-if (values.has_value())
+if (values.hasValue())
 jsonMessage->setObject("values"_s, *values);
-if (payload.has_value())
+if (payload.hasValue())
 jsonMessage->setValue("payload"_s, *payload);
-if (databaseId.has_value())
+if (databaseId.hasValue())
 jsonMessage->setInteger("databaseId"_s, *databaseId);
 if (sqlError)
 jsonMessage->setObject("sqlError"_s, sqlError);
-if (screenColor.has_value())
+if (screenColor.hasValue())
 jsonMessage->setString("screenColor"_s, *screenColor);
 if (alternateColors)
 jsonMessage->setArray("alternateColors"_s, alternateColors);
-if (printColor.has_value())
+if (printColor.hasValue())
 jsonMessage->setString("printColor"_s, *printColor);
 CallbackBase::sendSuccess(WTFMove(jsonMessage));
 }


Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result (239838 => 239839)

--- 

[webkit-changes] [239838] trunk

[commit-queue]

Title: [239838] trunk








Revision 239838
Author commit-qu...@webkit.org
Date 2019-01-10 12:04:32 -0800 (Thu, 10 Jan 2019)


Log Message
Unreviewed, rolling out r239825.
https://bugs.webkit.org/show_bug.cgi?id=193330

Broke tests on armv7/linux bots (Requested by guijemont on
#webkit).

Reverted changeset:

"Enable DFG on ARM/Linux again"
https://bugs.webkit.org/show_bug.cgi?id=192496
https://trac.webkit.org/changeset/239825

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/regress-192717.js
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/script-tests/dfg-float32array.js
trunk/LayoutTests/js/script-tests/dfg-float64array.js
trunk/LayoutTests/js/script-tests/dfg-int16array.js
trunk/LayoutTests/js/script-tests/dfg-int32array-overflow-values.js
trunk/LayoutTests/js/script-tests/dfg-int32array.js
trunk/LayoutTests/js/script-tests/dfg-int8array.js
trunk/LayoutTests/js/script-tests/dfg-uint16array.js
trunk/LayoutTests/js/script-tests/dfg-uint32array.js
trunk/LayoutTests/js/script-tests/dfg-uint8array.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h
trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp
trunk/Source/_javascript_Core/jit/CallFrameShuffler.cpp
trunk/Source/_javascript_Core/jit/GPRInfo.h
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
trunk/Source/_javascript_Core/offlineasm/arm.rb
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests




Diff

Modified: trunk/JSTests/ChangeLog (239837 => 239838)

--- trunk/JSTests/ChangeLog	2019-01-10 19:59:15 UTC (rev 239837)
+++ trunk/JSTests/ChangeLog	2019-01-10 20:04:32 UTC (rev 239838)
@@ -1,3 +1,17 @@
+2019-01-10  Commit Queue  
+
+Unreviewed, rolling out r239825.
+https://bugs.webkit.org/show_bug.cgi?id=193330
+
+Broke tests on armv7/linux bots (Requested by guijemont on
+#webkit).
+
+Reverted changeset:
+
+"Enable DFG on ARM/Linux again"
+https://bugs.webkit.org/show_bug.cgi?id=192496
+https://trac.webkit.org/changeset/239825
+
 2019-01-10  Dominik Infuehr  
 
 Enable DFG on ARM/Linux again


Modified: trunk/JSTests/stress/regress-192717.js (239837 => 239838)

--- trunk/JSTests/stress/regress-192717.js	2019-01-10 19:59:15 UTC (rev 239837)
+++ trunk/JSTests/stress/regress-192717.js	2019-01-10 20:04:32 UTC (rev 239838)
@@ -1,5 +1,5 @@
+//@ runDefault("--useLLInt=false", "--forceCodeBlockToJettisonDueToOldAge=true", "--maxPerThreadStackUsage=20", "--exceptionStackTraceLimit=1", "--defaultErrorStackTraceLimit=1")
 //@ skip if $memoryLimited or $buildType == "debug"
-//@ runDefault("--useLLInt=false", "--forceCodeBlockToJettisonDueToOldAge=true", "--maxPerThreadStackUsage=20", "--exceptionStackTraceLimit=1", "--defaultErrorStackTraceLimit=1")
 
 let foo = 'let a';
 for (let i = 0; i < 40; i++)


Modified: trunk/LayoutTests/ChangeLog (239837 => 239838)

--- trunk/LayoutTests/ChangeLog	2019-01-10 19:59:15 UTC (rev 239837)
+++ trunk/LayoutTests/ChangeLog	2019-01-10 20:04:32 UTC (rev 239838)
@@ -1,3 +1,17 @@
+2019-01-10  Commit Queue  
+
+Unreviewed, rolling out r239825.
+https://bugs.webkit.org/show_bug.cgi?id=193330
+
+Broke tests on armv7/linux bots (Requested by guijemont on
+#webkit).
+
+Reverted changeset:
+
+"Enable DFG on ARM/Linux again"
+https://bugs.webkit.org/show_bug.cgi?id=192496
+https://trac.webkit.org/changeset/239825
+
 2019-01-10  Justin Fan  
 
 [WebGPU] Fix vertex-buffer-triangle-strip test and small update to GPURenderPipeline


Modified: trunk/LayoutTests/js/script-tests/dfg-float32array.js (239837 => 239838)

--- trunk/LayoutTests/js/script-tests/dfg-float32array.js	2019-01-10 19:59:15 UTC (rev 239837)
+++ trunk/LayoutTests/js/script-tests/dfg-float32array.js	2019-01-10 20:04:32 UTC (rev 239838)
@@ -1,4 +1,4 @@
-//@ noNoLLIntRunLayoutTest if $architecture == "arm"
+//@ noNoLLIntRunLayoutTest if $architecture == "arm" and $hostOS == "darwin"
 
 description(
 "This tests that float32 arrays work in the DFG."


Modified: trunk/LayoutTests/js/script-tests/dfg-float64array.js (239837 => 239838)

--- trunk/LayoutTests/js/script-tests/dfg-float64array.js	2019-01-10 19:59:15 UTC (rev 239837)
+++ trunk/LayoutTests/js/script-tests/dfg-float64array.js	2019-01-10 20:04:32 UTC (rev 239838)
@@ -1,4 +1,4 @@
-//@ noNoLLIntRunLayoutTest if $architecture == "arm"
+//@ noNoLLIntRunLayoutTest if $architecture == "arm" and $hostOS == "darwin"
 
 description(
 "This tests that float64 arrays work in the DFG."


Modified: trunk/LayoutTests/js/script-tests/dfg-int16array.js (239837 => 239838)

--- trunk/LayoutTests/js/script-tests/dfg-int16array.js	2019-01-10 19:59:15 UTC (rev 239837)
+++ trunk/LayoutTests/js/script-tests/dfg-int16array.js	2019-01-10 20:04:32 UTC (rev 239838)
@@ -1,4 +1,4 @@
-//@ noNoLLIntRunLayoutTest if $architecture == "arm"
+//@ 

[webkit-changes] [239837] trunk

[justin_fan]

Title: [239837] trunk








Revision 239837
Author justin_...@apple.com
Date 2019-01-10 11:59:15 -0800 (Thu, 10 Jan 2019)


Log Message
Source/WebCore:
[WebGPU] Add BindGroupBinding, BindGroupDescriptor, and BufferBinding dictionaries from API
https://bugs.webkit.org/show_bug.cgi?id=193298

Reviewed by Dean Jackson.

No new tests. No change in behavior.

* CMakeLists.txt:
* DerivedSources.make:
* Modules/webgpu/WebGPUBindGroupBinding.h: Added.
* Modules/webgpu/WebGPUBindGroupBinding.idl: Added.
* Modules/webgpu/WebGPUBindGroupDescriptor.h: Added.
* Modules/webgpu/WebGPUBindGroupDescriptor.idl: Added.
* Modules/webgpu/WebGPUBufferBinding.h: Added.
* Modules/webgpu/WebGPUBufferBinding.idl: Added.
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/gpu/GPUBindGroupBinding.h: Added.
* platform/graphics/gpu/GPUBindGroupDescriptor.h: Added.
* platform/graphics/gpu/GPUBufferBinding.h: Added.

LayoutTests:
[WebGPU] Fix vertex-buffer-triangle-strip test and small update to GPURenderPipeline
https://bugs.webkit.org/show_bug.cgi?id=193289

Reviewed by Dean Jackson.

Fix broken test after pipeline layouts were added.

* webgpu/js/webgpu-functions.js:
(createBasicPipeline): Ensure pipeline layout is actually optional.
* webgpu/vertex-buffer-triangle-strip.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebCore/Modules/webgpu/WebGPUBindGroupBinding.h
trunk/Source/WebCore/Modules/webgpu/WebGPUBindGroupBinding.idl
trunk/Source/WebCore/Modules/webgpu/WebGPUBindGroupDescriptor.h
trunk/Source/WebCore/Modules/webgpu/WebGPUBindGroupDescriptor.idl
trunk/Source/WebCore/Modules/webgpu/WebGPUBufferBinding.h
trunk/Source/WebCore/Modules/webgpu/WebGPUBufferBinding.idl
trunk/Source/WebCore/platform/graphics/gpu/GPUBindGroupBinding.h
trunk/Source/WebCore/platform/graphics/gpu/GPUBindGroupDescriptor.h
trunk/Source/WebCore/platform/graphics/gpu/GPUBufferBinding.h




Diff

Modified: trunk/LayoutTests/ChangeLog (239836 => 239837)

--- trunk/LayoutTests/ChangeLog	2019-01-10 19:36:25 UTC (rev 239836)
+++ trunk/LayoutTests/ChangeLog	2019-01-10 19:59:15 UTC (rev 239837)
@@ -1,3 +1,16 @@
+2019-01-10  Justin Fan  
+
+[WebGPU] Fix vertex-buffer-triangle-strip test and small update to GPURenderPipeline
+https://bugs.webkit.org/show_bug.cgi?id=193289
+
+Reviewed by Dean Jackson.
+
+Fix broken test after pipeline layouts were added.
+
+* webgpu/js/webgpu-functions.js: 
+(createBasicPipeline): Ensure pipeline layout is actually optional.
+* webgpu/vertex-buffer-triangle-strip.html: 
+
 2019-01-10  John Wilander  
 
 Override the session configuration for cookieAcceptPolicy


Modified: trunk/Source/WebCore/CMakeLists.txt (239836 => 239837)

--- trunk/Source/WebCore/CMakeLists.txt	2019-01-10 19:36:25 UTC (rev 239836)
+++ trunk/Source/WebCore/CMakeLists.txt	2019-01-10 19:59:15 UTC (rev 239837)
@@ -464,10 +464,13 @@
 Modules/webgpu/WebGPU.idl
 Modules/webgpu/WebGPUAdapter.idl
 Modules/webgpu/WebGPUAdapterDescriptor.idl
+Modules/webgpu/WebGPUBindGroupBinding.idl
+Modules/webgpu/WebGPUBindGroupDescriptor.idl
 Modules/webgpu/WebGPUBindGroupLayout.idl
 Modules/webgpu/WebGPUBindGroupLayoutBinding.idl
 Modules/webgpu/WebGPUBindGroupLayoutDescriptor.idl
 Modules/webgpu/WebGPUBuffer.idl
+Modules/webgpu/WebGPUBufferBinding.idl
 Modules/webgpu/WebGPUBufferDescriptor.idl
 Modules/webgpu/WebGPUBufferUsage.idl
 Modules/webgpu/WebGPUColor.idl


Modified: trunk/Source/WebCore/ChangeLog (239836 => 239837)

--- trunk/Source/WebCore/ChangeLog	2019-01-10 19:36:25 UTC (rev 239836)
+++ trunk/Source/WebCore/ChangeLog	2019-01-10 19:59:15 UTC (rev 239837)
@@ -1,3 +1,41 @@
+2019-01-10  Justin Fan  
+
+[WebGPU] Add BindGroupBinding, BindGroupDescriptor, and BufferBinding dictionaries from API
+https://bugs.webkit.org/show_bug.cgi?id=193298
+
+Reviewed by Dean Jackson.
+
+No new tests. No change in behavior.
+
+* CMakeLists.txt:
+* DerivedSources.make:
+* Modules/webgpu/WebGPUBindGroupBinding.h: Added.
+* Modules/webgpu/WebGPUBindGroupBinding.idl: Added.
+* Modules/webgpu/WebGPUBindGroupDescriptor.h: Added.
+* Modules/webgpu/WebGPUBindGroupDescriptor.idl: Added.
+* Modules/webgpu/WebGPUBufferBinding.h: Added.
+* Modules/webgpu/WebGPUBufferBinding.idl: Added.
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* platform/graphics/gpu/GPUBindGroupBinding.h: Added.
+* platform/graphics/gpu/GPUBindGroupDescriptor.h: Added.
+* platform/graphics/gpu/GPUBufferBinding.h: Added.
+
+2019-01-09  Justin Fan  
+
+[WebGPU] Fix vertex-buffer-triangle-strip test and small update to 

[webkit-changes] [239836] trunk/Tools

[commit-queue]

Title: [239836] trunk/Tools








Revision 239836
Author commit-qu...@webkit.org
Date 2019-01-10 11:36:25 -0800 (Thu, 10 Jan 2019)


Log Message
Disable the run-jsc-stress-test remote host key check.
https://bugs.webkit.org/show_bug.cgi?id=192988

Patch by Zhifei Fang  on 2019-01-10
Reviewed by Alexey Proskuryakov.

* Scripts/run-jsc-stress-tests:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests




Diff

Modified: trunk/Tools/ChangeLog (239835 => 239836)

--- trunk/Tools/ChangeLog	2019-01-10 19:11:33 UTC (rev 239835)
+++ trunk/Tools/ChangeLog	2019-01-10 19:36:25 UTC (rev 239836)
@@ -1,3 +1,12 @@
+2019-01-10  Zhifei Fang  
+
+Disable the run-jsc-stress-test remote host key check.
+https://bugs.webkit.org/show_bug.cgi?id=192988
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/run-jsc-stress-tests:
+
 2019-01-10  John Wilander  
 
 Override the session configuration for cookieAcceptPolicy


Modified: trunk/Tools/Scripts/run-jsc-stress-tests (239835 => 239836)

--- trunk/Tools/Scripts/run-jsc-stress-tests	2019-01-10 19:11:33 UTC (rev 239835)
+++ trunk/Tools/Scripts/run-jsc-stress-tests	2019-01-10 19:36:25 UTC (rev 239836)
@@ -1791,7 +1791,7 @@
 remoteHost = $remoteHosts[remoteIndex]
 
 result = ""
-IO.popen("ssh -p #{remoteHost.port} #{remoteHost.user}@#{remoteHost.host} '#{cmd}'", "r") {
+IO.popen("ssh -o NoHostAuthenticationForLocalhost=yes -p #{remoteHost.port} #{remoteHost.user}@#{remoteHost.host} '#{cmd}'", "r") {
   | inp |
   inp.each_line {
 | line |
@@ -1908,8 +1908,8 @@
 if !remoteHost.remoteDirectory
 remoteHost.remoteDirectory = JSON::parse(sshRead("cat ~/.bencher", remoteIndex))["tempPath"]
 end
-mysys("ssh", "-p", remoteHost.port.to_s, "#{remoteHost.user}@#{remoteHost.host}", "mkdir -p #{remoteHost.remoteDirectory}")
-mysys("scp", "-P", remoteHost.port.to_s, ($outputDir.dirname + $tarFileName).to_s, "#{remoteHost.user}@#{remoteHost.host}:#{remoteHost.remoteDirectory}")
+mysys("ssh", "-o", "NoHostAuthenticationForLocalhost=yes", "-p", remoteHost.port.to_s, "#{remoteHost.user}@#{remoteHost.host}", "mkdir -p #{remoteHost.remoteDirectory}")
+mysys("scp", "-o", "NoHostAuthenticationForLocalhost=yes", "-P", remoteHost.port.to_s, ($outputDir.dirname + $tarFileName).to_s, "#{remoteHost.user}@#{remoteHost.host}:#{remoteHost.remoteDirectory}")
 remoteScript = "\""
 remoteScript += "cd #{remoteHost.remoteDirectory} && "
 remoteScript += "rm -rf #{$outputDir.basename} && "






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239835] trunk/Source/WebKit

[commit-queue]

Title: [239835] trunk/Source/WebKit








Revision 239835
Author commit-qu...@webkit.org
Date 2019-01-10 11:11:33 -0800 (Thu, 10 Jan 2019)


Log Message
REGRESSION(r239815) http/tests/workers/service/serviceworker-private-browsing.https.html test times out
https://bugs.webkit.org/show_bug.cgi?id=193325

Patch by Alex Christensen  on 2019-01-10
Reviewed by Joseph Pecoraro.

InjectedBundle::setPrivateBrowsingEnabled effectively didn't do anything when enabled was false.
I made it destroy the legacy private browsing session in the NetworkProcess, which caused a test to time out.
This functionality is only used for testing, so it's no big deal to revert that part of the patch.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::destroyLegacyPrivateBrowsingSession): Deleted.
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::destroyLegacyPrivateBrowsingSessionInNetworkProcess): Deleted.
* WebProcess/WebProcess.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKit/WebProcess/WebProcess.cpp
trunk/Source/WebKit/WebProcess/WebProcess.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (239834 => 239835)

--- trunk/Source/WebKit/ChangeLog	2019-01-10 18:47:39 UTC (rev 239834)
+++ trunk/Source/WebKit/ChangeLog	2019-01-10 19:11:33 UTC (rev 239835)
@@ -1,3 +1,24 @@
+2019-01-10  Alex Christensen  
+
+REGRESSION(r239815) http/tests/workers/service/serviceworker-private-browsing.https.html test times out
+https://bugs.webkit.org/show_bug.cgi?id=193325
+
+Reviewed by Joseph Pecoraro.
+
+InjectedBundle::setPrivateBrowsingEnabled effectively didn't do anything when enabled was false.
+I made it destroy the legacy private browsing session in the NetworkProcess, which caused a test to time out.
+This functionality is only used for testing, so it's no big deal to revert that part of the patch.
+
+* NetworkProcess/NetworkConnectionToWebProcess.cpp:
+(WebKit::NetworkConnectionToWebProcess::destroyLegacyPrivateBrowsingSession): Deleted.
+* NetworkProcess/NetworkConnectionToWebProcess.h:
+* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
+* WebProcess/InjectedBundle/InjectedBundle.cpp:
+(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::destroyLegacyPrivateBrowsingSessionInNetworkProcess): Deleted.
+* WebProcess/WebProcess.h:
+
 2019-01-10  Per Arne Vollan  
 
 [macOS] Add name of IORegistry key in sandbox.


Modified: trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp (239834 => 239835)

--- trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp	2019-01-10 18:47:39 UTC (rev 239834)
+++ trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp	2019-01-10 19:11:33 UTC (rev 239835)
@@ -554,11 +554,6 @@
 m_networkProcess->addWebsiteDataStore(WebsiteDataStoreParameters::legacyPrivateSessionParameters());
 }
 
-void NetworkConnectionToWebProcess::destroyLegacyPrivateBrowsingSession()
-{
-m_networkProcess->destroySession(PAL::SessionID::legacyPrivateSessionID());
-}
-
 void NetworkConnectionToWebProcess::removeStorageAccessForFrame(PAL::SessionID sessionID, uint64_t frameID, uint64_t pageID)
 {
 #if ENABLE(RESOURCE_LOAD_STATISTICS)


Modified: trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h (239834 => 239835)

--- trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h	2019-01-10 18:47:39 UTC (rev 239834)
+++ trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h	2019-01-10 19:11:33 UTC (rev 239835)
@@ -171,7 +171,6 @@
 void destroySocketStream(uint64_t);
 
 void ensureLegacyPrivateBrowsingSession();
-void destroyLegacyPrivateBrowsingSession();
 
 #if ENABLE(INDEXED_DATABASE)
 // Messages handlers (Modern IDB).


Modified: trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in (239834 => 239835)

--- trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in	2019-01-10 18:47:39 UTC (rev 239834)
+++ trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in	2019-01-10 19:11:33 UTC (rev 239835)
@@ -55,7 +55,6 @@
 CreateSocketStream(URL url, PAL::SessionID sessionID, String cachePartition, uint64_t identifier)
 
 EnsureLegacyPrivateBrowsingSession()
-DestroyLegacyPrivateBrowsingSession()
 
 RemoveStorageAccessForFrame(PAL::SessionID 

[webkit-changes] [239834] trunk/Source/WebKit

[pvollan]

Title: [239834] trunk/Source/WebKit








Revision 239834
Author pvol...@apple.com
Date 2019-01-10 10:47:39 -0800 (Thu, 10 Jan 2019)


Log Message
[macOS] Add name of IORegistry key in sandbox.
https://bugs.webkit.org/show_bug.cgi?id=193324

Reviewed by Brent Fulgham.

IOGVAVTCapabilities key has been changed to IOGVAHEVCDecodeCapabilities.

* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (239833 => 239834)

--- trunk/Source/WebKit/ChangeLog	2019-01-10 18:08:23 UTC (rev 239833)
+++ trunk/Source/WebKit/ChangeLog	2019-01-10 18:47:39 UTC (rev 239834)
@@ -1,3 +1,14 @@
+2019-01-10  Per Arne Vollan  
+
+[macOS] Add name of IORegistry key in sandbox.
+https://bugs.webkit.org/show_bug.cgi?id=193324
+
+Reviewed by Brent Fulgham.
+
+IOGVAVTCapabilities key has been changed to IOGVAHEVCDecodeCapabilities.
+
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2019-01-10  John Wilander  
 
 Override the session configuration for cookieAcceptPolicy


Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (239833 => 239834)

--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-01-10 18:08:23 UTC (rev 239833)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-01-10 18:47:39 UTC (rev 239834)
@@ -248,7 +248,7 @@
 (iokit-property "IOFramebufferOpenGLIndex")
 (iokit-property "IOGeneralInterest")
 (iokit-property "IOGLBundleName")
-(iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|VTCapabilities)")
+(iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|VTCapabilities|HEVCDecodeCapabilities)")
 (iokit-property-regex #"^IOGVA(.*)(De|En)code$")
 (iokit-property "IOHibernateState")
 (iokit-property "IOI2CTransactionTypes")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239833] trunk/Source/WebCore

[dino]

Title: [239833] trunk/Source/WebCore








Revision 239833
Author d...@apple.com
Date 2019-01-10 10:08:23 -0800 (Thu, 10 Jan 2019)


Log Message
Safari Crashing in Version 12.0.1 (14606.2.104.1.1) WebCore::GraphicsLayerCA::updateBackdropFilters
https://bugs.webkit.org/show_bug.cgi?id=193309


Reviewed by Antoine Quint.

A speculative fix for a CheckedArithmetic crash triggered in updateBackdropFilters.

The crash log indicates we crash in a Checked<> class that is not recording
overflow i.e. it is crashing due to an overflow. The only place in this function
where that could happen is when we convert the FloatRect for the backdrop
region into a Checked for width and height. This suggests that either
the width or height are negative, or the float values are too large for integers,
or the product of the two overflows.

Avoid this by using RecordOverflow, but also changing the code a little to
bail if the rectangle is incorrect.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateBackdropFilters):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (239832 => 239833)

--- trunk/Source/WebCore/ChangeLog	2019-01-10 17:57:22 UTC (rev 239832)
+++ trunk/Source/WebCore/ChangeLog	2019-01-10 18:08:23 UTC (rev 239833)
@@ -1,3 +1,26 @@
+2019-01-09  Dean Jackson  
+
+Safari Crashing in Version 12.0.1 (14606.2.104.1.1) WebCore::GraphicsLayerCA::updateBackdropFilters
+https://bugs.webkit.org/show_bug.cgi?id=193309
+
+
+Reviewed by Antoine Quint.
+
+A speculative fix for a CheckedArithmetic crash triggered in updateBackdropFilters.
+
+The crash log indicates we crash in a Checked<> class that is not recording
+overflow i.e. it is crashing due to an overflow. The only place in this function
+where that could happen is when we convert the FloatRect for the backdrop
+region into a Checked for width and height. This suggests that either
+the width or height are negative, or the float values are too large for integers,
+or the product of the two overflows.
+
+Avoid this by using RecordOverflow, but also changing the code a little to
+bail if the rectangle is incorrect.
+
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::updateBackdropFilters):
+
 2019-01-10  Oriol Brufau  
 
 [css-grid] Let abspos items reference implicit grid lines


Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (239832 => 239833)

--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2019-01-10 17:57:22 UTC (rev 239832)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2019-01-10 18:08:23 UTC (rev 239833)
@@ -2147,18 +2147,22 @@
 
 void GraphicsLayerCA::updateBackdropFilters(CommitState& commitState)
 {
+using CheckedUnsigned = Checked;
+
 bool canHaveBackdropFilters = needsBackdrop();
 
 if (canHaveBackdropFilters) {
-Checked backdropFilterArea = Checked(static_cast(m_backdropFiltersRect.rect().width())) * Checked(static_cast(m_backdropFiltersRect.rect().height()));
-if (backdropFilterArea.hasOverflowed())
-canHaveBackdropFilters = false;
-else {
-Checked newTotalBackdropFilterArea = Checked(commitState.totalBackdropFilterArea) + backdropFilterArea;
-if (newTotalBackdropFilterArea.hasOverflowed() || newTotalBackdropFilterArea.unsafeGet() > cMaxTotalBackdropFilterArea)
-canHaveBackdropFilters = false;
-else
-commitState.totalBackdropFilterArea = newTotalBackdropFilterArea.unsafeGet();
+canHaveBackdropFilters = false;
+IntRect backdropFilterRect = enclosingIntRect(m_backdropFiltersRect.rect());
+if (backdropFilterRect.width() > 0 && backdropFilterRect.height() > 0) {
+CheckedUnsigned backdropFilterArea = CheckedUnsigned(backdropFilterRect.width()) * CheckedUnsigned(backdropFilterRect.height());
+if (!backdropFilterArea.hasOverflowed()) {
+CheckedUnsigned newTotalBackdropFilterArea = CheckedUnsigned(commitState.totalBackdropFilterArea) + backdropFilterArea;
+if (!newTotalBackdropFilterArea.hasOverflowed() && newTotalBackdropFilterArea.unsafeGet() <= cMaxTotalBackdropFilterArea) {
+commitState.totalBackdropFilterArea = newTotalBackdropFilterArea.unsafeGet();
+canHaveBackdropFilters = true;
+}
+}
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239832] trunk

[ryanhaddad]

Title: [239832] trunk








Revision 239832
Author ryanhad...@apple.com
Date 2019-01-10 09:57:22 -0800 (Thu, 10 Jan 2019)


Log Message
Override the session configuration for cookieAcceptPolicy
https://bugs.webkit.org/show_bug.cgi?id=190925


Patch by John Wilander  on 2019-01-10
Reviewed by Alexey Proskuryakov and Alex Christensen.

Source/WebCore/PAL:

* pal/spi/cf/CFNetworkSPI.h:
Declaration of _overrideSessionCookieAcceptPolicy on NSHTTPCookieStorage.

Source/WebKit:

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
Now sets cookieStorage._overrideSessionCookieAcceptPolicy to YES.

Source/WTF:

* wtf/Platform.h:
Definition of HAVE_CFNETWORK_OVERRIDE_SESSION_COOKIE_ACCEPT_POLICY.

Tools:

Test infrastructure for setting a first-party-only cookie policy.

* DumpRenderTree/TestRunner.cpp:
(setOnlyAcceptFirstPartyCookiesCallback):
(TestRunner::staticFunctions):
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setOnlyAcceptFirstPartyCookies):
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::setOnlyAcceptFirstPartyCookies):
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

* TestExpectations:
Skipped since this cookie policy is only supported on Cocoa platforms.
* http/tests/cookies/only-accept-first-party-cookies-expected.txt: Added.
* http/tests/cookies/only-accept-first-party-cookies.html: Added.
* http/tests/cookies/resources/reset-cookies.html: Added.
To support reset of third-party cookies in an iframe.
* http/tests/cookies/resources/set-cookie-and-redirect-back.php: Added.
A simple bounce to set a cookie.
* platform/ios/TestExpectations:
Skipped for now. Will be fixed in .
* platform/mac/TestExpectations:
Skipped for now. Will be fixed in .

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/TestRunner.cpp
trunk/Tools/DumpRenderTree/TestRunner.h
trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm
trunk/Tools/DumpRenderTree/win/TestRunnerWin.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
trunk/Tools/WebKitTestRunner/TestInvocation.cpp


Added Paths

trunk/LayoutTests/http/tests/cookies/only-accept-first-party-cookies-expected.txt
trunk/LayoutTests/http/tests/cookies/only-accept-first-party-cookies.html
trunk/LayoutTests/http/tests/cookies/resources/reset-cookies.html
trunk/LayoutTests/http/tests/cookies/resources/set-cookie-and-redirect-back.php




Diff

Modified: trunk/LayoutTests/ChangeLog (239831 => 239832)

--- trunk/LayoutTests/ChangeLog	2019-01-10 17:32:24 UTC (rev 239831)
+++ trunk/LayoutTests/ChangeLog	2019-01-10 17:57:22 UTC (rev 239832)
@@ -1,3 +1,24 @@
+2019-01-10  John Wilander  
+
+Override the session configuration for cookieAcceptPolicy
+https://bugs.webkit.org/show_bug.cgi?id=190925
+
+
+Reviewed by Alexey Proskuryakov and Alex Christensen.
+
+* TestExpectations:
+Skipped since this cookie policy is only supported on Cocoa platforms.
+* http/tests/cookies/only-accept-first-party-cookies-expected.txt: Added.
+* http/tests/cookies/only-accept-first-party-cookies.html: Added.
+* http/tests/cookies/resources/reset-cookies.html: Added.
+To support reset of third-party cookies in an iframe.
+* http/tests/cookies/resources/set-cookie-and-redirect-back.php: Added.
+A simple bounce to set a cookie.
+* platform/ios/TestExpectations:
+Skipped for now. Will be fixed in .
+* platform/mac/TestExpectations:
+Skipped for now. Will be fixed in .
+
 2019-01-10  Miguel Gomez  
 
 Unreviewed GTK+ gardening after r239824.


Modified: trunk/LayoutTests/TestExpectations (239831 => 239832)

--- trunk/LayoutTests/TestExpectations	2019-01-10 17:32:24 UTC (rev 239831)
+++ trunk/LayoutTests/TestExpectations	2019-01-10 17:57:22 UTC (rev 239832)
@@ -1990,6 +1990,9 @@
 webkit.org/b/3652 http/tests/misc/link-rel-prefetch-and-subresource.html [ Skip ]
 webkit.org/b/3652 http/tests/misc/prefetch-purpose.html [ Skip ]
 
+# First-party-only cookie policy only supported on Cocoa platforms.

[webkit-changes] [239831] trunk

[commit-queue]

Title: [239831] trunk








Revision 239831
Author commit-qu...@webkit.org
Date 2019-01-10 09:32:24 -0800 (Thu, 10 Jan 2019)


Log Message
[css-grid] Let abspos items reference implicit grid lines
https://bugs.webkit.org/show_bug.cgi?id=193313

Patch by Oriol Brufau  on 2019-01-10
Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Import test changes from WPT.

* web-platform-tests/css/css-grid/abspos/grid-positioned-items-padding-001.html:
* web-platform-tests/css/css-grid/abspos/grid-positioned-items-unknown-named-grid-line-001.html:

Source/WebCore:

While they can't create new implicit grid lines, abspos items
can reference existing ones as clarified in
https://github.com/w3c/csswg-drafts/commit/511bb63

This patch makes WebKit match Blink, Firefox and Edge.

Tests: web-platform-tests/css/css-grid/abspos/grid-positioned-items-padding-001.html
   web-platform-tests/css/css-grid/abspos/grid-positioned-items-unknown-named-grid-line-001.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator const):
Remove argument from spanSizeForAutoPlacedItem call.
(WebCore::RenderGrid::createEmptyGridAreaAtSpecifiedPositionsOutsideGrid const):
Remove argument from spanSizeForAutoPlacedItem call.
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid const):
Remove argument from spanSizeForAutoPlacedItem call.
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid const):
Remove argument from spanSizeForAutoPlacedItem call.
(WebCore::RenderGrid::gridAreaBreadthForOutOfFlowChild):
Don't treat implicit grid lines as 'auto'.
* rendering/RenderGrid.h:
Remove unused gridPositionIsAutoForOutOfFlow.
* rendering/style/GridPositionsResolver.cpp:
(WebCore::adjustGridPositionsFromStyle):
Don't treat implicit grid lines as 'auto'.
Remove unused gridContainerStyle parameter.
(WebCore::GridPositionsResolver::spanSizeForAutoPlacedItem):
Remove argument from adjustGridPositionsFromStyle call.
Remove unused gridContainerStyle parameter.
(WebCore::resolveGridPositionFromStyle):
Remove unnecessary assert that uses isValidNamedLineOrArea.
(WebCore::GridPositionsResolver::resolveGridPositionsFromStyle):
Remove argument from adjustGridPositionsFromStyle call.
* rendering/style/GridPositionsResolver.h:
Remove unused isValidNamedLineOrArea.
Remove unused parameter from spanSizeForAutoPlacedItem.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-padding-001.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-unknown-named-grid-line-001.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/RenderGrid.h
trunk/Source/WebCore/rendering/style/GridPositionsResolver.cpp
trunk/Source/WebCore/rendering/style/GridPositionsResolver.h




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (239830 => 239831)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2019-01-10 17:31:27 UTC (rev 239830)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2019-01-10 17:32:24 UTC (rev 239831)
@@ -1,3 +1,15 @@
+2019-01-10  Oriol Brufau  
+
+[css-grid] Let abspos items reference implicit grid lines
+https://bugs.webkit.org/show_bug.cgi?id=193313
+
+Reviewed by Manuel Rego Casasnovas.
+
+Import test changes from WPT.
+
+* web-platform-tests/css/css-grid/abspos/grid-positioned-items-padding-001.html:
+* web-platform-tests/css/css-grid/abspos/grid-positioned-items-unknown-named-grid-line-001.html:
+
 2019-01-10  cathie chen  
 
 Import css-lists testcases from WPT.


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-padding-001.html (239830 => 239831)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-padding-001.html	2019-01-10 17:31:27 UTC (rev 239830)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-padding-001.html	2019-01-10 17:32:24 UTC (rev 239831)
@@ -109,13 +109,13 @@
 
 
   -data-offset-x="0" data-offset-y="0" data-expected-width="15" data-expected-height="15">
+data-offset-x="15" data-offset-y="15" data-expected-width="515" data-expected-height="315">
   
   -data-offset-x="15" data-offset-y="0" data-expected-width="100" data-expected-height="15">
+data-offset-x="15" data-offset-y="15" data-expected-width="100" data-expected-height="315">
   
   -data-offset-x="0" data-offset-y="15" data-expected-width="15" data-expected-height="50">
+data-offset-x="15" data-offset-y="15" data-expected-width="515" data-expected-height="50">
   
data-offset-x="315" data-offset-y="215" data-expected-width="215" data-expected-height="115">
@@ -193,13 +193,13 @@
 
 
   -data-offset-x="515" data-offset-y="0" data-expected-width="15" data-expected-height="15">
+data-offset-x="0" data-offset-y="15" 

[webkit-changes] [239830] trunk

[mrajca]

Title: [239830] trunk








Revision 239830
Author mra...@apple.com
Date 2019-01-10 09:31:27 -0800 (Thu, 10 Jan 2019)


Log Message
Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
https://bugs.webkit.org/show_bug.cgi?id=193301

Reviewed by Jer Noble.
Source/WebCore:

Instead of unconditionally enabling this with a compile-time flag, let clients
enable the quirk on a per-load basis.

Tests: added API tests in favor of the current layout test as this behavior is no
   longer on by default unless a client opts in.

* html/MediaElementSession.cpp:
(WebCore::needsPerDocumentAutoplayBehaviorQuirk):
(WebCore::MediaElementSession::playbackPermitted const):
* loader/DocumentLoader.h:

Source/WebKit:

Register a new quirk that can be configured per-load for per-document media
autoplay behaviors.

* Shared/WebsiteAutoplayQuirk.h:
* Shared/WebsitePoliciesData.cpp:
(WebKit::WebsitePoliciesData::applyToDocumentLoader):
* UIProcess/API/C/WKWebsitePolicies.cpp:
(WKWebsitePoliciesSetAllowedAutoplayQuirks):
(WKWebsitePoliciesGetAllowedAutoplayQuirks):
* UIProcess/API/C/WKWebsitePolicies.h:
* UIProcess/API/Cocoa/_WKWebsitePolicies.h:
* UIProcess/API/Cocoa/_WKWebsitePolicies.mm:
(-[_WKWebsitePolicies setAllowedAutoplayQuirks:]):
(-[_WKWebsitePolicies allowedAutoplayQuirks]):

Tools:

Added API tests.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.

Modified Paths

trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/LayoutTests/platform/wincairo/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/MediaElementSession.cpp
trunk/Source/WebCore/loader/DocumentLoader.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebsiteAutoplayQuirk.h
trunk/Source/WebKit/Shared/WebsitePoliciesData.cpp
trunk/Source/WebKit/UIProcess/API/C/WKWebsitePolicies.cpp
trunk/Source/WebKit/UIProcess/API/C/WKWebsitePolicies.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsitePolicies.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsitePolicies.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html


Removed Paths

trunk/LayoutTests/media/document-level-media-user-gesture-quirk-expected.txt
trunk/LayoutTests/media/document-level-media-user-gesture-quirk.html




Diff

Deleted: trunk/LayoutTests/media/document-level-media-user-gesture-quirk-expected.txt (239829 => 239830)

--- trunk/LayoutTests/media/document-level-media-user-gesture-quirk-expected.txt	2019-01-10 16:45:51 UTC (rev 239829)
+++ trunk/LayoutTests/media/document-level-media-user-gesture-quirk-expected.txt	2019-01-10 17:31:27 UTC (rev 239830)
@@ -1,13 +0,0 @@
-  
-RUN(internals.setMediaElementRestrictions(video1, "RequireUserGestureForAudioRateChange"))
-RUN(internals.setMediaElementRestrictions(video2, "RequireUserGestureForAudioRateChange"))
-RUN(internals.settings.setNeedsSiteSpecificQuirks(true))
-Trying to play the first video without a user gesture
-RUN(video1.play().then(failTest).catch(playFirstVideoWithUserGesture))
-Playback was denied - trying to play the first video with a user gesture
-RUN(video1.play().then(playedFirstVideo).catch(failTest))
-The first video played with a user gesture - trying to play the second video
-The second video should play unconditionally on Mac with quirks enabled
-RUN(video2.play().then(endTest).catch(failTest))
-END OF TEST
-


Deleted: trunk/LayoutTests/media/document-level-media-user-gesture-quirk.html (239829 => 239830)

--- trunk/LayoutTests/media/document-level-media-user-gesture-quirk.html	2019-01-10 16:45:51 UTC (rev 239829)
+++ trunk/LayoutTests/media/document-level-media-user-gesture-quirk.html	2019-01-10 17:31:27 UTC (rev 239830)
@@ -1,38 +0,0 @@
-
-
-
-document-level-media-user-gesture-quirk
-
-function runTest() {
-var video1 = document.getElementById('video1');
-var video2 = document.getElementById('video2');
-
-run('internals.setMediaElementRestrictions(video1, "RequireUserGestureForAudioRateChange")');
-run('internals.setMediaElementRestrictions(video2, "RequireUserGestureForAudioRateChange")');
-run('internals.settings.setNeedsSiteSpecificQuirks(true)');
-
-consoleWrite("Trying to play the first video without a user gesture");
-run('video1.play().then(failTest).catch(playFirstVideoWithUserGesture)');
-}
-
-function playFirstVideoWithUserGesture() {
-consoleWrite("Playback was denied - trying to play the first video with a user gesture");
-runWithKeyDown(() => 

[webkit-changes] [239829] trunk/Source/ThirdParty/libwebrtc

[youenn]

Title: [239829] trunk/Source/ThirdParty/libwebrtc








Revision 239829
Author you...@apple.com
Date 2019-01-10 08:45:51 -0800 (Thu, 10 Jan 2019)


Log Message
VPModuleInitialize should be called when VCP is enabled
https://bugs.webkit.org/show_bug.cgi?id=193299

Reviewed by Eric Carlson.

Add the necessary include to make sure ENABLE_VCP_ENCODER is defined appropriately.

* Source/webrtc/sdk/WebKit/WebKitUtilities.mm:

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.mm




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (239828 => 239829)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2019-01-10 15:46:35 UTC (rev 239828)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2019-01-10 16:45:51 UTC (rev 239829)
@@ -1,3 +1,14 @@
+2019-01-10  Youenn Fablet  
+
+VPModuleInitialize should be called when VCP is enabled
+https://bugs.webkit.org/show_bug.cgi?id=193299
+
+Reviewed by Eric Carlson.
+
+Add the necessary include to make sure ENABLE_VCP_ENCODER is defined appropriately.
+
+* Source/webrtc/sdk/WebKit/WebKitUtilities.mm:
+
 2018-12-22  Dan Bernstein  
 
 Fixed Apple production builds.


Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.mm (239828 => 239829)

--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.mm	2019-01-10 15:46:35 UTC (rev 239828)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.mm	2019-01-10 16:45:51 UTC (rev 239829)
@@ -37,6 +37,10 @@
 #include "Framework/Headers/WebRTC/RTCVideoFrameBuffer.h"
 #include "Framework/Native/api/video_decoder_factory.h"
 #include "Framework/Native/api/video_encoder_factory.h"
+#include "VideoProcessingSoftLink.h"
+
+#include 
+
 /*
 #if !defined(WEBRTC_IOS)
 __attribute__((objc_runtime_name("WK_RTCUIApplicationStatusObserver")))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239827] trunk

[zalan]

Title: [239827] trunk








Revision 239827
Author za...@apple.com
Date 2019-01-10 07:42:18 -0800 (Thu, 10 Jan 2019)


Log Message
[LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
https://bugs.webkit.org/show_bug.cgi?id=193310

Reviewed by Antti Koivisto.

Source/WebCore:

If the block inflow element has previous siblings with collapsed through vertical margins,
then this box's before margin could _indirectly_ collapse with the parent. Use the previous siblings
to check for margin collapsing.

Test: fast/block/block-only/collapsed-through-siblings.html

* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::adjustedVerticalPositionAfterMarginCollapsing const):
* page/FrameViewLayoutContext.cpp:
(WebCore::layoutUsingFormattingContext):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

* fast/block/margin-collapse/collapsed-through-siblings-expected.txt: Added.
* fast/block/margin-collapse/collapsed-through-siblings.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt


Added Paths

trunk/LayoutTests/fast/block/block-only/collapsed-through-siblings-expected.txt
trunk/LayoutTests/fast/block/block-only/collapsed-through-siblings.html




Diff

Modified: trunk/LayoutTests/ChangeLog (239826 => 239827)

--- trunk/LayoutTests/ChangeLog	2019-01-10 12:46:18 UTC (rev 239826)
+++ trunk/LayoutTests/ChangeLog	2019-01-10 15:42:18 UTC (rev 239827)
@@ -1,3 +1,13 @@
+2019-01-10  Zalan Bujtas  
+
+[LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
+https://bugs.webkit.org/show_bug.cgi?id=193310
+
+Reviewed by Antti Koivisto.
+
+* fast/block/margin-collapse/collapsed-through-siblings-expected.txt: Added.
+* fast/block/margin-collapse/collapsed-through-siblings.html: Added.
+
 2019-01-10  Dominik Infuehr  
 
 Enable DFG on ARM/Linux again


Added: trunk/LayoutTests/fast/block/block-only/collapsed-through-siblings-expected.txt (0 => 239827)

--- trunk/LayoutTests/fast/block/block-only/collapsed-through-siblings-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/block/block-only/collapsed-through-siblings-expected.txt	2019-01-10 15:42:18 UTC (rev 239827)
@@ -0,0 +1,12 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,70) size 784x522
+  RenderBlock {DIV} at (0,0) size 400x400
+RenderBlock {DIV} at (0,0) size 400x0
+RenderBlock {DIV} at (0,0) size 400x0
+RenderBlock {DIV} at (0,0) size 400x0
+RenderBlock {DIV} at (0,0) size 400x0
+RenderBlock {DIV} at (0,0) size 400x0
+RenderBlock {DIV} at (0,0) size 100x100


Added: trunk/LayoutTests/fast/block/block-only/collapsed-through-siblings.html (0 => 239827)

--- trunk/LayoutTests/fast/block/block-only/collapsed-through-siblings.html	(rev 0)
+++ trunk/LayoutTests/fast/block/block-only/collapsed-through-siblings.html	2019-01-10 15:42:18 UTC (rev 239827)
@@ -0,0 +1,8 @@
+
+	
+	
+	
+	
+	
+	
+


Modified: trunk/Source/WebCore/ChangeLog (239826 => 239827)

--- trunk/Source/WebCore/ChangeLog	2019-01-10 12:46:18 UTC (rev 239826)
+++ trunk/Source/WebCore/ChangeLog	2019-01-10 15:42:18 UTC (rev 239827)
@@ -1,3 +1,21 @@
+2019-01-10  Zalan Bujtas  
+
+[LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
+https://bugs.webkit.org/show_bug.cgi?id=193310
+
+Reviewed by Antti Koivisto.
+
+If the block inflow element has previous siblings with collapsed through vertical margins,
+then this box's before margin could _indirectly_ collapse with the parent. Use the previous siblings
+to check for margin collapsing.
+
+Test: fast/block/block-only/collapsed-through-siblings.html
+
+* layout/blockformatting/BlockFormattingContext.cpp:
+(WebCore::Layout::BlockFormattingContext::adjustedVerticalPositionAfterMarginCollapsing const):
+* page/FrameViewLayoutContext.cpp:
+(WebCore::layoutUsingFormattingContext):
+
 2019-01-10  Alicia Boya García  
 
 [MSE][GStreamer] Use GRefPtr in AppendPipeline::pushNewBuffer()


Modified: trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp (239826 => 239827)

--- trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp	2019-01-10 12:46:18 UTC (rev 239826)
+++ trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp	2019-01-10 15:42:18 UTC (rev 239827)
@@ -477,8 +477,13 @@
 currentLayoutBox = 
 }
 
-auto containingBlockContentBoxTop = 

[webkit-changes] [239826] trunk/Source/WebCore

[aboya]

Title: [239826] trunk/Source/WebCore








Revision 239826
Author ab...@igalia.com
Date 2019-01-10 04:46:18 -0800 (Thu, 10 Jan 2019)


Log Message
[MSE][GStreamer] Use GRefPtr in AppendPipeline::pushNewBuffer()
https://bugs.webkit.org/show_bug.cgi?id=192934

Reviewed by Xabier Rodriguez-Calvar.

* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::pushNewBuffer):
* platform/graphics/gstreamer/mse/AppendPipeline.h:
* platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:
(WebCore::MediaSourceClientGStreamerMSE::append):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h
trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (239825 => 239826)

--- trunk/Source/WebCore/ChangeLog	2019-01-10 11:55:51 UTC (rev 239825)
+++ trunk/Source/WebCore/ChangeLog	2019-01-10 12:46:18 UTC (rev 239826)
@@ -1,3 +1,16 @@
+2019-01-10  Alicia Boya García  
+
+[MSE][GStreamer] Use GRefPtr in AppendPipeline::pushNewBuffer()
+https://bugs.webkit.org/show_bug.cgi?id=192934
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
+(WebCore::AppendPipeline::pushNewBuffer):
+* platform/graphics/gstreamer/mse/AppendPipeline.h:
+* platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:
+(WebCore::MediaSourceClientGStreamerMSE::append):
+
 2019-01-10  Carlos Garcia Campos  
 
 [FreeType] Color emoji not properly supported


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp (239825 => 239826)

--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp	2019-01-10 11:55:51 UTC (rev 239825)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp	2019-01-10 12:46:18 UTC (rev 239826)
@@ -552,10 +552,10 @@
 #endif
 }
 
-GstFlowReturn AppendPipeline::pushNewBuffer(GstBuffer* buffer)
+GstFlowReturn AppendPipeline::pushNewBuffer(GRefPtr&& buffer)
 {
-GST_TRACE_OBJECT(m_pipeline.get(), "pushing data buffer %" GST_PTR_FORMAT, buffer);
-GstFlowReturn pushDataBufferRet = gst_app_src_push_buffer(GST_APP_SRC(m_appsrc.get()), buffer);
+GST_TRACE_OBJECT(m_pipeline.get(), "pushing data buffer %" GST_PTR_FORMAT, buffer.get());
+GstFlowReturn pushDataBufferRet = gst_app_src_push_buffer(GST_APP_SRC(m_appsrc.get()), buffer.leakRef());
 // Pushing buffers to appsrc can only fail if the appsrc is flushing, in EOS or stopped. Neither of these should
 // be true at this point.
 g_return_val_if_fail(pushDataBufferRet == GST_FLOW_OK, GST_FLOW_ERROR);


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h (239825 => 239826)

--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h	2019-01-10 11:55:51 UTC (rev 239825)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h	2019-01-10 12:46:18 UTC (rev 239826)
@@ -49,7 +49,7 @@
 AppendPipeline(Ref, Ref, MediaPlayerPrivateGStreamerMSE&);
 virtual ~AppendPipeline();
 
-GstFlowReturn pushNewBuffer(GstBuffer*);
+GstFlowReturn pushNewBuffer(GRefPtr&&);
 void resetParserState();
 Ref sourceBufferPrivate() { return m_sourceBufferPrivate.get(); }
 GstCaps* appsinkCaps() { return m_appsinkCaps.get(); }


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp (239825 => 239826)

--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp	2019-01-10 11:55:51 UTC (rev 239825)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp	2019-01-10 12:46:18 UTC (rev 239826)
@@ -141,13 +141,13 @@
 // Wrap the whole Vector object in case the data is stored in the inlined buffer.
 auto* bufferData = data.data();
 auto bufferLength = data.size();
-GstBuffer* buffer = gst_buffer_new_wrapped_full(static_cast(0), bufferData, bufferLength, 0, bufferLength, new Vector(WTFMove(data)),
+GRefPtr buffer = adoptGRef(gst_buffer_new_wrapped_full(static_cast(0), bufferData, bufferLength, 0, bufferLength, new Vector(WTFMove(data)),
 [](gpointer data)
 {
 delete static_cast*>(data);
-});
+}));
 
-return appendPipeline->pushNewBuffer(buffer) == GST_FLOW_OK;
+return appendPipeline->pushNewBuffer(WTFMove(buffer)) == GST_FLOW_OK;
 }
 
 void MediaSourceClientGStreamerMSE::markEndOfStream(MediaSourcePrivate::EndOfStreamStatus status)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239824] trunk/WebDriverTests

[carlosgc]

Title: [239824] trunk/WebDriverTests








Revision 239824
Author carlo...@webkit.org
Date 2019-01-10 03:08:29 -0800 (Thu, 10 Jan 2019)


Log Message
Unreviewed gardening. Mark user prompts tests in take screenshot commands as failure

Tests don't expect user prompts to be handled in take screenshot commands, but that's going to change in the
spec soon, see https://github.com/w3c/webdriver/issues/1359.

* TestExpectations.json:

Modified Paths

trunk/WebDriverTests/ChangeLog
trunk/WebDriverTests/TestExpectations.json




Diff

Modified: trunk/WebDriverTests/ChangeLog (239823 => 239824)

--- trunk/WebDriverTests/ChangeLog	2019-01-10 11:01:18 UTC (rev 239823)
+++ trunk/WebDriverTests/ChangeLog	2019-01-10 11:08:29 UTC (rev 239824)
@@ -1,3 +1,12 @@
+2019-01-10  Carlos Garcia Campos  
+
+Unreviewed gardening. Mark user prompts tests in take screenshot commands as failure
+
+Tests don't expect user prompts to be handled in take screenshot commands, but that's going to change in the
+spec soon, see https://github.com/w3c/webdriver/issues/1359.
+
+* TestExpectations.json:
+
 2018-12-21  Carlos Garcia Campos  
 
 Unreviewed gardening. Skip imported/w3c/webdriver/tests/permissions/set.py.


Modified: trunk/WebDriverTests/TestExpectations.json (239823 => 239824)

--- trunk/WebDriverTests/TestExpectations.json	2019-01-10 11:01:18 UTC (rev 239823)
+++ trunk/WebDriverTests/TestExpectations.json	2019-01-10 11:08:29 UTC (rev 239824)
@@ -1020,5 +1020,11 @@
 },
 "imported/w3c/webdriver/tests/permissions/set.py": {
 "expected": {"all": {"status": ["SKIP"], "bug": "webkit.org/b/192978"}}
+},
+"imported/w3c/webdriver/tests/take_screenshot/user_prompts.py": {
+"expected": {"all": {"status": ["FAIL"]}}
+},
+"imported/w3c/webdriver/tests/take_element_screenshot/user_prompts.py": {
+"expected": {"all": {"status": ["FAIL"]}}
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239823] trunk/LayoutTests

[carlosgc]

Title: [239823] trunk/LayoutTests








Revision 239823
Author carlo...@webkit.org
Date 2019-01-10 03:01:18 -0800 (Thu, 10 Jan 2019)


Log Message
Unreviewed GTK+ gardening. Rebaseline two css tests.

I think I missed these in previous rebaselines.

* platform/gtk/css1/font_properties/font-expected.png:
* platform/gtk/css1/font_properties/font-expected.txt:
* platform/gtk/css2.1/t1508-c527-font-06-b-expected.png:
* platform/gtk/css2.1/t1508-c527-font-06-b-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/css1/font_properties/font-expected.png
trunk/LayoutTests/platform/gtk/css1/font_properties/font-expected.txt
trunk/LayoutTests/platform/gtk/css2.1/t1508-c527-font-06-b-expected.png
trunk/LayoutTests/platform/gtk/css2.1/t1508-c527-font-06-b-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (239822 => 239823)

--- trunk/LayoutTests/ChangeLog	2019-01-10 10:03:53 UTC (rev 239822)
+++ trunk/LayoutTests/ChangeLog	2019-01-10 11:01:18 UTC (rev 239823)
@@ -1,5 +1,16 @@
 2019-01-10  Carlos Garcia Campos  
 
+Unreviewed GTK+ gardening. Rebaseline two css tests.
+
+I think I missed these in previous rebaselines.
+
+* platform/gtk/css1/font_properties/font-expected.png:
+* platform/gtk/css1/font_properties/font-expected.txt:
+* platform/gtk/css2.1/t1508-c527-font-06-b-expected.png:
+* platform/gtk/css2.1/t1508-c527-font-06-b-expected.txt:
+
+2019-01-10  Carlos Garcia Campos  
+
 [FreeType] Color emoji not properly supported
 https://bugs.webkit.org/show_bug.cgi?id=191976
 


Modified: trunk/LayoutTests/platform/gtk/css1/font_properties/font-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/gtk/css1/font_properties/font-expected.txt (239822 => 239823)

--- trunk/LayoutTests/platform/gtk/css1/font_properties/font-expected.txt	2019-01-10 10:03:53 UTC (rev 239822)
+++ trunk/LayoutTests/platform/gtk/css1/font_properties/font-expected.txt	2019-01-10 11:01:18 UTC (rev 239823)
@@ -9,29 +9,29 @@
   RenderBlock {PRE} at (0,27) size 769x168
 RenderText {#text} at (0,0) size 399x168
   text run at (0,0) width 161: "BODY {font-size: 12px;}"
-  text run at (160,0) width 1: " "
+  text run at (161,0) width 0: " "
   text run at (0,14) width 322: ".one {font: italic small-caps 13pt Helvetica;}"
-  text run at (321,14) width 1: " "
+  text run at (322,14) width 0: " "
   text run at (0,28) width 203: ".two {font: 150%/150% serif;}"
-  text run at (202,28) width 1: " "
+  text run at (203,28) width 0: " "
   text run at (0,42) width 252: ".three {font: 150%/150% sans-serif;}"
-  text run at (251,42) width 1: " "
+  text run at (252,42) width 0: " "
   text run at (0,56) width 231: ".four {font: small/200% cursive;}"
-  text run at (230,56) width 1: " "
+  text run at (231,56) width 0: " "
   text run at (0,70) width 399: ".five {font: italic small-caps 900 150%/150% sans-serif;}"
-  text run at (398,70) width 1: " "
+  text run at (399,70) width 0: " "
   text run at (0,84) width 392: ".six {font: italic small-caps 100 150%/300% sans-serif;}"
-  text run at (391,84) width 1: " "
+  text run at (392,84) width 0: " "
   text run at (0,98) width 392: ".seven {font: italic small-caps 900 150%/2em monospace;}"
-  text run at (391,98) width 1: " "
+  text run at (392,98) width 0: " "
   text run at (0,112) width 399: ".eight {font: italic small-caps 500 150%/1in sans-serif;}"
-  text run at (398,112) width 1: " "
+  text run at (399,112) width 0: " "
   text run at (0,126) width 378: ".nine {font: oblique normal 700 18px/200% sans-serif;}"
-  text run at (377,126) width 1: " "
+  text run at (378,126) width 0: " "
   text run at (0,140) width 301: ".ten {font: normal 400 80%/2.5 sans-serif;}"
-  text run at (300,140) width 1: " "
+  text run at (301,140) width 0: " "
   text run at (0,154) width 266: "SPAN.color {background-color: silver;}"
-  text run at (265,154) width 1: " "
+  text run at (266,154) width 0: " "
   RenderBlock {HR} at (0,207) size 769x2 [border: (1px inset #00)]
   RenderBlock {P} at (0,221) size 769x15
 RenderText {#text} at (0,0) size 706x14
@@ -86,9 +86,9 @@
 RenderText {#text} at (0,8) size 750x128
   text run at (0,8) width 750: "This element should be in a monospace font, italicized and small caps, with a weight of"
   text run at (0,44) width 55: "900. "
-  text run at (55,44) width 687: "Its font-size should be 150% the base font size, and its line-height should be"
+  text run at (54,44) width 688: "Its font-size should be 150% the base font size, and its line-height should be"
   text run at (0,80) width 618: 

[webkit-changes] [239822] trunk

[carlosgc]

Title: [239822] trunk








Revision 239822
Author carlo...@webkit.org
Date 2019-01-10 02:03:53 -0800 (Thu, 10 Jan 2019)


Log Message
[FreeType] Color emoji not properly supported
https://bugs.webkit.org/show_bug.cgi?id=191976

Reviewed by Michael Catanzaro.

Source/WebCore:

Always try to fallback to a colored font for emojis.

Test: platform/gtk/fonts/font-emoji-system-fallback.html

* platform/graphics/ComplexTextController.cpp:
(WebCore::advanceByCombiningCharacterSequence): Group regional indicators in pairs.
* platform/graphics/Font.cpp:
(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::Font::systemFallbackFontForCharacter const): Pass PreferColoredFont::No to FontCache::systemFallbackForCharacters.
* platform/graphics/Font.h: Add IsForPlatformFont enum to replace the bool parameter in systemFallbackFontForCharacter().
* platform/graphics/FontCache.h:
* platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::glyphDataForSystemFallback):
* platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::characterSequenceIsEmoji): Check whether the character sequence is an emoji.
(WebCore::FontCascade::fontForCombiningCharacterSequence const): In case of emojis try to fallback to a colored
font even if base font can render the emoji in black and white.
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::systemFallbackForCharacters): Add PreferColoredFont parameter that is ignored.
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::systemFallbackForCharacters): Add PreferColoredFont parameter.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::FontPlatformData): Initialize m_isColorBitmapFont.
* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::Font::variantCapsSupportsCharacterForSynthesis const): Moved from cross-platform file.
(WebCore::Font::platformSupportsCodePoint const): Add freetype implementation.
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::systemFallbackForCharacters): Add PreferColoredFont parameter that is ignored.
* platform/text/CharacterProperties.h:
(WebCore::isEmojiKeycapBase):
(WebCore::isEmojiRegionalIndicator):
(WebCore::isEmojiWithPresentationByDefault):
(WebCore::isEmojiModifierBase):

Source/WTF:

Add a name for combining enclosing keycap character.

* wtf/unicode/CharacterNames.h:

LayoutTests:

Add new test to ensure we fallback to noto color emoji for emojis.

* platform/gtk/fonts/font-emoji-system-fallback-expected.html: Added.
* platform/gtk/fonts/font-emoji-system-fallback.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/unicode/CharacterNames.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ComplexTextController.cpp
trunk/Source/WebCore/platform/graphics/Font.cpp
trunk/Source/WebCore/platform/graphics/Font.h
trunk/Source/WebCore/platform/graphics/FontCache.h
trunk/Source/WebCore/platform/graphics/FontCascadeFonts.cpp
trunk/Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp
trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp
trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp
trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp
trunk/Source/WebCore/platform/graphics/win/FontCacheWin.cpp
trunk/Source/WebCore/platform/text/CharacterProperties.h


Added Paths

trunk/LayoutTests/platform/gtk/fonts/font-emoji-system-fallback-expected.html
trunk/LayoutTests/platform/gtk/fonts/font-emoji-system-fallback.html




Diff

Modified: trunk/LayoutTests/ChangeLog (239821 => 239822)

--- trunk/LayoutTests/ChangeLog	2019-01-10 10:01:14 UTC (rev 239821)
+++ trunk/LayoutTests/ChangeLog	2019-01-10 10:03:53 UTC (rev 239822)
@@ -1,3 +1,15 @@
+2019-01-10  Carlos Garcia Campos  
+
+[FreeType] Color emoji not properly supported
+https://bugs.webkit.org/show_bug.cgi?id=191976
+
+Reviewed by Michael Catanzaro.
+
+Add new test to ensure we fallback to noto color emoji for emojis.
+
+* platform/gtk/fonts/font-emoji-system-fallback-expected.html: Added.
+* platform/gtk/fonts/font-emoji-system-fallback.html: Added.
+
 2019-01-10  cathie chen  
 
 Import css-lists testcases from WPT.


Added: trunk/LayoutTests/platform/gtk/fonts/font-emoji-system-fallback-expected.html (0 => 239822)

--- trunk/LayoutTests/platform/gtk/fonts/font-emoji-system-fallback-expected.html	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fonts/font-emoji-system-fallback-expected.html	2019-01-10 10:03:53 UTC (rev 239822)
@@ -0,0 +1,2 @@
+
+


Added: trunk/LayoutTests/platform/gtk/fonts/font-emoji-system-fallback.html (0 => 239822)

--- trunk/LayoutTests/platform/gtk/fonts/font-emoji-system-fallback.html	(rev 0)
+++ 

[webkit-changes] [239821] trunk/LayoutTests

[commit-queue]

Title: [239821] trunk/LayoutTests








Revision 239821
Author commit-qu...@webkit.org
Date 2019-01-10 02:01:14 -0800 (Thu, 10 Jan 2019)


Log Message
Import css-lists testcases from WPT.
https://bugs.webkit.org/show_bug.cgi?id=193273

Patch by cathie chen  on 2019-01-10
Reviewed by Daniel Bates.

LayoutTests/imported/w3c:

* resources/import-expectations.json:
* resources/resource-files.json:
* web-platform-tests/css/css-lists/META.yml: Added.
* web-platform-tests/css/css-lists/add-inline-child-after-marker-001-expected.html: Added.
* web-platform-tests/css/css-lists/add-inline-child-after-marker-001.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-armenian-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-armenian.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-circle-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-circle.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-decimal-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-decimal-leading-zero-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-decimal-leading-zero.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-decimal.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-disc-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-disc.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-georgian-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-georgian.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-greek-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-greek.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-latin-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-latin.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-roman-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-roman.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-square-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-square.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-upper-latin-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-upper-latin.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-upper-roman-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-upper-roman.html: Added.
* web-platform-tests/css/css-lists/content-property/w3c-import.log: Added.
* web-platform-tests/css/css-lists/counter-increment-inside-display-contents-expected.html: Added.
* web-platform-tests/css/css-lists/counter-increment-inside-display-contents.html: Added.
* web-platform-tests/css/css-lists/counter-invalid-expected.html: Added.
* web-platform-tests/css/css-lists/counter-invalid.htm: Added.
* web-platform-tests/css/css-lists/counter-reset-increment-display-contents-expected.html: Added.
* web-platform-tests/css/css-lists/counter-reset-increment-display-contents.html: Added.
* web-platform-tests/css/css-lists/counter-reset-increment-display-none-expected.html: Added.
* web-platform-tests/css/css-lists/counter-reset-increment-display-none.html: Added.
* web-platform-tests/css/css-lists/counter-reset-inside-display-contents-expected.html: Added.
* web-platform-tests/css/css-lists/counter-reset-inside-display-contents.html: Added.
* web-platform-tests/css/css-lists/inheritance-expected.txt: Added.
* web-platform-tests/css/css-lists/inheritance.html: Added.
* web-platform-tests/css/css-lists/li-with-height-001-expected.html: Added.
* web-platform-tests/css/css-lists/li-with-height-001.html: Added.
* web-platform-tests/css/css-lists/li-with-overflow-hidden-change-list-style-position-001-expected.html: Added.
* web-platform-tests/css/css-lists/li-with-overflow-hidden-change-list-style-position-001.html: Added.
* web-platform-tests/css/css-lists/list-and-block-textarea-001-expected.txt: Added.
* web-platform-tests/css/css-lists/list-and-block-textarea-001.html: Added.
* web-platform-tests/css/css-lists/list-and-flex-001-expected.html: Added.
* web-platform-tests/css/css-lists/list-and-flex-001.html: Added.
* web-platform-tests/css/css-lists/list-and-grid-001-expected.html: Added.
* web-platform-tests/css/css-lists/list-and-grid-001.html: Added.
* web-platform-tests/css/css-lists/list-and-margin-collapse-001-expected.txt: Added.
* 

[webkit-changes] [239820] trunk/Source/WebCore

[graouts]

Title: [239820] trunk/Source/WebCore








Revision 239820
Author grao...@webkit.org
Date 2019-01-10 00:19:39 -0800 (Thu, 10 Jan 2019)


Log Message
[Web Animations] Audit Web Animations classes for memory reduction
https://bugs.webkit.org/show_bug.cgi?id=193195

Reviewed by Simon Fraser and Yusuke Suzuki.

The classes, enums and structs added to support Web Animations were not as memory-efficient as they could be. We now order
members in a way that reduces padding, use Markable instead of Optional where applicable, declare enums as uint8_t
and removed unnecessary members.

As a result, classes and structs have shrunk as follows:

WebAnimation: 256 > 216
DeclarativeAnimation: 392 > 344
CSSAnimation: 416 > 368
CSSTransition: 440 > 392
AnimationEffect: 88 > 72
KeyframeEffect: 208 > 184
AnimationPlaybackEvent: 104 > 88
EffectTiming: 72 > 64
ComputedEffectTiming: 136 > 112
AnimationTimeline: 264 > 248
DocumentTimeline: 496 > 464
OptionalEffectTiming: 112 > 80
BaseKeyframe: 32 > 24
ParsedKeyframe: 80 > 72
BaseComputedKeyframe: 40 > 32

* animation/AnimationEffect.h: Order members in decreasing size, except for m_fill and m_direction, which we put at the top to
save 8 bytes (2 bytes of padding instead of 4 before m_animation and saving 6 bytes of padding at the end).
* animation/AnimationPlaybackEvent.cpp:
(WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent):
* animation/AnimationPlaybackEvent.h:
* animation/AnimationPlaybackEventInit.h:
* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::AnimationTimeline):
(WebCore::AnimationTimeline::updateCSSTransitionsForElement):
* animation/AnimationTimeline.h: We remove the m_classType member and instead make isDocumentTimeline() virtual.
(WebCore::AnimationTimeline::isDocumentTimeline const):
(): Deleted.
(WebCore::AnimationTimeline::classType const): Deleted.
* animation/CompositeOperation.h:
* animation/CompositeOperationOrAuto.h:
* animation/ComputedEffectTiming.h:
* animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::DeclarativeAnimation):
(WebCore::DeclarativeAnimation::invalidateDOMEvents):
* animation/DeclarativeAnimation.h: We keep m_wasPending and m_previousPhase at the top to save some padding at the end.
* animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::DocumentTimeline):
* animation/DocumentTimeline.h:
* animation/EffectTiming.h:
* animation/FillMode.h:
* animation/IterationCompositeOperation.h:
* animation/KeyframeEffect.cpp:
(WebCore::computeMissingKeyframeOffsets):
(WebCore::KeyframeEffect::create):
(WebCore::KeyframeEffect::KeyframeEffect):
* animation/KeyframeEffect.h:
* animation/OptionalEffectTiming.h:
* animation/PlaybackDirection.h:
* animation/WebAnimation.h:
* animation/WebAnimationUtilities.h:
(WebCore::WebAnimationsMarkableDoubleTraits::isEmptyValue):
(WebCore::WebAnimationsMarkableDoubleTraits::emptyValue):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/AnimationEffect.h
trunk/Source/WebCore/animation/AnimationPlaybackEvent.cpp
trunk/Source/WebCore/animation/AnimationPlaybackEvent.h
trunk/Source/WebCore/animation/AnimationPlaybackEventInit.h
trunk/Source/WebCore/animation/AnimationTimeline.cpp
trunk/Source/WebCore/animation/AnimationTimeline.h
trunk/Source/WebCore/animation/CompositeOperation.h
trunk/Source/WebCore/animation/CompositeOperationOrAuto.h
trunk/Source/WebCore/animation/ComputedEffectTiming.h
trunk/Source/WebCore/animation/DeclarativeAnimation.cpp
trunk/Source/WebCore/animation/DeclarativeAnimation.h
trunk/Source/WebCore/animation/DocumentTimeline.cpp
trunk/Source/WebCore/animation/DocumentTimeline.h
trunk/Source/WebCore/animation/EffectTiming.h
trunk/Source/WebCore/animation/FillMode.h
trunk/Source/WebCore/animation/IterationCompositeOperation.h
trunk/Source/WebCore/animation/KeyframeEffect.cpp
trunk/Source/WebCore/animation/KeyframeEffect.h
trunk/Source/WebCore/animation/OptionalEffectTiming.h
trunk/Source/WebCore/animation/PlaybackDirection.h
trunk/Source/WebCore/animation/WebAnimation.h
trunk/Source/WebCore/animation/WebAnimationUtilities.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (239819 => 239820)

--- trunk/Source/WebCore/ChangeLog	2019-01-10 08:02:31 UTC (rev 239819)
+++ trunk/Source/WebCore/ChangeLog	2019-01-10 08:19:39 UTC (rev 239820)
@@ -1,3 +1,70 @@
+2019-01-09  Antoine Quint  
+
+[Web Animations] Audit Web Animations classes for memory reduction
+https://bugs.webkit.org/show_bug.cgi?id=193195
+
+Reviewed by Simon Fraser and Yusuke Suzuki.
+
+The classes, enums and structs added to support Web Animations were not as memory-efficient as they could be. We now order
+members in a way that reduces padding, use Markable instead of Optional where applicable, declare enums as uint8_t
+and removed unnecessary members.
+
+As a result, classes and structs have shrunk as follows:
+
+WebAnimation: 256 > 216
+DeclarativeAnimation: 392 > 344
+CSSAnimation: 416 > 368

[webkit-changes] [239819] trunk/Source/WebKit

[timothy_horton]

Title: [239819] trunk/Source/WebKit








Revision 239819
Author timothy_hor...@apple.com
Date 2019-01-10 00:02:31 -0800 (Thu, 10 Jan 2019)


Log Message
Rename some entitlements files to be more clear about their target platform
https://bugs.webkit.org/show_bug.cgi?id=193311

Reviewed by Alexey Proskuryakov.

* Configurations/Network-iOSMac.entitlements: Renamed from Source/WebKit/Configurations/Network-iOS-minimalsimulator.entitlements.
* Configurations/NetworkService.xcconfig:
* Configurations/WebContent-iOSMac.entitlements: Renamed from Source/WebKit/Configurations/WebContent-iOS-minimalsimulator.entitlements.
* Configurations/WebContentService.xcconfig:
* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/NetworkService.xcconfig
trunk/Source/WebKit/Configurations/WebContentService.xcconfig
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit/Configurations/Network-iOSMac.entitlements
trunk/Source/WebKit/Configurations/WebContent-iOSMac.entitlements


Removed Paths

trunk/Source/WebKit/Configurations/Network-iOS-minimalsimulator.entitlements
trunk/Source/WebKit/Configurations/WebContent-iOS-minimalsimulator.entitlements




Diff

Modified: trunk/Source/WebKit/ChangeLog (239818 => 239819)

--- trunk/Source/WebKit/ChangeLog	2019-01-10 05:23:26 UTC (rev 239818)
+++ trunk/Source/WebKit/ChangeLog	2019-01-10 08:02:31 UTC (rev 239819)
@@ -1,3 +1,16 @@
+2019-01-10  Tim Horton  
+
+Rename some entitlements files to be more clear about their target platform
+https://bugs.webkit.org/show_bug.cgi?id=193311
+
+Reviewed by Alexey Proskuryakov.
+
+* Configurations/Network-iOSMac.entitlements: Renamed from Source/WebKit/Configurations/Network-iOS-minimalsimulator.entitlements.
+* Configurations/NetworkService.xcconfig:
+* Configurations/WebContent-iOSMac.entitlements: Renamed from Source/WebKit/Configurations/WebContent-iOS-minimalsimulator.entitlements.
+* Configurations/WebContentService.xcconfig:
+* WebKit.xcodeproj/project.pbxproj:
+
 2019-01-09  Brent Fulgham  
 
 Unreviewed build fix after r239816.


Deleted: trunk/Source/WebKit/Configurations/Network-iOS-minimalsimulator.entitlements (239818 => 239819)

--- trunk/Source/WebKit/Configurations/Network-iOS-minimalsimulator.entitlements	2019-01-10 05:23:26 UTC (rev 239818)
+++ trunk/Source/WebKit/Configurations/Network-iOS-minimalsimulator.entitlements	2019-01-10 08:02:31 UTC (rev 239819)
@@ -1,12 +0,0 @@
-
-
-
-
-seatbelt-profiles
-
-com.apple.WebKit.Networking
-
-	com.apple.security.network.client
-	
-
-


Copied: trunk/Source/WebKit/Configurations/Network-iOSMac.entitlements (from rev 239817, trunk/Source/WebKit/Configurations/Network-iOS-minimalsimulator.entitlements) (0 => 239819)

--- trunk/Source/WebKit/Configurations/Network-iOSMac.entitlements	(rev 0)
+++ trunk/Source/WebKit/Configurations/Network-iOSMac.entitlements	2019-01-10 08:02:31 UTC (rev 239819)
@@ -0,0 +1,12 @@
+
+
+
+
+seatbelt-profiles
+
+com.apple.WebKit.Networking
+
+	com.apple.security.network.client
+	
+
+


Modified: trunk/Source/WebKit/Configurations/NetworkService.xcconfig (239818 => 239819)

--- trunk/Source/WebKit/Configurations/NetworkService.xcconfig	2019-01-10 05:23:26 UTC (rev 239818)
+++ trunk/Source/WebKit/Configurations/NetworkService.xcconfig	2019-01-10 08:02:31 UTC (rev 239819)
@@ -30,7 +30,7 @@
 WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE_watchsimulator = Network-iOS;
 WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE_appletvos = Network-iOS;
 WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE_appletvsimulator = Network-iOS;
-WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE_iosmac = Network-iOS-minimalsimulator;
+WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE_iosmac = Network-iOSMac;
 
 CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO = Configurations/Network-OSX.entitlements;
 OTHER_CODE_SIGN_FLAGS = $(WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS);


Deleted: trunk/Source/WebKit/Configurations/WebContent-iOS-minimalsimulator.entitlements (239818 => 239819)

--- trunk/Source/WebKit/Configurations/WebContent-iOS-minimalsimulator.entitlements	2019-01-10 05:23:26 UTC (rev 239818)
+++ trunk/Source/WebKit/Configurations/WebContent-iOS-minimalsimulator.entitlements	2019-01-10 08:02:31 UTC (rev 239819)
@@ -1,12 +0,0 @@
-
-
-
-
-	seatbelt-profiles
-	
-		com.apple.WebKit.WebContent
-	
-	com.apple.security.cs.allow-jit
-	
-
-


Copied: trunk/Source/WebKit/Configurations/WebContent-iOSMac.entitlements (from rev 239817, trunk/Source/WebKit/Configurations/WebContent-iOS-minimalsimulator.entitlements) (0 => 239819)

--- trunk/Source/WebKit/Configurations/WebContent-iOSMac.entitlements	(rev 0)
+++ trunk/Source/WebKit/Configurations/WebContent-iOSMac.entitlements	2019-01-10 08:02:31 UTC (rev 239819)
@@ -0,0 +1,12 @@
+
+
+
+
+	seatbelt-profiles
+	
+		com.apple.WebKit.WebContent
+	
+