Re: [webkit-dev] Subpixel Layout Update
We've been pretty heavily in bug-fix mode recently, but it's been our intention to synchronize layout-unit usage in trunk to shrink down our patch for awhile now. On Fri, Oct 28, 2011 at 3:14 PM, Eric Seidel wrote: > It's not a big deal. It just wasn't until I saw the diff in > prettydiff that I had any clue what the branch changes look like. > After looking at the diff, it looks like you all should be able to > easily merge most of your branch into trunk *today*. Much of it is > changes we want regardless of whether we move to subpixel layout or > not. :) > > On Fri, Oct 28, 2011 at 2:54 PM, Emil A Eklund wrote: >> On Fri, Oct 28, 2011 at 14:52, Eric Seidel wrote: >>> I've posted the current diff from the branch so that its easier to read. >> >> Thanks Eric, >> >> I'll make sure to update it periodically to make it easier to follow >> our progress. >> >> -- >> Emil >> > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Subpixel Layout Update
It's not a big deal. It just wasn't until I saw the diff in prettydiff that I had any clue what the branch changes look like. After looking at the diff, it looks like you all should be able to easily merge most of your branch into trunk *today*. Much of it is changes we want regardless of whether we move to subpixel layout or not. :) On Fri, Oct 28, 2011 at 2:54 PM, Emil A Eklund wrote: > On Fri, Oct 28, 2011 at 14:52, Eric Seidel wrote: >> I've posted the current diff from the branch so that its easier to read. > > Thanks Eric, > > I'll make sure to update it periodically to make it easier to follow > our progress. > > -- > Emil > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Subpixel Layout Update
On Fri, Oct 28, 2011 at 14:52, Eric Seidel wrote: > I've posted the current diff from the branch so that its easier to read. Thanks Eric, I'll make sure to update it periodically to make it easier to follow our progress. -- Emil ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Subpixel Layout Update
I've posted the current diff from the branch so that its easier to read. On Fri, Oct 28, 2011 at 2:45 PM, Levi Weintraub wrote: > Thanks Eric, > > I just created a meta bug to track issues found in the branch. Please > file issues as blocking bugs against 71143: > https://bugs.webkit.org/show_bug.cgi?id=71143 > > -Levi > > On Fri, Oct 28, 2011 at 2:38 PM, Eric Seidel wrote: >> Do you have a master bug we can CC ourselves on to follow along at home? >> >> I've attached the diff, btw. >> >> On Fri, Oct 28, 2011 at 1:54 PM, Emil A Eklund wrote: >>> On Fri, Oct 28, 2011 at 13:47, Eric Seidel wrote: Most interesting is to see the branch diff. Is that possible from the web? Could you tell me what the magic svn command is if it's not possible? >>> >>> The easiest seems to be the following: >>> >>> svn diff --old http://svn.webkit.org/repository/webkit/trunk@98654 >>> --new http://svn.webkit.org/repository/webkit/branches/subpixellayout >>> Source/ >>> >>> Where the magic revision number is the last revision we've merged into >>> the branch, in this case 98654. You can find the latest revision we've >>> merged by looking at the revision history here: >>> http://trac.webkit.org/log/branches/subpixellayout >>> >>> >>> -- >>> Emil >>> >> > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Subpixel Layout Update
Thanks Eric, I just created a meta bug to track issues found in the branch. Please file issues as blocking bugs against 71143: https://bugs.webkit.org/show_bug.cgi?id=71143 -Levi On Fri, Oct 28, 2011 at 2:38 PM, Eric Seidel wrote: > Do you have a master bug we can CC ourselves on to follow along at home? > > I've attached the diff, btw. > > On Fri, Oct 28, 2011 at 1:54 PM, Emil A Eklund wrote: >> On Fri, Oct 28, 2011 at 13:47, Eric Seidel wrote: >>> Most interesting is to see the branch diff. Is that possible from the >>> web? Could you tell me what the magic svn command is if it's not >>> possible? >> >> The easiest seems to be the following: >> >> svn diff --old http://svn.webkit.org/repository/webkit/trunk@98654 >> --new http://svn.webkit.org/repository/webkit/branches/subpixellayout >> Source/ >> >> Where the magic revision number is the last revision we've merged into >> the branch, in this case 98654. You can find the latest revision we've >> merged by looking at the revision history here: >> http://trac.webkit.org/log/branches/subpixellayout >> >> >> -- >> Emil >> > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Subpixel Layout Update
On Fri, Oct 28, 2011 at 13:47, Eric Seidel wrote: > Most interesting is to see the branch diff. Is that possible from the > web? Could you tell me what the magic svn command is if it's not > possible? The easiest seems to be the following: svn diff --old http://svn.webkit.org/repository/webkit/trunk@98654 --new http://svn.webkit.org/repository/webkit/branches/subpixellayout Source/ Where the magic revision number is the last revision we've merged into the branch, in this case 98654. You can find the latest revision we've merged by looking at the revision history here: http://trac.webkit.org/log/branches/subpixellayout -- Emil ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Subpixel Layout Update
On Fri, Oct 28, 2011 at 1:43 PM, Levi Weintraub wrote: > As you may know, Emil and I have been diligently working on getting > subpixel layout up and running in WebKit. After much testing, we > settled on a fixed point implementation instead of floats; we're happy > to discuss how we arrived at this decision. Maybe create a Wiki page describe all the design decisions so you don't have to explain this multiple times? Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Subpixel Layout Update
Most interesting is to see the branch diff. Is that possible from the web? Could you tell me what the magic svn command is if it's not possible? Thanks! On Fri, Oct 28, 2011 at 1:43 PM, Levi Weintraub wrote: > WebKittens, > > As you may know, Emil and I have been diligently working on getting > subpixel layout up and running in WebKit. After much testing, we > settled on a fixed point implementation instead of floats; we're happy > to discuss how we arrived at this decision. We're currently in a state > where we pass most of the layout tests and many (but not all) of the > remaining failures are due to rounding differences that are desirable. > > As such, we've moved our efforts to a public branch on the WebKit.org > svn server, and would love early feedback and advice. Our branch > currently runs the following ports: Mac, Qt, Chromium-Linux, and > Chromium-Mac. Any advice or help bringing up other platforms would be > greatly appreciated. > > You can check our work out here: > http://svn.webkit.org/repository/webkit/branches/subpixellayout > (currently branched from r98654 and we'll continue to track head by a > day or two) > > Thanks, > Emil and Levi > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Subpixel Layout Update
WebKittens, As you may know, Emil and I have been diligently working on getting subpixel layout up and running in WebKit. After much testing, we settled on a fixed point implementation instead of floats; we're happy to discuss how we arrived at this decision. We're currently in a state where we pass most of the layout tests and many (but not all) of the remaining failures are due to rounding differences that are desirable. As such, we've moved our efforts to a public branch on the WebKit.org svn server, and would love early feedback and advice. Our branch currently runs the following ports: Mac, Qt, Chromium-Linux, and Chromium-Mac. Any advice or help bringing up other platforms would be greatly appreciated. You can check our work out here: http://svn.webkit.org/repository/webkit/branches/subpixellayout (currently branched from r98654 and we'll continue to track head by a day or two) Thanks, Emil and Levi ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] watchlist: A tool to alert you about patches of interest.
On Thu, 20 Oct 2011 00:40:14 +0200, David Levin wrote: The watchlist is a simple way to watch for new patches that interest you. The watchlist is automatically applied to patches by a bot (currently the style bot). ... Dave, it's cool! It'd be nice to find a way to subscribe for the rules without trunk changes. What is your opinion about an extra field in the settings of bugzilla? With the current solution the watchlist file can inordinately grow because of the special personal rule demands. Hmm does it make sense to solve through an extra setting field of bugzilla accounts? Zoltan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] old-run-webkit-tests is officially deprecated.
On Fri, Oct 28, 2011 at 1:00 AM, Eric Seidel wrote: > > If you're still using old-run-webkit-tests for your work, I would > *love* to know and fix any issues you may have with NRWT. > > The lack of locale independence is a showstopper for me, https://bugs.webkit.org/show_bug.cgi?id=68691. antti ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] old-run-webkit-tests is officially deprecated.
Please file these as bugs so they get tracked, fixed and not forgotten. :) On Fri, Oct 28, 2011 at 2:57 AM, Nikolas Zimmermann wrote: > > Am 28.10.2011 um 00:40 schrieb Eric Seidel: > >> Yes, thank you Ryosuke: >> https://bugs.webkit.org/show_bug.cgi?id=68931 >> >> If you have any other issues, I would love to know about them. > > The "--ignore" flag of orwt, accepting a comma seperated list of tests/dirs > to skip is very useful. > As WebGL tests cause a machine lockup on my old 2006 MBP, I always used > "run-webkit-tests -i fast/canvas/webgl". > > I'd appreciate if that could be added. > > Thanks, > Niko > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] old-run-webkit-tests is officially deprecated.
Am 28.10.2011 um 00:40 schrieb Eric Seidel: > Yes, thank you Ryosuke: > https://bugs.webkit.org/show_bug.cgi?id=68931 > > If you have any other issues, I would love to know about them. The "--ignore" flag of orwt, accepting a comma seperated list of tests/dirs to skip is very useful. As WebGL tests cause a machine lockup on my old 2006 MBP, I always used "run-webkit-tests -i fast/canvas/webgl". I'd appreciate if that could be added. Thanks, Niko ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
