Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]
Anatoly Lyutin [EMAIL PROTECTED] wrote: I have fixed failures in Win2k3 and have posed patch in Wine-Devel. May be it will be passes in WinXP. No, the test still doesn't pass for me under XP. I get te following failures in your test: msg.c:3209: Test failed: Child not switch correctly : the msg 0x0281 should NOT have been sent by DefWindowProc msg.c:3209: Test failed: Child not switch correctly : the msg 0x0047 was expected, but got msg 0x0281 instead Btw, you shouldn't use '\n' in the comment for the ok_sequence call. And I get another failure caused by your patch: msg.c:3233: Test failed: WM_MDICREATE for maximized visible MDI child window: the msg 0x0008 was expected, but got msg 0x0282 instead -- Dmitry.
Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]
Hi, Dmitry! I have fixed failures in Win2k3 and have posed patch in Wine-Devel. May be it will be passes in WinXP. -- Best regards Anatoly Lyutin.
Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]
Anatoly Lyutin [EMAIL PROTECTED] wrote: You can find the results of the test run under XP here: http://test.winehq.org/data/200707121000/xp_XP-PRO-IE7/user32:msg.txt I get the same failures. Thanks. I have viewed this. It was failed on 0x00ae messages. I could not find description of this message. Do you know something about it? It's a not documented XP message, have a look how other message sequences cope with it. http://test.winehq.org/data/200707121000/2003_W2K3-SE-SP2/user32:msg.txt shows that the run under W2K3 has exactly the same failures in your test. Hmm.. I want to asked you about this: msg.c:3285:expected 0008 - actual 0008 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 8005 - actual 0007 msg.c:3285:expected 0007 - actual 0007 msg.c:3285:expected 0009 - actual 0009 msg.c:3285:expected 0008 - actual 0008 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 8005 - actual 0007 msg.c:3285:expected 0007 - actual 0007 msg.c:3285:expected 0222 - actual 0222 msg.c:3285:expected 0047 - actual 0047 msg.c:3287:end of test for switch maximized MDI children Why does not this fail? Is this correct? You have in view of it? Sorry, I don't understand what you are trying to ask, or why the sequence above should fail. or you mean that failed on : msg.c:3271:expected 0001 - actual 0001 msg.c:3271:expected 0046 - actual 0046 msg.c:3271:expected 0083 - actual 0024 msg.c:3271: Test failed: Create maximized visible 2nd MDI child 2 window(Switch test) But I take this part from another test only for creating MDI child. I can see msg sequence for this test and fix it if I can. I see 2 failures in your test in the run under W2k3, and 3 failures under XP in the logs referenced above. -- Dmitry.
Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]
Anatoly Lyutin [EMAIL PROTECTED] wrote: I have asked that I can not understand why in test expected and obtained message does not coincide and test does not fail. Ex.: msg.c:3285:expected 0008 - actual 0008 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 8005 - actual 0007 Why distinction between the expected and the obtained messages leads to fail in another tests but not fail in this place? If a message is marked as optional it can be skipped without causing the test to fail. I see 2 failures in your test in the run under W2k3, and 3 failures under XP in the logs referenced above. That's right. But there 2 failures are not mine ( More precisely they directly do not concern to my test. ) These are tests for creation MDI children. Not switching. Here are the failures I see in http://test.winehq.org/data/200707121000/2003_W2K3-SE-SP2/user32:msg.txt msg.c:3252: Test failed: Create maximized visible 1st MDI child window(Switch test): the msg 0x0081 was expected, but got msg 0x0024 instead msg.c:3271: Test failed: Create maximized visible 2nd MDI child 2 window(Switch test): the msg 0x0083 was expected, but got msg 0x0024 instead Same failures exist in the XP run, plus another one: msg.c:3285: Test failed: Child not switch correctly -- Dmitry.
Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]
Dmitry Timoshkov wrote: Anatoly Lyutin [EMAIL PROTECTED] wrote: Can you send me output when you run my test on XP? It will be nice. You can find the results of the test run under XP here: http://test.winehq.org/data/200707121000/xp_XP-PRO-IE7/user32:msg.txt I get the same failures. Thanks. I have viewed this. It was failed on 0x00ae messages. I could not find description of this message. Do you know something about it? http://test.winehq.org/data/200707121000/2003_W2K3-SE-SP2/user32:msg.txt shows that the run under W2K3 has exactly the same failures in your test. Hmm.. I want to asked you about this: msg.c:3285:expected 0008 - actual 0008 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 8005 - actual 0007 msg.c:3285:expected 0007 - actual 0007 msg.c:3285:expected 0009 - actual 0009 msg.c:3285:expected 0008 - actual 0008 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 8005 - actual 0007 msg.c:3285:expected 0007 - actual 0007 msg.c:3285:expected 0222 - actual 0222 msg.c:3285:expected 0047 - actual 0047 msg.c:3287:end of test for switch maximized MDI children Why does not this fail? Is this correct? You have in view of it? or you mean that failed on : msg.c:3271:expected 0001 - actual 0001 msg.c:3271:expected 0046 - actual 0046 msg.c:3271:expected 0083 - actual 0024 msg.c:3271: Test failed: Create maximized visible 2nd MDI child 2 window(Switch test) But I take this part from another test only for creating MDI child. I can see msg sequence for this test and fix it if I can. -- Best regards Anatoly Lyutin.
Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]
Dmitry Timoshkov пишет: Anatoly Lyutin [EMAIL PROTECTED] wrote: You can find the results of the test run under XP here: http://test.winehq.org/data/200707121000/xp_XP-PRO-IE7/user32:msg.txt I get the same failures. Thanks. I have viewed this. It was failed on 0x00ae messages. I could not find description of this message. Do you know something about it? It's a not documented XP message, have a look how other message sequences cope with it. Ok. Thank you. http://test.winehq.org/data/200707121000/2003_W2K3-SE-SP2/user32:msg.txt shows that the run under W2K3 has exactly the same failures in your test. Hmm.. I want to asked you about this: msg.c:3285:expected 0008 - actual 0008 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 8005 - actual 0007 msg.c:3285:expected 0007 - actual 0007 msg.c:3285:expected 0009 - actual 0009 msg.c:3285:expected 0008 - actual 0008 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 8005 - actual 0007 msg.c:3285:expected 0007 - actual 0007 msg.c:3285:expected 0222 - actual 0222 msg.c:3285:expected 0047 - actual 0047 msg.c:3287:end of test for switch maximized MDI children Why does not this fail? Is this correct? You have in view of it? Sorry, I don't understand what you are trying to ask, or why the sequence above should fail. I have asked that I can not understand why in test expected and obtained message does not coincide and test does not fail. Ex.: msg.c:3285:expected 0008 - actual 0008 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 8005 - actual 0007 Why distinction between the expected and the obtained messages leads to fail in another tests but not fail in this place? I very want to understand difference. or you mean that failed on : msg.c:3271:expected 0001 - actual 0001 msg.c:3271:expected 0046 - actual 0046 msg.c:3271:expected 0083 - actual 0024 msg.c:3271: Test failed: Create maximized visible 2nd MDI child 2 window(Switch test) But I take this part from another test only for creating MDI child. I can see msg sequence for this test and fix it if I can. I see 2 failures in your test in the run under W2k3, and 3 failures under XP in the logs referenced above. That's right. But there 2 failures are not mine ( More precisely they directly do not concern to my test. ) These are tests for creation MDI children. Not switching. -- Best regards Anatoly Lyutin.
Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]
Dmitry Timoshkov wrote: Anatoly Lyutin [EMAIL PROTECTED] wrote: If a message is marked as optional it can be skipped without causing the test to fail. Thank you. I did not know about it. It will help me. Here are the failures I see in http://test.winehq.org/data/200707121000/2003_W2K3-SE-SP2/user32:msg.txt msg.c:3252: Test failed: Create maximized visible 1st MDI child window(Switch test): the msg 0x0081 was expected, but got msg 0x0024 instead msg.c:3271: Test failed: Create maximized visible 2nd MDI child 2 window(Switch test): the msg 0x0083 was expected, but got msg 0x0024 instead I have reviewed this. This my mistake. You are right. I try to fix it. Thanks. Same failures exist in the XP run, plus another one: msg.c:3285: Test failed: Child not switch correctly -- Best regards Anatoly Lyutin.
Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]
Anatoly Lyutin [EMAIL PROTECTED] wrote: Can you send me output when you run my test on XP? It will be nice. You can find the results of the test run under XP here: http://test.winehq.org/data/200707121000/xp_XP-PRO-IE7/user32:msg.txt I get the same failures. http://test.winehq.org/data/200707121000/2003_W2K3-SE-SP2/user32:msg.txt shows that the run under W2K3 has exactly the same failures in your test. -- Dmitry.
Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]
Hi, Dmitry! Can you send me output when you run my test on XP? It will be nice. -- Best regards Anatoly Lyutin.
Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]
Anatoly Lyutin [EMAIL PROTECTED] wrote: /* test for switch maximized MDI children */ +ShowWindow(mdi_client, SW_SHOW); trace(creating maximized visible MDI child window 1(Switch test)\n); mdi_child = CreateWindowExA(WS_EX_MDICHILD, MDI_child_class, MDI child, WS_CHILD | WS_VISIBLE | WS_MAXIMIZEBOX | WS_MAXIMIZE, Did you run the test under Windows after this change? For me this test doesn't pass under up to date XP neither in current, nor in new state. -- Dmitry.
