[Zeitgeist] [Bug 486996] [NEW] testInsertGetWithoutTimestamp testcase fails

2009-11-23 Thread Markus Korn
Public bug reported:

Running
   python test/resonance-engine-test.py
I get one failed testcase

==
FAIL: testInsertGetWithoutTimestamp (__main__.ZeitgeistEngineTest)
--
Traceback (most recent call last):
  File test/resonance-engine-test.py, line 87, in 
testInsertGetWithoutTimestamp
self.assertTrue(ev.timestamp)
AssertionError

--

I would have fixed this if I were totally sure what the correct fix is.
Right now the default timestamp of an event is an empty string, which is
why this testcase fails. Is this the expected behaviour, and should we
fix the test. Or should the default timestamp be a string containing the
timestamp of object creation time?

** Affects: zeitgeist
 Importance: Undecided
 Status: New

** Changed in: zeitgeist
Milestone: None = 0.3

-- 
testInsertGetWithoutTimestamp testcase fails
https://bugs.launchpad.net/bugs/486996
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: New

Bug description:
Running
   python test/resonance-engine-test.py
I get one failed testcase

==
FAIL: testInsertGetWithoutTimestamp (__main__.ZeitgeistEngineTest)
--
Traceback (most recent call last):
  File test/resonance-engine-test.py, line 87, in 
testInsertGetWithoutTimestamp
self.assertTrue(ev.timestamp)
AssertionError

--

I would have fixed this if I were totally sure what the correct fix is. Right 
now the default timestamp of an event is an empty string, which is why this 
testcase fails. Is this the expected behaviour, and should we fix the test. Or 
should the default timestamp be a string containing the timestamp of object 
creation time?

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 486996] Re: testInsertGetWithoutTimestamp testcase fails

2009-11-23 Thread Markus Korn
** Changed in: zeitgeist
   Status: New = Triaged

-- 
testInsertGetWithoutTimestamp testcase fails
https://bugs.launchpad.net/bugs/486996
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: Triaged

Bug description:
Running
   python test/resonance-engine-test.py
I get one failed testcase

==
FAIL: testInsertGetWithoutTimestamp (__main__.ZeitgeistEngineTest)
--
Traceback (most recent call last):
  File test/resonance-engine-test.py, line 87, in 
testInsertGetWithoutTimestamp
self.assertTrue(ev.timestamp)
AssertionError

--

I would have fixed this if I were totally sure what the correct fix is. Right 
now the default timestamp of an event is an empty string, which is why this 
testcase fails. Is this the expected behaviour, and should we fix the test. Or 
should the default timestamp be a string containing the timestamp of object 
creation time?

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 486996] Re: testInsertGetWithoutTimestamp testcase fails

2009-11-23 Thread Seif Lotfy
We should not even allow empty timestamps in. But if you guys think we
should then an empty timestamp means we should generate one using
time.time() and insert it into the DB. What do u think?

-- 
testInsertGetWithoutTimestamp testcase fails
https://bugs.launchpad.net/bugs/486996
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: Triaged

Bug description:
Running
   python test/resonance-engine-test.py
I get one failed testcase

==
FAIL: testInsertGetWithoutTimestamp (__main__.ZeitgeistEngineTest)
--
Traceback (most recent call last):
  File test/resonance-engine-test.py, line 87, in 
testInsertGetWithoutTimestamp
self.assertTrue(ev.timestamp)
AssertionError

--

I would have fixed this if I were totally sure what the correct fix is. Right 
now the default timestamp of an event is an empty string, which is why this 
testcase fails. Is this the expected behaviour, and should we fix the test. Or 
should the default timestamp be a string containing the timestamp of object 
creation time?

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


Re: [Zeitgeist] [Bug 486996] Re: testInsertGetWithoutTimestamp testcase fails

2009-11-23 Thread Seif Lotfy
@Mikkel: OK I get ur point :)

2009/11/23 Mikkel Kamstrup Erlandsen mikkel.kamst...@gmail.com

 @Seif: I wouldn't have to care about the timestamp format when sending
 events if my app doesn't need high precision timing. Just create the
 Event instance and send it along. Recall that not all apps will be
 written in Python and using our client libs...

 --
 testInsertGetWithoutTimestamp testcase fails
 https://bugs.launchpad.net/bugs/486996
 You received this bug notification because you are subscribed to The
 Zeitgeist Project.

 Status in Zeitgeist Engine: Triaged

 Bug description:
 Running
   python test/resonance-engine-test.py
 I get one failed testcase

 ==
 FAIL: testInsertGetWithoutTimestamp (__main__.ZeitgeistEngineTest)
 --
 Traceback (most recent call last):
  File test/resonance-engine-test.py, line 87, in
 testInsertGetWithoutTimestamp
self.assertTrue(ev.timestamp)
 AssertionError

 --

 I would have fixed this if I were totally sure what the correct fix is.
 Right now the default timestamp of an event is an empty string, which is why
 this testcase fails. Is this the expected behaviour, and should we fix the
 test. Or should the default timestamp be a string containing the timestamp
 of object creation time?



-- 
testInsertGetWithoutTimestamp testcase fails
https://bugs.launchpad.net/bugs/486996
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: Triaged

Bug description:
Running
   python test/resonance-engine-test.py
I get one failed testcase

==
FAIL: testInsertGetWithoutTimestamp (__main__.ZeitgeistEngineTest)
--
Traceback (most recent call last):
  File test/resonance-engine-test.py, line 87, in 
testInsertGetWithoutTimestamp
self.assertTrue(ev.timestamp)
AssertionError

--

I would have fixed this if I were totally sure what the correct fix is. Right 
now the default timestamp of an event is an empty string, which is why this 
testcase fails. Is this the expected behaviour, and should we fix the test. Or 
should the default timestamp be a string containing the timestamp of object 
creation time?

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 423139] Re: Data sources should use Event and Item classes

2009-11-23 Thread Seif Lotfy
I don' see us using this anymore since we only have one DP recently used 
Everything else will be in form of external DP

** Changed in: zeitgeist
   Status: In Progress = Invalid

** Changed in: zeitgeist
Milestone: 0.3.0 = None

** Changed in: zeitgeist
 Assignee: Seif Lotfy (seif) = (unassigned)

** Changed in: zeitgeist
   Importance: Low = Undecided

-- 
Data sources should use Event and Item classes
https://bugs.launchpad.net/bugs/423139
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: Invalid

Bug description:
If we have EventDict in the public module (as part of zeitgeist.dbusutils) then 
we should make use of it wherever applicable.


Otherwise EventDict should be moved out of zeitgeist/.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 413782] Re: Add GetContents and GetSources to the API

2009-11-23 Thread Seif Lotfy
** Changed in: zeitgeist
   Status: Confirmed = Invalid

** Changed in: zeitgeist
   Importance: High = Undecided

** Changed in: zeitgeist
Milestone: 0.3.0 = None

-- 
Add GetContents and GetSources to the API
https://bugs.launchpad.net/bugs/413782
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: Invalid

Bug description:
Currenty we have a GetTypes method that makes no sense since we have no such 
things as types anymore
We should change that to GetContents and GetSources to follow our current 
annotation convention
Also we shoudl look into our DB to check out what sources and what types are 
registered in our DB

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 429255] Re: sqlite error if 'application' attribute of an event is not given

2009-11-23 Thread Seif Lotfy
** Changed in: zeitgeist
   Status: New = Invalid

-- 
sqlite error if 'application' attribute of an event is not given
https://bugs.launchpad.net/bugs/429255
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: Invalid

Bug description:
(This is a bug in the event-item-separation branch)

According to the definition of an event in zeitgeist/datamodel.py the 
application attribute is optional.
The attached reproducer trys to add an event with 'application' not set, it 
fails with the following error:

Traceback (most recent call last):
  File reproducer.py, line 24, in module
engine.insert_event(event, item)
  File 
/home/markus/devel/gnome-zeitgeist/zeitgeist/event-item-separation/_zeitgeist/engine/querymancer_engine.py,
 line 425, in insert_event
app_id=self._get_application_id(event[application]))
  File 
/home/markus/devel/gnome-zeitgeist/zeitgeist/event-item-separation/_zeitgeist/engine/querymancer.py,
 line 267, in add
self._cursor.execute(self.INSERT(**rowspec))
sqlite3.OperationalError: no such column: None

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 426270] Re: AttributeError: 'NoneType' object has no attribute 'execute' if firefox is not installed

2009-11-23 Thread Seif Lotfy
** Changed in: zeitgeist
   Status: New = Invalid

-- 
AttributeError: 'NoneType' object has no attribute 'execute' if firefox is 
not installed
https://bugs.launchpad.net/bugs/426270
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: Invalid

Bug description:
I get this Traceback if firefox is not installed (a history db is not found):

DEBUG:root:Updating database with new Firefox History items
Traceback (most recent call last):
  File /home/markus/zeitgeist/trunk/zeitgeist/../zeitgeist-datahub, line 111, 
in _update_db_async
for num, item in enumerate(self._sources_queue[0].get_items()):
  File 
/home/markus/zeitgeist/trunk/zeitgeist/../_zeitgeist/loggers/zeitgeist_base.py,
 line 107, in _wrapper
for n, i in enumerate(self.get_items_uncached()):
  File 
/home/markus/zeitgeist/trunk/zeitgeist/../_zeitgeist/loggers/datasources/firefox.py,
 line 159, in get_items_uncached
history = self.cursor.execute(
AttributeError: 'NoneType' object has no attribute 'execute'

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 407372] Re: dataprovider use content type which are not valid URIs

2009-11-23 Thread Seif Lotfy
** Changed in: zeitgeist
   Status: Confirmed = Invalid

** Changed in: zeitgeist
Milestone: 0.3.0 = None

-- 
dataprovider use content  type which are not valid URIs
https://bugs.launchpad.net/bugs/407372
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: Invalid

Bug description:
the dataprovider in _zeitgesit/loggers/dataprovider use strings like File, 
Web or Note as content types. Which does not match our database design 
spec, which claims URIs for this values.
We need to change it and provide a script to convert entries in an existing DB 
to the new values.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 416724] Re: Insertion of same event more than once

2009-11-23 Thread Seif Lotfy
** Changed in: zeitgeist/0.3
   Status: New = Triaged

** Changed in: zeitgeist/0.3
   Status: Triaged = Invalid

-- 
Insertion of same event more than once
https://bugs.launchpad.net/bugs/416724
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: Invalid
Status in Zeitgeist Engine 0.3 series: Invalid

Bug description:
We tend to insert the same event twice sometimes but very rarely. It is usually 
a diffrence in the float part of the timestamp! We should convert to int 
before we insert

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 398448] Re: Compatibility with different Firefox versions (.desktop file)

2009-11-23 Thread Seif Lotfy
** Changed in: zeitgeist
   Status: New = Invalid

-- 
Compatibility with different Firefox versions (.desktop file)
https://bugs.launchpad.net/bugs/398448
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: Invalid

Bug description:
The firefox datasource has /usr/share/applications/firefox.desktop hardcoded, 
but that assumption is not always valid (eg., the user may have a 
firefox-3.5.desktop file).

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 416726] Re: Tomboy notes use wrong timestamps

2009-11-23 Thread Seif Lotfy
** Changed in: zeitgeist/0.3
   Status: Confirmed = Invalid

** Changed in: zeitgeist/0.3
Milestone: 0.3.0 = None

** Changed in: zeitgeist/0.3
   Importance: Medium = Undecided

-- 
Tomboy notes use wrong timestamps
https://bugs.launchpad.net/bugs/416726
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: Invalid
Status in Zeitgeist Engine 0.3 series: Invalid

Bug description:
Tomboy events have a +1 hour offset to my current time! Small bug needs fixing! 
We need to push events with a unified timestamp either UTC or UTC+TZ

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 487321] Re: Origin

2009-11-23 Thread Mikkel Kamstrup Erlandsen
WHY NOT?

-- 
Origin
https://bugs.launchpad.net/bugs/487321
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: New

Bug description:
 +   origin = 
 info.get_uri().rpartition(/)[0]

WHY?

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 485433] Re: Dont' raise an exception when a duplicate event is detected

2009-11-23 Thread Mikkel Kamstrup Erlandsen
I'll do this tonight, and update the unit tests accordingly

** Changed in: zeitgeist
 Assignee: Seif Lotfy (seif) = Mikkel Kamstrup Erlandsen (kamstrup)

-- 
Dont' raise an exception when a duplicate event is detected
https://bugs.launchpad.net/bugs/485433
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: Triaged

Bug description:
19:52 RainCT thekorn: raising an exception on Duplicate event detected is 
evil
19:53 RainCT thekorn: tell me how you want recent.py to work this way
19:53 thekorn RainCT, catch this exception
19:54 RainCT thekorn: doesn't help, if I'm sending 50 event and event 10 is 
already there then events 11-50 won't get inserted
19:55 thekorn RainCT, ok, so the only problem is when you are importing the 
existing history?
19:55 RainCT thekorn: no, with the current one too, because recent.py doesn't 
know when the last run was
19:55 thekorn RainCT, let's open a critical bugreport for it
19:56 thekorn this has to be discussed and needs more thoughts
19:56 RainCT (we should workaround that in some way but still the Zeitgeist 
API not allowing this is a problem)

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 483603] Re: Use timestamps with milliseconds granularity (was: use REAL)

2009-11-23 Thread Mikkel Kamstrup Erlandsen
Yes. Plugins *must* send the timestamps in millis since the Epoch. If
apps only use second granularity then we will have three zeroes in the
end of the timestamps.

-- 
Use timestamps with milliseconds granularity (was: use REAL)
https://bugs.launchpad.net/bugs/483603
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: New

Bug description:
Seconds are not fine-grained enough to differentiate events, so we should store 
the timestamps as floating-point numbers.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 425258] Re: origin should be a property of events, not items

2009-11-23 Thread Mikkel Kamstrup Erlandsen
Yeah. We had a discussion about this at the hackfest and everyone agreed
that origin must be a property of the subject(s). So the meaning og
origin is where does the subject come from?. For files it is the
parent folder. For websites it is the root URL (eg. http://youtube.com).

We do need to figure out however if we want trailing slashes on origin
or not... That's another issue however.

** Changed in: zeitgeist
   Status: Triaged = Invalid

-- 
origin should be a property of events, not items
https://bugs.launchpad.net/bugs/425258
You received this bug notification because you are a member of
Zeitgeist-Engine, which is the registrant for Zeitgeist Engine.

Status in Zeitgeist Engine: Invalid

Bug description:
Both http://live.gnome.org/GnomeZeitgeist/DatabaseDesign and our current 
implementation have origin as a property of items, but this makes no sense, 
as the origin can be different for every event and should as such be a property 
of it. (Further, to improve disk space usage we should save the actual value of 
it in the uri table).

I'm filling this bug so that we don't remember to fix it, but please let's 
ignore it until we get the basic event/item separation stuff merged - most 
important stuff first.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp