Re: [Zope-dev] Re: Reminder: feature freeze November 1.
Dang, that's embarassing. Thanks Tres! On Sun, 2005-11-13 at 23:43 -0500, Tres Seaver wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark Hammond wrote: Not on Windows: Windows test failures on Zope trunk http://www.zope.org/Collectors/Zope/1931 CMF-trunk runs fine on the Zope trunk, etc. Certainly agree it would help to have a specific list of what (if anything) still needs to fixed. FWIW, I don't expect Windows test failures to hold up a beta release (note that I didn't say that's a policy I agree with ;-)). Without Windows-centric developers who are motivated to investigate and fix those bugs, I don't know what else we can do. That bugs points at http://mail.zope.org/pipermail/zope-dev/2005-October/025512.html, which quotes Tim as saying: : No idea where this slash-vs-backslash confusion ultimately comes from, : though. Who recently checked code in hard-coding / as a path : separator? So in this specific example, the problem seems less a lack of Windows centric developers, but more an abundance of non-Windows-centric developers :) These test failures appear at first glance to not be windows specific at all - just possibly pointing at non-portable code written by others. As a Windows developer, I'm afraid I have no idea where I would start looking for this bug. test.py in the root is the likely culprit, as it is mucking with sys.path. Does this patch make the Windows tests pass? - --- test.py (revision 40087) +++ test.py (working copy) @@ -30,7 +30,7 @@ if shome: shome = os.path.abspath(shome) else: - -shome = os.path.join(zhome, 'lib/python') +shome = os.path.join(zhome, 'lib', 'python') elif shome: shome = os.path.abspath(shome) zhome = os.path.dirname(os.path.dirname(shome)) Tres. - -- === Tres Seaver +1 202-558-7113 [EMAIL PROTECTED] Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDeBX3+gerLs4ltQ4RAiMdAKC7L8kACTUcTON76ch5bLNEkzO60gCgmAWw tEeI08XK7m7PP3wD3Kwt9xE= =0aEf -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope ) ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Reminder: feature freeze November 1.
[Tres Seaver] test.py in the root is the likely culprit, as it is mucking with sys.path. Does this patch make the Windows tests pass? - --- test.py (revision 40087) +++ test.py (working copy) @@ -30,7 +30,7 @@ if shome: shome = os.path.abspath(shome) else: - -shome = os.path.join(zhome, 'lib/python') +shome = os.path.join(zhome, 'lib', 'python') elif shome: shome = os.path.abspath(shome) zhome = os.path.dirname(os.path.dirname(shome)) Well spotted! It (plus the later patch) does fix the checkDuplicate test failure on Windows, and I closed issue 1931. Turns out the Five tests that were failing on Windows also fail on Linux, but the failing tests don't run unless you pass ``--all`` to test.py (which I normally do, but I guess most people don't, in which case most people wouldn't see these failures). I opened a new issue about that: http://www.zope.org/Collectors/Zope/1947 ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: SVN: Zope/trunk/test.py Don't hard-wire forward-slash into sys.path (redux).
Tres Seaver wrote: Log message for revision 40092: Don't hard-wire forward-slash into sys.path (redux). Please don't forget to merge this and the previous rev to the Zope 2.9 branch. From now on, both the trunk and the 2.9 branch need to be taken care of. Philipp ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: branched Zope 2.9
Florent Guillaume wrote: BTW I'm for removing the 2.9 branch for now. You didn't, so I presume 2.9 branch stays? It's important to clear the status of this branch because bugfixes need to be merged to it (see my email about Tres' bugfix, for example). By the way, in the future, just to avoid confusion, I think release branches should be made by the release manager (in thise case Andreas Jung). They clearly fall under their responsibility and supervision. I still think it was a good thing to create the branch now because I agree with Tres' general argument that a feature freeze on the trunk hinders on-going development. The trunk should never be in any freeze state. That's what release branches are for. Thus, the Zope 2.9 and 3.2 branches should have been made November 1st. Philipp ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: branched Zope 2.9
--On 15. November 2005 00:20:00 +0800 Philipp von Weitershausen [EMAIL PROTECTED] wrote: Florent Guillaume wrote: BTW I'm for removing the 2.9 branch for now. You didn't, so I presume 2.9 branch stays? It's important to clear the status of this branch because bugfixes need to be merged to it (see my email about Tres' bugfix, for example). By the way, in the future, just to avoid confusion, I think release branches should be made by the release manager (in thise case Andreas Jung). They clearly fall under their responsibility and supervision. Jup. So when I see clear the only problem is the zpkg issue (where Philikon is working on it)...right? -aj pgpwkcfOTJt9V.pgp Description: PGP signature ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Reminder: feature freeze November 1.
On Sun, Nov 13, 2005 at 02:55:22PM -0500, Chris McDonough wrote: Of course the release manager should have the last say and as the release manager it's totally valid for Andreas to delete the branch. Apologies for taking initiative. I was really just trying to unstick Paul and get things rolling again. Thanks Chris, I didn't mean for you to get you in hot water. And thanks Jim for directly answering my question, which is really all I needed :) -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: branched Zope 2.9
Andreas Jung wrote: --On 15. November 2005 00:20:00 +0800 Philipp von Weitershausen [EMAIL PROTECTED] wrote: Florent Guillaume wrote: BTW I'm for removing the 2.9 branch for now. You didn't, so I presume 2.9 branch stays? It's important to clear the status of this branch because bugfixes need to be merged to it (see my email about Tres' bugfix, for example). By the way, in the future, just to avoid confusion, I think release branches should be made by the release manager (in thise case Andreas Jung). They clearly fall under their responsibility and supervision. Jup. So when I see clear the only problem is the zpkg issue (where Philikon is working on it)...right? Jup. Making progress in babysteps. Philipp ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope trunk 2.4 Windows 2000 fred-win
The Buildbot has detected a failed build of Zope trunk 2.4 Windows 2000 fred-win. Buildbot URL: http://buildbot.zope.org/ Build Reason: changes Build Source Stamp: 1541 Blamelist: philikon BUILD FAILED: failed failed slave lost sincerely, -The Buildbot ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Reminder: feature freeze November 1.
On Mon, 2005-11-14 at 10:22 -0500, Tim Peters wrote: ... Turns out the Five tests that were failing on Windows also fail on Linux, but the failing tests don't run unless you pass ``--all`` to test.py (which I normally do, but I guess most people don't, in which case most people wouldn't see these failures). I opened a new issue about that: http://www.zope.org/Collectors/Zope/1947 Ah. I'll add --all to the buildbot configs. JIm ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: branched Zope 2.9
On Tue, 2005-11-15 at 00:20 +0800, Philipp von Weitershausen wrote: Florent Guillaume wrote: BTW I'm for removing the 2.9 branch for now. You didn't, so I presume 2.9 branch stays? It's important to clear the status of this branch because bugfixes need to be merged to it (see my email about Tres' bugfix, for example). This is Andreas' call. Jim ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )