Hello all,
I have a couple of suggestions for changes to AbstractProcessingFilter. I am
not sure on process for submitting patches but I am happy to make these
changes myself if somebody would care to provide this information.
My first suggestion is to provide alternate failure URLs for the diffe
Hi Wesley
Thanks for the suggestions. Comments below.
Wesley Hall wrote:
Hello all,
I have a couple of suggestions for changes to AbstractProcessingFilter. I am
not sure on process for submitting patches but I am happy to make these
changes myself if somebody would care to provide this information.
Ben,
Thanks for taking the time to respond. (Comments below)
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] Behalf Of
> Ben Alex
> Sent: 20 July 2004 04:02
> To: [EMAIL PROTECTED]
> Subject: Re: [Acegisecurity-developer] Sugge
che license as the rest of the acegi code.
Regards
Wesley Hall
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] Behalf Of
> Wesley Hall
> Sent: 21 July 2004 20:26
> To: [EMAIL PROTECTED]
> Subject: RE: [Acegisecurity-developer] Suggestions
Hi Wesley
Thanks for the contribution.
Wesley Hall wrote:
Hi Ben,
I have made some changes to the attached classes...
AbstractProcessingFilter
-
authenticationServiceFailureUrl - AuthenticationServiceException
authenticationCredentialCheckFailureUrl - BadCredentialsExcep
Ben,
Comments below...
> >
> I've committed this one, minus the UsernameNotFoundException (because it
> gets re-thrown by DaoAuthenticationProvider in a BadCredentialsException).
>
> If people need to support additional application-specific (rather than
> Acegi Security-specific) exceptions, we c
Wesley Hall wrote:
This would actually be my preference too. I dont think the stack trace will
be affected unless a new exception is created, but I would have liked to set
the Authentication object in an overloaded constructor. The problem is that
it seemed that in some cases the Authenication inst
Hi Ben,
> Hi Wesley
>
> If you'd like to submit patches which take advantage of the enhanced
> AuthenticationException.getAuthentication() method, I'd be pleased to
> apply them to CVS.
>
> Best regards
> Ben
OK, I started an attempt at adding the setting of the Authentication object
right down a
Wesley Hall wrote:
Hi Ben,
Hi Wesley
If you'd like to submit patches which take advantage of the enhanced
AuthenticationException.getAuthentication() method, I'd be pleased to
apply them to CVS.
Best regards
Ben
What I have done (and this is a little more invasive, I know), is moved the
cat
