Re: [ath9k-devel] varying RSSI values with ath9k_htc drivers for TL-WN721N USB wifi adapter.

2013-05-02 Thread Harshal Vora
Hi, I did some testing with the latest version of the ath9k_htc drivers in 3.9.0-rc8-wl which already has the patch https://patchwork.kernel.org/patch/2177921/ and the results are much better. Can you point out the AR9285 RX descriptor contents relating to antenna configuration? Regards,

[ath9k-devel] [PATCH] ath9k_htc: Add ethtool stats support.

2013-05-02 Thread greearb
From: Ben Greear This provides some of the same info found in the ath9k_htc debugfs through the standard ethtool stats API. This logic is only supported when ath9k_htc debugfs kernel feature is enabled, since that is the only time stats are actually gathered. Signed-off-by: Ben Greear --- dri

Re: [ath9k-devel] Standardisation - adding 2 bit STBC and Ness to MCS

2013-05-02 Thread Johannes Berg
On Wed, 2013-05-01 at 16:34 +0200, Oleksij Rempel wrote: > > With this I believe we have everything needed to start the 3 week > > comment period. Yeah, I guess there was plenty of time. I would have preferred a separate thread, but I guess there's little enough traffic on this list so it doesn't

Re: [ath9k-devel] [PATCH 1/2] ath9k_htc: add STBC TX support

2013-05-02 Thread Oleksij Rempel
Hi Felix, thank you for your explanation and being pation with me. I learn it by my self and keywords you gave help me to find needed information. So, i continue to digg in to google books and wikis now. I see now, that my initial assumption that STBC some thing like "frequency diversity" is wr

Re: [ath9k-devel] [PATCH 1/2] ath9k_htc: add STBC TX support

2013-05-02 Thread Adrian Chadd
Well, let's dig into the firmware a bit more and tidy up how STBC is handled. Adrian ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 1/2] ath9k_htc: add STBC TX support

2013-05-02 Thread Felix Fietkau
On 2013-05-02 7:32 PM, Oleksij Rempel wrote: > Am 02.05.2013 18:55, schrieb Adrian Chadd: >> On 2 May 2013 01:11, Oleksij Rempel wrote: >> >>> +#define WLAN_RC_TX_STBC_FLAG 0x20 /* TX STBC */ >>> +#define WLAN_RC_RX_STBC_FLAG 0xC0 /* RX STBC ,2 bits */ >> >> I thought we covered this; why are you

Re: [ath9k-devel] [PATCH 1/2] ath9k_htc: add STBC TX support

2013-05-02 Thread Oleksij Rempel
Am 02.05.2013 18:55, schrieb Adrian Chadd: > On 2 May 2013 01:11, Oleksij Rempel wrote: > >> +#define WLAN_RC_TX_STBC_FLAG 0x20 /* TX STBC */ >> +#define WLAN_RC_RX_STBC_FLAG 0xC0 /* RX STBC ,2 bits */ > > I thought we covered this; why are you marking two bits here? becouse firmware checks for t

Re: [ath9k-devel] [PATCH 1/2] ath9k_htc: add STBC TX support

2013-05-02 Thread Adrian Chadd
On 2 May 2013 01:11, Oleksij Rempel wrote: > +#define WLAN_RC_TX_STBC_FLAG 0x20 /* TX STBC */ > +#define WLAN_RC_RX_STBC_FLAG 0xC0 /* RX STBC ,2 bits */ I thought we covered this; why are you marking two bits here? Atheros 11n hardware only supports 1-stream STBC RX. Have you verified that we'

Re: [ath9k-devel] [PATCH 2/2] ath10k: only warn about incompatible firmware versions

2013-05-02 Thread Michal Kazior
On 02/05/13 11:02, Kalle Valo wrote: > Most of the time it does more harm than good to halt the > driver initialisation if the firmware version is not > supported. For example, sometimes it's good to test > something from older versions etc. So just change the > check to a warning. > > Signed-off-b

[ath9k-devel] [PATCH 2/2] ath10k: only warn about incompatible firmware versions

2013-05-02 Thread Kalle Valo
Most of the time it does more harm than good to halt the driver initialisation if the firmware version is not supported. For example, sometimes it's good to test something from older versions etc. So just change the check to a warning. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10

[ath9k-devel] [PATCH 1/2] ath10k: print firmware version string during boot

2013-05-02 Thread Kalle Valo
Currently we don't print firmware version at all. Move the current "firmware dowloaded" message later once firmware has booted and include firmware version in the message. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion

[ath9k-devel] [PATCH 0/2] ath10k: firmware version related changes

2013-05-02 Thread Kalle Valo
Few simple changes how we handle firmware versions. --- Kalle Valo (2): ath10k: print firmware version string during boot ath10k: only warn about incompatible firmware versions drivers/net/wireless/ath/ath10k/core.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-)

Re: [ath9k-devel] [PATCH 02/20] ath10k: Merge mac.h with core.h

2013-05-02 Thread Sujith Manoharan
Kalle Valo wrote: > Sujith Manoharan writes: > > > Kalle Valo wrote: > >> Why do you want to delete mac.h? My idea was to avoid bloating core.h > >> and that's why I wanted to have header files for each .c file. > > > > mac.h contains a few prototypes and most of the data structures are in > > c

[ath9k-devel] [PATCH 2/2] ath9k: remove useless flag conversation.

2013-05-02 Thread Oleksij Rempel
some flags used only outside of ath9k - In this case we can use "enum mac80211_rx_flags" and pass it upstream without extra conversation. Signed-off-by: Oleksij Rempel --- drivers/net/wireless/ath/ath9k/ar9003_mac.c | 5 +++-- drivers/net/wireless/ath/ath9k/mac.c| 11 +++ driver

[ath9k-devel] [PATCH 1/2] ath9k_htc: add STBC TX support

2013-05-02 Thread Oleksij Rempel
current firmware will enable STBC_TX, only if other peer support it. This patch provide ht_peer_caps to firmware. FW versions 1.3, 1.4 should be able to work with it. Tested on ar7010+ar9280 and ar7010+ar9287. Signed-off-by: Oleksij Rempel --- drivers/net/wireless/ath/ath9k/htc.h | 2 ++

[ath9k-devel] [PATCH 0/2] work sync

2013-05-02 Thread Oleksij Rempel
Hello all, this patches currently pending for review or ack. Can please some one do it untill i forgt them :) Oleksij Rempel (2): ath9k_htc: add STBC TX support ath9k: remove useless flag conversation. drivers/net/wireless/ath/ath9k/ar9003_mac.c | 5 +++-- drivers/net/wireless/ath/ath9k/

Re: [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h

2013-05-02 Thread Sujith Manoharan
Kalle Valo wrote: > The idea is that everything within ar variable can be found from core.h. > That way people don't need to track down where it's actually defined. That doesn't seem to be the way things are organized. "ar" contains instances of HTT, HTC, WMI, BMI, HIF - which all have separate he

Re: [ath9k-devel] [PATCH 02/20] ath10k: Merge mac.h with core.h

2013-05-02 Thread Kalle Valo
Sujith Manoharan writes: > Kalle Valo wrote: >> Why do you want to delete mac.h? My idea was to avoid bloating core.h >> and that's why I wanted to have header files for each .c file. > > mac.h contains a few prototypes and most of the data structures are in core.h. > I don't think core.h is gett

Re: [ath9k-devel] uart interface issues (fixed)

2013-05-02 Thread Eugene Krasnikov
Hi Oleksij, Have you tried remote debugging? Or it's only about garbing logs from the chip. Have you tried to send commands to the chip? 2013/5/2 Oleksij Rempel : > Am 28.04.2013 16:17, schrieb Oleksij Rempel: >> >> Am 28.04.2013 13:38, schrieb Adrian Chadd: >>> >>> .. is it triggering BREAK inte

Re: [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h

2013-05-02 Thread Kalle Valo
Sujith Manoharan writes: > Kalle Valo wrote: >> I would like to have have all struct ath10k substructures in core.h so >> that they don't get too much spread around. Hence I need to drop this >> patch. > > debug.h seems an appropriate place to have debug-specific structures. The idea is that eve

Re: [ath9k-devel] [PATCH] ath10k: unify header inclusion guard names

2013-05-02 Thread Kalle Valo
Bartosz Markowski writes: > Signed-off-by: Bartosz Markowski Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: Fix TXOP handling

2013-05-02 Thread Kalle Valo
Sujith Manoharan writes: > Kalle Valo wrote: >> Please add a comment. > > [PATCH v2] ath10k: Fix TXOP handling I had to edit these out manually. This kind of comments should be after '--' so that git-am can rip them out manually. > The channel time duration programmed in the HW is in absolute m

Re: [ath9k-devel] uart interface issues (fixed)

2013-05-02 Thread Oleksij Rempel
Am 02.05.2013 09:22, schrieb Eugene Krasnikov: > What kind of commands did you try to send? I will try the same with my > dongle and update you if that works or not;) all command are here: ./target_firmware/magpie_fw_dev/target/cmnos/dbg_api.c working commands: help info ram wdt rst (restart syst

Re: [ath9k-devel] [PATCH v3] ath10k: Remove unneeded locks during HTT RX attach

2013-05-02 Thread Kalle Valo
Sujith Manoharan writes: > From: Sujith Manoharan > > Fix two issues: > > * Bail out properly when RX buffer allocation fails at init time. > * Do not acquire the rx ring lock during attach() since we > don't rearm the replenish timer. > > Signed-off-by: Sujith Manoharan Thanks, applied. The

Re: [ath9k-devel] uart interface issues (fixed)

2013-05-02 Thread Eugene Krasnikov
What kind of commands did you try to send? I will try the same with my dongle and update you if that works or not;) 2013/5/2 Oleksij Rempel : > Am 02.05.2013 09:15, schrieb Eugene Krasnikov: > >> Hi Oleksij, >> >> Have you tried remote debugging? Or it's only about garbing logs from >> the chip. H

[ath9k-devel] [PATCH 8/8] ath10k: free skb if ath10k_htc_send() fails

2013-05-02 Thread Michal Kazior
Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/htc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c index 163ddc9..22abc6f 100644 --- a/drivers/net/wireless/ath/ath10

[ath9k-devel] [PATCH 7/8] ath10k: print warning on ep0 htc rx

2013-05-02 Thread Michal Kazior
Fixes possible memleak. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/htc.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c index c7ff5c3..163ddc9 100644 --- a/drivers/n

[ath9k-devel] [PATCH 5/8] ath10k: handle rx pipe post failure

2013-05-02 Thread Michal Kazior
Fixes possible memleak. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/hif.h |4 +-- drivers/net/wireless/ath/ath10k/htc.c | 23 - drivers/net/wireless/ath/ath10k/pci.c | 45 - 3 files changed, 52 insertions(+), 20 deletio

[ath9k-devel] [PATCH 6/8] ath10k: handle CE start failure

2013-05-02 Thread Michal Kazior
Fixes possible memleak. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 7efdaf1..ca09a44 100644 --- a/

[ath9k-devel] [PATCH 4/8] ath10k: handle CE init failure

2013-05-02 Thread Michal Kazior
Fixes possible memleak. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/ce.c |2 ++ drivers/net/wireless/ath/ath10k/pci.c | 14 +++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/ce.c b/drivers/net/wireless/ath/

[ath9k-devel] [PATCH 3/8] ath10k: remove old irrelevant FIXMEs

2013-05-02 Thread Michal Kazior
Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/htt.h |2 -- drivers/net/wireless/ath/ath10k/pci.c |1 - 2 files changed, 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h index dc1f88d..f3c22df 100644 --- a/driver

[ath9k-devel] [PATCH 0/8] ath10k: fixes

2013-05-02 Thread Michal Kazior
Here's a bunch of fixes that get rid of a few FIXMEs and plug some memleaks on driver setup failure paths. Michal Kazior (8): ath10k: cleanup ath10k_core_unregister() ath10k: document some spinlocks ath10k: remove old irrelevant FIXMEs ath10k: handle CE init failure ath10k: handle rx pip

[ath9k-devel] [PATCH 2/8] ath10k: document some spinlocks

2013-05-02 Thread Michal Kazior
Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/htt.h |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h index 63beff5..dc1f88d 100644 --- a/drivers/net/wireless/ath/ath10k/htt

[ath9k-devel] [PATCH 1/8] ath10k: cleanup ath10k_core_unregister()

2013-05-02 Thread Michal Kazior
Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/core.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 13ffe78..a3afb79 100644 --- a/drivers/net/wireless

Re: [ath9k-devel] uart interface issues (fixed)

2013-05-02 Thread Oleksij Rempel
Am 02.05.2013 09:15, schrieb Eugene Krasnikov: > Hi Oleksij, > > Have you tried remote debugging? Or it's only about garbing logs from > the chip. Have you tried to send commands to the chip? Yes, it works. You need this resistors to make chip start with ttl adapter attached. Without them this ch

Re: [ath9k-devel] [RFC/RFT 2/2] ath10k: add AP UAPSD support

2013-05-02 Thread Kalle Valo
Janusz Dziedzic writes: > Add support for AP (P2P_GO) UAPSD. > > Signed-off-by: Janusz Dziedzic [...] > + ath10k_dbg(ATH10K_DBG_MAC, "uapsd_queues: 0x%X, " > +"max_sp: %d\n", sta->uapsd_queues, > +sta->max_sp);

Re: [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h

2013-05-02 Thread Sujith Manoharan
Kalle Valo wrote: > I would like to have have all struct ath10k substructures in core.h so > that they don't get too much spread around. Hence I need to drop this > patch. debug.h seems an appropriate place to have debug-specific structures. Sujith ___

Re: [ath9k-devel] [RFC/RFT 1/2] ath10k: WMI add AP PS

2013-05-02 Thread Kalle Valo
Janusz Dziedzic writes: > Add AP power save (UAPSD) structures, enums. > > Signed-off-by: Janusz Dziedzic > --- > drivers/net/wireless/ath/ath10k/wmi.c | 26 + > drivers/net/wireless/ath/ath10k/wmi.h | 67 > + > 2 files changed, 93 insertions(+)

Re: [ath9k-devel] [PATCH 2/2] ath10k: Add host statistics

2013-05-02 Thread Kalle Valo
Sujith Manoharan writes: > From: Sujith Manoharan > > Signed-off-by: Sujith Manoharan [...] > +static ssize_t ath10k_read_host_stats(struct file *file, char __user > *user_buf, > + size_t count, loff_t *ppos) > +{ [...] > + if (len > buf_len) > +

Re: [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h

2013-05-02 Thread Kalle Valo
Sujith Manoharan writes: > From: Sujith Manoharan > > Signed-off-by: Sujith Manoharan I would like to have have all struct ath10k substructures in core.h so that they don't get too much spread around. Hence I need to drop this patch. -- Kalle Valo