Hi
I was looking through the list archives to find something that useful I
could contribute to wget and get familiar with the code, I have attached
a patch for the following.
Darshit Shah gmail.com> wrote on 2014-09-05 07:31:34 GMT
>The Content-Length Header is expected by the server in many
Am Sonntag, 19. Oktober 2014, 11:27:51 schrieb Matthew Atkinson:
> Hi
>
> I was looking through the list archives to find something that useful I
> could contribute to wget and get familiar with the code, I have attached
> a patch for the following.
>
> Darshit Shah gmail.com> wrote on 2014-09-0
On 19/10/14 19:34, Tim Rühsen wrote:
> There two little things - well, just kinda organizational work:
>
> 1. Please also extend src/ChangeLog and include it in your patch
> 2. The maintainers will ask you for a 'git format-patch' output
> If you never worked with that:
> - git commit your cha
Matthew Atkinson writes:
> diff --git a/src/ChangeLog b/src/ChangeLog
> index 1c4e2d5..447179e 100644
> --- a/src/ChangeLog
> +++ b/src/ChangeLog
> @@ -1,3 +1,8 @@
> +2014-10-19 Matthew Atkinson
> +
> + * http.c (gethttp): Always send Content-Length header when method is
> post,
> + e
On 20/10/14 16:26, Giuseppe Scrivano wrote:
> should we do this only for POST requests? What about doing it in any
> case that "!(opt.body_data || opt.body_file)"?
>
> Regards,
> Giuseppe
>From http://tools.ietf.org/html/rfc7230#section-3.3.2
> A user agent SHOULD send a Content-Length in a requ
Am Montag, 20. Oktober 2014, 20:08:05 schrieb Matthew Atkinson:
> On 20/10/14 16:26, Giuseppe Scrivano wrote:
> > should we do this only for POST requests? What about doing it in any
> > case that "!(opt.body_data || opt.body_file)"?
> >
> > Regards,
> > Giuseppe
>
> From http://tools.ietf.org/h
I think we should handle PUT and POST alone. And add additional logic to
handle a 411 response to any request.
Wget has traditionally supported POST requests and PUT has a very similar
usage, for anything else, the user should use the - - send-header commands.
On 20-Oct-2014 1:16 pm, "Tim Rühsen"
On 20/10/14 21:16, Tim Rühsen wrote:
> Since Wget does not explicitly support PUT, we may just care for the POST
> request. Since servers may reject a POST without Content-Length, we are
> better
> off with supplying one. Since PUT (and also PATCH) request 'anticipate' a
> body,
> we could a
Matthew Atkinson writes:
> On 20/10/14 21:16, Tim Rühsen wrote:
>
>> Since Wget does not explicitly support PUT, we may just care for the POST
>> request. Since servers may reject a POST without Content-Length, we are
>> better
>> off with supplying one. Since PUT (and also PATCH) request 'a
Am Dienstag, 21. Oktober 2014, 09:39:25 schrieb Matthew Atkinson:
> On 20/10/14 21:16, Tim Rühsen wrote:
> > Since Wget does not explicitly support PUT, we may just care for the POST
> > request. Since servers may reject a POST without Content-Length, we are
> > better off with supplying one. Since
On 21/10/14 09:48, Giuseppe Scrivano wrote:
> thanks pushed now! Congratulations on your first contribution to wget.
>
> Regards,
> Giuseppe
You sure, or am I being a bit thick? My git is pointing at
git://git.savannah.gnu.org/wget.git and not seeing it
Thanks,
Matt
On 21/10/14 09:48, Giuseppe Scrivano wrote:
> Matthew Atkinson writes:
>
>> On 20/10/14 21:16, Tim Rühsen wrote:
>>
>>> Since Wget does not explicitly support PUT, we may just care for the POST
>>> request. Since servers may reject a POST without Content-Length, we are
>>> better
>>> off wit
Matthew Atkinson writes:
> I don't think this ever got pushed.
thanks to have checked it. I've pushed it right now.
Regards,
Giuseppe
13 matches
Mail list logo
