Re: [Carbon-dev] Need some guidance, with new naming strategy.

On Mon, Sep 27, 2010 at 9:54 AM, Pradeep Fernando wrote: > Hi devs, > > > Although I know little about the new naming strategy, I still struggle with > some of these names. > Is there a document listing down these new naming conventions. > > For example. In orbit smooks bundle, its jar is named >

Re: [Carbon-dev] FindBugs hackathon on 23rd Sep 2010

On Fri, Sep 24, 2010 at 12:23 PM, Hiranya Jayathilaka wrote: > Just got started with my components. Will finish off over the weekend. > > Thanks, > > Hiranya, Are you done with the components ? Other wise I can look into couple of them. Rajika ___ Carbo

Re: [Carbon-dev] FindBugs hackathon on 23rd Sep 2010

Please refrain from adding the bug count in generated code to the spreadsheet. The generated code is not part of the code we have written, and in this exercise, we are not interested in it. Of course, the code generation templates need to be fixed, but that will be a different exercise altogether.

Re: [Carbon-dev] Need some guidance, with new naming strategy.

On Mon, Sep 27, 2010 at 11:13 AM, Pradeep Fernando wrote: > Adding to this, > > > The version used in carbon 3.0.0 , orbit/savan-core is 1.1.0wso2v1, & the > version in carbon trunk is 1.0.0wso2v2. > The trunk version should be 1.1.0wso2v2 right? > Seems like savan-core version is not updated i

Re: [Carbon-dev] Carbon 3.0.1 RC3 Build

Hi, Yeah, Amani is looking into this right now. - Anjana. On Mon, Sep 27, 2010 at 10:37 AM, Charitha Kankanamge wrote: > Can we fix this and rebuild the DS pack? > > Regards > Charitha > > > > > On Fri, Sep 24, 2010 at 6:28 PM, Asela Pathberiya wrote: > >> Hi Anjana, >> >> I am getting followin

Re: [Carbon-dev] Need some guidance, with new naming strategy.

Adding to this, The version used in carbon 3.0.0 , orbit/savan-core is 1.1.0wso2v1, & the version in carbon trunk is 1.0.0wso2v2. The trunk version should be 1.1.0wso2v2 right? -Pradeep On Mon, Sep 27, 2010 at 9:54 AM, Pradeep Fernando wrote: > Hi devs, > > > Although I know little about th

Re: [Carbon-dev] [Stratos-dev] No more committing code without running FindBugs

It will be great if we can implement that. Azeez On Mon, Sep 27, 2010 at 11:06 AM, Senaka Fernando wrote: > > > On Mon, Sep 27, 2010 at 10:43 AM, Afkham Azeez wrote: > >> Hi Team, >> We have made a significant investment in fixing up our code using >> FindBugs. In order to maintain this, we

Re: [Carbon-dev] [Carbon-commits] [Carbon-Components] svn commit r74208 - trunk/carbon/components/bpel/org.wso2.carbon.bpel/src/main/java/org/wso2/carbon/bpel/ode/integration/store

On Mon, Sep 27, 2010 at 1:34 AM, Milinda Pathirage wrote: > > > On Mon, Sep 27, 2010 at 10:49 AM, Sumedha Rubasinghe wrote: > >> >> >> On Mon, Sep 27, 2010 at 1:15 AM, Milinda Pathirage wrote: >> >>> Ran the FindBugs, no bugs were found on latest modifications. >> >> >> Milinda, >> Can there be b

Re: [Carbon-dev] [Stratos-dev] No more committing code without running FindBugs

On Mon, Sep 27, 2010 at 10:43 AM, Afkham Azeez wrote: > Hi Team, > We have made a significant investment in fixing up our code using FindBugs. > In order to maintain this, we need to run all the modified code through > FindBugs before committing, henceforth. > Yes, +1. This should be mandatory.

Re: [Carbon-dev] [Carbon-commits] [Carbon-Components] svn commit r74208 - trunk/carbon/components/bpel/org.wso2.carbon.bpel/src/main/java/org/wso2/carbon/bpel/ode/integration/store

On Mon, Sep 27, 2010 at 10:49 AM, Sumedha Rubasinghe wrote: > > > On Mon, Sep 27, 2010 at 1:15 AM, Milinda Pathirage wrote: > >> Ran the FindBugs, no bugs were found on latest modifications. > > > Milinda, > Can there be bugs in your code that FindBugs cannot find? > Yes, there can be bugs that F

Re: [Carbon-dev] [Stratos-dev] WS-Discovery API via CarbonContext

On Mon, Sep 27, 2010 at 9:27 AM, Hiranya Jayathilaka wrote: > > > On Mon, Sep 27, 2010 at 8:35 AM, Afkham Azeez wrote: > >> Hi Senaka, >> Have you started working on this? If not, I can start looking at this. >> > > A basic interface has been added to Carbon. But IMO that needs some > changes. Fo

[Carbon-dev] Build Failure!

I'm getting the following error while building rule component! [INFO] [ERROR] BUILD FAILURE [INFO] [INFO] Compilation failure /home/disk1/CarbonNew/car

Re: [Carbon-dev] FindBugs hackathon on 23rd Sep 2010

Hi, Sample code is below. You need to import org.apache.commons.io.IOUtils. FileInputStream fileInputStream = null; OutputStream outputStream = null; try { outputStream = response.getOutputStream(); fileInputStream = new FileInputStream(file);

[Carbon-dev] Build Error

I get this error while building eventing component after doing a svn update. [ERROR] BUILD FAILURE [INFO] [INFO] Compilation failure /opt/builds/carbon/components/eventing/org.wso2.carbon.eventing.eventsource/src/main/java/o

Re: [Carbon-dev] [Carbon-commits] [Carbon-Components] svn commit r74208 - trunk/carbon/components/bpel/org.wso2.carbon.bpel/src/main/java/org/wso2/carbon/bpel/ode/integration/store

On Mon, Sep 27, 2010 at 1:15 AM, Milinda Pathirage wrote: > Ran the FindBugs, no bugs were found on latest modifications. Milinda, Can there be bugs in your code that FindBugs cannot find? /sumedha > > Thanks > Milinda > > > On Mon, Sep 27, 2010 at 10:39 AM, Afkham Azeez wrote: > >> Milinda,

Re: [Carbon-dev] [Carbon-commits] [Carbon-Components] svn commit r74208 - trunk/carbon/components/bpel/org.wso2.carbon.bpel/src/main/java/org/wso2/carbon/bpel/ode/integration/store

Ran the FindBugs, no bugs were found on latest modifications. Thanks Milinda On Mon, Sep 27, 2010 at 10:39 AM, Afkham Azeez wrote: > Milinda, > Did you run FindBugs on the modified code before committing? > > Azeez > > > > On Mon, Sep 27, 2010 at 9:07 AM, wrote: > >> Author: milinda >> Date: S

[Carbon-dev] No more committing code without running FindBugs

Hi Team, We have made a significant investment in fixing up our code using FindBugs. In order to maintain this, we need to run all the modified code through FindBugs before committing, henceforth. Thanks -- *Afkham Azeez* Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com, *

Re: [Carbon-dev] [Carbon-commits] [Carbon-Components] svn commit r74208 - trunk/carbon/components/bpel/org.wso2.carbon.bpel/src/main/java/org/wso2/carbon/bpel/ode/integration/store

Milinda, Did you run FindBugs on the modified code before committing? Azeez On Mon, Sep 27, 2010 at 9:07 AM, wrote: > Author: milinda > Date: Sun Sep 26 20:37:43 2010 > New Revision: 74208 > URL: http://wso2.org/svn/browse/wso2?view=rev&revision=74208 > > Log: > Some minor refactorings to Ten

Re: [Carbon-dev] Carbon 3.0.1 RC3 Build

Can we fix this and rebuild the DS pack? Regards Charitha On Fri, Sep 24, 2010 at 6:28 PM, Asela Pathberiya wrote: > Hi Anjana, > > I am getting following error [1] when building DS from parent product > pom.xml (in builder machine) . But this would not occur when i am building > it from dist

Re: [Carbon-dev] FindBugs hackathon on 23rd Sep 2010

Yes, if that is better, and if we don't have to introduce a dependency just to do this. Can you post the relevant sample code segment? Azeez On Mon, Sep 27, 2010 at 10:23 AM, Ruchira Wageesha wrote: > Hi, > > I also encountered the same error in mashup components. But, I used the > commons-io

Re: [Carbon-dev] FindBugs hackathon on 23rd Sep 2010

Hi, I also encountered the same error in mashup components. But, I used the commons-io for that. i.e. org.apache.commons.io.IOUtils.closeQuietly(fileWriter); where try-catch within the following final block has been wrapped within IOUtils class. I decided to use above method as it gives us a mor

[Carbon-dev] Need some guidance, with new naming strategy.

Hi devs, Although I know little about the new naming strategy, I still struggle with some of these names. Is there a document listing down these new naming conventions. For example. In orbit smooks bundle, its jar is named as smooks-1.2.4.wso2v1-SNAPSHOT in the trunk. In the 3.0.0 branch it is

Re: [Carbon-dev] [Stratos-dev] WS-Discovery API via CarbonContext

On Mon, Sep 27, 2010 at 8:35 AM, Afkham Azeez wrote: > Hi Senaka, > Have you started working on this? If not, I can start looking at this. > A basic interface has been added to Carbon. But IMO that needs some changes. For instance it doesn't provide a means to pass in the WS-D proxy URL. Thanks

[Carbon-dev] WS-Discovery API via CarbonContext

Hi Senaka, Have you started working on this? If not, I can start looking at this. -- *Afkham Azeez* Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com, * * *Member; Apache Software Foundation; **http://www.apache.org/* * email: **az...@wso2.com* * cell

Re: [Carbon-dev] FindBugs hackathon on 23rd Sep 2010

On Mon, Sep 27, 2010 at 8:06 AM, Afkham Azeez wrote: > Sure that is OK. But folks, we need to remember that writing quality code > is as much as, or more important, than simply releasing stuff. And do it the FIRST time you code, so that you do not have to fix it over and over again :) > It

Re: [Carbon-dev] FindBugs hackathon on 23rd Sep 2010

OK. I based my comments on some code I was looking at where there were multiple methods in a single class, and in each method, some result sets were traversed, and in a finally block, the result set & statement were closed. In that type of code, I think it may not be necessary to close result sets,

Re: [Carbon-dev] FindBugs hackathon on 23rd Sep 2010

On Sat, Sep 25, 2010 at 1:22 PM, Afkham Azeez wrote: > Please note that it is not necessary to close both the ResultSet and > Statement. When Statement#close is called, the ResultSets generated by those > Statements are also closed. Please refer to the JavaDocs > of java.sql.Statement Hi Azeez,

Re: [Carbon-dev] Adding Pretty Printing and Syntax Highlighting capability to Registry Browser

Can one of you guys please integrate EditArea into the SOAP tracer? Our XML viewers/editors should be consistent. Azeez On Sun, Sep 26, 2010 at 10:28 PM, Chanaka Jayasena wrote: > > > On Sun, Sep 26, 2010 at 10:06 PM, Denis Weerasiri wrote: > >> >> >> On Sun, Sep 26, 2010 at 9:10 PM, Kasun I

Re: [Carbon-dev] build wsas source

On Mon, Sep 27, 2010 at 7:52 AM, Samisa Abeysinghe wrote: > > > On Mon, Sep 27, 2010 at 7:16 AM, Sameera Jayasoma wrote: > >> If you need to build WSAS 3.2.1, the latest release based on Carbon 3.0.1, >> you need to build the Carbon 3.0.0 tag first as mentioned by Asela, >> > > Well, we need to

Re: [Carbon-dev] FindBugs hackathon on 23rd Sep 2010

Sure that is OK. But folks, we need to remember that writing quality code is as much as, or more important, than simply releasing stuff. It is perfectly OK to spend some extra time to think about how to implement something in a better, and maintainable way. The long term benefits will be immense.

Re: [Carbon-dev] build wsas source

On Mon, Sep 27, 2010 at 7:16 AM, Sameera Jayasoma wrote: > If you need to build WSAS 3.2.1, the latest release based on Carbon 3.0.1, > you need to build the Carbon 3.0.0 tag first as mentioned by Asela, > Well, we need to deploy these to repos, now that we have done Chunk1 releases. People sho

Re: [Carbon-dev] build wsas source

If you need to build WSAS 3.2.1, the latest release based on Carbon 3.0.1, you need to build the Carbon 3.0.0 tag first as mentioned by Asela, Sameera On Sun, Sep 26, 2010 at 11:45 PM, Asela Pathberiya wrote: > Hi Amila, > > On Sun, Sep 26, 2010 at 6:50 PM, Amila Liyanaarachchi > wrote: > >>

Re: [Carbon-dev] FindBugs hackathon on 23rd Sep 2010

Hi Azeez, Find answers, in-line. In addition all skipped rules are listed in [1]. Let me know if there are any invalid cases. Thanks AmilaJ [1] https://svn.wso2.org/repos/wso2/trunk/carbon/core/org.wso2.carbon.user.core/user-core-findbugs-excluded.xml Afkham Azeez wrote: > > > > > On Fr

Re: [Carbon-dev] FindBugs hackathon on 23rd Sep 2010

Hi Azeez, I am working on Identity components. Thanks, Asela. On Fri, Sep 24, 2010 at 12:22 PM, Afkham Azeez wrote: > There is no need for everybody to sit in one place and do this. We have the > IRC channel now. It is as good as being f2f. The plan was for everybody to > allocate sometime on

Re: [Carbon-dev] build wsas source

Hi Amila, On Sun, Sep 26, 2010 at 6:50 PM, Amila Liyanaarachchi wrote: > Hi Dev, > > I'm a newbie to building carbon, I'm trying to build wsas from the source ( > https://wso2.org/repos/wso2/branches/carbon/3.0.0/) > First of all I'm not sure whether I did it in the correct way, following is > wh

Re: [Carbon-dev] Adding Pretty Printing and Syntax Highlighting capability to Registry Browser

For XML Pretty Printer - components/proxy-admin/org.wso2.carbon.proxyadmin.ui/src/main/resources/web/proxyservices/index.jsp EditArea - components/endpoint/org.wso2.carbon.endpoint.ui/src/main/resources/web/endpoints/endpointSourceView.jsp On Sun, Sep 26, 2010 at 10:06 PM, Denis Weerasiri wrote:

Re: [Carbon-dev] FindBugs hackathon on 23rd Sep 2010

Hi Azeez, We'll be (tooling team) starting to fix issues from find bugs from tomorrow onwards. Since the tooling code base is considerably huge & the looming releases we cannot predict when we'll be able to finish it. Which would probably mean it'll take more than this week. Saminda On Sun, Sep

Re: [Carbon-dev] FindBugs hackathon on 23rd Sep 2010

I went through following esb components and fixed the issues. Remaining issues in these components are due to code generation. proxy-admin endpoint localentry priority mediation message-relay There are few issues left in mediation-initializer to be fixed. Thanks, Supun.. On Sun, Sep 26, 2010 a

Re: [Carbon-dev] Adding Pretty Printing and Syntax Highlighting capability to Registry Browser

On Sun, Sep 26, 2010 at 10:06 PM, Denis Weerasiri wrote: > > > On Sun, Sep 26, 2010 at 9:10 PM, Kasun Indrasiri wrote: > >> Hi all, >> >> How about $subject for resources with media type 'application/xml'? IMO, >> since we are dealing with many registry resources with media type of >> applicatio

Re: [Carbon-dev] Adding Pretty Printing and Syntax Highlighting capability to Registry Browser

On Sun, Sep 26, 2010 at 9:10 PM, Kasun Indrasiri wrote: > Hi all, > > How about $subject for resources with media type 'application/xml'? IMO, > since we are dealing with many registry resources with media type of > application/xml, we can present the resource content in better way. > If there ar

Re: [Carbon-dev] FindBugs hackathon on 23rd Sep 2010

Hi Azeez, I'm traveling at the moment. However, I have completed all the components that I assigned to me. I'll try to do some fixing when I get some free time. Thanks, Senaka. On Fri, Sep 24, 2010 at 9:57 AM, Afkham Azeez wrote: > Folks, > I'd like to see more enthusiasm in this area. I'm sur

[Carbon-dev] Adding Pretty Printing and Syntax Highlighting capability to Registry Browser

Hi all, How about $subject for resources with media type 'application/xml'? IMO, since we are dealing with many registry resources with media type of application/xml, we can present the resource content in better way. If there aren't any limitations, we can simply use org.wso2.carbon.utils.xml.XML

[Carbon-dev] build wsas source

Hi Dev, I'm a newbie to building carbon, I'm trying to build wsas from the source ( https://wso2.org/repos/wso2/branches/carbon/3.0.0/) First of all I'm not sure whether I did it in the correct way, following is what I have done so far. 1. built carbon\dependencies (mvn clean install -Dtest=false