[PATCH] D149504: [clang][CodeGenPGO] Don't use an invalid index when region counts disagree

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG220e77a83af1: [clang][CodeGenPGO] Dont use an invalid index when region counts disagree (authored by lanza). Changed prior to commit:

[PATCH] D149504: [clang][CodeGenPGO] Don't use an invalid index when region counts disagree

lanza added a comment. Actually, this still is consumed even without that flag being passed. Anybody know the rational for not having at least an llvm major version check here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149504/new/

[PATCH] D149504: [clang][CodeGenPGO] Don't use an invalid index when region counts disagree

lanza created this revision. lanza added a reviewer: bruno. Herald added subscribers: wlei, wenlei, arphaman. Herald added a project: All. lanza requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we're using an old instrprof profile and

[PATCH] D127269: Add llvm's Support lib to the psuedoCXX library

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd2f2909188b: Add llvms Support lib to the psuedoCXX library (authored by lanza). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127269/new/

[PATCH] D127269: Add llvm's Support lib to the psuedoCXX library

lanza created this revision. Herald added a subscriber: mgorny. Herald added a project: All. lanza requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This is failing to find `EnableABIBreakingCheck` at link time. Add Support to

[PATCH] D107944: [hmaptool] Port to python3

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bd4dc4f2854: [hmaptool] Port to python3 (authored by lanza). Changed prior to commit: https://reviews.llvm.org/D107944?vs=388568=388668#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D107944: [hmaptool] Port to python3

lanza updated this revision to Diff 388568. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107944/new/ https://reviews.llvm.org/D107944 Files: clang/utils/hmaptool/hmaptool Index: clang/utils/hmaptool/hmaptool === ---

[PATCH] D107944: [hmaptool] Port to python3

lanza created this revision. lanza requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is just a few trivial changes -- change the interpreter and fix a few byte-vs-string issues. Repository: rG LLVM Github Monorepo

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

lanza added a comment. Hey Fangrui, is there any reason this couldn't extend to armv7? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101873/new/ https://reviews.llvm.org/D101873 ___ cfe-commits mailing

[PATCH] D93273: [CodeGen][ObjC] Destroy callee-destroyed arguments in the caller function when the receiver is nil

lanza added a comment. Hey @ahatanak, I've ran into this problem in my companies projects and was wondering what the status of this patch is? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93273/new/ https://reviews.llvm.org/D93273

[PATCH] D91874: [GNU ObjC] Fix a regression listing methods twice.

lanza accepted this revision. lanza added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91874/new/ https://reviews.llvm.org/D91874 ___

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:2181 + /// This is true iff the protocol is tagged with the `objc_static_protocol` + /// attribute. kastiglione wrote: > This comment refers to the original spelling. Yes indeed,

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14f6bfcb52e7: [clang] Implement objc_non_runtime_protocol to

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza updated this revision to Diff 295911. lanza added a comment. Clean clang-tidy warnings before landing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza updated this revision to Diff 295876. lanza added a comment. Comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 Files: clang/include/clang/AST/DeclObjC.h clang/include/clang/Basic/Attr.td

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:487 + + // Walk both lists to get the full set of implied protocols + llvm::DenseSet AllImpliedProtocols; rjmccall wrote: > You should add something like ", including all the runtime

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza requested review of this revision. lanza marked an inline comment as done. lanza added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:490 + llvm::UniqueVector FoundProtocols; + std::set DeclaredProtocols; + rjmccall wrote: > You should use

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza updated this revision to Diff 295729. lanza added a comment. Update with John's suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:466 + for (; begin != end; ++begin) +AppendFirstRuntimeProtocols(*begin, PDs); + rjmccall wrote: > Should this make an effort to avoid declaring redundant bases? e.g. > > ``` >

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza marked 5 inline comments as done. lanza added a comment. Fixed and added a test under the `REDUNDANCY` prefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza updated this revision to Diff 294207. lanza added a comment. Fix duplicate inheritance issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. @theraven @rjmccall should be ready for review whenever you guys are ready! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 ___

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza updated this revision to Diff 293944. lanza added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 Files: clang/include/clang/AST/DeclObjC.h clang/include/clang/Basic/Attr.td

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. > Hmm, I thought we actually just generated a bogus definition for the protocol > when it was forward-declared; really, this is better behavior that I > expected. Regardless, I don't think it's worthwhile to diagnose this more > strongly than a warning because of the

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. > I don't think it'll actually error out at link time: protocol objects get > emitted eagerly on use, cross-module linking is just a code-size > optimization. This actually has caused longstanding problems. But if it's just a forward declaration there's nothing to emit.

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. A concern that has come up while rewriting this for the listed concerns is forward declared protocols that are defined as `non_runtime`. @protocol NonRuntimeProto; @interface Implementer : Root @end @implementation Implementer ... @end This compiles

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

lanza added a comment. > This change provides a codegen options flag to clang > -fobjc-export-direct-method-wrappers to generate the wrapper functions that > begin with the prefix objc_direct_wrapper and are marked as > attribute__((alwaysinline)). This way within a link unit the wrapper >

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. No problem! Thank you, John! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. ping @rjmccall. Any update on a timeline for this review process? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 ___ cfe-commits

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. @rjmccall Hey John, I sent the proposal to the addresses I was pointed to but haven't heard back in multiple weeks. Any update on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. > If someone writes up a short proposal for this, with motivation and impact, > we'd be happy to present it internally. I have a rough draft that I'll be touching up and submitting Monday most likely! Thanks, John! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza updated this revision to Diff 252706. lanza added a comment. Rename and address some issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza updated this revision to Diff 252707. lanza added a comment. Reword commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza marked an inline comment as done. lanza added a comment. > Adding some more knowledgeable reviewers for comments on your RFC. I pointed > out a few minor nits, but I'll hold off on a technical review until the > ObjC-specific details are worked out and there is buy-in on the feature.

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Motivated by the new objc_direct attribute, this change aims to limit metadata generation from Protocols that the programmer knows isn't going to be used at runtime. This attribute simply causes

[PATCH] D64772: Allow for vendor prefixes in a list test

lanza updated this revision to Diff 210004. lanza added a comment. rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64772/new/ https://reviews.llvm.org/D64772 Files: test/Preprocessor/init.c Index: test/Preprocessor/init.c

[PATCH] D64772: Allow for vendor prefixes in a list test

This revision was automatically updated to reflect the committed changes. Closed by commit rL366159: Allow for vendor prefixes in a list test (authored by lanza, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D64772: Allow for vendor prefixes in a list test

lanza created this revision. Herald added subscribers: cfe-commits, fedor.sergeev. Herald added a project: clang. Preprocessor/init.c contains a line that explicitly checks for the string __VERSION__ "Clang{{.*}} It's valid to have a toolchain configured to emit a vendor prefix before the word