Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

2016-08-17 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL278949: [Include-fixer] Install executables and support scripts (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D23045?vs=66414&id=68384#toc Repository: rL LLVM https:

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

2016-08-17 Thread Haojian Wu via cfe-commits
hokein added a comment. Sorry for the delay. I totally missed it. Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22 @@ +21,2 @@ + DESTINATION share/clang + COMPONENT find-all-symbols) Eugene.Zelenko wrote: > hokein wrote: > > I think we can put

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

2016-08-12 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a comment. Ping. I could not proceed until my question answered. Repository: rL LLVM https://reviews.llvm.org/D23045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

2016-08-02 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added inline comments. Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22 @@ +21,2 @@ + DESTINATION share/clang + COMPONENT find-all-symbols) hokein wrote: > I think we can put it in `clang-include-fixer` as find-all-symbols is a >

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

2016-08-02 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22 @@ +21,2 @@ + DESTINATION share/clang + COMPONENT find-all-symbols) I think

[PATCH] D23045: [Include-fixer] Install executables and support scripts

2016-08-01 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: ioeric, bkramer, hokein. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I tested this changes on my RHEL 6 build. Repository: rL LLVM https://reviews.llvm.org/