This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf4ba7a100a56: [clangd] Semantic highlighting for dependent
template name in template argument (authored by nridge).
Repository:
rG LLVM Github Mon
nridge marked an inline comment as done.
nridge added inline comments.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:305
+ break;
+default:;
+}
nridge wrote:
> hokein wrote:
> > nit: move the trailing `;` to a new line.
> I have done
nridge updated this revision to Diff 283784.
nridge added a comment.
Address nit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85272/new/
https://reviews.llvm.org/D85272
Files:
clang-tools-extra/clangd/SemanticHighlighting.cpp
clang-tools-extr
nridge added inline comments.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:305
+ break;
+default:;
+}
hokein wrote:
> nit: move the trailing `;` to a new line.
I have done this, but clang-format moves it back... do we really want to
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:305
+ break;
+default:;
+}
nit: move the trailing `;` to a new line.
Reposit
nridge created this revision.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous.
Herald added a project: clang.
nridge requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D8
