This revision was automatically updated to reflect the committed changes.
Closed by commit rL339375: [Sema] P0961R1: Relaxing the structured bindings
customization point finding… (authored by epilk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with a small bugfix.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1122
+for (Decl *D : MemberGet) {
+ if (FunctionTemplateDecl *FTD = dyn_cast(D)) {
+
erik.pilkington added inline comments.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1118-1130
+// ... and if that finds at least one declaration that is a function
+// template whose first template parameter is a non-type parameter ...
+LookupResult::Filter Filter
erik.pilkington updated this revision to Diff 159629.
erik.pilkington added a comment.
Address review comments.
https://reviews.llvm.org/D50418
Files:
clang/lib/Sema/SemaDeclCXX.cpp
clang/test/CXX/dcl.decl/dcl.decomp/p3.cpp
clang/www/cxx_status.html
Index: clang/www/cxx_status.html
rsmith added inline comments.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1118-1130
+// ... and if that finds at least one declaration that is a function
+// template whose first template parameter is a non-type parameter ...
+LookupResult::Filter Filter =
erik.pilkington created this revision.
erik.pilkington added a reviewer: rsmith.
Herald added a subscriber: dexonsmith.
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0961r1.html
I don't believe an actual defect report was filed for this, but the paper (in
the "wording" section)
