[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

2020-05-28 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd283fc4f9d07: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80554

[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

2020-05-27 Thread Adrian McCarthy via Phabricator via cfe-commits
amccarth marked an inline comment as done. amccarth added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:242 +// SplitTemplateClosers yields better interop with GCC and GDB (PR46052). +PP.SplitTemplateClosers = true; } sammccall wrote:

[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

2020-05-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:242 +// SplitTemplateClosers yields better interop with GCC and GDB (PR46052). +PP.SplitTemplateClosers = true; } amccarth wrote:

[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

2020-05-26 Thread Adrian McCarthy via Phabricator via cfe-commits
amccarth added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:242 +// SplitTemplateClosers yields better interop with GCC and GDB (PR46052). +PP.SplitTemplateClosers = true; } So, in other words, we'll always set `PP.SplitTemplateCloser

[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

2020-05-26 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80554/new/ https://reviews.llvm.org/D80554 ___

[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

2020-05-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: dblaikie, labath. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. D76801 caused some regressions in debuginfo compatibility by changing how certain functions were named. F