[cp-patches] RFC: NetworkInterface - implement some 1.6 methods

2008-04-21 Thread Robert Schuster
Hi, people using Jalimo asked for those methods and I found them simple to implement. Since I am lousy non-Java hacker I appreciate comments on the code in java_net_VMNetworkInterface.c. Regards Robert 2008-04-21 Robert Schuster <[EMAIL PROTECTED]> * java/net/NetworkInterface.java: (isUp)

Re: [cp-patches] RFC: NetworkInterface - implement some 1.6 methods

2008-04-21 Thread Christian Thalinger
On Mon, 2008-04-21 at 09:03 +0200, Robert Schuster wrote: > + public boolean isUp() > +throws SocketException > + { > +return VMNetworkInterface.isUp(netif.name); > + } > + public boolean isPointToPoint() > +throws SocketException > + { > +return VMNetworkInterface.isUp(netif.

Re: [cp-patches] RFC: NetworkInterface - implement some 1.6 methods

2008-04-21 Thread Robert Schuster
Hi, I fixed the copy and paste error and another flaw. Casting to jboolean did not alway returned the correct result. I made the if-flag-set then JNI_TRUE otherwise JNI_FALSE explicit. Now it works correctly. Christian Thalinger schrieb: > I wonder if it would be simpler to only have one native me

Re: [cp-patches] RFC: NetworkInterface - implement some 1.6 methods

2008-04-21 Thread Christian Thalinger
On Mon, 2008-04-21 at 09:03 +0200, Robert Schuster wrote: > Hi, > people using Jalimo asked for those methods and I found them simple to > implement. > > Since I am lousy non-Java hacker I appreciate comments on the code in > java_net_VMNetworkInterface.c. I wonder if it would be simpler to only

Re: [cp-patches] RFC: NetworkInterface - implement some 1.6 methods

2008-04-22 Thread Robert Schuster
Hi. Robert Schuster schrieb: > Hi, > I fixed the copy and paste error and another flaw. Casting to jboolean > did not alway returned the correct result. I made the if-flag-set then > JNI_TRUE otherwise JNI_FALSE explicit. Now it works correctly. If no one objects I would like to commit this patch.

Re: [cp-patches] RFC: NetworkInterface - implement some 1.6 methods

2008-05-15 Thread Robert Schuster
Hi, I committed this today. 2008-05-15 Robert Schuster <[EMAIL PROTECTED]> * java/net/NetworkInterface.java: (isUp): New method. (isPointToPoint): Dito. (isLoopback): Dito. (supportsMulticast): Dito. * vm/reference/java/net/VMNetworkInterface.java: (isUp): New method. (isPointTo

Re: [cp-patches] RFC: NetworkInterface - implement some 1.6 methods

2008-05-16 Thread Andrew John Hughes
2008/5/15 Robert Schuster <[EMAIL PROTECTED]>: > Hi, > I committed this today. > > 2008-05-15 Robert Schuster <[EMAIL PROTECTED]> > > > * java/net/NetworkInterface.java: > (isUp): New method. > (isPointToPoint): Dito. > (isLoopback): Dito. > (supportsMulticast): Dito. > * vm/referen