Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L&F [v2]

2024-05-29 Thread Abhishek Kumar
On Thu, 30 May 2024 06:45:26 GMT, Tejesh R wrote: >> Actually it is not unused and is run on the background thread to `allow >> enough time for visual verification`. I will check once in the CI testing >> after removing this method and if there is no failure, it can be removed. > > I verified w

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L&F [v2]

2024-05-29 Thread Tejesh R
On Thu, 30 May 2024 06:40:43 GMT, Abhishek Kumar wrote: >> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 159: >> >>> 157: } >>> 158: >>> 159: public void onBackgroundThread30() { >> >> Unused, can be removed? > > Actually it is not unused and is run on the background thread

Integrated: 8327401: Some jtreg tests fail on Wayland without any tracking bug

2024-05-29 Thread Alexander Zvegintsev
On Wed, 22 May 2024 02:25:14 GMT, Alexander Zvegintsev wrote: > These changes are intended to stabilize testing on Wayland in X11 > compatibility mode. > > > > Many tests may fail if there is no `robot.delay()` call after > `robot.waitForIdle()` (right after displaying a window). > > > So

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L&F [v2]

2024-05-29 Thread Abhishek Kumar
> bug6492108.java test always fails in GTK L&F in single as well as dual screen > linux machines. Since this test was not marked as "_headful_" in it's initial > version, it never failed but after the fix of > [JDK-8287051](https://bugs.openjdk.org/browse/JDK-8287051) this test was > problem li

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L&F [v2]

2024-05-29 Thread Abhishek Kumar
On Thu, 30 May 2024 06:10:29 GMT, Tejesh R wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comment update > > test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 47: > >> 45: * JTextArea,

client-libs-dev@openjdk.org

2024-05-29 Thread Tejesh R
On Fri, 24 May 2024 06:44:06 GMT, Abhishek Kumar wrote: > bug6492108.java test always fails in GTK L&F in single as well as dual screen > linux machines. Since this test was not marked as "_headful_" in it's initial > version, it never failed but after the fix of > [JDK-8287051](https://bugs.o

Re: RFR: 8332103: Add missing `@since` tags to `java.desktop`

2024-05-29 Thread Nizar Benalla
On Wed, 29 May 2024 11:38:02 GMT, Alexey Ivanov wrote: > Why is it? There's history beyond 10 and 9 As I've explained before, a program relying on the historical data built into `javac` can only give accurate reports for newer releases. As that data only goes back so far. I was left to investi

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v15]

2024-05-29 Thread Alexander Scherbatiy
On Wed, 29 May 2024 06:52:52 GMT, Prasanta Sadhukhan wrote: >> Alexander Scherbatiy has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Move OutputBin import before PageRanges in RasterPrinterJob >> - Add item listener to cbOutput only

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-29 Thread Alexander Scherbatiy
On Wed, 29 May 2024 20:14:06 GMT, Alexander Scherbatiy wrote: >> What about this support? > > Actually it is not clear for me which maximum N should be used for these > constants. > Should only `tray-1`, `tray-2`, and `tray-3` be added, or should there be > constants `tray-1` ... `tray-5` or e

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-29 Thread Alexander Scherbatiy
On Wed, 29 May 2024 06:49:31 GMT, Prasanta Sadhukhan wrote: >> src/java.desktop/share/classes/javax/print/attribute/standard/OutputBin.java >> line 154: >> >>> 152: FACE_UP, >>> 153: FACE_DOWN, >>> 154: LARGE_CAPACITY, >> >> What about this support from IPP

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v16]

2024-05-29 Thread Alexander Scherbatiy
> The fix adds new public `OutputBin` print attribute class which allow to set > a printer output bin in a `PrinterJob` class. The corresponding internal > `CustomOutputBin` class is added as well. > > - Constants used in `OutputBin` class are based on [Internet Printing > Protocol (IPP): “outp

Re: RFR: 8332103: Add missing `@since` tags to `java.desktop` [v2]

2024-05-29 Thread Alexey Ivanov
On Tue, 14 May 2024 23:36:13 GMT, Nizar Benalla wrote: >> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java >> line 154: >> >>> 152: * Constructs a {@code BasicSliderUI}. >>> 153: * >>> 154: * @since 16 >> >> Hmm, the *explicit* default constructor was add

Re: RFR: 8332103: Add missing `@since` tags to `java.desktop`

2024-05-29 Thread Alexey Ivanov
On Tue, 14 May 2024 23:45:23 GMT, Nizar Benalla wrote: > but for older code you can only guess "Element: X existed before JDK 10". So > I was left to check on my own, and made a mistake. Why is it? There's history beyond 10 and 9, yet accessing it requires more effort. In addition to that, old

Re: RFR: 8327401: Some jtreg tests fail on Wayland without any tracking bug [v3]

2024-05-29 Thread Alexander Zvegintsev
> These changes are intended to stabilize testing on Wayland in X11 > compatibility mode. > > > > Many tests may fail if there is no `robot.delay()` call after > `robot.waitForIdle()` (right after displaying a window). > > > Some tests do not release previously pressed mouse button/key, this

Re: RFR: 8327401: Some jtreg tests fail on Wayland without any tracking bug [v2]

2024-05-29 Thread Andrey Turbanov
On Wed, 22 May 2024 21:52:14 GMT, Alexander Zvegintsev wrote: >> These changes are intended to stabilize testing on Wayland in X11 >> compatibility mode. >> >> >> >> Many tests may fail if there is no `robot.delay()` call after >> `robot.waitForIdle()` (right after displaying a window). >>

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v15]

2024-05-29 Thread Prasanta Sadhukhan
On Tue, 28 May 2024 16:47:21 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in `Out

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-29 Thread Prasanta Sadhukhan
On Mon, 20 May 2024 06:48:15 GMT, Prasanta Sadhukhan wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make OutputBin class sealed > > src/java.desktop/share/classes/javax/print/attribute/standard/OutputBin.