Re: RFR: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS [v2]

2023-12-05 Thread Alexey Ivanov
On Tue, 5 Dec 2023 20:32:49 GMT, Phil Race wrote: >> With JDK 17, I still see the exception: >> >> >> Exception in thread "main" java.awt.print.PrinterException >> at java.desktop/sun.lwawt.macosx.CPrinterJob.print(CPrinterJob.java:393) >> at PrinterDevice.main(PrinterDevice.java:68)

Re: RFR: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS [v2]

2023-12-05 Thread Phil Race
On Tue, 5 Dec 2023 20:25:46 GMT, Alexey Ivanov wrote: >> On JDK 17 and earlier you will reach this line with this test as written >> And without that exception, the test would pass when it should fail. > > With JDK 17, I still see the exception: > > > Exception in thread "main"

Re: RFR: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS [v2]

2023-12-05 Thread Alexey Ivanov
On Tue, 5 Dec 2023 20:07:56 GMT, Phil Race wrote: >> test/jdk/java/awt/print/PrinterJob/PrinterDevice.java line 71: >> >>> 69: if (failed) { >>> 70: throw new RuntimeException("Test failed but no exception >>> propagated."); >>> 71: } >> >> A comment that

Re: RFR: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS [v2]

2023-12-05 Thread Alexander Zvegintsev
On Tue, 5 Dec 2023 19:41:54 GMT, Alexey Ivanov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8320443 > > test/jdk/java/awt/print/PrinterJob/PrinterDevice.java line 52: > >> 50: public class PrinterDevice

Re: RFR: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS [v2]

2023-12-05 Thread Phil Race
On Tue, 5 Dec 2023 20:07:15 GMT, Alexander Zvegintsev wrote: >> test/jdk/java/awt/print/PrinterJob/PrinterDevice.java line 52: >> >>> 50: public class PrinterDevice implements Printable { >>> 51: >>> 52: static volatile boolean failed = false; >> >> Is it really needed? In all the cases

Re: RFR: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS [v2]

2023-12-05 Thread Phil Race
On Tue, 5 Dec 2023 19:45:34 GMT, Alexey Ivanov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8320443 > > test/jdk/java/awt/print/PrinterJob/PrinterDevice.java line 30: > >> 28: * @summary Checks that the

Re: RFR: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS [v2]

2023-12-05 Thread Alexey Ivanov
On Mon, 4 Dec 2023 23:31:47 GMT, Phil Race wrote: >> For as long as we've had the macOS port, it seems that queries on the >> GraphicsConfiguration associated with >> a printer would give you null for the defaultTransform. >> Clearly this API isn't a popular one to call in such a context else

Re: RFR: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS [v2]

2023-12-04 Thread Phil Race
> For as long as we've had the macOS port, it seems that queries on the > GraphicsConfiguration associated with > a printer would give you null for the defaultTransform. > Clearly this API isn't a popular one to call in such a context else we'd have > had lots of reports. > We have a test that

Re: RFR: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS [v2]

2023-12-04 Thread Phil Race
On Wed, 22 Nov 2023 07:49:07 GMT, Andrey Turbanov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8320443 > > src/java.desktop/share/classes/sun/print/RasterPrinterJob.java line 2096: > >> 2094: >> 2095:

Re: RFR: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS [v2]

2023-12-04 Thread Phil Race
On Thu, 23 Nov 2023 17:06:01 GMT, Alexey Ivanov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8320443 > > test/jdk/java/awt/print/PrinterJob/PrinterDevice.java line 26: > >> 24: /* >> 25: * >> 26: * @bug 4276227