From: "Yury G. Kudryashov"
A large block of code was indented 2 spaces less than it should.
---
Source/cmInstallCommand.cxx | 156 +-
1 files changed, 78 insertions(+), 78 deletions(-)
diff --git a/Source/cmInstallCommand.cx
From: "Yury G. Kudryashov"
install(TARGETS ...) documentation described twice what happens on non-DLL
systems.
---
Source/cmInstallCommand.h |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/Source/cmInstallCommand.h b/Source/cmInstallCommand.h
index 8f6232
find_package(PkgConfig REQUIRED) now fails if pkg-config is not installed
Bug 12620
---
Modules/FindPkgConfig.cmake |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/Modules/FindPkgConfig.cmake b/Modules/FindPkgConfig.cmake
index c47f583..ce58899 100644
--- a/Modules/F
From: "Yury G. Kudryashov"
State explicitly what CONFIG_MODE argument does.
---
Modules/FindPackageHandleStandardArgs.cmake |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Modules/FindPackageHandleStandardArgs.cmake
b/Modules/FindPackageHandleStandard
Brad King wrote:
> On 1/19/2012 2:41 PM, Yury G. Kudryashov wrote:
>> State explicitly what CONFIG_MODE argument does.
> [snip]
>> -# a find_package(... NO_MODULE) call, in this case all the information
>> -# provided by the config-mode of find_package() will be evalu
TINATION).
The main advantage of this solution is that the relative path is calculated
only once (when package is installed), not every time Config.cmake file is
sourced. The main drawback is that one has to specify all required path
variables explicitly.
--
Yury G. Kudryashov,
mailto: ur...@mccme.ru
Alexander Neundorf wrote:
> On Tuesday 14 February 2012, Yury G. Kudryashov wrote:
>> will substitute @PACKAGE_INCLUDE_INSTALL_DIR@ by "../../../include" and
>> @PACKAGE_MYPKGDATA_INSTALL_DIR@ by "../../../share/mypkg" (both
>> transformed to be relative t
that it would require a lot of code for no real gain.
A "simple" API would be "write me a basic Config.cmake file for this export
set" but this would require a few changes in C++ code (i.e., turn export set
into an object with properties like DESTINATION, FILE, NAMES
few libraries/executables with simple version logic).
--
Yury G. Kudryashov,
mailto: ur...@mccme.ru
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www
From: "Yury G. Kudryashov"
---
Modules/CMakeFindPackageMode.cmake |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/Modules/CMakeFindPackageMode.cmake
b/Modules/CMakeFindPackageMode.cmake
index 4296577..bcf3014 100644
--- a/Modules/CMakeFindPackageMode.c
From: "Yury G. Kudryashov"
---
cmake.1 | 112 ---
1 files changed, 0 insertions(+), 112 deletions(-)
delete mode 100644 cmake.1
diff --git a/cmake.1 b/cmake.1
deleted file mode 100644
index c7695b4..000
--- a/cmake.
ference between std::string and cmStdString?
--
Yury G. Kudryashov,
mailto: ur...@mccme.ru
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org
From: "Yury G. Kudryashov"
---
Source/cmDocumentVariables.cxx |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Source/cmDocumentVariables.cxx b/Source/cmDocumentVariables.cxx
index 1cab2b5..366ebaa 100644
--- a/Source/cmDocumentVariables.cxx
++
The cmProperty class is used only in cmPropertyMap, and it seems easier to
implement this logic in cmPropertyMap.
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at
From: "Yury G. Kudryashov"
This class contains nothing but name (already stored in cmPropertyMap key) and
value (string).
---
Source/cmProperty.cxx | 40
Source/cmProperty.h | 24 ++
From: "Yury G. Kudryashov"
After previous commit cmProperty.h contained only one enum. Move it to
cmPropertyMap.h.
---
Source/CMakeLists.txt |2 --
Source/cmDocumentation.h |2 +-
Source/cmProperty.h | 21 -
Source/cmPropertyDe
From: "Yury G. Kudryashov"
---
Source/cmPropertyDefinition.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Source/cmPropertyDefinition.h b/Source/cmPropertyDefinition.h
index f68db87..58d1472 100644
--- a/Source/cmPropertyDefinition.h
++
Yury G. Kudryashov wrote:
> From: "Yury G. Kudryashov"
>
Mailman says that the next patch is too big. The compressed version is
attached.
--
Yury G. Kudryashov,
mailto: ur...@mccme.ru
0002-Add-const-qualifier-to-some-cmCommand-members.patch.xz
Description: application/x
From: "Yury G. Kudryashov"
GetLocation returns std::string::c_str() which is never NULL
---
Source/cmLocalGenerator.cxx |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/Source/cmLocalGenerator.cxx b/Source/cmLocalGenerator.cxx
index ffbeb48..ea48dd1 10
; recently merged-to-next topic for the target-include-directories...
I'd move AddStringToProperty to cmPropertyMap (say,
cmPropertyMap::PrependProperty). I'll prepare a patch in a few days (rather
busy now).
--
Yury G. Kudryashov,
mailto: ur...@mccme.ru
--
Powered by www.kitware.co
accept gitorious pull requests, or should I send e-mails like
this? I don't want to fill a bug report in mantis for each small fix.
--
Yury G. Kudryashov,
mailto: ur...@mccme.ru
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/openso
Brad King wrote:
> On 2/28/2012 2:46 PM, Yury G. Kudryashov wrote:
>> git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git
>> ready/fix-typos
>
> Please combine those commits and write a single commit message
> that briefly explains the tools you ran to find the e
Brad King wrote:
> On 2/25/2012 3:19 AM, Yury G. Kudryashov wrote:
>> Yury G. Kudryashov wrote:
>>
>>> From: "Yury G. Kudryashov"
>>>
>> Mailman says that the next patch is too big. The compressed version is
>> attached.
>
> While bui
Brad King wrote:
> On Tue, Feb 28, 2012 at 4:07 PM, Yury G. Kudryashov
> wrote:
>> This branch compiles with -Werror here:
>> git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git add-const-
>> qualifiers
>
> I still get warnings like:
>
> Source/
Brad King wrote:
> On 2/28/2012 4:21 PM, Brad King wrote:
>> On 2/28/2012 4:02 PM, Yury G. Kudryashov wrote:
>>> git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git doxygen-fixes
>
> Our style checker limits .h and .cxx files to 79 columns.
> Some of the updated
Brad King wrote:
> On 2/28/2012 4:21 PM, Brad King wrote:
>> On 2/28/2012 4:02 PM, Yury G. Kudryashov wrote:
>>> git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git
>>> run-vim-spellcheck
>
> Merged, thanks:
>
> http://cmake.org/gitweb?p=cmake
ndBoost=ON
# Turn all debug messages in mysubdir/CMakeLists.txt
-DCMAKE_DEBUG_MESSAGES_mysubdir=ON
# Turn all debug messages in **/CMakeLists.txt
-DCMAKE_DEBUG_MESSAGES_CMakeLists=ON
--
Yury G. Kudryashov,
mailto: ur...@mccme.ru
--
Powered by www.kitware.com
Visit other Kitware open-source projects
://gitorious.org/~urkud1/cmake/urkud-cmake/commits/rename-used-commands
--
Yury G. Kudryashov,
mailto: ur...@mccme.ru
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http
Hi!
I've just found that there are two doxygen configs in cmake source tree:
* cmake/doxygen.config
* cmake/Utilities/Doxygen/* VTK magic
The second one can be enabled by BUILD_DOCUMENTATION but doc_makeall.sh
references some VTK_* variables.
Which one should I use/fix/..?
--
Y
Brad King wrote:
> On 3/6/2012 2:23 AM, Yury G. Kudryashov wrote:
>> Hi!
>>
>> I've just found that there are two doxygen configs in cmake source tree:
>> * cmake/doxygen.config
>
> I think you can remove this one.
>
>> * cmake/Utilities/Doxygen/
ar as I understand, it will search:
/opt/p1, /opt/p1/foo, /usr/include, /usr/include/foo, /opt/p2, /opt/p2/foo.
--
Yury G. Kudryashov,
mailto: ur...@mccme.ru
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep
- for each of supported compilers other than gcc and clang, which flags
should I check?
- for each new language feature, do you have a minimal code example that
check if this feature is available?
Current version of FindCXX11.cmake is attached. This version is not ready
for review.
--
Y
ures(feature1 feature2 REQUIRED)
# check for optional AND required features
check_cxx11_features(
REQUIRED required1 required2
OPTIONAL optional1 optional2)
--
Yury G. Kudryashov,
mailto: ur...@mccme.ru
--
Powered by www.kitware.com
Visit other Kitware open-source p
o install(EXPORT ...).
>
> But I don't think it's 'done' enough for inclusion yet unfortunately. The
> existing tests pass, but new ones are needed. Hopefully we can get it
> ready early in the next cycle.
The problem is that I have a few deadlines in June: 2 gran
Hi,
2012/8/23 Alexander Neundorf :
> Hi,
>
> If I would do this, I would get the error for the BarExport export set, that
> it does not contain target foo, which it depends on.
>
> We'd like to make this work, since we need this in KDE.
>
> How can this be done ?
Sorry for the very long silence. I
2012/8/23 Brad King :
> On 08/22/2012 04:57 PM, Yury G. Kudryashov wrote:
>> I'm going to push the current state of my work to
>> git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git w/export-set
>> in a few minutes.
>
> Thanks for working on this!
>
Hi!
2012/8/23 Daniel Pfeifer :
> 2012/8/22 Yury G. Kudryashov :
>>> Any "latest install" strategy is bound to generate subtle problems.
>>> Dependencies among export sets should be explicit:
>>>
>>> install(EXPORT MyExport DEPENDS YourExport)
&g
2012/9/11 Alexander Neundorf :
> Hi Yury,
>
> will you be able to work on this for the 2.8.10 release ?
What are the deadlines?
--
Yours Yury,
mailto: urkud.ur...@gmail.com
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.htm
2012/9/17 Brad King :
> On 09/15/2012 04:45 PM, Alexander Neundorf wrote:
> Also, one of Yury's commit messages says:
>
> TODO: remove another clear() because it doesn't delete TargetExports.
>
> What is that about?
clear() on a vector of TargetExport* does not call delete on each element.
BTW, d
2012/9/16 Alexander Neundorf :
> On Tuesday 11 September 2012, Brad King wrote:
>> On 09/11/2012 04:08 PM, Yury G. Kudryashov wrote:
>> > 2012/9/11 Alexander Neundorf :
>> >> Hi Yury,
>> >>
>> >> will you be able to work on this for
second commit in the branch updates Tests/QtAutomoc.
--
Yury G. Kudryashov,
mailto: ur...@mccme.ru
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http:
2013/1/14 Alexander Neundorf :
> On Friday 11 January 2013, Brad King wrote:
>> On 01/11/2013 04:47 AM, Yury G. Kudryashov wrote:
>> > Look at
>> > $ git pull gitorious:~urkud1/cmake/urkud-cmake.git w/automoc-object
>> > please.
>>
>> The comm
From: "Yury G. Kudryashov"
---
Source/cmMakefile.cxx | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Source/cmMakefile.cxx b/Source/cmMakefile.cxx
index b432986..d1dc5a2 100644
--- a/Source/cmMakefile.cxx
+++ b/Source/cmMakefile.cxx
@@ -2243,7 +2243
From: "Yury G. Kudryashov"
---
Source/CPack/cmCPackDocumentVariables.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Source/CPack/cmCPackDocumentVariables.cxx
b/Source/CPack/cmCPackDocumentVariables.cxx
index 1dfaaf9..8b16ae9 100644
--- a/So
STRINGS
"Developer;Packager;Maintainer;User")
but in this case a common name will help users (at least, once buildsystems
will start really use this variable).
--
Yury G. Kudryashov,
mailto: ur...@mccme.ru
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
htt
45 matches
Mail list logo
