sanastas commented on issue #7676: Add OakIncrementalIndex to Druid
URL: https://github.com/apache/incubator-druid/pull/7676#issuecomment-494687467
Thank you for your input!
This is an automated message from the Apache Git Ser
gianm commented on issue #7724: Lookup transform expression not defined during
ingest from kafka
URL:
https://github.com/apache/incubator-druid/issues/7724#issuecomment-494711696
I think this is happening because the overlord doesn't load lookups and
doesn't have a lookup module, and so,
clintropolis commented on issue #7724: Lookup transform expression not defined
during ingest from kafka
URL:
https://github.com/apache/incubator-druid/issues/7724#issuecomment-494718031
Potentially related #5727 and #7082
Th
gianm opened a new pull request #7729: SeekableStreamIndexTaskRunner: Lazy init
of runner.
URL: https://github.com/apache/incubator-druid/pull/7729
The main motivation is that this fixes #7724, by making it so the overlord
doesn't try to create a task runner and parser when all it really
gianm commented on issue #7724: Lookup transform expression not defined during
ingest from kafka
URL:
https://github.com/apache/incubator-druid/issues/7724#issuecomment-49472
I raised https://github.com/apache/incubator-druid/pull/7729 which makes the
runner and parser initialization
gianm commented on issue #7724: Lookup transform expression not defined during
ingest from kafka
URL:
https://github.com/apache/incubator-druid/issues/7724#issuecomment-494723741
> Maybe a nice way to address that would be to extend #7222 to put the
LookupSerdeModule on the overlord and M
gocho1 commented on issue #7674: add s3 authentication method informations
URL: https://github.com/apache/incubator-druid/pull/7674#issuecomment-494742065
Should i do something about the build not passing ? Seems like a timeout
during tests
-
gianm commented on issue #7674: add s3 authentication method informations
URL: https://github.com/apache/incubator-druid/pull/7674#issuecomment-494742673
I restarted that one, it might have flaked out.
This is an automated mes
clintropolis opened a new pull request #7730: add support for multi-value
string dimensions for 'HllSketch' build aggregator
URL: https://github.com/apache/incubator-druid/pull/7730
Without this patch, attempting to use `HLLSketchBuild` aggregator on a
multi-value string dimension results
gianm commented on a change in pull request #7653: Refactor
SQLMetadataSegmentManager; Change contract of REST methods in
DataSourcesResource
URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r286335156
##
File path:
server/src/main/java/org/apache/druid/metadata
gianm commented on a change in pull request #7653: Refactor
SQLMetadataSegmentManager; Change contract of REST methods in
DataSourcesResource
URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r286365821
##
File path:
server/src/main/java/org/apache/druid/metadata
gianm commented on a change in pull request #7653: Refactor
SQLMetadataSegmentManager; Change contract of REST methods in
DataSourcesResource
URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r286321710
##
File path:
server/src/main/java/org/apache/druid/metadata
gianm commented on a change in pull request #7653: Refactor
SQLMetadataSegmentManager; Change contract of REST methods in
DataSourcesResource
URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r286416399
##
File path:
server/src/main/java/org/apache/druid/metadata
gianm commented on a change in pull request #7653: Refactor
SQLMetadataSegmentManager; Change contract of REST methods in
DataSourcesResource
URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r286322201
##
File path:
server/src/main/java/org/apache/druid/metadata
gianm commented on a change in pull request #7653: Refactor
SQLMetadataSegmentManager; Change contract of REST methods in
DataSourcesResource
URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r286416635
##
File path:
server/src/main/java/org/apache/druid/metadata
gianm commented on a change in pull request #7653: Refactor
SQLMetadataSegmentManager; Change contract of REST methods in
DataSourcesResource
URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r286368954
##
File path:
server/src/main/java/org/apache/druid/metadata
gianm commented on a change in pull request #7653: Refactor
SQLMetadataSegmentManager; Change contract of REST methods in
DataSourcesResource
URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r286321411
##
File path:
server/src/main/java/org/apache/druid/metadata
gianm commented on a change in pull request #7653: Refactor
SQLMetadataSegmentManager; Change contract of REST methods in
DataSourcesResource
URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r286368775
##
File path:
server/src/main/java/org/apache/druid/metadata
clintropolis opened a new pull request #7731: fix
AggregatorFactory.finalizeComputation implementations to be ok with null inputs
URL: https://github.com/apache/incubator-druid/pull/7731
`AggregatorFactory.finalizeComputation` is nullable with nullable input, but
some aggregators do not ch
gocho1 commented on issue #7674: add s3 authentication method informations
URL: https://github.com/apache/incubator-druid/pull/7674#issuecomment-494753005
Thanks, it worked !
This is an automated message from the Apache Git Se
Fokko commented on issue #7701: Bump Jackson to 2.9.9
URL: https://github.com/apache/incubator-druid/pull/7701#issuecomment-494820707
Rebased against master
This is an automated message from the Apache Git Service.
To respond
fjy commented on issue #7728: fix Select query fails with columns called
"timestamp" bug
URL: https://github.com/apache/incubator-druid/pull/7728#issuecomment-494850783
@hellobabygogo thanks for the contrib. Just an FYI that select query is now
deprecated in favor of Scan query.
-
sashidhar edited a comment on issue #7609: Local variable names shouldn't start
with capital
URL:
https://github.com/apache/incubator-druid/issues/7609#issuecomment-494883301
@leventov
1. This is the match pattern I'm currently using for Local Variable names
`'^[a-z_](_?[a-zA-Z0-9
sashidhar commented on issue #7609: Local variable names shouldn't start with
capital
URL:
https://github.com/apache/incubator-druid/issues/7609#issuecomment-494883301
@leventov
1. This is the match pattern I'm currently using for Local Variable names
`'^[a-z_](_?[a-zA-Z0-9_]+)*$'
sashidhar edited a comment on issue #7609: Local variable names shouldn't start
with capital
URL:
https://github.com/apache/incubator-druid/issues/7609#issuecomment-494883301
@leventov
1. This is the match pattern I'm currently using for Local Variable names
`'^[a-z_](_?[a-zA-Z0-9
sashidhar edited a comment on issue #7609: Local variable names shouldn't start
with capital
URL:
https://github.com/apache/incubator-druid/issues/7609#issuecomment-494883301
@leventov
1. This is the match pattern I'm currently using for Local Variable names
`'^[a-z_](_?[a-zA-Z0-9
jihoonson opened a new pull request #7732: [Backport] Update tutorial to delete
data
URL: https://github.com/apache/incubator-druid/pull/7732
Backport of #7577 to 0.15.0-incubating.
This is an automated message from the Apach
vogievetsky commented on a change in pull request #7705: Web-Console: add go to
editor button to tasks and supervisors view
URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r286602310
##
File path: web-console/src/views/load-data-view.tsx
##
@@ -175,14 +
vogievetsky commented on a change in pull request #7705: Web-Console: add go to
editor button to tasks and supervisors view
URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r286601831
##
File path: web-console/src/views/tasks-view.tsx
##
@@ -303,6 +303,1
vogievetsky commented on a change in pull request #7705: Web-Console: add go to
editor button to tasks and supervisors view
URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r285795400
##
File path: web-console/src/views/tasks-view.tsx
##
@@ -508,18 +518,
vogievetsky commented on a change in pull request #7705: Web-Console: add go to
editor button to tasks and supervisors view
URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r286601690
##
File path: web-console/src/views/tasks-view.tsx
##
@@ -303,6 +303,1
vogievetsky commented on a change in pull request #7705: Web-Console: add go to
editor button to tasks and supervisors view
URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r286601266
##
File path: web-console/src/console-application.tsx
##
@@ -107,6 +10
vogievetsky commented on a change in pull request #7705: Web-Console: add go to
editor button to tasks and supervisors view
URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r286601322
##
File path: web-console/src/views/load-data-view.tsx
##
@@ -27,6 +27
sashidhar commented on issue #7609: Local variable names shouldn't start with
capital
URL:
https://github.com/apache/incubator-druid/issues/7609#issuecomment-494899188
@leventov,
3. For local final variables example here
http://checkstyle.sourceforge.net/config_naming.html#LocalFin
This is an automated email from the ASF dual-hosted git repository.
fjy pushed a commit to branch 0.15.0-incubating
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/0.15.0-incubating by this push:
new f695425 Update tuto
fjy merged pull request #7732: [Backport] Update tutorial to delete data
URL: https://github.com/apache/incubator-druid/pull/7732
This is an automated message from the Apache Git Service.
To respond to the message, please log
mcbrewster commented on a change in pull request #7705: Web-Console: add go to
editor button to tasks and supervisors view
URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r286611391
##
File path: web-console/src/views/tasks-view.tsx
##
@@ -303,6 +303,16
himanshug merged pull request #7674: add s3 authentication method informations
URL: https://github.com/apache/incubator-druid/pull/7674
This is an automated message from the Apache Git Service.
To respond to the message, plea
This is an automated email from the ASF dual-hosted git repository.
himanshug pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git.
from 1fe0de1 Fix currSize attribute of historical server type (#7706)
add bd899b9 add s3 authentication
a2l007 opened a new issue #7733: Provide segment size property that includes
replicated segments
URL: https://github.com/apache/incubator-druid/issues/7733
### Description
I'd like to a new property `replicatedSize` to the tier-specific result of
`druid/coordinator/v1/datasources?si
himanshug commented on a change in pull request #7728: fix Select query fails
with columns called "timestamp" bug
URL: https://github.com/apache/incubator-druid/pull/7728#discussion_r286641405
##
File path:
processing/src/main/java/org/apache/druid/query/select/EventHolder.java
##
fjy opened a new pull request #7734: reorganizing the ToC
URL: https://github.com/apache/incubator-druid/pull/7734
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
This is an automated email from the ASF dual-hosted git repository.
fjy pushed a change to branch toc-fix
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git.
at afd80e0 reorganizing the ToC
No new revisions were added by this update.
-
himanshug commented on issue #7731: fix AggregatorFactory.finalizeComputation
implementations to be ok with null inputs
URL: https://github.com/apache/incubator-druid/pull/7731#issuecomment-494931501
LGTM in general. But I had a thought of adding following method to
AggregatorFactory
himanshug commented on a change in pull request #7729:
SeekableStreamIndexTaskRunner: Lazy init of runner.
URL: https://github.com/apache/incubator-druid/pull/7729#discussion_r286661510
##
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableSt
jihoonson commented on a change in pull request #7734: reorganizing the ToC
URL: https://github.com/apache/incubator-druid/pull/7734#discussion_r286663238
##
File path: docs/content/toc.md
##
@@ -126,20 +132,19 @@ layout: toc
* [Metrics and Monitoring](/docs/VERSION/oper
vogievetsky commented on issue #7669: add tests to dialogs, components and views
URL: https://github.com/apache/incubator-druid/pull/7669#issuecomment-494951826
Yay, this finally passed all the tests!
This is good to go as far as I am concerned 👍
clintropolis commented on issue #7731: fix
AggregatorFactory.finalizeComputation implementations to be ok with null inputs
URL: https://github.com/apache/incubator-druid/pull/7731#issuecomment-494957996
>This would fix the problem for extensions not in druid codebase and also
one less thin
clintropolis edited a comment on issue #7731: fix
AggregatorFactory.finalizeComputation implementations to be ok with null inputs
URL: https://github.com/apache/incubator-druid/pull/7731#issuecomment-494957996
> ...use above in all of druid code instead of finalizeComputation(..) .
This wo
clintropolis commented on a change in pull request #7729:
SeekableStreamIndexTaskRunner: Lazy init of runner.
URL: https://github.com/apache/incubator-druid/pull/7729#discussion_r286673679
##
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/Seekabl
stale[bot] commented on issue #7174: Change reservoir sampling of segments to
spliterator approach
URL: https://github.com/apache/incubator-druid/pull/7174#issuecomment-494982136
This pull request has been closed due to lack of activity. If you think that
is incorrect, or the pull request
stale[bot] closed pull request #7174: Change reservoir sampling of segments to
spliterator approach
URL: https://github.com/apache/incubator-druid/pull/7174
This is an automated message from the Apache Git Service.
To respon
clintropolis commented on issue #7731: fix
AggregatorFactory.finalizeComputation implementations to be ok with null inputs
URL: https://github.com/apache/incubator-druid/pull/7731#issuecomment-494988305
I think cardinality/hyperunique behavior also raises another thing to
consider, is that
gianm commented on issue #7609: Local variable names shouldn't start with
capital
URL:
https://github.com/apache/incubator-druid/issues/7609#issuecomment-494997860
> There are several occurrences of variables which are not constants (i.e
non static fields) which have variables all capital
himanshug commented on issue #7731: fix AggregatorFactory.finalizeComputation
implementations to be ok with null inputs
URL: https://github.com/apache/incubator-druid/pull/7731#issuecomment-495014170
@clintropolis yeah , I forgot that default behavior might be dependent on
the aggregation
gianm commented on issue #7728: fix Select query fails with columns called
"timestamp" bug
URL: https://github.com/apache/incubator-druid/pull/7728#issuecomment-495016935
How about instead fixing this by keeping time in `timestamp`, but then also
dropping any dimension/metric that is named
gianm commented on issue #7733: Provide segment size property that includes
replicated segments
URL:
https://github.com/apache/incubator-druid/issues/7733#issuecomment-495017202
It sounds useful to me. If it's not computationally or memory intensive to
compute, I don't see why not.
-
gianm commented on issue #7701: Bump Jackson to 2.9.9
URL: https://github.com/apache/incubator-druid/pull/7701#issuecomment-495018165
Jackson and Guava are two libraries that always seem to cause dependency
nightmares in connection with Hadoop. I would want to test this out with
various Ha
gianm commented on issue #7726: longMin/longMax has different result, should
unify?
URL:
https://github.com/apache/incubator-druid/issues/7726#issuecomment-495018328
What would SQL standard behavior be?
I think we're not standard for query (2), it should probably return `null`.
I'm
hellobabygogo commented on issue #7728: fix Select query fails with columns
called "timestamp" bug
URL: https://github.com/apache/incubator-druid/pull/7728#issuecomment-495034525
> How about instead fixing this by keeping time in `timestamp`, but then
also dropping any dimension/metric tha
hellobabygogo commented on issue #7728: fix Select query fails with columns
called "timestamp" bug
URL: https://github.com/apache/incubator-druid/pull/7728#issuecomment-495041803
> @hellobabygogo thanks for the contrib. Just an FYI that select query is
now deprecated in favor of Scan query
hellobabygogo commented on a change in pull request #7728: fix Select query
fails with columns called "timestamp" bug
URL: https://github.com/apache/incubator-druid/pull/7728#discussion_r286753674
##
File path:
processing/src/main/java/org/apache/druid/query/select/EventHolder.java
gianm commented on issue #7728: fix Select query fails with columns called
"timestamp" bug
URL: https://github.com/apache/incubator-druid/pull/7728#issuecomment-495053991
In master, Scan supports time ordering, and this will be released in 0.15.0.
--
fjy merged pull request #7669: add tests to dialogs, components and views
URL: https://github.com/apache/incubator-druid/pull/7669
This is an automated message from the Apache Git Service.
To respond to the message, please lo
fjy merged pull request #7731: fix AggregatorFactory.finalizeComputation
implementations to be ok with null inputs
URL: https://github.com/apache/incubator-druid/pull/7731
This is an automated message from the Apache Git Ser
This is an automated email from the ASF dual-hosted git repository.
fjy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new ffc2397 fix AggregatorFactory.finalizeCom
This is an automated email from the ASF dual-hosted git repository.
fjy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new 53b6467 SeekableStreamIndexTaskRunner: La
fjy closed issue #7724: Lookup transform expression not defined during ingest
from kafka
URL: https://github.com/apache/incubator-druid/issues/7724
This is an automated message from the Apache Git Service.
To respond to the
fjy merged pull request #7729: SeekableStreamIndexTaskRunner: Lazy init of
runner.
URL: https://github.com/apache/incubator-druid/pull/7729
This is an automated message from the Apache Git Service.
To respond to the message,
jihoonson opened a new pull request #7735: Remove LegacyKafkaIndexTaskRunner
URL: https://github.com/apache/incubator-druid/pull/7735
Kafka indexing service supports Incremental handoff since 0.12.0
(https://github.com/apache/incubator-druid/pull/4815) and
LegacyKafkaIndexTaskRunner was de
fjy commented on a change in pull request #7734: reorganizing the ToC
URL: https://github.com/apache/incubator-druid/pull/7734#discussion_r286777083
##
File path: docs/content/toc.md
##
@@ -126,20 +132,19 @@ layout: toc
* [Metrics and Monitoring](/docs/VERSION/operations
fjy commented on a change in pull request #7734: reorganizing the ToC
URL: https://github.com/apache/incubator-druid/pull/7734#discussion_r286777083
##
File path: docs/content/toc.md
##
@@ -126,20 +132,19 @@ layout: toc
* [Metrics and Monitoring](/docs/VERSION/operations
fjy commented on a change in pull request #7734: reorganizing the ToC
URL: https://github.com/apache/incubator-druid/pull/7734#discussion_r286777179
##
File path: docs/content/toc.md
##
@@ -126,20 +132,19 @@ layout: toc
* [Metrics and Monitoring](/docs/VERSION/operations
viongpanzi commented on a change in pull request #7716: AggregatorUtil should
cache parsed expression to avoid memory problem (OOM/FGC) when Expression is
used in metricsSpec
URL: https://github.com/apache/incubator-druid/pull/7716#discussion_r286778106
##
File path:
processing/sr
jihoonson commented on a change in pull request #7734: reorganizing the ToC
URL: https://github.com/apache/incubator-druid/pull/7734#discussion_r286783441
##
File path: docs/content/toc.md
##
@@ -126,20 +132,19 @@ layout: toc
* [Metrics and Monitoring](/docs/VERSION/oper
75 matches
Mail list logo