merlimat commented on issue #1764: WIP - Pulsar Go client library
URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-391173087
> Rename MessageBuilder to a ProducerMessage since it is no longer
implements a builder pattern?
Yes, I didn't want to call it `Message`
merlimat commented on issue #1764: WIP - Pulsar Go client library
URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-389330502
@bruth We have already seen it's not useful to have sync acks (given that
anyway there's no ack on the ack). Since we're already moving that API
merlimat commented on issue #1764: WIP - Pulsar Go client library
URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-389239317
> I noticed that the Ack calls don't take a context, but they (in theory)
should. Since they interface with C, I realize that doesn't translate
merlimat commented on issue #1764: WIP - Pulsar Go client library
URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-388982480
@bruth @lucperkins some more polishing and added `context.Context` arg to
`Send()`, `Receive()` and `Next()` calls. Please take another look.
-
merlimat commented on issue #1764: WIP - Pulsar Go client library
URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-388510252
@bruth Addressed most of the comments
This is an automated message from the Ap
merlimat commented on issue #1764: WIP - Pulsar Go client library
URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-388268109
@bruth Thanks for great comments. I'll go through them in detail
This is an aut