tien commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1993622235
Have updated the browser example to use TypeScript instead. Didn't touch the
node example as it's right now just a collection of scripts :p
NOTE:
You can see from the browser
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522535064
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -46,43 +44,49 @@ class Graph {
}
class Element {
- constructor(id, label)
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522534690
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js:
##
@@ -20,28 +20,28 @@
/**
* @author Jorge Bay Gondra
*/
-'use strict';
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522533103
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -46,43 +44,49 @@ class Graph {
}
class Element {
- constructor(id, l
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522528198
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js:
##
@@ -20,28 +20,28 @@
/**
* @author Jorge Bay Gondra
*/
-'use strict';
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522524987
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js:
##
@@ -20,28 +20,28 @@
/**
* @author Jorge Bay Gondra
*/
-'use str
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522509577
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -46,43 +44,49 @@ class Graph {
}
class Element {
- constructor(id, label)
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522509374
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/traversal.ts:
##
@@ -476,49 +481,43 @@ function toEnum(typeName, keys) {
const directionAlias =
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522501485
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -46,43 +44,49 @@ class Graph {
}
class Element {
- constructor(id, l
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522500544
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/traversal.ts:
##
@@ -476,49 +481,43 @@ function toEnum(typeName, keys) {
const directionAl
tien commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1993445516
Added a small entry to the `changelog` file, please let me know if further
info or modification is needed.
--
This is an automated message from the Apache Git Service.
To respond to the
tien commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992675130
@vkagamlyk I've removed all the unnecessary changes to the test files. Also
reset them all to what is on `master` first so there are no conflicts from
`3.7`.
--
This is an automated mes
tien commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992506652
> documentation update for
[users](https://tinkerpop.apache.org/docs/current/reference/#gremlin-javascript),
[developers
environment](https://tinkerpop.apache.org/docs/current/dev/develop
tien commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992495561
> P.S. Please do not change the formatting because it makes code review very
difficult. It's usually better to make separate PR for formatting/fix styles.
Yeah, this is because my ed
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522052097
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/sasl-authentication-tests.js:
##
@@ -69,38 +68,43 @@ describe('DriverRemoteConnection', fun
vkagamlyk commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992488713
Missing parts:
- documentation update for
[users](https://tinkerpop.apache.org/docs/current/reference/#gremlin-javascript),
[developers
environment](https://tinkerpop.apache.org/d
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522028418
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/sasl-authentication-tests.js:
##
@@ -69,38 +68,43 @@ describe('DriverRemoteConnection'
tien commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992375619
> I think this is a good first step to implement the type system. Thank you
for contribution @tien!
>
> Did I understand correctly that users will be able to use it without
having t
vkagamlyk commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992334497
I think this is a good first step to implement the type system. Thank you
for contribution @tien!
Did I understand correctly that users will be able to use it without having
t
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/3.6-dev/com.google.errorprone-error_prone_annotations-2.25.0
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
was fab11ec926 Bump com.google.errorprone:e
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/3.6-dev/com.google.errorprone-error_prone_annotations-2.26.0
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
at c4234e260a Bump com.google.errorprone:e
dependabot[bot] closed pull request #2501: Bump
com.google.errorprone:error_prone_annotations from 2.4.0 to 2.25.0
URL: https://github.com/apache/tinkerpop/pull/2501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dependabot[bot] commented on PR #2501:
URL: https://github.com/apache/tinkerpop/pull/2501#issuecomment-1991878169
Superseded by #2519.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #2519:
URL: https://github.com/apache/tinkerpop/pull/2519
Bumps
[com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone)
from 2.4.0 to 2.26.0.
Release notes
Sourced from https://github.com/google/error-prone/
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/nuget/gremlin-dotnet/3.6-dev/System.Text.Json-8.0.3
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
at f5d8225ca8 Bump System.Text.Json from 8.0.2 to 8.0.3 i
dependabot[bot] opened a new pull request, #2518:
URL: https://github.com/apache/tinkerpop/pull/2518
Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 8.0.2 to
8.0.3.
Commits
See full diff in https://github.com/dotnet/runtime/commits";>compare view
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/nuget/gremlin-dotnet/3.6-dev/Microsoft.Extensions.Logging.Abstractions-8.0.1
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
at 588e362838 Bump Microsoft.Ext
dependabot[bot] opened a new pull request, #2517:
URL: https://github.com/apache/tinkerpop/pull/2517
Bumps
[Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime)
from 7.0.1 to 8.0.1.
Release notes
Sourced from https://github.com/dotnet/runtime/releases";>Mi
This is an automated email from the ASF dual-hosted git repository.
florianhockmann pushed a change to branch
dependabot/nuget/gremlin-dotnet/3.6-dev/Polly-8.3.1
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
was aa90f77595 Bump Polly from 8.3.0 to 8.3.1 in /gremlin-dotnet
This is an automated email from the ASF dual-hosted git repository.
florianhockmann pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
from 6bd2c92f63 CTR add missing require to gremlin-js SetSerializer
add aa90f77595 Bump Polly from 8.3.0 t
This is an automated email from the ASF dual-hosted git repository.
florianhockmann pushed a change to branch 3.6-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
from 2d950116db Avoiding expensive hash computation for complex steps with
many children in filter ranking st
This is an automated email from the ASF dual-hosted git repository.
florianhockmann pushed a change to branch 3.7-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
from 4e99e77f6a feat: `gremlin.js` browser support (#2506)
add aa90f77595 Bump Polly from 8.3.0 to 8.3.1
This is an automated email from the ASF dual-hosted git repository.
florianhockmann pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit cc43fbf57af6f95213e52cb58e911dd8cb857ab4
Merge: 6bd2c92f63 936dd8137a
Author: Florian Hockmann
AuthorDate: T
FlorianHockmann merged PR #2513:
URL: https://github.com/apache/tinkerpop/pull/2513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@
34 matches
Mail list logo
