Re: [concordance-devel] [PATCH] Support the Harmony Touch (v12)

2015-04-03 Thread Scott Talbert
On Fri, 3 Apr 2015, Phil Dibowitz wrote: -printf(" Serial Number: %s\n\t%s\n\t%s\n", get_serial(1), - get_serial(2), get_serial(3)); +if (strlen(mh_get_serial()) != 0) +printf(" Serial Number: %s\n", mh_get_serial()); +el

Re: [concordance-devel] [PATCH] Support the Harmony Touch (v12)

2015-04-03 Thread Phil Dibowitz
On 03/06/2015 02:31 PM, Scott Talbert wrote: > Are you ever going to review this? Going 3+ months between patch reviews > is unacceptable. It totally is, my apologies. There was no activity on this for a while, and in December, January, February I was traveling a lot. -- Phil Dibowitz

Re: [concordance-devel] [PATCH] Support the Harmony Touch (v12)

2015-04-03 Thread Phil Dibowitz
On 11/28/2014 09:34 PM, Scott Talbert wrote: > On Thu, 27 Nov 2014, Phil Dibowitz wrote: > >>> -printf(" Serial Number: %s\n\t%s\n\t%s\n", get_serial(1), >>> - get_serial(2), get_serial(3)); >>> +if (strlen(mh_get_serial()) != 0) >>> +printf(" Serial Num

Re: [concordance-devel] [PATCH] Support the Harmony Touch (v12)

2015-03-06 Thread David Callahan
No kidding! You should give him double his money back! On March 6, 2015 4:31:15 PM CST, Scott Talbert wrote: >On Mon, 29 Dec 2014, Scott Talbert wrote: > > -printf(" Serial Number: %s\n\t%s\n\t%s\n", >get_serial(1), > - get_serial(2), get_serial(3)); > +

Re: [concordance-devel] [PATCH] Support the Harmony Touch (v12)

2015-03-06 Thread Scott Talbert
On Mon, 29 Dec 2014, Scott Talbert wrote: -printf(" Serial Number: %s\n\t%s\n\t%s\n", get_serial(1), - get_serial(2), get_serial(3)); +if (strlen(mh_get_serial()) != 0) +printf(" Serial Number: %s\n", mh_get_serial()); +e

Re: [concordance-devel] [PATCH] Support the Harmony Touch (v12)

2015-01-11 Thread Scott Talbert
Are you 100% sure you used a clean source tree? These are the only differences between v11 and v12: < +case 0xC129: /* Harmony Ultimate Hub */ --- +case 0xC129: /* Harmony Hub */ < + { MFG_HAR, "Harmony Ultimate Hub", NULL }, --- + { MFG_HAR, "Ha

Re: [concordance-devel] [PATCH] Support the Harmony Touch (v12)

2015-01-11 Thread Cédric de Launois
Hi Scott, I tried to apply your patch v12 but got two rejects (using a fresh source clone). See files attached. Patch v11 applies correctly. Regards, Cedric 2014-12-30 1:25 GMT+01:00 Scott Talbert : > On Sat, 29 Nov 2014, Scott Talbert wrote: > > > On Thu, 27 Nov 2014, Phil Dibowitz wrote: > >

Re: [concordance-devel] [PATCH] Support the Harmony Touch (v12)

2014-12-29 Thread Scott Talbert
On Sat, 29 Nov 2014, Scott Talbert wrote: > On Thu, 27 Nov 2014, Phil Dibowitz wrote: > >>> -printf(" Serial Number: %s\n\t%s\n\t%s\n", get_serial(1), >>> - get_serial(2), get_serial(3)); >>> +if (strlen(mh_get_serial()) != 0) >>> +printf(" Serial Number

Re: [concordance-devel] [PATCH] Support the Harmony Touch (v12)

2014-11-28 Thread Scott Talbert
On Thu, 27 Nov 2014, Phil Dibowitz wrote: >> -printf(" Serial Number: %s\n\t%s\n\t%s\n", get_serial(1), >> - get_serial(2), get_serial(3)); >> +if (strlen(mh_get_serial()) != 0) >> +printf(" Serial Number: %s\n", mh_get_serial()); >> +else >> +

Re: [concordance-devel] [PATCH] Support the Harmony Touch (v12)

2014-11-27 Thread Phil Dibowitz
So sorry for missing this, it got lost in the noise. Always feel free to bug me. On 08/22/2014 05:30 PM, Scott Talbert wrote: > -printf(" Serial Number: %s\n\t%s\n\t%s\n", get_serial(1), > - get_serial(2), get_serial(3)); > +if (strlen(mh_get_serial()) != 0) > +

[concordance-devel] [PATCH] Support the Harmony Touch (v12)

2014-08-22 Thread Scott Talbert
Add the PID for the Touch to the list of MH PIDs. Add the Touch's Skin/Arch to the remote_info structs. Add support for handling the Touch's non-standard serial number, and provide a libconcord call to expose this information. Don't try to read the /cfg/usercfg on the Link/Touch. Remove set_configu