Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

2015-10-26 Thread Xueming Shen
Hi Steve, I know I stared to sound like a broken record :-) But I would like to suggest the team one more time to reconsider the current decision of using the "set" methods to change the configuration setting/status of an existing JarFile to enable the multi-version support. public JarFile se

Re: [concurrency-interest] Is Reference.reachabilityFence() needed in Reference constructor?

2015-10-26 Thread Vitaly Davidovich
http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/file/5d13c9b094c4/src/share/vm/opto/library_call.cpp#l5629 C2 does inline it but intentionally forbids commoning out reads of Reference.get. However, this needs a real fix not a hack. sent from my phone On Oct 26, 2015 3:22 PM, "Justin Sampson" wr

Re: [RFR] (S) 8140189: [TESTBUG] Get rid of "@library /../../test/lib" in jtreg tests

2015-10-26 Thread Chris Plummer
I just pulled the latest hs-rt, and got about 30 new jvmci tests that are using "/../../test/lib". I can fix them with this push, or file a separate bug or send out a fix after I do this push. If I fix with this push, do you want another review? I'll test with jprt and run the jvmci tests local

Re: [9] RFR: 8139743 regular JAX-* sync-up from standalone repos

2015-10-26 Thread Lance Andersen
Hi Miran Overall looks OK. Couple quick points: Does the picture look correct at http://cr.openjdk.java.net/~mkos/8139743/specdiff.03/com/sun/xml/internal/bind/v2/package-summary.html? Might be made more readable http://cr.openjdk.java.net/~mkos/8139743/specdiff.03/com/sun/xml/internal/ws/a

Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

2015-10-26 Thread Steve Drach
Hi, We’ve published another webrev for review. Issue: https://bugs.openjdk.java.net/browse/JDK-8132734 JEP 238: https://bugs.openjdk.java.net/browse/JDK-8047305 Webrev: http://cr.openjdk.java.net/~psandoz/multiversion-jar/jar-webrev/ This one addresses the issues regarding CodeSigners, Certific

RFR(XS): 8136967: revert all changes applied to obtain information about 8131129

2015-10-26 Thread Michael Haupt
Dear all, please review this change. Issue: https://bugs.openjdk.java.net/browse/JDK-8136967 Webrev: http://cr.openjdk.java.net/~mhaupt/8136967/webrev.00/ This reverts the changes introduced with http://hg.openjdk.java.net/jdk9/dev/jdk/rev/69f78bcd65f8, which were supposed to deliver more detai

[RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-10-26 Thread Miroslav Kos
Hi everybody, I'd like to ask you for a review for 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader It is about changes in pluggability layer - there was a proprietary service loading implementation which was not fully compatible with to use java.util.ServiceLoader facility. Ther

Re: 8139891: Prepare Unsafe for true encapsulation

2015-10-26 Thread Chris Hegarty
Hi David, Alan, > On 26 Oct 2015, at 01:49, Alan Bateman wrote: > > On 26/10/2015 01:41, David Holmes wrote: > >>> If you are in agreement, is it best to move this first step on and >>> push it into hs-rt. I can then follow up with the additional steps: >>> hotspot test updates in hs-rt, and th