Re: RFR (JDK13/java.xml) 8224157: BCEL: update to version 6.3.1

On 6/24/19, 12:00 PM, Daniel Fuchs wrote: On 24/06/2019 18:24, Joe Wang wrote: Keeping the code in sync with the BCEL (not perfect) source is in our interest to produce smaller changeset in any future updates. Would you be okay with the current webrevs? Yes. This was just a remark that

Re: RFR (JDK13/java.xml) 8224157: BCEL: update to version 6.3.1

On 24/06/2019 18:24, Joe Wang wrote: Keeping the code in sync with the BCEL (not perfect) source is in our interest to produce smaller changeset in any future updates. Would you be okay with the current webrevs? Yes. This was just a remark that maybe the inconsistency should be reported

Re: RFR (JDK13/java.xml) 8224157: BCEL: update to version 6.3.1

On 6/24/19, 2:23 AM, Daniel Fuchs wrote: On 21/06/2019 21:20, Joe Wang wrote: Full webrev (for the record) http://cr.openjdk.java.net/~joehw/jdk13/8224157/webrev_02/ A short version of webrev_02 that includes the only files mentioned in this review:

Re: RFR (JDK13/java.xml) 8224157: BCEL: update to version 6.3.1

On 21/06/2019 21:20, Joe Wang wrote: Full webrev (for the record) http://cr.openjdk.java.net/~joehw/jdk13/8224157/webrev_02/ A short version of webrev_02 that includes the only files mentioned in this review: http://cr.openjdk.java.net/~joehw/jdk13/8224157/webrev_02_short/ Thanks Joe! The

Re: RFR (JDK13/java.xml) 8224157: BCEL: update to version 6.3.1

Thanks Lance! Joe On 6/21/19, 1:59 PM, Lance Andersen wrote: The revised webrev looks fine Joe On Jun 21, 2019, at 4:20 PM, Joe Wang > wrote: On 6/21/19, 11:59 AM, Daniel Fuchs wrote: Hi Joe, I promise, I will not grumble about the formatting and weird

Re: RFR (JDK13/java.xml) 8224157: BCEL: update to version 6.3.1

The revised webrev looks fine Joe > On Jun 21, 2019, at 4:20 PM, Joe Wang wrote: > > > > On 6/21/19, 11:59 AM, Daniel Fuchs wrote: >> Hi Joe, >> >> I promise, I will not grumble about the formatting and >> weird white spaces [grumble grumble]... > > Someone at BCEL needs to re-format the

Re: RFR (JDK13/java.xml) 8224157: BCEL: update to version 6.3.1

Hi Joe, Overall looks OK. Its unfortunate to loose the formatting but given it is not upstream, best to not have the additional work of going through this exercise each time. I have no additional changes to propose outside of what Daniel caught. Even though there are a large number of

Re: RFR (JDK13/java.xml) 8224157: BCEL: update to version 6.3.1

On 6/21/19, 11:59 AM, Daniel Fuchs wrote: Hi Joe, I promise, I will not grumble about the formatting and weird white spaces [grumble grumble]... Someone at BCEL needs to re-format the source with a modern IDE ;-)

Re: RFR (JDK13/java.xml) 8224157: BCEL: update to version 6.3.1

Hi Joe, I promise, I will not grumble about the formatting and weird white spaces [grumble grumble]... http://cr.openjdk.java.net/~joehw/jdk13/8224157/webrev/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantUtf8.java.frames.html Is the new import really needed

RFR (JDK13/java.xml) 8224157: BCEL: update to version 6.3.1

Please review an update to BCEL 6.3.1. This changeset will go into JDK13 if approved, 14 if not. 1. Format The changeset looks big, the majority of the changes however were only different in format (i.e. Const.java). Unlike previous updates, I'm leaving the format as they are in the