I have no other comments.
Thanks,
Xuelei
On 3/20/2018 7:50 AM, Adam Petcher wrote:
Latest webrev: http://cr.openjdk.java.net/~apetcher/8181594/webrev.02/
Comments inline below.
In addition, I also changed the name of IntegerModuloP_Base to
IntegerModuloP, and IntegerModuloP to
Latest webrev: http://cr.openjdk.java.net/~apetcher/8181594/webrev.02/
Comments inline below.
In addition, I also changed the name of IntegerModuloP_Base to
IntegerModuloP, and IntegerModuloP to ImmutableIntegerModuloP.
On 3/11/2018 12:04 PM, Xuelei Fan wrote:
On 2/26/2018 10:39 AM, Adam
On 2/26/2018 10:39 AM, Adam Petcher wrote:
http://cr.openjdk.java.net/~apetcher/8181594/webrev.01/
See inline below.
On 2/23/2018 12:46 PM, Xuelei Fan wrote:
ArrayUtil.java:
===
I'm not very sure how widely this utilities will be used in the
future. Looks like only
Thanks for the initial feedback. Here is the latest webrev:
http://cr.openjdk.java.net/~apetcher/8181594/webrev.01/
See inline below.
On 2/23/2018 12:46 PM, Xuelei Fan wrote:
ArrayUtil.java:
===
I'm not very sure how widely this utilities will be used in the
future. Looks like
ArrayUtil.java:
===
I'm not very sure how widely this utilities will be used in the future.
Looks like only BigIntegerModuloP uses this classes. I may prefer to
define private methods for byte array swap in BigIntegerModuloP.
BigIntegerModuloP.java:
===
As
+core-libs-dev
On 1/26/2018 4:06 PM, Adam Petcher wrote:
JBS: https://bugs.openjdk.java.net/browse/JDK-8181594
Webrev: http://cr.openjdk.java.net/~apetcher/8181594/webrev.00/
This is a code review for the field arithmetic that will be used in
implementations of X25519/X448 key agreement, the
