xiaosage079 opened a new pull request #1034: add support for rwlock, a classic
approach
URL: https://github.com/apache/incubator-brpc/pull/1034
#1031 got error when travis-ci do linking like
bvar_percentile_unittest.cpp:(.text+0x35): undefined reference to
feifeiiong commented on issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth
flag存在的意义?
URL: https://github.com/apache/incubator-brpc/issues/1033#issuecomment-576132347
好的,我们尝试一下,谢谢!此外关于 **解析response时就知道哪个是auth的结果并跳过了。**
这里,因为我看到Parse相关的解析都是使用的pipline中的auth状态标志位,不知道还有哪里会使用到with_auth_flag呢?
zyearn commented on issue #1023: Please stop using include(FindXXX) in cmake
URL: https://github.com/apache/incubator-brpc/issues/1023#issuecomment-576129491
But `find_package` provides more options for user, so we may replace
`include` with `find_package`. The pr is here
zyearn commented on issue #1032: replace_include_with_find_package
URL: https://github.com/apache/incubator-brpc/pull/1032#issuecomment-576128661
cmake/FindGFLAGS.cmake and cmake/FindGperftools.cmake can not be deleted
because they are not builtin module of cmake, we still need it if user
jamesge edited a comment on issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth
flag存在的意义?
URL: https://github.com/apache/incubator-brpc/issues/1033#issuecomment-576126900
如果发送时的socket需要auth,controller里的with_auth
jamesge commented on issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth
flag存在的意义?
URL: https://github.com/apache/incubator-brpc/issues/1033#issuecomment-576126900
如果发送时的socket需要auth,controller里的with_auth
jamesge edited a comment on issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth
flag存在的意义?
URL: https://github.com/apache/incubator-brpc/issues/1033#issuecomment-576126900
如果发送时的socket需要auth,controller里的with_auth
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new 4e51908 Reset with_auth in controller
zyearn commented on issue #1023: Please stop using include(FindXXX) in cmake
URL: https://github.com/apache/incubator-brpc/issues/1023#issuecomment-576125295
`include(FindProtobuf)` will include the cmake/Modules/FindProtobuf.cmake
file, which uses find_library to find protolib. While
feifeiiong opened a new issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth
flag存在的意义?
URL: https://github.com/apache/incubator-brpc/issues/1033
**Describe the bug (描述bug)**
发生rpc重试时,socket的auth状态与pipline的auth状态有可能不一致。
模式:连接池
**To Reproduce (复现方法)**
zyearn commented on issue #1032: replace_include_with_find_package
URL: https://github.com/apache/incubator-brpc/pull/1032#issuecomment-576091247
according to https://github.com/apache/incubator-brpc/issues/1023,
find_package provide more options for user to set(such as CMAKE_PREFIX_PATH).
htn4179 removed a comment on issue #1025: brpc lack of rwlock implementation
URL: https://github.com/apache/incubator-brpc/issues/1025#issuecomment-576087063
#1031 is classic and less flag and status,
#1026 has more flag and status, We maximize the read performance,
So, I think it is
htn4179 commented on issue #1025: brpc lack of rwlock implementation
URL: https://github.com/apache/incubator-brpc/issues/1025#issuecomment-576087186
> so which one is the latest? #1031 or #1026?
#1031 is classic and less flag and status,
#1026 has more flag and status, We
htn4179 commented on issue #1025: brpc lack of rwlock implementation
URL: https://github.com/apache/incubator-brpc/issues/1025#issuecomment-576087063
#1031 is classic and less flag and status,
#1026 has more flag and status, We maximize the read performance,
So, I think it is your
hairet commented on issue #1025: brpc lack of rwlock implementation
URL: https://github.com/apache/incubator-brpc/issues/1025#issuecomment-576082950
> so which one is the latest? #1031 or #1026?
the implementation in 1031 will be more clear,it should be the latest
but in 1031
zyearn commented on issue #1025: brpc lack of rwlock implementation
URL: https://github.com/apache/incubator-brpc/issues/1025#issuecomment-576006843
so which one is the latest?
https://github.com/apache/incubator-brpc/pull/1031 or
https://github.com/apache/incubator-brpc/pull/1026?
zyearn removed a comment on issue #1030: rw lock implementation
URL: https://github.com/apache/incubator-brpc/issues/1030#issuecomment-576006645
what is the relationship with
https://github.com/apache/incubator-brpc/issues/1025?
zyearn commented on issue #1030: rw lock implementation
URL: https://github.com/apache/incubator-brpc/issues/1030#issuecomment-576006645
what is the relationship with
https://github.com/apache/incubator-brpc/issues/1025?
zyearn opened a new pull request #1032: replace_include_with_find_package
URL: https://github.com/apache/incubator-brpc/pull/1032
This is an automated message from the Apache Git Service.
To respond to the message, please
+1 binding
在 2020/1/19 下午5:21,“James Ge” 写入:
+1 binding
Solved issues (many thanks to Justin)
- Removed butil/memory/scoped_array.h which is replaceable by
unique_ptr
- Removed butil/md5.cc butil/md5.h test/md5_unittest.cc which is
replaceable by openssl/md5.h
hairet opened a new pull request #1031: add support for rwlock
URL: https://github.com/apache/incubator-brpc/pull/1031
补充写优先读写锁实现,变量和状态应该算是比较简洁的了,参考了内核写优先设计。
UT里有性能相关测试
This is an automated message from the Apache Git
+1 binding
Solved issues (many thanks to Justin)
- Removed butil/memory/scoped_array.h which is replaceable by
unique_ptr
- Removed butil/md5.cc butil/md5.h test/md5_unittest.cc which is
replaceable by openssl/md5.h
- Removed authors from headers
- Updated copyright years to this year
- Added
cloudhan commented on issue #1023: Please stop using include(FindXXX) in cmake
URL: https://github.com/apache/incubator-brpc/issues/1023#issuecomment-575980973
OK, to be more specific, what I have done is
```cmake
cmake_minimum_required(VERSION 3.5)
project(server CXX)
#...
Suse130224 closed pull request #1028: support unix socket
URL: https://github.com/apache/incubator-brpc/pull/1028
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
htn4179 commented on issue #1026: rwlock implementation based on atomic and
butex #1025
URL: https://github.com/apache/incubator-brpc/pull/1026#issuecomment-575978842
yes,I have fixed it!
This is an automated message from
25 matches
Mail list logo