I am new to this and hence might be missing something, please could someone
help me with this build error? I am having the latest build and getting the
following error;
2015-10-29 23:37:07,435 INFO [utils.net.NetUtilsTest] (main:) IP is
1234:5678::c3d9:fa56:870:77a3
2015-10-29 23:37:07,560 E
Thats a good idea. I have seen other open source projects do it this way.
(example: netty project)
On demand build is a better way than doing for every commit change.
especially when the code reviews are going on or there is WIP, its not
intended to do a build on every commit or update. (The commi
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/982#issuecomment-152441549
@remibergsma ... Will start testing now!
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-152441332
Ping @remibergsma @karuturi @kansal
I will run the hardware required tests as well and try to deployed a VM
with a shared network.
Partial
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/995#issuecomment-152440604
Ping @remibergsma @karuturi @kansal
Partial test results:
* Hardware required: false
* Management Server + MySQL on CentOS 7.1
* One
Jenkins though unstable is right at what it does. That is, if its green,
the build works fine, there are no check style errors, there are no new
PMD/Findbugs errors etc.
On the other hand, Travis green/red doesnt say anything at the moment. It
can be red due to a timeout and sometimes its green bec
Hi Remi,
I have opened the following ticket against 4.6:
https://issues.apache.org/jira/browse/CLOUDSTACK-9008
I found this issue tonight while running regression tests against 4.6.
As the ticket indicates, when using managed storage for your root disk,
attempting to revert a VM to a VM snapsho
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-152421311
@DaanHoogland Sorry It was something to do with my IDE's settings.
Corrected and rebased.
---
If your project is set up for it, you can reply to this email and have
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1006#issuecomment-152420812
Looks good to me, though I've not tested it. Since the key is the same
(content wise), it should not cause any security issue other than some naming
confusion.
-
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/1010
CLOUDSTACK-8996: Reducing Virual Machine Deployments
Combining testcases to reduce the VM deployments wherever possible.
You can merge this pull request into a Git repository by running:
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/897#issuecomment-152412317
Thanks @sudhansu7. I had also the similar idea. @remibergsma @runseb please
look at the comments of sudhansu. Thanks.
---
If your project is set up for it, y
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-152411793
Hi @wilderrodrigues, To check the bug is solved, try deploying the VM in
shared network with no service.
https://cloud.githubusercontent.com/assets/4276209/1
GitHub user rags22489664 opened a pull request:
https://github.com/apache/cloudstack/pull/1009
CLOUDSTACK-9006 - ListTemplates API returns result in inconsistent order
when called concurrently
The order of templates returned in the response is based on a field called
sortkey and by
Github user rags22489664 closed the pull request at:
https://github.com/apache/cloudstack/pull/949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-152379017
Sorry guys been a bit in flight, yes @DaanHoogland has point but tbh we
should fix that everywhere in one go for all the hypervisors not to be a
dick, but just sayi
2 hours before this message was sent, there was a message about
jenkins being unreliable.
So I am starting to think that something other than Travis or Jenkins
is the problem.
--David
On Thu, Oct 29, 2015 at 5:33 PM, Daan Hoogland wrote:
> Guys and dolls,
>
> We have been having travis builds f
GitHub user davidamorimfaria opened a pull request:
https://github.com/apache/cloudstack/pull/1008
adjust packaging for centos7
Here are a few adjustments for the packaging in centos7. With these changes
I was able to start the service. Please review. Thank you.
You can merge this
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/832#issuecomment-152337266
@remibergsma @wilderrodrigues @DaanHoogland Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-152332158
uservm can not start
2015-10-29 21:04:38,017 WARN [resource.wrapper.LibvirtStartCommandWrapper]
(agentRequest-Handler-5:nu
Trying to help out with the docs without doing too much damage.
I am new to git.
I am using Eclipse with the egit/mylyn plug-in and I have managed to get
the source for the docs-admin downloaded.
The "Configure Fetch" has a Source Ref of "refs/heads/*" and a
Desctination Ref of "refs/remotes
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1006#issuecomment-152306235
Thanks for the fix @nnesic ! Pinging @DaanHoogland @bhaisaab to review.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-152306229
ran
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
comp
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/982#issuecomment-152304547
@DaanHoogland @wilderrodrigues You can do this to test this PR:
```
./kvm_local_deploy.py -r xenserver65
/data/shared/helper_scripts/cloudstack/ch
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/982#issuecomment-152303070
@xenserverarmy Sure, it works. It's very easy, the files end up in
`/etc/xapi.d/plugins`. Are you able to verify yourself?
---
If your project is set up for it,
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-152302260
@wido @sateesh-chodapuneedi @bhaisaab can you please see if you are
satisfied with the present state (with respect to your comments)?
---
If your project is se
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/981#issuecomment-152302053
is 4.5 also affected by this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/832#issuecomment-152300766
@borisroman Can you force push this PR please and rebase it with current
master? Then we can run some tests! Pinging @dahn to look at the code.
---
If your proj
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-152300355
@remibergsma The commit didn't change, I just rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/941#discussion_r43433516
--- Diff: ui/scripts/network.js ---
@@ -6504,7 +6432,123 @@
}
}
}
-
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/941#discussion_r43433493
--- Diff: ui/scripts/network.js ---
@@ -6504,7 +6432,123 @@
}
}
}
-
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/941#discussion_r43433480
--- Diff: ui/scripts/network.js ---
@@ -4495,99 +4511,11 @@
$('').addClass('psk').html(_l('mess
Hi Nux, et all,
How would I go about adding a strongswan ipsec client to the macchinina
template?
Are you also responsible for the images here?
http://dl.openvm.eu/cloudstack/macchinina/x86_64/
Michael
On 08/05/15 16:12, "David Nalley" wrote:
>https://github.com/citrix/foreman-cloudstack
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-152293339
Will run the tests again since the commit changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1001#issuecomment-152292108
let's save this to the last moment but ltgm @remibergsma @karuturi
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/848
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-152291324
code reviewed as requested by @remibergsma no comments. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/945
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-152290835
code lgtm @remibergsma can you retest? A newer commit is in since your lgtm
---
If your project is set up for it, you can reply to this email and have your
repl
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/945#issuecomment-152290121
based on code review LGTM. @nitin-maharana makes sense to write a marvin
test for this. could you?
---
If your project is set up for it, you can reply to this
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1002
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152286968
Agree that the Jenkins failure is unrelated. Will soon merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/818#discussion_r43429125
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkVO.java ---
@@ -616,7 +616,8 @@ public void setStrechedL2Network(boolean
strechedL2Network)
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/927#issuecomment-152284702
@karuturi I tested the `test_vpc_site2site_vpn ` two more times, and it
keeps failing. The same tests on master succeeds and also on other branches I
recently te
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-152282736
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-152279403
@SudharmaJain Your change looks good at first sight. Did you verify that
your intended behaviour actually happens? and how? The name of the vpn is now
containin
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-152275904
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -
Github user sudhansu7 commented on the pull request:
https://github.com/apache/cloudstack/pull/897#issuecomment-152273822
@remibergsma @runseb
I have below performance analysis, which I did some time back. I trying to
find out the dbdump to do a real test. But below analysis will
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/961#issuecomment-152271301
@karuturi @K0zka @ustcweizhou @DaanHoogland @miguelaferreira I just
reverted the commit.
---
If your project is set up for it, you can reply to this email and h
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/961#issuecomment-152269280
@remibergsma this doesn't work in tomcat7 either. We ran tests on centos7
and only half a page is loaded.
---
If your project is set up for it, you can reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152264912
@remibergsma @wilderrodrigues Also ran the test against PR #981 => LGTM
:+1:
```
=== TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
I think I figured it out.
Started working on a subtask CLOUDSTACK-9004 to re-factor and add some needed
features to HyperVEnlightenmentFeatureDef.
I'll submit a PR for it once I finish and then start working on the
implementation mentioned in the parent task CLOUDSTACK-8978
__
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-152234419
code reviewed. nothing strange. lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152220381
It says test failures 0. I have no idea why it's red! In addition, no Java
code was changed!
![image](https://cloud.githubusercontent.com/assets/51
Hi Ron,
Yes you need an account on github.com
> On Oct 29, 2015, at 4:41 PM, Ron Wheeler
> wrote:
>
> I am new to this and trying to create a pull request in Eclipse and get the
> message:
> "Unexpected error: API rate limit exceeded for 24.37.79.202."
>
> It goes on to suggest that balance
I am new to this and trying to create a pull request in Eclipse and get
the message:
"Unexpected error: API rate limit exceeded for 24.37.79.202."
It goes on to suggest that balance would be restored to the universe if
I was authenticated.
Do I need to have an account to create pull requests?
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/897#issuecomment-152214761
@nitin-maharana I looked at this, seems good. What is the best way to test
this or see the difference?
---
If your project is set up for it, you can reply to th
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1005#issuecomment-152213938
@wido You'd onky changed a methode name and added a getter. But no Unit
test were added right? Forgot "git add ." before commiting?
---
If your project is set u
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152208845
@serbaut If you think this should go into master, please comment LGTM
(Looks Good To Me) with any testing / verification you did. We need 2 LGTMs
before we can
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/961#issuecomment-152208509
@K0zka If you know of a fix for Tomcat6 we can merge that. Otherwise I
think we should consider reverting. We can wait a bit but if there is no
solution at the t
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/981
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/996#issuecomment-152205902
@remibergsma just checked this does not apply for 4.5, 4.5 has no prefilter
in that section
(see screenshot on 4.5)
![screen shot 2015-10-29 at 8 25 52
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/996#issuecomment-152203911
@remibergsma good idea, will do thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152203550
LGTM
Run this:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true
test/integration/component/t
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/996#issuecomment-152202839
Ping @bhaisaab you may want to backport this small fix to 4.5
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/996
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/996#issuecomment-152201239
LGTM as well!
![screen shot 2015-10-29 at 15 41
17](https://cloud.githubusercontent.com/assets/1630096/10821620/8e8cd2ae-7e53-11e5-94ca-9ef5b251da5d.png)
Build environment isn't Windows, it's Ubuntu 14.04 that I am getting this build
failure on.
From: Wido den Hollander
Sent: Thursday, October 29, 2015 1:50 AM
To: dev@cloudstack.apache.org
Subject: Re: Build fails on LocalTemplateDownloadTest
Josh Harsh
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-152197682
@nvazquez I havent' forgotten your PR. I'm having some trouble with the
automation to re-create a NSX cluster with a KVM host in our test environment.
As soo
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-152196235
Hi @kansal
Should I deploy a basic zone with shared network in order to see if that
fix is fine?
I will also run the other set of tests, s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-152195378
@snuf Can you respond to the comment by @dahn? Then we can proceed to merge
this. Thanks!
---
If your project is set up for it, you can reply to this email and
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1002#discussion_r43389852
--- Diff: test/integration/component/test_router_dhcphosts.py ---
@@ -0,0 +1,381 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-152193618
by the way, for user vms, I think it is better to add the field in
vm_instance/user_vm or zone/cluster/global setting to determine if the vm is
qemu guest agent
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152194820
@wilderrodrigues Testing this now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/995#issuecomment-152192762
Testing this PR now.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Hi all,
Just had a chat with Miguel.
He showed me that if we setup Github to notify Jenkins on “issue comments”
(next to “pull requests” we have now) and then set a “trigger phrase” in
Jenkins, we could automatically trigger a new build by typing “go build”. No
more need to force push commits b
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-152191665
that is good idea. then we need to rebuild systemvm template with
qemu-guest-agent
---
If your project is set up for it, you can reply to this email and have yo
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152189749
@remibergsma @karuturi
All green... Do you have some time to review/merge this PR? It's a test, no
code - neither on the routers nor the java side
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-152189257
Ping @remibergsma @snuf
I did not test any OVM3 specifics, but @snuf did. The PR doesn't break
existing functionality.
Although the "hardwa
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-152188711
Hmm, ok. That should be allowed. Since we want the Guest tools also to be
supported on SSVMs to control them properly.
---
If your project is set up for it, you can re
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/996#issuecomment-152187750
Ping @remibergsma @DaanHoogland @borisroman @wido @miguelaferreira
Thanks, @karuturi! :) LGTM :+1:
Test results:
* Hardware req
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-152187084
succeed after the following change:
diff --git
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
b/plugins/
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-152183473
I have same issue with Remi,
there are two virtio-serial in the vm definition.
---
If your project is set up for it, you can reply to this email and have you
On Thu, Oct 29, 2015 at 2:38 PM, Sebastien Goasguen
wrote:
> > On Oct 29, 2015, at 2:28 PM, Daan Hoogland
> wrote:
> > On Thu, Oct 29, 2015 at 2:22 PM, Sebastien Goasguen
> >>> On Oct 29, 2015, at 2:19 PM, Daan Hoogland
> >>> Sebastien, it is not urgent but costing us time
> >>
> >> so just do
> On Oct 29, 2015, at 2:28 PM, Daan Hoogland wrote:
>
> On Thu, Oct 29, 2015 at 2:22 PM, Sebastien Goasguen
> wrote:
>
>>
>>> On Oct 29, 2015, at 2:19 PM, Daan Hoogland
>> wrote:
>>>
>>> Sebastien, it is not urgent but costing us time
>>
>> so just don;t look at it ?
>>
> no-op. it is th
Github user serbaut commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1002#discussion_r43384431
--- Diff: test/integration/component/test_router_dhcphosts.py ---
@@ -0,0 +1,381 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user serbaut commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152180011
Thank you, that would have taken me days to write.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
On Thu, Oct 29, 2015 at 2:22 PM, Sebastien Goasguen
wrote:
>
> > On Oct 29, 2015, at 2:19 PM, Daan Hoogland
> wrote:
> >
> > Sebastien, it is not urgent but costing us time
>
> so just don;t look at it ?
>
no-op. it is there telling people that everything worked and if failed we
get questions a
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/961#issuecomment-152178160
@K0zka @karuturi I am using tomcat 6 as well. agree with Rajani
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
> On Oct 29, 2015, at 2:19 PM, Daan Hoogland wrote:
>
> Sebastien, it is not urgent but costing us time
so just don;t look at it ?
> and more important costing
> time of 'innocent' contributors.
What do you mean by that, I am not understanding.
> So ... revert at your will.
>
> On Thu, Oct
Hi,
We are building Debian packages on unstable branches (4.5 branch to be
specific). The Debian source format 30. rejects the version 4.5.3-SNAPSHOT
with an error "Can't build with source format 3.0 native: native package
version may not have a revision."
Source format 1.0 allows this value, and
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1007
CLOUDSTACK-8958: add dedicated ips to domain (account for now)
For now, we dedicate ip pool to account, however, other accounts in the
same domain cannot fetch the ip from this ip pool.
Sebastien, it is not urgent but costing us time and more important costing
time of 'innocent' contributors. So ... revert at your will.
On Thu, Oct 29, 2015 at 1:44 PM, Sebastien Goasguen
wrote:
> Not surprisingly I like Travis, because it outsources the “tests” and that
> we can fix them by edi
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/961#issuecomment-152176166
Hi @k0zka are you saying it might be specific to tomcat6? Reverting the the
change works fine.
Do you think we should revert this until we find a solution which
Github user serbaut commented on the pull request:
https://github.com/apache/cloudstack/pull/981#issuecomment-152175108
Sorry, been busy. Running tests now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user nnesic opened a pull request:
https://github.com/apache/cloudstack/pull/1006
Fixed user_vm_view to only display keypairs belonging to the account.
The user_vm_view displayes the keypair information by joining vm_details
with ssh_keypairs on the key value exclusively.
Not surprisingly I like Travis, because it outsources the “tests” and that we
can fix them by editing .travis.yml, which can be done by someone without
access to the Jenkins servers/slaves.
At the very least I agree with Miguel which should keep the mvn build, and
possible rat etc…
Personally,
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-152165313
@resmo the field value and label is same as on the detail view's Nic tab -
the default nic (or nic 1).
I'm sure there are more better ways of fixing the UI
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-152163454
Yes I see, but the label "IP address" does not indicate that it is the
first NIC's IP address :). It might make sense to change the label to be more
precise in that.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-152162038
@resmo the IP of the first nic, not necessarily public/private. I removed
displayname as adding ip address column screwed up the width/alignment issue
and it's a r
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-152161769
@wido I will also test it again today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
1 - 100 of 165 matches
Mail list logo