Hi all,
Here is the meeting notes for the last DPDK technical board meeting
held on 2017-07-05.
Member attendees:
- Hemant Agrawal
- Jan Blunck
- Jerin Jacob
- Olivier Matz
- Stephen Hemminger
- Thomas Monjalon
- Yuanhan Liu
0. Release blocking issues
No major issues, but as always, we lack
On Mon, Jul 10, 2017 at 01:19:06AM +, Wu, Jingjing wrote:
> > -Original Message-
> > From: Yuanhan Liu [mailto:y...@fridaylinux.org]
> > Subject: [PATCH 2/2] testpmd: give more hint on invalid RETA size
> >
> > Print the valid RTE size range so t
On Tue, Jul 04, 2017 at 05:13:37PM +0100, Ferruh Yigit wrote:
> @@ -157,8 +164,12 @@ rte_eth_dev_pci_generic_probe(struct rte_pci_device
> *pci_dev,
>
> RTE_FUNC_PTR_OR_ERR_RET(*dev_init, -EINVAL);
> ret = dev_init(eth_dev);
> - if (ret)
> + if (ret) {
> rte_eth
On Fri, Jul 07, 2017 at 12:52:48PM -0700, Stephen Hemminger wrote:
> While doing code for Hyper-V, noticed that the virtio driver was
> confused about receive versus transmit offloads. The virtio
> checksum offload is L4 (TCP/UDP) only, not IPv4. Also, TSO
> and LRO are not the same.
>
> This may
On Fri, Jul 07, 2017 at 02:21:28PM +0200, Thomas Monjalon wrote:
> 08/07/2017 07:21, Changpeng Liu:
> > MAINTAINERS | 2 +
> > doc/guides/sample_app_ug/vhost_scsi.rst | 110 +++
> > examples/Makefile | 2 +-
> > examples/vhost_scsi/Makefile
On Fri, Jul 07, 2017 at 02:10:57PM +0530, Hemant Agrawal wrote:
> On 7/7/2017 10:37 AM, Yuanhan Liu wrote:
> >On Sat, Jul 08, 2017 at 01:21:37PM +0800, Changpeng Liu wrote:
> >>vhost-user protocol is common to many virtio devices, such as
> >>virtio_net/virtio_scsi/v
Print the valid RTE size range so that user knows what goes wrong.
Signed-off-by: Yuanhan Liu
---
app/test-pmd/cmdline.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index c8faef9..d32a1df 100644
--- a/app/test-pmd
Currently, testpmd just allows to query the RETA info only when the
required size equals to configured RETA size.
This patch allows to query any RETA size <= the configured size. This
helps when the RETA size is big (say 512) and when I just want to peak
few RETA entries.
Signed-off-by: Yuan
On Sat, Jul 08, 2017 at 01:21:37PM +0800, Changpeng Liu wrote:
> vhost-user protocol is common to many virtio devices, such as
> virtio_net/virtio_scsi/virtio_blk. Since DPDK vhost library
> removed the NET specific data structures, the vhost library
> is common to other virtio devices, such as vir
On Sat, Jul 08, 2017 at 12:14:51PM +0800, Changpeng Liu wrote:
> +.. note::
> +You must check whether your Qemu can support "vhost-user-scsi" or not,
> +Qemu v2.9.50 or newer version is required.
QEMU v2.9.50 looks like a stable version, and I don't think they will
backport new features on
On Fri, Jul 07, 2017 at 02:00:38AM +, Liu, Changpeng wrote:
>
>
> > -Original Message-
> > From: Yuanhan Liu [mailto:y...@fridaylinux.org]
> > Sent: Friday, July 7, 2017 8:51 AM
> > To: Liu, Changpeng
> > Cc: dev@dpdk.org
> > Subject: R
On Thu, Jun 29, 2017 at 05:28:32PM +0800, Changpeng Liu wrote:
> +.. note::
> +You must check whether you Qemu can support "vhost-user-scsi" or not,
> +the latest Qemu code is recommended.
You should specify the least QEMU version that supports vhost-user scsi here.
> +
> +Common Issues
>
On Thu, Jul 06, 2017 at 04:30:43PM +0300, Ilya Maximets wrote:
> syscall always returns '-1' on failure and there is no point
> in printing that value. 'errno' is much more informative.
>
> Fixes: 586e39001317 ("vhost: export numa node")
>
> Signed-off-by: Ilya Maximets
Applied to dpdk-next-vir
On Fri, Jun 23, 2017 at 12:14:45AM -0400, Yong Wang wrote:
> Since "rte_eal_dev_init()" has been removed, the comment referred to
> it should be modified simultaneously.
>
> Signed-off-by: Yong Wang
Applied to dpdk-next-virtio. Thanks.
--yliu
On Fri, Jun 23, 2017 at 08:41:37AM -0400, Allain Legacy wrote:
> The rte_eth_dev.data pointer is set to a reference to a static table.
> Attempting to rte_free() it leads to a panic. For example, the
> following commands result in a panic if run in testpmd
>
> testpmd> port attach virtio_user0,
On Tue, Jul 04, 2017 at 10:50:42AM +0200, Jens Freimann wrote:
> +out_mutex:
> + if (pthread_mutex_destroy(&vsocket->conn_mutex))
> + RTE_LOG(ERR, VHOST_CONFIG,
> + "error: failed to destroy connection mutex\n");
One minor comment though: {} should be used for o
On Tue, Jul 04, 2017 at 10:50:40AM +0200, Jens Freimann wrote:
> This series is a bunch of small cleanups regarding checking return values etc.
Series applied to dpdk-next-virtio. You probably need update your script
(if you are using one) about my email address.
Thanks.
--yliu
Again, just some quick comments after a glimpse.
On Sat, Jul 01, 2017 at 07:08:42PM +0800, Jiayu Hu wrote:
> + for (i = 0; i < nb_pkts; i++) {
> + if (RTE_ETH_IS_IPV4_HDR(pkts[i]->packet_type) &&
> + (pkts[i]->packet_type & RTE_PTYPE_L4_TCP)) {
> +
Haven't looked at the details yet, and below are some quick comments
after a glimpse.
On Sat, Jul 01, 2017 at 07:08:41PM +0800, Jiayu Hu wrote:
...
> +void *rte_gro_tbl_create(const
> + const struct rte_gro_param *param)
The DPDK style is:
void *
rte_gro_tbl_destroy(...)
Also you sh
On Mon, Jul 03, 2017 at 05:56:20AM +, Hu, Jiayu wrote:
> > > +/**
> > > + * GRO table, which is used to merge packets. It keeps many reassembly
> > > + * tables of desired GRO types. Applications need to create GRO tables
> > > + * before using rte_gro_reassemble to perform GRO.
> > > + */
> >
Hi all,
The next meeting of the techboard will happen on IRC #dpdk-board,
at 3pm UTC, this Wednesday 5th of July.
The agenda is updated here:
https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db
For your convenience, I copied it here.
0. Release blocking issues?
On Thu, Jun 29, 2017 at 08:01:45AM +, Tan, Jianfeng wrote:
>
>
> > -Original Message-
> > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> > Sent: Thursday, June 29, 2017 3:58 PM
> > To: dev@dpdk.org; y...@fridaylinux.org
> > Cc: i.dyu...@samsung.com; Tan, Jianfeng; sta...@
On Wed, Jun 28, 2017 at 03:40:31PM +0300, Ivan Dyukov wrote:
> To compare enabled features in current device we must use bit
> mask instead of bit position.
>
> CC: sta...@dpdk.org
> Fixes: c843af3aa13e ("vhost: access header only")
>
> Signed-off-by: Ivan Dyukov
Applied to dpdk-next-virtio.
T
On Fri, Jun 30, 2017 at 02:43:47PM +, Mcnamara, John wrote:
>
>
> > -Original Message-
> > From: Yang, Zhiyong
> > Sent: Thursday, May 11, 2017 3:17 AM
> > To: dev@dpdk.org
> > Cc: Mcnamara, John ; yuanhan@linux.intel.com;
> > maxime.coque...@redhat.com; Yang, Zhiyong
> > Subject
P csum.
> >
> >Fixes: 859b480d5afd ("vhost: add guest offload setting")
> >Cc: sta...@dpdk.org
> >
> >Cc: Yuanhan Liu
> >Cc: Maxime Coquelin
> >Cc: Jiayu Hu
> >Signed-off-by: Jianfeng Tan
>
> Reviewed-by: Maxime Coquelin
Series applied to dpdk-next-virtio.
Thanks!
--yliu
On Wed, Jun 14, 2017 at 10:19:53AM +0200, Jens Freimann wrote:
> On Mon, Jun 12, 2017 at 02:29:04PM -0700, Daniel Verkamp wrote:
> > vsocket->conn_mutex was allocated with pthread_mutex_init() but never
> > freed with pthread_mutex_destroy(). This is a potential memory leak,
> > depending on how p
Tx buffer
Yuanhan Liu (2):
vhost: fix crash on NUMA
version: 17.05.1
dundant free of Tx buffer
Yuanhan Liu (1):
vhost: fix crash on NUMA
On Tue, Jun 20, 2017 at 09:35:07AM +0200, Thomas Monjalon wrote:
> 20/06/2017 06:14, santosh:
> > On Tuesday 20 June 2017 02:07 AM, Thomas Monjalon wrote:
> >
> > > 08/06/2017 16:28, Santosh Shukla:
> > >> Let test_mbuf alloc and free mempool.
> > >>
> > >> Cc: sta...@dpdk.org
> > >> Signed-off-by
vhost: fix memory leak
vhost: added error log for badly negotiated features
Jens Freimann (1):
vhost: check malloc return value when allocating guest pages
Tiwei Bie (1):
net/virtio: zero the whole memory zone
Yuanhan Liu (1):
vhost: fix crash on NUMA
Zhihong Wang (1
On Fri, Jun 16, 2017 at 04:32:05PM +0200, Dariusz Stojaczyk wrote:
> Since vhost_user_set_features failure is not handled in any way, a
> single error log has been added to at least to let the user know that
> something has gone wrong.
Indeed. And applied to dpdk-next-virtio.
Thanks.
--y
On Mon, Jun 05, 2017 at 04:44:33PM +0100, Brian Russell wrote:
> In virtio_read_caps, rte_pci_read_config returns the number of bytes
> read from PCI config or <0 on error.
> If less than the expected number of bytes are read then log the
> failure and return rather than carrying on with garbage.
>
On Mon, Jun 12, 2017 at 12:34:30PM +0800, Tiwei Bie wrote:
> Zero the whole memory zone instead of the first few bytes.
>
> Fixes: c1f86306a026 ("virtio: add new driver")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Tiwei Bie
> ---
> drivers/net/virtio/virtio_ethdev.c | 2 +-
> 1 file changed, 1 in
On Thu, Jun 01, 2017 at 02:56:30PM +0800, Beilei Xing wrote:
> This commit optimizes vxlan parsing function.
How?
--yliu
> Signed-off-by: Beilei Xing
> ---
> drivers/net/i40e/i40e_flow.c | 176
> ++-
> 1 file changed, 55 insertions(+), 121 delet
On Fri, Jun 02, 2017 at 10:20:38AM +0200, Jens Freimann wrote:
> On Fri, Jun 02, 2017 at 08:14:46AM +0800, Yuanhan Liu wrote:
> > The queue allocation was changed, from allocating one queue-pair at a
> > time to one queue at a time. Most of the changes have been done, but
> >
Signed-off-by: Yuanhan Liu
---
- I left Intel today.
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index afb4cab..f6095ef 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -424,7 +424,7 @@ F: doc/guides/nics/vmxnet3.rst
F: doc
oh (3):
net/mlx5: fix reusing Rx/Tx queues
net/mlx5: fix index handling for Tx ring
net/mlx5: fix rollback when starting device
Yuanhan Liu (5):
vhost: fix multiple queue not enabled for old kernels
vhost: fix max queues
vhost: fix fd leaks for vhost-user server
On Thu, Jun 01, 2017 at 09:36:39AM +, Dumitrescu, Cristian wrote:
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tiwei Bie
> > Hello everyone,
> >
> > We'd like to make a proposal of making DPDK.org allow hosting
> > some personal/project repos, which could be very useful when
> > so
, crash may happen.
Fix it by specifying the right copy size. Also, the net queue macros
are not used any more. Remove them.
Fixes: ab4d7b9f1afc ("vhost: turn queue pair to vring")
Cc: sta...@dpdk.org
Reported-by: Ciara Loftus
Signed-off-by: Yuanhan Liu
---
lib/librte_vhost/vhost_user.c |
Wang (2):
net/fm10k: fix pointer cast
net/virtio: fix queue notify
Yong Wang (2):
net/e1000/base: fix multicast setting in VF
net/ena: fix return of hash control flushing
Yongseok Koh (1):
net/mlx5: fix reusing Rx/Tx queues
Yuanhan Liu (7):
vhost: fix multiple
):
doc: fix a typo in howto guide
net/e1000/base: fix multicast setting in VF
net/ena: fix return of hash control flushing
Yongseok Koh (3):
net/mlx5: fix reusing Rx/Tx queues
net/mlx5: fix index handling for Tx ring
net/mlx5: fix rollback when starting device
Yuanhan
On Fri, May 26, 2017 at 01:59:12PM +0200, Dariusz Stojaczyk wrote:
> Fixes for memory-related undefined behavior issues in rte_vhost.
>
> Daniel Verkamp (1):
> vhost: access VhostUsrMsg via packed struct
>
> Dariusz Stojaczyk (2):
> vhost: fix malloc in rte_vhost_get_mem_table()
> vhost: fr
On Wed, May 24, 2017 at 01:12:07PM +, Stojaczyk, DariuszX wrote:
> > This is for fixing compile warnings with new clang 4.0?
> >
> > http://dpdk.org/ml/archives/dev/2017-April/064089.html
> >
> > If so, please show the exact warning in the commit log.
> >
>
> Everything compiles, but is
On Fri, May 26, 2017 at 01:18:02PM -0400, Zhihong Wang wrote:
> This patch implements the ops rx_queue_count for vhost PMD by adding
> a helper function rte_vhost_rx_queue_count in vhost lib.
>
> The ops rx_queue_count gets vhost RX queue avail count and helps to
> understand the queue fill level.
On Wed, May 24, 2017 at 12:10:57PM +0100, Kevin Traynor wrote:
> On 05/22/2017 06:20 AM, Yuanhan Liu wrote:
> > Hi all,
> >
> > Here is a list of patches targeted for 16.11.2 (LTS) release. Please
> > help review and test. The planned date for the final release is
On Wed, May 24, 2017 at 10:36:01AM +0200, Jens Freimann wrote:
> On Wed, May 24, 2017 at 04:14:19PM +0800, Yuanhan Liu wrote:
> > On Tue, May 23, 2017 at 12:51:56PM +, Wang, Zhihong wrote:
> > >
> > >
> > > > -Original Message-
> > > &
On Tue, May 23, 2017 at 12:51:56PM +, Wang, Zhihong wrote:
>
>
> > -Original Message-
> > From: Jens Freimann [mailto:jfrei...@redhat.com]
> > Sent: Tuesday, May 23, 2017 7:54 PM
> > To: Wang, Zhihong
> > Cc: dev@dpdk.org; yuanhan@linux.intel.com
> > Subject: Re: [dpdk-dev] [PATC
On Tue, May 23, 2017 at 09:05:38AM +, Hemant Agrawal wrote:
> Which is the next DPDK LTS release?
There is no answer yet. It could be v18.11. There was also a request for
proposing v17.11 to be the next LTS.
> Is 17.05 a DPDK LTS release?
Nope, it's not in the plan.
> Do we need to send a
On Thu, May 18, 2017 at 10:24:07PM +0800, Yuanhan Liu wrote:
> On Wed, May 17, 2017 at 01:30:21PM +0200, Jens Freimann wrote:
> > Hi Yuanhan,
> >
> > On Mon, May 08, 2017 at 01:02:57PM +0800, Yuanhan Liu wrote:
> > > On Fri, May 05, 2017 at 09:57:11AM -0400, Je
On Thu, May 11, 2017 at 04:33:12PM +0200, Dariusz Stojaczyk wrote:
> From: Daniel Verkamp
>
> Fixes unaligned access to fields.
This is for fixing compile warnings with new clang 4.0?
http://dpdk.org/ml/archives/dev/2017-April/064089.html
If so, please show the exact warning in the commit
; and is unlikely to be followed in practice.
>
> The first example is the way people write text and the way text is submitted
> in patches so the guidelines should reflect this.
+1 for the first one :)
And,
Reviewed-by: Yuanhan Liu
--yliu
On Thu, May 18, 2017 at 10:14:26AM +0200, Maxime Coquelin wrote:
>
>
> On 05/11/2017 05:25 PM, Jens Freimann wrote:
> >When we try to allocate guest pages we need to check the return value of
> >malloc(). Print an error message and return when it fails.
> >
> >Signed-off-by: Jens Freimann
> >---
setting
Xiao Wang (2):
net/fm10k: fix pointer cast
net/virtio: fix queue notify
Yong Wang (2):
net/e1000/base: fix multicast setting in VF
net/ena: fix return of hash control flushing
Yongseok Koh (1):
net/mlx5: fix reusing Rx/Tx queues
Yuanhan Liu (6):
vhost: fix
On Wed, May 17, 2017 at 01:30:21PM +0200, Jens Freimann wrote:
> Hi Yuanhan,
>
> On Mon, May 08, 2017 at 01:02:57PM +0800, Yuanhan Liu wrote:
> > On Fri, May 05, 2017 at 09:57:11AM -0400, Jens Freimann wrote:
> > > I'm implementing the receive path now to
On Mon, May 15, 2017 at 10:26:00AM +0100, Ferruh Yigit wrote:
> On 5/15/2017 10:19 AM, Yuanhan Liu wrote:
> > On Mon, May 15, 2017 at 10:17:43AM +0100, Ferruh Yigit wrote:
> >> On 5/12/2017 11:33 AM, Ferruh Yigit wrote:
> >>> remove __rte_unused instances that are no
On Mon, May 15, 2017 at 10:17:43AM +0100, Ferruh Yigit wrote:
> On 5/12/2017 11:33 AM, Ferruh Yigit wrote:
> > remove __rte_unused instances that are not required.
> >
>
> Hi Yuanhan,
>
> Does this kind of refactoring patches, specially the ones covering
> multiple drivers, cause trouble (more c
On Fri, May 12, 2017 at 11:33:03AM +0100, Ferruh Yigit wrote:
> remove __rte_unused instances that are not required.
I'm wondering this is done by some scripts?
--yliu
ge them
> accordingly.
>
> regards,
> Jens
>
>
>
> Yuanhan Liu (11):
> net/virtio: vring init for 1.1
> net/virtio: implement 1.1 guest Tx
> net/virtio-user: add option to enable 1.1
> vhost: enable 1.1 for testing
> vhost: set desc addr for 1.1
&
On Fri, May 05, 2017 at 04:21:53PM +0200, Thomas Monjalon wrote:
> 05/05/2017 02:40, Wei Dai:
> > Some customers find adding MAC addr to VF sometimes can fail,
> > but it is still stored in dev->data->mac_addrs[ ]. So this
> > can lead to some errors that assumes the non-zero entry in
> > dev->data
On Thu, May 04, 2017 at 12:14:30AM +, Mody, Rasesh wrote:
>
>
> > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com]
> > Sent: Monday, May 01, 2017 11:15 PM
> >
> > On Tue, Apr 25, 2017 at 12:28:46AM -0700, Rasesh Mody wrote:
> > > From: Rasesh Mod
On Tue, May 02, 2017 at 08:44:23PM +0800, Wei Dai wrote:
> Some customers find adding MAC addr to VF sometimes can fail,
> but it is still stored in dev->data->mac_addrs[ ]. So this
> can lead to some errors that assumes the non-zero entry in
> dev->data->mac_addrs[ ] is valid.
> Following acknowle
On Tue, Apr 25, 2017 at 12:28:46AM -0700, Rasesh Mody wrote:
> From: Rasesh Mody
>
> Changes included in this fix
> - limit CFLAGS to base files
> - fix to remove/mark unused members
> - add checks for debug config option
> - make qede_set_mtu() and qede_udp_dst_port_del() static and others
>
On Fri, Apr 28, 2017 at 11:00:07AM +0200, Thomas Monjalon wrote:
> 28/04/2017 10:27, Yuanhan Liu:
> > On Fri, Apr 28, 2017 at 10:15:46AM +0200, Thomas Monjalon wrote:
> > > 28/04/2017 09:21, Yuanhan Liu:
> > > > Some commits for stable releases (with Cc stable tag) ma
On Fri, Apr 28, 2017 at 10:15:46AM +0200, Thomas Monjalon wrote:
> 28/04/2017 09:21, Yuanhan Liu:
> > Some commits for stable releases (with Cc stable tag) may not have the
> > fixline. For example:
> > http://dpdk.org/dev/patchwork/patch/23955/
> >
> &
On Fri, Apr 28, 2017 at 09:57:20AM +0200, Maxime Coquelin wrote:
> >>>Maybe we could introduce a version message? With that, we could tell
> >>>whether the frontend has fixed the known bug or not.
> >>
> >>That's a possibility, but this is not really the role of a protocol
> >>version. As in this c
On Fri, Apr 28, 2017 at 03:35:53PM +0800, Yuanhan Liu wrote:
> > >Maybe we could introduce a version message? With that, we could tell
> > >whether the frontend has fixed the known bug or not.
> >
> > That's a possibility, but this is not really the role of a pr
On Fri, Apr 28, 2017 at 09:23:54AM +0200, Maxime Coquelin wrote:
>
>
> On 04/28/2017 04:25 AM, Yuanhan Liu wrote:
> >On Thu, Apr 27, 2017 at 10:52:20AM +0200, Maxime Coquelin wrote:
> >>
> >>
> >>On 04/27/2017 10:20 AM, Yuanhan Liu wrote:
> >&g
s. Thus, this patch makes
git-log-fixes.sh script also list those stable commits do not have
fixline.
Signed-off-by: Yuanhan Liu
---
devtools/git-log-fixes.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
index 3bf
K since 16.04, but it's
> still unproven in rich use cases in hardware. Therefore it's marked as
> experimental for now, will enable it after enough field test and possible
> optimization.
>
> Signed-off-by: Zhihong Wang
Reviewed-by: Yuanhan Liu
--yliu
On Wed, Feb 22, 2017 at 10:34:23AM +0800, Yuanhan Liu wrote:
> On Mon, Feb 20, 2017 at 10:04:45PM +0800, hanxue...@126.com wrote:
> > From: Huanle Han
> >
> > The dev detachable flag was removed by
> > commit f229eb4 ("net/virtio: fix rewriting LSC flag"
On Wed, Feb 22, 2017 at 10:24:13AM +0800, Yuanhan Liu wrote:
> On Mon, Feb 20, 2017 at 10:04:46PM +0800, hanxue...@126.com wrote:
> > From: Huanle Han
> >
> > This commit fixs segment fault when rte_eth_dev_close()
> > is called on a virtio dev more than once.
>
On Fri, Apr 21, 2017 at 02:28:09AM +, Jianfeng Tan wrote:
> Segfault happens when using virtio-user after commit 7f0a669e7b04
> ("ethdev: add allocation helper for virtual drivers").
>
> It's due to we use ethdev->device to recognize physical devices,
> but after above commit, this field is al
On Thu, Apr 27, 2017 at 07:35:37AM +, Jianfeng Tan wrote:
> LSC flag is set in several places, but only the last one takes effect;
> so we remove the redundant ones and just keep the last one.
Note that I modified this commit log a bit. It actually fixed a bug: the
dev_flags is being overwritt
On Thu, Apr 27, 2017 at 07:35:35AM +, Jianfeng Tan wrote:
> v2:
> - Split 2nd patch into two patches.
>
> Patch 1: fix wrong MSI-X for modern devices so that LSC is always not
> available.
> Patch 2: clean up LSC setting.
> Patch 3: remove redundant MSI-X detection
> Patch 4: fix li
On Thu, Apr 27, 2017 at 12:00:52PM +0200, Maxime Coquelin wrote:
>
>
> On 04/27/2017 11:41 AM, Zhiyong Yang wrote:
> > vhost since dpdk17.02 + qemu2.7 and above will cause failures of
> >new connection when negotiating to set MQ. (one queue pair works
> >well).
> >Because there exist some b
On Thu, Apr 27, 2017 at 10:52:20AM +0200, Maxime Coquelin wrote:
>
>
> On 04/27/2017 10:20 AM, Yuanhan Liu wrote:
> >On Thu, Apr 27, 2017 at 09:56:47AM +0200, Maxime Coquelin wrote:
> >>Hi Zhiyong,
> >>
> >>+Marc-André
> >>
> >>
On Thu, Apr 27, 2017 at 09:56:47AM +0200, Maxime Coquelin wrote:
> Hi Zhiyong,
>
> +Marc-André
>
> On 04/27/2017 08:34 AM, Zhiyong Yang wrote:
> >vhost since dpdk17.02 + qemu2.7 and above will cause failures of
> >new connection when negotiating to set MQ. (one queue pair works
> >well).Because t
On Thu, Apr 27, 2017 at 02:34:53PM +0800, Zhiyong Yang wrote:
> vhost since dpdk17.02 + qemu2.7 and above will cause failures of
> new connection when negotiating to set MQ. (one queue pair works
> well).Because there exist some bugs in qemu code when introducing
> VHOST_USER_PROTOCOL_F_REPLY_ACK t
On Thu, Apr 27, 2017 at 07:35:37AM +, Jianfeng Tan wrote:
> LSC flag is set in several places, but only the last one takes effect;
> so we remove the redundant ones and just keep the last one.
I think this patch would also fix the issue reported by:
http://dpdk.org/dev/patchwork/patch/2055
On Wed, Apr 26, 2017 at 09:45:42AM +0200, Maxime Coquelin wrote:
> As said, only cosmetic comments, it looks otherwise valid to me.
> If you fix these, feel free to add my:
> Acked-by: Maxime Coquelin
Oops, I forgot to reply this thread, that I have already applied it :/
--yliu
On Wed, Apr 26, 2017 at 05:44:05AM +, Tan, Jianfeng wrote:
>
>
> > -Original Message-
> > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com]
> > Sent: Wednesday, April 26, 2017 1:33 PM
> > To: Tan, Jianfeng
> > Cc: dev@dpdk.org; maxime.coqu
On Wed, Apr 26, 2017 at 04:52:50AM +, Jianfeng Tan wrote:
> Clean up LSC setting:
Firstly, this patch does two things. There should be two patches.
> - LSC flag is set in several places, but only the last one takes
> effect; so we just keep the last one.
> - As we already change to us
> Fixes: 6a7c0dfcdf40 ("net/virtio: do not depend on PCI device of ethdev")
>
> Signed-off-by: Jianfeng Tan
Acked-by: Yuanhan Liu
--yliu
t; /usr/include/linux/vhost.h: At top level:
> /usr/include/linux/vhost.h:73:3: error: ISO C99 doesn't support unnamed
> structs/unions [-Werror=pedantic]
> [...]
>
> Fixes: eb32247457fe ("vhost: export guest memory regions")
> Fixes: a798beb47c8e ("vhost: rename header file")
>
> Cc: Yuanhan Liu
> Cc: Maxime Coquelin
> Signed-off-by: Adrien Mazarguil
Acked-by: Yuanhan Liu
--yliu
On Fri, Apr 21, 2017 at 11:28:37AM +0200, Thomas Monjalon wrote:
> > Maybe I should add some words in doc\guides\nics\i40e.rst to Record which
> > configurations are saved and restored by the PMD driver in reset
> > function. Which not list in that are recognized as not saved and restored
> > b
On Thu, Apr 20, 2017 at 09:17:24AM +, Zhao1, Wei wrote:
> > > > Please explain exactly the responsibility of this function, and how
> > > > it is different from calling stop/configure/start.
> > >
> > > In this reset feature, reset function can do the calling
> > > stop/configure/start process,
On Thu, Apr 06, 2017 at 02:57:29AM +, Zhao1, Wei wrote:
> > > + * Reset an ethernet device when it's not working. One scenario is,
> > > + after PF
> > > + * port is down and up, the related VF port should be reset.
> > > + * The API will stop the port, clear the rx/tx queues, re-setup the
> >
| 4 ++--
> drivers/net/mlx5/mlx5_mac.c| 16 ++--
> drivers/net/qede/qede_ethdev.c | 6 --
> drivers/net/ring/rte_eth_ring.c| 3 ++-
> drivers/net/virtio/virtio_ethdev.c | 13 +++--
For virtio changes,
Acked-by: Yuanhan Liu
--yliu
On Wed, Apr 19, 2017 at 01:26:01PM +0800, Yuanhan Liu wrote:
> For zero copy mode, we need pin the mbuf to not let the underlaying PMD
> driver (or the app) free the mbuf. Currently, only the heading mbuf is
> pinned. However, the mbuf free function would try to free all mbufs
> in th
On Wed, Apr 19, 2017 at 06:21:59AM +, Tan, Jianfeng wrote:
>
>
> > I've expected it to be plain english, something like following:
> >
> > /*
> > * Return the physical address (or virtual address in case of
> > * virtio-user) of mbuf data buffer.
> > *
> > * The addre
On Fri, Apr 14, 2017 at 03:53:18PM +0800, Yuanhan Liu wrote:
> Like what we did for virtio PMD driver [0][1], we could also apply such
> trick to vhost, to avoid the memory write on net header when necessary.
>
> [0]: c9ea670c1dc7 ("net/virtio: fix performance regression
On Wed, Apr 19, 2017 at 02:30:33AM +, Jianfeng Tan wrote:
> virtio-user cannot work on 32-bit system as higher 32-bit of the
> addr field (64-bit) in the desc is filled with non-zero value
> which should not happen for a 32-bit system.
>
> In case of virtio-user, we use buf_addr of mbuf to fil
may be returned to the mempool twice, while in
turn, being allocated twice later. Something uncertain may happen then.
For example, the VM2VM case becomes broken.
Fixes: b0a985d1f340 ("vhost: add dequeue zero copy")
Cc: sta...@dpdk.org
Signed-off-by: Yuanhan Liu
---
lib/librte_vhost/vi
On Wed, Apr 19, 2017 at 02:31:58AM +, Yang, Zhiyong wrote:
> Haha, you are right.
> I will rework it and send V2.
Note that the "started" field is added in one of my recent patch, to
addres the link status always being UP.
So you should pull the latest virtio code and make a patch there: you
On Fri, Apr 14, 2017 at 06:10:30AM +, Jianfeng Tan wrote:
> Previously, we miss to set intr_handle->fd which will be used as
> target file for epoll to check LSC.
>
> As a result, stdin (0) is used and intr thread keeps busy whenever
> data comes from stdin.
>
> To fix this, we use vhostfd as
On Fri, Apr 14, 2017 at 02:36:45PM +0800, Yuanhan Liu wrote:
> The virtio port link status will always be UP, even the port is stopped:
>
> testpmd> port stop 0
> Stopping ports...
> Checking link statuses...
> Port 0 Link Up - speed 1 Mbps - full-duple
On Mon, Apr 17, 2017 at 08:50:52AM +, Yang, Zhiyong wrote:
> Hi, yuanhan:
> Sorry for the delay reply due to my annual leave.
>
> > -Original Message-
> > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com]
> > Sent: Thursday, April 6, 2017 12:
On Tue, Apr 18, 2017 at 10:20:41AM +0200, Maxime Coquelin wrote:
>
>
> On 04/17/2017 09:27 AM, Yuanhan Liu wrote:
> >A "return" is missing on error, which could lead to a "use after free"
> >issue (about var "conn").
> >
> >Fixes
On Fri, Apr 14, 2017 at 04:55:53PM +0100, Bruce Richardson wrote:
> Hi all,
>
> just a heads-up that there are compilation errors showing up with
> compiling DPDK with clang 4.0 release. Here are some of the errors I am
> seeing. Volunteers to do patches for some of them welcome.
>
> Regards,
> /
A "return" is missing on error, which could lead to a "use after free"
issue (about var "conn").
Fixes: 65388b43f592 ("vhost: fix fd leaks for vhost-user server mode")
Coverity issue: 143476
Reported-by: John McNamara
Signed-off-by: Yuanhan Liu
---
201 - 300 of 1959 matches
Mail list logo
