/InternalLocator.java
Lines 97-98 (original), 96-97 (patched)
<https://reviews.apache.org/r/5/#comment246860>
In the javadoc, missing a closing '}' and a ';' between the first two
statments
- Ken Howe
On May 2, 2017, 1
views.apache.org/r/5/#comment246856>
typo - correspnds to my note on line 111
- Ken Howe
On May 2, 2017, 12:06 a.m., Kirk Lund wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
empty inner class we won't get a stack trace at all. So just throw the
new exception and let the default constructor fill in the stack trace and
casue. If the intent was to not have the cause filled in then couldn't we just
throw a new zero-arg CacheException?
- Ken Howe
On May 2,
ode/cache/query/internal/index/AbstractIndex.java
Line 1223 (original), 1256 (patched)
<https://reviews.apache.org/r/5/#comment246788>
typo: remove '//' that are left over from the original comment
- Ken Howe
lt;https://reviews.apache.org/r/5/#comment246693>
more comment formatting
- Ken Howe
On May 2, 2017, 12:06 a.m., Kirk Lund wrote:
>
> ---
> This is an au
lt;https://reviews.apache.org/r/5/#comment246693>
more comment formatting
- Ken Howe
On May 2, 2017, 12:06 a.m., Kirk Lund wrote:
>
> ---
> This is an au
lt;https://reviews.apache.org/r/5/#comment246693>
more comment formatting
- Ken Howe
On May 2, 2017, 12:06 a.m., Kirk Lund wrote:
>
> ---
> This is an au
va/org/apache/geode/cache/query/internal/QueryUtils.java
Line 1503 (original), 1409 (patched)
<https://reviews.apache.org/r/5/#comment246589>
For consistency, suggest renaming this method to
getConditionedRelationshipIndexResultsExpandedToTopOrCGJLevel
(similar to the renamed getCo
> On May 1, 2017, 10:28 p.m., Ken Howe wrote:
> > geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java
> > Line 237 (original), 232 (patched)
> > <https://reviews.apache.org/r/5/diff/1/?file=1704078#file1704078line237>
> >
> &
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58682/#review173528
---
Ship it!
Ship It!
- Ken Howe
On April 27, 2017, 6:30 p.m
s.apache.org/r/5/#comment246508>
delete line
geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java
Lines 76 (patched)
<https://reviews.apache.org/r/5/#comment246509>
delete line
- Ken Howe
On May 1, 201
c. names don't add clarity to the code. Exceptions would be where the
name might conflict with a keyword, which is not the case here.
- Ken Howe
On April 28, 2017, 6:02 p.m., Jinmei Liao wrote:
>
> ---
> This is an automat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58848/#review173384
---
Ship it!
Ship It!
- Ken Howe
On April 28, 2017, 7:40 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58742/#review173224
---
Ship it!
Ship It!
- Ken Howe
On April 26, 2017, 5:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58751/#review173213
---
Ship it!
Ship It!
- Ken Howe
On April 26, 2017, 8:54 p.m
ODE-2798 (which is a dupilcate of
GEODE-2681.)
Precheckin has been started.
Thanks,
Ken Howe
6c70d3ba478307af234a
Diff: https://reviews.apache.org/r/58595/diff/1/
Testing
---
Verified manually using the steps noted in GEODE-2798 (which is a dupilcate of
GEODE-2681.)
Precheckin has been started.
Thanks,
Ken Howe
/LocatorServerStartupRule.java
Line 67 (original), 63 (patched)
<https://reviews.apache.org/r/58518/#comment245592>
Javadoc comment is no longer needed
- Ken Howe
On April 19, 2017, 11:22 p.m., Jared Stewart wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58518/#review172364
---
Ship it!
Ship It!
- Ken Howe
On April 18, 2017, 9:58 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58460/#review172121
---
Ship it!
Ship It!
- Ken Howe
On April 17, 2017, 7:09 p.m
st/java/org/apache/geode/internal/cache/control/MemoryMonitorJUnitTest.java
Lines 297-301 (original), 297-301 (patched)
<https://reviews.apache.org/r/58460/#comment245101>
Spotless seems to have made a mess of this and the following comment.
- Ken Howe
On April 14, 2017, 9:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58435/#review171956
---
Ship it!
Ship It!
- Ken Howe
On April 13, 2017, 10:15 p.m
;
Rename withAutoStart() ?
- Ken Howe
On April 12, 2017, 11:32 p.m., Jinmei Liao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> On April 12, 2017, 9:10 p.m., Ken Howe wrote:
> > geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
> > Lines 110 (patched)
> > <https://reviews.apache.org/r/58388/diff/2/?file=1690839#file1690839line110>
> >
> > I find
boolean
to start (or not) later in the before() method. My interpretation is that it's
an "auto start" flag for each test.
- Ken Howe
On April 12, 2017, 3:08 p.m., Jinmei Liao wrote:
>
> ---
> This is an auto
to have been somewhat haphazard up to now.
This commnent applies to all our rules, not just this one.
- Ken Howe
On April 12, 2017, 3:08 p.m., Jinmei Liao wrote:
>
> ---
> This is an automatically generated e-mail. To rep
ing
Thanks,
Ken Howe
/diff/2-3/
Testing (updated)
---
==> Precheckin was clean other than spotlessCheck. Re-runing the precheckin
after reformatting to correct the failure
All Pulse UI tests run locally pass.
Precheckin is running
Thanks,
Ken Howe
run locally pass.
Precheckin is running
Thanks,
Ken Howe
://reviews.apache.org/r/58325/diff/1/
Testing
---
All Pulse UI tests run locally pass.
Precheckin is running
Thanks,
Ken Howe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58319/#review171491
---
Ship it!
Ship It!
- Ken Howe
On April 10, 2017, 9:06 p.m
at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:216)
at
org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest.withFunctionError_shouldThrow(SizeExportLogsFunctionCacheTest.java:146)
Re-running precheckin after merging current develop to my branch.
Thanks,
Ken Howe
at
org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest.withFunctionError_shouldThrow(SizeExportLogsFunctionCacheTest.java:146)
Re-running precheckin after merging current develop to my branch.
Thanks,
Ken Howe
216)
at
org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest.withFunctionError_shouldThrow(SizeExportLogsFunctionCacheTest.java:146)
Thanks,
Ken Howe
---
>
> (Updated March 30, 2017, 6:17 p.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe,
> Kirk Lund, and Swapnil Bawaskar.
>
>
> Repository: geode
>
>
> Description
> ---
>
at
org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest.withFunctionError_shouldThrow(SizeExportLogsFunctionCacheTest.java:146)
Thanks,
Ken Howe
ated e-mail. To reply, visit:
> https://reviews.apache.org/r/58050/
> ---
>
> (Updated March 30, 2017, 6:17 p.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe,
> Kirk Lund, and Swapnil Bawaskar.
>
>
> Repository: geode
>
&g
---
Precheckin is running
Thanks,
Ken Howe
(after the change noted above.)
- Ken Howe
On March 28, 2017, 10:34 p.m., Patrick Rhomberg wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57729/#review169795
---
- Ken Howe
On March 17, 2017, 6:48 p.m., Jinmei Liao wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57729/#review169799
---
- Ken Howe
On March 17, 2017, 6:48 p.m., Jinmei Liao wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57729/#review169524
---
Ship it!
Ship It!
- Ken Howe
On March 17, 2017, 6:48 p.m
ing is:
LogWriter.FINE and FINER --> Level.DEBUG
LogWriter.FINEST --> Level.TRACE
The new mapping has
LogWriter.FINE --> Level.DEBUG
LogWriter.FIBNER abnd FINEST --> Level.TRACE
- Ken Howe
On March 17, 2017, 6:48 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57573/#review169054
---
Ship it!
Ship It!
- Ken Howe
On March 15, 2017, 8:02 p.m
/internal/cli/commands/golden-help-offline.properties
Line 1477 (original), 1477 (patched)
<https://reviews.apache.org/r/57611/#comment241257>
This of course has to match the string as specified in CliStrings: "If not
specified" vs. "Otherwise"
- Ken Howe
On March 14, 20
move the deleted files dir
from the dir.listFiles() rather than arbitarily returning length - 1. Something
like
List listOfFiles = Arrays.asList(dir.listFiles());
listOfFiles.remove(dirOfDeletedFiles.getName());
return listOfFiles.size();
- Ken Howe
On March 13, 2017,
*-01' should have the "first" message,
but the active log file and the 2nd rolled log, '*-02' would have the same
"message" and you can't truly verify that the contents ended up in the correct
files.
Ran spotlessApply
Re-started precheckin
Thanks,
Ken Howe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57431/#review168833
---
Ship it!
Ship It!
- Ken Howe
On March 13, 2017, 6:05 p.m
en started
Thanks,
Ken Howe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57390/#review168474
---
Ship it!
Ship It!
- Ken Howe
On March 7, 2017, 7:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57439/#review168468
---
Ship it!
Ship It!
- Ken Howe
On March 9, 2017, 12:44 a.m
ent240005>
Is the upper_bound a useable port? If so then the outer loop test should be
'<='. Also in the test condition, the upper_bound should be reduced by the
count to enusre that i + j doesn't exceed the upper_bound.
- Ken Howe
On March 4, 20
latest (version 3) without
examining the intermediate changes.
As these changes appear that they won't break nightly builds (your precheckin
passed), it would be great to get this merged so that further refinements to
the export logs command behavior can be dealt with individually.
- Ken
87fc2
Diff: https://reviews.apache.org/r/57249/diff/2/
Changes: https://reviews.apache.org/r/57249/diff/1-2/
Testing
---
Tested locally on JVMs with small heap to verify there are no OOMEs
Precheckin has been started.
Thanks,
Ken Howe
arted.
Thanks,
Ken Howe
> On March 2, 2017, 6:31 p.m., Ken Howe wrote:
> > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
> > Line 140 (original), 114 (patched)
> > <https://reviews.apache.org/r/57242/diff/1/?file=1653588#file1653588line144>
> >
atched)
<https://reviews.apache.org/r/57242/#comment239611>
Why use locatorPort from 0 to -1? The test in startServer(Properties
properties, int locatorPort, boolean pdxPersistent) is for >0
- Ken Howe
On March 2, 2017, 3:30 p.m., Ji
https://reviews.apache.org/r/57221/diff/1-2/
Testing
---
Ran spotlessApply
Precheckin is in progress
Thanks,
Ken Howe
iff/1/
Testing
---
Ran spotlessApply
Precheckin is in progress
Thanks,
Ken Howe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167511
---
Ship it!
Ship It!
- Ken Howe
On March 1, 2017, 1:39 a.m
I’m working on the NetstatDUnitTest failure. GEODE-2541
Ken
> On Feb 28, 2017, at 8:35 AM, Apache Jenkins Server
> wrote:
>
> 2: Task failed with an exception.
> ---
> * What went wrong:
> Execution failed for task ':geode-core:flakyTest'.
>> There were failing tests. See the report at
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57050/#review166763
---
Ship it!
Ship It!
- Ken Howe
On Feb. 24, 2017, 9:37 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56801/#review166005
---
Ship it!
Ship It!
- Ken Howe
On Feb. 17, 2017, 11:56 p.m
of the code.
- Ken Howe
On Feb. 17, 2017, 10:21 p.m., Kevin Duling wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56637/#review165559
---
Ship it!
Ship It!
- Ken Howe
On Feb. 14, 2017, 7 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56668/#review165545
---
Ship it!
Ship It!
- Ken Howe
On Feb. 14, 2017, 5:01 p.m
/ServerStarterRule.java
(lines 89 - 94)
<https://reviews.apache.org/r/56637/#comment237407>
Looks like a null properties argument will cause an NPE
- Ken Howe
On Feb. 14, 2017, 4:19 p.m., Jinmei Liao wrote:
>
> ---
tion = 20
- Ken
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56506/#review164991
---
On Feb. 11, 2017, midnight, Ken Howe wrote:
>
> --
ically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56506/#review165186
-------
On Feb. 11, 2017, midnight, Ken Howe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
ernal/cache/Oplog.java 0b98364
geode-core/src/test/java/org/apache/geode/internal/cache/OplogFlushTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/56506/diff/
Testing
---
Started precheckin
Thanks,
Ken Howe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56522/#review165136
---
Ship it!
Ship It!
- Ken Howe
On Feb. 10, 2017, 12:57 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56516/#review165128
---
Ship it!
Ship It!
- Ken Howe
On Feb. 9, 2017, 8:06 p.m
geode/internal/cache/OplogFlushTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/56506/diff/
Testing
---
Started precheckin
Thanks,
Ken Howe
eckin copmleted successfully
Thanks,
Ken Howe
a
Diff: https://reviews.apache.org/r/53857/diff/
Testing
---
Ran spotlessCheck (and spotlessApply to fix some formatting)
Precheckin is in progress
Thanks,
Ken Howe
101 - 176 of 176 matches
Mail list logo
