j3graham commented on code in PR #370:
URL:
https://github.com/apache/httpcomponents-client/pull/370#discussion_r880748866
##
httpclient5/src/main/java/org/apache/hc/client5/http/utils/Base64.java:
##
@@ -0,0 +1,223 @@
+/*
+ * ===
j3graham commented on code in PR #370:
URL:
https://github.com/apache/httpcomponents-client/pull/370#discussion_r880745172
##
httpclient5/pom.xml:
##
@@ -80,6 +80,7 @@
commons-codec
commons-codec
+ test
Review Comment:
Should be able to. Right now m
I am.
Gary
On Tue, May 24, 2022, 03:18 Oleg Kalnichevski wrote:
> Folks
>
> I would like to cut new releases of HttpCore 5.1, HttpCore 5.2 and
> HttpClient 5.2. Will there be two more PMCs around to help me with the
> release?
>
> Oleg
>
>
> -
ok2c commented on code in PR #370:
URL:
https://github.com/apache/httpcomponents-client/pull/370#discussion_r880556089
##
httpclient5/src/main/java/org/apache/hc/client5/http/utils/Base64.java:
##
@@ -0,0 +1,223 @@
+/*
+ * ===
michael-o commented on code in PR #370:
URL:
https://github.com/apache/httpcomponents-client/pull/370#discussion_r880555943
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/HttpRFC7578Multipart.java:
##
@@ -129,7 +128,7 @@ public byte[] encode(final byte[] by
ok2c commented on code in PR #370:
URL:
https://github.com/apache/httpcomponents-client/pull/370#discussion_r880554970
##
httpclient5/pom.xml:
##
@@ -80,6 +80,7 @@
commons-codec
commons-codec
+ test
Review Comment:
@j3graham Can't we drop `commons-c
ok2c commented on code in PR #370:
URL:
https://github.com/apache/httpcomponents-client/pull/370#discussion_r880549473
##
httpclient5/src/main/java/org/apache/hc/client5/http/utils/Base64.java:
##
@@ -0,0 +1,223 @@
+/*
+ * ===
michael-o commented on code in PR #370:
URL:
https://github.com/apache/httpcomponents-client/pull/370#discussion_r880450009
##
httpclient5/src/main/java/org/apache/hc/client5/http/utils/Base64.java:
##
@@ -0,0 +1,223 @@
+/*
+ * ==
j3graham commented on code in PR #370:
URL:
https://github.com/apache/httpcomponents-client/pull/370#discussion_r880445736
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/HttpRFC7578Multipart.java:
##
@@ -129,7 +128,7 @@ public byte[] encode(final byte[] byt
j3graham commented on code in PR #370:
URL:
https://github.com/apache/httpcomponents-client/pull/370#discussion_r880445353
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/HttpRFC7578Multipart.java:
##
@@ -163,13 +162,13 @@ public byte[] decode(final byte[] b
j3graham commented on code in PR #370:
URL:
https://github.com/apache/httpcomponents-client/pull/370#discussion_r880444994
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/HttpRFC7578Multipart.java:
##
@@ -138,7 +137,7 @@ public byte[] decode(final byte[] byt
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541441#comment-17541441
]
Johannes Graham commented on HTTPCLIENT-2218:
-
For curiosity's sake:
michael-o commented on code in PR #370:
URL:
https://github.com/apache/httpcomponents-client/pull/370#discussion_r880387556
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/HttpRFC7578Multipart.java:
##
@@ -129,7 +128,7 @@ public byte[] encode(final byte[] by
j3graham commented on PR #369:
URL:
https://github.com/apache/httpcomponents-client/pull/369#issuecomment-113570
New one also drops the commons-codec dependency for production (my own test
code obsessively compares the behaviour of the two)
--
This is an automated message from the Ap
j3graham commented on PR #369:
URL:
https://github.com/apache/httpcomponents-client/pull/369#issuecomment-1135784273
I opened a new one - https://github.com/apache/httpcomponents-client/pull/370
Closed this due to accidentally pulling in changes like the codeql one.
--
This is
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541373#comment-17541373
]
Michael Osipov commented on HTTPCLIENT-2218:
Then let's do this.
> Use
Folks
I would like to cut new releases of HttpCore 5.1, HttpCore 5.2 and
HttpClient 5.2. Will there be two more PMCs around to help me with the
release?
Oleg
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additiona
ok2c commented on PR #369:
URL:
https://github.com/apache/httpcomponents-client/pull/369#issuecomment-1135499398
@j3graham The PR actually looks pretty good. Why is it closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541304#comment-17541304
]
Oleg Kalnichevski commented on HTTPCLIENT-2218:
---
[~michael-o] We are n
19 matches
Mail list logo