j3graham commented on code in PR #370:
URL:
https://github.com/apache/httpcomponents-client/pull/370#discussion_r880745172
##########
httpclient5/pom.xml:
##########
@@ -80,6 +80,7 @@
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
+ <scope>test</scope>
Review Comment:
Should be able to. Right now my test iterates over lots of inputs and
compares what each codec returns. This is likely overkill - I will update the
tests to use constant expected values for a reasonable number of points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
