Re: [PR] OAK-10734 : keep _revisions entry for non bcs younger than sweep - ad… [jackrabbit-oak]

2024-04-02 Thread via GitHub
rishabhdaim commented on code in PR #1393: URL: https://github.com/apache/jackrabbit-oak/pull/1393#discussion_r1548075492 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java: ## @@ -1263,6 +1265,77 @@ private Iterator can

Re: [PR] OAK-10682 - [Indexing job] Improve Mongo regex filter to only use positive conditions (no negations) [jackrabbit-oak]

2024-04-02 Thread via GitHub
nfsantos merged PR #1394: URL: https://github.com/apache/jackrabbit-oak/pull/1394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackra

Re: [PR] OAK-10682 - [Indexing job] Improve Mongo regex filter to only use positive conditions (no negations) [jackrabbit-oak]

2024-04-02 Thread via GitHub
nfsantos commented on PR #1394: URL: https://github.com/apache/jackrabbit-oak/pull/1394#issuecomment-2032226929 This is identical to https://github.com/apache/jackrabbit-oak/pull/1364, which was already reviewed and approved. The original PR has some issue with an invalid commit, so I extra

Re: [PR] OAK-10682 - [Indexing job] Improve Mongo regex filter to only use positive conditions (no negations) [jackrabbit-oak]

2024-04-02 Thread via GitHub
nfsantos closed pull request #1364: OAK-10682 - [Indexing job] Improve Mongo regex filter to only use positive conditions (no negations) URL: https://github.com/apache/jackrabbit-oak/pull/1364 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] OAK-10535 : unignored lateWriteRemoveChildGC_noSweep [jackrabbit-oak]

2024-04-02 Thread via GitHub
stefan-egli merged PR #1396: URL: https://github.com/apache/jackrabbit-oak/pull/1396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

Re: [PR] OAK-10734 : keep _revisions entry for non bcs younger than sweep - ad… [jackrabbit-oak]

2024-04-02 Thread via GitHub
stefan-egli commented on PR #1393: URL: https://github.com/apache/jackrabbit-oak/pull/1393#issuecomment-2032173805 Note incoming https://github.com/apache/jackrabbit-oak/pull/1396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] OAK-10535 : unignored lateWriteRemoveChildGC_noSweep [jackrabbit-oak]

2024-04-02 Thread via GitHub
stefan-egli opened a new pull request, #1396: URL: https://github.com/apache/jackrabbit-oak/pull/1396 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] OAK-10734 : merge DetailedGC/OAK-10199 to OAK-10734 [jackrabbit-oak]

2024-04-02 Thread via GitHub
stefan-egli merged PR #1395: URL: https://github.com/apache/jackrabbit-oak/pull/1395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

[PR] OAK-10682 - [Indexing job] Improve Mongo regex filter to only use positive conditions (no negations) [jackrabbit-oak]

2024-04-02 Thread via GitHub
nfsantos opened a new pull request, #1394: URL: https://github.com/apache/jackrabbit-oak/pull/1394 The current implementation of filtering excluded paths and custom regex is using a condition like ` _id: { $nin: [ /^[0-9]{1,3}:\/content\/dam\/.*$/ ]` Mongo cannot evaluate this

Re: [PR] Test CI [jackrabbit-oak]

2024-04-02 Thread via GitHub
nfsantos closed pull request #1391: Test CI URL: https://github.com/apache/jackrabbit-oak/pull/1391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

Re: [PR] OAK-10734 : keep _revisions entry for non bcs younger than sweep - ad… [jackrabbit-oak]

2024-04-02 Thread via GitHub
stefan-egli commented on PR #1393: URL: https://github.com/apache/jackrabbit-oak/pull/1393#issuecomment-2031620876 another test class required gccount fixing, done now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] OAK-10734 : keep _revisions entry for non bcs younger than sweep - added test case to showcase as parentWithGarbageGCChildIndependent [jackrabbit-oak]

2024-04-02 Thread via GitHub
stefan-egli closed pull request #1392: OAK-10734 : keep _revisions entry for non bcs younger than sweep - added test case to showcase as parentWithGarbageGCChildIndependent URL: https://github.com/apache/jackrabbit-oak/pull/1392 -- This is an automated message from the Apache Git Service. To

Re: [PR] OAK-10734 : keep _revisions entry for non bcs younger than sweep - added test case to showcase as parentWithGarbageGCChildIndependent [jackrabbit-oak]

2024-04-02 Thread via GitHub
stefan-egli commented on PR #1392: URL: https://github.com/apache/jackrabbit-oak/pull/1392#issuecomment-2031604570 wrong branch - closing PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] OAK-10734 : keep _revisions entry for non bcs younger than sweep - added test case to showcase as parentWithGarbageGCChildIndependent [jackrabbit-oak]

2024-04-02 Thread via GitHub
stefan-egli opened a new pull request, #1392: URL: https://github.com/apache/jackrabbit-oak/pull/1392 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Test CI [jackrabbit-oak]

2024-04-02 Thread via GitHub
reschke commented on PR #1391: URL: https://github.com/apache/jackrabbit-oak/pull/1391#issuecomment-2031593581 Please don't do that. You can trigger a build from https://ci-builds.apache.org/. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[PR] Test CI [jackrabbit-oak]

2024-04-02 Thread via GitHub
nfsantos opened a new pull request, #1391: URL: https://github.com/apache/jackrabbit-oak/pull/1391 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] OAK-10708: error-level log failures to write the journal [jackrabbit-oak]

2024-04-02 Thread via GitHub
stefan-egli commented on code in PR #1363: URL: https://github.com/apache/jackrabbit-oak/pull/1363#discussion_r1547445759 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java: ## @@ -352,7 +352,10 @@ private void applyToDocumentStore(Revisio

Re: [PR] OAK-9710: Document addition of feature to support custom TTL for direct download [jackrabbit-oak]

2024-03-31 Thread via GitHub
github-actions[bot] closed pull request #509: OAK-9710: Document addition of feature to support custom TTL for direct download URL: https://github.com/apache/jackrabbit-oak/pull/509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] OAK-10708: error-level log failures to write the journal [jackrabbit-oak]

2024-03-29 Thread via GitHub
reschke commented on code in PR #1363: URL: https://github.com/apache/jackrabbit-oak/pull/1363#discussion_r1544701153 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java: ## @@ -352,7 +352,10 @@ private void applyToDocumentStore(RevisionVec

Re: [PR] [draft] extra facet field logging [jackrabbit-oak]

2024-03-28 Thread via GitHub
github-actions[bot] commented on PR #531: URL: https://github.com/apache/jackrabbit-oak/pull/531#issuecomment-2026454049 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message f

[PR] OAK-10731: oak-pojosr: remove unused gmongo dependency [jackrabbit-oak]

2024-03-28 Thread via GitHub
reschke opened a new pull request, #1390: URL: https://github.com/apache/jackrabbit-oak/pull/1390 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10731: oak-pojosr: remove unused gmongo dependency [jackrabbit-oak]

2024-03-28 Thread via GitHub
reschke merged PR #1390: URL: https://github.com/apache/jackrabbit-oak/pull/1390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

Re: [PR] OAK-10708: error-level log failures to write the journal [jackrabbit-oak]

2024-03-28 Thread via GitHub
stefan-egli commented on PR #1363: URL: https://github.com/apache/jackrabbit-oak/pull/1363#issuecomment-2024981747 @reschke , now created OAK-10730 for logging the MongoException - it's not entirely clear at what level we should log though - I would suggest to not go log.error right away (a

Re: [PR] OAK-10729: update groovy dependency to 3.0.21 [jackrabbit-oak]

2024-03-28 Thread via GitHub
reschke merged PR #1388: URL: https://github.com/apache/jackrabbit-oak/pull/1388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

Re: [PR] OAK-10727 : log revisionDetailedGcType in VersionGarbageCollector con… [jackrabbit-oak]

2024-03-28 Thread via GitHub
stefan-egli commented on PR #1387: URL: https://github.com/apache/jackrabbit-oak/pull/1387#issuecomment-2024684882 +1 to adding it also to VersionGCStats - we can still see which one turns out more/how useful and adjust along the way in case -- This is an automated message from the Apache

Re: [PR] OAK-10727 : log revisionDetailedGcType in VersionGarbageCollector con… [jackrabbit-oak]

2024-03-28 Thread via GitHub
stefan-egli merged PR #1387: URL: https://github.com/apache/jackrabbit-oak/pull/1387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

Re: [PR] OAK-10728 : embedded verification fails if id is from long path [jackrabbit-oak]

2024-03-28 Thread via GitHub
stefan-egli merged PR #1389: URL: https://github.com/apache/jackrabbit-oak/pull/1389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

Re: [PR] OAK-10727 : log revisionDetailedGcType in VersionGarbageCollector con… [jackrabbit-oak]

2024-03-27 Thread via GitHub
rishabhdaim commented on PR #1387: URL: https://github.com/apache/jackrabbit-oak/pull/1387#issuecomment-2024365217 I am wondering if I shouldn't add this to `VersionGCStats` so that it gets logged along with other stats. -- This is an automated message from the Apache Git Service. To resp

[PR] OAK-10729: update groovy dependency to 3.0.21 [jackrabbit-oak]

2024-03-27 Thread via GitHub
reschke opened a new pull request, #1388: URL: https://github.com/apache/jackrabbit-oak/pull/1388 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10726 : fix and gctype-parameterize BranchCommitGCTest [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli merged PR #1386: URL: https://github.com/apache/jackrabbit-oak/pull/1386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

Re: [PR] OAK-10726 : fix and gctype-parameterize BranchCommitGCTest [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli commented on PR #1386: URL: https://github.com/apache/jackrabbit-oak/pull/1386#issuecomment-2023191505 Going ahead and merge - it's mostly tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] OAK-10726 : fix and gctype-parameterize BranchCommitGCTest [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli commented on PR #1386: URL: https://github.com/apache/jackrabbit-oak/pull/1386#issuecomment-2022977366 piggybacked https://github.com/apache/jackrabbit-oak/pull/1386/commits/635e0819bd77c233f80016428b357be74cf4d3f8 also onto this PR - does the gcType parameterization also for V

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli commented on code in PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1541089542 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1007,6 +1008,10 @@ public void collectGar

Re: [PR] OAK-10727 : log revisionDetailedGcType in VersionGarbageCollector con… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli commented on PR #1387: URL: https://github.com/apache/jackrabbit-oak/pull/1387#issuecomment-2022726498 @rishabhdaim wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] OAK-10727 : log revisionDetailedGcType in VersionGarbageCollector con… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli opened a new pull request, #1387: URL: https://github.com/apache/jackrabbit-oak/pull/1387 …structor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli commented on PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#issuecomment-2022690091 > BranchCommitGCTest now fail due to using the new mode by default - requires fixing first before merging this will be handled in OAK-10726 now (to not block this PR)

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli merged PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli commented on code in PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1541044437 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1007,6 +1008,10 @@ public void collectGar

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli commented on code in PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1541043816 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1007,6 +1008,10 @@ public void collectGar

Re: [PR] OAK-10715 : embedded verification fixes : it was using the wrong equa… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli merged PR #1377: URL: https://github.com/apache/jackrabbit-oak/pull/1377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
rishabhdaim commented on PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#issuecomment-2022597351 PR approved with a minor review comment that can be handled later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
rishabhdaim commented on code in PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1540970470 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1007,6 +1008,10 @@ public void collectGar

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
rishabhdaim commented on code in PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1540970470 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1007,6 +1008,10 @@ public void collectGar

[PR] Issues/OAK-10675 [jackrabbit-oak]

2024-03-27 Thread via GitHub
t-rana opened a new pull request, #1385: URL: https://github.com/apache/jackrabbit-oak/pull/1385 Added service principal support in oak-blob-cloud-azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] OAK-10715 : embedded verification fixes : it was using the wrong equa… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli commented on code in PR #1377: URL: https://github.com/apache/jackrabbit-oak/pull/1377#discussion_r1540935354 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1639,16 +1640,37 @@ public void removeGar

Re: [PR] OAK-10715 : embedded verification fixes : it was using the wrong equa… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli commented on code in PR #1377: URL: https://github.com/apache/jackrabbit-oak/pull/1377#discussion_r1540935123 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1639,16 +1640,37 @@ public void removeGar

Re: [PR] OAK-10715 : embedded verification fixes : it was using the wrong equa… [jackrabbit-oak]

2024-03-27 Thread via GitHub
Joscorbe commented on code in PR #1377: URL: https://github.com/apache/jackrabbit-oak/pull/1377#discussion_r1540903551 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1714,7 +1736,48 @@ public void removeGarbage

Re: [PR] OAK-10725: Upgrade jackson-databind dependency to 2.16.2 [jackrabbit-oak]

2024-03-26 Thread via GitHub
reschke merged PR #1384: URL: https://github.com/apache/jackrabbit-oak/pull/1384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10725: Upgrade jackson-databind dependency to 2.16.2 [jackrabbit-oak]

2024-03-26 Thread via GitHub
reschke opened a new pull request, #1384: URL: https://github.com/apache/jackrabbit-oak/pull/1384 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-26 Thread via GitHub
stefan-egli commented on PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#issuecomment-2021043000 BranchCommitGCTest now fail due to using the new mode by default - requires fixing first before merging this -- This is an automated message from the Apache Git Service. To r

[PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-26 Thread via GitHub
stefan-egli opened a new pull request, #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383 … and deleted properties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] OAK-10723: Update commons-lang3 dependency to 3.14.0 [jackrabbit-oak]

2024-03-26 Thread via GitHub
reschke merged PR #1382: URL: https://github.com/apache/jackrabbit-oak/pull/1382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10723: Update commons-lang3 dependency to 3.14.0 [jackrabbit-oak]

2024-03-26 Thread via GitHub
reschke opened a new pull request, #1382: URL: https://github.com/apache/jackrabbit-oak/pull/1382 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10721: oak-segment-azure/oak-blob-cloud-azure: update embedded Guava to 33.1.0 [jackrabbit-oak]

2024-03-26 Thread via GitHub
reschke merged PR #1380: URL: https://github.com/apache/jackrabbit-oak/pull/1380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

Re: [PR] OAK-10722: Update commons-codec dependency to 1.16.1 [jackrabbit-oak]

2024-03-26 Thread via GitHub
reschke merged PR #1381: URL: https://github.com/apache/jackrabbit-oak/pull/1381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10722: Update commons-codec dependency to 1.16.1 [jackrabbit-oak]

2024-03-26 Thread via GitHub
reschke opened a new pull request, #1381: URL: https://github.com/apache/jackrabbit-oak/pull/1381 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] OAK-10721: oak-segment-azure/oak-blob-cloud-azure: update embedded Guava to 33.1.0 [jackrabbit-oak]

2024-03-26 Thread via GitHub
reschke opened a new pull request, #1380: URL: https://github.com/apache/jackrabbit-oak/pull/1380 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10720: Update commons-io dependency to 2.15.1 [jackrabbit-oak]

2024-03-26 Thread via GitHub
reschke merged PR #1379: URL: https://github.com/apache/jackrabbit-oak/pull/1379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10720: Update commons-io dependency to 2.15.1 [jackrabbit-oak]

2024-03-26 Thread via GitHub
reschke opened a new pull request, #1379: URL: https://github.com/apache/jackrabbit-oak/pull/1379 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10718: Update (shaded) Guava to 33.1.0 [jackrabbit-oak]

2024-03-25 Thread via GitHub
reschke merged PR #1378: URL: https://github.com/apache/jackrabbit-oak/pull/1378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10718: Update (shaded) Guava to 33.1.0 [jackrabbit-oak]

2024-03-25 Thread via GitHub
reschke opened a new pull request, #1378: URL: https://github.com/apache/jackrabbit-oak/pull/1378 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10715 : embedded verification should use traversed nodeState [jackrabbit-oak]

2024-03-25 Thread via GitHub
stefan-egli commented on PR #1375: URL: https://github.com/apache/jackrabbit-oak/pull/1375#issuecomment-2018545288 Replaced by https://github.com/apache/jackrabbit-oak/pull/1377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] OAK-10715 : embedded verification should use traversed nodeState [jackrabbit-oak]

2024-03-25 Thread via GitHub
stefan-egli closed pull request #1375: OAK-10715 : embedded verification should use traversed nodeState URL: https://github.com/apache/jackrabbit-oak/pull/1375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] OAK-10715 : embedded verification fixes : it was using the wrong equa… [jackrabbit-oak]

2024-03-25 Thread via GitHub
stefan-egli opened a new pull request, #1377: URL: https://github.com/apache/jackrabbit-oak/pull/1377 …ls method that always returned true in the given use case, plus added verifyDeletion -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] OAK-10688 : keep only traversed property revisions - take special car… [jackrabbit-oak]

2024-03-25 Thread via GitHub
stefan-egli commented on PR #1372: URL: https://github.com/apache/jackrabbit-oak/pull/1372#issuecomment-2018170092 thx for the reviews, comments addressed, merged now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] OAK-10688 : keep only traversed property revisions - take special car… [jackrabbit-oak]

2024-03-25 Thread via GitHub
stefan-egli merged PR #1372: URL: https://github.com/apache/jackrabbit-oak/pull/1372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

Re: [PR] OAK-10688 : keep only traversed property revisions - take special car… [jackrabbit-oak]

2024-03-25 Thread via GitHub
stefan-egli commented on code in PR #1372: URL: https://github.com/apache/jackrabbit-oak/pull/1372#discussion_r1537698677 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1246,6 +1349,256 @@ private void collect

Re: [PR] OAK-10688 : keep only traversed property revisions - take special car… [jackrabbit-oak]

2024-03-25 Thread via GitHub
stefan-egli commented on code in PR #1372: URL: https://github.com/apache/jackrabbit-oak/pull/1372#discussion_r1537690222 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1246,6 +1349,256 @@ private void collect

Re: [PR] OAK-10714 : enable embedded verification for tests by default [jackrabbit-oak]

2024-03-25 Thread via GitHub
stefan-egli merged PR #1374: URL: https://github.com/apache/jackrabbit-oak/pull/1374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

Re: [PR] OAK-10688 : keep only traversed property revisions - take special car… [jackrabbit-oak]

2024-03-25 Thread via GitHub
stefan-egli commented on code in PR #1372: URL: https://github.com/apache/jackrabbit-oak/pull/1372#discussion_r1537663777 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -139,6 +142,14 @@ public class VersionGarb

Re: [PR] OAK-10688 : keep only traversed property revisions - take special car… [jackrabbit-oak]

2024-03-25 Thread via GitHub
stefan-egli commented on code in PR #1372: URL: https://github.com/apache/jackrabbit-oak/pull/1372#discussion_r1537643653 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1246,6 +1349,256 @@ private void collect

Re: [PR] OAK-10688 : keep only traversed property revisions - take special car… [jackrabbit-oak]

2024-03-25 Thread via GitHub
stefan-egli commented on code in PR #1372: URL: https://github.com/apache/jackrabbit-oak/pull/1372#discussion_r1537642939 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1246,6 +1349,256 @@ private void collect

Re: [PR] OAK-10688 : keep only traversed property revisions - take special car… [jackrabbit-oak]

2024-03-25 Thread via GitHub
stefan-egli commented on code in PR #1372: URL: https://github.com/apache/jackrabbit-oak/pull/1372#discussion_r1537243198 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1246,6 +1349,256 @@ private void collect

Re: [PR] OAK-10713: add (failing) test for Lucene regexp stack overflow [jackrabbit-oak]

2024-03-22 Thread via GitHub
reschke merged PR #1373: URL: https://github.com/apache/jackrabbit-oak/pull/1373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

Re: [PR] OAK-9752 Update Tika version to 2.x [jackrabbit-oak]

2024-03-22 Thread via GitHub
enapps-enorman commented on PR #626: URL: https://github.com/apache/jackrabbit-oak/pull/626#issuecomment-2015467150 No response, so closing again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] OAK-9752 Update Tika version to 2.x [jackrabbit-oak]

2024-03-22 Thread via GitHub
enapps-enorman closed pull request #626: OAK-9752 Update Tika version to 2.x URL: https://github.com/apache/jackrabbit-oak/pull/626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] OAK-10716: oak-lucene: update to version 4.7.2 (latest from that branch) [jackrabbit-oak]

2024-03-22 Thread via GitHub
reschke merged PR #1376: URL: https://github.com/apache/jackrabbit-oak/pull/1376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

Re: [PR] OAK-10708: error-level log failures to write the journal [jackrabbit-oak]

2024-03-22 Thread via GitHub
reschke commented on PR #1363: URL: https://github.com/apache/jackrabbit-oak/pull/1363#issuecomment-2014939980 > Meanwhile, what's not quite clear is why we're [catching](https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/do

[PR] OAK-10716: https://issues.apache.org/jira/browse/OAK-10716 [jackrabbit-oak]

2024-03-22 Thread via GitHub
reschke opened a new pull request, #1376: URL: https://github.com/apache/jackrabbit-oak/pull/1376 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10688 : keep only traversed property revisions - take special car… [jackrabbit-oak]

2024-03-22 Thread via GitHub
rishabhdaim commented on code in PR #1372: URL: https://github.com/apache/jackrabbit-oak/pull/1372#discussion_r1535173583 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java: ## @@ -929,6 +929,53 @@ private boolean isValidRevision(@No

Re: [PR] OAK-10715 : embedded verification should use traversed nodeState [jackrabbit-oak]

2024-03-21 Thread via GitHub
stefan-egli commented on PR #1375: URL: https://github.com/apache/jackrabbit-oak/pull/1375#issuecomment-2012384974 @Joscorbe , @rishabhdaim , this is more FYI as we should first merge OAK-10688 (and then I'd redo this PR from DetailedGC directly) -- This is an automated message from the A

[PR] OAK-10715 : embedded verification should use traversed nodeState [jackrabbit-oak]

2024-03-21 Thread via GitHub
stefan-egli opened a new pull request, #1375: URL: https://github.com/apache/jackrabbit-oak/pull/1375 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] OAK-10714 : enable embedded verification for tests by default [jackrabbit-oak]

2024-03-21 Thread via GitHub
stefan-egli opened a new pull request, #1374: URL: https://github.com/apache/jackrabbit-oak/pull/1374 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] OAK-10713: add (failing) list for Lucene regexp stack overflow [jackrabbit-oak]

2024-03-21 Thread via GitHub
reschke opened a new pull request, #1373: URL: https://github.com/apache/jackrabbit-oak/pull/1373 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-6766: Convert oak-lucene to OSGi R7 annotations [jackrabbit-oak]

2024-03-21 Thread via GitHub
mbaedke commented on PR #1352: URL: https://github.com/apache/jackrabbit-oak/pull/1352#issuecomment-2011744368 Addressed @kwin 's suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] OAK-10688 : keep only traversed property revisions - take special car… [jackrabbit-oak]

2024-03-20 Thread via GitHub
stefan-egli opened a new pull request, #1372: URL: https://github.com/apache/jackrabbit-oak/pull/1372 …e with internal properties, esp _bc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] OAK-6756: Convert oak-auth-external to OSGi R7 annotations [jackrabbit-oak]

2024-03-20 Thread via GitHub
mbaedke opened a new pull request, #1371: URL: https://github.com/apache/jackrabbit-oak/pull/1371 done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] OAK-10712: update groovy dependency to 2.5.23 [jackrabbit-oak]

2024-03-19 Thread via GitHub
reschke merged PR #1370: URL: https://github.com/apache/jackrabbit-oak/pull/1370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10712: update groovy dependency to 2.5.23 [jackrabbit-oak]

2024-03-19 Thread via GitHub
reschke opened a new pull request, #1370: URL: https://github.com/apache/jackrabbit-oak/pull/1370 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10375: remove binary data from logs [jackrabbit-oak]

2024-03-19 Thread via GitHub
reschke commented on PR #1353: URL: https://github.com/apache/jackrabbit-oak/pull/1353#issuecomment-2006212870 That's a good point. Paths can contain senstive information as well, but I *believe* we use them alaready almost everywhere, because that information is really essential for debugg

Re: [PR] OAK-10375: remove binary data from logs [jackrabbit-oak]

2024-03-18 Thread via GitHub
steffenvan commented on PR #1353: URL: https://github.com/apache/jackrabbit-oak/pull/1353#issuecomment-2004305989 Hmm as long as it doesn't violate any privacy concerns, I guess so. @reschke -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] OAK-6766: Convert oak-lucene to OSGi R7 annotations [jackrabbit-oak]

2024-03-18 Thread via GitHub
mbaedke commented on code in PR #1352: URL: https://github.com/apache/jackrabbit-oak/pull/1352#discussion_r1528585246 ## oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java: ## @@ -368,13 +349,19 @@ public class LuceneIndexProv

Re: [PR] OAK-6766: Convert oak-lucene to OSGi R7 annotations [jackrabbit-oak]

2024-03-18 Thread via GitHub
mbaedke commented on code in PR #1352: URL: https://github.com/apache/jackrabbit-oak/pull/1352#discussion_r1528579036 ## oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java: ## @@ -104,201 +107,178 @@ import static org.apache

Re: [PR] WIP: Update DetailedGC branch [jackrabbit-oak]

2024-03-14 Thread via GitHub
rishabhdaim merged PR #1366: URL: https://github.com/apache/jackrabbit-oak/pull/1366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

Re: [PR] Trunk detailed gc merge [jackrabbit-oak]

2024-03-14 Thread via GitHub
rishabhdaim closed pull request #1369: Trunk detailed gc merge URL: https://github.com/apache/jackrabbit-oak/pull/1369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] Trunk detailed gc merge [jackrabbit-oak]

2024-03-14 Thread via GitHub
rishabhdaim opened a new pull request, #1369: URL: https://github.com/apache/jackrabbit-oak/pull/1369 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Trunk detailed merge [jackrabbit-oak]

2024-03-14 Thread via GitHub
rishabhdaim closed pull request #1368: Trunk detailed merge URL: https://github.com/apache/jackrabbit-oak/pull/1368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[PR] Trunk detailed merge [jackrabbit-oak]

2024-03-14 Thread via GitHub
rishabhdaim opened a new pull request, #1368: URL: https://github.com/apache/jackrabbit-oak/pull/1368 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] OAK-10710 : added option to reset detailedGC after finishing detailed… [jackrabbit-oak]

2024-03-14 Thread via GitHub
rishabhdaim merged PR #1367: URL: https://github.com/apache/jackrabbit-oak/pull/1367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

Re: [PR] OAK-10710 : added option to reset detailedGC after finishing detailed… [jackrabbit-oak]

2024-03-14 Thread via GitHub
rishabhdaim commented on PR #1367: URL: https://github.com/apache/jackrabbit-oak/pull/1367#issuecomment-1998046586 `the removal of the detailedGC / enable detailedGC (collect only) part` * This is done to avoid confusion since we have 2 ways to run detailedGC code i.e. from **_collect_**

<    3   4   5   6   7   8   9   10   11   12   >