Re: [VOTE]KIP-966: Eligible Leader Replicas

2023-10-11 Thread Calvin Liu
Hi, The KIP has received 3 binding votes from Justine Olshan, Jun Rao and Colin McCabe. Also thanks to Jeff Kim, Jack Vanlightly, Artem Livshits, David Arthur, David Jacot for the comments to make the KIP better. Thanks for the help! On Mon, Oct 9, 2023 at 10:20 AM Calvin Liu wrote: > Hi Colin,

Re: [VOTE]KIP-966: Eligible Leader Replicas

2023-10-09 Thread Calvin Liu
Hi Colin, Thanks for the feedback. I have updated the KIP but with the following changes. --The request is still grouped by topics. For each topic, the caller can specify either partition IDs or a range of partitions to query. If it is a range query, the request should specify the "first partition

Re: [VOTE]KIP-966: Eligible Leader Replicas

2023-10-06 Thread Colin McCabe
Hi Calvin, Thanks for the KIP. I think the config discussion was good and I have no more comments there. I have one last thing I think we should fix up: I think we should improve DescribeTopicRequest. The current mechanism of "you can only list 20 topics" doesn't do a very good job of limiting

Re: [VOTE]KIP-966: Eligible Leader Replicas

2023-10-04 Thread Jun Rao
Hi, Calvin, Thanks for the KIP. +1 from me too. Jun On Wed, Sep 20, 2023 at 5:28 PM Justine Olshan wrote: > Thanks Calvin. > I think this will be very helpful going forward to minimize data loss. > > +1 from me (binding) > > Justine > > On Wed, Sep 20, 2023 at 3:42 PM Calvin Liu > wrote: > >

Re: [VOTE]KIP-966: Eligible Leader Replicas

2023-09-20 Thread Justine Olshan
Thanks Calvin. I think this will be very helpful going forward to minimize data loss. +1 from me (binding) Justine On Wed, Sep 20, 2023 at 3:42 PM Calvin Liu wrote: > Hi all, > I'd like to call for a vote on KIP-966 which includes a series of > enhancements to the current ISR model. > >- I