[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292488#comment-13292488
]
Chris Male commented on LUCENE-3312:
Yeah StoredDocument should only consist of Stora
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397487#comment-13397487
]
Uwe Schindler commented on LUCENE-3312:
---
Hi Nikola,
do you have any news or progres
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398324#comment-13398324
]
Chris Male commented on LUCENE-3312:
Hey Nikola,
Just did a quick pass over the patc
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398325#comment-13398325
]
Nikola Tankovic commented on LUCENE-3312:
-
I like the solution, but we will wait
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398327#comment-13398327
]
Uwe Schindler commented on LUCENE-3312:
---
Chris: The iterator looks generics-wise co
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398330#comment-13398330
]
Chris Male commented on LUCENE-3312:
Yes you're right on all accounts.
Taking a look
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398331#comment-13398331
]
Uwe Schindler commented on LUCENE-3312:
---
This is an example how to do it correct (j
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398348#comment-13398348
]
Nikola Tankovic commented on LUCENE-3312:
-
Can I use something like this?
{code}
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398353#comment-13398353
]
Chris Male commented on LUCENE-3312:
I think we should make it so you can use appropr
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398356#comment-13398356
]
Uwe Schindler commented on LUCENE-3312:
---
The code I sent was just an example. We ha
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398361#comment-13398361
]
Nikola Tankovic commented on LUCENE-3312:
-
Maybe something like this?
{code}
p
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398368#comment-13398368
]
Nikola Tankovic commented on LUCENE-3312:
-
OK, so no AbstractIterator then. I wil
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398429#comment-13398429
]
Nikola Tankovic commented on LUCENE-3312:
-
Let me know if I can further improve t
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398432#comment-13398432
]
Uwe Schindler commented on LUCENE-3312:
---
Looks fine, I would disallow remove() comp
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398435#comment-13398435
]
Chris Male commented on LUCENE-3312:
Why not make this a public class in util.* and k
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398438#comment-13398438
]
Uwe Schindler commented on LUCENE-3312:
---
+1
> Break out StorableFi
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398446#comment-13398446
]
Nikola Tankovic commented on LUCENE-3312:
-
I think this is now OK, I'll put in ut
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404449#comment-13404449
]
Uwe Schindler commented on LUCENE-3312:
---
Hi Nikola,
I will think about the core API
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404450#comment-13404450
]
Nikola Tankovic commented on LUCENE-3312:
-
Agreed! No problem about commit access
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407509#comment-13407509
]
Uwe Schindler commented on LUCENE-3312:
---
Hi Nikola,
I merged your patch to current
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407524#comment-13407524
]
Uwe Schindler commented on LUCENE-3312:
---
And as noted before: In Lucene core we don
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407894#comment-13407894
]
Nikola Tankovic commented on LUCENE-3312:
-
Uwe,
I apologize for inconveniences.
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407897#comment-13407897
]
Chris Male commented on LUCENE-3312:
My feeling at least is that we should definitely
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407898#comment-13407898
]
Uwe Schindler commented on LUCENE-3312:
---
Fine, thanks. I had no time to do API wise
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408611#comment-13408611
]
Nikola Tankovic commented on LUCENE-3312:
-
Hi, I'm going over tests and so far so
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408626#comment-13408626
]
Chris Male commented on LUCENE-3312:
If the test is wanting to retrieve the ID field
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408973#comment-13408973
]
Michael McCandless commented on LUCENE-3312:
Hmm ... if the test is running f
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408997#comment-13408997
]
Michael McCandless commented on LUCENE-3312:
Branch looks good!
But we still
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409375#comment-13409375
]
Chris Male commented on LUCENE-3312:
bq. Hmm ... if the test is running fine today, n
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409402#comment-13409402
]
Chris Male commented on LUCENE-3312:
bq. Regarding 'deleteField' in 'StoredDocument',
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409419#comment-13409419
]
Uwe Schindler commented on LUCENE-3312:
---
I applied the patch to the branch: At revi
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409432#comment-13409432
]
Uwe Schindler commented on LUCENE-3312:
---
Done, no new compile failures! At revision
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409461#comment-13409461
]
Nikola Tankovic commented on LUCENE-3312:
-
Hi Uwe,
how can I see those warnings
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409464#comment-13409464
]
Uwe Schindler commented on LUCENE-3312:
---
"ant compile" on command line. Before send
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409476#comment-13409476
]
Nikola Tankovic commented on LUCENE-3312:
-
Yes, of course :) Mike taught me that.
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409481#comment-13409481
]
Uwe Schindler commented on LUCENE-3312:
---
Maybe you missed to clean before? ANT's ja
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409484#comment-13409484
]
Nikola Tankovic commented on LUCENE-3312:
-
Sorry for my n00b-iness. Thank you!
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409641#comment-13409641
]
Uwe Schindler commented on LUCENE-3312:
---
I merged trunk again (because of LUCENE-41
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411355#comment-13411355
]
Uwe Schindler commented on LUCENE-3312:
---
Nikola: Did you get the test running now?
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411920#comment-13411920
]
Nikola Tankovic commented on LUCENE-3312:
-
Hi Uwe,
I have the test fixed, and b
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414097#comment-13414097
]
Uwe Schindler commented on LUCENE-3312:
---
Hi Nikola,
the second half of the GSoC sta
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414100#comment-13414100
]
Nikola Tankovic commented on LUCENE-3312:
-
Hi Uwe,
in a few days I will hopeful
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414102#comment-13414102
]
Uwe Schindler commented on LUCENE-3312:
---
Is there anything at the moment you need h
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414107#comment-13414107
]
Nikola Tankovic commented on LUCENE-3312:
-
Not at the moment, just little more ti
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419831#comment-13419831
]
Nikola Tankovic commented on LUCENE-3312:
-
I keep getting this error:
{code}
[jun
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419832#comment-13419832
]
Robert Muir commented on LUCENE-3312:
-
Yes. There aren't many tests that test that Lu
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065180#comment-13065180
]
Simon Willnauer commented on LUCENE-3312:
-
once we are on this here we should thi
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092625#comment-13092625
]
Chris Male commented on LUCENE-3312:
With LUCENE-2308 out of the way, I've started lo
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092948#comment-13092948
]
Michael McCandless commented on LUCENE-3312:
bq. Due to the fact that FieldIn
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093406#comment-13093406
]
Chris Male commented on LUCENE-3312:
{quote}
Good question... I think the userland "F
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093483#comment-13093483
]
Chris Male commented on LUCENE-3312:
I'm almost done getting an initial patch for thi
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093499#comment-13093499
]
Simon Willnauer commented on LUCENE-3312:
-
bq. I'm almost done getting an initial
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093513#comment-13093513
]
Chris Male commented on LUCENE-3312:
Just for clarification, Packed refers to the not
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093520#comment-13093520
]
Simon Willnauer commented on LUCENE-3312:
-
bq. Just for clarification, Packed ref
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093525#comment-13093525
]
Chris Male commented on LUCENE-3312:
Given what you say about the similarities betwee
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093698#comment-13093698
]
Chris Male commented on LUCENE-3312:
{quote}
Good question... I think the userland "F
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093802#comment-13093802
]
Chris Male commented on LUCENE-3312:
So one thought would be to have a different clas
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093818#comment-13093818
]
Michael McCandless commented on LUCENE-3312:
I agree DocValues seem both inde
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093825#comment-13093825
]
Michael McCandless commented on LUCENE-3312:
bq. So one thought would be to h
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113984#comment-13113984
]
Chris Male commented on LUCENE-3312:
Back on this wagon for a bit.
Just wondering ab
101 - 160 of 160 matches
Mail list logo
