[jira] [Commented] (SOLR-8451) We should not call method.abort in HttpSolrClient and HttpSolrCall#remoteQuery should not close streams.

2016-01-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121955#comment-15121955 ] ASF subversion and git services commented on SOLR-8451: --- Commit

[jira] [Commented] (SOLR-8451) We should not call method.abort in HttpSolrClient and HttpSolrCall#remoteQuery should not close streams.

2016-01-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121939#comment-15121939 ] ASF subversion and git services commented on SOLR-8451: --- Commit

[jira] [Commented] (SOLR-8451) We should not call method.abort in HttpSolrClient and HttpSolrCall#remoteQuery should not close streams.

2016-01-21 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111807#comment-15111807 ] Mark Miller commented on SOLR-8451: --- bq. HttpClient appears to clean up these situations for us. I have

[jira] [Commented] (SOLR-8451) We should not call method.abort in HttpSolrClient and HttpSolrCall#remoteQuery should not close streams.

2016-01-20 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110095#comment-15110095 ] Mark Miller commented on SOLR-8451: --- Okay, I'd like to come back to this and actually add an attempt to

[jira] [Commented] (SOLR-8451) We should not call method.abort in HttpSolrClient and HttpSolrCall#remoteQuery should not close streams.

2016-01-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097099#comment-15097099 ] ASF subversion and git services commented on SOLR-8451: --- Commit 1724516 from

[jira] [Commented] (SOLR-8451) We should not call method.abort in HttpSolrClient.

2016-01-05 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083852#comment-15083852 ] Mark Miller commented on SOLR-8451: --- I have a connection reuse test that hits HttpSolrClient,

[jira] [Commented] (SOLR-8451) We should not call method.abort in HttpSolrClient.

2015-12-24 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071304#comment-15071304 ] Mark Miller commented on SOLR-8451: --- It's the right thing to do. I have read the doc, the code, and

[jira] [Commented] (SOLR-8451) We should not call method.abort in HttpSolrClient.

2015-12-23 Thread Karl Wright (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069751#comment-15069751 ] Karl Wright commented on SOLR-8451: --- I don't follow the reasoning here. AFAICT method.abort should be

[jira] [Commented] (SOLR-8451) We should not call method.abort in HttpSolrClient.

2015-12-23 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069755#comment-15069755 ] Mark Miller commented on SOLR-8451: --- bq. whenever there's any chance that the response has not been fully

[jira] [Commented] (SOLR-8451) We should not call method.abort in HttpSolrClient.

2015-12-23 Thread Karl Wright (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069812#comment-15069812 ] Karl Wright commented on SOLR-8451: --- Hmm, under some circumstances this is definitely not the right thing