[jira] [Commented] (LUCENE-7053) Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator()

2016-02-28 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171008#comment-15171008 ] Uwe Schindler commented on LUCENE-7053: --- There is a bit code duplication in both te

[jira] [Commented] (LUCENE-7053) Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator()

2016-02-28 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171010#comment-15171010 ] Michael McCandless commented on LUCENE-7053: +1 to the patch. You can also f

[jira] [Commented] (LUCENE-7053) Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator()

2016-02-28 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171012#comment-15171012 ] Uwe Schindler commented on LUCENE-7053: --- bq. We can take this further, e.g. I grep'

[jira] [Commented] (LUCENE-7053) Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator()

2016-02-28 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171027#comment-15171027 ] Uwe Schindler commented on LUCENE-7053: --- As we implemented {{compareTo}} we could r

[jira] [Commented] (LUCENE-7053) Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator()

2016-02-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171058#comment-15171058 ] Robert Muir commented on LUCENE-7053: - Yes, please, and remove BytesRef.COMPARATOR wh

[jira] [Commented] (LUCENE-7053) Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator(); remove natural comparator in favour of Java 8 one

2016-02-28 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171087#comment-15171087 ] Uwe Schindler commented on LUCENE-7053: --- All tests pass. > Remove deprecated Bytes

[jira] [Commented] (LUCENE-7053) Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator(); remove natural comparator in favour of Java 8 one

2016-02-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1517#comment-1517 ] Robert Muir commented on LUCENE-7053: - +1 > Remove deprecated BytesRef#getUTF8Sorted

[jira] [Commented] (LUCENE-7053) Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator(); remove natural comparator in favour of Java 8 one

2016-02-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171576#comment-15171576 ] ASF subversion and git services commented on LUCENE-7053: - Commit

[jira] [Commented] (LUCENE-7053) Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator(); remove natural comparator in favour of Java 8 one

2016-02-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171596#comment-15171596 ] ASF subversion and git services commented on LUCENE-7053: - Commit

[jira] [Commented] (LUCENE-7053) Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator(); remove natural comparator in favour of Java 8 one

2016-02-29 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171680#comment-15171680 ] Michael McCandless commented on LUCENE-7053: Thanks [~thetaphi]! > Remove de

[jira] [Commented] (LUCENE-7053) Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator(); remove natural comparator in favour of Java 8 one

2016-03-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174080#comment-15174080 ] ASF subversion and git services commented on LUCENE-7053: - Commit