Re: [M2] Proposal for filtering of resources

2005-08-26 Thread Carsten Ziegeler
I added an issue to JIRA for this: MNG-788. I described a slightly different (imho better :) ) solution. If noone objects I'll come up with a patch in the next days. Carsten -- Carsten Ziegeler - Open Source Group, SN AG http://www.s-und-n.de http://www.osoco.org/weblogs/rael/

Re: [M2] Proposal for filtering of resources

2005-08-25 Thread Carsten Ziegeler
From the plan below, I'm able to address a) and b), but currently I don't know how to enhance the POM (Item c)). So if anyone could implement c) I'm willing to provide a patch for the resource plugin. Carsten Carsten Ziegeler wrote: Now, what do you think of the following: a) the resource

Re: [M2] Proposal for filtering of resources

2005-08-25 Thread Trygve Laugstøl
On Thu, Aug 25, 2005 at 03:18:45PM +0200, Carsten Ziegeler wrote: From the plan below, I'm able to address a) and b), but currently I don't know how to enhance the POM (Item c)). So if anyone could implement c) I'm willing to provide a patch for the resource plugin. You can change the POM

Re: [M2] Proposal for filtering of resources

2005-08-25 Thread Carsten Ziegeler
Trygve Laugstøl wrote: On Thu, Aug 25, 2005 at 03:18:45PM +0200, Carsten Ziegeler wrote: From the plan below, I'm able to address a) and b), but currently I don't know how to enhance the POM (Item c)). So if anyone could implement c) I'm willing to provide a patch for the resource plugin.

Re: [M2] Proposal for filtering of resources

2005-08-25 Thread Brett Porter
Yes, I know - but I'm not sure how to add a nested structure to it, but perhaps I can figure it out somehow... But before I start working on a patch, I would like to know if there is general interest in it. I don't want to work for the trashcan :) I think we're all interested, but I'd like

Re: [M2] Proposal for filtering of resources

2005-08-25 Thread Kenney Westerhof
On Thu, 25 Aug 2005, Carsten Ziegeler wrote: There sure is. I suggest you create a JIRA issue for this, and describe the final solution there so we have a central place for the design. Also you can attach the patches you make there. Some comments: c) The POM gets the filtering tags at the

Re: [M2] Proposal for filtering of resources

2005-08-25 Thread Carsten Ziegeler
Kenney Westerhof wrote: Thinking about this, I'm not really sure anymore what the correct solution would be. We have the following features/demands: I had the same feeling yesterday when I wrote the last proposal :) 1) being able to split resources up into two groups: the filtered-on-copy

Re: [M2] Proposal for filtering of resources

2005-08-25 Thread Thomas Van de Velde
I agree with Kenney on the need for environment specific filter files. I have used such an approach for M1 as follows: goal name=filter:init !-- Check if an environment has been passed -- maven:paramCheck value=${maven.filter.env} fail=true message=You have to define a filter environment

Re: [M2] Proposal for filtering of resources

2005-08-25 Thread Kenney Westerhof
On Thu, 25 Aug 2005, Thomas Van de Velde wrote: I am wondering if M2 could have something like: filtering filterTokens tokenvalue/token /filterTokens filterFiles filterFile env=foodevfoo.properties/filterFile filterFilebar.properties/filterFile /filterFiles /filtering Filters are

[M2] Proposal for filtering of resources

2005-08-24 Thread Carsten Ziegeler
In my opinion the current configuration of resources wrt filtering is a little bit too complicated and not as user friendly as it could be :) I think the most natural way is to configure the filters directly on the resources. This allows to easily configure different resource sets with different

Re: [M2] Proposal for filtering of resources

2005-08-24 Thread Brett Porter
I think this is reasonable, but I'd like to allow multiple sources (properties, and multiple files). The existence of the filtering element can be used to trigger it. filtering filterTokens tokenvalue/token /filterTokens filterFiles filterFilefoo.properties/filterFile

Re: [M2] Proposal for filtering of resources

2005-08-24 Thread Carsten Ziegeler
Brett Porter wrote: I think this is reasonable, but I'd like to allow multiple sources (properties, and multiple files). The existence of the filtering element can be used to trigger it. filtering filterTokens tokenvalue/token /filterTokens filterFiles

Re: [M2] Proposal for filtering of resources

2005-08-24 Thread Kenney Westerhof
On Wed, 24 Aug 2005, Brett Porter wrote: I think this is reasonable, but I'd like to allow multiple sources (properties, and multiple files). The existence of the filtering element can be used to trigger it. I don't think it's a good idea to specify the filter files at the resource level

Re: [M2] Proposal for filtering of resources

2005-08-24 Thread Carsten Ziegeler
Kenney Westerhof wrote: On Wed, 24 Aug 2005, Brett Porter wrote: I think this is reasonable, but I'd like to allow multiple sources (properties, and multiple files). The existence of the filtering element can be used to trigger it. I don't think it's a good idea to specify the filter files

Re: [M2] Proposal for filtering of resources

2005-08-24 Thread Kenney Westerhof
On Wed, 24 Aug 2005, Carsten Ziegeler wrote: The difference is that you only define the _tokens_ in the pom, not their values. This indicates which tokens are used by the resource files. Specifying both key and value pairs in the pom doesn't allow for users of the project to specify their own

Re: [M2] Proposal for filtering of resources

2005-08-24 Thread Carsten Ziegeler
Kenney Westerhof wrote: On Wed, 24 Aug 2005, Carsten Ziegeler wrote: The difference is that you only define the _tokens_ in the pom, not their values. This indicates which tokens are used by the resource files. Ah, sorry, I didn't notice this detail in your previous post. Ok, now I get it.

Re: [M2] Proposal for filtering of resources

2005-08-24 Thread Incze Lajos
On Wed, Aug 24, 2005 at 04:21:58PM +1000, Brett Porter wrote: I think this is reasonable, but I'd like to allow multiple sources (properties, and multiple files). The existence of the filtering element can be used to trigger it. filtering filterTokens tokenvalue/token

Re: [M2] Proposal for filtering of resources

2005-08-24 Thread Kenney Westerhof
On Wed, 24 Aug 2005, Incze Lajos wrote: And what if you use something like this (in resource): resource ... filteringprofile-reference/filtering /resource where the profile id references a filter specification along the above line augmented with an context name, which can be