[GitHub] metron issue #883: METRON-1381: Add Apache license to MD files and remove th...

2017-12-30 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/883 @JonZeolla Yes, I did. No idea what I was thinking, in all honesty. @nickwallen You're the actual person I wanted here. ---

Re: [DISCUSS] Removing Markdown files from rat exclusion

2017-12-30 Thread Justin Leet
I've updated the PR to add the header to a new MD file that went in. I've also commented on all PRs that I saw that would potentially be problematic were they to go into master if they weren't merged first. Once the updated PR gets the +1's reaffirmed, it will be merged into master and Markdown h

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-12-30 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r159122619 --- Diff: metron-platform/metron-parsers/3rdPartyParser.md --- @@ -0,0 +1,306 @@ +# Custom Metron Parsers --- End diff -- Not sure what th

[GitHub] metron issue #883: METRON-1381: Add Apache license to MD files and remove th...

2017-12-30 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/883 Did you mean to tag @nickwallen in that last comment? I took a quick look and it all looks good to me but didn't do any verification that you got all of the md files (depending on Travis), and did

[GitHub] metron pull request #840: METRON-939: Upgrade ElasticSearch and Kibana

2017-12-30 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/840#discussion_r159122591 --- Diff: metron-deployment/README.md --- @@ -1,3 +1,16 @@ +# Metron Deployment --- End diff -- Can you please add the license header to t

[GitHub] metron issue #865: METRON-1212 The bundle System and Maven Plugin (Feature B...

2017-12-30 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/865 Given that this is a feature branch, I'm sure master will be merged in, but as a reminder, markdown file headers will be enforced by rat relatively soon (so any new markdown files in here will nee

[GitHub] metron pull request #882: METRON-1380: Create a typosquatting use-case (comm...

2017-12-30 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/882#discussion_r159122512 --- Diff: use-cases/typosquat_detection/README.md --- @@ -0,0 +1,431 @@ +# Problem Statement --- End diff -- Can you please add the licens

[GitHub] metron pull request #884: METRON-1382 Run Stellar in a Zeppelin Notebook

2017-12-30 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/884#discussion_r159122504 --- Diff: metron-stellar/stellar-zeppelin/README.md --- @@ -0,0 +1,85 @@ +# Stellar Interpreter for Apache Zeppelin + +[Apache Zeppelin](https:

[GitHub] metron issue #883: METRON-1381: Add Apache license to MD files and remove th...

2017-12-30 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/883 @ottobackwards @JonZeolla Merged in master and added header to new markdown file (the deb deployment one). Once you two are satisfied with the new commit, and I've run through the outstanding PRs