Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/563
This currently has conflicts with master and needs to be rebased before it
can be merged (sorry for taking so long to review the PR).
---
If your project is set up for it, you can reply
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r69829659
--- Diff:
nifi-api/src/main/java/org/apache/nifi/components/state/ExternalStateManager.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r69829390
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/ConsumeKafka.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r69828743
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestGetKafka.java
---
@@ -166,4 +170,44
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r69827581
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java
---
@@ -481,4 +496,51
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r69827217
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java
---
@@ -218,11 +232,13
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r69827142
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java
---
@@ -184,6 +195,9
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/563
@ijokarumawak I believe you're right about it only being Kafka. I looked
through them as well and couldn't find an instance of external state.
While surprised I am definitely happy because
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/612
+1
Reviewed code, did a contrib check build, created a cluster to demonstrated
the problem and then recreated with the fix and the issue was resolved. Thanks
Mark will merge it in to 0.x
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/29#discussion_r69802769
--- Diff: minifi-docs/LICENSE ---
@@ -0,0 +1,235 @@
+
+ Apache License
+ Version
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/29#discussion_r69802803
--- Diff: LICENSE ---
@@ -0,0 +1,235 @@
+
+ Apache License
+ Version 2.0, January
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/29#discussion_r69802152
--- Diff: README.md ---
@@ -18,7 +18,100 @@ MiNiFi is a child project effort of Apache NiFi
## Table of Contents
+- [Features
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/29#discussion_r69801770
--- Diff: NOTICE ---
@@ -0,0 +1,9 @@
+Apache NiFi - MiNiFi
+Copyright 2014-2016 The Apache Software Foundation
+
+This product includes
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/576
+1
Did a contrib check build, reviewed the code and comments were addressed,
and did a functional test using vanilla ES as well as one secured with Shield.
Thanks for the contribution
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69745504
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69745293
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/24#discussion_r69504541
--- Diff:
minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/configuration/notifiers/util/TestRestChangeNotifierCommon.java
---
@@ -84,6
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi-minifi/pull/25
MINIFI-22 Removing lingering parts of UI
Most of this work was done with MINIFI-38 but there were still some
lingering transitive dependencies being brought in that needed to be removed
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69371933
--- Diff:
minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMain.java
---
@@ -0,0 +1,342
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69357651
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69352051
--- Diff:
minifi-toolkit/minifi-toolkit-configuration/src/test/resources/Splunk_Processors_with_Listen_TCP.xml
---
@@ -0,0 +1,18
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69342080
--- Diff:
minifi-toolkit/minifi-toolkit-configuration/src/test/resources/Splunk_Processors_with_Listen_TCP.xml
---
@@ -0,0 +1,18
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/576
It would be nice to have integration tests similar to those in the original
Fetch/PutElasticSearch processors.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69324539
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69323436
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69320973
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69320860
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69320695
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/pom.xml
---
@@ -56,6 +56,11 @@ language governing permissions
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69319929
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69319708
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69319479
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69319085
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69318837
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69318008
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69317662
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69317330
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69317281
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69317035
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69316350
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69314307
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69313807
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69313182
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69312668
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69306232
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/pom.xml
---
@@ -56,6 +56,11 @@ language governing permissions
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69218372
--- Diff: minifi-commons/minifi-commons-schema/pom.xml ---
@@ -0,0 +1,46 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69214705
--- Diff: minifi-toolkit/minifi-toolkit-configuration/pom.xml ---
@@ -0,0 +1,42 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69210176
--- Diff:
minifi-toolkit/minifi-toolkit-assembly/src/main/resources/config.sh ---
@@ -0,0 +1,133 @@
+#!/bin/sh
+#
+#Licensed
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69180850
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/BaseSchema.java
---
@@ -15,13 +15,17
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69178841
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/BaseSchema.java
---
@@ -15,13 +15,17
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69162642
--- Diff: minifi-toolkit/minifi-toolkit-assembly/NOTICE ---
@@ -0,0 +1,21 @@
+Apache NiFi
+Copyright 2014-2016 The Apache Software Foundation
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69159093
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/SchemaLoader.java
---
@@ -0,0 +1,52
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68943688
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68799710
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68780468
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68780983
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68777286
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68666372
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68660039
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/573
+1
Fixes errors seen on Windows, code looks good and passes contrib-check.
Thanks Mark
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user JPercivall closed the pull request at:
https://github.com/apache/nifi/pull/569
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi/pull/570
NIFI-2098 Adding ignore annotation to testManyFilesOpened unit test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi NIFI-2098
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi/pull/569
NIFI-2097 Changing RemoteProcessGroupStatusTest.java to use a random open
port ...
... instead of a statically defined one
You can merge this pull request into a Git repository by running
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/556
Ah sorry @jskora for misinterpreting it, changes look good. I am gonna do
another round of testing and then should be good to merge.
---
If your project is set up for it, you can reply
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/556
@jskora what about changing it so there is a media and image bundles?
Reading this comment[1] it's what we decided and the only way not to break
backwards compatibility.
[1] https
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/556
According to the latest comment from @bbende, yes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/556
The only relevant exception I saw processing the download folder was an xml
parse error related to a underlying limitation of Tika, no need to address:
2016-06-22 11:32:19,774 ERROR [Timer
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/556
@markap14 it seems odd to limit the usefulness of provenance for the reason
to "keep data in the flow". Information is being created on "why this flowfile
failed"
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/556
I am trying to parse my downloads folder again and I came across a couple
exceptions (will post in other comment) but as I try to figure why it happened
I realize that since ExtractMediaMetatadata
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/556#discussion_r68074121
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/556#discussion_r68056970
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/test/java/org/apache/nifi/processors/media/TestExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/556#discussion_r68052320
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/556#discussion_r67982895
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/556#discussion_r67969885
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/test/java/org/apache/nifi/processors/media/TestExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/556#discussion_r67964066
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/556#discussion_r67963557
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/556#discussion_r67963320
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/556#discussion_r67963044
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/548#discussion_r67957184
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
@@ -288,9 +289,13
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/548#discussion_r67957067
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
@@ -288,9 +289,13
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/555
Nope I am missing it, sorry about that. Once the travis build finishes
successfully I am +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/555
In cases where validateWarnWhenPercentThresholdReached fails would
validateWarnWhenSizeThresholdReached fail too? Wondering if we should ignore
both.
---
If your project is set up for it, you can
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/543
Also, for the sake of transparency, we had a discussion offline debating
the various directions to go to handle the "consistent inconsistency" and had
the idea for a way for the user to c
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/543
Thanks @olegz, will merge it in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67801359
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,290
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67800576
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,290
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67799164
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,290
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/252
@jskora were you able to rebase and open a new PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67782966
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,290
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67782856
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,290
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r6337
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutTCP.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67776824
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,290
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/542
Specifically looking at Bryan's commit: I looked through the code and built
locally (since travis failed for un-related issues) and it looks good.
+1
---
If your project is set up
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/542#discussion_r67723205
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseJSON.java
---
@@ -89,6 +89,25
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67722269
--- Diff:
nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/put/AbstractPutEventProcessor.java
---
@@ -119,7 +119,24
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/542#discussion_r67714535
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseJSON.java
---
@@ -89,6 +89,25
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/542#discussion_r67713339
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseJSON.java
---
@@ -89,6 +89,25
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67707758
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,270
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67707310
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,270
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/272
Thanks for the assist @apiri
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/543
I agree with @joewitt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
1 - 100 of 345 matches
Mail list logo
