Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/180#discussion_r50873154
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/FetchElasticsearch.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/180#discussion_r50872992
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/FetchElasticsearch.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/180#discussion_r50872655
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/180#discussion_r50872609
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/180#discussion_r50872442
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/180#discussion_r50872379
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/180#discussion_r50871641
--- Diff: nifi-assembly/LICENSE ---
@@ -1085,29 +1085,3 @@ information can be found here:
http://www.adobe.com/devnet/xmp/library/eula-xmp-
LIABILITY
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/185#issuecomment-175089667
@mattyb149 wow this set of Processors is quite a feat! :) I provided
feedback in the way of several inline comments. The only other thing that I
would recommend is to
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50852054
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptProcessor.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50853284
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/java/org/apache/nifi/processors/script/TestInvokeGroovy.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50853235
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/java/org/apache/nifi/processors/script/TestInvokeGroovy.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50852926
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/impl/ScalaScriptEngineConfigurator.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50852708
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptProcessor.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50852398
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptProcessor.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50851689
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50851441
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50851488
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50851174
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50850972
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50850518
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50849585
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50849985
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50849038
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50846497
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50845068
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50845300
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50844755
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/185#discussion_r50844627
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java
---
@@ -0,0
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/184#issuecomment-174658788
@rpmiskin all looks good - thanks for contributing this back! I have merged
to master, so it will be included in the 0.5.0 release. Thanks!
---
If your project is set
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/158#issuecomment-174651410
@jdye64 - it looks like this PR removes the entire
nifi-nar-bundles/nifi-ldap-iaa-providers-bundle module. I'm guessing that was
an accident :) Can you un-delete
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/158#issuecomment-174013946
@jdye64 - this is awesome! A few NiFi-isms to work out, which i commented
on inline but otherwise looks good to go. Thanks for all of the work that
you've put in
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r50576416
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchema.java
---
@@ -0,0 +1,454
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r50576123
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchema.java
---
@@ -0,0 +1,454
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r50575812
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchema.java
---
@@ -0,0 +1,454
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r50575707
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchema.java
---
@@ -0,0 +1,454
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r50575577
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchema.java
---
@@ -0,0 +1,454
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r50575282
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchema.java
---
@@ -0,0 +1,454
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r50575133
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchema.java
---
@@ -0,0 +1,454
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r50575093
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchema.java
---
@@ -0,0 +1,454
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r50575110
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchema.java
---
@@ -0,0 +1,454
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r50574984
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchema.java
---
@@ -0,0 +1,454
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r50574955
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchema.java
---
@@ -0,0 +1,454
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/135#discussion_r50328396
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java
---
@@ -198,23
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/135#discussion_r50327323
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java
---
@@ -143,26
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/177#issuecomment-173373027
~smarthi - thanks for fixing this up and contributing it back! I've merged
it into master.
---
If your project is set up for it, you can reply to this email and
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/124#issuecomment-173351611
Jeremy,
I've been reviewing this and I made a handful of minor changes:
* Copied licensing information to the nar - it was already present in
nifi-ass
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/124#issuecomment-170978164
@jdye64 I left a lot of inline comments while doing a code review. Mostly
just pointing out either naming conventions that we should strive to be
consistent with, or
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49482412
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/PutHTMLElement.java
---
@@ -0,0 +1,150
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49482104
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49482019
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/ModifyHTMLElement.java
---
@@ -0,0 +1,164
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49481748
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/test/java/org/apache/nifi/TestGetHTMLElement.java
---
@@ -0,0 +1,319
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49481551
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/test/java/org/apache/nifi/TestGetHTMLElement.java
---
@@ -0,0 +1,319
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49481366
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/test/java/org/apache/nifi/TestGetHTMLElement.java
---
@@ -0,0 +1,319
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49481210
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/test/java/org/apache/nifi/AbstractHTMLTest.java
---
@@ -0,0 +1,74
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480961
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/PutHTMLElement.java
---
@@ -0,0 +1,150
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480952
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/PutHTMLElement.java
---
@@ -0,0 +1,150
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480617
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/AbstractHTMLProcessor.java
---
@@ -0,0 +1,120
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480382
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480407
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480317
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49479161
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/AbstractHTMLProcessor.java
---
@@ -0,0 +1,120
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480077
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480004
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49479943
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49479814
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49478696
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/AbstractHTMLProcessor.java
---
@@ -0,0 +1,120
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49478637
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/AbstractHTMLProcessor.java
---
@@ -0,0 +1,120
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r49476742
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/test/java/org/apache/nifi/processors/kite/TestInferAvroSchemaFromCSV.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r49475763
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchemaFromCSV.java
---
@@ -0,0 +1,235
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r49475867
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchemaFromCSV.java
---
@@ -0,0 +1,235
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r49475642
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchemaFromJSON.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r49475535
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchemaFromJSON.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/158#discussion_r49475506
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchemaFromJSON.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/163#discussion_r49474698
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/pom.xml
---
@@ -120,4 +124,99 @@
provided
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/163#discussion_r49474547
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/test/java/org/apache/nifi/web/security/x509/ocsp
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/163#discussion_r49474399
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/pom.xml
---
@@ -120,4 +124,99 @@
provided
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/163#discussion_r49474365
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/pom.xml
---
@@ -120,4 +124,99 @@
provided
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/166#issuecomment-170953688
@jvwing - nice catch! Will merge this in shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/165#discussion_r49469400
--- Diff:
nifi-mock/src/main/java/org/apache/nifi/util/MockProcessorLog.java ---
@@ -16,20 +16,57 @@
*/
package org.apache.nifi.util
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/141#issuecomment-167591336
@olegz - I'm very happy that you are digging in here. This bit of code
certainly could use some TLC and refactoring. I very much like the approach of
moving this
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/141#discussion_r48486134
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/131#issuecomment-159124855
@olegz I left a handful of comments in-line. Otherwise, looks great! Very
happy to have someone else digging into these Processors and the code is
certainly looking
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/131#discussion_r45688132
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestGetKafka.java
---
@@ -45,13 +45,18
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/131#discussion_r45688059
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestGetKafka.java
---
@@ -45,13 +45,18
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/131#discussion_r45687929
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java
---
@@ -203,26 +205,69
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/131#discussion_r45687909
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java
---
@@ -70,6 +70,10
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/116#issuecomment-157452951
Yikes! @apiri the fact that the uuid attribute can be removed is a bug. I
created a ticket for this: https://issues.apache.org/jira/browse/NIFI-1182
I do agree
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/123#discussion_r44989850
--- Diff:
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/DocsReader.java
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/123#issuecomment-157182575
@trkurc Personally, I have exactly 0 qualms about changing it to package
private. If I choose to take some random util class from a release of Apache
Tomcat, for
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/127#issuecomment-157179517
@naveenmadhire - code looks good. Builds without problem, and testing on my
Kafka instance shows the expected results. Nice work! And thanks for the
contribution. On
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/126#discussion_r44975323
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/125#issuecomment-157140757
@naveenmadhire no trouble at all :) Looking forward to the new pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/125#issuecomment-156770044
Naveen, thanks for contributing this back! Certainly a nice addition to the
GetKafka processor. The patch looks good, but I did have just a couple of small
points of
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/118#discussion_r44422933
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml ---
@@ -152,7 +152,8 @@ language governing permissions and limitations under
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/118#discussion_r44421629
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestGetJMSQueue.java
---
@@ -24,73
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/118#discussion_r44421577
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestGetJMSQueue.java
---
@@ -24,73
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/118#discussion_r44421520
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestGetJMSQueue.java
---
@@ -24,73
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/118#discussion_r44421395
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestGetJMSQueue.java
---
@@ -24,73
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/118#discussion_r44421276
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestGetJMSQueue.java
---
@@ -24,73
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/118#discussion_r44421141
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml ---
@@ -152,7 +152,8 @@ language governing permissions and limitations under
301 - 400 of 421 matches
Mail list logo
