[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-06 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r207918920 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/HTableAccessWrapper.java --- @@ -20,10 +20,7 @@ import

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-06 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r207919955 --- Diff: hbase-coprocessor/src/test/java/org/apache/omid/transaction/TestSnapshotFilter.java --- @@ -226,8 +222,115 @@ public void

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206935434 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206934998 --- Diff: hbase-coprocessor/src/test/java/org/apache/omid/transaction/TestSnapshotFilter.java --- @@ -226,8 +222,115 @@ public void

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206936274 --- Diff: hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java --- @@ -52,6 +52,7 @@ static byte[] DELETE_TOMBSTONE =

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206860096 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206861622 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206848753 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/OmidSnapshotFilter.java --- @@ -83,92 +76,97 @@ public void

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206867892 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206927180 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206856182 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206857467 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206862264 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206843754 --- Diff: hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java --- @@ -382,13 +385,16 @@ public int hashCode() {

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206852241 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206839768 --- Diff: hbase-client/src/test/java/org/apache/omid/transaction/TestCellUtils.java --- @@ -99,11 +99,11 @@ public void

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread yonigottesman
GitHub user yonigottesman reopened a pull request: https://github.com/apache/incubator-omid/pull/41 [OMID-102] Support for user Filter when using coprocessor for snapshot filtering You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread yonigottesman
Github user yonigottesman closed the pull request at: https://github.com/apache/incubator-omid/pull/41 ---