Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-17 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/#review53770 --- core/src/main/java/org/apache/oozie/CoordinatorJobBean.java

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-17 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/#review53768 --- Ship it! Ship It! - Rohini Palaniswamy On Sept. 17, 2014, 10:56

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-17 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/ --- (Updated Sept. 17, 2014, 10:56 p.m.) Review request for oozie. Bugs: OOZIE-19

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-12 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/#review53208 --- StatusTransitXCommand abstract class defined methods in the order in

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-10 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/ --- (Updated Sept. 11, 2014, 1:42 a.m.) Review request for oozie. Bugs: OOZIE-194

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-10 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/#review52944 --- core/src/main/java/org/apache/oozie/command/bundle/BundleStatusTran

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-10 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/#review52782 --- core/src/main/java/org/apache/oozie/BundleJobBean.java

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-09 Thread Mona Chitnis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/#review52789 --- Ship it! Looks good now. Thanks for the 2 clarifications above. -

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-09 Thread Purshotam Shah
> On Sept. 9, 2014, 3:12 p.m., Mona Chitnis wrote: > > core/src/main/java/org/apache/oozie/command/bundle/BundleStatusTransitXCommand.java, > > line 81 > > > > > > But this is executed only if condition bAction.getCoor

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-09 Thread Mona Chitnis
> On Sept. 4, 2014, 8:55 p.m., Mona Chitnis wrote: > > core/src/main/java/org/apache/oozie/command/bundle/BundleStatusTransitXCommand.java, > > line 177 > > > > > > related question, is this situation possible? - job

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-09 Thread Mona Chitnis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/#review52722 --- core/src/main/java/org/apache/oozie/command/bundle/BundleStatusTran

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-08 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/ --- (Updated Sept. 8, 2014, 9:15 p.m.) Review request for oozie. Bugs: OOZIE-1940

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-08 Thread Purshotam Shah
> On Sept. 4, 2014, 8:55 p.m., Mona Chitnis wrote: > > core/src/main/java/org/apache/oozie/command/bundle/BundleStatusTransitXCommand.java, > > line 81 > > > > > > do we need to execute this synchronously? None of the

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-08 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/#review52627 --- core/src/main/java/org/apache/oozie/command/bundle/BundleStatusTran

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-09-04 Thread Mona Chitnis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/#review52346 --- core/src/main/java/org/apache/oozie/command/bundle/BundleStatusTran

Re: Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-08-27 Thread Mona Chitnis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/#review51661 --- this is good cleanup and refactoring. Did cursory review to understa

Review Request 24948: OOZIE-1940 StatusTransitService has race condition

2014-08-25 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/ --- Review request for oozie. Bugs: OOZIE-1940 https://issues.apache.org/jira/b