Re: [ovs-dev] [PATCH v2] Fix missing system-id in INSTALL.Docker

2016-10-04 Thread Hui Kang
I like your version better. I am ok abandoning this patch. Thanks. - Hui On Tue, Oct 4, 2016 at 7:01 PM, Ben Pfaff wrote: > On Tue, Oct 04, 2016 at 04:33:02PM -0400, Hui Kang wrote: >> Signed-off-by: Hui Kang >> --- >> INSTALL.Docker.md | 8 >> 1

[ovs-dev] [PATCH v2] Fix missing system-id in INSTALL.Docker

2016-10-04 Thread Hui Kang
Signed-off-by: Hui Kang --- INSTALL.Docker.md | 8 1 file changed, 8 insertions(+) diff --git a/INSTALL.Docker.md b/INSTALL.Docker.md index b62922d..4606354 100644 --- a/INSTALL.Docker.md +++ b/INSTALL.Docker.md @@ -83,6 +83,14 @@ ovs-vsctl set Open_vSwitch . external_ids:ovn-remote

Re: [ovs-dev] [PATCH] Fix missing system-id in INSTALL.Docker

2016-10-04 Thread Hui Kang
Ben Pfaff wrote on 10/04/2016 12:25:50 AM: > From: Ben Pfaff > To: Hui Kang/Watson/IBM@IBMUS > Cc: dev@openvswitch.org, Hui Kang > Date: 10/04/2016 12:26 AM > Subject: Re: [ovs-dev] [PATCH] Fix missing system-id in INSTALL.Docker > > On Mon, Oct 03, 2016 at 10:15:21PM

Re: [ovs-dev] [PATCH] Fix missing system-id in INSTALL.Docker

2016-10-03 Thread Hui Kang
Ben Pfaff wrote on 10/03/2016 09:23:29 PM: > From: Ben Pfaff > To: Hui Kang/Watson/IBM@IBMUS > Cc: Hui Kang , dev@openvswitch.org > Date: 10/03/2016 09:23 PM > Subject: Re: [ovs-dev] [PATCH] Fix missing system-id in INSTALL.Docker > > On Mon, Oct 03, 2016 at 04:43:20PM

Re: [ovs-dev] [PATCH] Fix missing system-id in INSTALL.Docker

2016-10-03 Thread Hui Kang
"dev" wrote on 10/03/2016 03:57:21 PM: > From: Ben Pfaff > To: Hui Kang > Cc: dev@openvswitch.org > Date: 10/03/2016 03:57 PM > Subject: Re: [ovs-dev] [PATCH] Fix missing system-id in INSTALL.Docker > Sent by: "dev" > > On Mon, Oct 03, 2016 at

[ovs-dev] [PATCH] Fix missing system-id in INSTALL.Docker

2016-10-03 Thread Hui Kang
Signed-off-by: Hui Kang --- INSTALL.Docker.md | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/INSTALL.Docker.md b/INSTALL.Docker.md index b62922d..5cb49d0 100644 --- a/INSTALL.Docker.md +++ b/INSTALL.Docker.md @@ -69,6 +69,8 @@ gets cleared. It is harmless to run it

[ovs-dev] Difference between hmap and cmap

2016-09-18 Thread Hui Kang
Hi, OVS developers, I am studying the hashing functions in OVS and find these two implementations: hmap and cmap. I understand that cmap is the improved cuckoo hashing and cmap supports multiple-reader and single writer. My questions are: 1. What does hmap stand for? hash map? 2. hmap looks much

Re: [ovs-dev] [PATCH] ovn: Delete stale MAC_Bindings that result in Referential Integrity Violation

2016-08-24 Thread Hui Kang
"dev" wrote on 08/24/2016 03:10:29 AM: > From: Chandra Sekhar Vejendla/San Jose/IBM@IBMUS > To: dev@openvswitch.org > Date: 08/24/2016 03:11 AM > Subject: [ovs-dev] [PATCH] ovn: Delete stale MAC_Bindings that > result in Referential Integrity Violation > Sent by: "dev" > > The MAC_Bindings hav

Re: [ovs-dev] [PATCH, v5] Scanning only changed entries in the ovnsb

2016-08-06 Thread Hui Kang
"dev" wrote on 08/06/2016 08:38:27 AM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: Hui Kang > Cc: dev@openvswitch.org > Date: 08/06/2016 08:38 AM > Subject: Re: [ovs-dev] [PATCH, v5] Scanning only changed entries in the ovnsb > Sent by: "dev" > >

[ovs-dev] [PATCH, v5] Scanning only changed entries in the ovnsb

2016-07-27 Thread Hui Kang
off-by: Hui Kang --- ovn/northd/ovn-northd.c | 100 1 file changed, 68 insertions(+), 32 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 716f123..32c14a2 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-no

Re: [ovs-dev] [PATCH, v4] Scanning only changed entries in the ovnsb

2016-07-27 Thread Hui Kang
"dev" wrote on 07/27/2016 05:53:17 PM: > From: Ben Pfaff > To: Hui Kang > Cc: dev@openvswitch.org > Date: 07/27/2016 05:53 PM > Subject: Re: [ovs-dev] [PATCH, v4] Scanning only changed entries in the ovnsb > Sent by: "dev" > > On Tue, Jul

Re: [ovs-dev] [ovs-dev,ovn-controller] Physical: persist tunnels

2016-07-27 Thread Hui Kang
8.html > > > > > > Signed-off-by: Ryan Moats > > > > Acked-by: Flavio Fernandes > > Tested-by: Flavio Fernandes > > > > Tested this fix with a cluster of 50 hosts. > > Acked-by: Liran Schour > Tested-by: Liran Schour This patch fixes the 100

Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb

2016-07-27 Thread Hui Kang
Ben Pfaff wrote on 07/27/2016 12:30:25 PM: > From: Ben Pfaff > To: Hui Kang/Watson/IBM@IBMUS > Cc: Hui Kang , dev@openvswitch.org > Date: 07/27/2016 12:30 PM > Subject: Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb > > On Tue, Jul 26, 2016 at 03:44

[ovs-dev] [PATCH, v4] Scanning only changed entries in the ovnsb

2016-07-26 Thread Hui Kang
- Improve performance by scanning only changed port binding entries when determining whether to mark the logical switch port up or down v3->v4: - Add an initialization function to scan all entries in Port_binding table when ovn-northd restarts or fails over Signed-off-by: Hui Kang ---

Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb

2016-07-26 Thread Hui Kang
Russell Bryant wrote on 07/26/2016 03:50:44 PM: > From: Russell Bryant > To: Hui Kang/Watson/IBM@IBMUS > Cc: Ben Pfaff , Hui Kang , ovs > dev > Date: 07/26/2016 03:51 PM > Subject: Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb > > On Tue, Jul

Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb

2016-07-26 Thread Hui Kang
"dev" wrote on 07/26/2016 02:20:27 PM: > From: Ben Pfaff > To: Hui Kang > Cc: dev@openvswitch.org > Date: 07/26/2016 02:20 PM > Subject: Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb > Sent by: "dev" > > On Sat, Jul

Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb

2016-07-26 Thread Hui Kang
"dev" wrote on 07/26/2016 02:20:27 PM: > From: Ben Pfaff > To: Hui Kang > Cc: dev@openvswitch.org > Date: 07/26/2016 02:20 PM > Subject: Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb > Sent by: "dev" > > On Sat, Jul

Re: [ovs-dev] [PATCH v3] [OVN-northd] Rename nbs/nbr port names tonbsp/nbrp

2016-07-20 Thread Hui Kang
"dev" wrote on 07/19/2016 04:15:56 PM: > From: Justin Pettit > To: Hui Kang > Cc: dev@openvswitch.org > Date: 07/19/2016 04:16 PM > Subject: Re: [ovs-dev] [PATCH v3] [OVN-northd] Rename nbs/nbr port > names to nbsp/nbrp > Sent by: "dev" > > &g

[ovs-dev] [PATCH v3] [OVN-northd] Rename nbs/nbr port names to nbsp/nbrp

2016-07-19 Thread Hui Kang
These variables indicate ports in nb switches or routers. Signed-off-by: Hui Kang -- v2->v3: - rebase agains master branch v1->v2: - modify commit message --- ovn/northd/ovn-northd.c | 184 1 file changed, 92 insertions(+), 92 deletions(-)

[ovs-dev] [PATCH v2] [OVN-northd] Rename nbs/nbr port names to nbsp/nbrp

2016-07-19 Thread Hui Kang
These variables indicate ports in nb switches or routers. Signed-off-by: Hui Kang -- v1->v2: - modify commit message --- ovn/northd/ovn-northd.c | 196 1 file changed, 98 insertions(+), 98 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/

Re: [ovs-dev] [PATCH] [OVN-northd] Rename nbs/nbr to nbsp/nbrp

2016-07-18 Thread Hui Kang
Make sense to me. I will update the patch. Thanks, Ryan. - Hui On Mon, Jul 18, 2016 at 10:37 AM, Ryan Moats wrote: > "dev" wrote on 07/02/2016 12:25:11 PM: > >> From: Ben Pfaff >> To: Justin Pettit >> Cc: dev@openvswitch.org, Hui Kang >> Date: 07/0

Re: [ovs-dev] [PATCH v2] Scanning only changed entries in the ovnsb

2016-07-16 Thread Hui Kang
"dev" wrote on 07/16/2016 10:47:14 PM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: Hui Kang > Cc: dev@openvswitch.org > Date: 07/16/2016 10:47 PM > Subject: Re: [ovs-dev] [PATCH v2] Scanning only changed entries in the ovnsb > Sent by: "dev" >

[ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb

2016-07-16 Thread Hui Kang
Improve performance by scanning only changed port binding entries when determining whether to mark the logical switch port up or down Signed-off-by: Hui Kang --- ovn/northd/ovn-northd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd

[ovs-dev] [PATCH v2] Scanning only changed entries in the ovnsb

2016-07-14 Thread Hui Kang
Improve performance by scanning only changed entries in ovnsb Signed-off-by: Hui Kang --- ovn/northd/ovn-northd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 7ce509d..bb6b853 100644 --- a/ovn/northd/ovn

[ovs-dev] [PATCH] Scanning only changed entries in the ovnsb

2016-07-14 Thread Hui Kang
Improve performance by scanning only changed entries in ovnsb Signed-off-by: Hui Kang --- ovn/northd/ovn-northd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 7ce509d..bb6b853 100644 --- a/ovn/northd/ovn

[ovs-dev] [PATCH] Scanning only changed entries in the ovnsb

2016-07-14 Thread Hui Kang
Improve performance by scanning only changed entries in ovnsb Signed-off-by: Hui Kang --- ovn/northd/ovn-northd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 7ce509d..8a73a3a 100644 --- a/ovn/northd/ovn

Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

2016-06-27 Thread Hui Kang
Ryan Moats/Omaha/IBM wrote on 06/25/2016 09:07:39 PM: > From: Ryan Moats/Omaha/IBM > To: Hui Kang/Watson/IBM@IBMUS > Cc: Ben Pfaff , dev@openvswitch.org > Date: 06/25/2016 09:07 PM > Subject: Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd > on creating and bindi

Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

2016-06-26 Thread Hui Kang
Ryan Moats/Omaha/IBM wrote on 06/26/2016 08:53:19 PM: > From: Ryan Moats/Omaha/IBM > To: Hui Kang/Watson/IBM@IBMUS > Cc: Ben Pfaff , dev@openvswitch.org > Date: 06/26/2016 08:53 PM > Subject: Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd > on creating and bindi

Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

2016-06-26 Thread Hui Kang
Ryan Moats/Omaha/IBM wrote on 06/25/2016 09:07:39 PM: > From: Ryan Moats/Omaha/IBM > To: Hui Kang/Watson/IBM@IBMUS > Cc: Ben Pfaff , dev@openvswitch.org > Date: 06/25/2016 09:07 PM > Subject: Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd > on creating and bindi

Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

2016-06-25 Thread Hui Kang
> > > > Actually, I take that back. The cycles/port for all the cases above > > demonstrate only slightly nonlinear scaling: 200/25 is 8 Mcycles/port, > > 1200/125 is 9.6 Mcycles/port. > > > > So the issue is not that it does not scale. The issue is that it is > > slow. > > Er? When I do the rati

Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

2016-06-24 Thread Hui Kang
Ryan Moats/Omaha/IBM wrote on 06/24/2016 10:51:10 PM: > From: Ryan Moats/Omaha/IBM > To: Hui Kang/Watson/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 06/24/2016 10:51 PM > Subject: Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd > on creating and binding larg

Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

2016-06-24 Thread Hui Kang
Ben Pfaff wrote on 06/24/2016 02:24:12 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: Hui Kang/Watson/IBM@IBMUS, Justin Pettit , > Yusheng Wang , dev@openvswitch.org > Date: 06/24/2016 02:24 PM > Subject: Re: [ovs-dev] [OVN] Potential scalability bug in ovn-no

[ovs-dev] [PATCH] [OVN-northd] Rename nbs/nbr to nbsp/nbrp

2016-06-24 Thread Hui Kang
These variables indicate ports in nb switches or routers. Signed-off-by: Hui Kang --- ovn/northd/ovn-northd.c | 196 1 file changed, 98 insertions(+), 98 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 1599e18

Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

2016-06-24 Thread Hui Kang
> > My question is whether there is any particular reason to allocate that > > number > > of (struct ovn_port)? It seems to me there is room in this code to > optimize > > for performance. Thanks. > > > > - Hui > > > > > > [1] > > > https://github.com/openvswitch/ovs/blob/master/ovn/northd/ovn-no

Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

2016-06-24 Thread Hui Kang
Hi, Ryan, Thanks for your comments; reply inline. - Hui Ryan Moats/Omaha/IBM wrote on 06/24/2016 08:12:38 AM: > From: Ryan Moats/Omaha/IBM > To: Hui Kang/Watson/IBM@IBMUS, "Ben Pfaff" , "Justin > Pettit" , "Yusheng Wang" > Cc: dev@openvswitch.org >

[ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

2016-06-23 Thread Hui Kang
Hi, In our scalability test for OVN, we observed an in-scalable behaviour of the ovn-northd process: the time binding a logical port increases as # of large port increasing, regardless of whether logical ports belong to the same logical switch. The most suspicious function in causing this issue is

Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine

2016-06-20 Thread Hui Kang
Yusheng Wang wrote on 06/19/2016 11:12:49 PM: > From: Yusheng Wang > To: Hui Kang/Watson/IBM@IBMUS > Cc: "dev@openvswitch.org" > Date: 06/19/2016 11:13 PM > Subject: Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine > > > > The paper ex

Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine

2016-06-17 Thread Hui Kang
one field name as a, I input the following line and I got this error message +:1:r|1|. Error in format --- Any idea? Thanks. - Hui Yusheng Wang wrote on 06/17/2016 04:30:02 AM: > From: Yusheng Wang > To: Hui

Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine

2016-06-17 Thread Hui Kang
Hui Kang/Watson/IBM wrote on 06/17/2016 11:04:21 AM: > From: Hui Kang/Watson/IBM > To: Yusheng Wang > Cc: Ryan Moats/Omaha/IBM@IBMUS, "dev@openvswitch.org" > Date: 06/17/2016 11:04 AM > Subject: Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine > > &quo

Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine

2016-06-17 Thread Hui Kang
"dev" wrote on 06/16/2016 10:58:58 PM: > From: Yusheng Wang > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: "dev@openvswitch.org" > Date: 06/16/2016 10:59 PM > Subject: Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine > Sent by: "dev" > > > I agree with all your comments but the last one. T

Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine

2016-06-17 Thread Hui Kang
Yusheng Wang wrote on 06/17/2016 04:30:02 AM: > From: Yusheng Wang > To: Hui Kang/Watson/IBM@IBMUS > Cc: "dev@openvswitch.org" > Date: 06/17/2016 04:40 AM > Subject: Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine > > > The idea is to write ovn-n

Re: [ovs-dev] [PATCH V5] Function tracer to trace all function calls

2016-06-14 Thread Hui Kang
Hi, Daniele, I am also interesting in profiling the ovs process and would like to participate in the discussion. I am using oprofile-1.1.0 to profiling the ovn-northd process. I believe oprofile-1.1.0 share the same underlying profiling mechanism as Linux perf (correct me if I am wrong). However

Re: [ovs-dev] [PATCH monitor_cond V7 00/10] Conditional monitor implementation

2016-06-13 Thread Hui Kang
"dev" wrote on 06/13/2016 07:19:25 AM: > From: Liran Schour > To: b...@ovn.org > Cc: d...@openvswitch.com > Date: 06/13/2016 08:29 AM > Subject: [ovs-dev] [PATCH monitor_cond V7 00/10] Conditional monitor > implementation > Sent by: "dev" > > This patch series implements conditional monitorin

[ovs-dev] [PATCH] ovn-architecture.7.xml: Fix ovn-controller behavior in VIF life cycle

2016-06-13 Thread Hui Kang
Signed-off-by: Hui Kang --- ovn/ovn-architecture.7.xml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml index f8a348b..72786bc 100644 --- a/ovn/ovn-architecture.7.xml +++ b/ovn/ovn-architecture.7.xml @@ -382,12

[ovs-dev] [PATCH] Display correct ovnsb sock location in the ovnsb-ctl help message

2016-04-19 Thread Hui Kang
Signed-off-by: Hui Kang --- ovn/utilities/ovn-sbctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c index a257729..a888333 100644 --- a/ovn/utilities/ovn-sbctl.c +++ b/ovn/utilities/ovn-sbctl.c @@ -329,7 +329,7

Re: [ovs-dev] [PATCH] ovn-architecture.7.xml: Clarify the definition of Binding table

2016-03-24 Thread Hui Kang
"dev" wrote on 03/24/2016 03:29:28 PM: > From: Ben Pfaff > To: Hui Kang > Cc: dev@openvswitch.org > Date: 03/24/2016 03:29 PM > Subject: Re: [ovs-dev] [PATCH] ovn-architecture.7.xml: Clarify the > definition of Binding table > Sent by: "dev" > >

[ovs-dev] [PATCH] ovn-architecture.7.xml: Clarify the definition of Binding table

2016-03-24 Thread Hui Kang
For the sake of clarity Signed-off-by: Hui Kang --- ovn/ovn-architecture.7.xml | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml index 13acaf5..a588a0e 100644 --- a/ovn/ovn-architecture.7.xml +++ b/ovn/ovn

Re: [ovs-dev] [PATCH] Use southbound database when saying Binding table

2016-03-23 Thread Hui Kang
-Ben Pfaff wrote: - To: Hui Kang From: Ben Pfaff Date: 03/23/2016 02:22PM Cc: dev@openvswitch.org, Hui Kang/Watson/IBM@IBMUS Subject: Re: [ovs-dev] [PATCH] Use southbound database when saying Binding table On Wed, Mar 23, 2016 at 02:00:32PM -0400, Hui Kang wrote: > For the sake

[ovs-dev] [PATCH] Use southbound database when saying Binding table

2016-03-23 Thread Hui Kang
For the sake of clarity Signed-off-by: Hui Kang --- ovn/ovn-architecture.7.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml index 13acaf5..659c599 100644 --- a/ovn/ovn-architecture.7.xml +++ b/ovn/ovn