___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> nitpick, could we move this deletion to next commit?
Make sense. I moved it.
>
>
> Acked-by: Alex Wang
>
Thanks for the review. Pushed to master.
>
>
>>
>> /* ctl_fatal() also logs the error, so it is preferred in this file. */
>> @@ -250,9 +247,8 @@ struct ctl_table_class {
>> * entry. */
>>
Acked-by: Alex Wang
On Thu, Jul 9, 2015 at 1:27 PM, Andy Zhou wrote:
> This file follows a convention that all static functions are grouped
> towards the beginning, ahead of public functions. Re-arrange the code
> to confirm to this convention. No functional changes.
>
> Signed-off-by: Andy Zh
On Thu, Jul 9, 2015 at 1:27 PM, Andy Zhou wrote:
> Both get_table() and set_cloum() APIs are mostly used within db-ctl-base
> library. This patch makes both private to the library.
>
> Add a new ctl_set_colum() API for library client.
>
> The changes are cleanups. No functional changes.
>
> Signe
Acked-by: Alex Wang
On Thu, Jul 9, 2015 at 1:27 PM, Andy Zhou wrote:
> Instead, client now pass it via the modified ctl_init() API.
>
> Siigned-off-by: Andy Zhou
> ---
> lib/db-ctl-base.c | 8 +++-
> lib/db-ctl-base.h | 8 ++--
> utilities/ovs-vsctl.c | 4 ++--
> vtep/vtep-ctl
Instead, client now pass it via the modified ctl_init() API.
Siigned-off-by: Andy Zhou
---
lib/db-ctl-base.c | 8 +++-
lib/db-ctl-base.h | 8 ++--
utilities/ovs-vsctl.c | 4 ++--
vtep/vtep-ctl.c | 4 ++--
4 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/lib/
This file follows a convention that all static functions are grouped
towards the beginning, ahead of public functions. Re-arrange the code
to confirm to this convention. No functional changes.
Signed-off-by: Andy Zhou
---
lib/db-ctl-base.c | 166 +++--
Minor cleanups in db-ctl-base library, and in prepare for ovsdb join related
changes in the library.
v1->v2:
Drop the first patch that has been committed.
group static functions together
Fix comments
Andy Zhou (3):
db-ctl-base: do not expose get_table() API
db-ctl-base: do not r
Both get_table() and set_cloum() APIs are mostly used within db-ctl-base
library. This patch makes both private to the library.
Add a new ctl_set_colum() API for library client.
The changes are cleanups. No functional changes.
Signed-off-by: Andy Zhou
---
lib/db-ctl-base.c | 15 +++
Thanks for looking again.
I pushed this series without further changes.
On Tue, Feb 15, 2011 at 12:22:16PM -0800, Ethan Jackson wrote:
> Ohh oops, now that I look at it again I misread the code. My bad.
>
> Ethan
>
>
> On Tue, Feb 15, 2011 at 12:17 PM, Ben Pfaff wrote:
> > On Tue, Feb 15, 20
Ohh oops, now that I look at it again I misread the code. My bad.
Ethan
On Tue, Feb 15, 2011 at 12:17 PM, Ben Pfaff wrote:
> On Tue, Feb 15, 2011 at 11:33:42AM -0800, Ethan Jackson wrote:
>> This looks fine to me. However I'm certainty not the worlds best shell
>> programmer.
>>
>> > +
On Tue, Feb 15, 2011 at 11:33:42AM -0800, Ethan Jackson wrote:
> This looks fine to me. However I'm certainty not the worlds best shell
> programmer.
>
> > + elif test "X`ovsdb-tool needs-conversion $conf_file $schema_file`"
> > != Xno; then
> > + # Back up the old version.
> >
This looks fine to me. However I'm certainty not the worlds best shell
programmer.
> + elif test "X`ovsdb-tool needs-conversion $conf_file $schema_file`"
> != Xno; then
> + # Back up the old version.
> + version=`ovsdb-tool db-version "$conf_file"`
> + cksu
On Mon, Feb 14, 2011 at 04:19:42PM -0800, Ethan Jackson wrote:
> I think this is fine. However, we could alternatively always use the
> db-version and the checksum in the backup file name saving the need to
> check if it exists and having the added benefit of consistency. At
> any rate, looks goo
>
> I tested the xenserver version but not the Debian version.
> ---
> debian/openvswitch-switch.init | 13 -
> xenserver/etc_init.d_openvswitch | 15 ---
> 2 files changed, 16 insertions(+), 12 deletions(-)
>
> diff --git a/debian/openvswitch-switch.init b/debian/ope
Looks Good.
On Tue, Feb 8, 2011 at 4:00 PM, Ben Pfaff wrote:
> ---
> ovsdb/ovsdb-tool.1.in | 7 +++
> ovsdb/ovsdb-tool.c | 15 +++
> ovsdb/ovsdb.c | 17 +
> ovsdb/ovsdb.h | 3 +++
> tests/ovsdb-tool.at | 22 ++
>
Looks Good.
On Tue, Feb 8, 2011 at 4:00 PM, Ben Pfaff wrote:
> ---
> ovsdb/SPECS | 4
> ovsdb/ovsdb-tool.1.in | 31 +++
> ovsdb/ovsdb-tool.c | 26 ++
> ovsdb/ovsdb.c | 18 --
> ovsd
Looks Good.
On Tue, Feb 8, 2011 at 4:00 PM, Ben Pfaff wrote:
> This new function saves reading the whole database when only the schema is
> of interest. This commit adapts ovsdb-tool to use it for the "db-version"
> command. Upcoming commits will introduce another caller.
> ---
> ovsdb/file.c
On Wed, Feb 09, 2011 at 12:29:12PM -0800, Ethan Jackson wrote:
> Looks good. Couple of minor comments.
>
> > -\fBca\-cert\fR
> > +\fica-cert\fR
> > ?Specifies a PEM file containing the CA certificate used to verify that
> > ?the virtual switch is connected to a trustworthy controller.
> > ?.PP
>
Looks good. Couple of minor comments.
> -\fBca\-cert\fR
> +\fica-cert\fR
> Specifies a PEM file containing the CA certificate used to verify that
> the virtual switch is connected to a trustworthy controller.
> .PP
\fi should be \fI here.
> -Port commands:\n\
> +Port commands (a bond is con
On Tue, Feb 8, 2011 at 4:02 PM, Ethan Jackson wrote:
> I'll review this series unless someone else really wants to.
But Justin is so *fond* of the database...
--
"I don't normally do acked-by's. I think it's my way of avoiding
getting blamed when it all blows up." Andrew Morton
_
I'll review this series unless someone else really wants to.
Ethan
On Tue, Feb 8, 2011 at 4:00 PM, Ben Pfaff wrote:
> OVSDB has some really nice features for debugging databases, but they
> only work when the database doesn't get compacted before the
> investigation gets started. Until now ever
---
ovsdb/SPECS |4
ovsdb/ovsdb-tool.1.in| 31 +++
ovsdb/ovsdb-tool.c | 26 ++
ovsdb/ovsdb.c| 18 --
ovsdb/ovsdb.h|6 --
tests/ovsdb-execution.at |3 ++-
te
Until now, Open vSwitch "start" has always converted the database to the
current database schema. This compacts the database, which as a side
effect throws away useful information about the transactions that were
executed to bring the database into its current state. This can make
debugging datab
This new function saves reading the whole database when only the schema is
of interest. This commit adapts ovsdb-tool to use it for the "db-version"
command. Upcoming commits will introduce another caller.
---
ovsdb/file.c | 86
ovsdb/
---
ovsdb/ovsdb-tool.1.in |7 +++
ovsdb/ovsdb-tool.c| 15 +++
ovsdb/ovsdb.c | 17 +
ovsdb/ovsdb.h |3 +++
tests/ovsdb-tool.at | 22 ++
5 files changed, 64 insertions(+), 0 deletions(-)
diff --git a/ovsdb/ovsdb
OVSDB has some really nice features for debugging databases, but they
only work when the database doesn't get compacted before the
investigation gets started. Until now every restart or reboot has
compacted the database; this series of patches improves on that.
Ben Pfaff (5):
ovs-vsctl: Improve
---
utilities/ovs-vsctl.8.in |8
utilities/ovs-vsctl.c| 17 ++---
2 files changed, 18 insertions(+), 7 deletions(-)
diff --git a/utilities/ovs-vsctl.8.in b/utilities/ovs-vsctl.8.in
index 5e3ab39..cec7159 100644
--- a/utilities/ovs-vsctl.8.in
+++ b/utilities/ovs-vsct
29 matches
Mail list logo
