dongjoon-hyun commented on a change in pull request #943:
URL: https://github.com/apache/orc/pull/943#discussion_r733289198
##
File path: java/tools/src/test/org/apache/orc/tools/TestFileDump.java
##
@@ -703,4 +703,12 @@ public void testHasNull() throws Exception {
guiyanakuang commented on pull request #915:
URL: https://github.com/apache/orc/pull/915#issuecomment-948207235
I'm posting this comment to show that I haven't forgotten about this pr and
that I still need some time to refactor the code to make it meet expectations.
--
This is an
guiyanakuang commented on a change in pull request #943:
URL: https://github.com/apache/orc/pull/943#discussion_r733277252
##
File path: java/tools/src/test/org/apache/orc/tools/TestFileDump.java
##
@@ -703,4 +703,12 @@ public void testHasNull() throws Exception {
guiyanakuang commented on a change in pull request #943:
URL: https://github.com/apache/orc/pull/943#discussion_r733268269
##
File path: java/tools/src/test/org/apache/orc/tools/TestFileDump.java
##
@@ -703,4 +703,12 @@ public void testHasNull() throws Exception {
dongjoon-hyun commented on a change in pull request #943:
URL: https://github.com/apache/orc/pull/943#discussion_r733126258
##
File path: java/tools/src/test/org/apache/orc/tools/TestFileDump.java
##
@@ -703,4 +703,12 @@ public void testHasNull() throws Exception {
dongjoon-hyun commented on a change in pull request #943:
URL: https://github.com/apache/orc/pull/943#discussion_r733121428
##
File path: java/tools/src/test/org/apache/orc/tools/TestFileDump.java
##
@@ -703,4 +703,12 @@ public void testHasNull() throws Exception {
dongjoon-hyun merged pull request #943:
URL: https://github.com/apache/orc/pull/943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun merged pull request #940:
URL: https://github.com/apache/orc/pull/940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guiyanakuang opened a new pull request #943:
URL: https://github.com/apache/orc/pull/943
### What changes were proposed in this pull request?
This matching algorithm is wrong when i does not backtrack after a failed
match in the middle. As a simple example data = OOORC, pattern=
Yiqun Zhang created ORC-1034:
Summary: The search byte array algorithm is incorrectly
implemented in FileDump.java
Key: ORC-1034
URL: https://issues.apache.org/jira/browse/ORC-1034
Project: ORC
guiyanakuang commented on pull request #941:
URL: https://github.com/apache/orc/pull/941#issuecomment-947395635
> It would be great if we can have more specific PR title instead of `Fix
some bugs`. If you need, you can split the PR into smaller ones.
It might be better to split it
dongjoon-hyun commented on a change in pull request #940:
URL: https://github.com/apache/orc/pull/940#discussion_r732475780
##
File path: java/core/src/test/org/apache/orc/impl/TestEncryption.java
##
@@ -140,4 +145,43 @@ public void testPushDownReadEncryption() throws
dongjoon-hyun commented on a change in pull request #940:
URL: https://github.com/apache/orc/pull/940#discussion_r732475228
##
File path: java/core/src/test/org/apache/orc/impl/TestEncryption.java
##
@@ -140,4 +145,43 @@ public void testPushDownReadEncryption() throws
guiyanakuang commented on a change in pull request #940:
URL: https://github.com/apache/orc/pull/940#discussion_r732474540
##
File path: java/core/src/test/org/apache/orc/impl/TestEncryption.java
##
@@ -140,4 +145,43 @@ public void testPushDownReadEncryption() throws
dongjoon-hyun merged pull request #942:
URL: https://github.com/apache/orc/pull/942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun commented on a change in pull request #940:
URL: https://github.com/apache/orc/pull/940#discussion_r732470615
##
File path: java/core/src/test/org/apache/orc/impl/TestEncryption.java
##
@@ -140,4 +145,43 @@ public void testPushDownReadEncryption() throws
guiyanakuang commented on a change in pull request #942:
URL: https://github.com/apache/orc/pull/942#discussion_r732468542
##
File path: java/tools/src/test/org/apache/orc/tools/convert/TestJsonReader.java
##
@@ -117,10 +117,13 @@ public void testDateTimeTypeSupport() throws
guiyanakuang commented on a change in pull request #941:
URL: https://github.com/apache/orc/pull/941#discussion_r732461971
##
File path: java/tools/src/test/org/apache/orc/tools/TestFileDump.java
##
@@ -703,4 +709,86 @@ public void testHasNull() throws Exception {
dongjoon-hyun commented on a change in pull request #941:
URL: https://github.com/apache/orc/pull/941#discussion_r732459997
##
File path: java/tools/src/test/org/apache/orc/tools/TestFileDump.java
##
@@ -703,4 +709,86 @@ public void testHasNull() throws Exception {
dongjoon-hyun commented on a change in pull request #941:
URL: https://github.com/apache/orc/pull/941#discussion_r732459561
##
File path: java/tools/src/test/org/apache/orc/tools/TestFileDump.java
##
@@ -703,4 +709,86 @@ public void testHasNull() throws Exception {
dongjoon-hyun commented on a change in pull request #942:
URL: https://github.com/apache/orc/pull/942#discussion_r732458591
##
File path: java/tools/src/test/org/apache/orc/tools/convert/TestJsonReader.java
##
@@ -117,10 +117,13 @@ public void testDateTimeTypeSupport() throws
dongjoon-hyun merged pull request #938:
URL: https://github.com/apache/orc/pull/938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Dongjoon Hyun created ORC-1033:
--
Summary: Bump junit.version from 5.8.0 to 5.8.1
Key: ORC-1033
URL: https://issues.apache.org/jira/browse/ORC-1033
Project: ORC
Issue Type: Improvement
dongjoon-hyun merged pull request #939:
URL: https://github.com/apache/orc/pull/939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Dongjoon Hyun created ORC-1032:
--
Summary: Bump parquet.version from 1.12.0 to 1.12.2
Key: ORC-1032
URL: https://issues.apache.org/jira/browse/ORC-1032
Project: ORC
Issue Type: Improvement
25 matches
Mail list logo